Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-01 Thread David Woodhouse
On Sun, 2015-02-01 at 21:07 -0800, David Miller wrote: > From: David Woodhouse > Date: Sun, 01 Feb 2015 21:29:43 + > > > I really was looking for some way to push down something like an XFRM > > state into the tun device and just say "shove them out here until I tell > > you otherwise". > >

Re: [Qemu-devel] [PATCH v4 09/18] spapr_rtas: Reserve DDW RTAS token numbers

2015-02-01 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:21PM +1100, Alexey Kardashevskiy wrote: > Will be squashed later. ? Was this supposed to reach the published series? > > Signed-off-by: Alexey Kardashevskiy > Reviewed-by: David Gibson > --- > include/hw/ppc/spapr.h | 6 +- > 1 file changed, 5 insertions(+),

Re: [Qemu-devel] [PATCH v4 08/18] vfio: Add DMA memory registering

2015-02-01 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:20PM +1100, Alexey Kardashevskiy wrote: > This makes use of the new "memory registering" feature. The idea is > to provide the guest ability to notify the host kernel about pages which > are going to be used for DMA. Having this information, the host kernel > can pin t

[Qemu-devel] [PATCH 4/4] monitor: more accurate completion for host_net_remove()

2015-02-01 Thread Jason Wang
Current completion for host_net_remove will show hub ports and clients that were not peered with hub ports. Fix this. Cc: Luiz Capitulino Signed-off-by: Jason Wang --- monitor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/monitor.c b/monitor.c index 7e4f605..e6dc50a 100644 --- a/mo

[Qemu-devel] [PATCH 2/4] net: remove the wrong comment in net_init_hubport()

2015-02-01 Thread Jason Wang
Not only nic could be the one to peer. Signed-off-by: Jason Wang --- net/hub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/hub.c b/net/hub.c index ef09d5f..2b60ab9 100644 --- a/net/hub.c +++ b/net/hub.c @@ -288,7 +288,6 @@ int net_init_hubport(const NetClientOptions *opts, const char

[Qemu-devel] [PATCH 1/4] monitor: print hub port name during info network

2015-02-01 Thread Jason Wang
Signed-off-by: Jason Wang --- net/hub.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/hub.c b/net/hub.c index 7e0f2d6..ef09d5f 100644 --- a/net/hub.c +++ b/net/hub.c @@ -245,9 +245,12 @@ void net_hub_info(Monitor *mon) QLIST_FOREACH(hub, &hubs, next) {

[Qemu-devel] [PATCH 3/4] net: del hub port when peer is deleted

2015-02-01 Thread Jason Wang
We should del hub port when peer is deleted since it will not be reused and will only be freed during exit. Signed-off-by: Jason Wang --- net/net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/net.c b/net/net.c index 7acc162..74e651e 100644 --- a/net/net.c +++ b/net/net.c @@ -996,6

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-01 Thread Liu Yuan
On Tue, Jan 27, 2015 at 05:35:27PM +0900, Teruaki Ishizaki wrote: > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle "block_size_shift" value for > calculating VDI object size. > > When you start qemu, you don't need to specify additio

Re: [Qemu-devel] [PATCH v4 07/18] spapr_iommu: Implement free_table() helper

2015-02-01 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:19PM +1100, Alexey Kardashevskiy wrote: > Every sPAPRTCETable object holds an IOMMU memory region which holds > a referenced to the sPAPRTCETable instance. So if we want to free > an sPAPRTCETable instance, calling object_unref() will not be enough > as embedded memory

Re: [Qemu-devel] [PATCH v4 02/18] spapr_iommu: Make H_PUT_TCE_INDIRECT endian-safe

2015-02-01 Thread David Gibson
On Thu, Jan 29, 2015 at 08:27:14PM +1100, Alexey Kardashevskiy wrote: > PAPR is defined as big endian so TCEs need an adjustment so > does this patch. > > This changes code to have ldq_be_phys() in one place. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson -- David Gibson

[Qemu-devel] [Bug 1308341] Re: Multiple CPUs causes blue screen on Windows guest (14.04 regression)

2015-02-01 Thread Fred Thoma
*** This bug is a duplicate of bug 1346917 *** https://bugs.launchpad.net/bugs/1346917 Same bluescreen again on day 9 after the kernel upgrade. So upgrading Kernel from 3.13 to 3.16 did not help. Still looking for a fix. -- You received this bug notification because you are a member of qe

Re: [Qemu-devel] [PATCH v4 1/2] spapr: Add pseries-2.3 machine

2015-02-01 Thread David Gibson
On Fri, Jan 30, 2015 at 12:53:18PM +1100, Alexey Kardashevskiy wrote: > The next patch will make MMIO space bigger and keep the old value for > older pseries machines. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson -- David Gibson| I'll have my music bar

Re: [Qemu-devel] [PATCH v4 2/2] spapr-pci: Enable huge BARs

2015-02-01 Thread David Gibson
On Fri, Jan 30, 2015 at 12:53:19PM +1100, Alexey Kardashevskiy wrote: > At the moment sPAPR only supports 512MB window for MMIO BARs. However > modern devices might want bigger 64bit BARs. > > This extends MMIO window from 512MB to 62GB (aligned to > SPAPR_PCI_WINDOW_SPACING) and advertises it in

[Qemu-devel] [PATCH] qmp: unbreak build for non-vnc configuration

2015-02-01 Thread Leon Yu
Signed-off-by: Leon Yu Fixes: df887684603a ("monitor: add query-vnc-servers command") --- qmp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qmp.c b/qmp.c index 963305c..ae55f1e 100644 --- a/qmp.c +++ b/qmp.c @@ -134,6 +134,12 @@ VncInfo *qmp_query_vnc(Error **errp) error_set(er

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-01 Thread David Miller
From: David Woodhouse Date: Sun, 01 Feb 2015 21:29:43 + > I really was looking for some way to push down something like an XFRM > state into the tun device and just say "shove them out here until I tell > you otherwise". People decided to use TUN and push VPN stuff back into userspace, and t

[Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-01 Thread Tiejun Chen
When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,-igd-passthru=on". This need to bring a change on tool side. Signed-off-by: Tiejun Chen --- v2: * Based on some discussions with Wei we'd like

Re: [Qemu-devel] [PATCH] quorum: don't share qiov

2015-02-01 Thread Wen Congyang
On 01/30/2015 09:39 PM, Kevin Wolf wrote: > Am 30.01.2015 um 09:07 hat Wen Congyang geschrieben: >> If the child touches qiov->iov, it will cause unexpected results. >> >> Signed-off-by: Wen Congyang > > Any specific child you're thinking of? > > I think children are not supposed to modify their

Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

2015-02-01 Thread Chen, Tiejun
On 2015/1/30 20:26, Wei Liu wrote: On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote: [...] Just remember to handle old option in libxl if your old option is already released by some older version of QEMUs. I just drop that old option, -gfx_passthru, if we're under qemu upstream ci

Re: [Qemu-devel] [PATCH v1] vhost-user: fix not send all hugepage files to vhost-user

2015-02-01 Thread Paolo Bonzini
On 17/12/2014 07:02, haifeng@huawei.com wrote: > From: linhaifeng > > If we create VM with two or more numa nodes qemu will create two > or more hugepage files but qemu only send one hugepage file fd > to vhost-user when VM's memory size is 2G and with two numa nodes. > > Signed-off-by: li

[Qemu-devel] [Bug 1392504] Re: USB Passthrough is not working anymore

2015-02-01 Thread zebul666
I just installed libvirt 1.2.8 on ubuntu utopic and usb passthrough does not work on a linux vm I got the libusbx error in the livert VM log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1392504 Tit

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-01 Thread David Woodhouse
On Sun, 2015-02-01 at 12:19 -0800, David Miller wrote: > From: David Woodhouse > Date: Sun, 01 Feb 2015 13:33:50 + > > > Of course, now I'm looking closely at the path these packets take to > > leave the box, it starts to offend me that they're being passed up to > > userspace just to encrypt

Re: [Qemu-devel] [PATCH RFC v6 18/20] virtio: support revision-specific features

2015-02-01 Thread Michael S. Tsirkin
On Fri, Jan 30, 2015 at 03:08:08PM +0100, Cornelia Huck wrote: > On Wed, 7 Jan 2015 21:10:07 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jan 07, 2015 at 05:22:32PM +0100, Cornelia Huck wrote: > > > On Sun, 28 Dec 2014 10:32:06 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu,

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-01 Thread David Miller
From: David Woodhouse Date: Sun, 01 Feb 2015 13:33:50 + > Of course, now I'm looking closely at the path these packets take to > leave the box, it starts to offend me that they're being passed up to > userspace just to encrypt them (as DTLS or ESP) and then send them back > down to the kernel

Re: [Qemu-devel] [PATCHv2 1/2] m48t59: introduce new year_offset qdev property

2015-02-01 Thread Hervé Poussineau
Le 01/02/2015 19:39, Mark Cave-Ayland a écrit : Currently the m48t59 device uses the hardware model in order to determine whether the year value is offset from the hardware value. As this will soon be required by the x59 model, change the year offset to a qdev property and update the callers appr

[Qemu-devel] [PATCHv2 1/2] m48t59: introduce new year_offset qdev property

2015-02-01 Thread Mark Cave-Ayland
Currently the m48t59 device uses the hardware model in order to determine whether the year value is offset from the hardware value. As this will soon be required by the x59 model, change the year offset to a qdev property and update the callers appropriately. Signed-off-by: Mark Cave-Ayland ---

[Qemu-devel] [PATCHv2 2/2] m48t59: add m48t59 sysbus device

2015-02-01 Thread Mark Cave-Ayland
This is for subsequent use by the sun4u machine. Signed-off-by: Mark Cave-Ayland --- hw/timer/m48t59.c |4 1 file changed, 4 insertions(+) diff --git a/hw/timer/m48t59.c b/hw/timer/m48t59.c index ec420bd..84701ec 100644 --- a/hw/timer/m48t59.c +++ b/hw/timer/m48t59.c @@ -129,6 +129,10

[Qemu-devel] [PATCHv2 0/2] m48t59: add year offset and sysbus device

2015-02-01 Thread Mark Cave-Ayland
This patch lays the groundwork for switching sun4u over from ioport NVRAM access to MMIO NVRAM access. Patch 1 introduces a new year_offset property which is the offset between the year value stored in hardware and the actual year. In particular, Sun hardware has a 68 year offset used to extend th

Re: [Qemu-devel] [PATCH 0/4] timer/m48t59: QOM'ify

2015-02-01 Thread Mark Cave-Ayland
On 19/01/15 21:59, Hervé Poussineau wrote: > Hi, > > This patchset QOM'ifies the m48t59 timer. > Patch 1 allows the creation of the m4859 ISA device from the command line. > Patch 2 QOM'ifies the device. > Patches 3 add a Nvram interface to m48txx devices, so that callers can > detect the device

Re: [Qemu-devel] [PATCH v2 0/7] isa: remove isa_mem_base variable

2015-02-01 Thread Mark Cave-Ayland
On 01/02/15 08:12, Hervé Poussineau wrote: > Hi, > > This patchset removes the isa_mem_base variable in VGA display devices. > This variable is a global variable telling at which address is the > ISA memory base address in the system memory address space. > > Once removed, we're paving the way t

Re: [Qemu-devel] [PATCH] vfio-pci: unparent BAR subregions

2015-02-01 Thread Alex Williamson
On Sat, 2015-01-31 at 21:47 +0100, Paolo Bonzini wrote: > > On 31/01/2015 16:10, Alex Williamson wrote: > >> Explicit object_unparent() is only needed if you recreate the memory > >> region during the lifetime of the object. This is rarely needed, and it > >> is simple to spot if it's needed. If

[Qemu-devel] [PATCH v2] vfio-pci: Fix missing unparent of dynamically allocated MemoryRegion

2015-02-01 Thread Alex Williamson
Commit d8d95814609e added explicit object_unparent() calls for dynamically allocated MemoryRegions. The VFIOMSIXInfo structure also contains such a MemoryRegion, covering the mmap'd region of a PCI BAR above the MSI-X table. This structure is freed as part of the class exit function and therefore

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-01 Thread David Woodhouse
On Sun, 2015-02-01 at 14:26 +0200, Michael S. Tsirkin wrote: > > When I run over the VPN, netperf thinks it sent 2½ times the amount of > > TX traffic. > > At some level, it's expected: netperf's manual actually says: > A UDP_STREAM test has no end-to-end flow control - UDP provides none and

Re: [Qemu-devel] [PATCH V11 2/3] i386: Add a Virtual Machine Generation ID device

2015-02-01 Thread Gal Hammer
On 22/01/2015 15:52, Igor Mammedov wrote: On Tue, 16 Dec 2014 17:50:43 +0200 Gal Hammer wrote: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709), add a device description to the SSDT ACPI table and its implementation. The GUID is

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-01 Thread Michael S. Tsirkin
On Sun, Feb 01, 2015 at 11:20:33AM +, David Woodhouse wrote: > On Wed, 2010-04-14 at 08:58 +0800, Herbert Xu wrote: > > On Tue, Apr 13, 2010 at 08:31:03PM +0200, Eric Dumazet wrote: > > > > > > Herbert Acked your patch, so I guess its OK, but I think it can be > > > dangerous. > > > > The tun

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-01 Thread David Woodhouse
On Wed, 2010-04-14 at 08:58 +0800, Herbert Xu wrote: > On Tue, Apr 13, 2010 at 08:31:03PM +0200, Eric Dumazet wrote: > > > > Herbert Acked your patch, so I guess its OK, but I think it can be > > dangerous. > > The tun socket accounting was never designed to stop it from > flooding another tun int

[Qemu-devel] [PATCH v2 7/7] isa: remove isa_mem_base variable

2015-02-01 Thread Hervé Poussineau
Now that isa_mem_base variable is always 0, we can remove its usage. Signed-off-by: Hervé Poussineau --- hw/display/cirrus_vga.c |2 +- hw/display/vga-isa.c|2 +- hw/display/vga.c|3 +-- hw/isa/isa-bus.c|1 - include/hw/isa/isa.h|2 -- 5 files changed,

[Qemu-devel] [PATCH v2 6/7] gt64xxx: remove isa_mem_base usage

2015-02-01 Thread Hervé Poussineau
Create a custom address space for PCI memory region and use it for the PCI bus. Dynamically handle PCI0 Mem0 and PCI0 Mem1 regions, as already done for PCI0 IO. Signed-off-by: Hervé Poussineau --- hw/mips/gt64xxx_pci.c | 95 +++-- 1 file changed, 68

[Qemu-devel] [PATCH v2 4/7] mips: remove isa_mem_base usage

2015-02-01 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/mips/mips_r4k.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c index 5b982f2..3e90e27 100644 --- a/hw/mips/mips_r4k.c +++ b/hw/mips/mips_r4k.c @@ -165,7 +165,8 @@ void mips_r

[Qemu-devel] [PATCH v2 3/7] jazz: remove usage of isa_mem_base

2015-02-01 Thread Hervé Poussineau
Do assorted changes in memory-mapped rtc interface. Also fix size of ISA I/O memory region, which should be 0x1 bytes. Signed-off-by: Hervé Poussineau --- hw/mips/mips_jazz.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/mips/mips_jazz.

[Qemu-devel] [PATCH v2 1/7] isa: add memory space parameter to isa_bus_new

2015-02-01 Thread Hervé Poussineau
Currently, keep current behaviour by always using get_system_memory(). Also use QOM casts when possible. Signed-off-by: Hervé Poussineau Reviewed-by: Paolo Bonzini --- hw/alpha/typhoon.c |2 +- hw/i386/pc_piix.c|2 +- hw/isa/i82378.c |3 ++- hw/isa/isa-bus.c | 11 +

[Qemu-devel] [PATCH v2 0/7] isa: remove isa_mem_base variable

2015-02-01 Thread Hervé Poussineau
Hi, This patchset removes the isa_mem_base variable in VGA display devices. This variable is a global variable telling at which address is the ISA memory base address in the system memory address space. Once removed, we're paving the way to new QEMU functionalities: - supporting other MMIO ISA de

[Qemu-devel] [PATCH v2 5/7] piix4: use PCI address space instead of system memory

2015-02-01 Thread Hervé Poussineau
piix4 is only used on MIPS Malta board, which gives get_system_memory() to pci_register_bus(). Signed-off-by: Hervé Poussineau --- hw/isa/piix4.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index 0cacc3b..a9916df 100644 --- a/hw/isa/piix

[Qemu-devel] [PATCH v2 2/7] jazz: do not explode QEMUMachineInitArgs structure

2015-02-01 Thread Hervé Poussineau
Also remove address_space and address_space_io parameters, which where always get_system_memory() and get_system_io(). Signed-off-by: Hervé Poussineau --- hw/mips/mips_jazz.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/hw/mips/mips_jazz.c b/hw/mip