Re: [Qemu-devel] [RFC PATCH 10/11] hw/arm/virt-acpi-build: Generation of DSDT table for virt devices

2015-01-26 Thread Shannon Zhao
On 2015/1/26 18:40, Igor Mammedov wrote: > On Sat, 24 Jan 2015 17:21:19 +0800 > Shannon Zhao wrote: > >> > DSDT consists of the usual common table header plus a definition >> > block in AML encoding which describes all devices in the platform. >> > >> > After initializing DSDT with header inform

Re: [Qemu-devel] [RFC PATCH 02/11] hw/arm/virt-acpi-build: Basic framework for building ACPI tables

2015-01-26 Thread Shannon Zhao
On 2015/1/26 18:19, Igor Mammedov wrote: > On Sat, 24 Jan 2015 17:21:11 +0800 > Shannon Zhao wrote: > >> Introduce a preliminary framework in virt-acpi-build.c with the main >> ACPI build functions. It exposes the generated ACPI contents to >> guest over fw_cfg. Some codes borrowed from hw/i386/a

Re: [Qemu-devel] [RFC PATCH 03/11] hw/arm/virt-acpi-build: Generate RSDP table

2015-01-26 Thread Shannon Zhao
On 2015/1/26 18:22, Igor Mammedov wrote: > On Sat, 24 Jan 2015 17:21:12 +0800 > Shannon Zhao wrote: > >> > RSDP points to XSDT which in turn points to other tables. >> > >> > Signed-off-by: Shannon Zhao >> > --- >> > hw/arm/virt-acpi-build.c | 22 ++ >> > 1 files changed,

Re: [Qemu-devel] [PATCH v3 0/6] Some PCI related cleanup patches

2015-01-26 Thread Hu Tao
On Wed, Jan 21, 2015 at 02:00:58PM +0200, Michael S. Tsirkin wrote: > On Wed, Jan 21, 2015 at 02:41:33PM +0800, Hu Tao wrote: > > ping... > > At some point you said "will resend". I meant resend patch 6. Patches 1-5 can still apply cleanly. Regards, Hu > > > On Thu, Dec 11, 2014 at 10:20:22AM

Re: [Qemu-devel] [PATCH v3 6/6] pci: introduce PCI_DEVFN_AUTO

2015-01-26 Thread Hu Tao
On Wed, Jan 21, 2015 at 02:00:02PM +0200, Michael S. Tsirkin wrote: > On Thu, Dec 11, 2014 at 10:20:28AM +0800, Hu Tao wrote: > > Introduce PCI_DEVFN_AUTO rather than using -1 in code. > > > > Signed-off-by: Hu Tao > > --- > > hw/core/qdev-properties.c | 1 + > > hw/pci/pci.c | 5 ++

[Qemu-devel] [PATCH v2] spapr_vio/spapr_iommu: Move VIO bypass where it belongs

2015-01-26 Thread Alexey Kardashevskiy
Instead of tweaking a TCE table device by adding there a bypass flag, let's add an alias to RAM and IOMMU memory region, and enable/disable those according to the selected bypass mode. This way IOMMU memory region can have size of the actual window rather than ram_size which is essential for upcomi

Re: [Qemu-devel] [PATCH v4 08/17] spapr_events: re-use EPOW event infrastructure for hotplug events

2015-01-26 Thread David Gibson
On Mon, Jan 26, 2015 at 10:56:51AM -0600, Michael Roth wrote: > Quoting David Gibson (2015-01-18 22:31:23) > > On Tue, Dec 23, 2014 at 06:30:22AM -0600, Michael Roth wrote: > > > From: Nathan Fontenot [snip] > > > +static void spapr_hotplug_req_event(sPAPRDRConnector *drc, uint8_t > > > hp_action

Re: [Qemu-devel] [PATCH v4 10/17] spapr_drc: add spapr_drc_populate_dt()

2015-01-26 Thread David Gibson
On Mon, Jan 26, 2015 at 02:35:58PM -0600, Michael Roth wrote: > Quoting David Gibson (2015-01-18 23:15:28) > > On Tue, Dec 23, 2014 at 06:30:24AM -0600, Michael Roth wrote: [snip] > > > +/* generate a human-readable name for a DRC to encode into the DT > > > + * description. this is mainly only use

Re: [Qemu-devel] [PATCH v4 16/17] spapr_pci: enable basic hotplug operations

2015-01-26 Thread David Gibson
On Mon, Jan 26, 2015 at 03:17:31PM -0600, Michael Roth wrote: > Quoting David Gibson (2015-01-18 23:58:28) > > On Tue, Dec 23, 2014 at 06:30:30AM -0600, Michael Roth wrote: [snip] > > > +/* create OF node for pci device and required OF DT properties */ > > > +static void *spapr_create_pci_child_dt(

Re: [Qemu-devel] [PATCH v4 03/17] spapr_rtas: add get/set-power-level RTAS interfaces

2015-01-26 Thread David Gibson
On Sun, Jan 25, 2015 at 11:21:26PM -0600, Michael Roth wrote: > Quoting David Gibson (2015-01-16 00:21:55) > > On Tue, Dec 23, 2014 at 06:30:17AM -0600, Michael Roth wrote: > > > From: Nathan Fontenot > > > > > > Signed-off-by: Nathan Fontenot > > > Signed-off-by: Michael Roth > > > --- > > >

Re: [Qemu-devel] [PATCH v2 0/1] dataplane vs. endianness

2015-01-26 Thread David Gibson
On Mon, Jan 26, 2015 at 05:26:41PM +0100, Cornelia Huck wrote: > Stefan: > > Here's v2 of my endianness patch for dataplane, with the extraneous > vdev argument dropped from get_desc(). > > I orginally planned to send my virtio-1 patchset as well, but I haven't > found the time for it; therefore,

Re: [Qemu-devel] [PATCH v3 08/14] qemu-nbd: Use blk_new_open() in main()

2015-01-26 Thread Eric Blake
On 01/26/2015 08:00 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > qemu-nbd.c | 25 + > 1 file changed, 9 insertions(+), 16 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvi

Re: [Qemu-devel] [PATCH v4 37/47] Page request: Consume pages off the post-copy queue

2015-01-26 Thread David Gibson
On Wed, Jan 14, 2015 at 08:13:27PM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Fri, Oct 03, 2014 at 06:47:43PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > When transmitting RAM pages, consum

Re: [Qemu-devel] [PATCH v4 43/47] Host page!=target page: Cleanup bitmaps

2015-01-26 Thread David Gibson
On Wed, Dec 17, 2014 at 06:21:34PM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Fri, Oct 03, 2014 at 06:47:49PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Prior to the start of postcopy, ens

Re: [Qemu-devel] [PATCH v4 44/47] Postcopy; Handle userfault requests

2015-01-26 Thread David Gibson
On Mon, Jan 05, 2015 at 05:13:50PM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Fri, Oct 03, 2014 at 06:47:50PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > userfaultfd is a Linux syscall that

Re: [Qemu-devel] [PATCH 1/2] hw/ppc/spapr.c Set default boot order

2015-01-26 Thread Nikunj A Dadhania
Alexander Graf writes: > On 23.01.15 23:51, dval...@suse.de wrote: >> From: Dinar Valeev >> >> In order to use -boot once=X option we need to have default list >> where restore to on reset. >> >> Signed-off-by: Dinar Valeev > > Alexey, Nijunj, where is the default boot order stored usually?

[Qemu-devel] [PATCH v2 3/3] pc-dimm: Add Error argument to pc_existing_dimms_capacity

2015-01-26 Thread Bharata B Rao
Now that pc_existing_dimms_capacity() is an API, include Error pointer as an argument and modify the caller appropriately. Suggested-by: Igor Mammedov Signed-off-by: Bharata B Rao --- hw/i386/pc.c | 4 ++-- hw/mem/pc-dimm.c | 32 ++-- include/hw/

[Qemu-devel] [PATCH v2 2/3] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-26 Thread Bharata B Rao
Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed by PowerPC memory hotplug code too. Signed-off-by: Bharata B Rao Reviewed-by: Igor Mammedov --- hw/i386/pc.c | 24 hw/mem/pc-dimm.c | 25 + include/hw/mem

[Qemu-devel] [PATCH v2 1/3] pc: Fix DIMMs capacity calculation

2015-01-26 Thread Bharata B Rao
pc_existing_dimms_capacity() is returning DIMMs count rather than capacity. Fix this to return the capacity. Also consider only realized devices for capacity calculation. Signed-off-by: Bharata B Rao Reviewed-by: Igor Mammedov --- hw/i386/pc.c | 26 ++ 1 file changed, 10

[Qemu-devel] [PATCH v2 0/3] Fix pc DIMMs capacity calculation

2015-01-26 Thread Bharata B Rao
This is the v2 of the patchset that fixes pc DIMMs capacity calculation and makes pc_existing_dimms_capacity() an API. Changes in v2 - - Removed an un-needed header inclusion. v1: http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg03011.html v0: http://lists.gnu.org/archive/html/

Re: [Qemu-devel] [PATCH v3] sheepdog: selectable object size support

2015-01-26 Thread Teruaki Ishizaki
(2015/01/26 19:33), Kevin Wolf wrote: Am 26.01.2015 um 10:52 hat Teruaki Ishizaki geschrieben: Hi, Kevin Thanks for your review! (2015/01/23 22:53), Kevin Wolf wrote: Am 23.01.2015 um 09:24 hat Teruaki Ishizaki geschrieben: Previously, qemu block driver of sheepdog used hard-coded VDI object

Re: [Qemu-devel] [PATCH v3 07/14] qemu-img: Use BlockBackend as far as possible

2015-01-26 Thread Eric Blake
On 01/26/2015 08:00 AM, Max Reitz wrote: > Although qemu-img already creates BlockBackends, it does not do accesses > to the images through them. This patch converts all of the bdrv_* calls > for which this is currently possible to blk_* calls. Most of the > remaining calls will probably stay bdrv_

Re: [Qemu-devel] [RFC] optimization for qcow2 cache get/put

2015-01-26 Thread Zhang Haoyu
On 2015-01-27 09:24:13, Zhang Haoyu wrote: > > On 2015-01-26 22:11:59, Max Reitz wrote: > >On 2015-01-26 at 08:20, Zhang Haoyu wrote: >> > Hi, all > > > > > > Regarding too large qcow2 image, e.g., 2TB, > > > so long disruption happened when performing snapshot, > >> which was caused by cache upd

[Qemu-devel] Ping [PATCH v2] Fix irq route entries exceed KVM_MAX_IRQ_ROUTES

2015-01-26 Thread 马文霜
Ping Patches here: http://patchwork.ozlabs.org/patch/426888/ Description: In multi-core guest, set irq affinity will eventually lead to guest crash. This BUG can be reproduced easily. Wenshuang Ma

Re: [Qemu-devel] [PATCH v3 06/14] qemu-img: Use blk_new_open() in img_rebase()

2015-01-26 Thread Eric Blake
On 01/26/2015 08:00 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > qemu-img.c | 57 - > 1 file changed, 24 insertions(+), 33 deletions(-) > > - > /* For safe rebasing we need to compare old and new backing file */ > if (

Re: [Qemu-devel] [PATCH v5 5/5] qemu-iotests: Add 093 for IO throttling

2015-01-26 Thread Fam Zheng
On Mon, 01/26 15:45, Max Reitz wrote: > On 2015-01-16 at 03:46, Fam Zheng wrote: > >This case utilizes qemu-io command "aio_{read,write} -q" to verify the > >effectiveness of IO throttling options. > > > >It's implemented by driving the vm timer from qtest protocol, so the > >throttling timers are

Re: [Qemu-devel] [PATCH 2/2] bootdevice: update boot_order in MachineState

2015-01-26 Thread Gonglei
On 2015/1/27 7:52, dval...@suse.de wrote: > From: Dinar Valeev > > on sPAPR we need to update boot_order in MachineState in case it > got changed on reset. > > Signed-off-by: Dinar Valeev > --- > bootdevice.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/bootdevice.c b/bootdevi

Re: [Qemu-devel] Update boot_order on reset for sPAPR

2015-01-26 Thread Alexey Kardashevskiy
On 01/27/2015 10:52 AM, dval...@suse.de wrote: > This is cleaner attempt to fix -boot once=X behaviour on sPAPR > > qemu-system-ppc64 -m 1024 -enable-kvm -boot once=d -vga none -nographic > Ready! > 0 > dev /chosen ok > 0 > .properties > stdout 3e512100 > > ib

Re: [Qemu-devel] Submit your Google Summer of Code project ideas and volunteer to mentor

2015-01-26 Thread Fam Zheng
On Fri, 01/23 17:21, Stefan Hajnoczi wrote: > Dear libvirt, KVM, and QEMU contributors, > The Google Summer of Code season begins soon and it's time to collect > our thoughts for mentoring students this summer working full-time on > libvirt, KVM, and QEMU. > > What is GSoC? > Google Summer of Code

Re: [Qemu-devel] [PATCH v3 03/14] blockdev: Use blk_new_open() in blockdev_init()

2015-01-26 Thread Max Reitz
On 2015-01-26 at 17:37, Eric Blake wrote: On 01/26/2015 08:00 AM, Max Reitz wrote: Due to different error propagation, this breaks tests 051 and 087; fix their output. Signed-off-by: Max Reitz --- blockdev.c | 92 +- tests/qemu-iot

[Qemu-devel] [PATCH 1/4] iotests: Fix 083

2015-01-26 Thread Max Reitz
As of 8f9e835fd2e687d2bfe936819c3494af4343614d, probing should be disabled in the qemu-iotests (at least when using qemu-io). This broke 083's reference output (which consisted mostly of "Could not read image for determining its format"). This patch fixes it. Note that one case which failed befor

[Qemu-devel] [PATCH 4/4] nbd: Improve error messages

2015-01-26 Thread Max Reitz
This patch makes use of the Error object for nbd_receive_negotiate() so that errors during negotiation look nicer. Furthermore, this patch adds an additional error message if the received magic was wrong, but would be correct for the other protocol version, respectively: So if an export name was s

[Qemu-devel] [PATCH 2/4] iotests: Fix 100 for nbd

2015-01-26 Thread Max Reitz
In case of NBD, _make_test_img starts a new NBD server. Therefore, _cleanup_test_img (which shuts that server down) has to be invoked before the next _make_test_img call in order to make 100 work for NBD. Signed-off-by: Max Reitz --- tests/qemu-iotests/100 | 12 1 file changed, 12 i

[Qemu-devel] [PATCH 3/4] iotests: Fix 104 for NBD

2015-01-26 Thread Max Reitz
_make_test_img sets up an NBD server, _cleanup_test_img shuts it down; thus, _cleanup_test_img has to be called before _make_test_img is invoked another time. Furthermore, the pipe through _filter_test_img was unnecessary; _make_test_img already takes care of that. And finally, a filter is added

[Qemu-devel] [PATCH 0/4] nbd: iotest fixes and error message improvement

2015-01-26 Thread Max Reitz
This series is a follow-up to my previous patch "iotests: Specify format for qemu-nbd" and as such relies on it. The first three patches of this series fix the qemu-iotests so they once again pass when using NBD. The fourth patch of this series improves NBD's error message for establishing connec

Re: [Qemu-devel] [PATCH v2 00/11] cpu: add i386 cpu hot remove support

2015-01-26 Thread Zhu Guihua
On Mon, 2015-01-26 at 12:27 +0100, Alexandre DERUMIER wrote: > >>About this, I can do it successfully on my qemu. > >>So can you tell us more information about your operation? > simply start with > > -smp 2,sockets=2,cores=2,maxcpus=4 -device kvm64-x86_64-cpu,apic-id=2,id=cpu2 > > then > > #de

Re: [Qemu-devel] [RFC] optimization for qcow2 cache get/put

2015-01-26 Thread Zhang Haoyu
On 2015-01-26 22:11:59, Max Reitz wrote: >On 2015-01-26 at 08:20, Zhang Haoyu wrote: > > Hi, all > > > > Regarding too large qcow2 image, e.g., 2TB, > > so long disruption happened when performing snapshot, >> which was caused by cache update and IO wait. > > perf top data shown as below, > >

[Qemu-devel] [PATCH 2/2] bootdevice: update boot_order in MachineState

2015-01-26 Thread dvaleev
From: Dinar Valeev on sPAPR we need to update boot_order in MachineState in case it got changed on reset. Signed-off-by: Dinar Valeev --- bootdevice.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bootdevice.c b/bootdevice.c index 5914417..4f11a06 100644 --- a/bootdevice.c +++ b/bootd

[Qemu-devel] [PATCH 1/2] sPAPR: reread boot_device on reset

2015-01-26 Thread dvaleev
From: Dinar Valeev Update boot_device on reset. This is required to have -boot once=X working. This patch is moving creating fdt qemu,boot-device entry from spapr_create_fdt_skel to spapr_finalize_fdt which is used on guest reset. Signed-off-by: Dinar Valeev --- hw/ppc/spapr.c | 18 ++

[Qemu-devel] Update boot_order on reset for sPAPR

2015-01-26 Thread dvaleev
This is cleaner attempt to fix -boot once=X behaviour on sPAPR qemu-system-ppc64 -m 1024 -enable-kvm -boot once=d -vga none -nographic Ready! 0 > dev /chosen ok 0 > .properties stdout 3e512100 ibm,architecture-vec-5 0080 qemu,boot-device

Re: [Qemu-devel] [PATCH 11/11] target-arm: Fix brace style in reindented code

2015-01-26 Thread Greg Bellows
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell wrote: > This patch fixes the brace style in the code reindented in the > previous commit. > > Signed-off-by: Peter Maydell > --- > target-arm/helper.c | 36 +++- > 1 file changed, 23 insertions(+), 13 deletions(-)

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other

2015-01-26 Thread Chen Gang S
On 1/26/15 23:01, Peter Maydell wrote: > On 26 January 2015 at 14:59, Chen Gang S wrote: >> On 1/26/15 06:10, Peter Maydell wrote: >>> I would just like the commit message to be clear about the >>> scope of the work the patch covers. If the patch is just "Fix >>> mismatched lock/unlock calls in IP

Re: [Qemu-devel] [PATCH 10/11] target-arm: Reindent ancient page-table-walk code

2015-01-26 Thread Greg Bellows
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell wrote: > A few of the oldest parts of the page-table-walk code have broken indent > (either hardcoded tabs or two-spaces). Reindent these sections. > > For ease of review, this patch does not touch the brace style and > so is a whitespace-only chang

Re: [Qemu-devel] [PATCH v3 05/14] qemu-img: Use blk_new_open() in img_open()

2015-01-26 Thread Eric Blake
On 01/26/2015 08:00 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > qemu-img.c | 20 ++-- > 1 file changed, 6 insertions(+), 14 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.or

Re: [Qemu-devel] [PATCH v3 04/14] block/xen: Use blk_new_open() in blk_connect()

2015-01-26 Thread Eric Blake
On 01/26/2015 08:00 AM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > hw/block/xen_disk.c | 28 > 1 file changed, 12 insertions(+), 16 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library

Re: [Qemu-devel] [PATCH v3 03/14] blockdev: Use blk_new_open() in blockdev_init()

2015-01-26 Thread Eric Blake
On 01/26/2015 08:00 AM, Max Reitz wrote: > Due to different error propagation, this breaks tests 051 and 087; fix > their output. > > Signed-off-by: Max Reitz > --- > blockdev.c | 92 > +- > tests/qemu-iotests/051.out | 60

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2015-01-26 Thread Tony Breeds
** Changed in: cinder Assignee: (unassigned) => Tony Breeds (o-tony) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: qemu-img convert intermittently corrupts output images Status

Re: [Qemu-devel] [PATCHv2 7/7] openpic: fix up loadvm under -M mac99

2015-01-26 Thread Mark Cave-Ayland
On 22/01/15 13:39, Alexander Graf wrote: > On 21.01.15 17:01, Mark Cave-Ayland wrote: >> Issuing loadvm under -M mac99 would fail for two reasons: firstly an >> incorrect >> version number for openpic would cause openpic_load() to abort, and secondly >> a cut/paste error when restoring the IVPR a

Re: [Qemu-devel] [PATCH 05/11] target-arm: Use correct mmu_idx for unprivileged loads and stores

2015-01-26 Thread Greg Bellows
On Mon, Jan 26, 2015 at 2:37 PM, Peter Maydell wrote: > On 26 January 2015 at 19:34, Greg Bellows wrote: > > On Mon, Jan 26, 2015 at 8:56 AM, Peter Maydell > > > wrote: > >> Because that's what the ARM ARM specifies. Compare C3.2.5 (A64 LDT &c) > >> with F7.1.95 (A32/T32 LDRT). > > > > > > I ha

Re: [Qemu-devel] [PATCH v3 02/14] block: Add blk_new_open()

2015-01-26 Thread Eric Blake
On 01/26/2015 08:00 AM, Max Reitz wrote: > blk_new_with_bs() creates a BlockBackend with an empty BlockDriverState > attached to it. Empty BDSs are not nice, therefore add an alternative > function which combines blk_new_with_bs() with bdrv_open(). > > Note: In contrast to bdrv_open() which takes

Re: [Qemu-devel] [PATCH 08/11] target-arm: Pass mmu_idx to get_phys_addr()

2015-01-26 Thread Peter Maydell
On 26 January 2015 at 21:41, Greg Bellows wrote: > The above cases would be more readable if each case had a comment > identifying the corresponding AT instruction. Just faster for reference > purposes. Makes sense; will add them in v2. -- PMM

[Qemu-devel] QEMU: DBT vs. Interpretation

2015-01-26 Thread Javier Picorel
Hi, We are trying to make QEMU deterministic for architectural simulation. In the absence of I/O, let’s say only executing user code or exceptions, is there any source of indeterminism (e.g., non deterministic compiler optimizations, TB indeterminism) of QEMU’s DBT versus a canonical interpre

Re: [Qemu-devel] [PATCHv2 5/7] target-ppc: force update of msr bits in cpu_post_load

2015-01-26 Thread Alexander Graf
> Am 26.01.2015 um 22:41 schrieb Mark Cave-Ayland > : > >> On 22/01/15 13:37, Alexander Graf wrote: >> >>> On 21.01.15 17:01, Mark Cave-Ayland wrote: >>> Since env->msr has already been restored by the time cpu_post_load is >>> called, >>> make sure that ppc_store_msr() is explicitly called

Re: [Qemu-devel] [PATCH v3 01/14] block: Lift some BDS functions to the BlockBackend

2015-01-26 Thread Eric Blake
On 01/26/2015 08:00 AM, Max Reitz wrote: > Create the blk_* counterparts for the following bdrv_* functions (which > make sense to call on the BlockBackend level): > - bdrv_co_write_zeroes() > - bdrv_write_compressed() > - bdrv_truncate() > - bdrv_discard() > - bdrv_load_vmstate() > - bdrv_save_vms

Re: [Qemu-devel] [PATCH 08/11] target-arm: Pass mmu_idx to get_phys_addr()

2015-01-26 Thread Greg Bellows
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell wrote: > Make all the callers of get_phys_addr() pass it the correct > mmu_idx rather than just a simple "is_user" flag. This includes > properly decoding the AT/ATS system instructions; we include the > logic for handling all the opc1/opc2 cases be

Re: [Qemu-devel] [PATCH v4 10/17] spapr_drc: add spapr_drc_populate_dt()

2015-01-26 Thread Michael Roth
Quoting David Gibson (2015-01-18 23:15:28) > On Tue, Dec 23, 2014 at 06:30:24AM -0600, Michael Roth wrote: > > This function handles generation of ibm,drc-* array device tree > > properties to describe DRC topology to guests. This will by used > > by the guest to direct RTAS calls to manage any dyn

Re: [Qemu-devel] [PATCH v4 16/17] spapr_pci: enable basic hotplug operations

2015-01-26 Thread Michael Roth
Quoting Alexey Kardashevskiy (2015-01-22 23:17:21) > On 12/23/2014 11:30 PM, Michael Roth wrote: > > This enables hotplug for PHB bridges. Upon hotplug we generate the > > OF-nodes required by PAPR specification and IEEE 1275-1994 > > "PCI Bus Binding to Open Firmware" for the device. > > > > We a

Re: [Qemu-devel] [PATCH v4 16/17] spapr_pci: enable basic hotplug operations

2015-01-26 Thread Michael Roth
Quoting David Gibson (2015-01-18 23:58:28) > On Tue, Dec 23, 2014 at 06:30:30AM -0600, Michael Roth wrote: > > This enables hotplug for PHB bridges. Upon hotplug we generate the > > OF-nodes required by PAPR specification and IEEE 1275-1994 > > "PCI Bus Binding to Open Firmware" for the device. > >

Re: [Qemu-devel] [PATCHv2 5/7] target-ppc: force update of msr bits in cpu_post_load

2015-01-26 Thread Mark Cave-Ayland
On 22/01/15 13:37, Alexander Graf wrote: > On 21.01.15 17:01, Mark Cave-Ayland wrote: >> Since env->msr has already been restored by the time cpu_post_load is called, >> make sure that ppc_store_msr() is explicitly called with all msr bits except >> MSR_TGPR marked as invalid. >> >> This solves th

Re: [Qemu-devel] [PATCH v4 17/17] spapr_pci: emit hotplug add/remove events during hotplug

2015-01-26 Thread Michael Roth
Quoting David Gibson (2015-01-19 00:00:00) > On Tue, Dec 23, 2014 at 06:30:31AM -0600, Michael Roth wrote: > > From: Tyrel Datwyler > > > > This uses extension of existing EPOW interrupt/event mechanism > > to notify userspace tools like librtas/drmgr to handle > > in-guest configuration/cleanup

Re: [Qemu-devel] [PATCH v4 14/17] spapr_pci: populate DRC dt entries for PHBs

2015-01-26 Thread Michael Roth
Quoting David Gibson (2015-01-18 23:22:54) > On Tue, Dec 23, 2014 at 06:30:28AM -0600, Michael Roth wrote: > > Reserve 32 entries of type PCI in each PHB's initial FDT. This > > advertises to guests that each PHB is DR-capable device with > > physical hotpluggable slots. This is necessary for allow

Re: [Qemu-devel] [PATCH v4 08/17] spapr_events: re-use EPOW event infrastructure for hotplug events

2015-01-26 Thread Michael Roth
Quoting David Gibson (2015-01-18 22:31:23) > On Tue, Dec 23, 2014 at 06:30:22AM -0600, Michael Roth wrote: > > From: Nathan Fontenot > > > > This extends the data structures currently used to report EPOW events to > > gets via the check-exception RTAS interfaces to also include event types > > fo

Re: [Qemu-devel] [PATCH v4 03/17] spapr_rtas: add get/set-power-level RTAS interfaces

2015-01-26 Thread Michael Roth
Quoting David Gibson (2015-01-16 00:21:55) > On Tue, Dec 23, 2014 at 06:30:17AM -0600, Michael Roth wrote: > > From: Nathan Fontenot > > > > Signed-off-by: Nathan Fontenot > > Signed-off-by: Michael Roth > > --- > > hw/ppc/spapr_rtas.c | 25 + > > 1 file changed, 25 ins

Re: [Qemu-devel] [PATCH v4 02/17] spapr_drc: initial implementation of sPAPRDRConnector device

2015-01-26 Thread Michael Roth
Quoting David Gibson (2015-01-16 00:19:08) > On Tue, Dec 23, 2014 at 06:30:16AM -0600, Michael Roth wrote: > > This device emulates a firmware abstraction used by pSeries guests to > > manage hotplug/dynamic-reconfiguration of host-bridges, PCI devices, > > memory, and CPUs. It is conceptually simi

Re: [Qemu-devel] [PATCH v4 02/17] spapr_drc: initial implementation of sPAPRDRConnector device

2015-01-26 Thread Michael Roth
Quoting Bharata B Rao (2015-01-02 04:32:58) > On Tue, Dec 23, 2014 at 6:00 PM, Michael Roth > wrote: > > This device emulates a firmware abstraction used by pSeries guests to > > manage hotplug/dynamic-reconfiguration of host-bridges, PCI devices, > > memory, and CPUs. It is conceptually similar

Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers

2015-01-26 Thread Paolo Bonzini
On 26/01/2015 22:13, Max Reitz wrote: >>> >> An eject blocker would also break backwards-compatibility though. What >> about an eject notifier? Would that concept make sense? > > It does make sense (in that it is the way I would implement "just do > what we always did"), but I just don't like

Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers

2015-01-26 Thread Max Reitz
On 2015-01-26 at 16:10, Paolo Bonzini wrote: On 26/01/2015 21:43, Max Reitz wrote: If the NBD server is attached to the BDS, it should keep serving the BDS. The problem is that it is no longer attached to the BDS, but to the BB. That's not necessarily a problem. :) It is the cause of the pro

Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers

2015-01-26 Thread Paolo Bonzini
On 26/01/2015 21:43, Max Reitz wrote: >> If the NBD server is attached to the BDS, it should keep serving the BDS. > > The problem is that it is no longer attached to the BDS, but to the BB. That's not necessarily a problem. :) It is the cause of the problem though. Is it possible to attach t

Re: [Qemu-devel] [PATCH v5 5/5] qemu-iotests: Add 093 for IO throttling

2015-01-26 Thread Max Reitz
On 2015-01-16 at 03:46, Fam Zheng wrote: This case utilizes qemu-io command "aio_{read,write} -q" to verify the effectiveness of IO throttling options. It's implemented by driving the vm timer from qtest protocol, so the throttling timers are signaled with determinied time duration. Then we veri

Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers

2015-01-26 Thread Max Reitz
On 2015-01-26 at 15:40, Paolo Bonzini wrote: On 26/01/2015 20:27, Max Reitz wrote: However, this was wrong: With the NBD attached to some BB, it should stay attached until the NBD export is removed or the server stopped; medium ejection should have nothing to do with this (other than the NBD se

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2015-01-26 Thread Mike Perez
** Changed in: cinder Status: In Progress => Triaged ** Changed in: cinder Assignee: Tony Breeds (o-tony) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368815 Title: q

Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers

2015-01-26 Thread Paolo Bonzini
On 26/01/2015 20:27, Max Reitz wrote: > However, this was wrong: With the NBD attached to some BB, it > should stay attached until the NBD export is removed or the server > stopped; medium ejection should have nothing to do with this (other than > the NBD server not being able to read data while

Re: [Qemu-devel] [PATCH 05/11] target-arm: Use correct mmu_idx for unprivileged loads and stores

2015-01-26 Thread Peter Maydell
On 26 January 2015 at 19:34, Greg Bellows wrote: > On Mon, Jan 26, 2015 at 8:56 AM, Peter Maydell > wrote: >> Because that's what the ARM ARM specifies. Compare C3.2.5 (A64 LDT &c) >> with F7.1.95 (A32/T32 LDRT). > > > I had been comparing the wording of ARMv8 - F1.6.3 and ARMv7 - A4.6.3. > After

Re: [Qemu-devel] [PATCH 07/11] target-arm: Split AArch64 cases out of ats_write()

2015-01-26 Thread Greg Bellows
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell wrote: > Instead of simply reusing ats_write() as the handler for both AArch32 > and AArch64 address translation operations, use a different function > for each with the common code in a third function. This is necessary > because the semantics for

Re: [Qemu-devel] [PATCH v5 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp

2015-01-26 Thread Max Reitz
On 2015-01-16 at 03:46, Fam Zheng wrote: QMP command "block_set_io_throttle" expects underscores in parameters instead of dashes: {iops,bps}_{rd,wr,max}. Add optional argument conv_keys (defaults to True, backward compatible), it will be used in IO throttling test case. Reviewed-by: Benoit Cane

Re: [Qemu-devel] [PATCH v5 3/5] qemu-iotests: Add VM method qtest() to iotests.py

2015-01-26 Thread Max Reitz
On 2015-01-16 at 03:46, Fam Zheng wrote: This will allow test case to run command in qtest protocol. It's *test cases write-only for now. Signed-off-by: Fam Zheng --- tests/qemu-iotests/iotests.py | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) Reviewed-by: Max

Re: [Qemu-devel] [PATCH v5 2/5] qtest: Add scripts/qtest.py

2015-01-26 Thread Max Reitz
On 2015-01-16 at 03:46, Fam Zheng wrote: This adds scripts/qtest.py as a python library for qtest protocol. This is a skeleton with a basic "cmd" method to execute a command, reading and parsing of qtest output could be added later on demand. Signed-off-by: Fam Zheng --- scripts/qtest.py | 7

Re: [Qemu-devel] [PATCH v5 1/5] qemu-io: Account IO by aio_read and aio_write

2015-01-26 Thread Max Reitz
On 2015-01-16 at 03:46, Fam Zheng wrote: This will enable accounting of aio requests issued from qemu-io aio read/write commands. Signed-off-by: Fam Zheng --- qemu-io-cmds.c | 11 +++ 1 file changed, 11 insertions(+) I'm not sure what the status of this series is (Paolo already ask

Re: [Qemu-devel] [PATCH 06/11] target-arm: Don't define any MMU_MODE*_SUFFIXes

2015-01-26 Thread Greg Bellows
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell wrote: > target-arm doesn't use any of the MMU-mode specific cpu ldst > accessor functions. Suppress their generation by not defining > any of the MMU_MODE*_SUFFIX macros. ("user" and "kernel" are > too simplistic as descriptions of indexes 0 and 1

Re: [Qemu-devel] [PATCH 05/11] target-arm: Use correct mmu_idx for unprivileged loads and stores

2015-01-26 Thread Greg Bellows
On Mon, Jan 26, 2015 at 8:56 AM, Peter Maydell wrote: > On 26 January 2015 at 14:40, Greg Bellows wrote: > > On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell < > peter.mayd...@linaro.org> > > wrote: > >> > >> The MMU index to use for unprivileged loads and stores is more > >> complicated than we

Re: [Qemu-devel] [PATCH v3 2/2] target-arm: Add checks that cpreg raw accesses are handled

2015-01-26 Thread Greg Bellows
On Mon, Jan 26, 2015 at 8:26 AM, Peter Maydell wrote: > Add assertion checking when cpreg structures are registered that they > either forbid raw-access attempts or at least make an attempt at > handling them. Also add an assert in the raw-accessor-of-last-resort, > to avoid silently doing a read

Re: [Qemu-devel] [PATCH 00/20] block: Rework bdrv_close_all()

2015-01-26 Thread Max Reitz
@subject: Sorry, should be 00/21 of course. I messed up when copying the subject and the text to this final version. Max

[Qemu-devel] [PATCH 21/21] iotests: Add test for multiple BB on BDS tree

2015-01-26 Thread Max Reitz
This adds a test for having multiple BlockBackends in one BDS tree. In this case, there is one BB for the protocol BDS and one BB for the format BDS in a simple two-BDS tree (with the protocol BDS and BB added first). When bdrv_close_all() is executed, no cached data from any BDS should be lost; t

[Qemu-devel] [PATCH 18/21] blockdev: Keep track of monitor-owned BDS

2015-01-26 Thread Max Reitz
...and release the reference on bdrv_close_all(). Signed-off-by: Max Reitz --- block.c | 2 ++ blockdev.c| 24 include/block/block_int.h | 2 ++ 3 files changed, 28 insertions(+) diff --git a/block.c b/block.c index 64d1524..f096577 1

[Qemu-devel] [PATCH 19/21] block: Strip down bdrv_close_all()

2015-01-26 Thread Max Reitz
References to all BlockBackends and BlockDriverStates are now released by their respective holders; force-closing them is no longer necessary. Signed-off-by: Max Reitz --- block.c| 11 +-- block/block-backend.c | 8 include/sysemu/block-backend.

[Qemu-devel] [PATCH 13/21] blockdev: Add list of monitor-owned BlockBackends

2015-01-26 Thread Max Reitz
The monitor does hold references to some BlockBackends so it should have a list of those BBs; blk_backends is a different list, as it contains references to all BBs (after a follow-up patch, that is), and that should not be changed because we do need such a list. Signed-off-by: Max Reitz --- blo

[Qemu-devel] [PATCH 11/21] block: Add blk_commit_all() and blk_invalidate_cache_all()

2015-01-26 Thread Max Reitz
These functions will be changed to iterate through the BDS trees as defined by the BlockBackends instead of the list of root BDS, therefore prepare moving their code to the BlockBackend level. Signed-off-by: Max Reitz --- block/block-backend.c | 10 ++ include/sysemu/block-backe

[Qemu-devel] [PATCH 17/21] block: Remove bdrv_states

2015-01-26 Thread Max Reitz
Every entry in this list should be a root BDS and as such either be anchored to a BlockBackend or be owned by the monitor. Signed-off-by: Max Reitz --- block.c | 21 + include/block/block.h | 1 - include/block/block_int.h | 2 -- 3 files changed, 1 in

[Qemu-devel] [PATCH 15/21] block: Make bdrv_drain_one() public

2015-01-26 Thread Max Reitz
We will need it in block/block-backend.c. Signed-off-by: Max Reitz --- block.c | 2 +- include/block/block_int.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index ca6a587..d4a3c79 100644 --- a/block.c +++ b/block.c @@ -1948,7 +1948,7

[Qemu-devel] [PATCH 20/21] iotests: Add "wait" functionality to _cleanup_qemu

2015-01-26 Thread Max Reitz
The qemu process does not always need to be killed, just waiting for it can be fine, too. This introduces a way to do so. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.qemu | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.qemu b/

[Qemu-devel] [PATCH 14/21] blockdev: Remove blk_hide_on_behalf_of_do_drive_del()

2015-01-26 Thread Max Reitz
This function first removed the BlockBackend from the blk_backends list and cleared its name so it would no longer be found by blk_name(); since blk_next() now iterates through monitor_block_backends (which the BB is removed from in do_drive_del()), this is no longer necessary. Second, bdrv_make_a

[Qemu-devel] [PATCH 16/21] block: Move some bdrv_*_all() functions to BB

2015-01-26 Thread Max Reitz
Move bdrv_drain_all(), bdrv_commit_all(), bdrv_flush_all() and bdrv_invalidate_cache_all() to BB. The only operation left is bdrv_close_all(), which cannot be moved to the BB because it should not only close all BBs, but also all monitor-owned BDSs. Signed-off-by: Max Reitz --- block.c

[Qemu-devel] [PATCH 10/21] block: Add blk_next_inserted()

2015-01-26 Thread Max Reitz
This function skips to the next BlockBackend for which blk_is_inserted() is true. Signed-off-by: Max Reitz --- block/block-backend.c | 15 +++ include/sysemu/block-backend.h | 1 + 2 files changed, 16 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c

[Qemu-devel] [PATCH 03/21] block: Add bdrv_close_all() notifiers

2015-01-26 Thread Max Reitz
This adds a list of notifiers to be invoked on bdrv_close_all(). Signed-off-by: Max Reitz --- block.c | 10 ++ include/block/block.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block.c b/block.c index b7e631c..3adb724 100644 --- a/block.c +++ b/block.c @@ -104,

[Qemu-devel] [PATCH 12/21] block: Use BlockBackend more

2015-01-26 Thread Max Reitz
Replace bdrv_drain_all(), bdrv_commmit_all(), bdrv_flush_all(), bdrv_invalidate_cache_all(), bdrv_next() and occurrences of bdrv_states by their BlockBackend equivalents. Signed-off-by: Max Reitz --- block.c | 22 - block/block-backend.c | 8 +++ block/qapi.c

[Qemu-devel] [PATCH 05/21] block: Remove per-BDS close notifiers

2015-01-26 Thread Max Reitz
They are unused, and bdrv_close_all() is a perfectly valid replacement. Signed-off-by: Max Reitz --- block.c| 7 --- block/block-backend.c | 7 --- include/block/block.h | 1 - include/block/block_int.h | 2 -- include/sysemu/block-backend.h

[Qemu-devel] [PATCH 08/21] block: Make bdrv_close() static

2015-01-26 Thread Max Reitz
There are no users of bdrv_close() left, except for one of bdrv_open()'s failure paths, bdrv_close_all() and bdrv_delete(), and that is good. Make bdrv_close() static so nobody makes the mistake of directly using bdrv_close() again. Signed-off-by: Max Reitz --- block.c | 4 +++- in

[Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers

2015-01-26 Thread Max Reitz
Every time a reference to a BlockBackend is taken, a notifier for bdrv_close_all() has to be deposited so the reference holder can relinquish its reference when bdrv_close_all() is called. That notifier should be revoked on a bdrv_unref() call. Add a Notifier * parameter to all the functions chang

[Qemu-devel] [PATCH 02/21] quorum: Fix close path

2015-01-26 Thread Max Reitz
bdrv_unref() can lead to bdrv_close(), which in turn will result in bdrv_drain_all(). This function will later be called blk_drain_all() and iterate only over the BlockBackends for which blk_is_inserted() holds true; therefore, bdrv_is_inserted() and thus quorum_is_inserted() will probably be calle

[Qemu-devel] [PATCH 09/21] block: Add blk_name_taken()

2015-01-26 Thread Max Reitz
There may be BlockBackends which are not returned by blk_by_name(), but do exist and have a name. blk_name_taken() allows testing whether a specific name is in use already, independent of whether the BlockBackend with that name is accessible through blk_by_name(). Signed-off-by: Max Reitz --- bl

  1   2   3   4   >