Re: [Qemu-devel] [PATCH] dataplane: endianness-aware accesses

2015-01-20 Thread Cornelia Huck
David: I saw you tested Stefan's endianness patch. Could you also give my alternative implementation a try? Thanks! On Tue, 20 Jan 2015 17:27:50 +0100 Cornelia Huck wrote: > The vring.c code currently assumes that guest and host endianness match, > which is not true for a number of cases: > >

Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD

2015-01-20 Thread Markus Armbruster
Programmingkid writes: > On Jan 20, 2015, at 3:28 PM, Markus Armbruster wrote: > >> Programmingkid writes: >> >>> On Jan 20, 2015, at 10:22 AM, Eric Blake wrote: >>> On 01/20/2015 07:29 AM, Programmingkid wrote: > > On Jan 20, 2015, at 3:33 AM, Markus Armbruster wrote: > >>>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fw_cfg: fix typos in comments: patch -> path

2015-01-20 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] seccomp: add mlockall to whitelist

2015-01-20 Thread Amit Shah
On (Tue) 20 Jan 2015 [14:32:33], Paolo Bonzini wrote: > This is used by "-realtime mlock=on". > > Signed-off-by: Paolo Bonzini Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-mips: Clean up switch fall through after commit fecd264

2015-01-20 Thread Michael Tokarev
20.01.2015 12:59, Markus Armbruster wrote: > Commit fecd264 added a number of fall-throughs, but neglected to > properly document them as intentional. Commit d922445 cleaned that up > for many, but not all cases. Take care of the remaining ones. Applied to -trivial fixing one extra space on the

Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

2015-01-20 Thread Chen, Tiejun
CCed Stefano. Thanks Tiejun On 2015/1/21 15:19, Tiejun Chen wrote: When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side. Signed-o

[Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

2015-01-20 Thread Tiejun Chen
When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,gfx_passthru=on". This need to bring several changes on tool side. Signed-off-by: Tiejun Chen --- tools/libxl/libxl_dm.c | 19 +-

Re: [Qemu-devel] [v6][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support

2015-01-20 Thread Chen, Tiejun
On 2015/1/20 16:14, Gerd Hoffmann wrote: On Di, 2015-01-20 at 11:14 +0800, Chen, Tiejun wrote: On 2015/1/19 19:45, Gerd Hoffmann wrote: On Mo, 2015-01-19 at 17:28 +0800, Tiejun Chen wrote: +DEF("gfx_passthru", 0, QEMU_OPTION_gfx_passthru, +"-gfx_passthru enable Intel IGD passthrough by X

[Qemu-devel] [Bug 1096814] Re: Guest hang when doing kernel build and writing date in guest

2015-01-20 Thread chao zhou
kvm.git + qemu.git: bab5bb39_74acb997 kernel version:3.19.0-rc3 When write date to remote disk in guest, and compile the kernel, after live migration, the guest and host work fine. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a mem

Re: [Qemu-devel] [PATCH v3 0/6] Some PCI related cleanup patches

2015-01-20 Thread Hu Tao
ping... On Thu, Dec 11, 2014 at 10:20:22AM +0800, Hu Tao wrote: > Hi, > > This is v3 of PCI clenaup series. See each patch for the detail. > > Regards, > Hu > > changes: > > v3: > - rebase on top of 7fb8da2b886, all 5 patches applied cleanly. > - new patch: pci: introduce PCI_DEVFN_AUTO >

Re: [Qemu-devel] [PATCH v3 0/5] Migration Deciphering aid

2015-01-20 Thread Amit Shah
On (Tue) 20 Jan 2015 [11:54:50], Alexander Graf wrote: > > > On 20.01.15 11:31, Amit Shah wrote: > > On (Fri) 26 Dec 2014 [15:42:43], Alexander Graf wrote: > >> Migration is a black hole to most people. One of the biggest reasons for > >> this is that its protocol is a secret, undocumented sauce

Re: [Qemu-devel] [PATCH 3/3] Print errors in some of the early migration failure cases.

2015-01-20 Thread Amit Shah
On (Tue) 20 Jan 2015 [14:48:03], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert Little improvements.. Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH 2/3] Migration: Add lots of trace events

2015-01-20 Thread Amit Shah
On (Tue) 20 Jan 2015 [14:48:02], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Mostly on the load side, so that when we get a complaint about > a migration failure we can figure out what it didn't like. Nice! Just one note below. > Signed-off-by: Dr. David Alan Gilbe

Re: [Qemu-devel] [PATCH 1/3] savevm: Convert fprintf to error_report

2015-01-20 Thread Amit Shah
On (Tue) 20 Jan 2015 [14:48:01], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Convert a bunch of fprintfs to error_reports > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

[Qemu-devel] [PATCH v2] Fixes several full screen issues on Mac OS X

2015-01-20 Thread Programmingkid
This patch makes several changes: - Minimizes distorted full screen display by respecting aspect ratios. - Makes full screen mode available on Mac OS 10.7 and higher. - Allows user to decide if video should be stretched to fill the screen, using a menu item called "Zoom To Fit". - Hides the normalW

Re: [Qemu-devel] [PATCH v3 6/9] rocker: add new rocker switch device

2015-01-20 Thread Jason Wang
On Fri, Jan 16, 2015 at 5:48 PM, Scott Feldman wrote: On Fri, Jan 16, 2015 at 1:15 AM, Jason Wang wrote: On 01/11/2015 11:57 AM, sfel...@gmail.com wrote: Each port is a netdev and can be paired with using -netdev id=. Signed-off-by: Scott Feldman Signed-off-by: Jiri Pirko ---

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Jason Wang as net subsystem maintainer

2015-01-20 Thread Jason Wang
On Tue, Jan 20, 2015 at 11:40 PM, Stefan Hajnoczi wrote: Jason Wang will be co-maintaining the QEMU net subsystem with me. He has contributed improvements and reviewed patches over the past years as part of working on virtio-net and virtualized networking. Jason has already been backing m

Re: [Qemu-devel] [v6][PATCH 08/10] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2015-01-20 Thread Chen, Tiejun
+uint32_t xen_igd_pci_read(PCIDevice *pci_dev, uint32_t config_addr, int len) +{ +XenHostPCIDevice dev; +uint32_t val; +int r; + +/* IGD read/write is through the host bridge. + */ +assert(pci_dev->devfn == 0x00); + +if (!is_igd_passthrough(pci_dev)) { +goto rea

Re: [Qemu-devel] cpu hotplug and windows guest (win2012r2)

2015-01-20 Thread Alexandre DERUMIER
Ok, I think it's a windows bug, I have the same topology than you, I don't work. (I see the new vcpu in device manager, but not in taskmgr or perform) Rebooting the os make the new vcpu display, so it's seem to be ok on qemu side. (Just to known, which version of win2012r2 do you use ? standard

Re: [Qemu-devel] [PATCH 1/4] qdev: support to get a device firmware path directly

2015-01-20 Thread Gonglei
On 2015/1/21 0:10, Paolo Bonzini wrote: > > > On 19/01/2015 14:23, arei.gong...@huawei.com wrote: >> @@ -780,6 +788,12 @@ static int qdev_get_fw_dev_path_helper(DeviceState >> *dev, char *p, int size) >> d = bus_get_fw_dev_path(dev->parent_bus, dev); >> } >> if (d

Re: [Qemu-devel] [PATCH] tcg: Use macro instead of hard code number 0xffffffff for tcg_target_ulong using

2015-01-20 Thread Gang Chen
It is not for fixing bugs. I guess it belongs to trivial patch (not fix bugs, not changing any working flow). And excuse me, gmail is broken again, in China, I have to reply on web site via my Mac book Safari (which is not a pure text). On Mon, Jan 19, 2015 at 11:58 PM, Peter Maydell wrote: > O

Re: [Qemu-devel] [v6][PATCH 07/10] xen, gfx passthrough: register a isa bridge

2015-01-20 Thread Chen, Tiejun
+static void +xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, + XenHostPCIDevice *dev) +{ I suggest this implementation, and the table, are moved to the same file where igd-passthrough-isa-bridge is implemented. The function can get PCIDevice

Re: [Qemu-devel] [v6][PATCH 07/10] xen, gfx passthrough: register a isa bridge

2015-01-20 Thread Chen, Tiejun
+ +if (pch_dev_id == 0x) { +fprintf(stderr, "unsupported PCH!\n"); I would drop this fprintf: this likely means a newer card, so the bridge is not necessary. Okay. +return; +} + +/* Currently IGD drivers always need to access PCH by 1f.0. */ +pci_dev = p

Re: [Qemu-devel] [PATCH 2/2] dataplane: use virtio_ld/st_p() for endian-aware memory access

2015-01-20 Thread David Gibson
On Mon, Jan 19, 2015 at 05:04:37PM +, Stefan Hajnoczi wrote: > The vring.c code was written under the assumption that virtio devices > have the same endianness as the host. > > This is wrong when emulating targets that differ in endianness from the > host. > > It is also wrong when emulating

Re: [Qemu-devel] [PATCH 1/2] dataplane: move vring_more_avail() into vring.c

2015-01-20 Thread David Gibson
On Mon, Jan 19, 2015 at 05:04:36PM +, Stefan Hajnoczi wrote: > vring_more_avail() was an inline function in vring.h. No external > callers use it so it's not necessary to export it. > > Furthermore, we'll need virtio-access.h for endian-aware memory accesses > but that only works in per-targe

Re: [Qemu-devel] cpu hotplug and windows guest (win2012r2)

2015-01-20 Thread Andrey Korolyov
On Tue, Jan 20, 2015 at 10:06 PM, Alexandre DERUMIER wrote: > Hi, > > I have tried with numa enabled, and it's still don't work. > Can you send me your vm qemu command line ? > > > Also, with numa I have notice something strange with "info numa" command. > > starting with -smp socket=2,cores=1 > >

Re: [Qemu-devel] [PATCH v5 00/26] qcow2: Support refcount orders != 4

2015-01-20 Thread Max Reitz
On 2014-12-15 at 07:50, Max Reitz wrote: As of version 3, the qcow2 file format supports different widths for refcount entries, ranging from 1 to 64 bit (only powers of two). Currently, qemu only supports 16 bit, which is the only width supported by version 2 (compat=0.10) images. This series ad

Re: [Qemu-devel] [PATCH v2 00/12] qcow2: Add new overlap check functions

2015-01-20 Thread Max Reitz
On 2014-11-24 at 10:56, Max Reitz wrote: As has been requested, this series adds new overlap check functions to the qcow2 code. My local branch is called "qcow2-improved-overlap-v1", but I am not so sure whether it is actually an improvement; that is left for you to decide, dear reviewers. See p

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Greg Bellows
On Tue, Jan 20, 2015 at 10:25 AM, Igor Mammedov wrote: > On Tue, 20 Jan 2015 16:08:09 + > Peter Maydell wrote: > >> On 20 January 2015 at 15:59, Igor Mammedov wrote: >> > On Tue, 20 Jan 2015 15:34:23 + >> > Peter Maydell wrote: >> > >> >> On 20 January 2015 at 15:22, Igor Mammedov wrot

Re: [Qemu-devel] [PATCH v3 2/2] xilinx_zynq: Add zynq-gpio to the machine

2015-01-20 Thread Peter Crosthwaite
On Tue, Jan 6, 2015 at 2:26 PM, Colin Leitner wrote: > Signed-off-by: Colin Leitner Reviewed-by: Peter Crosthwaite > --- > hw/arm/xilinx_zynq.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c > index 06e6e24..6d8c0d9 100644 > --- a/hw/

Re: [Qemu-devel] [PATCH v3 1/2] zynq_gpio: GPIO model for Zynq SoC

2015-01-20 Thread Peter Crosthwaite
Hi Colin, Sorry about the delay, review below. On Tue, Jan 6, 2015 at 2:26 PM, Colin Leitner wrote: > Based on the pl061 model. This model implements all four banks with 32 I/Os > each. > > The I/Os are placed in named groups: > > * bankX_in for the 32 inputs of each bank > * bankX_out for th

Re: [Qemu-devel] [PATCH v4 0/7] pc: acpi: various fixes and cleanups

2015-01-20 Thread Michael S. Tsirkin
On Tue, Jan 20, 2015 at 09:38:18PM +0100, Igor Mammedov wrote: > On Tue, 20 Jan 2015 18:29:07 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Jan 20, 2015 at 03:52:25PM +, Igor Mammedov wrote: > > > NOTE to maintainer: please update test data (ACPI blobs) in test > > > cases > > > > > > ch

Re: [Qemu-devel] [Bug 1399191] [NEW] Large VHDX image size

2015-01-20 Thread Jeff Cody
On Mon, Jan 19, 2015 at 03:19:05PM +, Lokesha, Amulya wrote: > > > -Original Message- > From: Jeff Cody [mailto:jc...@redhat.com] > Sent: Tuesday, January 13, 2015 9:18 AM > To: Lokesha, Amulya > Cc: Bug 1399191; Geoffroy, Daniel > Subject: Re: [Qemu-devel] [Bug 1399191] [NEW] Large

[Qemu-devel] [PATCH] block: vhdx - force FileOffsetMB field to '0' for certain block states

2015-01-20 Thread Jeff Cody
The v1.0.0 spec calls out PAYLOAD_BLOCK_ZERO FileOffsetMB field as being 'reserved'. In practice, this means that Hyper-V will fail to read a disk image with PAYLOAD_BLOCK_ZERO block states with a FileOffsetMB value other than 0. The other states that indicate a block that is not there (PAYLOAD_B

Re: [Qemu-devel] [PATCH v4 0/7] pc: acpi: various fixes and cleanups

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 18:29:07 +0200 "Michael S. Tsirkin" wrote: > On Tue, Jan 20, 2015 at 03:52:25PM +, Igor Mammedov wrote: > > NOTE to maintainer: please update test data (ACPI blobs) in test > > cases > > > > changes from v3: > > * rename acpi_gen_utils.[ch] to acpi-build-utils.[ch] > >

Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD

2015-01-20 Thread Programmingkid
On Jan 20, 2015, at 3:28 PM, Markus Armbruster wrote: > Programmingkid writes: > >> On Jan 20, 2015, at 10:22 AM, Eric Blake wrote: >> >>> On 01/20/2015 07:29 AM, Programmingkid wrote: On Jan 20, 2015, at 3:33 AM, Markus Armbruster wrote: > Programmingkid writes: > >

Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD

2015-01-20 Thread Markus Armbruster
Programmingkid writes: > On Jan 20, 2015, at 10:22 AM, Eric Blake wrote: > >> On 01/20/2015 07:29 AM, Programmingkid wrote: >>> >>> On Jan 20, 2015, at 3:33 AM, Markus Armbruster wrote: >>> Programmingkid writes: > Subject was: > Re: [PATCH v7] block/raw-posix.c: Fixes raw_

Re: [Qemu-devel] [PATCH 2/3 V3] s390: implement pci instructions

2015-01-20 Thread Markus Armbruster
Frank Blaschka writes: > On Tue, Jan 20, 2015 at 01:56:09PM +0100, Markus Armbruster wrote: >> Markus Armbruster writes: >> >> > Cornelia Huck writes: >> > >> >> On Tue, 20 Jan 2015 10:45:41 +0100 >> >> Markus Armbruster wrote: >> >> >> >>> This patch makes Coverity unhappy: >> >>> >> >>> **

Re: [Qemu-devel] [PATCH] qdev: Don't exit when running into bad -global

2015-01-20 Thread Markus Armbruster
Eric Blake writes: > On 01/20/2015 02:04 AM, Markus Armbruster wrote: >> -global lets you set a nice booby-trap for yourself: >> >> $ qemu-system-x86_64 -nodefaults -S -display none -usb -monitor stdio >> -global usb-mouse.usb_version=l >> QEMU 2.1.94 monitor - type 'help' for more info

Re: [Qemu-devel] [PATCH 4/5] target-arm: Add AArch32 guest support to KVM64

2015-01-20 Thread Greg Bellows
On Tue, Jan 20, 2015 at 10:57 AM, Alex Bennée wrote: > > Greg Bellows writes: > >> Add 32-bit to/from 64-bit register synchronization on register gets and puts. >> Set EL1_32BIT feature flag passed to KVM >> >> Signed-off-by: Greg Bellows >> --- >> target-arm/kvm64.c | 21 +

[Qemu-devel] [PATCH v3] Makes -full-screen option work on Mac OS X

2015-01-20 Thread Programmingkid
This patch makes the -full-screen option actually instruct QEMU to enter fullscreen at startup, on Mac OS X. Signed-off-by: John Arbuckle --- Eliminated compile warning. ui/cocoa.m |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index d37c2

Re: [Qemu-devel] [PATCH v2] Makes -full-screen option work on Mac OS X

2015-01-20 Thread Programmingkid
On Jan 14, 2015, at 12:09 PM, Peter Maydell wrote: > On 12 January 2015 at 16:46, Programmingkid wrote: >> This patch makes the -full-screen option actually instruct QEMU to enter >> fullscreen at startup. >> >> Signed-off-by: John Arbuckle >> >> --- >> Removed the set_to_full_screen variabl

Re: [Qemu-devel] cpu hotplug and windows guest (win2012r2)

2015-01-20 Thread Alexandre DERUMIER
Hi, I have tried with numa enabled, and it's still don't work. Can you send me your vm qemu command line ? Also, with numa I have notice something strange with "info numa" command. starting with -smp socket=2,cores=1 # info numa 2 nodes node 0 cpus: 0 node 0 size: 2048 MB node 1 cpus: 1 node 1

Re: [Qemu-devel] [PATCH] target-mips: Clean up switch fall through after commit fecd264

2015-01-20 Thread Maciej W. Rozycki
On Tue, 20 Jan 2015, Peter Maydell wrote: > In this particular case, this part of the file is fine and the > problem is simply that this patch as it stands introduces a single > line (the one above) that's not indented correctly. The only fix > required is to delete one space in the line added by

Re: [Qemu-devel] [PATCH v2 5/6] block: mirror - change string allocation to 2-bytes

2015-01-20 Thread John Snow
On 01/20/2015 12:31 PM, Jeff Cody wrote: The backing_filename string in mirror_run() is only used to check for a NULL string, so we don't need to allocate 1024 bytes (or, later, PATH_MAX bytes), when we only need to copy the first 2 characters. We technically only need 1 byte, as we are just c

Re: [Qemu-devel] [PATCH v2 4/6] block: move string allocation from stack to the heap

2015-01-20 Thread John Snow
On 01/20/2015 12:31 PM, Jeff Cody wrote: Rather than allocate PATH_MAX bytes on the stack, use g_strndup() to dynamically allocate the string, and add an exit label for cleanup. Signed-off-by: Jeff Cody --- block.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --g

Re: [Qemu-devel] [PATCH v2 6/6] block: update string sizes for filename, backing_file, exact_filename

2015-01-20 Thread John Snow
On 01/20/2015 12:31 PM, Jeff Cody wrote: The string field entries 'filename', 'backing_file', and 'exact_filename' in the BlockDriverState struct are defined as 1024 bytes. However, many places that use these values accept a maximum of PATH_MAX bytes, so we have a mixture of 1024 byte and PATH

Re: [Qemu-devel] [PATCH v2 3/6] block: qapi - move string allocation from stack to the heap

2015-01-20 Thread John Snow
On 01/20/2015 12:31 PM, Jeff Cody wrote: Rather than declaring 'backing_filename2' on the stack in bdrv_quiery_image_info(), dynamically allocate it on the heap. Signed-off-by: Jeff Cody --- block/qapi.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/block/qapi

Re: [Qemu-devel] [PATCH v2 1/6] block: vmdk - make ret variable usage clear

2015-01-20 Thread John Snow
On 01/20/2015 12:31 PM, Jeff Cody wrote: Keep the variable 'ret' something that is returned by the function it is defined in. For the return value of 'sscanf', use a more meaningful variable name. Signed-off-by: Jeff Cody --- block/vmdk.c | 14 -- 1 file changed, 8 insertions(

Re: [Qemu-devel] [PATCH v2 2/6] block: vmdk - move string allocations from stack to the heap

2015-01-20 Thread John Snow
On 01/20/2015 12:31 PM, Jeff Cody wrote: Functions 'vmdk_parse_extents' and 'vmdk_create' allocate several PATH_MAX sized arrays on the stack. Make these dynamically allocated. Signed-off-by: Jeff Cody --- block/vmdk.c | 64 1 f

Re: [Qemu-devel] [PATCH] target-mips: Clean up switch fall through after commit fecd264

2015-01-20 Thread Peter Maydell
On 20 January 2015 at 18:16, Maciej W. Rozycki wrote: > On Tue, 20 Jan 2015, Markus Armbruster wrote: > >> >> diff --git a/target-mips/translate.c b/target-mips/translate.c >> >> index e9d86b2..8abc12b 100644 >> >> --- a/target-mips/translate.c >> >> +++ b/target-mips/translate.c >> >> @@ -18729,6

Re: [Qemu-devel] [PATCH] target-mips: Clean up switch fall through after commit fecd264

2015-01-20 Thread Maciej W. Rozycki
On Tue, 20 Jan 2015, Markus Armbruster wrote: > >> diff --git a/target-mips/translate.c b/target-mips/translate.c > >> index e9d86b2..8abc12b 100644 > >> --- a/target-mips/translate.c > >> +++ b/target-mips/translate.c > >> @@ -18729,6 +18729,7 @@ static void decode_opc(CPUMIPSState *env, > >> Di

Re: [Qemu-devel] [PULL 00/18] misc cross-tree patches queue

2015-01-20 Thread Peter Maydell
> are available in the git repository at: > > > git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-misc-20150120 > > for you to fetch changes up to de5ee4a888667ca0a198f0743d70075d70564117: > > cpu_ldst.h: Don&

[Qemu-devel] [PATCH v2 6/6] block: update string sizes for filename, backing_file, exact_filename

2015-01-20 Thread Jeff Cody
The string field entries 'filename', 'backing_file', and 'exact_filename' in the BlockDriverState struct are defined as 1024 bytes. However, many places that use these values accept a maximum of PATH_MAX bytes, so we have a mixture of 1024 byte and PATH_MAX byte allocations. This patch makes the B

[Qemu-devel] [PATCH v2 1/6] block: vmdk - make ret variable usage clear

2015-01-20 Thread Jeff Cody
Keep the variable 'ret' something that is returned by the function it is defined in. For the return value of 'sscanf', use a more meaningful variable name. Signed-off-by: Jeff Cody --- block/vmdk.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b

[Qemu-devel] [PATCH v2 5/6] block: mirror - change string allocation to 2-bytes

2015-01-20 Thread Jeff Cody
The backing_filename string in mirror_run() is only used to check for a NULL string, so we don't need to allocate 1024 bytes (or, later, PATH_MAX bytes), when we only need to copy the first 2 characters. We technically only need 1 byte, as we are just checking for NULL, but since backing_filename[

[Qemu-devel] [PATCH v2 3/6] block: qapi - move string allocation from stack to the heap

2015-01-20 Thread Jeff Cody
Rather than declaring 'backing_filename2' on the stack in bdrv_quiery_image_info(), dynamically allocate it on the heap. Signed-off-by: Jeff Cody --- block/qapi.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index a6fd6f7..e51bade 100644

[Qemu-devel] [PATCH v2 2/6] block: vmdk - move string allocations from stack to the heap

2015-01-20 Thread Jeff Cody
Functions 'vmdk_parse_extents' and 'vmdk_create' allocate several PATH_MAX sized arrays on the stack. Make these dynamically allocated. Signed-off-by: Jeff Cody --- block/vmdk.c | 64 1 file changed, 38 insertions(+), 26 deletions(-)

[Qemu-devel] [PATCH v2 4/6] block: move string allocation from stack to the heap

2015-01-20 Thread Jeff Cody
Rather than allocate PATH_MAX bytes on the stack, use g_strndup() to dynamically allocate the string, and add an exit label for cleanup. Signed-off-by: Jeff Cody --- block.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index cbe4a32..39cd7a6 1

[Qemu-devel] [PATCH v2 0/6] RESEND - Update filename string sizes in block layer

2015-01-20 Thread Jeff Cody
[ Note, my prior email to qemu-devel bounced, because I mistyped an address. Resending ] The block layer uses a mixture of 'PATH_MAX' and '1024' string sizes for filenames (and backing filenames). This series consolidates all that usage to 'PATH_MAX'. Since most platforms (especially the most

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-20 Thread John Snow
On 01/17/2015 12:17 PM, Vladimir Sementsov-Ogievskiy wrote: Best regards, Vladimir On 09.01.2015 01:05, John Snow wrote: CCing migration maintainers, feedback otherwise in-line. On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Just migrate parts of dirty bitmaps, corresponding t

Re: [Qemu-devel] [PATCH v4 0/7] pc: acpi: various fixes and cleanups

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 18:29:07 +0200 "Michael S. Tsirkin" wrote: > On Tue, Jan 20, 2015 at 03:52:25PM +, Igor Mammedov wrote: > > NOTE to maintainer: please update test data (ACPI blobs) in test cases > > > > changes from v3: > > * rename acpi_gen_utils.[ch] to acpi-build-utils.[ch] > > * co

[Qemu-devel] [PATCH v2] Machine menu patch for Mac OS X

2015-01-20 Thread Programmingkid
Features: Menu items to switch floppy and CD image files. Menu items to eject floppy and CD image files. Menu item to use /dev/cdrom. Verifies with the user before quitting QEMU by displaying a dialog box. Signed-off-by: John Arbuckle --- Changed setting the window title to pause to displaying t

Re: [Qemu-devel] [PATCH] qemu-ga-win: Document 'guest-set-time' limitation

2015-01-20 Thread Eric Blake
On 01/20/2015 01:30 AM, Michal Privoznik wrote: > The command implementation for Windows guest has this limitation. If > no time to set has been provided the documentation for the command > states that time should be read from RTC. However, on Windows bare > GetSystemTime() is used, which does not

Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs

2015-01-20 Thread Eric Blake
On 01/12/2015 04:59 AM, Pavel Dovgalyuk wrote: > This patch adds global variables, defines, functions declarations, > and function stubs for deterministic VM replay used by external modules. > > Signed-off-by: Pavel Dovgalyuk > --- > +++ b/qapi-schema.json > @@ -3515,3 +3515,35 @@ > # Since: 2.

[Qemu-devel] [PATCH v4 7/7] pc: acpi-build: simplify PCI bus tree generation

2015-01-20 Thread Igor Mammedov
it basicaly does the same as original approach, * just without bus/notify tables tracking (less obscure) which is easier to follow. * drops unnecessary loops and bitmaps, creating devices and notification method in the same loop. * saves us ~100LOC Signed-off-by: Igor Mammedov --- v4: * kee

Re: [Qemu-devel] [PATCH] qdev: Don't exit when running into bad -global

2015-01-20 Thread Eric Blake
On 01/20/2015 02:04 AM, Markus Armbruster wrote: > -global lets you set a nice booby-trap for yourself: > > $ qemu-system-x86_64 -nodefaults -S -display none -usb -monitor stdio > -global usb-mouse.usb_version=l > QEMU 2.1.94 monitor - type 'help' for more information > (qemu) device_

[Qemu-devel] [PATCH v4 1/7] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled

2015-01-20 Thread Igor Mammedov
ACPI parser in XP considers PNP0A06 devices of CPU and memory hotplug as duplicates. Adding unique _UID to CPU hotplug device fixes BSOD. Signed-off-by: Igor Mammedov --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw

[Qemu-devel] [PATCH v4 0/7] pc: acpi: various fixes and cleanups

2015-01-20 Thread Igor Mammedov
NOTE to maintainer: please update test data (ACPI blobs) in test cases changes from v3: * rename acpi_gen_utils.[ch] to acpi-build-utils.[ch] * copy GLP license block from acpi-build.c * assert on wrong Segcount earlier and extend condition to seg_count > 0 && seg_count <= 255 * drop "pc: a

Re: [Qemu-devel] [PATCH 2/5] target-arm: Add feature parsing to virt

2015-01-20 Thread Alex Bennée
Greg Bellows writes: > Added machvirt parsing of feature keywords added to the -cpu command line > option. Parsing occurs during machine initialization. > > Signed-off-by: Greg Bellows > --- > hw/arm/virt.c | 21 +++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > dif

Re: [Qemu-devel] [PATCH 4/5] target-arm: Add AArch32 guest support to KVM64

2015-01-20 Thread Alex Bennée
Greg Bellows writes: > Add 32-bit to/from 64-bit register synchronization on register gets and puts. > Set EL1_32BIT feature flag passed to KVM > > Signed-off-by: Greg Bellows > --- > target-arm/kvm64.c | 21 + > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --g

Re: [Qemu-devel] [PATCH v11 03/13] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-01-20 Thread John Snow
On 01/20/2015 03:26 AM, Markus Armbruster wrote: John Snow writes: On 01/19/2015 05:08 AM, Markus Armbruster wrote: John Snow writes: On 01/16/2015 10:36 AM, Max Reitz wrote: On 2015-01-12 at 11:30, John Snow wrote: From: Fam Zheng The new command pair is added to manage user created

Re: [Qemu-devel] target-tricore: Possible bug in get_mtcr()

2015-01-20 Thread Bastian Koppelmann
Hi Markus, On 01/20/2015 09:23 AM, Markus Armbruster wrote: Coverity[*] points out: *** CID 1264337: Logically dead code (DEADCODE) /target-tricore/translate.c: 348 in gen_mtcr() 342 #define E(ADDRESS, REG, FEATURE) A(ADDRESS, REG, FEATURE) 343 static inline void gen_mt

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 16:08:09 + Peter Maydell wrote: > On 20 January 2015 at 15:59, Igor Mammedov wrote: > > On Tue, 20 Jan 2015 15:34:23 + > > Peter Maydell wrote: > > > >> On 20 January 2015 at 15:22, Igor Mammedov wrote: > >> > Please do not use legacy +-feature format and support on

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Jason Wang as net subsystem maintainer

2015-01-20 Thread Michael S. Tsirkin
On Tue, Jan 20, 2015 at 03:40:38PM +, Stefan Hajnoczi wrote: > Jason Wang will be co-maintaining the QEMU net subsystem with me. He > has contributed improvements and reviewed patches over the past years as > part of working on virtio-net and virtualized networking. > > Jason has already been

Re: [Qemu-devel] [PATCH v4 0/7] pc: acpi: various fixes and cleanups

2015-01-20 Thread Michael S. Tsirkin
On Tue, Jan 20, 2015 at 03:52:25PM +, Igor Mammedov wrote: > NOTE to maintainer: please update test data (ACPI blobs) in test cases > > changes from v3: > * rename acpi_gen_utils.[ch] to acpi-build-utils.[ch] > * copy GLP license block from acpi-build.c > * assert on wrong Segcount earlier

[Qemu-devel] [PATCH] dataplane: endianness-aware accesses

2015-01-20 Thread Cornelia Huck
The vring.c code currently assumes that guest and host endianness match, which is not true for a number of cases: - emulating targets with a different endianness than the host - bi-endian targets, where the correct endianness depends on the virtio device - upcoming support for the virtio-1 stand

[Qemu-devel] [PATCH] sb16: fix interrupt acknowledgement

2015-01-20 Thread Paolo Bonzini
SoundBlaster 16 emulation is very broken and consumes a lot of CPU, but a small fix was suggested offlist and it is enough to fix some games. I got Epic Pinball to work with the "SoundBlaster Clone" option. The processing of the interrupt register is wrong due to two missing "not"s. This causes

Re: [Qemu-devel] [PATCH] qemu-timer.c: Trim list of included headers

2015-01-20 Thread Paolo Bonzini
On 20/01/2015 17:16, Peter Maydell wrote: > qemu-timer.c was including a lot more headers than it needed to, > presumably for historical reasons. In particular, it included > ui/console.h; this now tries to pull in , which will > cause a compilation failure in --disable-tools --disable-system > c

[Qemu-devel] [PATCH] qemu-timer.c: Trim list of included headers

2015-01-20 Thread Peter Maydell
qemu-timer.c was including a lot more headers than it needed to, presumably for historical reasons. In particular, it included ui/console.h; this now tries to pull in , which will cause a compilation failure in --disable-tools --disable-system configurations when running "make check" (which builds

Re: [Qemu-devel] [PATCH 1/4] qdev: support to get a device firmware path directly

2015-01-20 Thread Paolo Bonzini
On 19/01/2015 14:23, arei.gong...@huawei.com wrote: > @@ -780,6 +788,12 @@ static int qdev_get_fw_dev_path_helper(DeviceState *dev, > char *p, int size) > d = bus_get_fw_dev_path(dev->parent_bus, dev); > } > if (d) { > +l += snprintf(p + l, size - l, "%

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Peter Maydell
On 20 January 2015 at 15:59, Igor Mammedov wrote: > On Tue, 20 Jan 2015 15:34:23 + > Peter Maydell wrote: > >> On 20 January 2015 at 15:22, Igor Mammedov wrote: >> > Please do not use legacy +-feature format and support only foo=val format. >> > Other targets have it only for to being able s

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-20 Thread Christophe Fergeau
Hey, On Thu, Jan 08, 2015 at 11:50:13AM +0100, Javier Celaya wrote: > Hello > > Recently, SPICE included the lz4 compression algorithm. This patch adds > a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not > exist before the commit that added this compression algorithm,

Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD

2015-01-20 Thread Programmingkid
On Jan 20, 2015, at 10:22 AM, Eric Blake wrote: > On 01/20/2015 07:29 AM, Programmingkid wrote: >> >> On Jan 20, 2015, at 3:33 AM, Markus Armbruster wrote: >> >>> Programmingkid writes: >>> Subject was: Re: [PATCH v7] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so th

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 09:34:39 -0600 Greg Bellows wrote: > On Tue, Jan 20, 2015 at 9:22 AM, Igor Mammedov wrote: > > > On Mon, 19 Jan 2015 16:30:17 -0600 > > Greg Bellows wrote: > > > > > Adds a CPU feature parsing function and assigns to the CPU class. The > > only > > > feature added was "-aa

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Eduardo Habkost
On Tue, Jan 20, 2015 at 09:34:39AM -0600, Greg Bellows wrote: > On Tue, Jan 20, 2015 at 9:22 AM, Igor Mammedov wrote: > > > On Mon, 19 Jan 2015 16:30:17 -0600 > > Greg Bellows wrote: > > > > > Adds a CPU feature parsing function and assigns to the CPU class. The > > only > > > feature added was

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 15:34:23 + Peter Maydell wrote: > On 20 January 2015 at 15:22, Igor Mammedov wrote: > > Please do not use legacy +-feature format and support only foo=val format. > > Other targets have it only for to being able support legacy setups > > which use +- format. > > I though

Re: [Qemu-devel] [PATCH 4/7] ppc: move sdr1 value change detection logic to helper_store_sdr1()

2015-01-20 Thread Paolo Bonzini
On 20/01/2015 16:23, Mark Cave-Ayland wrote: > On 20/01/15 14:57, Paolo Bonzini wrote: > >> On 23/12/2014 01:36, Mark Cave-Ayland wrote: >>> Otherwise when cpu_post_load calls ppc_store_sdr1() when restoring a VM >>> snapshot the value is deemed unchanged and so the internal env->htab* >>> varia

[Qemu-devel] [PULL 11/18] cpu_ldst.h: Drop unused ld/st*_kernel defines

2015-01-20 Thread Peter Maydell
The ld*_kernel and st*_kernel defines are not used anywhere; delete them. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-id: 1421334118-3287-10-git-send-email-peter.mayd...@linaro.org --- include/exec/cpu_ldst.h | 15 ---

[Qemu-devel] [PULL 03/18] cpu_ldst.h: Remove unused ldul_ macros

2015-01-20 Thread Peter Maydell
The five ldul_ macros are not used anywhere and are marked up with an XXX comment. "ldul" is a non-standard prefix for our family of load instructions: we don't mark 32-bit accesses for signedness because they return a 32 bit quantity. So just delete them. Signed-off-by: Peter Maydell Reviewed-by

[Qemu-devel] [PATCH v4 4/7] acpi: move generic aml building helpers into dedictated file

2015-01-20 Thread Igor Mammedov
the will be later used for composing AML primitives and all that could be reused later for ARM machines as well. Signed-off-by: Igor Mammedov --- v3: * rename acpi_gen_utils.[ch] to acpi-build-utils.[ch] * copy GLP license block from acpi-build.c v2: * fix wrong ident in moved code --- hw/

[Qemu-devel] [PATCH v4 3/7] acpi: build_append_nameseg(): add padding if necessary

2015-01-20 Thread Igor Mammedov
According to ACPI spec NameSeg shorter than 4 characters must be padded up to 4 characters with "_" symbol. ACPI 5.0: 20.2.2 "Name Objects Encoding" Do it in build_append_nameseg() so that caller shouldn't know or care about it. Signed-off-by: Igor Mammedov Reviewed-by: Claudio Fontana --- v2:

[Qemu-devel] [PATCH v4 5/7] acpi: add build_append_namestring() helper

2015-01-20 Thread Igor Mammedov
Use build_append_namestring() instead of build_append_nameseg() So user won't have to care whether name is NameSeg, NamePath or NameString. See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding Signed-off-by: Igor Mammedov Reviewed-by: Claudio Fontana --- v3: assert on wrong Segcount earlier

[Qemu-devel] [PULL 17/18] cpu_ldst.h, cpu-all.h, bswap.h: Update documentation on ld/st accessors

2015-01-20 Thread Peter Maydell
Add documentation of what the cpu_*_* accessors look like. Correct some minor errors in the existing documentation of the direct _p accessor family. Remove the near-duplicate comment on the _p accessors from cpu-all.h and replace it with a reference to the comment in bswap.h. Signed-off-by: Peter

[Qemu-devel] [PATCH v4 6/7] acpi: drop min-bytes in build_package()

2015-01-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Claudio Fontana --- hw/acpi/acpi-build-utils.c | 14 -- hw/i386/acpi-build.c | 13 ++--- include/hw/acpi/acpi-build-utils.h | 4 ++-- 3 files changed, 12 insertions(+), 19 deletions(-) diff --git a/hw/acpi/acpi

[Qemu-devel] [PULL 09/18] linux-user/main.c (m68k): Use get_user_u16 rather than lduw in cpu_loop

2015-01-20 Thread Peter Maydell
In the m68k cpu_loop() use get_user_u16 to read the immediate for the simcall rahter than lduw, to bring it into line with how other archs do it and to remove another user of the ldl family of functions. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Paolo Bonzini Revi

[Qemu-devel] [PULL 02/18] exec.c: Drop TARGET_HAS_ICE define and checks

2015-01-20 Thread Peter Maydell
The TARGET_HAS_ICE #define is intended to indicate whether a target-* guest CPU implementation supports the breakpoint handling. However, all our guest CPUs have that support (the only two which do not define TARGET_HAS_ICE are unicore32 and openrisc, and in both those cases the bp support is prese

[Qemu-devel] [PATCH v4 2/7] pc: acpi-build: cleanup AcpiPmInfo initialization

2015-01-20 Thread Igor Mammedov
zero initialize AcpiPmInfo struct to reduce code bloat a little bit. Signed-off-by: Igor Mammedov Reviewed-by: Claudio Fontana --- hw/i386/acpi-build.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 6a2e9c5..e0b66e7

[Qemu-devel] [PULL 07/18] bsd-user/elfload.c: Don't use ldl() or ldq_raw()

2015-01-20 Thread Peter Maydell
Use get_user_u64() and get_user_ual() instead of the ldl() and ldq_raw() functions. [Note that this change is not compile tested as it is actually in dead code -- none of the bsd-user configurations are PPC.] Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Paolo Bonzini

qemu-devel@nongnu.org

2015-01-20 Thread Peter Maydell
Use the cpu_ld*_data and cpu_st*_data family of functions to access guest memory in vm86.c rather than the very short-named ldl/stl functions. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-id: 1421334118-3287-7-git-send-

  1   2   3   >