Re: [Qemu-devel] [PATCH v2 2/2] e1000: decrement RDT if equal to RDH

2015-01-12 Thread Jason Wang
On Tue, Jan 13, 2015 at 3:12 AM, Richard Tollerton wrote: "Michael S. Tsirkin" writes: Richard, can you respond please? I'd like to see this clarified in code comment or commit message before applying this patchset. Apologies, and thanks for reminding me. On Thu, Dec 18, 2014 at 12:0

Re: [Qemu-devel] [PATCH 0/1] pci: allow 0 address for PCI IO/MEM regions

2015-01-12 Thread David Gibson
On Mon, Jan 12, 2015 at 07:24:06AM -0600, Michael Roth wrote: > Quoting Michael Roth (2014-12-23 13:33:35) > > This patch enables the programming of address 0 for IO/MMIO BARs for > > PCI devices. > > > > It was originally included as part of a series implementing PCI > > hotplug for pseries guest

[Qemu-devel] [PATCH] vl.c: optimized code format

2015-01-12 Thread Zhang Min
From: Rudy Zhang There are several tab characters in the 'vl.c' file. It leads to to misalignment of the code. So, let the space instead of the tab. Signed-off-by: Rudy Zhang --- vl.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git

Re: [Qemu-devel] [Bug 1399191] [NEW] Large VHDX image size

2015-01-12 Thread Jeff Cody
On Sun, Jan 11, 2015 at 11:33:31PM -0500, Lokesha, Amulya wrote: > Please find comments inline > > -Original Message- > From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Jeff > Cody > Sent: Wednesday, January 07, 2015 9:11 PM > To: Lokesha, Amulya > Subject: Re: [Qem

[Qemu-devel] [PATCH 14/14] libqos/ahci: create libqos/ahci.c

2015-01-12 Thread John Snow
With global state removed, code responsible for booting up, verifying, and initializing the AHCI HBA is extracted and inserted into libqos/ahci.c, which would allow for other qtests in the future to quickly grab a meaningfully initialized reference to an AHCI HBA. Even without other users, functio

[Qemu-devel] [PATCH 12/14] qtest/ahci: remove getter/setter macros

2015-01-12 Thread John Snow
These macros were a bad idea: They relied upon certain arguments being present locally with a specific name. With the endgoal being to factor out AHCI helper functions outside of the test file itself, these have to be replaced by more explicit helper setter/getter functions. Signed-off-by: John S

[Qemu-devel] [PATCH 03/14] libqos: create libqos.c

2015-01-12 Thread John Snow
The intent of this file is to serve as a misc. utilities file to be shared amongst tests that are utilizing libqos facilities. In a later patch, migration test helpers will be added to libqos.c that will allow simplified testing of migration cases where libqos is "Just Enough OS" for migrations te

[Qemu-devel] [PATCH 09/14] qtest/ahci: remove pcibus global

2015-01-12 Thread John Snow
Rely on the PCI Device's bus pointer instead. One less global to worry about. Signed-off-by: John Snow --- tests/ahci-test.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index c41c7d9..1981b6a 100644 --- a/tests/ahci-tes

[Qemu-devel] [PATCH 11/14] libqos/ahci: Functional register helpers

2015-01-12 Thread John Snow
Introduce a set of "static inline" register helpers that are intended to replace the current set of macros with more functional versions that are better suited to inclusion in libqos than porcelain macros. As a stopgap measure before eliminating the porcelain macros, define them to use the new fun

[Qemu-devel] [PATCH 13/14] qtest/ahci: Bookmark FB and CLB pointers

2015-01-12 Thread John Snow
Instead of re-querying the AHCI device for the FB and CLB buffers, save the pointer we gave to the device during initialization and reference these values instead. Signed-off-by: John Snow --- tests/ahci-test.c | 42 -- tests/libqos/ahci.h | 6 ++ 2

[Qemu-devel] [PATCH 02/14] qtest/ahci: Create ahci.h

2015-01-12 Thread John Snow
Extract defines and other information to ahci.h, to be shared with other tests if they so please. At the very least, reduce clutter in the test file itself. Signed-off-by: John Snow --- tests/ahci-test.c | 319 +-- tests/libqos/ahci.h | 352

[Qemu-devel] [PATCH 08/14] qtest/ahci: finalize AHCIQState consolidation

2015-01-12 Thread John Snow
Move barsize, ahci_fingerprint and capabilities registers into the AHCIQState object, removing global ahci-related state from the ahci-test.c file. More churn, less globals. Signed-off-by: John Snow --- tests/ahci-test.c | 80 + tests/libqos

[Qemu-devel] [PATCH 07/14] qtest/ahci: Store hba_base in AHCIQState

2015-01-12 Thread John Snow
Store the HBA memory base address in the new state object, to simplify function prototypes and encourage a more functional testing style. This causes a lot of churn, but this patch is as "simplified" as I could get it to be. This patch is therefore fairly mechanical and straightforward: Any case w

[Qemu-devel] [PATCH 06/14] libqos: add pc specific interface

2015-01-12 Thread John Snow
Create an operations structure so that the libqos interface can be architecture agnostic, and create a pc-specific interface to functions like qtest_boot. Move the libqos object in the Makefile from being ahci-test only to being linked with all tests that utilize the libqos features. Signed-off-b

[Qemu-devel] [PATCH 04/14] libqos: add qtest_vboot

2015-01-12 Thread John Snow
Add a va_list variant of the qtest_boot function. Signed-off-by: John Snow --- tests/libqos/libqos.c | 25 +++-- tests/libqos/libqos.h | 1 + 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c index c478bc9..c8b3ef0

[Qemu-devel] [PATCH 01/14] libqos: Split apart pc_alloc_init

2015-01-12 Thread John Snow
Move the list-specific initialization over into malloc.c, to keep all of the list implementation details within the same file. The allocation and freeing of these structures are now both back within the same layer. Signed-off-by: John Snow --- tests/libqos/malloc-pc.c | 20

[Qemu-devel] [PATCH 10/14] qtest/ahci: remove guest_malloc global

2015-01-12 Thread John Snow
Make helper routines rely on the earmarked guest allocator object with AHCIQState/QOSSTate instead. Signed-off-by: John Snow --- tests/ahci-test.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 1981b6a..b84f942 1

[Qemu-devel] [PATCH 00/14] ahci-test preliminary refactoring

2015-01-12 Thread John Snow
This series aims to do two main things: (1) Eliminate global state out of the ahci-test file so that the tests are more functional. This will allow me to write migration tests more easily. These tests are already written and will be submitted upstream after these refactor series. (2)

[Qemu-devel] [PATCH 05/14] libqos: add alloc_init_flags

2015-01-12 Thread John Snow
Allow a generic interface to alloc_init_flags, not just through pc_alloc_init_flags. Signed-off-by: John Snow --- tests/libqos/malloc-pc.c | 4 +--- tests/libqos/malloc.c| 8 tests/libqos/malloc.h| 2 ++ 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/tests/libqo

[Qemu-devel] [v2] xen-pt: Fix PCI devices re-attach failed

2015-01-12 Thread Liang Li
Use the 'xl pci-attach $DomU $BDF' command to attach more than one PCI devices to the guest, then detach the devices with 'xl pci-detach $DomU $BDF', after that, re-attach these PCI devices again, an error message will be reported like following: libxl: error: libxl_qmp.c:287:qmp_handle_error_

[Qemu-devel] Question regarding two variables in qemu migration code

2015-01-12 Thread Jidong Xiao
Hi, I am looking at the qemu source code, and trying to understand the migration part. In arch_init.c, there are two variables which seems quite confusing to me, They are: static uint64_t migration_dirty_pages; static int64_t num_dirty_pages_period; // defined in function migration_bitmap_sync(

Re: [Qemu-devel] question about live migration with storage

2015-01-12 Thread Zhang Haoyu
On 2015-01-13 09:49:00, Zhang Haoyu wrote: >Hi, > >I want to live migrate a vm with storage, with regard to the migration of >storage, >should I use drive_mirror or traditional mechanism implemented in >block-migration.c ? Because I don't use libvirtd to manage vm, if I want to use drive_mirror

[Qemu-devel] [PATCH] Machine menu patch for Mac OS X

2015-01-12 Thread Programmingkid
This patch adds a Machine menu to QEMU. This menu gives the user the ability to easily work with floppy and CD image files. Features: Menu items to switch floppy and CD image files. Menu items to eject floppy and CD image files. Menu item to use /dev/cdrom. Verifies with the user before quitting

[Qemu-devel] question about live migration with storage

2015-01-12 Thread Zhang Haoyu
Hi, I want to live migrate a vm with storage, with regard to the migration of storage, should I use drive_mirror or traditional mechanism implemented in block-migration.c ? Any advices? Thanks, Zhang Haoyu

[Qemu-devel] Help for beginner

2015-01-12 Thread Ady Wahyudi Paundu
Hi all, Happy New Year (not too late I hope) I also hope you guys don't' mind to be bothered by newbie questions related to Qemu, because I really don't know where else to ask. I want to learn how several aspects of qemu works, and it really hard to find resources (physical or virtual) about it.

Re: [Qemu-devel] [PATCH v11 00/13] block: Incremental backup series

2015-01-12 Thread Fam Zheng
On Mon, 01/12 11:30, John Snow wrote: > Welcome to version 11. I hope you are enjoying our regular newsletter. > > This patchset enables the in-memory part of the incremental backup > feature. A patchset by Vladimir Sementsov-Ogievskiy enables the > migration of in-memory dirty bitmaps, and a futu

Re: [Qemu-devel] [PATCH 2/4] pci: Add generic PCIe host bridge

2015-01-12 Thread Alexander Graf
On 12.01.15 22:20, Peter Maydell wrote: > On 12 January 2015 at 21:06, Alexander Graf wrote: >> >> >> On 12.01.15 21:08, Peter Maydell wrote: >>> On 12 January 2015 at 17:38, Alexander Graf wrote: I'd prefer to keep things as easy as we humanly can for now. Then add MSI. And if we the

[Qemu-devel] [Bug 1362755] Re: QEmu +2 does not route VLAN tagged packets, that are originated within the Hypervisor itself.

2015-01-12 Thread Thiago Martins
** Project changed: qemu => linux ** Changed in: linux Status: New => Confirmed ** Summary changed: - QEmu +2 does not route VLAN tagged packets, that are originated within the Hypervisor itself. + Linux (3.13 to 3.16) as a Router under QEmu +2, does not route VLAN tagged packets, that

[Qemu-devel] should active block commit ever be allowed to show 0 total progress?

2015-01-12 Thread Eric Blake
I was trying to work on a libvirt bug, when I discovered the following: $ qemu-img create -f qcow2 a.qcow2 10M Formatting 'a.qcow2', fmt=qcow2 size=10485760 encryption=off cluster_size=65536 lazy_refcounts=off $ qemu-img create -f qcow2 \ -obacking_file=a.qcow2,backing_fmt=qcow2 b.qcow2 Formatti

Re: [Qemu-devel] [Bug 1409246] Re: ARM GIC / PL061 error on uni-processor system

2015-01-12 Thread Christopher Covington
Hi Christopher, On 01/10/2015 11:42 AM, Christopher Horler wrote: > confirmed - not a bug, patching the kernel fixes the problem. Mind pointing to your patch? I've been seeing the "GIC CPU mask not found - kernel will fail to boot." message for a long time but since it was apparently spurious nev

Re: [Qemu-devel] [PULL v2 00/44] Block patches

2015-01-12 Thread Peter Maydell
On 12 January 2015 at 16:39, Stefan Hajnoczi wrote: > The following changes since commit 64ea8038ffbf703dcd438a108d2d5499c8ff95d9: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150109.0' > into staging (2015-01-10 22:29:09 +) > > are available in the git repository a

Re: [Qemu-devel] [PATCH 2/4] pci: Add generic PCIe host bridge

2015-01-12 Thread Peter Maydell
On 12 January 2015 at 21:06, Alexander Graf wrote: > > > On 12.01.15 21:08, Peter Maydell wrote: >> On 12 January 2015 at 17:38, Alexander Graf wrote: >>> I'd prefer to keep things as easy as we humanly can for now. Then add >>> MSI. And if we then realize that we still need 4 rather than 1 share

Re: [Qemu-devel] [PATCH 2/4] pci: Add generic PCIe host bridge

2015-01-12 Thread Alexander Graf
On 12.01.15 21:08, Peter Maydell wrote: > On 12 January 2015 at 17:38, Alexander Graf wrote: >> I'd prefer to keep things as easy as we humanly can for now. Then add >> MSI. And if we then realize that we still need 4 rather than 1 shared >> interrupt lines we can still change it :) > > Except

Re: [Qemu-devel] master: intermittent acpi-test failures

2015-01-12 Thread Michael S. Tsirkin
On Mon, Jan 12, 2015 at 08:04:31PM +, Peter Maydell wrote: > On 12 January 2015 at 19:49, Peter Maydell wrote: > > This turns out to be a bug in RTH's patchset which I was testing > > which coincidentally had the same symptoms. > > More generally, I think this ACPI test is the first (only?) t

Re: [Qemu-devel] [PATCH 2/4] pci: Add generic PCIe host bridge

2015-01-12 Thread Peter Maydell
On 12 January 2015 at 17:38, Alexander Graf wrote: > I'd prefer to keep things as easy as we humanly can for now. Then add > MSI. And if we then realize that we still need 4 rather than 1 shared > interrupt lines we can still change it :) Except that that would be a breaking change, so I would pr

Re: [Qemu-devel] master: intermittent acpi-test failures

2015-01-12 Thread Peter Maydell
On 12 January 2015 at 19:49, Peter Maydell wrote: > This turns out to be a bug in RTH's patchset which I was testing > which coincidentally had the same symptoms. More generally, I think this ACPI test is the first (only?) time we try to actually run guest code in "make check", so if we break 64-

Re: [Qemu-devel] master: intermittent acpi-test failures

2015-01-12 Thread Peter Maydell
On 12 January 2015 at 17:56, Peter Maydell wrote: > On 30 November 2014 at 15:12, Michael S. Tsirkin wrote: >> On Sat, Nov 29, 2014 at 05:39:01PM +, Peter Maydell wrote: >>> On 29 November 2014 at 17:36, Michael S. Tsirkin wrote: >>> > My guess is VM fails to boot from disk for some reason.

Re: [Qemu-devel] [PULL 00/10] Linked list for tcg ops

2015-01-12 Thread Peter Maydell
> git://github.com/rth7680/qemu.git tcg-pull-20150112 I'm afraid this fails "make check" on 32-bit hosts: see my other email for diagnosis. thanks -- PMM

Re: [Qemu-devel] [PULL 05/10] tcg: Put opcodes in a linked list

2015-01-12 Thread Peter Maydell
On 9 January 2015 at 21:23, Richard Henderson wrote: > The previous setup required ops and args to be completely sequential, > and was error prone when it came to both iteration and optimization. > > Signed-off-by: Richard Henderson > void tcg_gen_qemu_ld_i32(TCGv_i32 val, TCGv addr, TCGArg idx

Re: [Qemu-devel] [PATCH v2 2/2] e1000: decrement RDT if equal to RDH

2015-01-12 Thread Richard Tollerton
"Michael S. Tsirkin" writes: > Richard, can you respond please? > I'd like to see this clarified in code comment or > commit message before applying this patchset. Apologies, and thanks for reminding me. On Thu, Dec 18, 2014 at 12:01:48AM -0500, Jason Wang wrote: > > Some drivers set RDT=RDH.

Re: [Qemu-devel] master: intermittent acpi-test failures

2015-01-12 Thread Peter Maydell
On 12 January 2015 at 18:08, Peter Maydell wrote: > So we're just sat in a loop which never finishes. This > seems to be because the first time in to it we set > the loop counter EBP to 0x5b207801. Looking further up the trace we seem to be mistranslating movsbl: IN: 0x000f195e: movsbl (

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 18:31, John Snow wrote: >> How do you track which parts of the disk have been acted upon (e.g. >> mirrored in the case of the drive-mirror command), so that they have >> become 0? > > Hm... so your question here is, "What happens if the named bitmap you > are transferring gets res

Re: [Qemu-devel] master: intermittent acpi-test failures

2015-01-12 Thread Peter Maydell
On 12 January 2015 at 17:56, Peter Maydell wrote: > ...but I don't see why that "call 0xf106f" takes > us to f1064, which the trace says it does I think the trace is just confusing. Attaching in gdb we see: => 0xf1133: test %ebp,%ebp 0xf1135: jle0xf1144 0xf1137: mov(%

Re: [Qemu-devel] master: intermittent acpi-test failures

2015-01-12 Thread Peter Maydell
On 30 November 2014 at 15:12, Michael S. Tsirkin wrote: > On Sat, Nov 29, 2014 at 05:39:01PM +, Peter Maydell wrote: >> On 29 November 2014 at 17:36, Michael S. Tsirkin wrote: >> > My guess is VM fails to boot from disk for some reason. >> > Could you trigger a screenshot after this happens?

[Qemu-devel] [PULL v2 07/44] block: Get full backing filename from string

2015-01-12 Thread Stefan Hajnoczi
From: Max Reitz Introduce bdrv_get_full_backing_filename_from_filename(), a function which takes the name of the backed file and a potentially relative backing filename to produce the full (absolute) backing filename. Use this function from bdrv_get_full_backing_filename(). Signed-off-by: Max R

[Qemu-devel] [PULL v2 13/44] block: fix spoiling all dirty bitmaps by mirror and migration

2015-01-12 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Mirror and migration use dirty bitmaps for their purposes, and since commit [block: per caller dirty bitmap] they use their own bitmaps, not the global one. But they use old functions bdrv_set_dirty and bdrv_reset_dirty, which change all dirty bitmaps. Named di

Re: [Qemu-devel] [PATCH 2/4] pci: Add generic PCIe host bridge

2015-01-12 Thread Alexander Graf
On 12.01.15 18:36, alvise rigo wrote: > Hi Alexander, > > Just a comment below. > > On Tue, Jan 6, 2015 at 5:03 PM, Alexander Graf wrote: >> With simple exposure of MMFG, ioport window, mmio window and an IRQ line we >> can successfully create a workable PCIe host bridge that can be mapped >>

[Qemu-devel] [PULL v2 10/44] block/vmdk: Relative backing file for creation

2015-01-12 Thread Stefan Hajnoczi
From: Max Reitz When a vmdk image is created with a backing file, it is opened to check whether it is indeed a vmdk file by letting qemu probe it. When doing so, the backing filename is relative to the image's base directory so it should be interpreted accordingly. Signed-off-by: Max Reitz Revi

[Qemu-devel] [PULL v2 31/44] coroutine-ucontext: use __thread

2015-01-12 Thread Stefan Hajnoczi
From: Paolo Bonzini ELF thread local storage is about 10% faster on tests/test-coroutine's perf/cost test. The timing on my machine is 190ns per iteration with pthread TLS, 170 with ELF TLS. Based on a patch by Kevin Wolf and Peter Lieven, but redone to follow the model of coroutine-win32.c (in

[Qemu-devel] [PULL v2 09/44] block: Relative backing file for image creation

2015-01-12 Thread Stefan Hajnoczi
From: Max Reitz Relative backing filenames are always relative to the backed image's directory; the same applies to image creation. Therefore, if the backing file has to be opened for determining its size (in case the size has not been explicitly specified) its filename should be interpreted rela

[Qemu-devel] [PULL v2 08/44] block: JSON filenames and relative backing files

2015-01-12 Thread Stefan Hajnoczi
From: Max Reitz When using a relative backing file name, qemu needs to know the directory of the top image file. For JSON filenames, such a directory cannot be easily determined (e.g. how do you determine the directory of a qcow2 BDS directly on top of a quorum BDS?). Therefore, do not allow rela

Re: [Qemu-devel] [PATCH 2/4] pci: Add generic PCIe host bridge

2015-01-12 Thread alvise rigo
Hi Alexander, Just a comment below. On Tue, Jan 6, 2015 at 5:03 PM, Alexander Graf wrote: > With simple exposure of MMFG, ioport window, mmio window and an IRQ line we > can successfully create a workable PCIe host bridge that can be mapped > anywhere > and only needs to get described to the OS

[Qemu-devel] [PULL v2 18/44] iotests: Filter out "I/O thread spun..." warning

2015-01-12 Thread Stefan Hajnoczi
From: Max Reitz Filter out the "main loop: WARNING: I/O thread spun for..." warning from qemu output (it hardly matters for code specifically testing I/O). Furthermore, use _filter_qemu in all the custom functions which run qemu. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/q

[Qemu-devel] [PULL v2 29/44] qemu-iotests: Add "_supported_os Linux" to 058

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng Other cases have this, and this test is not portable as well, as we want to add "make check-block" to "make check", it shouldn't fail on Mac OS X. Reported-by: Peter Maydell Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/058 | 1 + 1 file chang

[Qemu-devel] [PULL v2 11/44] iotests: Add test for relative backing file names

2015-01-12 Thread Stefan Hajnoczi
From: Max Reitz Sometimes, qemu does not have a filename to work with, so it does not know which directory to use for a backing file specified by a relative filename. Add a test which tests that qemu exits with an appropriate error message. Additionally, add a test for qemu-img create with a bac

[Qemu-devel] [PULL v2 05/44] block: replace g_new0 with g_new for bottom half allocation.

2015-01-12 Thread Stefan Hajnoczi
From: Paolo Bonzini This saves about 15% of the clock cycles spent on allocation. Using the slice allocator does not add a visible improvement; allocation is faster than malloc, while freeing seems to be slower. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- async.c | 10 ++--

[Qemu-devel] [PULL v2 06/44] checkpatch: Brace handling on multi-line condition

2015-01-12 Thread Stefan Hajnoczi
From: Max Reitz CODING_STYLE states the following about braces around blocks: > The opening brace is on the line that contains the control flow > statement that introduces the new block; [...] This is obviously impossible with multi-line conditions. Therefore, CODING_STYLE does not make any cle

[Qemu-devel] [PULL v2 19/44] migration/block: fix pending() return value

2015-01-12 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Because of wrong return value of .save_live_pending() in migration/block.c, migration finishes before the whole disk is transferred. Such situation occurs when the migration process is fast enough, for example when source and dest are on the same host. If in th

[Qemu-devel] [PULL v2 12/44] qapi: Fix document for BlockStats.node-name

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Message-id: 1418694024-26498-1-git-send-email-f...@redhat.com Signed-off-by: Max Reitz --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json inde

[Qemu-devel] [PULL v2 14/44] qapi: Comment version info in TransactionAction

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Markus Armbruster Message-id: 1418899027-8445-2-git-send-email-f...@redhat.com Signed-off-by: Max Reitz --- qapi-schema.json | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qapi-sc

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-12 Thread John Snow
On 01/12/2015 11:48 AM, Paolo Bonzini wrote: On 11/12/2014 15:17, Vladimir Sementsov-Ogievskiy wrote: Just migrate parts of dirty bitmaps, corresponding to the block being migrated. Also, skip block migration if it is disabled (blk parameter of migrate command is false). So I have misread

[Qemu-devel] [PULL v2 16/44] block: Add blockdev-backup to transaction

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Markus Armbruster Message-id: 1418899027-8445-4-git-send-email-f...@redhat.com Signed-off-by: Max Reitz --- blockdev.c | 79 qap

[Qemu-devel] [PULL v2 00/44] Block patches

2015-01-12 Thread Stefan Hajnoczi
The following changes since commit 64ea8038ffbf703dcd438a108d2d5499c8ff95d9: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150109.0' into staging (2015-01-10 22:29:09 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-reques

[Qemu-devel] [PULL v2 17/44] qemu-iotests: Test blockdev-backup in 055

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng This applies cases on drive-backup on blockdev-backup, except cases with target format and mode. Also add a case to check source == target. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Reviewed-by: Markus Armbruster Message-id: 1418899027-8445-5-git-send-email-f...@redhat.

[Qemu-devel] [PULL v2 04/44] block: do not allocate an iovec per read of a growable/zero_after_eof BDS

2015-01-12 Thread Stefan Hajnoczi
From: Paolo Bonzini Most reads do not go past the end of the file, and they can use the input QEMUIOVector instead of creating one. This removes the qemu_iovec_* functions from the profile. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block.c | 12 +--- 1 file changed,

[Qemu-devel] [PULL v2 30/44] qemu-iotests: Add supported os parameter for python tests

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng If I understand correctly, qemu-iotests never meant to be portable. We only support Linux for all the shell cases, but didn't specify it for python tests. Now add this and default all the python tests as Linux only. If we cares enough later, we can override the parameter in indivi

[Qemu-devel] [PULL v2 02/44] qemu-iotests: Speed up make check-block

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng Using /tmp, which is usually mounted as tmpfs, the quick group can be quicker. On my laptop (Lenovo T430s with Fedora 20), this reduces the time from 50s to 30s. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests-quick.sh | 2 +-

[Qemu-devel] [PULL v2 03/44] block: mark AioContext as recursive

2015-01-12 Thread Stefan Hajnoczi
From: Paolo Bonzini AioContext can be accessed recursively, in fact that's what we do with aio_poll. Marking the GSource as recursive avoids that GLib blocks it and unblocks it around every call to aio_dispatch, which is a pretty expensive operation. Signed-off-by: Paolo Bonzini Signed-off-by:

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-12 Thread Alexander Graf
On 12.01.15 17:49, alvise rigo wrote: > Hi Alexander, > > Just a comment below. > > On Tue, Jan 6, 2015 at 5:03 PM, Alexander Graf wrote: >> Now that we have a working "generic" PCIe host bridge driver, we can plug >> it into ARMs virt machine to always have PCIe available to normal ARM VMs. >

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-12 Thread Paolo Bonzini
On 11/12/2014 15:17, Vladimir Sementsov-Ogievskiy wrote: > Just migrate parts of dirty bitmaps, corresponding to the block being > migrated. Also, skip block migration if it is disabled (blk parameter > of migrate command is false). So I have misread the patch. blk here: +static void blk_store_

[Qemu-devel] [PULL v2 44/44] NVMe: Set correct VS Value for 1.1 Compliant Controllers

2015-01-12 Thread Stefan Hajnoczi
From: Anubhav Rakshit According to NVMe specifications Bits 15:08 represent Minor Version number. Signed-off-by: Anubhav Rakshit Signed-off-by: Stefan Hajnoczi --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 4f70f

[Qemu-devel] [PULL v2 40/44] ide: Implement VPD response for ATAPI

2015-01-12 Thread Stefan Hajnoczi
From: John Snow SCSI devices have multiple kinds of queries they need to respond to, as defined in the "cmd inquiry" section in MMC-6 and SPC-3. Relevent sections: MMC-6 revision 2g: Non-VPD response data and pointer to SPC-3; Section 6.8 "Inquiry Command" SPC-3 revision 23: In

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-12 Thread alvise rigo
Hi Alexander, Just a comment below. On Tue, Jan 6, 2015 at 5:03 PM, Alexander Graf wrote: > Now that we have a working "generic" PCIe host bridge driver, we can plug > it into ARMs virt machine to always have PCIe available to normal ARM VMs. > > I've successfully managed to expose a Bochs VGA d

[Qemu-devel] [PULL v2 37/44] coroutine: try harder not to delete coroutines

2015-01-12 Thread Stefan Hajnoczi
From: Peter Lieven Placing coroutines on the global pool should be preferrable, because it can help all threads. But if the global pool is full, we can still try to save some allocations by stashing completed coroutines on the local pool. This is quite cheap too, because it does not require ato

[Qemu-devel] [PULL v2 23/44] libqos: Remove PCI assumptions in constants of virtio driver

2015-01-12 Thread Stefan Hajnoczi
From: Marc Marí Convert PCI-specific constants names of libqos virtio driver. Signed-off-by: Marc Marí Signed-off-by: Stefan Hajnoczi --- tests/libqos/virtio-pci.c | 30 +++--- tests/libqos/virtio-pci.h | 24 tests/virtio-blk-test.c | 11

[Qemu-devel] [PULL v2 01/44] qemu-iotests: Remove 091 from quick group

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng For the purpose of allowing running quick group on tmpfs. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index a4742c6..0809

[Qemu-devel] [PULL v2 15/44] qmp: Add command 'blockdev-backup'

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible but is an illegal case wi

[Qemu-devel] [PULL v2 27/44] .gitignore: Ignore generated "common.env"

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index e32a584..090f974 100644 --- a/.gitignore +++ b/.gitignore @@ -109,3 +109,4 @@ cscope.* tags TAGS *~ +/tests/qemu-iotests/c

[Qemu-devel] [PULL v2 43/44] MAINTAINERS: Add migration/block* to block subsystem

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng We are moving block-migration.c to the separated migration directory, keep this file watched by block maintainers is a good idea. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINE

[Qemu-devel] [PULL v2 25/44] libqos: Add virtio MMIO support

2015-01-12 Thread Stefan Hajnoczi
From: Marc Marí Add virtio MMIO support. Add virtio-blk-test MMIO test case. Signed-off-by: Marc Marí Signed-off-by: Stefan Hajnoczi --- tests/Makefile | 4 +- tests/libqos/virtio-mmio.c | 190 + tests/libqos/virtio-mmio.h | 46 ++

[Qemu-devel] [PULL v2 28/44] qemu-iotests: Replace "/bin/true" with "true"

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng The former is not portable because on Mac OSX it is /usr/bin/true. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/common.config | 2 +- tests/qemu-iotests/common.filter | 2 +- tests/qemu-iotests/common.rc | 2 +- 3 files changed, 3 insertio

[Qemu-devel] [PULL v2 38/44] block: limited request size in write zeroes unsupported path

2015-01-12 Thread Stefan Hajnoczi
From: Peter Lieven If bs->bl.max_write_zeroes is large and we end up in the unsupported path we might allocate a lot of memory for the iovector and/or even generate an oversized requests. Fix this by limiting the request by the minimum of the reported maximum transfer size or 16MB (32768 sectors

[Qemu-devel] [PULL v2 34/44] QSLIST: add lock-free operations

2015-01-12 Thread Stefan Hajnoczi
From: Paolo Bonzini These operations are trivial to implement and do not have ABA problems. They are enough to implement simple multiple-producer, single consumer lock-free lists or, as in the next patch, the multiple consumers can steal a whole batch of elements and process them at their leisure

[Qemu-devel] [PULL v2 42/44] MAINTAINERS: Update email addresses for Chrysostomos Nanakos

2015-01-12 Thread Stefan Hajnoczi
From: Chrysostomos Nanakos Remove first email address and let the one from which I am contributing. Signed-off-by: Chrysostomos Nanakos Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7fc3cdb..f2e88ae 100644 ---

[Qemu-devel] [PATCH v2] Makes -full-screen option work on Mac OS X

2015-01-12 Thread Programmingkid
This patch makes the -full-screen option actually instruct QEMU to enter fullscreen at startup. Signed-off-by: John Arbuckle --- Removed the set_to_full_screen variable. Removed the scanForFullScreenOption() function. ui/cocoa.m |6 ++ 1 files changed, 6 insertions(+), 0 deletions(

[Qemu-devel] [PULL v2 24/44] libqos: Add malloc generic

2015-01-12 Thread Stefan Hajnoczi
From: Marc Marí This malloc is a basic interface implementation that works for any platform. It should be replaced in the future for a real malloc implementation for each of the platforms. Signed-off-by: Marc Marí Signed-off-by: Stefan Hajnoczi --- tests/libqos/malloc-generic.c | 50 +

[Qemu-devel] [PULL v2 41/44] nvme: Fix get/set number of queues feature

2015-01-12 Thread Stefan Hajnoczi
From: Alex Friedman According to the specification, the low 16 bits should contain the number of I/O submission queues, and the high 16 bits should contain the number of I/O completion queues. Signed-off-by: Alex Friedman Acked-by: Keith Busch Signed-off-by: Stefan Hajnoczi --- hw/block/nvme

Re: [Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-12 Thread Alexander Graf
On 12.01.15 17:20, Claudio Fontana wrote: > Just adding a nit here below: > > On 06.01.2015 17:03, Alexander Graf wrote: >> Now that we have a working "generic" PCIe host bridge driver, we can plug >> it into ARMs virt machine to always have PCIe available to normal ARM VMs. >> >> I've successfu

[Qemu-devel] [PULL v2 22/44] tests: Prepare virtio-blk-test for multi-arch implementation

2015-01-12 Thread Stefan Hajnoczi
From: Marc Marí Modularize functions in virtio-blk-test and add PCI suffix for PCI specific components. Signed-off-by: Marc Marí Signed-off-by: Stefan Hajnoczi --- tests/virtio-blk-test.c | 146 1 file changed, 85 insertions(+), 61 deletions(-)

[Qemu-devel] [PULL v2 26/44] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2015-01-12 Thread Stefan Hajnoczi
From: Programmingkid Signed-off-by: John Arbuckle Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 18 +- configure | 2 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index e51293a..16fa0a4 100644 --- a/b

[Qemu-devel] [PULL v2 20/44] libqos: Convert malloc-pc allocator to a generic allocator

2015-01-12 Thread Stefan Hajnoczi
From: Marc Marí The allocator in malloc-pc has been extracted, so it can be used in every arch. This operation showed that both the alloc and free functions can be also generic. Because of this, the QGuestAllocator has been removed from is function to wrap the alloc and free function, and now jus

[Qemu-devel] [PULL v2 21/44] libqos: Change use of pointers to uint64_t in virtio

2015-01-12 Thread Stefan Hajnoczi
From: Marc Marí Convert use of pointers in functions of virtio to uint64_t in order to make it platform-independent. Add casting from pointers (in PCI functions) to uint64_t and vice versa through uintptr_t. Signed-off-by: Marc Marí Signed-off-by: Stefan Hajnoczi --- tests/libqos/virtio-pci.

[Qemu-devel] [PATCH v11 10/13] qapi: Add transaction support to block-dirty-bitmap-{add, enable, disable}

2015-01-12 Thread John Snow
From: Fam Zheng This adds three qmp commands to transactions. Users can stop a dirty bitmap, start backup of it, and start another dirty bitmap atomically, so that the dirty bitmap is tracked incrementally and we don't miss any write. Signed-off-by: Fam Zheng Signed-off-by: John Snow --- blo

[Qemu-devel] [PULL v2 39/44] block: Split BLOCK_OP_TYPE_COMMIT to BLOCK_OP_TYPE_COMMIT_{SOURCE, TARGET}

2015-01-12 Thread Stefan Hajnoczi
From: Fam Zheng Like BLOCK_OP_TYPE_BACKUP_SOURCE and BLOCK_OP_TYPE_BACKUP_TARGET, block-commit involves two asymmetric devices. This change is not user-visible (yet), because commit only works with device names. But once we enable backing reference in blockdev-add, or specifying node-name in bl

[Qemu-devel] [PULL v2 35/44] coroutine: rewrite pool to avoid mutex

2015-01-12 Thread Stefan Hajnoczi
From: Paolo Bonzini This patch removes the mutex by using fancy lock-free manipulation of the pool. Lock-free stacks and queues are not hard, but they can suffer from the ABA problem so they are better avoided unless you have some deferred reclamation scheme like RCU. Otherwise you have to stic

[Qemu-devel] [PULL v2 36/44] coroutine: drop qemu_coroutine_adjust_pool_size

2015-01-12 Thread Stefan Hajnoczi
From: Paolo Bonzini This is not needed anymore. The new TLS-based algorithm is adaptive. Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Message-id: 1417518350-6167-7-git-send-email-pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi --- block/block-backend.c | 4 include/block

[Qemu-devel] [PATCH v11 02/13] qapi: Add optional field "name" to block dirty bitmap

2015-01-12 Thread John Snow
From: Fam Zheng This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a common name. Implemented

[Qemu-devel] [PULL v2 32/44] qemu-thread: add per-thread atexit functions

2015-01-12 Thread Stefan Hajnoczi
From: Paolo Bonzini Destructors are the main additional feature of pthread TLS compared to __thread. If we were using C++ (hint, hint!) we could have used thread-local objects with a destructor. Since we are not, instead, we add a simple Notifier-based API. Note that the notifier must be per-t

[Qemu-devel] [PULL v2 33/44] test-coroutine: avoid overflow on 32-bit systems

2015-01-12 Thread Stefan Hajnoczi
From: Paolo Bonzini unsigned long is not large enough to represent 10 * duration there. Just use floating point. Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Message-id: 1417518350-6167-4-git-send-email-pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/test-coroutin

[Qemu-devel] [PATCH v11 07/13] qmp: Add block-dirty-bitmap-enable and block-dirty-bitmap-disable

2015-01-12 Thread John Snow
From: Fam Zheng This allows to put the dirty bitmap into a disabled state where no more writes will be tracked. It will be used before backup or writing to persistent file. Signed-off-by: Fam Zheng Signed-off-by: John Snow --- block.c | 24 +++- blockdev.c

  1   2   3   4   >