[Qemu-devel] [Bug 1405385] Re: QEMU crashes when virtio network cards are used together with e1000 network cards

2015-01-08 Thread Bram Klein Gunnewiek
I'm not sure if there is more information required from my side? I can still reproduce this and have no clue where to look for more information. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1405385

Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

2015-01-08 Thread Amit Shah
On (Thu) 08 Jan 2015 [11:11:29], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > If the remote host, or networking dies during a migration, the socket can be > waiting for a long timeout, and migration_cancel can't complete the cancel > for a long time (and you can't star

Re: [Qemu-devel] [PATCH 1/3] socket shutdown

2015-01-08 Thread Amit Shah
On (Thu) 08 Jan 2015 [11:11:30], Dr. David Alan Gilbert (git) wrote: > static const QEMUFileOps socket_write_ops = { > -.get_fd = socket_get_fd, > +.get_fd= socket_get_fd, > .writev_buffer = socket_writev_buffer, > -.close = socket_close > +.close = s

Re: [Qemu-devel] Fwd: [question] About MSI for vioscsi

2015-01-08 Thread Wangting (Kathy)
On 2015-1-8 18:03, Vadim Rozenfeld wrote: > On Thu, 2015-01-08 at 17:27 +0800, Wangting (Kathy) wrote: >> >> On 2015-1-8 17:01, Vadim Rozenfeld wrote: >>> On Thu, 2015-01-08 at 16:40 +0800, Wangting (Kathy) wrote: Hi Vadim, In order to enable MSI for vioscsi in virtio-win-0.1-74

Re: [Qemu-devel] [PATCH 2/4] qemu-timer: add timer_init and timer_init_ns/us/ms

2015-01-08 Thread Fam Zheng
On Thu, 01/08 11:03, Paolo Bonzini wrote: > These functions for the main loop TimerListGroup will replace > timer_new and timer_new_ns/us/ms. > > Signed-off-by: Paolo Bonzini > --- > include/qemu/timer.h | 73 > > 1 file changed, 73 insertion

Re: [Qemu-devel] [PATCH 0/4] qemu-timer: introduce usable pointer-free API

2015-01-08 Thread Fam Zheng
On Thu, 01/08 11:03, Paolo Bonzini wrote: > The current pointer free API for timers is very low level. Introduce > a new API that matches timer_new_ns/us/ms and also a new API timer_deinit > that can be used instead of timer_free. > > Finally, mechanically change timer macro names in vmstate, to

[Qemu-devel] Press Inquiry: Qemu Advent Calendar (German Linux Magazin)

2015-01-08 Thread Tim Schürmann
Hi! I'm responsible for the content of the DVD that is shipped with each printed issue of the german Linux Magazin. I would like to ask, if we could use the Qemu images/virtual machines from your Qemu Advent Calendar 2014 (well at least the ones with Open-Source-Software :)). Best regards,

[Qemu-devel] [PATCH v3] spapr-pci: Enable huge BARs

2015-01-08 Thread Alexey Kardashevskiy
At the moment sPAPR only supports 512MB window for MMIO BARs. However modern devices might want bigger 64bit BARs. This extends MMIO window from 512MB to 62GB (aligned to SPAPR_PCI_WINDOW_SPACING) and advertises it in 2 records in the PHB "ranges" property. 32bit gets the space from SPAPR_PCI_MEM_

[Qemu-devel] [RFC PATCH] spapr_vio/spapr_iommu: Move VIO bypass where it belongs

2015-01-08 Thread Alexey Kardashevskiy
Instead of tweaking a TCE table device by adding there a bypass flag, let's add an alias to RAM and IOMMU memory region, and enable/disable those according to the selected bypass mode. This way IOMMU memory region can have size of the actual window rather than ram_size which is essential for upcomi

[Qemu-devel] [PATCH v2] Fix irq route entries exceed KVM_MAX_IRQ_ROUTES

2015-01-08 Thread 马文霜
Last month, we experienced several guests crash(6cores-8cores), qemu logs display the following messages: qemu-system-x86_64: /build/qemu-2.1.2/kvm-all.c:976: kvm_irqchip_commit_routes: Assertion `ret == 0' failed. After analysis and verification, we can confirm it's irq-balance daemon(in guest)

Re: [Qemu-devel] [PATCH] qga: add guest-set-admin-password command

2015-01-08 Thread Michael Roth
Quoting Daniel P. Berrange (2014-12-15 06:47:46) > Add a new 'guest-set-admin-password' command for changing the > root/administrator password. This command is needed to allow > OpenStack to support its API for changing the admin password > on a running guest. > > Accepts either the raw password s

Re: [Qemu-devel] [libvirt-users] Using virsh blockcopy -- what's it supposed to accomplish?

2015-01-08 Thread Gary R Hook
On 1/8/15 3:04 PM, Eric Blake wrote: Where are you specifying the format? I have not personally played with NBD much. This appears to be the pervasive situation. There's not much out there in google-land about this. But here's my guess: Even though /tmp/dsk.test.qcow2 is a qcow2 file, th

Re: [Qemu-devel] [libvirt-users] Using virsh blockcopy -- what's it supposed to accomplish?

2015-01-08 Thread Gary R Hook
On 1/8/15 2:21 PM, Kashyap Chamarthy wrote: qemu-img create -f qcow2 /tmp/dsk.test.qcow2 A typo? You also need to provide a size here: $ qemu-img create -f qcow2 /tmp/dsk.test.qcow2 1G Yes, my mistake. The size is set to the potential size of the source disk, which in this case is 20G

Re: [Qemu-devel] [RFC PATCH] qga: implement guest-network-get-interfaces command for windows

2015-01-08 Thread Michael Roth
Quoting Michael Roth (2015-01-08 17:29:43) > Quoting zhanghailiang (2014-12-24 04:21:20) > > Signed-off-by: zhanghailiang > > --- > > Hi, > > > > This patch implements guest-network-get-interfaces command for > > Windows. > > > > This patch is RFC because the value of network 'prefix' length may

Re: [Qemu-devel] [RFC PATCH] qga: implement guest-network-get-interfaces command for windows

2015-01-08 Thread Michael Roth
Quoting zhanghailiang (2014-12-24 04:21:20) > Signed-off-by: zhanghailiang > --- > Hi, > > This patch implements guest-network-get-interfaces command for > Windows. > > This patch is RFC because the value of network 'prefix' length may be wrong > When there is an adapter with multiple IP which h

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-08 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/01/2015 23:45, Eric Blake wrote: >>> The bitmaps are transmitted many times in their entirety, but >>> only the last copy actually means something. The others are >>> lost. This means you should use the non-live interface >>> (register_savevm

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-08 Thread Eric Blake
On 01/08/2015 03:36 PM, Paolo Bonzini wrote: > > > On 11/12/2014 15:17, Vladimir Sementsov-Ogievskiy wrote: >> Just migrate parts of dirty bitmaps, corresponding to the block being >> migrated. Also, skip block migration if it is disabled (blk parameter >> of migrate command is false). >> >> Skip

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 23:28, Gerhard Wiesinger wrote: >> > > Updated to 2.2.0 qemu-kvm release, worked seemless so far for all VMs. > > I'll keep you up to date in the next days whether it happens again or not. > > BTW: Has something changed in the time code area between 1.6.2 and 2.1.2? Most of this

Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 22:51, John Snow wrote: > CC'ing Eric Blake for monitor interface review. See also my review of patch 9. Paolo

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-08 Thread Paolo Bonzini
On 11/12/2014 15:17, Vladimir Sementsov-Ogievskiy wrote: > Just migrate parts of dirty bitmaps, corresponding to the block being > migrated. Also, skip block migration if it is disabled (blk parameter > of migrate command is false). > > Skipping shared sectors: bitmaps are migrated independently

Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

2015-01-08 Thread John Snow
On 01/08/2015 05:29 PM, Eric Blake wrote: On 01/08/2015 02:51 PM, John Snow wrote: CC'ing Eric Blake for monitor interface review. Indeed, I already saw and reviewed the monitor interface in a mail dated Dec 11. Sorry, I missed that one. Thank you, though :) On 12/11/2014 09:17 AM, Vla

Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

2015-01-08 Thread Eric Blake
On 01/08/2015 02:51 PM, John Snow wrote: > CC'ing Eric Blake for monitor interface review. Indeed, I already saw and reviewed the monitor interface in a mail dated Dec 11. > > On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: >> Add dirty parameter to qmp-migrate command. If this param

Re: [Qemu-devel] [PATCH 7/9] block-migration: remove not needed iothread lock

2015-01-08 Thread Paolo Bonzini
On 11/12/2014 15:17, Vladimir Sementsov-Ogievskiy wrote: > -qemu_mutex_lock_iothread(); > +bdrv_reset_dirty_bitmap(bs, bmds->dirty_bitmap, cur_sector, nr_sectors); > + > blk->aiocb = bdrv_aio_readv(bs, cur_sector, &blk->qiov, > nr_sectors, blk_mig_rea

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-08 Thread Gerhard Wiesinger
On 08.01.2015 19:22, Paolo Bonzini wrote: On 08/01/2015 19:12, Gerhard Wiesinger wrote: Since kernels were the same on FC20/F21 and qemu/kvm changed from 1.6.2 to 2.1.2 I guess the topic seems to be there. Also newer gcc might be a topic. Indeed. Can you try the 2.2.0 qemu-kvm release, availa

Re: [Qemu-devel] [PATCH 9/9] block-migration: add named dirty bitmaps migration

2015-01-08 Thread John Snow
CCing migration maintainers, feedback otherwise in-line. On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Just migrate parts of dirty bitmaps, corresponding to the block being migrated. Also, skip block migration if it is disabled (blk parameter of migrate command is false). Skipping

Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

2015-01-08 Thread John Snow
CC'ing Eric Blake for monitor interface review. On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add dirty parameter to qmp-migrate command. If this parameter is true, block-migration.c will migrate dirty bitmaps. This parameter can be used without "blk" parameter to migrate only dirt

Re: [Qemu-devel] [PATCH 4/9] hbitmap: store / restore

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 22:21, John Snow wrote: > Why are the conversions to little endian, though? Shouldn't we be > serializing to a Big Endian format? Because reading two 32-bit little-endian longs or a 64-bit little-endian long gives the same value. This is not true for big-endian. Take the followin

Re: [Qemu-devel] [PATCH 7/9] block-migration: remove not needed iothread lock

2015-01-08 Thread John Snow
On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Instead of locking iothread, we can just swap these calls. So, if some write to our range occures before resetting the bitmap, then it will get into subsequent aio read, becouse it occures, in any case, after resetting the bitmap. s

Re: [Qemu-devel] [PATCH 6/9] block-migration: tiny refactoring

2015-01-08 Thread John Snow
On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Add blk_create and blk_free to remove code duplicates. Otherwise, duplicates will rise in the following patches because of BlkMigBlock sturcture extendin. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block-migration.c | 56 +

Re: [Qemu-devel] [PATCH 5/9] block: BdrvDirtyBitmap store/restore interface

2015-01-08 Thread John Snow
On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Several functions to provide necessary access to BdrvDirtyBitmap for block-migration.c Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 61 +-- include/block/b

Re: [Qemu-devel] [PATCH 4/9] hbitmap: store / restore

2015-01-08 Thread John Snow
On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Functions to store / restore HBitmap. HBitmap should be saved to linear bitmap format independently of endianess. Because of restoring in several steps, every step writes only the last level of the bitmap. All other levels are restore

Re: [Qemu-devel] [PATCH 2/9] block-migration: fix pending() return value

2015-01-08 Thread John Snow
On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Because of wrong return value of .save_live_pending() in block-migration, migration finishes before the whole disk is transferred. Such situation occures when the migration (occurs) process is fast enouth, for example when source and

Re: [Qemu-devel] [PATCH 3/9] block: fix spoiling all dirty bitmaps by mirror and migration

2015-01-08 Thread John Snow
On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: Mirror and migration use dirty bitmaps for their purposes, and since commit [block: per caller dirty bitmap] they use their own bitmaps, not the global one. But they use old functions bdrv_set_dirty and bdrv_reset_dirty, which change a

Re: [Qemu-devel] [PATCH 1/9] block: rename bdrv_reset_dirty_bitmap

2015-01-08 Thread John Snow
On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote: We will need functions for set/unset a subregion of BdrvDirtyBitmap, to fix migration and mirror (accordingly to the following patch "block: fix spoiling all dirty bitmaps by mirror and migration"). Having the old function 'bdrv_reset_

Re: [Qemu-devel] [libvirt-users] Using virsh blockcopy -- what's it supposed to accomplish?

2015-01-08 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/01/2015 22:04, Eric Blake wrote: > Where are you specifying the format? I have not personally played > with NBD much. But here's my guess: Even though > /tmp/dsk.test.qcow2 is a qcow2 file, the NBD server is serving up a > RAW image through

Re: [Qemu-devel] [libvirt-users] Using virsh blockcopy -- what's it supposed to accomplish?

2015-01-08 Thread Eric Blake
On 01/08/2015 12:44 PM, Gary R Hook wrote: > I've learned how to use the blockcopy command to create a local copy in > a simple disk file: > > virsh dumpxml my_domain > my_domain.xml > virsh undefine my_domain > virsh blockcopy --domain my_domain vda $PWD/dsk.copy.qcow2 --wait > --verbose --finis

Re: [Qemu-devel] [libvirt-users] Using virsh blockcopy -- what's it supposed to accomplish?

2015-01-08 Thread Kashyap Chamarthy
On Thu, Jan 08, 2015 at 01:44:58PM -0600, Gary R Hook wrote: > On 12/24/14 4:42 AM, Kashyap Chamarthy wrote: > >On Tue, Dec 23, 2014 at 12:38:57PM -0600, Gary R Hook wrote: > > > >[. . .] > > > >In my case, the block device is a QCOW2 disk image file. If I boot > >without using the disk image file

Re: [Qemu-devel] [libvirt-users] Using virsh blockcopy -- what's it supposed to accomplish?

2015-01-08 Thread Gary R Hook
On 12/24/14 4:42 AM, Kashyap Chamarthy wrote: On Tue, Dec 23, 2014 at 12:38:57PM -0600, Gary R Hook wrote: [. . .] In my case, the block device is a QCOW2 disk image file. If I boot without using the disk image file which has the operating system, the domain will fail to boot, no? I see you're

[Qemu-devel] [RFC PATCH v3] tests: rtl8139: test timers and interrupt

2015-01-08 Thread Frediano Ziglio
Test behaviour of timers and interrupts related to timeouts. Signed-off-by: Frediano Ziglio --- tests/Makefile | 2 +- tests/rtl8139-test.c | 181 +++ 2 files changed, 182 insertions(+), 1 deletion(-) This patch was derived from a test I d

[Qemu-devel] [PATCH 87/88] target-xtensa: test cross-page opcode

2015-01-08 Thread Michael Roth
From: Max Filippov Alter cross-page TB test to also test cross-page opcode. Signed-off-by: Max Filippov (cherry picked from commit 85d36377e4ff8b98119420099d445369bfd6b7bb) Signed-off-by: Michael Roth --- tests/tcg/xtensa/test_mmu.S | 26 +- 1 file changed, 13 insertio

[Qemu-devel] [PATCH 88/88] pc: acpi: mark all possible CPUs as enabled in SRAT

2015-01-08 Thread Michael Roth
From: Igor Mammedov If QEMU is started with -numa ... Windows only notices that CPU has been hot-added but it will not online such CPUs. It's caused by the fact that possible CPUs are flagged as not enabled in SRAT and Windows honoring that information doesn't use corresponding CPU. ACPI 5.0 S

[Qemu-devel] [PATCH 75/88] qcow2: Prevent numerical overflow

2015-01-08 Thread Michael Roth
From: Max Reitz In qcow2_alloc_cluster_offset(), *num is limited to INT_MAX >> BDRV_SECTOR_BITS by all callers. However, since remaining is of type uint64_t, we might as well cast *num to that type before performing the shift. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kev

[Qemu-devel] [PATCH 81/88] qcow2.py: Add required padding for header extensions

2015-01-08 Thread Michael Roth
From: Kevin Wolf The qcow2 specification requires that the header extension data be padded to round up the extension size to the next multiple of 8 bytes. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Message-id: 1416935562-7760-3-git-send-email-kw...@redhat.com Signed-off-by: Stefan Hajnoc

[Qemu-devel] [PATCH 76/88] qcow2: Flushing the caches in qcow2_close may fail

2015-01-08 Thread Michael Roth
From: Max Reitz qcow2_cache_flush() may fail; if one of the caches failed to be flushed successfully to disk in qcow2_close() the image should not be marked clean, and we should emit a warning. This breaks the (qcow2-specific) iotests 026, 071 and 089; change their output accordingly. Cc: qemu-

[Qemu-devel] [PATCH 69/88] block/nfs: Add create_opts

2015-01-08 Thread Michael Roth
From: Max Reitz The nfs protocol driver is capable of creating images, but did not specify any creation options. Fix it. A way to test this issue is the following: $ qemu-img create -f nfs nfs://127.0.0.1/foo.qcow2 64M Without this patch, it segfaults. With this patch, it does not. However, th

[Qemu-devel] [PATCH 70/88] block: Check create_opts before image creation

2015-01-08 Thread Michael Roth
From: Max Reitz If a driver supports image creation, it needs to set the .create_opts field. We can use that to make sure .create_opts for both drivers involved is not NULL in bdrv_img_create(), which is important so that the create_opts pointer in that function is not NULL after the qemu_opts_ap

[Qemu-devel] [PATCH 65/88] virtio-net: fix unmap leak

2015-01-08 Thread Michael Roth
From: Jason Wang virtio_net_handle_ctrl() and other functions that process control vq request call iov_discard_front() which will shorten the iov. This will lead unmapping in virtqueue_push() leaks mapping. Fixes this by keeping the original iov untouched and using a temp variable in those funct

[Qemu-devel] [PATCH 63/88] exec: Handle multipage ranges in invalidate_and_set_dirty()

2015-01-08 Thread Michael Roth
From: Peter Maydell The code in invalidate_and_set_dirty() needs to handle addr/length combinations which cross guest physical page boundaries. This can happen, for example, when disk I/O reads large blocks into guest RAM which previously held code that we have cached translations for. Unfortunat

[Qemu-devel] [PATCH 86/88] target-xtensa: fix translation for opcodes crossing page boundary

2015-01-08 Thread Michael Roth
From: Max Filippov If TB ends with an opcode that crosses page boundary and the following page is not executable then EPC1 for the code fetch exception wrongly points at the beginning of the TB. Always treat instruction that crosses page boundary as a separate TB. Cc: qemu-sta...@nongnu.org Sign

[Qemu-devel] [PATCH 59/88] kvm: Fix memory slot page alignment logic

2015-01-08 Thread Michael Roth
From: Alexander Graf Memory slots have to be page aligned to get entered into KVM. There is existing logic that tries to ensure that we pad memory slots that are not page aligned to the biggest region that would still fit in the alignment requirements. Unfortunately, that logic is broken. It tri

[Qemu-devel] [PATCH 82/88] block: Don't probe for unknown backing file format

2015-01-08 Thread Michael Roth
From: Kevin Wolf If a qcow2 image specifies a backing file format that doesn't correspond to any format driver that qemu knows, we shouldn't fall back to probing, but simply error out. Not looking up the backing file driver in bdrv_open_backing_file(), but just filling in the "driver" option if

[Qemu-devel] [PATCH 61/88] libcacard: fix resource leak

2015-01-08 Thread Michael Roth
From: zhanghailiang In function connect_to_qemu(), getaddrinfo() will allocate memory that is stored into server, it should be freed by using freeaddrinfo() before connect_to_qemu() return. Cc: qemu-sta...@nongnu.org Reviewed-by: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Pa

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 19:12, Gerhard Wiesinger wrote: > Since kernels were the same on FC20/F21 and qemu/kvm changed from > 1.6.2 to 2.1.2 I guess the topic seems to be there. Also newer gcc > might be a topic. Indeed. Can you try the 2.2.0 qemu-kvm release, available in the fedora-virt-preview reposit

[Qemu-devel] [PATCH 83/88] linuxboot: compute initrd loading address

2015-01-08 Thread Michael Roth
From: Paolo Bonzini Even though hw/i386/pc.c tries to compute a valid loading address for the initrd, close to the top of RAM, this does not take into account other data that is malloced into that memory by SeaBIOS. Luckily we can easily look at the memory map to find out how much memory is used

[Qemu-devel] [PATCH 23/88] ivshmem: Fix potential OOB r/w access

2015-01-08 Thread Michael Roth
From: Sebastian Krahmer Fix OOB access via malformed incoming_posn parameters and check that requested memory is actually alloc'ed. Signed-off-by: Sebastian Krahmer [AF: Rebased, cleanups, avoid fd leak] Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PATCH 84/88] linuxboot: fix loading old kernels

2015-01-08 Thread Michael Roth
From: Paolo Bonzini Old kernels that used high memory only allowed the initrd to be in the first 896MB of memory. If you load the initrd above, they complain that "initrd extends beyond end of memory". In order to fix this, while not breaking machines with small amounts of memory fixed by cdebe

[Qemu-devel] [PATCH 80/88] qcow2: Fix header extension size check

2015-01-08 Thread Michael Roth
From: Kevin Wolf After reading the extension header, offset is incremented, but not checked against end_offset any more. This way an integer overflow could happen when checking whether the extension end is within the allowed range, effectively disabling the check. This patch adds the missing che

[Qemu-devel] [PATCH 50/88] vnc: sanitize bits_per_pixel from the client

2015-01-08 Thread Michael Roth
From: Petr Matousek bits_per_pixel that are less than 8 could result in accessing non-initialized buffers later in the code due to the expectation that bytes_per_pixel value that is used to initialize these buffers is never zero. To fix this check that bits_per_pixel from the client is one of th

[Qemu-devel] [PATCH 74/88] iotests: Add test for unsupported image creation

2015-01-08 Thread Michael Roth
From: Max Reitz Add a test for creating and amending images (amendment uses the creation options) with formats not supporting creation over protocols not supporting creation. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked f

[Qemu-devel] [PATCH 85/88] audio: Don't free hw resources until after hw backend is stopped

2015-01-08 Thread Michael Roth
From: Peter Maydell When stopping an audio voice, call the audio backend's fini method before calling audio_pcm_hw_free_resources_ rather than afterwards. This allows backends which use helper threads (like pulseaudio) to terminate those threads before the conv_buf or mix_buf are freed and avoids

[Qemu-devel] [PATCH 41/88] pc: Fix disabling of vapic for compat PC models

2015-01-08 Thread Michael Roth
From: Jan Kiszka We used to be able to address both the QEMU and the KVM APIC via "apic". This doesn't work anymore. So we need to use their parent class to turn off the vapic on machines that should not expose them. Signed-off-by: Jan Kiszka Reviewed-by: Michael S. Tsirkin Signed-off-by: Mich

[Qemu-devel] [PATCH 77/88] qcow2: Respect bdrv_truncate() error

2015-01-08 Thread Michael Roth
From: Max Reitz bdrv_truncate() may fail and qcow2_write_compressed() should return the error code in that case. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit 6a69b9620ac1562a067990d87284a85552bfd61b) Conflict

[Qemu-devel] [PATCH 72/88] qemu-img: Check create_opts before image amendment

2015-01-08 Thread Michael Roth
From: Max Reitz The image options which can be amended are described by the .create_opts field for every driver. This field must therefore be non-NULL so that anything can be amended in the first place. Check that this holds true before going into qemu_opts_create() (because if .create_opts is NU

[Qemu-devel] [PATCH 37/88] virtio-rng: fix virtio-rng child refcount in transports

2015-01-08 Thread Michael Roth
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-rng child is not finalized! Dr

[Qemu-devel] [PATCH 73/88] iotests: Only kill NBD server if it runs

2015-01-08 Thread Michael Roth
From: Max Reitz There may be NBD tests which do not create a sample image and simply test whether wrong usage of the protocol is rejected as expected. In this case, there will be no NBD server and trying to kill it during clean-up will fail. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz R

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-01-08 Thread Gerhard Wiesinger
On 08.01.2015 18:24, Paolo Bonzini wrote: On 08/01/2015 14:36, Gerhard Wiesinger wrote: Quitting and reattaching gdb also hangs here, so gettimeofday takes 100% CPU and never ends! Therefore I guess this is a problem either in the Linux kernel or in QEMU/KVM. What kernel are you running on (a

[Qemu-devel] [PATCH 79/88] block migration: fix return value

2015-01-08 Thread Michael Roth
From: Gary R Hook Modify block_save_iterate() to return positive/zero/negative (success/not done/failure) return status. The computation of the blocks transferred (an int64_t) exceeds the size of an int return value. Signed-off-by: Gary R Hook Reviewed-by: ChenLiang Reviewed-by: Stefan Hajnocz

[Qemu-devel] [PATCH 44/88] vmware-vga: use vmsvga_verify_rect in vmsvga_update_rect

2015-01-08 Thread Michael Roth
From: Gerd Hoffmann Switch vmsvga_update_rect over to use vmsvga_verify_rect. Slight change in behavior: We don't try to automatically fixup rectangles any more. In case we find invalid update requests we'll do a full-screen update instead. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffma

[Qemu-devel] [PATCH 67/88] block: Omit bdrv_find_format for essential drivers

2015-01-08 Thread Michael Roth
From: Max Reitz We can always assume raw, file and qcow2 being available; so do not use bdrv_find_format() to locate their BlockDriver objects but statically reference the respective objects. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf (cherry picked from comm

[Qemu-devel] [PATCH 64/88] hw/ide/core.c: Prevent SIGSEGV during migration

2015-01-08 Thread Michael Roth
From: Don Slutz The other callers to blk_set_enable_write_cache() in this file already check for s->blk == NULL. Signed-off-by: Don Slutz Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Message-id: 1416259239-13281-1-git-send-email-dsl...@verizon.com Cc: qemu-sta...@nongnu.org Signed-

[Qemu-devel] [PATCH 78/88] block/raw-posix: Fix ret in raw_open_common()

2015-01-08 Thread Michael Roth
From: Max Reitz The return value must be negative on error; there is one place in raw_open_common() where errp is set, but ret remains 0. Fix it. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit 01212d4ed68fc8daa2

[Qemu-devel] [PATCH 29/88] vhost-scsi: use virtio_ldl_p

2015-01-08 Thread Michael Roth
From: Paolo Bonzini This helps for cross-endian configurations. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini (cherry picked from commit 7ce0425575745a40e94e75426607e0bec17899fa) Signed-off-by: Michael Roth --- hw/scsi/vhost-scsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 delet

[Qemu-devel] [PATCH 66/88] block: Make essential BlockDriver objects public

2015-01-08 Thread Michael Roth
From: Max Reitz There are some block drivers which are essential to QEMU and may not be removed: These are raw, file and qcow2 (as the default non-raw format). Make their BlockDriver objects public so they can be directly referenced throughout the block layer without needing to call bdrv_find_for

[Qemu-devel] [PATCH 60/88] virtio-scsi: work around bug in old BIOSes

2015-01-08 Thread Michael Roth
From: Paolo Bonzini Old BIOSes left some padding by mistake after the req_size/resp_size. New QEMU does not like it, thinking it is a bidirectional command. As a workaround, we can check if the ANY_LAYOUT bit is set; if not, we always consider the first buffer as the virtio-scsi request/response

[Qemu-devel] [PATCH 30/88] virtio-net: use aliases instead of duplicate qdev properties

2015-01-08 Thread Michael Roth
From: Gonglei virtio-net-pci, virtio-net-s390, and virtio-net-ccw all duplicate the qdev properties of their VirtIONet child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward pr

[Qemu-devel] [PATCH 71/88] qemu-img: Check create_opts before image creation

2015-01-08 Thread Michael Roth
From: Max Reitz If a driver supports image creation, it needs to set the .create_opts field. We can use that to make sure .create_opts for both drivers involved is not NULL for the target image in qemu-img convert, which is important so that the create_opts pointer in img_convert() is not NULL af

[Qemu-devel] [PATCH 62/88] l2tpv3: fix possible double free

2015-01-08 Thread Michael Roth
From: zhanghailiang freeaddrinfo(result) does not assign result = NULL, after frees it. There will be a double free when it goes error case. It is reported by covertiy. Reviewed-by: Gonglei Cc: qemu-sta...@nongnu.org Signed-off-by: zhanghailiang Signed-off-by: Paolo Bonzini (cherry picked fro

[Qemu-devel] [PATCH 21/88] ivshmem: Check ivshmem_read() size argument

2015-01-08 Thread Michael Roth
From: Stefan Hajnoczi The third argument to the fd_read() callback implemented by ivshmem_read() is the number of bytes, not a flags field. Fix this and check we received enough bytes before accessing the buffer pointer. Cc: Cam Macdonell Reported-by: Sebastian Krahmer Signed-off-by: Stefan H

[Qemu-devel] [PATCH 34/88] virtio-serial: use aliases instead of duplicate qdev properties

2015-01-08 Thread Michael Roth
From: Gonglei virtio-serial-{pci, s390, ccw} all duplicate the qdev properties of their VirtIOSerial child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward property accesses to

[Qemu-devel] [PATCH 68/88] block/vvfat: qcow driver may not be found

2015-01-08 Thread Michael Roth
From: Max Reitz Although virtually impossible right now, bdrv_find_format("qcow") may fail. The vvfat block driver should heed that case. Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit 1bcb15cf776a57e8963072c191

[Qemu-devel] [PATCH 53/88] hw/core/loader: implement address translation in uimage loader

2015-01-08 Thread Michael Roth
From: Max Filippov Such address translation is needed when load address recorded in uImage is a virtual address. When the actual load address is requested, return untranslated address: user that needs the translated address can always apply translation function to it and those that need it untran

[Qemu-devel] [PATCH 58/88] target-xtensa: add missing window check for entry

2015-01-08 Thread Michael Roth
From: Max Filippov Entry opcode needs to check if moving to new register frame would cause register window overflow. Entry used in function prologue never overflows because preceding windowed call* opcode writes return address to the target register window frame, causing overflow exceptions at th

[Qemu-devel] [PATCH 47/88] qcow2: Do not overflow when writing an L1 sector

2015-01-08 Thread Michael Roth
From: Max Reitz While writing an L1 table sector, qcow2_write_l1_entry() copies the respective range from s->l1_table to the local "buf" array. The size of s->l1_table does not have to be a multiple of L1_ENTRIES_PER_SECTOR; thus, limit the index which is used for copying all entries to the L1 si

[Qemu-devel] [PATCH 32/88] virtio/vhost-scsi: use aliases instead of duplicate qdev properties

2015-01-08 Thread Michael Roth
From: Gonglei {virtio, vhost}-scsi-{pci, s390, ccw} all duplicate the qdev properties of their VirtIOSCSI/VHostSCSI child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward prope

[Qemu-devel] [PATCH 55/88] snapshot: add bdrv_drain_all() to bdrv_snapshot_delete() to avoid concurrency problem

2015-01-08 Thread Michael Roth
From: Zhang Haoyu If there are still pending i/o while deleting snapshot, because deleting snapshot is done in non-coroutine context, and the pending i/o read/write (bdrv_co_do_rw) is done in coroutine context, so it's possible to cause concurrency problem between above two operations. Add bdrv_d

[Qemu-devel] [PATCH 19/88] virtio-balloon: fix integer overflow in memory stats feature

2015-01-08 Thread Michael Roth
From: Luiz Capitulino When a QMP client changes the polling interval time by setting the guest-stats-polling-interval property, the interval value is stored and manipulated as an int64_t variable. However, the balloon_stats_change_timer() function, which is used to set the actual timer with the

[Qemu-devel] [PATCH 28/88] smbios: Fix assertion on socket count calculation

2015-01-08 Thread Michael Roth
From: Eduardo Habkost QEMU currently allows the number of VCPUs to not be a multiple of the number of threads per socket, but the smbios socket count calculation introduced by commit c97294ec1b9e36887e119589d456557d72ab37b5 doesn't take that into account, triggering an assertion. e.g.: $ ./x86

[Qemu-devel] [PATCH 45/88] vmware-vga: use vmsvga_verify_rect in vmsvga_copy_rect

2015-01-08 Thread Michael Roth
From: Gerd Hoffmann Add verification to vmsvga_copy_rect, re-enable HW_RECT_ACCEL. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Don Koch (cherry picked from commit 61b41b4c20eba08d2185297767e69153d7f3e09d) Signed-off-by: Michael Roth --- hw/display/vmware_vga.c | 20 +

[Qemu-devel] [PATCH 56/88] hw/ppc/spapr_pci.c: Avoid functions not in glib 2.12 (g_hash_table_iter_*)

2015-01-08 Thread Michael Roth
From: Peter Maydell The g_hash_table_iter_* functions for iterating through a hash table are not present in glib 2.12, which is our current minimum requirement. Rewrite the code to use g_hash_table_foreach() instead. Signed-off-by: Peter Maydell Signed-off-by: Alexander Graf (cherry picked fro

[Qemu-devel] [PATCH 49/88] Make qemu_shutdown_requested signal-safe

2015-01-08 Thread Michael Roth
From: Jan Kiszka qemu_shutdown_requested may be interrupted by qemu_system_killed. If the latter sets shutdown_requested after qemu_shutdown_requested has read it but before it was cleared, the shutdown event is lost. Fix this by using atomic_xchg. This provides a different fix for the problem w

[Qemu-devel] [PATCH 25/88] pc-dimm: Don't check dimm->node when there is non-NUMA config

2015-01-08 Thread Michael Roth
From: zhanghailiang It should not break memory hotplug feature if there is non-NUMA option. This patch would also allow to use pc-dimm as replacement for initial memory for non-NUMA configs. Note: After this patch, the memory hotplug can work normally for Linux guest OS when there is non-NUMA o

[Qemu-devel] [PATCH 46/88] vmware-vga: use vmsvga_verify_rect in vmsvga_fill_rect

2015-01-08 Thread Michael Roth
From: Gerd Hoffmann Add verification to vmsvga_fill_rect, re-enable HW_FILL_ACCEL. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Don Koch (cherry picked from commit bd9ccd8517e83b7c33a9167815dbfffb30d70b13) Signed-off-by: Michael Roth --- hw/display/vmware_vga.c | 17 +

[Qemu-devel] [PATCH 57/88] esp-pci: fixup deadlock with linux

2015-01-08 Thread Michael Roth
From: Hannes Reinecke A linux guest will be issuing messages: [ 32.124042] DC390: Deadlock in DataIn_0: DMA aborted unfinished: 00 bytes remain!! [ 32.126348] DC390: DataIn_0: DMA State: 0 and the HBA will fail to work properly. Reason is the emulation is not setting the 'DMA transfer

[Qemu-devel] [PATCH 17/88] qemu-iotests: Test missing "driver" key for blockdev-add

2015-01-08 Thread Michael Roth
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Cc: qemu-sta...@nongnu.org Signed-off-by: Michael Roth Signed-off-by: Luiz Capitulino (cherry picked from commit fe509ee2373078435fb8c4f68eebd2740c4e388f) Signed-off-by: Michael Roth --- tests/qemu-iotests/087 | 17 +++

[Qemu-devel] [PATCH 40/88] virtio-9p: fix virtio-9p child refcount in transports

2015-01-08 Thread Michael Roth
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon unplug the virtio-9p child is not finalized! Drop our

[Qemu-devel] [PATCH 43/88] vmware-vga: add vmsvga_verify_rect

2015-01-08 Thread Michael Roth
From: Gerd Hoffmann Add verification function for rectangles, returning true if verification passes and false otherwise. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Don Koch (cherry picked from commit 07258900fd45b646f5b69048d64c4490b3243e1b) Signed-off-by: Michael Rot

[Qemu-devel] [PATCH 54/88] hw/xtensa/xtfpga: treat uImage load address as virtual

2015-01-08 Thread Michael Roth
From: Max Filippov U-boot for xtensa always treats uImage load address as virtual address. This is important when booting uImage on xtensa core with MMUv2, because MMUv2 has fixed non-identity virtual-to-physical mapping after reset. Always do virtual-to-physical translation of uImage load addre

[Qemu-devel] [PATCH 14/88] qapi: add visit_start_union and visit_end_union

2015-01-08 Thread Michael Roth
In some cases an input visitor might bail out on filling out a struct for various reasons, such as missing fields when running in strict mode. In the case of a QAPI Union type, this may lead to cases where the .kind field which encodes the union type is uninitialized. Subsequently, other visitors,

[Qemu-devel] [PATCH 42/88] vmware-vga: CVE-2014-3689: turn off hw accel

2015-01-08 Thread Michael Roth
From: Gerd Hoffmann Quick & easy stopgap for CVE-2014-3689: We just compile out the hardware acceleration functions which lack sanity checks. Thankfully we have capability bits for them (SVGA_CAP_RECT_COPY and SVGA_CAP_RECT_FILL), so guests should deal just fine, in theory. Subsequent patches

[Qemu-devel] [PATCH 52/88] tcg/mips: fix store softmmu slow path

2015-01-08 Thread Michael Roth
From: Aurelien Jarno Commit 9d8bf2d1 moved the softmmu slow path out of line and introduce a regression at the same time by always calling tcg_out_tlb_load with is_load=1. This makes impossible to run any significant code under qemu-system-mips*. Cc: Paolo Bonzini Cc: qemu-sta...@nongnu.org Rev

  1   2   3   >