Re: [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option

2015-01-03 Thread Jason Wang
On 12/29/2014 03:38 PM, Roy Vardi wrote: > > > > > > > -Original Message- > > > From: Jason Wang [mailto:jasow...@redhat.com] > > > Sent: Tuesday, December 23, 2014 11:13 AM > > > To: Roy Vardi > > > Cc: qemu-devel@nongnu.org; stefa...@redhat.com; Noam Camus; > > > arm...@redhat.com; a

[Qemu-devel] [PATCH v4 4/7] qemu-iotests: Add "_supported_os Linux" to 058

2015-01-03 Thread Fam Zheng
Other cases have this, and this test is not portable as well, as we want to add "make check-block" to "make check", it shouldn't fail on Mac OS X. Reported-by: Peter Maydell Signed-off-by: Fam Zheng --- tests/qemu-iotests/058 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotest

[Qemu-devel] [PATCH v4 7/7] qemu-iotests: Add supported os parameter for python tests

2015-01-03 Thread Fam Zheng
If I understand correctly, qemu-iotests never meant to be portable. We only support Linux for all the shell cases, but didn't specify it for python tests. Now add this and default all the python tests as Linux only. If we cares enough later, we can override the parameter in individual cases. Signe

[Qemu-devel] [PATCH v4 5/7] qemu-iotests: Speed up make check-block

2015-01-03 Thread Fam Zheng
Using /tmp, which is usually mounted as tmpfs, the quick group can be quicker. On my laptop (Lenovo T430s with Fedora 20), this reduces the time from 50s to 30s. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests-quick.sh | 2 +- tests/qemu-iotests/check| 1 + 2 files c

[Qemu-devel] [PATCH v4 3/7] qemu-iotests: Replace "/bin/true" with "true"

2015-01-03 Thread Fam Zheng
The former is not portable because on Mac OSX it is /usr/bin/true. Signed-off-by: Fam Zheng --- tests/qemu-iotests/common.config | 2 +- tests/qemu-iotests/common.filter | 2 +- tests/qemu-iotests/common.rc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iot

[Qemu-devel] [PATCH v4 1/7] .gitignore: Ignore generated "common.env"

2015-01-03 Thread Fam Zheng
Signed-off-by: Fam Zheng --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index e32a584..090f974 100644 --- a/.gitignore +++ b/.gitignore @@ -109,3 +109,4 @@ cscope.* tags TAGS *~ +/tests/qemu-iotests/common.env -- 1.9.3

[Qemu-devel] [PATCH v4 2/7] qemu-iotests: Remove 091 from quick group

2015-01-03 Thread Fam Zheng
For the purpose of allowing running quick group on tmpfs. Signed-off-by: Fam Zheng --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index a4742c6..08099b9 100644 --- a/tests/qemu-iotests/group +++

[Qemu-devel] [PATCH v4 6/7] tests/Makefile: Add check-block to make check on Linux

2015-01-03 Thread Fam Zheng
"make check-block" does nothing on other platforms, but still takes some time to enumerate all the tests. So let's only add it for Linux for now. Signed-off-by: Fam Zheng --- tests/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/Makefile b/tests/Makefile index e4ddb6a..b3ee

[Qemu-devel] [PATCH v4 0/7] tests: Add check-block to "make check"

2015-01-03 Thread Fam Zheng
qemu-iotests contains useful tests that have a nice coverage of block layer code. Adding check-block (which calls tests/qemu-iotests-quick.sh) to "make check" is good for developers' self-testing. v4: 06: Use CONFIG_LINUX instead of custom "uname" in tests/Makefile. (Peter) v2: Take care of other

Re: [Qemu-devel] [PATCH] Fix irq route entries exceed KVM_MAX_IRQ_ROUTES

2015-01-03 Thread William Dauchy
On Dec31 03:45, kevinnma(马文霜) wrote: > diff --git a/kvm-all.c b/kvm-all.c > index 18cc6b4..f47e1b1 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -1123,6 +1123,17 @@ static int kvm_irqchip_get_virq(KVMState *s) > int i, bit; > bool retry = true; > > +/* > + * PIC and IOAPIC sha

Re: [Qemu-devel] [PATCH v5 1/3] qcow2: Add qcow2_shrink_l1_and_l2_table for qcow2 shrinking

2015-01-03 Thread Jun Li
On Fri, 11/21 11:56, Max Reitz wrote: > On 2014-10-26 at 16:20, Jun Li wrote: > >This patch is the realization of new function qcow2_shrink_l1_and_l2_table. > >This function will shrink/discard l1 and l2 table when do qcow2 shrinking. > > > >Signed-off-by: Jun Li > >--- > >v5: > > Do some modifi

[Qemu-devel] [PATCH 3/3] misc: Fix new typos in comments

2015-01-03 Thread Stefan Weil
recieve -> receive suprise -> surprise Cc: Igor Mammedov Cc: John Snow Signed-off-by: Stefan Weil --- include/hw/hotplug.h |2 +- tests/ahci-test.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/hotplug.h b/include/hw/hotplug.h index 050d2f0..2db025

[Qemu-devel] [PATCH 2/3] target-arm: Fix typo in comment (seperately -> separately)

2015-01-03 Thread Stefan Weil
Cc: Peter Maydell Cc: Greg Bellows Signed-off-by: Stefan Weil --- target-arm/helper.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 3ef0f1f..1a5e067 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -972,7 +972

[Qemu-devel] [PATCH 0/3] Fix new typos found by codespell

2015-01-03 Thread Stefan Weil
Happy New Year to everybody! Regards Stefan [PATCH 1/3] target-tricore: Fix new typos [PATCH 2/3] target-arm: Fix typo in comment (seperately -> separately) [PATCH 3/3] misc: Fix new typos in comments

[Qemu-devel] [PATCH 1/3] target-tricore: Fix new typos

2015-01-03 Thread Stefan Weil
adress -> address managment -> management Cc: Bastian Koppelmann Signed-off-by: Stefan Weil --- target-tricore/csfr.def |2 +- target-tricore/translate.c |2 +- target-tricore/tricore-opcodes.h |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ta

Re: [Qemu-devel] [PATCH 08/10] block/dmg: fix sector data offset calculation

2015-01-03 Thread Peter Wu
On Friday 02 January 2015 19:05:29 John Snow wrote: > On 12/27/2014 10:01 AM, Peter Wu wrote: > > This patch addresses two issues: > > > > - The data fork offset was not taken into account, resulting in failure > > to read an InstallESD.dmg file (5164763151 bytes) which had a > > non-zero

Re: [Qemu-devel] [PATCH 06/10] block/dmg: process XML plists

2015-01-03 Thread Peter Wu
On Friday 02 January 2015 19:04:32 John Snow wrote: > On 12/27/2014 10:01 AM, Peter Wu wrote: > > The format is simple enough to avoid using a full-blown XML parser. > > The offsets are based on the description at > > http://newosxbook.com/DMG.html > > > > Signed-off-by: Peter Wu > > --- > > blo

Re: [Qemu-devel] [PATCH 03/10] block/dmg: extract processing of resource forks

2015-01-03 Thread Peter Wu
On Friday 02 January 2015 19:01:06 John Snow wrote: > On 12/27/2014 10:01 AM, Peter Wu wrote: > > Besides the offset, also read the resource length. This length is now > > used in the extracted function to verify the end of the resource fork > > against "count" from the resource fork. > > > > Signe

Re: [Qemu-devel] [PATCH 02/10] block/dmg: extract mish block decoding functionality

2015-01-03 Thread Peter Wu
On Friday 02 January 2015 18:59:38 John Snow wrote: > > On 12/27/2014 10:01 AM, Peter Wu wrote: > > Extract the mish block decoder such that this can be used for other > > formats in the future. A new DmgHeaderState struct is introduced to > > share state while decoding. > > > > The code is kept u

Re: [Qemu-devel] [PATCH 01/10] block/dmg: properly detect the UDIF trailer

2015-01-03 Thread Peter Wu
On Friday 02 January 2015 18:58:00 John Snow wrote: > > On 12/27/2014 10:01 AM, Peter Wu wrote: > > DMG files have a variable length with a UDIF trailer at the end of a > > file. This UDIF trailer is essential as it describes the contents of > > the image. At the moment however, the start of this

Re: [Qemu-devel] [PATCH 2.3 0/8] Linked list for tcg ops

2015-01-03 Thread Paolo Bonzini
On 11/11/2014 17:24, Richard Henderson wrote: > Currently tcg ops are simply placed in a buffer in order. Which is > fine until we want to actually do something with the opcode stream, > such as optimize them. Note the horrible things like call opcodes > needing their argument count both prefix

[Qemu-devel] [PULL 8/9] block/iscsi: fix uninitialized variable

2015-01-03 Thread Paolo Bonzini
From: Peter Wu 'ret' was never initialized in the success path. Signed-off-by: Peter Wu Signed-off-by: Paolo Bonzini --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index ed375fc..12ddbfb 100644 --- a/block/iscsi.c +++ b/bloc

[Qemu-devel] [PULL 7/9] pckbd: set bits 2-3-6-7 of the output port by default

2015-01-03 Thread Paolo Bonzini
OSes typically write 0xdd/0xdf to turn the A20 line off and on. This has bits 2-3-6-7 on, so that the output port subsection is migrated. Change the reset value and migration default to include those four bits, thus avoiding that the subsection is migrated. This strictly speaking changes guest AB

[Qemu-devel] [PULL 5/9] gen-icount: check cflags instead of use_icount global

2015-01-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --- include/exec/gen-icount.h | 6 +++--- target-alpha/translate.c | 2 +- target-arm/translate-a64.c| 2 +- target-arm/translate.c| 2 +- target-cris/translate.c | 2 +- target-i

[Qemu-devel] [PULL 9/9] pci: move REDHAT_SDHCI device ID to make room for Rocker

2015-01-03 Thread Paolo Bonzini
From: Scott Feldman The rocker device uses same PCI device ID as sdhci. Since rocker device driver has already been accepted into Linux 3.18, and REDHAT_SDHCI device ID isn't used by any drivers, it's safe to move REDHAT_SDHCI device ID, avoiding conflict with rocker. Signed-off-by: Scott Feldm

[Qemu-devel] [PULL 2/9] target-ppc: pass DisasContext to SPR generator functions

2015-01-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Reviewed-by: Alexander Graf Signed-off-by: Paolo Bonzini --- target-ppc/cpu.h| 13 +-- target-ppc/translate.c | 10 +- target-ppc/translate_init.c | 247 ++-- 3 files changed,

[Qemu-devel] [PULL 6/9] serial: refine serial_thr_ipending_needed

2015-01-03 Thread Paolo Bonzini
If the THR interrupt is disabled, there is no need to migrate thr_ipending because LSR.THRE will be sampled again when the interrupt is enabled. (This is the behavior that is not documented in the datasheet, but relied on by Windows!) Note that in this case IIR will never be 0x2 so, if thr_ipendin

[Qemu-devel] [PULL 4/9] translate: check cflags instead of use_icount global

2015-01-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --- target-alpha/translate.c| 8 target-arm/translate-a64.c | 4 ++-- target-arm/translate.c | 4 ++-- target-i386/translate.c | 50 +++-- t

[Qemu-devel] [PULL 3/9] cpu-exec: add a new CF_USE_ICOUNT cflag

2015-01-03 Thread Paolo Bonzini
Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --- include/exec/exec-all.h | 5 +++-- translate-all.c | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 38a8a09..6a15448 100644 --- a/include/exec/ex

[Qemu-devel] [PULL 1/9] atomic: fix position of volatile qualifier

2015-01-03 Thread Paolo Bonzini
What needs to be volatile is not the pointer, but the pointed-to value! Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- include/qemu/atomic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index 492bce1..93c2ae2 1

[Qemu-devel] [PULL 0/9] Misc changes for 2015-01-03 (icount, migration, iscsi, sdhci-pci)

2015-01-03 Thread Paolo Bonzini
The following changes since commit c95f3901b4ead79f3fe2c641fda7d2c70fc84c72: Merge remote-tracking branch 'remotes/kraxel/tags/pull-sdl-20141219-1' into staging (2014-12-21 23:17:00 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you