[Qemu-devel] [PATCH v3 2/5] bootdevice: add Error **errp argument for validate_bootdevices()

2014-12-19 Thread arei.gonglei
From: Gonglei It will be useful for checking when we change traditional boot order dynamically and propagate error message to the monitor. Signed-off-by: Gonglei Reviewed-by: Markus Armbruster --- bootdevice.c| 10 +- include/sysemu/sysemu.h | 2 +- vl.c

[Qemu-devel] [PATCH v3 4/5] bootdevice: add validate check for qemu_boot_set()

2014-12-19 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei Reviewed-by: Markus Armbruster --- bootdevice.c | 8 1 file changed, 8 insertions(+) diff --git a/bootdevice.c b/bootdevice.c index 7f07507..9de34ba 100644 --- a/bootdevice.c +++ b/bootdevice.c @@ -49,12 +49,20 @@ void qemu_register_boot_set(QEMUB

[Qemu-devel] [PATCH v3 1/5] bootdevice: move code about bootorder from vl.c to bootdevice.c

2014-12-19 Thread arei.gonglei
From: Gonglei First, we can downsize vl.c, make it simpler by little and little. Second, I can maintain those code and make some improvement. Cc: Jan Kiszka Signed-off-by: Gonglei Reviewed-by: Markus Armbruster --- bootdevice.c| 62

[Qemu-devel] [PATCH v3 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-19 Thread arei.gonglei
From: Gonglei It will be useful for checking when we change traditional boot order dynamically and propagate error message to the monitor. For x86 architecture, we pass &local_err to set_boot_dev() when vm startup in pc_coms_init(). Cc: Michael S. Tsirkin Cc: Alexander Graf Cc: Blue Swirl Cc:

[Qemu-devel] [PATCH v3 3/5] bootdevice: add Error **errp argument for qemu_boot_set()

2014-12-19 Thread arei.gonglei
From: Gonglei It will be useful for checking when we change traditional boot order dynamically and propagate error message to the monitor. Signed-off-by: Gonglei Reviewed-by: Markus Armbruster --- bootdevice.c| 14 ++ include/sysemu/sysemu.h | 2 +- monitor.c

[Qemu-devel] [PATCH v3 0/5] bootdevice: Refactor and improvement

2014-12-19 Thread arei.gonglei
From: Gonglei Changes of v3: As Markus's suggestion, thanks. - respin commit message of patch 2, 3, 5 - remove error_free() before exit(). - add 'R-by' tag for this patch series. Changes of v2: Thanks to Peter's report and suggestion. - fix 'make check' complaint. - fix inapposite using &

Re: [Qemu-devel] [PATCH v2 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-19 Thread Gonglei
On 2014/12/20 1:24, Markus Armbruster wrote: > writes: > >> From: Gonglei >> >> We can use it for checking when we change traditional >> boot order dynamically and propagate error message >> to the monitor. >> For x86 architecture, we pass &local_err to set_boot_dev() >> when vm startup in pc_c

Re: [Qemu-devel] [PATCH v2 2/5] bootdevice: add Error **errp argument for validate_bootdevices()

2014-12-19 Thread Gonglei
On 2014/12/20 1:17, Markus Armbruster wrote: > writes: > >> From: Gonglei >> >> We can use it for checking when we change traditional >> boot order dynamically and propagate error message >> to the monitor. > > In case you need to respin for some other reason: consider replacing "We > can use

Re: [Qemu-devel] [PATCH v2 0/5] bootdevice: Refactor and improvement

2014-12-19 Thread Gonglei
On 2014/12/20 1:27, Markus Armbruster wrote: > I don't understand why you move declarations to sysemu.h, and I had a > few remarks here and there. But I couldn't see anything wrong, so: > My thought is just moving the code related boot order to a unified place. :( > Series > Reviewed-by: Marku

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2014-12-19 Thread timsoft
same behaviour observed with qemu 2.2.0 32bit version for windows host -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1404278 Title: tap connections not working on windows host Status in QEMU: Ne

Re: [Qemu-devel] [PATCH] target-s390x: Add Extract PSW instruction

2014-12-19 Thread Richard Henderson
On 12/17/2014 10:17 AM, Bastian Koppelmann wrote: > +tcg_gen_andi_tl(regs[r1], regs[r1], ~0xull); > +tcg_gen_or_tl(regs[r1], regs[r1], tmp); This is store_reg32_i64. But just reminds me that I've got patches for 8 missing insns outstanding since September 2013, that got stalled on

[Qemu-devel] [Bug 1404278] [NEW] tap connections not working on windows host

2014-12-19 Thread timsoft
Public bug reported: using latest qemu 2.2.0 64bit for windows host (installed from qemu-w64-setup-20141210.exe obtained from http://qemu.weilnetz.de/w64/ ),OpenVPN 2.6.3-I601 64bit tap adapter named tap01 and calling qemu using the following. qemu-system-x86_64.exe -m 512 -net nic -net tap,ifnam

Re: [Qemu-devel] [PULL 10/10] monitor: add vnc websockets

2014-12-19 Thread Eric Blake
On 12/19/2014 02:04 AM, Gerd Hoffmann wrote: > Add websockets bool to VncBasicInfo, report websocket server sockets, > flag websocket client connections. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 5 - > ui/vnc.c | 15 --- > 2 files changed, 16 insertion

Re: [Qemu-devel] Can we make monitor commands identify BDS / BB by name consistently?

2014-12-19 Thread Markus Armbruster
Markus Armbruster writes: > Conscious design decision: Backend (BB) and node (BDS) names share a > common name space. > > Enables a convenience feature: when a command needs a node, we accept > either kind of name, and a backend name is resolved to its root node. > > Should not be confused with a

Re: [Qemu-devel] Live migration bug, possible missing ram in migration?

2014-12-19 Thread Frerot , Jean-Sébastien
yes it is. [jsfrerot@compute02 ~]$ ntpq -pn remote refid st t when poll reach delay offset jitter == +208.80.96.70142.3.100.2 2 u 148 1024 377 19.6890.037 1.219 *192.95.25.79213

Re: [Qemu-devel] [PULL 09/10] monitor: add query-vnc2 command

2014-12-19 Thread Eric Blake
On 12/19/2014 06:04 AM, Markus Armbruster wrote: > Gerd Hoffmann writes: > >> Add new query vnc qmp command, for the lack of better ideas just name it >> "query-vnc2". Changes over query-vnc: >> >> * It returns a list of vnc servers, so multiple vnc server instances >>are covered. >> * Eac

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Alexander Graf
On 19.12.14 18:29, Paolo Bonzini wrote: > > > On 19/12/2014 18:16, Alexander Graf wrote: >> >> >> On 19.12.14 17:51, Mark Cave-Ayland wrote: >>> On 19/12/14 16:35, Peter Maydell wrote: >>> On 19 December 2014 at 16:15, Mark Cave-Ayland wrote: > It looks like after restoring the C

Re: [Qemu-devel] [PATCH v3] target-tricore: pretty-print register dump and show more status registers

2014-12-19 Thread Bastian Koppelmann
On 12/19/2014 11:34 AM, Alex Zuepke wrote: Now using psw_read() to retrieve the status bits correctly. Signed-off-by: Alex Zuepke --- target-tricore/translate.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/target-tricore/translate.c b/target-t

Re: [Qemu-devel] [PATCH] PPC: e500: Fix GPIO controller interrupt number

2014-12-19 Thread Alexander Graf
On 19.12.14 15:20, Amit Tomar wrote: > This patch sets the GPIO controller interrupt number to 47,not 43 (and the > Device tree agrees). > > > Signed-off-by: Amit Singh Tomar Thanks, applied to ppc-next with modified commit message. Let's try to improve the patch description next time ;).

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 18:16, Alexander Graf wrote: > > > On 19.12.14 17:51, Mark Cave-Ayland wrote: >> On 19/12/14 16:35, Peter Maydell wrote: >> >>> On 19 December 2014 at 16:15, Mark Cave-Ayland >>> wrote: It looks like after restoring the CPU state with loadvm env->htab_base is still at 0

Re: [Qemu-devel] Live migration bug, possible missing ram in migration?

2014-12-19 Thread Dr. David Alan Gilbert
* Frerot, Jean-S?bastien (jsfre...@egliseespoir.com) wrote: > Thanks for the info, how should I debug this then? Cause I can't live > migrate my windows VM now. Are the host clocks on the servers synchronised with ntp? Having a clock mismatch with migration really confuses stuff (especially windo

Re: [Qemu-devel] [PATCH v2 0/5] bootdevice: Refactor and improvement

2014-12-19 Thread Markus Armbruster
writes: > From: Gonglei > > Changes of v2: > Thanks to Peter's report and suggestion. > - fix 'make check' complaint. > - fix inapposite using &error_abort in patch 5. > > Because of Peter's review comments in a pull request, I start a new > round review about this patch series v2. Please rev

Re: [Qemu-devel] [PATCH v2 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-19 Thread Markus Armbruster
writes: > From: Gonglei > > We can use it for checking when we change traditional > boot order dynamically and propagate error message > to the monitor. > For x86 architecture, we pass &local_err to set_boot_dev() > when vm startup in pc_coms_init(). > > Cc: Michael S. Tsirkin > Cc: Alexander G

Re: [Qemu-devel] [PATCH v2 3/5] bootdevice: add Error **errp argument for qemu_boot_set()

2014-12-19 Thread Markus Armbruster
writes: > From: Gonglei > > We can use it for checking when we change traditional > boot order dynamically and propagate error message > to the monitor. > > Signed-off-by: Gonglei I was about to write that this patch isn't an improvement, but then I read PATCH 4, and now I understand what you'

Re: [Qemu-devel] [PATCH v2 2/5] bootdevice: add Error **errp argument for validate_bootdevices()

2014-12-19 Thread Markus Armbruster
writes: > From: Gonglei > > We can use it for checking when we change traditional > boot order dynamically and propagate error message > to the monitor. In case you need to respin for some other reason: consider replacing "We can use it" by something like "Will be useful", to make it clearer th

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Alexander Graf
On 19.12.14 17:51, Mark Cave-Ayland wrote: > On 19/12/14 16:35, Peter Maydell wrote: > >> On 19 December 2014 at 16:15, Mark Cave-Ayland >> wrote: >>> It looks like after restoring the CPU state with loadvm env->htab_base >>> is still at 0x0 rather than its pre-migration value of 0x7e00. >>

[Qemu-devel] [Bug 1363641] Re: Build of v2.1.0 fails on armv7l due to undeclared __NR_select

2014-12-19 Thread Eduardo Otubo
Hello Ben, I just submitted a pull request to fix the issue you reported: http://lists.gnu.org/archive/html/qemu-devel/2014-12/msg03134.html Thanks again. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bu

Re: [Qemu-devel] [PATCH v2 1/5] bootdevice: move code about bootorder from vl.c to bootdevice.c

2014-12-19 Thread Markus Armbruster
writes: > From: Gonglei > > First, we can downsize vl.c, make it simpler by > little and little. Second, I can maintain those code > and make some improvement. Any patch moving code from vl.c to a better place can't be all bad :) [...] > diff --git a/include/hw/hw.h b/include/hw/hw.h > index 3

Re: [Qemu-devel] [PATCH] check return value of fcntl() to detect invalid fd

2014-12-19 Thread Eric Blake
On 12/19/2014 06:25 AM, Amos Kong wrote: > Passing some invalid fds in QEMU commandline, the fds don't exist. > QEMU will get error "TUNGETIFF ioctl() failed: Bad file descriptor", > and coredump in setting queues. > > This patch checked return value of first operate to fd, QEMU will > report erro

[Qemu-devel] [PULL 01/02] seccomp: typo in configure error message

2014-12-19 Thread Eduardo Otubo
Error message was misleading people to install wrong version of libseccomp. Signed-off-by: Eduardo Otubo --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index cae588c..7539645 100755 --- a/configure +++ b/configure @@ -1830,7 +1830,7 @@ if

[Qemu-devel] [PULL 00/02] seccomp branch queue

2014-12-19 Thread Eduardo Otubo
The following changes since commit b574f602680d41c4cf4a9c106e3e2244bed01cdd: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20141216-1' into staging (2014-12-17 19:22:42 +) are available in the git repository at: https://github.com/otubo/qemu.git tags/pull-seccom

[Qemu-devel] [PULL 02/02] seccomp: add mbind() to the syscall whitelist

2014-12-19 Thread Eduardo Otubo
From: Paul Moore The "memory-backend-ram" QOM object utilizes the mbind(2) syscall to set the policy for a memory range. Add the syscall to the seccomp sandbox whitelist. Signed-off-by: Paul Moore Tested-by: Eduardo Habkost Reviewed-by: Eduardo Habkost Acked-by: Eduardo Otubo --- qemu-secc

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Mark Cave-Ayland
On 19/12/14 16:35, Peter Maydell wrote: > On 19 December 2014 at 16:15, Mark Cave-Ayland > wrote: >> It looks like after restoring the CPU state with loadvm env->htab_base >> is still at 0x0 rather than its pre-migration value of 0x7e00. > > Odd -- there is code that is at least trying to do

[Qemu-devel] [PULL 13/19] qapi: Fix document for BlockStats.node-name

2014-12-19 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Message-id: 1418694024-26498-1-git-send-email-f...@redhat.com Signed-off-by: Max Reitz --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json inde

[Qemu-devel] [PULL 17/19] block: Add blockdev-backup to transaction

2014-12-19 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Markus Armbruster Message-id: 1418899027-8445-4-git-send-email-f...@redhat.com Signed-off-by: Max Reitz --- blockdev.c | 79 qap

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Peter Maydell
On 19 December 2014 at 16:15, Mark Cave-Ayland wrote: > It looks like after restoring the CPU state with loadvm env->htab_base > is still at 0x0 rather than its pre-migration value of 0x7e00. Odd -- there is code that is at least trying to do that: machine.c calls ppc_store_sdr1() which shoul

[Qemu-devel] [PULL 14/19] block: fix spoiling all dirty bitmaps by mirror and migration

2014-12-19 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Mirror and migration use dirty bitmaps for their purposes, and since commit [block: per caller dirty bitmap] they use their own bitmaps, not the global one. But they use old functions bdrv_set_dirty and bdrv_reset_dirty, which change all dirty bitmaps. Named di

[Qemu-devel] [PULL 18/19] qemu-iotests: Test blockdev-backup in 055

2014-12-19 Thread Kevin Wolf
From: Fam Zheng This applies cases on drive-backup on blockdev-backup, except cases with target format and mode. Also add a case to check source == target. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Reviewed-by: Markus Armbruster Message-id: 1418899027-8445-5-git-send-email-f...@redhat.

[Qemu-devel] [PULL 08/19] block: Get full backing filename from string

2014-12-19 Thread Kevin Wolf
From: Max Reitz Introduce bdrv_get_full_backing_filename_from_filename(), a function which takes the name of the backed file and a potentially relative backing filename to produce the full (absolute) backing filename. Use this function from bdrv_get_full_backing_filename(). Signed-off-by: Max R

[Qemu-devel] [PULL 16/19] qmp: Add command 'blockdev-backup'

2014-12-19 Thread Kevin Wolf
From: Fam Zheng Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible but is an illegal case wi

[Qemu-devel] [PULL 09/19] block: JSON filenames and relative backing files

2014-12-19 Thread Kevin Wolf
From: Max Reitz When using a relative backing file name, qemu needs to know the directory of the top image file. For JSON filenames, such a directory cannot be easily determined (e.g. how do you determine the directory of a qcow2 BDS directly on top of a quorum BDS?). Therefore, do not allow rela

[Qemu-devel] [PULL 15/19] qapi: Comment version info in TransactionAction

2014-12-19 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Markus Armbruster Message-id: 1418899027-8445-2-git-send-email-f...@redhat.com Signed-off-by: Max Reitz --- qapi-schema.json | 6 ++ 1 file changed, 6 insertions(+) diff --git a/qapi-sc

[Qemu-devel] [PULL 19/19] iotests: Filter out "I/O thread spun..." warning

2014-12-19 Thread Kevin Wolf
From: Max Reitz Filter out the "main loop: WARNING: I/O thread spun for..." warning from qemu output (it hardly matters for code specifically testing I/O). Furthermore, use _filter_qemu in all the custom functions which run qemu. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/q

[Qemu-devel] [PULL 07/19] checkpatch: Brace handling on multi-line condition

2014-12-19 Thread Kevin Wolf
From: Max Reitz CODING_STYLE states the following about braces around blocks: > The opening brace is on the line that contains the control flow > statement that introduces the new block; [...] This is obviously impossible with multi-line conditions. Therefore, CODING_STYLE does not make any cle

[Qemu-devel] [PULL 11/19] block/vmdk: Relative backing file for creation

2014-12-19 Thread Kevin Wolf
From: Max Reitz When a vmdk image is created with a backing file, it is opened to check whether it is indeed a vmdk file by letting qemu probe it. When doing so, the backing filename is relative to the image's base directory so it should be interpreted accordingly. Signed-off-by: Max Reitz Revi

[Qemu-devel] [PULL 10/19] block: Relative backing file for image creation

2014-12-19 Thread Kevin Wolf
From: Max Reitz Relative backing filenames are always relative to the backed image's directory; the same applies to image creation. Therefore, if the backing file has to be opened for determining its size (in case the size has not been explicitly specified) its filename should be interpreted rela

[Qemu-devel] [PULL 01/19] qemu-iotests: Remove 091 from quick group

2014-12-19 Thread Kevin Wolf
From: Fam Zheng For the purpose of allowing running quick group on tmpfs. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index a4742c6..0809

[Qemu-devel] [PULL 05/19] block: do not allocate an iovec per read of a growable/zero_after_eof BDS

2014-12-19 Thread Kevin Wolf
From: Paolo Bonzini Most reads do not go past the end of the file, and they can use the input QEMUIOVector instead of creating one. This removes the qemu_iovec_* functions from the profile. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block.c | 12 +--- 1 file changed,

[Qemu-devel] [PULL 12/19] iotests: Add test for relative backing file names

2014-12-19 Thread Kevin Wolf
From: Max Reitz Sometimes, qemu does not have a filename to work with, so it does not know which directory to use for a backing file specified by a relative filename. Add a test which tests that qemu exits with an appropriate error message. Additionally, add a test for qemu-img create with a bac

[Qemu-devel] [PULL 03/19] tests/Makefile: Add check-block to make check

2014-12-19 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index 16f0e4c..f430b18 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -463,7 +463,7 @@ check-qapi-schem

[Qemu-devel] [PULL 06/19] block: replace g_new0 with g_new for bottom half allocation.

2014-12-19 Thread Kevin Wolf
From: Paolo Bonzini This saves about 15% of the clock cycles spent on allocation. Using the slice allocator does not add a visible improvement; allocation is faster than malloc, while freeing seems to be slower. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- async.c | 10 ++--

[Qemu-devel] [PULL 00/19] Block patches

2014-12-19 Thread Kevin Wolf
The following changes since commit dfa9c2a0f4d0a0c8b2c1449ecdbb1297427e1560: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-12-15 16:43:42 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch

[Qemu-devel] [PULL 04/19] block: mark AioContext as recursive

2014-12-19 Thread Kevin Wolf
From: Paolo Bonzini AioContext can be accessed recursively, in fact that's what we do with aio_poll. Marking the GSource as recursive avoids that GLib blocks it and unblocks it around every call to aio_dispatch, which is a pretty expensive operation. Signed-off-by: Paolo Bonzini Signed-off-by:

[Qemu-devel] [PULL 02/19] qemu-iotests: Speed up make check-block

2014-12-19 Thread Kevin Wolf
From: Fam Zheng Using /tmp, which is usually mounted as tmpfs, the quick group can be quicker. On my laptop (Lenovo T430s with Fedora 20), this reduces the time from 50s to 30s. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests-quick.sh | 2 +-

Re: [Qemu-devel] [PATCH 5/8] target-i386: Set APIC ID using cpu_index on CONFIG_USER

2014-12-19 Thread Eduardo Habkost
On Fri, Dec 19, 2014 at 12:22:30PM +0100, Paolo Bonzini wrote: > On 19/12/2014 03:41, Eduardo Habkost wrote: > > +object_property_set_int(OBJECT(cpu), CPU(cpu)->cpu_index, "apic-id", > > +&error); > > +if (error) { > > +goto out; > > +} > > + > > Sho

Re: [Qemu-devel] [PATCH] iotests: Filter out "I/O thread spun..." warning

2014-12-19 Thread Kevin Wolf
Am 19.12.2014 um 17:17 hat Max Reitz geschrieben: > Filter out the "main loop: WARNING: I/O thread spun for..." warning from > qemu output (it hardly matters for code specifically testing I/O). > > Furthermore, use _filter_qemu in all the custom functions which run > qemu. > > Signed-off-by: Max

[Qemu-devel] [PATCH] iotests: Filter out "I/O thread spun..." warning

2014-12-19 Thread Max Reitz
Filter out the "main loop: WARNING: I/O thread spun for..." warning from qemu output (it hardly matters for code specifically testing I/O). Furthermore, use _filter_qemu in all the custom functions which run qemu. Signed-off-by: Max Reitz --- tests/qemu-iotests/067 | 3 ++- tests/qemu

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Mark Cave-Ayland
On 19/12/14 14:29, Peter Maydell wrote: > On 19 December 2014 at 14:12, Mark Cave-Ayland > wrote: >> I now have something that nearly works in that I can issue a "savevm" >> followed by a "loadvm" in the monitor and be able to resume where I left >> off - but only in OpenBIOS. If I boot into an O

[Qemu-devel] Review of ways to reopen BDSes (was: Review of monitor commands identifying BDS / BB by name)

2014-12-19 Thread Markus Armbruster
= Introduction = Kevin asked for all the ways you can reopen BDSes with different options or flags. This memo only covers all the ways you can reopen, but it doesn't attempt to fully analyze how options or flags change in each case. This is a systematic review of all the ways you can reopen BDSe

Re: [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option

2014-12-19 Thread Eric Blake
On 12/15/2014 05:05 AM, Roy Vardi wrote: > From: Roy Vardi > > Add 'persistent' boolean flag to -net tap option. > When set to off - tap interface will be released on shutdown > When set to on\not specified - tap interface will remain > > Running with -net tap,persistent=off will

Re: [Qemu-devel] [PATCH v4 0/6] block: Relative backing files

2014-12-19 Thread Kevin Wolf
Am 26.11.2014 um 17:20 hat Max Reitz geschrieben: > Cover letter of v1: > > Sometimes, qemu does not have a filename to work with (it then generates > a JSON filename), so it does not know which directory to use for a > backing file specified by a relative filename. > > In this case, qemu should

Re: [Qemu-devel] [PATCH v4 6/8] acpi: add build_append_namestring() helper

2014-12-19 Thread Claudio Fontana
Reviewed-by: Claudio Fontana On 19.12.2014 15:27, Igor Mammedov wrote: > Use build_append_namestring() instead of build_append_nameseg() > So user won't have to care whether name is NameSeg, NamePath or > NameString. > > See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding > > Signed-off-by:

Re: [Qemu-devel] Live migration bug, possible missing ram in migration?

2014-12-19 Thread Frerot , Jean-Sébastien
re-adding right email: quint...@redhat.com -- Jean-Sébastien Frerot jsfre...@egliseespoir.com 2014-12-19 9:41 GMT-05:00 Frerot, Jean-Sébastien : > > Thanks for the info, how should I debug this then? Cause I can't live > migrate my windows VM now. > > > -- > Jean-Sébastien Frerot > jsfre...@egl

Re: [Qemu-devel] Live migration bug, possible missing ram in migration?

2014-12-19 Thread Frerot , Jean-Sébastien
Thanks for the info, how should I debug this then? Cause I can't live migrate my windows VM now. -- Jean-Sébastien Frerot jsfre...@egliseespoir.com 2014-12-19 9:40 GMT-05:00 Paolo Bonzini : > > > > On 19/12/2014 14:15, Frerot, Jean-Sébastien wrote: > > Hi, I've been using kvm for some time now u

Re: [Qemu-devel] Live migration bug, possible missing ram in migration?

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 14:15, Frerot, Jean-Sébastien wrote: > Hi, I've been using kvm for some time now using live migration as well > with ceph backend. Recently I started running into an issue with only > one of my VM, which happens to be a windows server (2012). When I > migrate this particular VM it s

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Peter Maydell
On 19 December 2014 at 14:12, Mark Cave-Ayland wrote: > I now have something that nearly works in that I can issue a "savevm" > followed by a "loadvm" in the monitor and be able to resume where I left > off - but only in OpenBIOS. If I boot into an OS and try this then it > doesn't work and the co

[Qemu-devel] [PATCH v4 6/8] acpi: add build_append_namestring() helper

2014-12-19 Thread Igor Mammedov
Use build_append_namestring() instead of build_append_nameseg() So user won't have to care whether name is NameSeg, NamePath or NameString. See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding Signed-off-by: Igor Mammedov --- v3: assert on wrong Segcount earlier and extend condition to seg

Re: [Qemu-devel] Review of ways to create BDSes

2014-12-19 Thread Markus Armbruster
Markus Armbruster writes: > = Introduction = > > BDSes can be opened in various ways. Some of them don't provide for > user configuration. Some of them should. > > Example: -drive format=qcow2,file=foo.qcow2 where foo.qcow2 has a raw > backing file foo.raw. This creates the the following tree

Re: [Qemu-devel] [PULL 5/5] e1000: defer packets until BM enabled

2014-12-19 Thread Michael S. Tsirkin
On Fri, Dec 19, 2014 at 01:18:24PM +, Stefan Hajnoczi wrote: > From: "Michael S. Tsirkin" > > Some guests seem to set BM for e1000 after > enabling RX. > If packets arrive in the window, device is wedged. > Probably works by luck on real hardware, work around > this by making can_receive depe

[Qemu-devel] [PATCH] PPC: e500: Fix GPIO controller interrupt number

2014-12-19 Thread Amit Tomar
This patch sets the GPIO controller interrupt number to 47,not 43 (and the Device tree agrees). Signed-off-by: Amit Singh Tomar --- hw/ppc/e500.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 2832fc0..2cd69a9 100644 --- a/hw/ppc/e500

Re: [Qemu-devel] Live migration bug, possible missing ram in migration?

2014-12-19 Thread Frerot , Jean-Sébastien
fixing quint...@redhat.com email. -- Jean-Sébastien Frerot jsfre...@egliseespoir.com 2014-12-19 8:15 GMT-05:00 Frerot, Jean-Sébastien : > > Hi, I've been using kvm for some time now using live migration as well > with ceph backend. Recently I started running into an issue with only one > of my

[Qemu-devel] Live migration bug, possible missing ram in migration?

2014-12-19 Thread Frerot , Jean-Sébastien
Hi, I've been using kvm for some time now using live migration as well with ceph backend. Recently I started running into an issue with only one of my VM, which happens to be a windows server (2012). When I migrate this particular VM it seems that not all the ram is transferred. So when the migrati

Re: [Qemu-devel] [Qemu-ppc] Unable to loadvm on qemu-system-ppc -M g3beige (keyboard freeze)

2014-12-19 Thread Mark Cave-Ayland
On 19/12/14 12:29, Peter Maydell wrote: > On 19 December 2014 at 10:53, Mark Cave-Ayland > wrote: >> It seems that I've misunderstood something mentioned earlier in the >> thread, i.e. that loadvm also does the create, initialize, realize and >> reset cycle. At least issuing "loadvm" in the monit

Re: [Qemu-devel] [PATCH 1/2] tcg: Introduce tcg_arch_init() function

2014-12-19 Thread Richard Henderson
On 12/18/2014 10:26 PM, Eduardo Habkost wrote: > +void tcg_arch_init(void); I'm not keen on the name, because it's fairly ambiguous whether "arch" is talking about the host or target. It doesn't help that "tcg_target" is the host. ;-P Assuming we do this (see hook discussion), what about "trans

Re: [Qemu-devel] Review of ways to create BDSes

2014-12-19 Thread Markus Armbruster
Kevin Wolf writes: > Am 18.12.2014 um 16:25 hat Markus Armbruster geschrieben: >> = Introduction = >> >> BDSes can be opened in various ways. Some of them don't provide for >> user configuration. Some of them should. >> >> Example: -drive format=qcow2,file=foo.qcow2 where foo.qcow2 has a raw

Re: [Qemu-devel] [PATCH 1/2] cpu: initialize cpu->exception_index on reset

2014-12-19 Thread Eduardo Habkost
On Fri, Dec 19, 2014 at 12:53:13PM +0100, Paolo Bonzini wrote: > This unbreaks linux-user (broken by e511b4d, cpu-exec: reset exception_index > correctly, 2014-11-26). > > Reported-by: Eduardo Habkost > Signed-off-by: Paolo Bonzini Fixes the problem. Thanks! Tested-by: Eduardo Habkost -- Ed

Re: [Qemu-devel] [PATCH v3 6/8] acpi: add build_append_namestring() helper

2014-12-19 Thread Claudio Fontana
On 19.12.2014 12:47, Igor Mammedov wrote: > Use build_append_namestring() instead of build_append_nameseg() > So user won't have to care whether name is NameSeg, NamePath or > NameString. > > See for refernce ACPI 5.0: 20.2.2 Name Objects Encoding > > Signed-off-by: Igor Mammedov > --- > v2: >

Re: [Qemu-devel] [PATCH v3 4/5] Split the QEMU buffered file code out

2014-12-19 Thread Eduardo Habkost
On Thu, Dec 18, 2014 at 09:24:11AM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Fri, Dec 12, 2014 at 11:13:41AM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The splitting of qemu-file and addi

[Qemu-devel] [PATCH] check return value of fcntl() to detect invalid fd

2014-12-19 Thread Amos Kong
Passing some invalid fds in QEMU commandline, the fds don't exist. QEMU will get error "TUNGETIFF ioctl() failed: Bad file descriptor", and coredump in setting queues. This patch checked return value of first operate to fd, QEMU will report error and exit without coredump. It's effected for both n

[Qemu-devel] [PULL 1/5] tap: fix vcpu long time io blocking on tap

2014-12-19 Thread Stefan Hajnoczi
From: "Wangkai (Kevin,C)" [Adjusted doc comment for grammar. --Stefan] Signed-off-by: Wangkai Signed-off-by: Stefan Hajnoczi --- net/tap.c | 12 1 file changed, 12 insertions(+) diff --git a/net/tap.c b/net/tap.c index bde6b58..1fe0edf 100644 --- a/net/tap.c +++ b/net/tap.c @@ -

[Qemu-devel] [PULL 5/5] e1000: defer packets until BM enabled

2014-12-19 Thread Stefan Hajnoczi
From: "Michael S. Tsirkin" Some guests seem to set BM for e1000 after enabling RX. If packets arrive in the window, device is wedged. Probably works by luck on real hardware, work around this by making can_receive depend on BM. Tested-by: Gabriel Somlo Signed-off-by: Michael S. Tsirkin Reviewe

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 13:49, Igor Mammedov wrote: >> source: >> qemu-system-x86_64 -monitor stdio -M pc-i440fx-1.7 -parallel none >> xpsp3x86.qcow2 >> >> switch to text screen where you could select Safe Mode and stop/migrate at >> this point > > one more issue if you continue normal boot and wait til

[Qemu-devel] [PULL 4/5] net: Use g_new() & friends where that makes obvious sense

2014-12-19 Thread Stefan Hajnoczi
From: Markus Armbruster g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with siz

Re: [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option

2014-12-19 Thread Daniel P. Berrange
On Fri, Dec 19, 2014 at 01:13:50PM +, Stefan Hajnoczi wrote: > On Mon, Dec 15, 2014 at 02:05:23PM +0200, Roy Vardi wrote: > > From: Roy Vardi > > > > Add 'persistent' boolean flag to -net tap option. > > When set to off - tap interface will be released on shutdown > > When set to

[Qemu-devel] [PULL 2/5] net: don't use set/get_pointer() in set/get_netdev()

2014-12-19 Thread Stefan Hajnoczi
From: Jason Wang Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue support) tries to use set_pointer() and get_pointer() to set and get NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This trick works but result a unclean and fragile implementation (e.g print_netdev

[Qemu-devel] [PULL 3/5] net: Fuse g_malloc(); memset() into g_new0()

2014-12-19 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- net/l2tpv3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 3b805a7..6014c43 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -695,8 +695,7 @@ int

[Qemu-devel] [PULL 0/5] Net patches

2014-12-19 Thread Stefan Hajnoczi
The following changes since commit 86b182ac0e0b44726d85598cbefb468ed22517fc: Merge remote-tracking branch 'remotes/xtensa/tags/20141217-xtensa' into staging (2014-12-17 17:31:26 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for you

Re: [Qemu-devel] [PATCH v2] e1000: defer packets until BM enabled

2014-12-19 Thread Stefan Hajnoczi
On Mon, Dec 01, 2014 at 08:06:52PM +0200, Michael S. Tsirkin wrote: > Some guests seem to set BM for e1000 after > enabling RX. > If packets arrive in the window, device is wedged. > Probably works by luck on real hardware, work around > this by making can_receive depend on BM. > > Tested-by: Gabr

Re: [Qemu-devel] [PATCH 0/2] tcg: Move TCG arch-specific initialization inside TCG code

2014-12-19 Thread Eduardo Habkost
On Fri, Dec 19, 2014 at 11:29:34AM +0100, Paolo Bonzini wrote: > On 19/12/2014 10:47, Andreas Färber wrote: > > How do you imagine this to work with multiple CPU types? From the looks > > of it, this is for the target CPU, not the TCG architecture, so > > tcg_arch_init() limits us to one implementa

Re: [Qemu-devel] [PATCH 0/2] net: Trivial cleanups around g_malloc()

2014-12-19 Thread Stefan Hajnoczi
On Thu, Dec 04, 2014 at 02:28:15PM +0100, Markus Armbruster wrote: > Markus Armbruster (2): > net: Fuse g_malloc(); memset() into g_new0() > net: Use g_new() & friends where that makes obvious sense > > net/l2tpv3.c | 9 - > net/queue.c | 2 +- > net/slirp.c | 2 +- > 3 files change

Re: [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option

2014-12-19 Thread Stefan Hajnoczi
On Mon, Dec 15, 2014 at 02:05:23PM +0200, Roy Vardi wrote: > From: Roy Vardi > > Add 'persistent' boolean flag to -net tap option. > When set to off - tap interface will be released on shutdown > When set to on\not specified - tap interface will remain > > Running with -net tap,p

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Paolo Bonzini
On 19/12/2014 13:42, Igor Mammedov wrote: > On Fri, 19 Dec 2014 13:02:24 +0100 > Paolo Bonzini wrote: > >> >> >> On 19/12/2014 12:32, Igor Mammedov wrote: >>> There is one more commit that breaks it, this time with subsection >>> 6c3bff0 "exec: Save CPUState::exception_index field" >>> >>> qemu

Re: [Qemu-devel] [PULL 10/10] monitor: add vnc websockets

2014-12-19 Thread Markus Armbruster
Copying Eric again, even though the QAPI schema change here is pretty trivial. Gerd Hoffmann writes: > Add websockets bool to VncBasicInfo, report websocket server sockets, > flag websocket client connections. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 5 - > ui/vnc.c

Re: [Qemu-devel] [PULL 09/10] monitor: add query-vnc2 command

2014-12-19 Thread Markus Armbruster
Gerd Hoffmann writes: > Add new query vnc qmp command, for the lack of better ideas just name it > "query-vnc2". Changes over query-vnc: > > * It returns a list of vnc servers, so multiple vnc server instances >are covered. > * Each vnc server returns a list of server sockets. Followup pa

Re: [Qemu-devel] [PATCH 7/8] target-i386: Move topology.h to hw/i386/topology.h

2014-12-19 Thread Eduardo Habkost
On Fri, Dec 19, 2014 at 12:24:05PM +0100, Paolo Bonzini wrote: > > > On 19/12/2014 03:41, Eduardo Habkost wrote: > > This will allow the PC code to use the header, and lets us eliminate the > > QEMU_INCLUDES hack inside tests/Makefile. > > > > Signed-off-by: Eduardo Habkost > > Please use incl

Re: [Qemu-devel] [PATCH 4/8] target-i386: Keep track of apic-id setting

2014-12-19 Thread Eduardo Habkost
On Fri, Dec 19, 2014 at 12:23:07PM +0100, Paolo Bonzini wrote: > On 19/12/2014 03:41, Eduardo Habkost wrote: > > Set a flag indicating that the apic-id property was set, so we can later > > ensure we won't try to realize a X86CPU object before apic-id was set. > > > > Signed-off-by: Eduardo Habkos

Re: [Qemu-devel] [PULL 0/4] vga: cirrus hwcursor fixes.

2014-12-19 Thread Peter Maydell
On 17 December 2014 at 14:42, Gerd Hoffmann wrote: > Hi, > > vga patches lingering way too long in my queue. > > Finally merging the cirrus hwcursor fixes (for NT4 guests!) > discussed months ago ... > > Also minor tweaks picked up during freeze. > > please pull, > Gerd > > The following chang

Re: [Qemu-devel] [PULL 00/10] vnc: add support for multiple vnc displays

2014-12-19 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > > Ok, here we go with the multiple vnc display patch series. > Compared to the v3 series two patch hunks have been moved > from patch #9 to patch #2. The final result after applying > all patches hasn't changed, so I think it's ok to go straight > for a pull req i

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Igor Mammedov
On Fri, 19 Dec 2014 13:42:37 +0100 Igor Mammedov wrote: > On Fri, 19 Dec 2014 13:02:24 +0100 > Paolo Bonzini wrote: > > > > > > > On 19/12/2014 12:32, Igor Mammedov wrote: > > > There is one more commit that breaks it, this time with subsection > > > 6c3bff0 "exec: Save CPUState::exception_in

Re: [Qemu-devel] broken backward migration due to commit 461a275 "parallel: adding vmstate for save/restore"

2014-12-19 Thread Igor Mammedov
On Fri, 19 Dec 2014 13:02:24 +0100 Paolo Bonzini wrote: > > > On 19/12/2014 12:32, Igor Mammedov wrote: > > There is one more commit that breaks it, this time with subsection > > 6c3bff0 "exec: Save CPUState::exception_index field" > > > > qemu: warning: error while loading state for instance

  1   2   >