Re: [Qemu-devel] [PATCH 1/4] virtio-mmio: introduce set_host_notifier()

2014-11-18 Thread Fam Zheng
On Tue, 11/04 20:47, Shannon Zhao wrote: > set_host_notifier() is introduced into virtio-mmio now. Most of codes came > from virtio-pci. > > Signed-off-by: Ying-Shiuan Pan > Signed-off-by: Li Liu > Signed-off-by: Shannon Zhao > --- > hw/virtio/virtio-mmio.c | 70 > ++

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-18 Thread Amit Shah
On (Mon) 17 Nov 2014 [22:08:46], Michael S. Tsirkin wrote: > At the moment we migrate ROMs which reside in fw cfg, which allows > changing ROM code at will, and supports migrating largish blocks early, > with good performance. > However, we are running into a problem: changing size breaks > migrati

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-18 Thread Amit Shah
On (Mon) 17 Nov 2014 [22:11:13], Michael S. Tsirkin wrote: > And to make it clear, I'd like to see review from > migration maintainers on this. > The patchset crosses into pc so it's probably best to > merge through my tree to avoic conflicts. Fine by me. Amit

Re: [Qemu-devel] [PATCH for-2.2] acpi-build: mark RAM dirty on table update

2014-11-18 Thread Amit Shah
On (Mon) 17 Nov 2014 [19:04:13], Michael S. Tsirkin wrote: > acpi build modifies internal FW CFG RAM on first access > but we forgot to mark it dirty. > If this RAM has been migrated already, it won't be > migrated again, returning corrupted tables to guest. > > Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCH] configure: Replace which(1) with "command -v"

2014-11-18 Thread Fam Zheng
Because which(1) is not always installed, whereas "command -v" is the more native way to check for a command. Signed-off-by: Fam Zheng --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 47048f0..986a13d 100755 --- a/configure +++ b/confi

Re: [Qemu-devel] [PATCH] usb: delete redundant brackets in usb_host_handle_control()

2014-11-18 Thread Fam Zheng
On Wed, 11/19 14:57, Jun Li wrote: > When see usb codes, find there are redundant brackets !((udev->port->speedmask > & USB_SPEED_MASK_SUPER)) here. So delete it. > > Signed-off-by: Jun Li > --- > hw/usb/host-libusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/u

[Qemu-devel] [PATCH v2] tests: Use "command -v" instead of which(1) in shell scripts

2014-11-18 Thread Fam Zheng
When which(1) is not installed, we would complain "perl not found" because it's the first set_prog_path check. The error message is wrong. Fix it by using "command -v", a native way to query the existence of a command. Suggested-by: Eric Blake Signed-off-by: Fam Zheng --- v2: Use "command -v"

[Qemu-devel] [PATCH] usb: delete redundant brackets in usb_host_handle_control()

2014-11-18 Thread Jun Li
When see usb codes, find there are redundant brackets !((udev->port->speedmask & USB_SPEED_MASK_SUPER)) here. So delete it. Signed-off-by: Jun Li --- hw/usb/host-libusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index a5f9dab

Re: [Qemu-devel] [PATCH v6 00/10] block: Incremental backup series

2014-11-18 Thread Denis V. Lunev
On 18/11/14 19:08, John Snow wrote: On 11/18/2014 08:09 AM, Vladimir Sementsov-Ogievskiy wrote: (3) Data Integrity The dirty flag could work something like: - If, on first open, the file has the dirty flag set, we need to discard the bitmap data because we can no longer trust it. - If the bi

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-18 Thread Eric Blake
On 11/18/2014 01:26 PM, Eric Blake wrote: > Now, in response to your question about some other 3-pass inducing > pattern, let's think back to v1, where you questioned what would happen > if a hole in the reftable gets turned into data due to a later > allocation. Let's see if I can come up with a

Re: [Qemu-devel] [PATCH v3 0/4] target-ppc: Add FWNMI support in qemu for powerKVM guests

2014-11-18 Thread Aravinda Prasad
On Tuesday 11 November 2014 08:54 AM, David Gibson wrote: [..] > > So, this may not still be possible depending on whether the KVM side > of this is already merged, but it occurs to me that there's a simpler > way. > > Rather than mucking about with having to update the hypervisor on the > RT

[Qemu-devel] [PATCH 2/2] pcie-aer: Fix command pcie_aer_inject_error is invalid

2014-11-18 Thread Chen Fan
in spec "PCI Express 3.0" section 6.2.6 Figure 6-3 virtual bridge part, the flowchart showing tell us SERR# enable at Bridge Control register associate with system error at Secondary Status register can send error message. but bridge_control from dev->config is NULL, and SERR# was set in dev->wmask

[Qemu-devel] [PATCH 0/2] pcie-aer: Fix command pcie_aer_inject_error invalid

2014-11-18 Thread Chen Fan
set each patch details. Chen Fan (2): pcie_aer: fix typos in pcie_aer_inject_error comment pcie-aer: Fix command pcie_aer_inject_error is invalid hw/pci/pcie_aer.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) -- 1.9.3

[Qemu-devel] [PATCH 1/2] pcie_aer: fix typos in pcie_aer_inject_error comment

2014-11-18 Thread Chen Fan
Refer to "PCI Express Base Spec3.0", this comments can't fit the description in spec, so we should fix them. Signed-off-by: Chen Fan --- hw/pci/pcie_aer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c index 1f4be16..7ca077a 100644

[Qemu-devel] [ANNOUNCE] QEMU 2.2.0-rc2 is now available

2014-11-18 Thread Michael Roth
On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 2.2 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.2.0-rc2.tar.bz2 You can help improve th

Re: [Qemu-devel] [question] kvm fully support vga adapter pass-through ?

2014-11-18 Thread Alex Williamson
On Wed, 2014-11-19 at 09:56 +0800, Zhang Haoyu wrote: > Hi all, > > Does the combination of qemu-2.0.1 and linux-3.10 fully support > direct-assign vga adapters to vm? No, at best I'd call it experimental

[Qemu-devel] [question] kvm fully support vga adapter pass-through ?

2014-11-18 Thread Zhang Haoyu
Hi all, Does the combination of qemu-2.0.1 and linux-3.10 fully support direct-assign vga adapters to vm? Thanks, Zhang Haoyu

Re: [Qemu-devel] [PATCH v2] Pass semihosting exit code back to system.

2014-11-18 Thread Peter Maydell
On 18 November 2014 21:19, Paolo Bonzini wrote: > The isa-debugexit and testdev character device do not exit with exitcode > 0, in order to distinguish an exit from a system power down; the > low-order bit is always 1. The return values then should be 1 and 3 > instead of 0 and 1. Semihosting is

Re: [Qemu-devel] mute button not work

2014-11-18 Thread Tony Breeds
On Tue, Nov 18, 2014 at 03:55:07PM +0800, li wrote: > Hi all, > > i use qemu-system-x86_64 to run windows 7, and fund that "mute/unmute" button > in the right bottom of guest desktop not work. > > related info is as below: > > $qemu-system-x86_64 --version > QEMU emulator version 1.4.0, Copy

Re: [Qemu-devel] [PATCH v2] Pass semihosting exit code back to system.

2014-11-18 Thread Liviu Ionescu
On 18 Nov 2014, at 23:19, Paolo Bonzini wrote: > The isa-debugexit and testdev character device do not exit with exitcode > 0, in order to distinguish an exit from a system power down; the > low-order bit is always 1. The return values then should be 1 and 3 > instead of 0 and 1. I have no exp

Re: [Qemu-devel] Tunneled Migration with Non-Shared Storage

2014-11-18 Thread Paolo Bonzini
On 18/11/2014 21:28, Dr. David Alan Gilbert wrote: > This seems odd, since as far as I know the tunneling code is quite separate > to the migration code; I thought the only thing that the migration > code sees different is the file descriptors it gets past. > (Having said that, again I don't know

Re: [Qemu-devel] [PATCH v2] Pass semihosting exit code back to system.

2014-11-18 Thread Paolo Bonzini
On 18/11/2014 21:08, Peter Maydell wrote: > Applied to target-arm.next, thanks. > (That's > https://git.linaro.org/people/peter.maydell/qemu-arm.git target-arm.next > which is a *rebasing* branch.) The isa-debugexit and testdev character device do not exit with exitcode 0, in order to distinguis

Re: [Qemu-devel] Tunneled Migration with Non-Shared Storage

2014-11-18 Thread Dr. David Alan Gilbert
* Gary R Hook (grhookatw...@gmail.com) wrote: > What I really need to figure out is why, when performing a migration > using non-shared storage, an entire VM is copied into memory before it???s > sent across the wire using this method. A copy-on-read operation > is performed first, then the disk is

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-18 Thread Eric Blake
On 11/17/2014 05:06 AM, Max Reitz wrote: >> Umm, that sounds backwards from what you document. It's a good test of >> the _new_ reftable needing a second round of allocations. So keep it >> with corrected comments. But I think you _intended_ to write a test >> that starts with a refcount_width=

Re: [Qemu-devel] [PATCH] add semihosting-config option

2014-11-18 Thread Liviu Ionescu
On 18 Nov 2014, at 21:44, Peter Maydell wrote: > ...and there isn't much point in these if()s right, removed > Also we prefer 'true' and 'false' to TRUE and FALSE. fixed > (The change won't hit master until after we release 2.2 in early > December, so there's no immediate hurry either way.)

[Qemu-devel] [PATCH] functional ARM semihosting under GDB

2014-11-18 Thread Liviu Ionescu
Signed-off-by: Liviu Ionescu --- gdbstub.c | 12 +++ hw/arm/armv7m.c | 27 +++- hw/arm/stellaris.c | 14 + include/hw/arm/arm.h| 8 --- include/hw/boards.h | 1 + include/sysemu/sysemu.h | 7 +++ qemu-options.hx

[Qemu-devel] [PATCH] functional ARM semihosting under GDB

2014-11-18 Thread Liviu Ionescu
The shortcomings addressed by this patch: - the semihosting trace messages disapeared when the GDB session was started - the semihosting exit code was not passed back to the host - the semihosting command line was not passed properly, because it generated a very large string, including the image fu

[Qemu-devel] [PATCH v2] Add the "-semihosting-config" option.

2014-11-18 Thread Liviu Ionescu
The usual semihosting behaviour is to process the system calls locally and return; unfortuantelly the initial implementation dinamically changed the target to GDB during debug sessions, which, for the usual arm-none-eabi-gdb, is not implemented. The result was that during debug sessions the semihos

Re: [Qemu-devel] [PATCH v2] Pass semihosting exit code back to system.

2014-11-18 Thread Peter Maydell
On 18 November 2014 20:01, Liviu Ionescu wrote: > In order to run unit tests under semihosting, it is necessary to pass the > application exit code back to the system. > > ARM defines only the code to be used for non-error application exit > (ADP_Stopped_ApplicationExit), all other codes should re

Re: [Qemu-devel] [PATCH] pass semihosting exit code back to system

2014-11-18 Thread Liviu Ionescu
On 18 Nov 2014, at 21:48, Peter Maydell wrote: > The ARM documentation seems to define this value as > 0x20026 rather than with a shift-and-decimal-value, so > I'd rather follow that. right, I changed it and resent. regards, Liviu

[Qemu-devel] [PATCH v2] Pass semihosting exit code back to system.

2014-11-18 Thread Liviu Ionescu
In order to run unit tests under semihosting, it is necessary to pass the application exit code back to the system. ARM defines only the code to be used for non-error application exit (ADP_Stopped_ApplicationExit), all other codes should return non-zero exit codes. This patch checks if the applic

Re: [Qemu-devel] [PATCH v2 18/21] qcow2: Add function for refcount order amendment

2014-11-18 Thread Eric Blake
On 11/18/2014 11:58 AM, Max Reitz wrote: > On 18.11.2014 18:55, Eric Blake wrote: >> On 11/14/2014 06:06 AM, Max Reitz wrote: >>> Add a function qcow2_change_refcount_order() which allows changing the >>> refcount order of a qcow2 image. >>> >>> Signed-off-by: Max Reitz >>> --- >>> +if (n

Re: [Qemu-devel] [PATCH] pass semihosting exit code back to system

2014-11-18 Thread Peter Maydell
On 18 November 2014 19:29, Liviu Ionescu wrote: > Signed-off-by: Liviu Ionescu > --- > target-arm/arm-semi.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/target-arm/arm-semi.c b/target-arm/arm-semi.c > index ebb5235..4b982ad 100644 > --- a/target-arm/arm

Re: [Qemu-devel] [PATCH] functional ARM semihosting under GDB

2014-11-18 Thread Liviu Ionescu
On 17 Nov 2014, at 14:32, Peter Maydell wrote: > You can start out by separating out one or two and submitting > those. just did that, I submitted two patches, one to add the -semihosting-config and one to fix the exit code. if you have further comments, please let me know. once you integrat

Re: [Qemu-devel] [PATCH] add semihosting-config option

2014-11-18 Thread Peter Maydell
On 18 November 2014 19:00, Liviu Ionescu wrote: > - allow to define where the semihosting calls will be addressed > > Signed-off-by: Liviu Ionescu > --- > gdbstub.c | 12 > include/sysemu/sysemu.h | 6 ++ > qemu-options.hx | 12 +++- > vl.c

[Qemu-devel] [PATCH] add -semihosting-config option

2014-11-18 Thread Liviu Ionescu
The usual semihosting behaviour is to process the system calls locally and return; unfortuantelly the initial implementation dinamically changed the target to GDB during debug sessions, which, for the usual arm-none-eabi-gdb, is not implemented. The result was that during debug sessions the semihos

[Qemu-devel] [PATCH] pass ARM semihosting exit code back to system

2014-11-18 Thread Liviu Ionescu
In order to run unit tests under semihosting, it is necessary to pass the application exit code back to the system. ARM defines only the code to be used for non-error application exit (ADP_Stopped_ApplicationExit), all other codes should return non-zero exit codes. This patch checks if the applic

[Qemu-devel] [PATCH] pass semihosting exit code back to system

2014-11-18 Thread Liviu Ionescu
Signed-off-by: Liviu Ionescu --- target-arm/arm-semi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/target-arm/arm-semi.c b/target-arm/arm-semi.c index ebb5235..4b982ad 100644 --- a/target-arm/arm-semi.c +++ b/target-arm/arm-semi.c @@ -58,6 +58,11 @@ #define

[Qemu-devel] [PATCH] add semihosting-config option

2014-11-18 Thread Liviu Ionescu
- allow to define where the semihosting calls will be addressed Signed-off-by: Liviu Ionescu --- gdbstub.c | 12 include/sysemu/sysemu.h | 6 ++ qemu-options.hx | 12 +++- vl.c| 49 +++

Re: [Qemu-devel] [PATCH v2 18/21] qcow2: Add function for refcount order amendment

2014-11-18 Thread Max Reitz
On 18.11.2014 18:55, Eric Blake wrote: On 11/14/2014 06:06 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 457 +

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Peter Maydell
On 18 November 2014 11:41, Kevin Wolf wrote: > Am 17.11.2014 um 22:20 hat Don Slutz geschrieben: >> The other callers to blk_set_enable_write_cache() in this file >> already check for s->blk == NULL. >> >> Signed-off-by: Don Slutz >> --- >> >> I think this is a bugfix that should be back ported t

Re: [Qemu-devel] [PATCH v2 18/21] qcow2: Add function for refcount order amendment

2014-11-18 Thread Eric Blake
On 11/14/2014 06:06 AM, Max Reitz wrote: > Add a function qcow2_change_refcount_order() which allows changing the > refcount order of a qcow2 image. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 457 > + > block/qcow2.h |

Re: [Qemu-devel] [PULL] Net patches

2014-11-18 Thread Peter Maydell
On 18 November 2014 15:04, Stefan Hajnoczi wrote: > The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2014-11-17 17:22:03 +) > > are available in the git repository at: > > git:

Re: [Qemu-devel] hotremoving a disk qmp/hmp

2014-11-18 Thread Markus Armbruster
William Dauchy writes: > On Nov18 15:22, Markus Armbruster wrote: >> This is block backend "disk1". > > yes indeed. > >> I presume you're deleting the device using backend "disk1". > > yes > >> What kind of device is this? PCI, perhaps? >> Please show us a complete QMP conversation. > > Here it

Re: [Qemu-devel] qmp-commands.hx and inherited types (Was: Re: [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove)

2014-11-18 Thread Eric Blake
On 11/18/2014 09:44 AM, John Snow wrote: >> Is it worth using type inheritance, as in: >> >> { 'type': 'BlockDirtyBitmapAdd', >>'base': 'BlockDirtyBitmap', >>'data': { '*granularity': 'int' } } >> > > Strictly speaking, I would argue against inheritance here because > "BlockDirtyBitmapAdd"

Re: [Qemu-devel] [PATCH 1/3] s390: Add PCI bus support

2014-11-18 Thread Alexander Graf
On 18.11.14 13:50, Frank Blaschka wrote: > On Mon, Nov 10, 2014 at 04:14:16PM +0100, Alexander Graf wrote: >> >> >> On 10.11.14 15:20, Frank Blaschka wrote: >>> From: Frank Blaschka >>> >>> This patch implements a pci bus for s390x together with infrastructure >>> to generate and handle hotplug

Re: [Qemu-devel] runtime configurable semihosting

2014-11-18 Thread Peter Maydell
On 18 November 2014 16:46, Liviu Ionescu wrote: > > On 18 Nov 2014, at 15:31, Peter Maydell wrote: > >> Sorry, yes, you're right; I should have looked more carefully. >> So we do need a new option; > > or we should fix the parser. if the current keyword is not in > the list, it can be pushed back

[Qemu-devel] Tunneled Migration with Non-Shared Storage

2014-11-18 Thread Gary R Hook
What I really need to figure out is why, when performing a migration using non-shared storage, an entire VM is copied into memory before it’s sent across the wire using this method. A copy-on-read operation is performed first, then the disk is sent, then the dirty pages, then the RAM. The odd t

Re: [Qemu-devel] runtime configurable semihosting

2014-11-18 Thread Liviu Ionescu
On 18 Nov 2014, at 15:31, Peter Maydell wrote: > Sorry, yes, you're right; I should have looked more carefully. > So we do need a new option; or we should fix the parser. if the current keyword is not in the list, it can be pushed back, and defaults used. > -semihosting-config target=[native|

[Qemu-devel] qmp-commands.hx and inherited types (Was: Re: [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove)

2014-11-18 Thread John Snow
On 11/07/2014 08:00 AM, Eric Blake wrote: On 10/30/2014 04:22 AM, Fam Zheng wrote: [snip] +++ b/qapi/block-core.json @@ -865,6 +865,61 @@ '*on-target-error': 'BlockdevOnError' } } ## +# @BlockDirtyBitmap +# +# @device: name of device which the bitmap is tracking +# +# @name

[Qemu-devel] Sending packets up to VM using vhost-net User.

2014-11-18 Thread Anshul Makkar
Hi, I am developing an application that is using vhost-user backend for packet transfer. The architecture: 1) VM1 is using Vhost-user and executing on server1. ".qemu-system-x86_64 -m 1024 -mem-path /dev/hugepages,prealloc=on,share=on -drive file=/home/amakkar/test.img,if=none,id=drive-virtio-d

Re: [Qemu-devel] Sending packets up to VM using vhost-net User.

2014-11-18 Thread Anshul Makkar
Sorry, forgot to mention I am using " git clone -b vhost-user-v5 https://github.com/virtualopensystems/qemu.git"; for vhost-user backend implementation. and "git clone https://github.com/virtualopensystems/vapp.git " for reference implementation. Anshul Makkar On Tue, Nov 18, 2014 at 5:29 PM, An

[Qemu-devel] Fwd: [PATCH v2 0/6] Geometry and blocksize support for backing devices

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 0/6] Geometry and blocksize support for backing devices Date: Tue, 18 Nov 2014 17:09:55 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com CC: borntrae...@d

[Qemu-devel] Fwd: [PATCH v2 4/6] geometry: Add block-backend wrappers for geometry probing

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 4/6] geometry: Add block-backend wrappers for geometry probing Date: Tue, 18 Nov 2014 17:09:59 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com CC: born

[Qemu-devel] Fwd: [PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 6/6] geometry: Target specific hook for s390x in geometry guessing Date: Tue, 18 Nov 2014 17:10:01 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com CC:

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2014-11-18 Thread Peter Maydell
On 18 November 2014 15:04, Stefan Hajnoczi wrote: > The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2014-11-17 17:22:03 +) > > are available in the git repository at: > > git:

[Qemu-devel] Fwd: [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 5/6] geometry: Call backend function to detect geometry and blocksize Date: Tue, 18 Nov 2014 17:10:00 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com C

[Qemu-devel] Fwd: [PATCH v2 3/6] geometry: Add driver methods to probe blocksizes and geometry

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 3/6] geometry: Add driver methods to probe blocksizes and geometry Date: Tue, 18 Nov 2014 17:09:58 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com CC:

[Qemu-devel] Fwd: [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 2/6] geometry: Detect blocksize via ioctls in separate static functions Date: Tue, 18 Nov 2014 17:09:57 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com

[Qemu-devel] Fwd: [PATCH v2 1/6] geometry: add bdrv functions for geometry and blocksize

2014-11-18 Thread Ekaterina Tumanova
copying to mail list Forwarded Message Subject: [PATCH v2 1/6] geometry: add bdrv functions for geometry and blocksize Date: Tue, 18 Nov 2014 17:09:56 +0100 From: Ekaterina Tumanova To: arm...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, kw...@redhat.com CC: borntr

Re: [Qemu-devel] [PATCH v6 00/10] block: Incremental backup series

2014-11-18 Thread John Snow
On 11/18/2014 08:09 AM, Vladimir Sementsov-Ogievskiy wrote: (3) Data Integrity The dirty flag could work something like: - If, on first open, the file has the dirty flag set, we need to discard the bitmap data because we can no longer trust it. - If the bitmap file is clean, proceed as normal

[Qemu-devel] [PULL] net: The third parameter of getsockname should be initialized

2014-11-18 Thread Stefan Hajnoczi
From: zhanghailiang Signed-off-by: zhanghailiang Reviewed-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/socket.c b/net/socket.c index fb21e20..ca4b8ba 100644 --- a/net/socket.c +++ b/net/socket.c @

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-18 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > At the moment we migrate ROMs which reside in fw cfg, which allows > changing ROM code at will, and supports migrating largish blocks early, > with good performance. > However, we are running into a problem: changing size breaks > migration every time. Pardon my ig

[Qemu-devel] [PULL] Net patches

2014-11-18 Thread Stefan Hajnoczi
The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-11-17 17:22:03 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/net-pull-request for you to

Re: [Qemu-devel] hotremoving a disk qmp/hmp

2014-11-18 Thread William Dauchy
On Nov18 15:22, Markus Armbruster wrote: > This is block backend "disk1". yes indeed. > I presume you're deleting the device using backend "disk1". yes > What kind of device is this? PCI, perhaps? > Please show us a complete QMP conversation. Here it is: live vm with one disk: (QEMU) query-

[Qemu-devel] [PULL 2/2] Tracing: Fix simpletrace.py error on tcg enabled binary traces

2014-11-18 Thread Stefan Hajnoczi
From: Christoph Seifert simpletrace.py does not recognize the tcg option while reading trace-events file. In result simpletrace does not work on binary traces and tcg enabled events. Moved transformation of tcg enabled events to _read_events() which is used by simpletrace. Signed-off-by: Chr

[Qemu-devel] [PULL 0/2] Tracing patches

2014-11-18 Thread Stefan Hajnoczi
The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-11-17 17:22:03 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for yo

[Qemu-devel] [PULL 1/2] Tracing docs fix configure option and description

2014-11-18 Thread Stefan Hajnoczi
From: "Dr. David Alan Gilbert" Fix the example trace configure option. Update the text to say that multiple backends are allowed and what happens when multiple backends are enabled. Signed-off-by: Dr. David Alan Gilbert Message-id: 1412691161-31785-1-git-send-email-dgilb...@redhat.com Signed-of

Re: [Qemu-devel] [PATCH 0/5] pc: make ROMs resizeable

2014-11-18 Thread Michael S. Tsirkin
On Tue, Nov 18, 2014 at 03:47:16PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > At the moment we migrate ROMs which reside in fw cfg, which allows > > changing ROM code at will, and supports migrating largish blocks early, > > with good performance. > > However, we are run

Re: [Qemu-devel] exec.c:invalidate_and_set_dirty() only checks whether first page in its range is dirty...

2014-11-18 Thread Stefan Hajnoczi
On Sun, Nov 16, 2014 at 06:11:48PM +, Peter Maydell wrote: > I'm trying to track down a bug in ARM TCG where we: > * boot a guest > * run 'shutdown -r now' to trigger a reboot > * on reboot, crash when running userspace because the contents >of physical RAM have changed but the translate

Re: [Qemu-devel] [PULL 0/6] Block patches for 2.2.0-rc2

2014-11-18 Thread Peter Maydell
On 18 November 2014 11:35, Kevin Wolf wrote: > The following changes since commit 1aba4be97eb01b650d146c7f01dc961d55da62ab: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2014-11-17 17:22:03 +) > > are available in the git repository at: > > > git://r

Re: [Qemu-devel] [PATCH v6 00/10] block: Incremental backup series

2014-11-18 Thread Vladimir Sementsov-Ogievskiy
Also, if we sync not the last level, bitmap.dirty_flag should be related to syncing level, not to the whole bitmap, to reduce sync overhead. Or, if we implement difficult sync policy, there should be dirty flags for each bitmap level. Despite this, only one level is needed to be saved in the bit

Re: [Qemu-devel] hotremoving a disk qmp/hmp

2014-11-18 Thread Markus Armbruster
William Dauchy writes: > Hello, > > When hotremoving a disk I'm using the QMP API with device_del command; > > Previous query-block command result: > > { u'device': u'disk1', > u'inserted': { u'backing_file_depth': 0, > u'bps': 0, > u'bps_rd': 0,

Re: [Qemu-devel] [PATCH v3 1/3] linux-aio: fix submit aio as a batch

2014-11-18 Thread Paolo Bonzini
> @@ -137,6 +145,12 @@ static void qemu_laio_completion_bh(void *opaque) > } > } > > +static void qemu_laio_start_retry(struct qemu_laio_state *s) > +{ > +if (s->io_q.idx) > +qemu_bh_schedule(s->io_q.retry); > +} > + > static void qemu_laio_completion_cb(EventNotifier *e) >

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Stefano Stabellini
Konrad, I think we should have this fix in Xen 4.5. Should I go ahead and backport it? On Mon, 17 Nov 2014, Don Slutz wrote: > The other callers to blk_set_enable_write_cache() in this file > already check for s->blk == NULL. > > Signed-off-by: Don Slutz > --- > > I think this is a bugfix that

Re: [Qemu-devel] [PATCH v3 3/3] linux-aio: remove 'node' from 'struct qemu_laiocb'

2014-11-18 Thread Paolo Bonzini
On 06/11/2014 16:10, Ming Lei wrote: > No one uses the 'node' field any more, so remove it > from 'struct qemu_laiocb', and this can save 16byte > for the struct on 64bit arch. > > Signed-off-by: Ming Lei > --- > block/linux-aio.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/blo

Re: [Qemu-devel] [PATCH] Tracing: Fix simpletrace.py error on tcg enabled binary traces

2014-11-18 Thread Stefan Hajnoczi
On Sun, Nov 02, 2014 at 10:37:59PM +0100, christoph.seif...@posteo.de wrote: > From: Christoph Seifert > > simpletrace.py does not recognize the tcg option while reading trace-events > file. In result simpletrace does not work on binary traces and tcg enabled > events. Moved transformation of

Re: [Qemu-devel] [PATCH v3 2/3] linux-aio: handling -EAGAIN for !s->io_q.plugged case

2014-11-18 Thread Paolo Bonzini
On 06/11/2014 16:10, Ming Lei wrote: > +/* don't submit until next completion for -EAGAIN of non plug case */ > +if (unlikely(!s->io_q.plugged)) { > +return 0; > +} > + Is this an optimization or a fix for something? > +/* > + * Switch to queue mode until -EA

Re: [Qemu-devel] [PATCH] Tracing: Fix simpletrace.py error on tcg enabled binary traces

2014-11-18 Thread Stefan Hajnoczi
On Mon, Nov 17, 2014 at 07:57:08PM -0600, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Sun, Nov 02, 2014 at 10:37:59PM +0100, christoph.seif...@posteo.de wrote: > >> From: Christoph Seifert > >> > >> simpletrace.py does not recognize the tcg option while reading trace-events > >> fil

Re: [Qemu-devel] [PATCH v2 1/5] libqos: Change use of pointers to uint64_t in virtio

2014-11-18 Thread Stefan Hajnoczi
On Mon, Nov 17, 2014 at 04:25:50PM +0100, Andreas Färber wrote: > Am 17.11.2014 um 16:19 schrieb Marc Marí: > > El Mon, 17 Nov 2014 15:16:21 + > > Stefan Hajnoczi escribió: > >> On Sat, Nov 01, 2014 at 06:02:26PM +0100, Marc Marí wrote: > >>> Convert use of pointers in functions of virtio to u

Re: [Qemu-devel] [PATCH 00/13] linux-aio/virtio-scsi: support AioContext wide IO submission as batch

2014-11-18 Thread Paolo Bonzini
On 09/11/2014 08:42, Ming Lei wrote: > This patch implements AioContext wide IO submission as batch, and > the idea behind is very simple: > > - linux native aio(io_submit) supports to enqueue read/write requests > to different files > > - in one AioContext, I/O requests from

Re: [Qemu-devel] [PULL] migration: fix for CVE-2014-7840

2014-11-18 Thread Peter Maydell
On 18 November 2014 11:29, Amit Shah wrote: > The following changes since commit d6be29e3fb5659102ac0e48e295d177cb67e32c5: > > target-arm: handle address translations that start at level 3 (2014-11-17 > 19:30:28 +) > > are available in the git repository at: > > git://git.kernel.org/pub/s

Re: [Qemu-devel] runtime configurable semihosting

2014-11-18 Thread Peter Maydell
On 13 November 2014 09:44, Liviu Ionescu wrote: > Peter Maydell wrote: >> I took a quick look at the syntax of command options and monitor >> commands, and I would suggest the following: >> >> - extend the option "-semihosting" with an optional >> "target=native|gdb|auto", default auto > > unfortu

Re: [Qemu-devel] [PATCH v6 00/10] block: Incremental backup series

2014-11-18 Thread Vladimir Sementsov-Ogievskiy
(3) Data Integrity The dirty flag could work something like: - If, on first open, the file has the dirty flag set, we need to discard the bitmap data because we can no longer trust it. - If the bitmap file is clean, proceed as normal, but take a lock against any of the bitmap functions to prev

Re: [Qemu-devel] [PATCH 1/3] s390: Add PCI bus support

2014-11-18 Thread Frank Blaschka
On Mon, Nov 10, 2014 at 04:14:16PM +0100, Alexander Graf wrote: > > > On 10.11.14 15:20, Frank Blaschka wrote: > > From: Frank Blaschka > > > > This patch implements a pci bus for s390x together with infrastructure > > to generate and handle hotplug events, to configure/unconfigure via > > sclp

Re: [Qemu-devel] [PATCH Part1 1/5] acpi, pc: Add hotunplug request cb for pc machine.

2014-11-18 Thread Igor Mammedov
On Mon, 17 Nov 2014 13:03:13 +0800 Tang Chen wrote: in subj s/cb/callback|handler/ > Memory and CPU hot unplug are both asynchronize procedures. s/asynchronize/asynchronous/ > They both need unplug request cb when the unplug operation happens. s/cb when the unplug operation happens/callback to i

[Qemu-devel] [PATCH 4/4] MAINTAINERS: add include files to virtio-serial entry

2014-11-18 Thread Amit Shah
Signed-off-by: Amit Shah --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4c46cfe..d2f4a11 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -696,6 +696,7 @@ M: Amit Shah S: Supported F: hw/char/virtio-serial-bus.c F: hw/char/virtio-console.c +F:

[Qemu-devel] [PATCH 3/4] MAINTAINERS: add entry for virtio-rng

2014-11-18 Thread Amit Shah
Signed-off-by: Amit Shah --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index af8d856..4c46cfe 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -697,6 +697,13 @@ S: Supported F: hw/char/virtio-serial-bus.c F: hw/char/virtio-console.c +virtio-

[Qemu-devel] [PATCH 2/4] MAINTAINERS: migration: add vmstate static checker files

2014-11-18 Thread Amit Shah
Signed-off-by: Amit Shah --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e517c41..af8d856 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -935,6 +935,8 @@ F: migration* F: savevm.c F: arch_init.c F: vmstate.c +F: scripts/vmstate-static-checke

[Qemu-devel] [PATCH 1/4] MAINTAINERS: Add myself to migration maintainers

2014-11-18 Thread Amit Shah
Signed-off-by: Amit Shah --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index bcb69e8..e517c41 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -928,6 +928,7 @@ F: scripts/checkpatch.pl Migration M: Juan Quintela +M: Amit Shah S: Maintained F: i

[Qemu-devel] [PATCH 0/4] MAINTAINERS: add myself to migration, rng; update others

2014-11-18 Thread Amit Shah
Hello, These patches add myself to the migration maintainers list, and a new entry for virtio-rng. Also update the virtio-serial entry for an include file. Please ack. Amit Shah (4): MAINTAINERS: Add myself to migration maintainers MAINTAINERS: migration: add vmstate static checker files

Re: [Qemu-devel] [PATCH] linux-headers: update to 3.18-rc5

2014-11-18 Thread Peter Maydell
On 18 November 2014 05:19, Paolo Bonzini wrote: > > > On 17/11/2014 19:32, Peter Maydell wrote: >> On 17 November 2014 18:28, Ard Biesheuvel wrote: >>> This updates the Linux header to version 3.18-rc5, adding support for >>> (among other things) read-only memslots on ARM and arm64. >>> >>> Signe

Re: [Qemu-devel] [PATCH v2 6/6] qemu-nbd: Use BlockBackend where reasonable

2014-11-18 Thread Paolo Bonzini
On 18/11/2014 12:21, Max Reitz wrote: > Because qemu-nbd creates the BlockBackend by itself, it should create > the according BlockDriverState tree by itself as well; that means, it > has call bdrv_open() on its own. This is one of the places where > qemu-nbd still needs to use a BlockDriverState

Re: [Qemu-devel] [PATCH 4/5] memory: interface to allocate device ram

2014-11-18 Thread Michael S. Tsirkin
On Mon, Nov 17, 2014 at 08:21:00PM +, Peter Maydell wrote: > On 17 November 2014 20:08, Michael S. Tsirkin wrote: > > Add API to allocate on-device RAM. > > This looks just like regular RAM from migration POV, > > but has two special properties internally: > > - it is never exposed to guest >

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Kevin Wolf
Am 17.11.2014 um 22:20 hat Don Slutz geschrieben: > The other callers to blk_set_enable_write_cache() in this file > already check for s->blk == NULL. > > Signed-off-by: Don Slutz > --- > > I think this is a bugfix that should be back ported to stable > releases. Please remember to include a 'C

Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration

2014-11-18 Thread Stefan Hajnoczi
On Mon, Nov 17, 2014 at 04:20:39PM -0500, Don Slutz wrote: > The other callers to blk_set_enable_write_cache() in this file > already check for s->blk == NULL. > > Signed-off-by: Don Slutz > --- > > I think this is a bugfix that should be back ported to stable > releases. > > I also think this

[Qemu-devel] [PULL 4/6] block/raw-posix: Fix preallocating write() loop

2014-11-18 Thread Kevin Wolf
From: Max Reitz write() may write less bytes than requested; in this case, the number of bytes written is returned. This is the byte count we should be subtracting from the number of bytes still to be written, and not the byte count we requested to write. Reported-by: László Érsek Signed-off-by

[Qemu-devel] [PULL 3/6] raw-posix: The SEEK_HOLE code is flawed, rewrite it

2014-11-18 Thread Kevin Wolf
From: Markus Armbruster On systems where SEEK_HOLE in a trailing hole seeks to EOF (Solaris, but not Linux), try_seek_hole() reports trailing data instead. Additionally, unlikely lseek() failures are treated badly: * When SEEK_HOLE fails, try_seek_hole() reports trailing data. For -ENXIO, th

[Qemu-devel] [PULL 5/6] block/raw-posix: Only sync after successful preallocation

2014-11-18 Thread Kevin Wolf
From: Max Reitz The loop which filled the file with zeroes may have been left early due to an error. In that case, the fsync() should be skipped. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/raw-posix.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/blo

[Qemu-devel] [PULL 1/6] raw-posix: Fix comment for raw_co_get_block_status()

2014-11-18 Thread Kevin Wolf
From: Markus Armbruster Missed in commit 705be72. Signed-off-by: Markus Armbruster Reviewed-by: Paolo Bonzini Reviewed-by: Fam Zheng Reviewed-by: Eric Blake Reviewed-by: Max Reitz Signed-off-by: Max Reitz --- block/raw-posix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

  1   2   >