On 09/27/2014 07:58 AM, Bastian Koppelmann wrote:
> Move FCX loading of save_context_ to caller functions, for STLCX, STUCX insn
> to use those functions.
> Move FCX storing of restore_context_ to caller functions, for LDLCX, LDUCX
> insn to use those functions.
> Remove do_raise_exception functi
On 09/27/2014 07:58 AM, Bastian Koppelmann wrote:
> +/* ld circ */
> +DEF_HELPER_4(ld_b_circ, void, env, i32, i32, int)
Avoid, whenever possible, performing memory operations within helpers. Doing
that complicates the generation of correct code for exact exceptions from the
memory operation. I'm
On 2014/9/26 23:40, Paolo Bonzini wrote:
Il 19/09/2014 05:09, zhanghailiang ha scritto:
If readdir_r fails, error_setg_errno will reference the freed
pointer *dirpath*.
Moreover, readdir_r may cause a buffer overflow, using readdir instead.
Signed-off-by: zhanghailiang
---
v2:
- Switch read
On 2014/9/26 23:35, Paolo Bonzini wrote:
Il 26/09/2014 10:35, zhanghailiang ha scritto:
Hi,
This has been reviewed, Will anyone pick this up?;)
I think mst will. It's Jewish new year this week, so it will have to
wait for next week.
OK, Thanks;)
Best Regard,
zhanghailiang
Paolo
Thanks,
On 2014/9/28 10:59, Chen, Tiejun wrote:
On 2014/9/3 9:40, Kay, Allen M wrote:
-Original Message-
From: Chen, Tiejun
Sent: Monday, September 01, 2014 12:50 AM
To: Michael S. Tsirkin
Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org;
Konrad Rzeszutek Wilk
Subject: R
On 09/27/2014 07:58 AM, Bastian Koppelmann wrote:
> +/* D[c] = D[c][0] op1 (D[a][pos1] op2 D[b][pos2]);*/
> +static inline void gen_bit_2op(TCGv ret, TCGv r1, TCGv r2, TCGv r3,
> + int pos1, int pos2,
> + void(*op1)(TCGv, TCGv, TCGv),
> +
On 2014/9/3 9:40, Kay, Allen M wrote:
-Original Message-
From: Chen, Tiejun
Sent: Monday, September 01, 2014 12:50 AM
To: Michael S. Tsirkin
Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org;
Konrad Rzeszutek Wilk
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] x
Before, scsi_req_cancel will take ownership of the canceled request and unref
it. We did this because we didn't know whether AIO CB will be called or not
during the cancelling, so we set the io_canceled flag before calling it, and
skip unref in the potentially called callbacks, which is not very ni
For VIRTIO_SCSI_T_TMF_ABORT_TASK and VIRTIO_SCSI_T_TMF_ABORT_TASK_SET,
use scsi_req_cancel_async to start the cancellation.
Because each tmf command may cancel multiple requests, we need to use a
counter to track the number of remaining requests we still need to wait
for.
Signed-off-by: Fam Zheng
The only two implementations are identical to each other, with nothing specific
to device: they only call bdrv_aio_cancel with the SCSIRequest.aiocb.
Let's move it to scsi-bus.
Signed-off-by: Fam Zheng
---
hw/scsi/scsi-bus.c | 4 ++--
hw/scsi/scsi-disk.c| 14 --
hw/scsi/scs
Let the aio cb do the clean up and notification job after scsi_req_cancel, in
preparation for asynchronous cancellation.
Signed-off-by: Fam Zheng
---
hw/scsi/scsi-bus.c | 14 ++
hw/scsi/scsi-disk.c| 8
hw/scsi/scsi-generic.c | 1 +
include/hw/scsi/scsi.h | 1 +
4
The only user of this function is spapr_vscsi.c. We can convert to
scsi_req_cancel plus adding a check in vscsi_request_cancelled.
Suggested-by: Paolo Bonzini
Signed-off-by: Fam Zheng
---
hw/scsi/scsi-bus.c| 15 ---
hw/scsi/spapr_vscsi.c | 11 ---
2 files changed, 8 inse
Devices will call this function to start an asynchronous cancellation. The
bus->info->cancel will be called after the request is canceled.
Devices will probably need to track a separate TMF request that triggers this
cancellation, and wait until the cancellation is done before completing it. So
we
Now that we always called the cb in bdrv_aio_cancel, let's make scsi-generic
callbacks check io_canceled flag similarly to scsi-disk.
Signed-off-by: Fam Zheng
---
hw/scsi/scsi-generic.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/scsi/scsi-generic.c b/hw/scs
v4: Call notifier_list_notify in scsi_req_complete. (Paolo)
v3: Address Paolo's comments:
- scsi_req_canceled -> scsi_req_cancel_complete
- Drop unnecessary changes in scsi_req_alloc and scsi_req_unref.
- Update comment of scsi_req_cancel_async.
- Add notifier only if not null.
On Thu, 09/25 10:51, Paolo Bonzini wrote:
> Il 25/09/2014 04:20, Fam Zheng ha scritto:
> > Devices will call this function to start an asynchronous cancellation. The
> > bus->info->cancel will be called after the request is canceled.
> >
> > Devices will probably need to track a separate TMF reque
On 09/27/2014 07:58 AM, Bastian Koppelmann wrote:
> Add instructions of B opcode format.
>
> Signed-off-by: Bastian Koppelmann
> ---
> target-tricore/translate.c | 27 +++
> 1 file changed, 27 insertions(+)
Reviewed-by: Richard Henderson
On 09/27/2014 07:58 AM, Bastian Koppelmann wrote:
+env->gpr_a[2] = cpu_ldl_data(env, ea+8);
> +env->gpr_a[3] = cpu_ldl_data(env, ea+12);
> +env->gpr_d[0] = cpu_ldl_data(env, ea+16);
> +env->gpr_d[1] = cpu_ldl_data(env, ea+20);
> +env->gpr_d[2] = cpu_ldl_data(env, ea+24);
Wat
Hi,
Ping^2...
Can anyone help reviewing this patch? Luiz? Eric? Markus? Thanks;)
Best regards,
zhanghailiang
On 2014/9/24 8:39, zhanghailiang wrote:
Hi,
Ping...
Thanks,
zhanghailiang
On 2014/9/19 14:43, zhanghailiang wrote:
Hi,
In original code, Function dump_error ignores its second p
Add instructions of BO opcode format.
Add microcode generator functions gen_swap, gen_ldmst.
Add helper for loading/storing byte, halfword, upper halfword word, dword in
circular and bit reverse addr mode
Add sign extended bitmask for BO_OFF10 field.
Signed-off-by: Bastian Koppelmann
---
target
Add instructions of B opcode format.
Signed-off-by: Bastian Koppelmann
---
target-tricore/translate.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/target-tricore/translate.c b/target-tricore/translate.c
index 3ec5ca7..871c3cd 100644
--- a/target-tricore/transl
Add instructions of ABS, ABSB opcode format.
Add microcode generator functions for ld/st of two 32bit reg as one 64bit value.
Add microcode generator functions for ldmst and swap.
Add helper ldlcx, lducx, stlcx and stucx.
Signed-off-by: Bastian Koppelmann
---
target-tricore/helper.h| 4 +
Add instructions of BIT opcode format.
Add microcode generator functions gen_bit_1/2op to do 1/2 bit operations on the
last bit.
Signed-off-by: Bastian Koppelmann
---
target-tricore/translate.c | 349 +
1 file changed, 349 insertions(+)
diff --git a/
Move FCX loading of save_context_ to caller functions, for STLCX, STUCX insn to
use those functions.
Move FCX storing of restore_context_ to caller functions, for LDLCX, LDUCX insn
to use those functions.
Remove do_raise_exception function, which caused clang to emit a warning.
Fix: save_context_
Hi guys,
here is the next round of TriCore patches. The first patch addresses a clang
issue mentioned by Peter Maydell and
some bugfixes. And the other four add instructions of the ABS, ABSB, B, BIT and
BO opcode format.
Thanks,
Bastian
Bastian Koppelmann (5):
target-tricore: Cleanup and Bu
** Also affects: qemu
Importance: Undecided
Status: New
** No longer affects: qemu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/62244
Title:
Debugging mode not enabled in Bochs.
Status
Hi Peter,
thanks for the hints! Indeed there was an outdated version of iasl on my
system, which I have manually installed in /usr/local/bin many years
ago... (on both machines, on the gentoo as well as the kubuntu box) -
sorry for that!!!
That produced an error message during build (see below),
On 27 September 2014 10:28, Thomas Eschenbacher
wrote:
> update: I found out that the latest version on the stable-1.7 branch builds
> fine, but all stable-2.0 and later fail.
> I did some binary search on all versions on the stable-2.0 branch and found
> out that the problem occurs after this c
> > > virtio-net: use aliases instead of duplicate qdev properties
> > > virtio: fix virtio-net child refcount in transports
> > > virtio/vhost scsi: use aliases instead of duplicate qdev properties
> > > virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in
> > > transports
>
update: I found out that the latest version on the stable-1.7 branch builds
fine, but all stable-2.0 and later fail.
I did some binary search on all versions on the stable-2.0 branch and found out
that the problem occurs after this commit:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=15bce1b7c
John Snow writes:
> On the subject of compatibly broken:
> Is there any circumstance where the mapping has *any* effect on the
> current working behavior? Since we do not support the shorthand syntax
> at all currently, there is no code that USES this mapping to do
> anything.
>
> Even if you spe
31 matches
Mail list logo
