[Qemu-devel] Fw:Re:What does "COW" mean?

2014-09-02 Thread shhuiw
Hi, Sorry to trouble you. I posted my question in the user mailing list, but can not get the right answer. So I forward it to the devel mailing list. Hope to find answer here. At 2014-09-02 04:33:50, "shhuiw" wrote: > > >Hi, > >I'm new to qemu community, and I'm trying the COW image format (ol

[Qemu-devel] Question about cow format with hexdump

2014-09-02 Thread shhuiw
Hi, I'm reading the source code of cow.c: https://github.com/qemu/qemu/blob/master/block/cow.c and try to understand the format better. I created a cow format imagefile and can run 'qume-img info' to query the header info

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Gonglei (Arei)
Best regards, -Gonglei > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Wednesday, September 03, 2014 2:25 PM > To: Gonglei (Arei) > Cc: Eduardo Habkost; qemu-devel@nongnu.org; aligu...@amazon.com; > m...@redhat.com; pbonz...@redhat.com; ak...@redhat.com;

[Qemu-devel] [PULL 06/10] MAINTAINERS: Add VMWare devices maintainer

2014-09-02 Thread Michael Tokarev
From: Dmitry Fleytman Signed-off-by: Dmitry Fleytman Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 142f68a..8622e01 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -684,6 +

[Qemu-devel] [PULL 08/10] qom/object.c, hmp.c: fix string_output_get_string() memory leak

2014-09-02 Thread Michael Tokarev
From: Chen Fan string_output_get_string() uses g_string_free(str, false) to transfer the 'str' pointer to callers and never free it. Signed-off-by: Chen Fan Reviewed-by: Peter Crosthwaite Reviewed-by: Hu Tao Signed-off-by: Michael Tokarev --- hmp.c|6 -- qom/object.c | 12

[Qemu-devel] [PULL 01/10] curl: The macro that you have to uncomment to get debugging is DEBUG_CURL.

2014-09-02 Thread Michael Tokarev
From: "Richard W.M. Jones" Signed-off-by: Richard W.M. Jones Signed-off-by: Michael Tokarev --- block/curl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index 0258339..938f9d9 100644 --- a/block/curl.c +++ b/block/curl.c @@ -26,7 +26,7 @@

[Qemu-devel] [PULL 04/10] device_tree.c: redirect load_device_tree err message to stderr

2014-09-02 Thread Michael Tokarev
From: Li Liu Reviewed-by: Peter Crosthwaite Signed-off-by: Li Liu Signed-off-by: Michael Tokarev --- device_tree.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/device_tree.c b/device_tree.c index ca83504..9d47195 100644 --- a/device_tree.c +++ b/device

[Qemu-devel] [PULL 09/10] hmp: fix MemdevList memory leak

2014-09-02 Thread Michael Tokarev
From: Chen Fan the memdev_list in hmp_info_memdev() is never freed. so we use existent method qapi_free_MemdevList() to free it. and also we can use qapi_free_MemdevList() to replace list loops to clean up the memdev list in error path. Signed-off-by: Chen Fan Reviewed-by: Peter Crosthwaite Re

[Qemu-devel] [PULL 03/10] scripts: Remove scripts/qtest

2014-09-02 Thread Michael Tokarev
From: Fam Zheng This is a dummy file with no user, drop it. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- scripts/qtest |5 - 1 file changed, 5 deletions(-) delete mode 100755 scripts/qtest diff --git a/scripts/qtest b/scripts/qtest delete

[Qemu-devel] [PULL 05/10] device_tree.c: dump all err mesages with error_report

2014-09-02 Thread Michael Tokarev
From: Li Liu Signed-off-by: Li Liu Signed-off-by: Michael Tokarev --- device_tree.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/device_tree.c b/device_tree.c index 9d47195..df9eed9 100644 --- a/device_tree.c +++ b/device_tree

[Qemu-devel] [PULL 02/10] Fix debug print warning

2014-09-02 Thread Michael Tokarev
From: Gonglei Steps: 1.enable qemu debug print, using simply scprit as below: grep "//#define DEBUG" * -rl | xargs sed -i "s/\/\/#define DEBUG/#define DEBUG/g" 2. make -j 3. get some warning: hw/i2c/pm_smbus.c: In function 'smb_ioport_writeb': hw/i2c/pm_smbus.c:142: warning: format '%04x' expe

[Qemu-devel] [PULL 10/10] slirp: Honour vlan/stack in hostfwd_remove commands

2014-09-02 Thread Michael Tokarev
From: Peter Maydell The hostfwd_add and hostfwd_remove monitor commands allow the user to optionally specify a vlan/stack tuple. hostfwd_add honours this, but hostfwd_remove does not (it looks up the tuple but then ignores the SlirpState it has looked up and always uses the first stack in the lis

[Qemu-devel] [PULL 07/10] query-memdev: fix potential memory leaks

2014-09-02 Thread Michael Tokarev
From: Chen Fan Signed-off-by: Chen Fan Reviewed-by: Peter Crosthwaite Reviewed-by: Hu Tao Signed-off-by: Michael Tokarev --- numa.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/numa.c b/numa.c index c78cec9..aa772aa 100644 --- a/numa.c +++ b/numa.c @@ -318,10 +

[Qemu-devel] [PULL 00/10] Trivial patches for 2014-09-03

2014-09-02 Thread Michael Tokarev
Here's a next trivial-patches batch. A few little things here and there. Please consider applying. Thanks, /mjt The following changes since commit 30eaca3acdf17d7bcbd1213eb149c02037edfb0b: Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20140902-1' into staging

[Qemu-devel] [PATCH] vhost_net: initialize acked_features to a safe value during ack

2014-09-02 Thread Jason Wang
commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and vhost_ack_features) removes the step that initializes the acked_features to backend_features. This will result an unexpected value of acked_features which may fail the features setting of vhost. This patch fixes it b

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Gerd Hoffmann
Hi, > 4. When we hotplug the virtio-net-pci device, only pass virtio-net-pci's > pointer to > del_boot_device_path(). But virtio-net-pci != virtio-net-device, so I add a > function > named is_same_fw_dev_path() to handle this situation. When hot-unplugging virtio-net-pci I'd expect we free

[Qemu-devel] [PATCH V2] fix: unix sockets created for virtio-serail has insufficient permissions

2014-09-02 Thread Chunyan Liu
Add umask to _virCommand, allow user to set umask to command. Set umask(002) to qemu process to overwrite default umask(022) so that unix sockets created for virtio-serial has expected permissions. Fix problem reported here: https://sourceware.org/bugzilla/show_bug.cgi?id=13078#c11 https://bugzill

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 02:17:02AM +0400, Andrey Korolyov wrote: > On Wed, Sep 3, 2014 at 2:09 AM, Andrey Korolyov wrote: > > On Wed, Sep 3, 2014 at 1:51 AM, Michael S. Tsirkin wrote: > >> On Wed, Sep 03, 2014 at 01:29:29AM +0400, Andrey Korolyov wrote: > >>> On Wed, Sep 3, 2014 at 1:03 AM, Micha

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Jason Wang
On 09/03/2014 02:35 PM, Michael S. Tsirkin wrote: > On Wed, Sep 03, 2014 at 02:17:02AM +0400, Andrey Korolyov wrote: >> On Wed, Sep 3, 2014 at 2:09 AM, Andrey Korolyov wrote: >>> On Wed, Sep 3, 2014 at 1:51 AM, Michael S. Tsirkin wrote: On Wed, Sep 03, 2014 at 01:29:29AM +0400, Andrey Koroly

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-09-02 Thread Bharata B Rao
On Tue, Aug 19, 2014 at 5:51 AM, Michael Roth wrote: > From: Nathan Fontenot > > This add entries to the root OF node to advertise our PHBs as being > DR-capable in according with PAPR specification. > > Each PHB is given a name of PHB, advertised as a PHB type, > and associated with a power doma

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 02:17:02AM +0400, Andrey Korolyov wrote: > On Wed, Sep 3, 2014 at 2:09 AM, Andrey Korolyov wrote: > > On Wed, Sep 3, 2014 at 1:51 AM, Michael S. Tsirkin wrote: > >> On Wed, Sep 03, 2014 at 01:29:29AM +0400, Andrey Korolyov wrote: > >>> On Wed, Sep 3, 2014 at 1:03 AM, Micha

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 02:17:02AM +0400, Andrey Korolyov wrote: > On Wed, Sep 3, 2014 at 2:09 AM, Andrey Korolyov wrote: > > On Wed, Sep 3, 2014 at 1:51 AM, Michael S. Tsirkin wrote: > >> On Wed, Sep 03, 2014 at 01:29:29AM +0400, Andrey Korolyov wrote: > >>> On Wed, Sep 3, 2014 at 1:03 AM, Micha

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-02 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 01:40:45AM +, Kay, Allen M wrote: > > > > -Original Message- > > From: Chen, Tiejun > > Sent: Monday, September 01, 2014 12:50 AM > > To: Michael S. Tsirkin > > Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org; > > Konrad Rzeszutek Wilk >

[Qemu-devel] [Bug 1254828] Re: qemu-sparc64-static: Segmentation Fault during debootstrap second stage

2014-09-02 Thread Itaru Kitayama
I am seeing the same: # qemu-sparc64-static -version qemu-sparc64 version 2.1.50, Copyright (c) 2003-2008 Fabrice Bellard -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1254828 Title: qemu-sparc64-

[Qemu-devel] [PATCH 1/3] trace: Only link generated-tracers.o with "simple" backend

2014-09-02 Thread Fam Zheng
In any other cases the object file is effectively empty, which is disliked by ranlib and nm on Mac OS X. Reported-by: Peter Maydell Signed-off-by: Fam Zheng --- trace/Makefile.objs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/trace/Makefile.objs b/trace/Makefile.objs in

[Qemu-devel] [PATCH 3/3] util: Don't link host-utils.o if it's empty

2014-09-02 Thread Fam Zheng
Reported-by: Peter Maydell Signed-off-by: Fam Zheng --- util/Makefile.objs | 3 ++- util/host-utils.c | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/util/Makefile.objs b/util/Makefile.objs index 6b3c83b..cb8862b 100644 --- a/util/Makefile.objs +++ b/util/Makefile.objs @@

[Qemu-devel] [PATCH 0/3] build-sys: Exclude empty object files when linking libqemuutil.a

2014-09-02 Thread Fam Zheng
On Mac OS X, ranlib complains on a few empty objects: ARlibqemuutil.a /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libqemuutil.a(generated-tracers.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefa

[Qemu-devel] [PATCH 2/3] util: Move general qemu_getauxval to util/getauxval.c

2014-09-02 Thread Fam Zheng
So that we won't have an empty getauxval.o which is disliked by ranlib. Reported-by: Peter Maydell Suggested-by: Paolo bonz...@redhat.com Signed-off-by: Fam Zheng --- include/qemu/osdep.h | 4 util/getauxval.c | 8 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH v2] rules.mak: Fix DSO build by pulling in archive symbols

2014-09-02 Thread Fam Zheng
On Tue, 09/02 14:07, Paolo Bonzini wrote: > Il 02/09/2014 03:19, Fam Zheng ha scritto: > > Thanks both of you for tracking down the problem. Let's add 2>/dev/null to > > suppress the warning. > > Actually I think the warning would complicate tracking down real > problems. We can fix the source of

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Gonglei (Arei)
> Subject: RE: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > Hi, > > > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > > Sent: Wednesday, September 03, 2014 2:00 AM > > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > Importance: High > > > >

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Gonglei (Arei)
Hi, > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Wednesday, September 03, 2014 2:00 AM > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > Importance: High > > On Mon, Sep 01, 2014 at 06:47:13AM +, Gonglei (Arei) wrote: > > > From: Gerd Hoffmann [mai

[Qemu-devel] vhost-user mmap failed

2014-09-02 Thread linhafieng
hi, I run the qemu-master(vhost-user v10)with the vapp(vhost-user v9).It says mmap failed,do you know why this happen? ./vhost -s /path/to/socket Processing message: VHOST_USER_SET_MEM_TABLE _set_mem_table mmap: Invalid argument mmap: Invalid argument Got memory.nregions 2 Cmd: VHOST_USER_SET_V

Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option

2014-09-02 Thread Hu Tao
On Tue, Sep 02, 2014 at 11:45:38PM +0200, Max Reitz wrote: > On 29.08.2014 10:33, Hu Tao wrote: > >This patch adds a new option preallocation for raw format, and implements > >full preallocation. > > > >Signed-off-by: Hu Tao > >--- > > block/raw-posix.c | 92 > > +

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-02 Thread Kay, Allen M
> -Original Message- > From: Chen, Tiejun > Sent: Monday, September 01, 2014 12:50 AM > To: Michael S. Tsirkin > Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org; > Konrad Rzeszutek Wilk > Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create > i

Re: [Qemu-devel] [PATCH v13 4/6] qapi: introduce PreallocMode and a new PreallocMode full.

2014-09-02 Thread Hu Tao
On Tue, Sep 02, 2014 at 03:51:23PM -0600, Eric Blake wrote: > On 08/29/2014 02:33 AM, Hu Tao wrote: > > This patch prepares for the subsequent patches. > > > > Signed-off-by: Hu Tao > > --- > > block/qcow2.c | 23 +++ > > qapi/block-core.json | 16 +

Re: [Qemu-devel] [PATCH v13 4/6] qapi: introduce PreallocMode and a new PreallocMode full.

2014-09-02 Thread Hu Tao
On Tue, Sep 02, 2014 at 11:32:50PM +0200, Max Reitz wrote: > On 29.08.2014 10:33, Hu Tao wrote: > >This patch prepares for the subsequent patches. > > > >Signed-off-by: Hu Tao > >--- > > block/qcow2.c | 23 +++ > > qapi/block-core.json | 16

Re: [Qemu-devel] [PATCH v13 3/6] rename parse_enum_option to qapi_enum_parse and make it public

2014-09-02 Thread Hu Tao
On Tue, Sep 02, 2014 at 11:27:00PM +0200, Max Reitz wrote: > On 29.08.2014 10:33, Hu Tao wrote: > >From: Peter Lieven > > > >relaxing the license to LGPLv2+ is intentional. > > > >Suggested-by: Markus Armbruster > >Signed-off-by: Hu Tao > >Signed-off-by: Peter Lieven > >Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option

2014-09-02 Thread Hu Tao
On Fri, Aug 29, 2014 at 09:48:01AM +0100, Richard W.M. Jones wrote: > On Fri, Aug 29, 2014 at 04:33:12PM +0800, Hu Tao wrote: > > +if (prealloc == PREALLOC_MODE_FULL) { > > +/* posix_fallocate() doesn't set errno. */ > > +result = -posix_fallocate(fd, 0, total_size); > > +

Re: [Qemu-devel] [PATCH] xen-hvm.c: Improve the return method for xen_hvm_init()

2014-09-02 Thread Chen Gang
Oh, sorry, forgot Cc to qemu trivial. Thanks. On 9/3/14 0:22, Chen Gang wrote: > When failure occurs, it need use "return -1" instead of exit(1), so can > let upper caller has chance to print failure information, too, then user > can know the failure result more clearly. > > xen_hvm_init() may

Re: [Qemu-devel] [PATCH V2] acpi-build: Set FORCE_APIC_CLUSTER_MODEL bit for FADT flags

2014-09-02 Thread zhanghailiang
Hi, Ping... Thanks, zhanghailiang On 2014/8/29 11:52, zhanghailiang wrote: If we start Windows 2008 R2 DataCenter with number of cpu less than 8, The system will use APIC Flat Logical destination mode as default configuration, Which has an upper limit of 8 CPUs. The fault is that VM can not s

Re: [Qemu-devel] [PATCH v3 0/8] block: Asynchronous request cancellation

2014-09-02 Thread Fam Zheng
On Tue, 09/02 16:09, Stefan Hajnoczi wrote: > On Wed, Aug 27, 2014 at 10:49:08AM +0800, Fam Zheng wrote: > > v3: Drop "RFC". > > Improvements according to Paolo's comments: > > 05: Just use THREAD_DONE and ret = -ECANCELED in thread-pool.c > > 06: Don't check dbs->cancelled for twice. >

Re: [Qemu-devel] tcmu-runner and QEMU

2014-09-02 Thread Andy Grover
On 09/02/2014 02:25 AM, Stefan Hajnoczi wrote: The easiest approach is to write a tool similar to qemu-nbd that speaks the userspace target protocol (i.e. mmap the shared memory). If the tcmu setup code is involved, maybe providing a libtcmu with the setup code would be useful. I suspect that

Re: [Qemu-devel] [PATCH memory v2 0/3] Memory Region Naming - take 2

2014-09-02 Thread Stefano Stabellini
Sorry for the late reply. I just wanted to confirm that it's all working now. Thanks, Stefano On Mon, 25 Aug 2014, Peter Crosthwaite wrote: > Hi, > > Here is an attempt at a proper fix to the memory region naming bugs as > reported by Peter. The Xen compile bug and the memory leak. > > Regard

Re: [Qemu-devel] [RFC PATCH v2 2/2] VFIO: Clear stale MSIx table during EEH reset

2014-09-02 Thread Gavin Shan
On Tue, Sep 02, 2014 at 02:10:42PM -0600, Alex Williamson wrote: >On Mon, 2014-09-01 at 10:53 +1000, Gavin Shan wrote: >> The PCI device MSIx table is cleaned out in hardware after EEH PE >> reset. However, we still hold the stale MSIx entries in QEMU, which >> should be cleared accordingly. Otherw

Re: [Qemu-devel] [RFC V2 7/8] throttle: Add throttle group support

2014-09-02 Thread Eric Blake
On 08/13/2014 08:23 AM, Benoît Canet wrote: > The throttle group support use a cooperative round robin scheduling algorithm. > > The principle of the algorithm are simple: s/are/is/ > - Each BDS of the group is used as a token in a circular way. > - The active BDS compute if a wait must be done

Re: [Qemu-devel] [PATCH v2 3/3] docs/qcow2: Limit refcount_order to [0, 6]

2014-09-02 Thread Eric Blake
On 09/02/2014 04:25 PM, Max Reitz wrote: > Specify the upper limit of refcount_order to be 6 (that is, > refcount_bits = 64). Any larger value does not make much sense when all > offsets, sizes, cluster counts etc. "only" have a width of 64 bit as > well, and very large values would be very difficu

Re: [Qemu-devel] [PATCH v2 2/3] docs/qcow2: Correct refcount_block_entries

2014-09-02 Thread Eric Blake
On 09/02/2014 04:25 PM, Max Reitz wrote: > A refblock entry may have a different size than 16 bits, it may even be > smaller than a byte. Correct the refcount_block_entries calculation > accordingly. > > Signed-off-by: Max Reitz > --- > docs/specs/qcow2.txt | 2 +- > 1 file changed, 1 insertion(

[Qemu-devel] [PATCH v2 2/3] docs/qcow2: Correct refcount_block_entries

2014-09-02 Thread Max Reitz
A refblock entry may have a different size than 16 bits, it may even be smaller than a byte. Correct the refcount_block_entries calculation accordingly. Signed-off-by: Max Reitz --- docs/specs/qcow2.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/qcow2.txt b/do

[Qemu-devel] [PATCH v2 0/3] qcow2: Drop REFCOUNT_SHIFT

2014-09-02 Thread Max Reitz
In preparation for qemu maybe actually supporting variable refcount widths in the far future, drop the hardcoded REFCOUNT_SHIFT and instead use the value as given by the image. Also, the qcow2 documentation gave the width of a refcount block entry as sizeof(uint16_t), which is wrong for any refcou

[Qemu-devel] [PATCH v2 1/3] qcow2: Drop REFCOUNT_SHIFT

2014-09-02 Thread Max Reitz
With BDRVQcowState.refcount_block_bits, we don't need REFCOUNT_SHIFT anymore. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2-refcount.c | 32 ++-- block/qcow2.c | 2 +- block/qcow2.h | 2 -- 3 files changed, 15 insertions(+), 21

[Qemu-devel] [PATCH v2 3/3] docs/qcow2: Limit refcount_order to [0, 6]

2014-09-02 Thread Max Reitz
Specify the upper limit of refcount_order to be 6 (that is, refcount_bits = 64). Any larger value does not make much sense when all offsets, sizes, cluster counts etc. "only" have a width of 64 bit as well, and very large values would be very difficult to support. Therefore, just cap it at the larg

Re: [Qemu-devel] [PATCH 0/8] add basic recovery logic to quorum driver

2014-09-02 Thread Benoît Canet
The Monday 01 Sep 2014 à 15:43:06 (+0800), Liu Yuan wrote : Liu, Do you think this could work with qcow2 file backed by NFS servers ? Best regards Benoît > This patch set mainly add mainly two logics to implement device recover > - notify qourum driver of the broken states from the child drive

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Andrey Korolyov
On Wed, Sep 3, 2014 at 2:09 AM, Andrey Korolyov wrote: > On Wed, Sep 3, 2014 at 1:51 AM, Michael S. Tsirkin wrote: >> On Wed, Sep 03, 2014 at 01:29:29AM +0400, Andrey Korolyov wrote: >>> On Wed, Sep 3, 2014 at 1:03 AM, Michael S. Tsirkin wrote: >>> >> bad one is the >>> >> >>> >> Author: Jason W

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Andrey Korolyov
On Wed, Sep 3, 2014 at 1:51 AM, Michael S. Tsirkin wrote: > On Wed, Sep 03, 2014 at 01:29:29AM +0400, Andrey Korolyov wrote: >> On Wed, Sep 3, 2014 at 1:03 AM, Michael S. Tsirkin wrote: >> >> bad one is the >> >> >> >> Author: Jason Wang >> >> Date: Tue Sep 2 18:07:46 2014 +0300 >> >> >> >>

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Michael Roth
Quoting Andrey Korolyov (2014-09-02 16:29:29) > On Wed, Sep 3, 2014 at 1:03 AM, Michael S. Tsirkin wrote: > >> bad one is the > >> > >> Author: Jason Wang > >> Date: Tue Sep 2 18:07:46 2014 +0300 > >> > >> vhost_net: start/stop guest notifiers properly > > > > > > > > upstream has this (pul

Re: [Qemu-devel] [PATCH v13 6/6] qcow2: Add full preallocation option

2014-09-02 Thread Max Reitz
On 29.08.2014 10:33, Hu Tao wrote: preallocation=full allocates disk space by fallocating the space if posix_fallocate() is available, otherwise by writing zeros to disk to ensure disk space in any cases. Signed-off-by: Hu Tao --- block/qcow2.c | 61 ++

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 01:29:29AM +0400, Andrey Korolyov wrote: > On Wed, Sep 3, 2014 at 1:03 AM, Michael S. Tsirkin wrote: > >> bad one is the > >> > >> Author: Jason Wang > >> Date: Tue Sep 2 18:07:46 2014 +0300 > >> > >> vhost_net: start/stop guest notifiers properly > > > > > > > > ups

Re: [Qemu-devel] [PATCH v13 4/6] qapi: introduce PreallocMode and a new PreallocMode full.

2014-09-02 Thread Eric Blake
On 08/29/2014 02:33 AM, Hu Tao wrote: > This patch prepares for the subsequent patches. > > Signed-off-by: Hu Tao > --- > block/qcow2.c | 23 +++ > qapi/block-core.json | 16 > tests/qemu-iotests/049.out | 2 +- > 3 files changed, 32 inser

Re: [Qemu-devel] [PATCH v13 5/6] raw-posix: Add full preallocation option

2014-09-02 Thread Max Reitz
On 29.08.2014 10:33, Hu Tao wrote: This patch adds a new option preallocation for raw format, and implements full preallocation. Signed-off-by: Hu Tao --- block/raw-posix.c | 92 +++ qemu-doc.texi | 8 + qemu-img.texi | 8 +++

Re: [Qemu-devel] [PATCH v13 4/6] qapi: introduce PreallocMode and a new PreallocMode full.

2014-09-02 Thread Max Reitz
On 29.08.2014 10:33, Hu Tao wrote: This patch prepares for the subsequent patches. Signed-off-by: Hu Tao --- block/qcow2.c | 23 +++ qapi/block-core.json | 16 tests/qemu-iotests/049.out | 2 +- 3 files changed, 32 insertions(+), 9 d

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Andrey Korolyov
On Wed, Sep 3, 2014 at 1:03 AM, Michael S. Tsirkin wrote: >> bad one is the >> >> Author: Jason Wang >> Date: Tue Sep 2 18:07:46 2014 +0300 >> >> vhost_net: start/stop guest notifiers properly > > > > upstream has this (pull request sent today): > vhost_net: cleanup start/stop condition > >

Re: [Qemu-devel] [PATCH v13 3/6] rename parse_enum_option to qapi_enum_parse and make it public

2014-09-02 Thread Max Reitz
On 29.08.2014 10:33, Hu Tao wrote: From: Peter Lieven relaxing the license to LGPLv2+ is intentional. Suggested-by: Markus Armbruster Signed-off-by: Hu Tao Signed-off-by: Peter Lieven Reviewed-by: Eric Blake Reviewed-by: Benoit Canet --- blockdev.c | 30 ++--

Re: [Qemu-devel] [PATCH v13 2/6] block: don't convert file size to sector size

2014-09-02 Thread Max Reitz
On 29.08.2014 10:33, Hu Tao wrote: and avoid converting it back later. Signed-off-by: Hu Tao --- block/gluster.c | 9 - block/qcow.c | 8 block/qcow2.c | 10 +- block/raw-posix.c | 6 +++--- block/raw-win32.c | 6 +++--- 5 files changed, 19 inserti

Re: [Qemu-devel] [PATCH v13 1/6] block: round up file size to nearest sector

2014-09-02 Thread Max Reitz
On 29.08.2014 10:33, Hu Tao wrote: Signed-off-by: Hu Tao --- block/archipelago.c | 3 ++- block/cow.c | 3 ++- block/gluster.c | 4 +-- block/iscsi.c| 4 +-- block/nfs.c | 3 ++- block/qcow.c

Re: [Qemu-devel] [PATCH v5 06/10] hw/vfio: create common module

2014-09-02 Thread Alex Williamson
On Tue, 2014-09-02 at 09:13 +0200, Eric Auger wrote: > On 09/01/2014 07:41 PM, Alexander Graf wrote: > > > > > >> Am 01.09.2014 um 18:31 schrieb Eric Auger : > >> > >>> On 08/13/2014 09:59 PM, Alex Williamson wrote: > On Tue, 2014-08-12 at 08:09 +0200, Eric Auger wrote: > > On 08/11/2014

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Michael S. Tsirkin
On Tue, Sep 02, 2014 at 09:33:13PM +0400, Andrey Korolyov wrote: > On Tue, Sep 2, 2014 at 7:27 PM, Michael S. Tsirkin wrote: > > On Tue, Sep 02, 2014 at 06:25:46PM +0300, Michael S. Tsirkin wrote: > >> On Tue, Sep 02, 2014 at 10:20:50AM -0500, Michael Roth wrote: > >> > Quoting Michael Roth (2014-

[Qemu-devel] QEMU correctness and performance testing

2014-09-02 Thread Xin Tong
​where can i find most recent correctness and performance #s for QEMU ? are there any organizations running these and making their data available online ? Thanks, Xin​

Re: [Qemu-devel] [PATCH v4 00/14] ivshmem: update documentation, add client/server tools

2014-09-02 Thread Eric Blake
On 09/02/2014 09:25 AM, David Marchand wrote: > Here is a patchset containing an update on ivshmem specs documentation and > importing ivshmem server and client tools. > These tools have been written from scratch and are not related to what is > available in nahanni repository. > I put them in cont

Re: [Qemu-devel] [PATCH v2 3/5] qemu-char: Convert udp backend to QAPI

2014-09-02 Thread Peter Maydell
On 2 September 2014 21:04, Eric Blake wrote: > On 09/02/2014 04:24 AM, Peter Maydell wrote: >> + >> +if (host == NULL || strlen(host) == 0) { >> +host = "localhost"; >> +} >> +if (port == NULL || strlen(port) == 0) { >> +error_setg(errp, "chardev: udp: remote port not s

Re: [Qemu-devel] [PATCH v4 05/14] contrib/ivshmem-*: switch to QEMU headers

2014-09-02 Thread Eric Blake
On 09/02/2014 09:25 AM, David Marchand wrote: > Reuse parsers from QEMU, C99 boolean. > > Signed-off-by: David Marchand > --- > contrib/ivshmem-client/ivshmem-client.c | 12 + > contrib/ivshmem-client/ivshmem-client.h |4 +- > contrib/ivshmem-client/main.c | 12 + > con

Re: [Qemu-devel] [PATCH v4 02/14] docs: update ivshmem device spec

2014-09-02 Thread Eric Blake
On 09/02/2014 09:25 AM, David Marchand wrote: > Add some notes on the parts needed to use ivshmem devices: more specifically, > explain the purpose of an ivshmem server and the basic concept to use the > ivshmem devices in guests. > Move some parts of the documentation and re-organise it. > > Sign

Re: [Qemu-devel] [PATCH v4 01/14] contrib: add ivshmem client and server

2014-09-02 Thread Eric Blake
On 09/02/2014 09:25 AM, David Marchand wrote: > When using ivshmem devices, notifications between guests can be sent as > interrupts using a ivshmem-server (typical use described in documentation). > The client is provided as a debug tool. > > Signed-off-by: Olivier Matz > Signed-off-by: David Ma

Re: [Qemu-devel] [RFC PATCH v2 2/2] VFIO: Clear stale MSIx table during EEH reset

2014-09-02 Thread Alex Williamson
On Mon, 2014-09-01 at 10:53 +1000, Gavin Shan wrote: > The PCI device MSIx table is cleaned out in hardware after EEH PE > reset. However, we still hold the stale MSIx entries in QEMU, which > should be cleared accordingly. Otherwise, we will run into another > (recursive) EEH error and the PCI dev

Re: [Qemu-devel] [PATCH v2 3/5] qemu-char: Convert udp backend to QAPI

2014-09-02 Thread Eric Blake
On 09/02/2014 04:24 AM, Peter Maydell wrote: > Convert the udp char backend to the new style QAPI framework. > > Signed-off-by: Peter Maydell > --- > qemu-char.c | 69 > +++-- > 1 file changed, 54 insertions(+), 15 deletions(-) > > + > +

Re: [Qemu-devel] [PATCH v2] dump: let dump_error return error info to caller

2014-09-02 Thread Eric Blake
On 09/02/2014 02:25 AM, zhanghailiang wrote: > The second parameter of dump_error is unused, but one purpose of > using this function is to report the error info. > > Use error_set to return the error info to the caller. > > Signed-off-by: zhanghailiang > --- > V2: > - Return the error reason t

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Michael Roth
Quoting Andrey Korolyov (2014-09-02 12:33:13) > On Tue, Sep 2, 2014 at 7:27 PM, Michael S. Tsirkin wrote: > > On Tue, Sep 02, 2014 at 06:25:46PM +0300, Michael S. Tsirkin wrote: > >> On Tue, Sep 02, 2014 at 10:20:50AM -0500, Michael Roth wrote: > >> > Quoting Michael Roth (2014-08-27 12:35:57) > >

Re: [Qemu-devel] [PATCH v5 11/11] iotests: Add test for potentially damaging repairs

2014-09-02 Thread Eric Blake
On 08/29/2014 03:41 PM, Max Reitz wrote: > There are certain cases where repairing a qcow2 image might actually > damage it further (or rather, where repairing it has in fact damaged it > further with the old qcow2 check implementation). This should not > happen, so add a test for these cases. > >

Re: [Qemu-devel] [PATCH v5 10/11] iotests: Fix test outputs

2014-09-02 Thread Eric Blake
On 08/29/2014 03:41 PM, Max Reitz wrote: > 039, 060 and 061 all create images with referenced clusters having a > refcount of 0. Because previous commits changed handling of such errors, > these tests now have a different output. Fix it. > > Furthermore, 060 created a refblock with a refcount grea

[Qemu-devel] [Bug 1364501] Re: Gdb hangs when trying to single-step after an invalid instruction

2014-09-02 Thread Martin
>> Public bug reported: >> >> When using Gdb to remote-debug a program and manually setting its PC to >> point to an address containing an invalid instruction and then doing a >> single step, Qemu will never return control to the remote Gdb. >> >> For instance, let's say address 0x114 contains an i

Re: [Qemu-devel] [PATCH 2/2] docs/qcow2: Correct refcount_block_entries

2014-09-02 Thread Eric Blake
On 09/02/2014 12:59 PM, Max Reitz wrote: >> Consider refcount_order == 0 (that is, no shared blocks, ALL blocks have >> at most refcount 1). Then, refcount_bits is (1 << 0) == 1. But 1/8 in >> integer math truncates to 0 (oops, division by zero is undefined); when >> in reality, the expression y

Re: [Qemu-devel] [PATCH] block/iscsi: use 16 byte CDBs only when necessary

2014-09-02 Thread Peter Lieven
Looking at the code, is it possible that not the guest is causing trouble here, but multiwrite_merge code? >From what I see the only limit it has when merging requests is the number of >IOVs. Any thoughts? Mine are: a) Introducing bs->bl.max_request_size and set merge = 0 if the result would

Re: [Qemu-devel] [PATCH v2 2/2] qemu-img: fix rebase src_cache option documentation

2014-09-02 Thread Max Reitz
On 02.09.2014 12:01, Stefan Hajnoczi wrote: The src_cache option (-T) specifies the cache mode for backing files. It applies both the image's old backing file as well as the new backing file: ret = bdrv_open(&bs_old_backing, backing_name, NULL, NULL, src_flags, old_backing_

Re: [Qemu-devel] [PATCH v2 1/2] qemu-img: clarify src_cache option documentation

2014-09-02 Thread Max Reitz
On 02.09.2014 12:01, Stefan Hajnoczi wrote: The source cache option takes the same values as the cache option. The documentation reads a little strange because it starts with "In contrast the src_cache option ...". The fact that this is comparing with the previous documented option (the 'cache'

Re: [Qemu-devel] [PATCH 2/2] docs/qcow2: Correct refcount_block_entries

2014-09-02 Thread Max Reitz
On 30.08.2014 00:37, Eric Blake wrote: On 08/29/2014 03:45 PM, Max Reitz wrote: A refblock entry may have a different size than 16 bits, it may even be smaller than a byte. Correct the refcount_block_entries calculation accordingly. Signed-off-by: Max Reitz --- docs/specs/qcow2.txt | 2 +-

Re: [Qemu-devel] [PATCH v5 01/11] qcow2: Calculate refcount block entry count

2014-09-02 Thread Max Reitz
On 30.08.2014 01:03, Eric Blake wrote: On 08/29/2014 03:40 PM, Max Reitz wrote: The size of a refblock entry is (in theory) variable; calculate therefore the number of entries per refblock and the according bit shift (1 << x == entry count) when opening an image. Signed-off-by: Max Reitz ---

Re: [Qemu-devel] [Bug 1364501] [NEW] Gdb hangs when trying to single-step after an invalid instruction

2014-09-02 Thread Peter Maydell
On 2 September 2014 17:38, martin wrote: > Public bug reported: > > When using Gdb to remote-debug a program and manually setting its PC to > point to an address containing an invalid instruction and then doing a > single step, Qemu will never return control to the remote Gdb. > > For instance, le

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: Honour vlan/stack in hostfwd_remove commands

2014-09-02 Thread Michael Tokarev
26.06.2014 16:35, Peter Maydell wrote: > On 16 June 2014 16:47, Peter Maydell wrote: >> The hostfwd_add and hostfwd_remove monitor commands allow the user >> to optionally specify a vlan/stack tuple. hostfwd_add honours this, >> but hostfwd_remove does not (it looks up the tuple but then ignores >

Re: [Qemu-devel] [question] virtio-blk performance degradationhappened with virito-serial

2014-09-02 Thread Andrey Korolyov
On Tue, Sep 2, 2014 at 10:11 PM, Amit Shah wrote: > On (Tue) 02 Sep 2014 [22:05:45], Andrey Korolyov wrote: > >> Can confirm serious degradation comparing to the 1.1 with regular >> serial output - I am able to hang VM forever after some tens of >> seconds after continuously printing dmest to the

Re: [Qemu-devel] [PATCH] block/iscsi: use 16 byte CDBs only when necessary

2014-09-02 Thread Peter Lieven
Am 02.09.2014 um 17:28 schrieb ronnie sahlberg: > That is one big request. I assume the device reports "no limit" in > the VPD page so we can not state it is the guest/application going > beyond the allowed limit? Yes, my storage reports no limit, but afaik there is no way to tell the guest the l

Re: [Qemu-devel] [question] virtio-blk performance degradationhappened with virito-serial

2014-09-02 Thread Amit Shah
On (Tue) 02 Sep 2014 [22:05:45], Andrey Korolyov wrote: > Can confirm serious degradation comparing to the 1.1 with regular > serial output - I am able to hang VM forever after some tens of > seconds after continuously printing dmest to the ttyS0. VM just ate > all available CPU quota during test

Re: [Qemu-devel] [question] virtio-blk performance degradationhappened with virito-serial

2014-09-02 Thread Andrey Korolyov
On Tue, Sep 2, 2014 at 10:36 AM, Amit Shah wrote: > On (Mon) 01 Sep 2014 [20:52:46], Zhang Haoyu wrote: >> >>> Hi, all >> >>> >> >>> I start a VM with virtio-serial (default ports number: 31), and found >> >>> that virtio-blk performance degradation happened, about 25%, this >> >>> problem can b

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Eduardo Habkost
On Mon, Sep 01, 2014 at 06:47:13AM +, Gonglei (Arei) wrote: > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: Monday, September 01, 2014 2:43 PM > > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > Importance: High > > > > Hi, > > > > > +static bool

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-02 Thread Andrey Korolyov
On Tue, Sep 2, 2014 at 7:27 PM, Michael S. Tsirkin wrote: > On Tue, Sep 02, 2014 at 06:25:46PM +0300, Michael S. Tsirkin wrote: >> On Tue, Sep 02, 2014 at 10:20:50AM -0500, Michael Roth wrote: >> > Quoting Michael Roth (2014-08-27 12:35:57) >> > > Hi everyone, >> > > >> > > The following new patch

[Qemu-devel] [Bug 1364501] [NEW] Gdb hangs when trying to single-step after an invalid instruction

2014-09-02 Thread martin
Public bug reported: When using Gdb to remote-debug a program and manually setting its PC to point to an address containing an invalid instruction and then doing a single step, Qemu will never return control to the remote Gdb. For instance, let's say address 0x114 contains an invalid instruction.

Re: [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount

2014-09-02 Thread Greg Kurz
On Mon, 1 Sep 2014 18:52:48 +0800 Jun Li wrote: > When every item of refcount block is NULL, free refcount block and reset the > corresponding item of refcount table with NULL. > > Signed-off-by: Jun Li > --- > > The v2 do following change to modify some potential issue. > > +--

Re: [Qemu-devel] [PATCH v4 07/33] target-arm: add non-secure Translation Block flag

2014-09-02 Thread Greg Bellows
Thanks Peter. I'll fix these in v5. On 2 September 2014 11:11, Peter Maydell wrote: > On 1 July 2014 00:09, wrote: > > From: Sergey Fedorov > > > > This patch is based on idea found in patch at > > git://github.com/jowinter/qemu-trustzone.git > > f3d955c6c0ed8c46bc0eb10b634201032a651dd2 by

Re: [Qemu-devel] [PATCH v4 01/33] target-arm: add cpu feature EL3 to CPUs with Security Extensions

2014-09-02 Thread Peter Maydell
On 1 July 2014 00:09, wrote: > From: Fabian Aggeler > > Set ARM_FEATURE_EL3 feature for CPUs that implement Security Extensions. > > Signed-off-by: Fabian Aggeler > Signed-off-by: Greg Bellows When this patchset is eventually ready to commit, this patch needs to be the last one, so we don't e

[Qemu-devel] [PATCH] xen-hvm.c: Improve the return method for xen_hvm_init()

2014-09-02 Thread Chen Gang
When failure occurs, it need use "return -1" instead of exit(1), so can let upper caller has chance to print failure information, too, then user can know the failure result more clearly. xen_hvm_init() may also return -errno, which may let upper caller think more (e.g. free some other related reso

Re: [Qemu-devel] [PATCH v4 07/33] target-arm: add non-secure Translation Block flag

2014-09-02 Thread Peter Maydell
On 1 July 2014 00:09, wrote: > From: Sergey Fedorov > > This patch is based on idea found in patch at > git://github.com/jowinter/qemu-trustzone.git > f3d955c6c0ed8c46bc0eb10b634201032a651dd2 by > Johannes Winter . > > This flag prevents QEMU from executing TCG code generated for other CPU > sec

Re: [Qemu-devel] [PULL 13/13] vhost_net: start/stop guest notifiers properly

2014-09-02 Thread Michael S. Tsirkin
On Tue, Sep 02, 2014 at 05:47:54PM +0200, William Dauchy wrote: > On Sep02 18:07, Michael S. Tsirkin wrote: > > From: Jason Wang > > > > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > > support changed the order of stopping the device. Previously > > vhost_dev_stop would disa

  1   2   3   >