Re: [Qemu-devel] [questions] about using vfio to assign sr-iov vf to vm

2014-08-15 Thread Zhang Haoyu
>> Hi, all >> I'm using VFIO to assign intel 82599 VF to VM, now I encounter a problem, >> 82599 PF and its VFs belong to the same iommu_group, but I only want to >> assign some VFs to one VM, and some other VFs to another VM, ..., >> so how to only unbind (part of) the VFs but PF? >> I read the k

[Qemu-devel] [PATCH v4 6/8] intel-iommu: add supports for queued invalidation interface

2014-08-15 Thread Le Tan
Add supports for queued invalidation interface, an expended invalidation interface with extended capabilities. Signed-off-by: Le Tan --- hw/i386/intel_iommu.c | 373 - hw/i386/intel_iommu_internal.h | 27 ++- 2 files changed, 393 insertions(+), 7

[Qemu-devel] [PATCH v4 7/8] intel-iommu: add context-cache to cache context-entry

2014-08-15 Thread Le Tan
Add context-cache to cache context-entry encountered on a page-walk. Each VTDAddressSpace has a member of VTDContextCacheEntry which represents an entry in the context-cache. Since devices with different bus_num and devfn have their respective VTDAddressSpace, this will be a good way to reference t

[Qemu-devel] [PATCH v4 5/8] intel-iommu: fix coding style issues around in q35.c and machine.c

2014-08-15 Thread Le Tan
Fix coding style issues around in hw/pci-host/q35.c and hw/core/machine.c. Signed-off-by: Le Tan --- hw/core/machine.c | 10 +++--- hw/pci-host/q35.c | 11 ++- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index 0708de5..f0046d6

[Qemu-devel] [PATCH v4 8/8] intel-iommu: add IOTLB using hash table

2014-08-15 Thread Le Tan
Add IOTLB to cache information about the translation of input-addresses. IOTLB use a GHashTable as cache. The key of the hash table is the logical-OR of gfn and source id after left-shifting. Signed-off-by: Le Tan --- hw/i386/intel_iommu.c | 213 -

[Qemu-devel] [PATCH v4 3/8] intel-iommu: add DMAR table to ACPI tables

2014-08-15 Thread Le Tan
Expose Intel IOMMU to the BIOS. If object of TYPE_INTEL_IOMMU_DEVICE exists, add DMAR table to ACPI RSDT table. For now the DMAR table indicates that there is only one hardware unit without INTR_REMAP capability on the platform. Signed-off-by: Le Tan --- hw/i386/acpi-build.c | 39 +++

[Qemu-devel] [PATCH v4 4/8] intel-iommu: add Intel IOMMU emulation to q35 and add a machine option "iommu" as a switch

2014-08-15 Thread Le Tan
Add Intel IOMMU emulation to q35 chipset and expose it to the guest. 1. Add a machine option. Users can use "-machine iommu=on|off" in the command line to enable/disable Intel IOMMU. The default is off. 2. Accroding to the machine option, q35 will initialize the Intel IOMMU and use pci_setup_iommu(

[Qemu-devel] [PATCH v4 0/8] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset

2014-08-15 Thread Le Tan
Hi, These patches are intended to introduce Intel IOMMU (VT-d) emulation to q35 chipset. The major job in these patches is to add support for emulating Intel IOMMU according to the VT-d specification, including basic responses to CSRs accesses, the logics of DMAR (DMA remapping) and DMA memory add

[Qemu-devel] [PATCH v4 1/8] iommu: add is_write as a parameter to the translate function of MemoryRegionIOMMUOps

2014-08-15 Thread Le Tan
Add a bool variable is_write as a parameter to the translate function of MemoryRegionIOMMUOps to indicate the operation of the access. It can be used for correct fault reporting from within the callback. Change the interface of related functions. Signed-off-by: Le Tan --- exec.c|

[Qemu-devel] [PATCH v4 2/8] intel-iommu: introduce Intel IOMMU (VT-d) emulation

2014-08-15 Thread Le Tan
Add support for emulating Intel IOMMU according to the VT-d specification for the q35 chipset machine. Implement the logics for DMAR (DMA remapping) without PASID support. The emulation supports register-based invalidation and primary fault logging. Signed-off-by: Le Tan --- hw/i386/Makefile.obj

[Qemu-devel] [Bug 1062220] Re: qemu-system-arm crashed with SIGABRT in cpu_abort()

2014-08-15 Thread Apport retracing service
** Tags added: utopic -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1062220 Title: qemu-system-arm crashed with SIGABRT in cpu_abort() Status in QEMU: New Status in “qemu” package in Ubuntu: I

[Qemu-devel] [question] qemu-2.0.0 difference between download from http://wiki.qemu.org/Download and download http://git.qemu.org/qemu.git

2014-08-15 Thread Zhang Haoyu
Hi, I download one copy of qemu-2.0.0 from http://wiki.qemu.org/Download, and then download another copy of qemu-2.0.0 from http://git.qemu.org/qemu.git, I compared them, found that dtc, pixman, roms are missed in the latter. so If want to use qemu-2.0.1 to build my emulator, should I still add t

Re: [Qemu-devel] [PATCH 0/3] target-xtensa: fix loading uImage kernels on MMUv2 cores

2014-08-15 Thread Max Filippov
On Tue, Aug 12, 2014 at 8:22 AM, Max Filippov wrote: > Hi, > > this series fixes loading uImage kernels on MMUv2 xtensa cores. > > U-boot for xtensa always treats uImage load address as virtual address. > This is important when booting uImage on xtensa core with MMUv2, because > MMUv2 has fixed no

Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12

2014-08-15 Thread Eric Blake
On 08/15/2014 03:01 PM, Michael Roth wrote: >>> I tried to compile on Fedora 20, but had to backport this to get it to work: >>> >>> Luiz Capitulino >>> a49db98d fpu: softfloat: drop INLINE macro >>> >> >> ping > > Hmm, unfortunately I didn't see this until after 2.0.1 was tagged/pushed. My > und

Re: [Qemu-devel] vexpress-a9: coreboot is unable to push any data on stack

2014-08-15 Thread Peter Maydell
On 15 August 2014 19:02, Piotr Król wrote: > On Fri, Aug 15, 2014 at 05:10:04PM +0100, Peter Maydell wrote: >> For your stack issues, it looks like your code is trying to >> use the area which is the flash as the stack. Since flash >> isn't writeable, we ignore the writes and it's not very >> usef

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-15 Thread Hulin, Patrick - 0559 - MITLL
On Aug 15, 2014, at 4:48 PM, Paolo Bonzini wrote: > Il 13/08/2014 20:36, Hulin, Patrick - 0559 - MITLL ha scritto: >> Hi QEMU devs, >> >> QEMU 2.10 does not currently run Windows 7 64-bit without KVM. There >> have been a few threads about this over the past few years (such as >> https://bugs.la

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2014-08-15 Thread LocutusOfBorg
I didn't install a VM because: -I'm on ubuntu 14.04 on my laptop -I use pbuilder-dist (from ubuntu-dev-tools) armhf that uses qemu as underlying virtualization system. the fact is: why on my machine it doesn't show this error? possible solution: -because qemu+pbuilder-dist is not multithreaded?

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2014-08-15 Thread Serge Hallyn
Perhaps i don't understand what you are doing. My understanding was that a package is being built (in the buildds) under qemu. Qemu is failing due to tcg failure. We want to tes twhether a qemu patch fixes it. That's why I suggest installing the new qemu package on your host, using it to run a

Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12

2014-08-15 Thread Michael Roth
Quoting Eric Blake (2014-08-15 13:43:21) > On 08/07/2014 02:21 PM, Eric Blake wrote: > > On 08/06/2014 02:38 PM, Michael Roth wrote: > >> Hi everyone, > >> > >> The following new patches are queued for QEMU stable v2.0.1: > >> > >> https://github.com/mdroth/qemu/commits/stable-2.0-staging > >> >

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-15 Thread Paolo Bonzini
Il 13/08/2014 20:36, Hulin, Patrick - 0559 - MITLL ha scritto: > Hi QEMU devs, > > QEMU 2.10 does not currently run Windows 7 64-bit without KVM. There > have been a few threads about this over the past few years (such as > https://bugs.launchpad.net/qemu/+bug/921208 and > http://lists.gnu.org/arc

Re: [Qemu-devel] [V2 PATCH 7/8] target-ppc: Bug Fix: srawi

2014-08-15 Thread Richard Henderson
On 08/12/2014 03:45 AM, Tom Musta wrote: > For 64 bit implementations, the special case of a shift by zero > should result in the sign extension of the least significant 32 bits > of the source GPR (not a direct copy of the 64 bit source GPR). > > Example: > > R3 A6212433228F41DC > srawi 3,3,0 >

Re: [Qemu-devel] [V2 PATCH 4/8] target-ppc: Bug Fix: mullw

2014-08-15 Thread Richard Henderson
On 08/12/2014 03:45 AM, Tom Musta wrote: > +#else > tcg_gen_mul_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)], > cpu_gpr[rB(ctx->opcode)]); > tcg_gen_ext32s_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rD(ctx->opcode)]); > +#endif Note that the sign-extension can be d

Re: [Qemu-devel] [V2 PATCH 2/8] target-ppc: Bug Fix: rlwnm

2014-08-15 Thread Richard Henderson
On 08/12/2014 03:45 AM, Tom Musta wrote: > The rlwnm specification includes the ROTL32 operation, which is defined > to be a left rotation of two copies of the least significant 32 bits of > the source GPR. > > The current implementation is incorrect on 64-bit implementations in that > it rotates

Re: [Qemu-devel] [V2 PATCH 1/8] target-ppc: Bug Fix: rlwinm

2014-08-15 Thread Richard Henderson
On 08/12/2014 03:45 AM, Tom Musta wrote: > The rlwinm specification includes the ROTL32 operation, which is defined > to be a left rotation of two copies of the least significant 32 bits of > the source GPR. > > The current implementation is incorrect on 64-bit implementations in that > it rotates

Re: [Qemu-devel] [PULL 00/62] Block patches

2014-08-15 Thread Paolo Bonzini
Il 15/08/2014 15:10, Kevin Wolf ha scritto: > Am 15.08.2014 um 14:41 hat Peter Maydell geschrieben: >> On 8 August 2014 18:39, Kevin Wolf wrote: >>> The following changes since commit 69f87f713069f1f70f86cb65883f7d43e3aa21de: >>> >>> Merge remote-tracking branch >>> 'remotes/pmaydell/tags/pull-

[Qemu-devel] Using cache=writeback safely on qemu 1.4.0 and later

2014-08-15 Thread Andrew Martin
Hello, I am running several qemu-kvm VM servers on Ubuntu 12.04 with qemu-kvm 1.4.0. Most of the guests are also running Ubuntu 12.04. I am using qcow2 disk images with the virtio driver in almost all cases, and am storing the disks on two types of storage devices: * a shared NFS server mounted o

Re: [Qemu-devel] [PATCH 8/8] target-ppc: Bug Fix: srad

2014-08-15 Thread Richard Henderson
On 08/11/2014 09:23 AM, Tom Musta wrote: > Fix the check for carry in the srad helper to properly construct > the mask -- a "1ULL" must be used (instead of "1") in order to > get the desired result. > > Signed-off-by: Tom Musta > --- > target-ppc/int_helper.c |2 +- > 1 files changed, 1 inse

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-15 Thread Paolo Bonzini
Il 14/08/2014 11:39, Stefan Hajnoczi ha scritto: > That begs the question whether you should look at PCI passthrough > instead? Being able to use logical volumes, or to access multiple remote LUNs through a single FC card in the host is an obvious reason to avoid PCI passthrough. Paolo

Re: [Qemu-devel] [PATCH 6/8] target-ppc: Bug Fix: mulldo OV Detection

2014-08-15 Thread Richard Henderson
On 08/11/2014 09:23 AM, Tom Musta wrote: > Fix the code to properly detect overflow; the 128 bit signed > product must have all zeroes or all ones in the first 65 bits > otherwise OV should be set. > > Signed-off-by: Tom Musta > --- > target-ppc/int_helper.c | 14 -- > 1 files chan

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-15 Thread Paolo Bonzini
Il 14/08/2014 12:46, Kevin Wolf ha scritto: > So to finally reply with some numbers... I'm running fio tests based on > Ming's configuration on a loop-mounted tmpfs image using dataplane. I'm not sure tmpfs is a particularly useful comparison, since it doesn't support O_DIRECT. O_DIRECT over ramd

Re: [Qemu-devel] [PATCH 5/8] target-ppc: Bug Fix: mullwo

2014-08-15 Thread Richard Henderson
On 08/11/2014 09:23 AM, Tom Musta wrote: > tcg_gen_muls2_i32(t0, t1, t0, t1); > tcg_gen_ext_i32_tl(cpu_gpr[rD(ctx->opcode)], t0); > +#if defined(TARGET_PPC64) > +tcg_gen_ext_i32_tl(t2, t1); > +tcg_gen_deposit_i64(cpu_gpr[rD(ctx->opcode)], > +cpu_gpr[rD(ctx-

Re: [Qemu-devel] [PATCH 4/8] target-ppc: Bug Fix: mullw

2014-08-15 Thread Richard Henderson
On 08/11/2014 09:23 AM, Tom Musta wrote: > For 64-bit implementations, the mullw result is the 64 bit product > of the sign-extended least significant 32 bits of the source > registers. > > Fix the code to properly sign extend the source operands and produce > a 64 bit product. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 3/8] target-ppc: Bug Fix: rlwimi

2014-08-15 Thread Richard Henderson
On 08/11/2014 09:23 AM, Tom Musta wrote: > Also fix the special case of MB=31 and ME=0 to copy the entire contents > of the source GPR. Err, that's not what you did. > if (likely(sh == 0 && mb == 0 && me == 31)) { > +#if defined(TARGET_PPC64) > +tcg_gen_mov_i64(cpu_gpr[rA(ctx->opcode

Re: [Qemu-devel] [PATCH 2/8] target-ppc: Bug Fix: rlwnm

2014-08-15 Thread Richard Henderson
On 08/11/2014 09:23 AM, Tom Musta wrote: > +#if defined(TARGET_PPC64) > +tcg_gen_andi_tl(t0, t0, MASK(32, 63)); > +#endif Err. this is just simple zero-extension. > tcg_gen_mov_tl(cpu_gpr[rA(ctx->opcode)], t0); Why not combine with the mov as tcg_gen_ext32u_tl which will jus

Re: [Qemu-devel] [PATCH 1/8] target-ppc: Bug Fix: rlwinm

2014-08-15 Thread Richard Henderson
On 08/15/2014 08:34 AM, Richard Henderson wrote: > On 08/11/2014 09:23 AM, Tom Musta wrote: >> The rlwinm specification includes the ROTL32 operation, which is defined >> to be a left rotation of two copies of the least significant 32 bits of >> the source GPR. >> >> The current implementation is i

Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12

2014-08-15 Thread Eric Blake
On 08/07/2014 02:21 PM, Eric Blake wrote: > On 08/06/2014 02:38 PM, Michael Roth wrote: >> Hi everyone, >> >> The following new patches are queued for QEMU stable v2.0.1: >> >> https://github.com/mdroth/qemu/commits/stable-2.0-staging >> >> The release is planned for 2014-08-15: >> >> http://wi

Re: [Qemu-devel] [PATCH v2 1/2] QEMUSizedBuffer based QEMUFile

2014-08-15 Thread Eric Blake
On 08/07/2014 04:24 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This is based on Stefan and Joel's patch that creates a QEMUFile that goes > to a memory buffer; from: > > http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg05036.html > > Using the QEMUFile i

Re: [Qemu-devel] [PATCH 1/8] target-ppc: Bug Fix: rlwinm

2014-08-15 Thread Richard Henderson
On 08/11/2014 09:23 AM, Tom Musta wrote: > The rlwinm specification includes the ROTL32 operation, which is defined > to be a left rotation of two copies of the least significant 32 bits of > the source GPR. > > The current implementation is incorrect on 64-bit implementations in that > it rotates

Re: [Qemu-devel] [PATCH v6 02/10] monitor: fix access freed memory

2014-08-15 Thread Luiz Capitulino
On Thu, 14 Aug 2014 12:30:10 +0200 "Michael S. Tsirkin" wrote: > On Thu, Aug 14, 2014 at 03:29:13PM +0800, zhanghailiang wrote: > > The function monitor_fdset_dup_fd_find_remove() references member of > > 'mon_fdset' > > which may be freed in function monitor_fdset_cleanup() > > > > Reviewed-by

Re: [Qemu-devel] [PATCH v3 00/14] drop qapi nested structs

2014-08-15 Thread Luiz Capitulino
On Tue, 5 Aug 2014 19:14:19 -0600 Eric Blake wrote: > According to this email: > https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00708.html > we want to repurpose 'data': { 'name': {dict...} } in qapi files > for future use of designating default values of optional parameters. > But to

Re: [Qemu-devel] vexpress-a9: coreboot is unable to push any data on stack

2014-08-15 Thread Piotr Król
On Fri, Aug 15, 2014 at 05:10:04PM +0100, Peter Maydell wrote: > For your stack issues, it looks like your code is trying to > use the area which is the flash as the stack. Since flash > isn't writeable, we ignore the writes and it's not very > useful for stack. It looks like your code is assuming

Re: [Qemu-devel] [PULL 00/24] Linux-user updates

2014-08-15 Thread Peter Maydell
On 15 August 2014 12:01, wrote: > A usual set of improvements and bugfixes. The binfmt flag addition is an > ABI break so endusers need to update their binfmt registering scripts. Ugh, really? I didn't realize that when I saw that patch go past; I'd like to look at it in more detail before I app

Re: [Qemu-devel] [PULL 00/12] post-2.1 bugfixes

2014-08-15 Thread Peter Maydell
On 14 August 2014 17:08, Michael S. Tsirkin wrote: > The following changes since commit 2d591ce2aeebf9620ff527c7946844a3122afeec: > > Merge remote-tracking branch 'remotes/mdroth/qga-pull-2014-08-08' into > staging (2014-08-08 14:16:05 +0100) > > are available in the git repository at: > > gi

Re: [Qemu-devel] [PATCH for-2.2 v3 0/3] nbd: Adapt for dataplane

2014-08-15 Thread Stefan Hajnoczi
On Fri, Aug 15, 2014 at 03:31:48PM +0200, Max Reitz wrote: > On 15.08.2014 15:08, Kevin Wolf wrote: > >Am 20.06.2014 um 21:57 hat Max Reitz geschrieben: > >>For the NBD server to work with dataplane, it needs to correctly access > >>the exported BDS. It makes the most sense to run both in the same

[Qemu-devel] [PULL 54/55] image-fuzzer: Reduce number of generator functions in __init__

2014-08-15 Thread Stefan Hajnoczi
From: Maria Kustova Some issues can be found only when a fuzzed image has a partial structure, e.g. has L1/L2 tables but no refcount ones. Generation of an entirely defined image limits these cases. Now the Image constructor creates only a header and a backing file name (if any), other image elem

[Qemu-devel] [PULL 53/55] image-fuzzer: Add generators of L1/L2 tables

2014-08-15 Thread Stefan Hajnoczi
From: Maria Kustova Entries in L1/L2 entries are based on a portion of random guest clusters. L2 entries contain offsets to host image clusters filled with random data. Clusters for L1/L2 tables and guest data are selected randomly. Signed-off-by: Maria Kustova Signed-off-by: Stefan Hajnoczi -

[Qemu-devel] [PULL 52/55] image-fuzzer: Add fuzzing functions for L1/L2 table entries

2014-08-15 Thread Stefan Hajnoczi
From: Maria Kustova Signed-off-by: Maria Kustova Signed-off-by: Stefan Hajnoczi --- tests/image-fuzzer/qcow2/fuzz.py | 28 1 file changed, 28 insertions(+) diff --git a/tests/image-fuzzer/qcow2/fuzz.py b/tests/image-fuzzer/qcow2/fuzz.py index a53c84f..57527f9 1006

[Qemu-devel] [PULL 51/55] docs: Expand the list of supported image elements with L1/L2 tables

2014-08-15 Thread Stefan Hajnoczi
From: Maria Kustova Signed-off-by: Maria Kustova Signed-off-by: Stefan Hajnoczi --- docs/image-fuzzer.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/image-fuzzer.txt b/docs/image-fuzzer.txt index e73b182..0d0005d 100644 --- a/docs/image-fuzzer.txt +++ b/docs/ima

[Qemu-devel] [PULL 55/55] qcow2: fix new_blocks double-free in alloc_refcount_block()

2014-08-15 Thread Stefan Hajnoczi
Commit de82815db1c89da058b7fb941dab137d6d9ab738 ("qcow2: Handle failure for potentially large allocations") introduced a double-free of new_blocks in the alloc_refcount_block() error path. The qemu-iotests qcow2 026 test case was failing because qemu-io segfaulted. Make sure new_blocks is NULL af

[Qemu-devel] [PULL 48/55] image-fuzzer: Fuzzing functions for qcow2 images

2014-08-15 Thread Stefan Hajnoczi
From: Maria Kustova The fuzz submodule of the qcow2 image generator contains fuzzing functions for image fields. Each fuzzing function contains a list of constraints and a call of a helper function that randomly selects a fuzzed value satisfied to one of constraints. For now constraints include o

[Qemu-devel] [PULL 49/55] image-fuzzer: Generator of fuzzed qcow2 images

2014-08-15 Thread Stefan Hajnoczi
From: Maria Kustova The layout submodule of the qcow2 package creates a random valid image, randomly selects some amount of its fields, fuzzes them and write the fuzzed image to the file. Fuzzing process can be controlled by an external configuration. Reviewed-by: Stefan Hajnoczi Signed-off-by:

[Qemu-devel] [PULL 45/55] ide: only constrain read/write requests to drive size, not other types

2014-08-15 Thread Stefan Hajnoczi
From: Michael Tokarev Commit 58ac321135a introduced a check to ide dma processing which constrains all requests to drive size. However, apparently, some valid requests (like TRIM) does not fit in this constraint, and fails in 2.1. So check the range only for reads and writes. Cc: qemu-sta...@n

[Qemu-devel] [PULL 50/55] image-fuzzer: Public API for image-fuzzer/runner/runner.py

2014-08-15 Thread Stefan Hajnoczi
From: Maria Kustova __init__.py provides the public API required by the test runner Reviewed-by: Stefan Hajnoczi Signed-off-by: Maria Kustova Signed-off-by: Stefan Hajnoczi --- tests/image-fuzzer/qcow2/__init__.py | 1 + 1 file changed, 1 insertion(+) create mode 100644 tests/image-fuzzer/q

[Qemu-devel] [PULL 47/55] image-fuzzer: Tool for fuzz tests execution

2014-08-15 Thread Stefan Hajnoczi
From: Maria Kustova The purpose of the test runner is to prepare the test environment (e.g. create a work directory, a test image, etc), execute a program under test with parameters, indicate a test failure if the program was killed during the test execution and collect core dumps, logs and other

[Qemu-devel] [PULL 42/55] libqos: Correct mask to align size to PAGE_SIZE in malloc-pc

2014-08-15 Thread Stefan Hajnoczi
From: Marc Marí Reviewed-by: John Snow Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Signed-off-by: Marc Marí Signed-off-by: Stefan Hajnoczi --- tests/libqos/malloc-pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc-pc.c b/tests/libqos/m

[Qemu-devel] [PULL 39/55] qemu-options: add missing -drive discard option to cmdline help

2014-08-15 Thread Stefan Hajnoczi
From: Peter Lieven Signed-off-by: Peter Lieven Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 96516c1..44e3be3 100644 --- a/qemu-options.hx +++ b/qemu-option

[Qemu-devel] [PULL 46/55] docs: Specification for the image fuzzer

2014-08-15 Thread Stefan Hajnoczi
From: Maria Kustova 'Overall fuzzer requirements' chapter contains the current product vision and features done and to be done. This chapter is still in progress. Signed-off-by: Maria Kustova Signed-off-by: Stefan Hajnoczi --- docs/image-fuzzer.txt | 239 ++

[Qemu-devel] [PULL 44/55] virtio-blk: Correct bug in support for flexible descriptor layout

2014-08-15 Thread Stefan Hajnoczi
From: Marc Marí Without this correction, only a three descriptor layout is accepted, and requests with just two descriptors are not completed and no error message is displayed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Marc Marí Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c |

[Qemu-devel] [PULL 34/55] dataplane: stop trying on notifier error

2014-08-15 Thread Stefan Hajnoczi
From: Cornelia Huck If we fail to set up guest or host notifiers, there's no use trying again every time the guest kicks, so disable dataplane in that case. Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 11 ++

[Qemu-devel] [PULL 30/55] qemu-char: using qemu_set_nonblock() instead of fcntl(O_NONBLOCK)

2014-08-15 Thread Stefan Hajnoczi
From: Gonglei Technically, fcntl(soc, F_SETFL, O_NONBLOCK) is incorrect since it clobbers all other file flags. We can use F_GETFL to get the current flags, set or clear the O_NONBLOCK flag, then use F_SETFL to set the flags. Using the qemu_set_nonblock() wrapper. Signed-off-by: Wangxin Signed

[Qemu-devel] [PULL 38/55] parallels: 2TB+ parallels images support

2014-08-15 Thread Stefan Hajnoczi
From: "Denis V. Lunev" Parallels has released in the recent updates of Parallels Server 5/6 new addition to his image format. Images with signature WithouFreSpacExt have offsets in the catalog coded not as offsets in sectors (multiple of 512 bytes) but offsets coded in blocks (i.e. header->tracks

[Qemu-devel] [PULL 27/55] cmd646: switch cmd646_update_irq() to accept PCIDevice instead of PCIIDEState

2014-08-15 Thread Stefan Hajnoczi
From: Mark Cave-Ayland This is in preparation for adding configuration space accessors which accept PCIDevice as a parameter. Signed-off-by: Mark Cave-Ayland Signed-off-by: Stefan Hajnoczi --- hw/ide/cmd646.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/ide/

[Qemu-devel] [PULL 37/55] parallels: split check for parallels format in parallels_open

2014-08-15 Thread Stefan Hajnoczi
From: "Denis V. Lunev" and rework error path a bit. There is no difference at the moment, but the code will be definitely shorter when additional processing will be required for WithouFreSpacExt Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi Reviewed-by: Jeff

[Qemu-devel] [PULL 43/55] libqos: Change free function called in malloc

2014-08-15 Thread Stefan Hajnoczi
From: Marc Marí Reviewed-by: John Snow Reviewed-by: Stefan Hajnoczi Signed-off-by: Marc Marí Signed-off-by: Stefan Hajnoczi --- tests/libqos/malloc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/malloc.h b/tests/libqos/malloc.h index 46f6000..5565381 10064

[Qemu-devel] [PULL 35/55] parallels: extend parallels format header with actual data values

2014-08-15 Thread Stefan Hajnoczi
From: "Denis V. Lunev" Parallels image format has several additional fields inside: - nb_sectors is actually 64 bit wide. Upper 32bits are not used for images with signature "WithoutFreeSpace" and must be explicitly zeroed according to Parallels. They will be used for images with signature

[Qemu-devel] [PULL 28/55] cmd646: allow MRDMODE interrupt status bits clearing from PCI config space

2014-08-15 Thread Stefan Hajnoczi
From: Mark Cave-Ayland Make sure that we also update the normal DMA interrupt status bits at the same time, and alter the IRQ if being cleared accordingly. Signed-off-by: Mark Cave-Ayland Signed-off-by: Stefan Hajnoczi --- hw/ide/cmd646.c | 32 ++-- 1 file changed,

[Qemu-devel] [PULL 33/55] dataplane: fail notifier setting gracefully

2014-08-15 Thread Stefan Hajnoczi
From: Cornelia Huck The dataplane code is currently doing a hard exit if it fails to set up either guest or host notifiers. In practice, this may mean that a guest suddenly dies after a dataplane device failed to come up (e.g., when a file descriptor limit is hit for tne nth device). Let's just

[Qemu-devel] [PULL 41/55] libqtest: add QTEST_LOG for debugging qtest testcases

2014-08-15 Thread Stefan Hajnoczi
From: Marc Marí Signed-off-by: Paolo Bonzini Signed-off-by: Marc Marí Signed-off-by: Stefan Hajnoczi --- tests/libqtest.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 0bf17aa..ed55686 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@

[Qemu-devel] [PULL 24/55] qtest/ide: Fix small memory leak

2014-08-15 Thread Stefan Hajnoczi
From: John Snow For libqos debugging purposes, it's nice to be able to assert that tests and associated libraries have no memory leaks. To that end, free up the trivial cmdline leak. The remaining leaks caused by pc_alloc_init are fixed instead by my first-fit pc_alloc implementation already on

[Qemu-devel] [PULL 32/55] dataplane: print why starting failed

2014-08-15 Thread Stefan Hajnoczi
From: Cornelia Huck Setting up guest or host notifiers may fail, but the user will have no idea why: Let's print the error returned by the callback. Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 13 --

[Qemu-devel] [PULL 40/55] ide: Fix segfault when flushing a device that doesn't exist

2014-08-15 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c| 4 +++- tests/ide-test.c | 14 ++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index bdb0a80..82dd4af 100644 --- a/hw/ide/core.c +++ b/h

[Qemu-devel] [PULL 31/55] channel-posix: using qemu_set_nonblock() instead of fcntl(O_NONBLOCK)

2014-08-15 Thread Stefan Hajnoczi
From: Gonglei Technically, fcntl(soc, F_SETFL, O_NONBLOCK) is incorrect since it clobbers all other file flags. We can use F_GETFL to get the current flags, set or clear the O_NONBLOCK flag, then use F_SETFL to set the flags. Using the qemu_set_nonblock() wrapper. Signed-off-by: Gonglei Signed

[Qemu-devel] [PULL 22/55] libqos: Fixes a small memory leak.

2014-08-15 Thread Stefan Hajnoczi
From: John Snow Allow users the chance to clean up the QPCIBusPC structure by adding a small cleanup routine. Helps clear up small memory leaks during setup/teardown, to allow for cleaner debug output messages. Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- tests/libqos/pci-pc.c

[Qemu-devel] [PULL 23/55] libqos: allow qpci_iomap to return BAR mapping size

2014-08-15 Thread Stefan Hajnoczi
From: John Snow This patch allows qpci_iomap to return the size of the BAR mapping that it created, to allow driver applications (e.g, ahci-test) to make determinations about the suitability or the mapping size, or in the specific case of AHCI, how many ports are supported by the HBA. Signed-off

[Qemu-devel] [PULL 25/55] cmd646: add constants for CNTRL register access

2014-08-15 Thread Stefan Hajnoczi
From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Stefan Hajnoczi --- hw/ide/cmd646.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index a8e35fe..d8395ef 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -3

[Qemu-devel] [PULL 29/55] cmd646: synchronise UDMA interrupt status with DMA interrupt status

2014-08-15 Thread Stefan Hajnoczi
From: Mark Cave-Ayland Make sure that both registers are synchronised when being accessed through PCI configuration space. Signed-off-by: Mark Cave-Ayland Signed-off-by: Stefan Hajnoczi --- hw/ide/cmd646.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/ide/cm

[Qemu-devel] [PULL 20/55] libqos: Correct memory leak

2014-08-15 Thread Stefan Hajnoczi
From: John Snow Fix a small memory leak inside of libqos, in the pc_alloc_init routine. Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- tests/libqos/malloc-pc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/libqos/malloc-pc.c b/tests/libqos/malloc-pc.c index db1496c

[Qemu-devel] [PULL 21/55] libqtest: Correct small memory leak.

2014-08-15 Thread Stefan Hajnoczi
From: John Snow Fixes a small memory leak inside of libqtest. After we produce a test path and glib copies the string for itself, we should clean up our temporary copy. Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --g

[Qemu-devel] [PULL 26/55] cmd646: synchronise DMA interrupt status with UDMA interrupt status

2014-08-15 Thread Stefan Hajnoczi
From: Mark Cave-Ayland Make sure that the standard DMA interrupt status bits reflect any changes made to the UDMA interrupt status bits. The CMD646U2 datasheet claims that these bits are equivalent, and they must be synchronised for guests that manipulate both registers. Signed-off-by: Mark Cave

[Qemu-devel] [PULL 36/55] parallels: replace tabs with spaces in block/parallels.c

2014-08-15 Thread Stefan Hajnoczi
From: "Denis V. Lunev" Signed-off-by: Denis V. Lunev Reviewed-by: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi --- block/parallels.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 59cf

[Qemu-devel] [PULL 19/55] qtest: Adding qtest_memset and qmemset.

2014-08-15 Thread Stefan Hajnoczi
From: John Snow Currently, libqtest allows for memread and memwrite, but does not offer a simple way to zero out regions of memory. This patch adds a simple function to do so. Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- tests/libqtest.c | 12 tests/libqtest.h | 24

[Qemu-devel] [PULL 15/55] ide: stop PIO transfer on errors

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini This will provide a hook for sending the result of the command via the FIS receive area. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/ide/

[Qemu-devel] [PULL 17/55] ahci: construct PIO Setup FIS for PIO commands

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini PIO commands should put a PIO Setup FIS in the receive area when data transfer ends. Currently QEMU does not do this and only places the D2H FIS at the end of the operation. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/a

[Qemu-devel] [PULL 10/55] ide: remove wrong setting of BM_STATUS_INT

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Similar to the case removed in commit 69c38b8 (ide/core: Remove explicit setting of BM_STATUS_INT, 2011-05-19), the only remaining use of add_status(..., BM_STATUS_INT) is for short PRDs. The flag should not be raised in this case. Signed-off-by: Paolo Bonzini Signed-off-by

[Qemu-devel] [PULL 12/55] ide: move BM_STATUS bits to pci.[ch]

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini They are not used by AHCI, and should not be even available there. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/internal.h | 11 --- hw/ide/pci.c | 4 hw/ide/pci.h | 7 +++ 3 files changed, 11

[Qemu-devel] [PULL 18/55] q35: Enable the ioapic device to be seen by qtest.

2014-08-15 Thread Stefan Hajnoczi
From: John Snow Currently, the ioapic device can not be found in a qtest environment when requesting "irq_interrupt_in ioapic" via the qtest socket. By mirroring how the ioapic is added in i44ofx (hw/i440/pc_piix.c), as a child of "q35," the device is able to be seen by qtest. Signed-off-by: Jo

[Qemu-devel] [PULL 14/55] ahci: remove duplicate PORT_IRQ_* constants

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini These are defined twice, just use one set consistently. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/ahci.c | 6 +++--- hw/ide/ahci.h | 21 - 2 files changed, 3 insertions(+), 24 deletions(-) diff --

[Qemu-devel] [PULL 11/55] ide: fold add_status callback into set_inactive

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini It is now called only after the set_inactive callback. Put the two together. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/ahci.c | 9 - hw/ide/atapi.c| 2 +- hw/ide/core.c | 12 hw/ide/

[Qemu-devel] [PULL 07/55] ide: simplify async_cmd_done callbacks

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Drop the unused return value. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/ahci.c | 4 +--- hw/ide/internal.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index

[Qemu-devel] [PULL 08/55] ide: simplify start_transfer callbacks

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Drop the unused return value and make the callback optional. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/ahci.c | 4 +--- hw/ide/core.c | 10 +++--- hw/ide/internal.h | 3 +-- hw/ide/macio.c| 6 --

[Qemu-devel] [PULL 09/55] ide: wrap start_dma callback

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Make it optional and prepare for the next patches. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/atapi.c| 6 ++ hw/ide/core.c | 15 --- hw/ide/internal.h | 1 + 3 files changed, 11 insertions(+),

[Qemu-devel] [PULL 16/55] ide: make all commands go through cmd_done

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini AHCI has code to fill in the D2H FIS trigger the IRQ all over the place. Centralize this in a single cmd_done callback by generalizing the existing async_cmd_done callback. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/ahc

[Qemu-devel] [PULL 13/55] ide: move retry constants out of BM_STATUS_* namespace

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 20 ++-- hw/ide/internal.h | 12 ++-- hw/ide/pci.c | 14 +++--- 3 files changed, 23 insertions(+), 23 deletions(-) diff --git

[Qemu-devel] [PULL 05/55] ide: simplify reset callbacks

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Drop the unused return value and make the callback optional. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/ahci.c | 6 -- hw/ide/core.c | 5 +++-- hw/ide/internal.h | 3 ++- hw/ide/macio.c| 1 - hw/ide/pci.

[Qemu-devel] [PULL 02/55] libqtest: add QTEST_LOG for debugging qtest testcases

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- tests/libqtest.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 98e8f4b..4a75cd3 100644 --- a/tests/libqtest.c +++

[Qemu-devel] [PULL 06/55] ide: simplify set_inactive callbacks

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Drop the unused return value and make the callback optional. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/ahci.c | 6 -- hw/ide/core.c | 5 +++-- hw/ide/internal.h | 2 +- hw/ide/macio.c| 1 - hw/ide/pci.c

[Qemu-devel] [PULL 04/55] ide: stash aiocb for flushes

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini This ensures that operations are completed after a reset Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index db191

[Qemu-devel] [PULL 03/55] ide-test: add test for werror=stop

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- tests/ide-test.c | 81 1 file changed, 81 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index 4a0d97f..151ef3

[Qemu-devel] [PULL 01/55] blkdebug: report errors on flush too

2014-08-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Signed-off-by: Stefan Hajnoczi --- block/blkdebug.c | 20 1 file changed, 20 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index f51407d..1586ed9 100644 --- a/block/blkdebug.c +++

[Qemu-devel] [PULL 00/55] Block patches

2014-08-15 Thread Stefan Hajnoczi
The following changes since commit 5c6b3c50cca2106e5fbcbc6efa94c2f8b9d29fd8: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2014-08-15 16:37:17 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request

  1   2   3   4   >