Hi,
> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex command
>
> On Fri, Jul 25, 2014 at 02:52:50PM +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Adds "set-bootindex id=xx,bootindex=xx,suffix=xx" QMP command.
> >
> > Example QMP command:
> > -> { "execute": "se
Best regards,
-Gonglei
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Friday, August 01, 2014 10:46 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; chenliang (T); Huangweidong (C);
> m...@redhat.com; a...@ozlabs.ru; hu...@cn.fujitsu.com;
> arm.
>Hi Zhang,
>
>No I haven't seen such problem
>Which kernel version are you running?
Host kernel: RHEL7-RC1(linux-3.10.0).
>Does it include the latest lazy eli changes?
>
lazy eli or lazy eoi?
How to confirm whether lazy eli has been included?
>Btw, hv_spinlocks=0xfff is a pretty huge value.
>
Hi,
> > >
> > > > +del_boot_device_path(dev);
> > >
> > > You can call this from device_finalize() instead of placing it into each
> > > individual device.
> > >
> > Maybe put this call in device_finalize is not a good idea.
> > I have three reasons:
> >
> > 1. the device's some memory have be
On 2014/7/31 20:09, Tiejun Chen wrote:
v3:
* Drop patch #4
* Add one patch #1 from Michael
* Rebase
v2:
* Fix some coding style
* New patch to separate i440fx_init
* Just add prefix with XEN_IGD_PASSTHROUGH/xen_igd_passthrough
* Based on patch #2 to regenerate
* Unify prefix with XEN_IGD_PASST
Obsoleted by automatic object_property_add arrayification.
Reviewed-by: Paolo Bonzini
Signed-off-by: Peter Crosthwaite
---
memory.c | 30 +-
1 file changed, 5 insertions(+), 25 deletions(-)
diff --git a/memory.c b/memory.c
index 64d7176..5272bf9 100644
--- a/memory
Hi Zhang,
No I haven't seen such problem
Which kernel version are you running?
Does it include the latest lazy eli changes?
Btw, hv_spinlocks=0xfff is a pretty huge value.
Best regards,
Vadim.
- Original Message -
From: "Zhang Haoyu"
To: "Vadim Rozenfeld"
Cc: "Jidong Xiao" , "qe
If "[*]" is given as the last part of a QOM property name, treat that
as an array property. The added property is given the first available
name, replacing the * with a decimal number counting from 0.
First add with name "foo[*]" will be "foo[0]". Second "foo[1]" and so
on.
Signed-off-by: Peter C
On Fri, Aug 01, 2014 at 03:32:59PM +0100, Peter Maydell wrote:
> On 17 June 2014 09:45, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Acked-by: Greg Bellows
> > Signed-off-by: Edgar E. Iglesias
> > ---
> > cpu-exec.c | 12
> > target-arm/cpu.c
On 06/03/2014 09:42 PM, Peter Maydell wrote:
> On 3 June 2014 12:38, Alexey Kardashevskiy wrote:
>> On 06/03/2014 07:45 PM, Peter Maydell wrote:
>>> On 3 June 2014 04:52, Alexey Kardashevskiy wrote:
Is there anything I can do to help with this? Chase someone down? :)
>>>
>>> Confirming that
Public bug reported:
Hello,
I would like to request that support for OpenGL and 3D acceleration be added to
QEMU. I am sure it has been discussed before, but at the dawn of a new century
there are a number of possible solutions and I haven't seen anything
implemented into upstream.
Options -
the memdev_list in hmp_info_memdev() is never freed.
so we use existent method qapi_free_MemdevList() to free it.
and also we can use qapi_free_MemdevList() to replace list loops
to clean up the memdev list in error path.
Signed-off-by: Chen Fan
---
hmp.c | 2 ++
numa.c | 9 ++---
2 files c
when using valgrind to test the command "query memdev", I had
found some memory leaks. the test result:
==13802== 4 bytes in 1 blocks are definitely lost in loss record 125 of 8,508
==13802==at 0x4A08934: malloc (vg_replace_malloc.c:291)
==13802==by 0x4A08AA8: realloc (vg_replace_malloc.c:
string_output_get_string() uses g_string_free(str, false) to
transfer the 'str' pointer to callers and never free it.
Signed-off-by: Chen Fan
---
hmp.c| 6 --
qom/object.c | 12 ++--
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/hmp.c b/hmp.c
index 4d1838e.
Signed-off-by: Chen Fan
Reviewed-by: Peter Crosthwaite
---
numa.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/numa.c b/numa.c
index 7bf7834..a2b4bca 100644
--- a/numa.c
+++ b/numa.c
@@ -318,10 +318,11 @@ void memory_region_allocate_system_memory(MemoryRegion
*mr, Ob
On Fri, Aug 01, 2014 at 03:27:44PM +0100, Peter Maydell wrote:
> On 17 June 2014 09:45, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
>
> > --- a/target-arm/helper.c
> > +++ b/target-arm/helper.c
> > @@ -3312,6 +3312,19 @@ unsigned int arm_excp_target_el(CPUState *cs,
> > unsigned int
On Fri, Aug 01, 2014 at 03:21:08PM +0100, Peter Maydell wrote:
> On 17 June 2014 09:45, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Signed-off-by: Edgar E. Iglesias
> > ---
> > target-arm/cpu.h | 1 +
> > target-arm/helper-a64.c| 1 +
> > target-arm/helper.c
On Fri, Aug 01, 2014 at 02:56:29PM +0100, Peter Maydell wrote:
> On 17 June 2014 09:45, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Not all exception types update both FAR and ESR.
> >
> > Reviewed-by: Alex Bennée
> > Reviewed-by: Greg Bellows
> > Signed-off-by: Edgar E. Igle
On Mon, Aug 04, 2014 at 01:48:10PM +1000, Edgar E. Iglesias wrote:
> On Fri, Aug 01, 2014 at 02:29:28PM +0100, Peter Maydell wrote:
> > On 17 June 2014 09:45, Edgar E. Iglesias wrote:
> > > From: "Edgar E. Iglesias"
> > >
> > > Signed-off-by: Edgar E. Iglesias
> >
> > > diff --git a/target-arm/
On Fri, Aug 01, 2014 at 02:29:28PM +0100, Peter Maydell wrote:
> On 17 June 2014 09:45, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Signed-off-by: Edgar E. Iglesias
>
> > diff --git a/target-arm/helper.c b/target-arm/helper.c
> > index 7170086..b04fb5d 100644
> > --- a/target
On Fri, 2014-08-01 at 23:26 +1000, Peter Crosthwaite wrote:
> On Fri, Aug 1, 2014 at 8:22 PM, Chen Fan wrote:
> > string_output_get_string() always return the data the sov->string
>
> "returns the data sov->string points to and never frees it"
>
> Although "sov" is a little out of context howev
Hi, Vadim
I start a vm(windows server 2008 64bit) with below qemu command, get stuck with
black screen during boot stage,
no error report by qemu and kvm hypervisor, but if I remove the item
"hv_vapic", then start and run the VM successfully.
/var/run/qemu-server/5195516385344.pid -daemonize -
To indicate the IRQs are initially disconnected.
Signed-off-by: Peter Crosthwaite
---
hw/intc/openpic.c | 2 +-
hw/ppc/e500.c | 2 +-
hw/ppc/mac_newworld.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c
index 028529e..7d1
Re-implement the Sysbus GPIOs to use the existing TYPE_DEVICE
GPIO named framework. A constant string name is chosen to avoid
conflicts with existing unnamed GPIOs.
This unifies GPIOs are IRQs for sysbus devices and allows removal
of all Sysbus state for GPIOs.
Any existing and future-added funct
Previously this was restricted to a single call per-dev/per-name. With
the conversion of the GPIO output state to QOM the implementation can
now handle repeated calls. Remove the restriction.
Signed-off-by: Peter Crosthwaite
---
hw/core/qdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletion
To properly indicate they are unconnected.
Signed-off-by: Peter Crosthwaite
---
hw/ssi/xilinx_spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ssi/xilinx_spi.c b/hw/ssi/xilinx_spi.c
index 207f47a..620573c 100644
--- a/hw/ssi/xilinx_spi.c
+++ b/hw/ssi/xilinx_spi.c
@@
On Fri, Aug 01, 2014 at 02:51:44PM +0100, Peter Maydell wrote:
> On 17 June 2014 09:45, Edgar E. Iglesias wrote:
> >
> > +static inline bool arm_excp_unmasked(CPUState *cs, unsigned int excp_idx)
> > +{
> > +CPUARMState *env = cs->env_ptr;
> > +
> > +switch (excp_idx) {
> > +case EXCP_
All users of GPIO outputs are fully QOMified, using QOM properties to
access the GPIO data. Delete.
Signed-off-by: Peter Crosthwaite
---
hw/core/qdev.c | 1 -
include/hw/qdev-core.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 4cbf773..77b0b
Allows a container to take ownership of GPIOs in a contained
device and automatically connect them as GPIOs to the container.
This prepares for deprecation of the SYSBUS IRQ functionality, which
has this feature. We push it up to the device level instead of sysbus
level. There's nothing sysbus spe
To replace the old qemu_irq intercept API (which had users reaching
into qdev private state for IRQs).
Signed-off-by: Peter Crosthwaite
---
hw/core/qdev.c | 25 +
include/hw/qdev-core.h | 2 ++
2 files changed, 27 insertions(+)
diff --git a/hw/core/qdev.c b/hw/
No more users left and obsoleted by qdev_intercept_gpio_out.
Signed-off-by: Peter Crosthwaite
---
hw/core/irq.c| 6 --
include/hw/irq.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/hw/core/irq.c b/hw/core/irq.c
index 7d6318a..fef9cc2 100644
--- a/hw/core/irq.c
+++ b/hw/core/irq.
Change the qtest intercept handler to accept just the individual IRQ
being intercepted as opaque. n is still expected to be correctly set
as for the original intercepted irq. qemu_intercept_irq_in is updated
accordingly.
Then covert the qemu_irq_intercept_out call to use qdev intercept
version. Th
Rather than an abort(). This allows callers to decide whether parenting
an already-parented object is a fatal error condition.
Useful for providing a default value for an object's parent in the case
where you want to set one iff it doesn't already have one.
Signed-off-by: Peter Crosthwaite
---
Re-implement as a link setter. This should allow the QOM framework to
keep track of ref counts properly etc.
We need to add a default parent for the connecting input incase it's
coming from a non-qdev source. We simply parent the IRQ to the machine
in this case.
Signed-off-by: Peter Crosthwaite
Create a valid qobject even if the input string is null.
qstring->string will be NULL and length will be 0.
This prepares support for clearing of QOM Link properties
where NULL canonical path string will be passes through
this API.
Signed-off-by: Peter Crosthwaite
---
qobject/qstring.c | 12 ++
By passing in NULL to object_property_set_link.
The lead user of this is the QDEV GPIO framework which will implement
GPIO disconnects via an "unlink".
Signed-off-by: Peter Crosthwaite
---
qom/object.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qom/object.c b/qom/o
To the device that contains them. This will allow for referencing
a GPIO input from it's canonical path (exciting for dynamic machine
generation!)
Signed-off-by: Peter Crosthwaite
---
hw/core/qdev.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
ind
Within the object that contains the GPIO output. This allows for
connecting GPIO outputs via setting of a Link property.
Signed-off-by: Peter Crosthwaite
---
hw/core/qdev.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 35c266a..5f55709 10
Only allow a GPIO name to be one or the other. Inputs and outputs are
functionally different and should be in different namespaces. Prepares
support for the QOMification of IRQs as Links or Child objects.
The alternative is to munge names .e.g. with "-in" or "-out" suffixes
when giving QOM names.
Hi All,
So phase one was the QOMification of qemu_irq. This is the next step.
We start to setup GPIOs as proper QOM objects. Inputs are child objects
of their device. Outputs are settable Links and connection is made
via proper setting of a QOM link.
We then cleanup Sysbus to simply re-use device
On Fri, 2014-08-01 at 23:38 +1000, Peter Crosthwaite wrote:
> On Fri, Aug 1, 2014 at 8:22 PM, Chen Fan wrote:
> > Signed-off-by: Chen Fan
> > ---
> > hmp.c | 9 ++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/hmp.c b/hmp.c
> > index 2414cc7..0b1c830 100644
> >
On Fri, 2014-08-01 at 23:26 +1000, Peter Crosthwaite wrote:
> On Fri, Aug 1, 2014 at 8:22 PM, Chen Fan wrote:
> > string_output_get_string() always return the data the sov->string
>
> "returns the data sov->string points to and never frees it"
>
> Although "sov" is a little out of context howev
Hi,
> > Yoda conditions lack readability, and QEMU has a
> > strict compiler configuration for checking a common
> > mistake like "if (dev = NULL)". Make it a written rule.
> >
> > Signed-off-by: Gonglei
> > ---
> > CODING_STYLE | 14 ++
> > 1 file changed, 14 insertions(+)
> >
> > d
On Sun, Aug 3, 2014 at 1:45 AM, Richard W.M. Jones wrote:
> On aarch64 it is the bootloader's job to uncompress the kernel. UEFI
> and u-boot bootloaders do this automatically when the kernel is
> gzip-compressed.
>
> However the qemu -kernel option does not do this. The following
> command does
On 3 August 2014 15:21, Peter Maydell wrote:
> On 3 August 2014 09:53, Adam Lackorzynski wrote:
>> Hi,
>>
>> the following three patches address the behavior of the GICD_ICFGR register
>> in the ARM GIC.
>>
>> Adam Lackorzynski (3):
>> arm_gic: Fix read of GICD_ICFGR
>> arm_gic: SGIs for GICD
comments below
On 08/03/14 17:28, Chen Gang wrote:
> In dump_init(), when failure occurs, need notice about 'fd' and memory
> mapping. So call dump_cleanup() for it (need let all initializations at
> front).
>
> Also simplify dump_cleanup(): remove redundant 'ret' and redundant 'fd'
> checking.
>
In dump_init(), when failure occurs, need notice about 'fd' and memory
mapping. So call dump_cleanup() for it (need let all initializations at
front).
Also simplify dump_cleanup(): remove redundant 'ret' and redundant 'fd'
checking.
Signed-off-by: Chen Gang
---
dump.c | 18 +-
1
On Thu, 2014-07-24 at 07:24 +0800, Le Tan wrote:
> Hi Stefan,
>
> 2014-07-24 4:29 GMT+08:00 Stefan Weil :
> > Am 22.07.2014 17:47, schrieb Le Tan:
> >> Add support for emulating Intel IOMMU according to the VT-d specification
> >> for
> >> the q35 chipset machine. Implement the logic for DMAR (DM
With security_model=mapped-xattr, we encode the uid,gid and other file
attributes as extended attributes of the file. We save them under
user.virtfs.* namespace.
Use little-endian encoding for on-disk values. This enables us to export
the same directory from both little-endian and big-endian hosts
On 3 August 2014 09:53, Adam Lackorzynski wrote:
> Hi,
>
> the following three patches address the behavior of the GICD_ICFGR register
> in the ARM GIC.
>
> Adam Lackorzynski (3):
> arm_gic: Fix read of GICD_ICFGR
> arm_gic: SGIs for GICD_ICFGR are WI
> arm_gic: GICD_ICFGR: Do not force edge
On 3 August 2014 02:17, Peter Crosthwaite wrote:
> Note that many of the existing call this with stderr as FP argument
> which in theory should be change to something that backs onto
> qemu_log. I suspect the file handle in this case will be NULL when
> logging is disabled and this patch avoid hav
On 3 August 2014 00:45, Erik de Castro Lopo wrote:
> Signed-off-by: Erik de Castro Lopo
> ---
> linux-user/syscall.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a50229d..5f22b37 100644
> --- a/linux-user/syscall.c
> +++ b/linux-use
Hi,
the following three patches address the behavior of the GICD_ICFGR register
in the ARM GIC.
Adam Lackorzynski (3):
arm_gic: Fix read of GICD_ICFGR
arm_gic: SGIs for GICD_ICFGR are WI
arm_gic: GICD_ICFGR: Do not force edge-triggered PPIs
hw/intc/arm_gic.c | 15 ---
1 file c
Using GICD_ICFGR for PPIs forces PPIs to edge-triggered mode, although they
have been initialised to level-triggered. This affects all interrupts
covered by the write access. Change the handling of PPIs to not force a
specific mode. It is implementation defined whether setting the mode of PPIs
is s
Writes to SGIs for GICD_ICFGR register must be ignored.
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index d2b1aaf..cd6e6ea 100644
--- a/hw/intc/arm_gic.c
+++ b/hw/intc
The GICD_ICFGR register covers 4 interrupts per byte.
Signed-off-by: Adam Lackorzynski
---
hw/intc/arm_gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index 1532ef9..d2b1aaf 100644
--- a/hw/intc/arm_gic.c
+++ b/hw/intc/arm_gic.c
@@
56 matches
Mail list logo
