On Sun, Aug 3, 2014 at 11:14 AM, Peter Crosthwaite
wrote:
> On Sat, Aug 2, 2014 at 11:26 PM, Michael Tokarev wrote:
>> 31.07.2014 04:31, Peter Crosthwaite wrote:
>>> To avoid callsites with optional output having to NULL guard.
>>
>> Isn't it a bit backwards? If we don't need output, maybe we sh
Sorry premature send (I guess I just discovered a new keyboard shortcut!)
On Sun, Aug 3, 2014 at 11:14 AM, Peter Crosthwaite
wrote:
> On Sat, Aug 2, 2014 at 11:26 PM, Michael Tokarev wrote:
>> 31.07.2014 04:31, Peter Crosthwaite wrote:
>>> To avoid callsites with optional output having to NULL g
On Sat, Aug 2, 2014 at 11:26 PM, Michael Tokarev wrote:
> 31.07.2014 04:31, Peter Crosthwaite wrote:
>> To avoid callsites with optional output having to NULL guard.
>
> Isn't it a bit backwards? If we don't need output, maybe we should
> not call hexdump in the first place?
>
Well my thinking i
On 08/02/2014 09:35 PM, Michael Tokarev wrote:
> 06.07.2014 12:43, Chen Gang wrote:
>> getchar() is a standard c library function which may return with failure
>> (e.g. -1), so like another platforms, also need check it under WIN32.
>
> Applied to -trivial queue, with a slight modification:
>
I forgot to mention one of the popular crashes:
Assertion failed: (len <= 64), function tcg_gen_deposit_i64, file
/var/tmp/pkg/usr/ports/emulators/qemu-devel/work/qemu-2.0.0/tcg/tcg-op.h, line
2206.
(This corresponds to qemu 2.1.0)
Note that segfaults also happened in the recent past. Not sur
Signed-off-by: Erik de Castro Lopo
---
linux-user/syscall.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a50229d..5f22b37 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -9432,6 +9432,7 @@ abi_long do_syscall(void *cpu_env,
On 3 August 2014 00:21, Erik de Castro Lopo wrote:
> Peter Maydell wrote:
>
>> Amend it to what? The current code looks fine to me,
>> so I'm not sure what bug you're trying to fix here.
>
> There is still a missing call to unlock_user_struct() inside
> the "if (arg2)" block. Is that not worth fix
Peter Maydell wrote:
> Amend it to what? The current code looks fine to me,
> so I'm not sure what bug you're trying to fix here.
There is still a missing call to unlock_user_struct() inside
the "if (arg2)" block. Is that not worth fixing?
Erik
--
---
On 2 August 2014 23:48, Erik de Castro Lopo wrote:
> Peter Maydell wrote:
>
>> Doesn't this turn a timer_create(clkid, NULL, phtimer) into a
>> timer_create(clkid, something-not-NULL, phtimer) ? That
>> doesn't seem right to me (and the code you've deleted here
>> is the common idiom in syscall.c
Peter Maydell wrote:
> Doesn't this turn a timer_create(clkid, NULL, phtimer) into a
> timer_create(clkid, something-not-NULL, phtimer) ? That
> doesn't seem right to me (and the code you've deleted here
> is the common idiom in syscall.c for handling those "arg
> is pointer-to-struct-or-NULL" cas
Qemu versions 1.7.0, 1.7.1, 2.0.0, 2.1.0 do not run Debian mips64 BE or
LE stably. While install in 32-bit mode typically works, running the
64-bit kernel causes qemu to segfault or abort after a while.
How to reproduce:
Grab installation kernel and initrd:
ftp://ftp.debian.org/debian/dists/whe
Just tested qemu 2.1.0 and the bug is fixed in this version.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1351271
Title:
qemu deletes the b
On aarch64 it is the bootloader's job to uncompress the kernel. UEFI
and u-boot bootloaders do this automatically when the kernel is
gzip-compressed.
However the qemu -kernel option does not do this. The following
command does not work:
qemu-system-aarch64 [...] -kernel /boot/vmlinuz
because
No change compared to v3. I just rebased the patch on top of current
HEAD and ensured that it still works.
Any comments at all on this approach? It's the last patch I need to
make libguestfs work on aarch64 ...
Rich.
On 2 August 2014 15:10, Erik de Castro Lopo wrote:
> * Add missing unlock of user struct.
> * Remove unneeded pointer variable.
>
> Signed-off-by: Erik de Castro Lopo
> ---
> linux-user/syscall.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/syscall.c
* Add missing unlock of user struct.
* Remove unneeded pointer variable.
Signed-off-by: Erik de Castro Lopo
---
linux-user/syscall.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a50229d..7d8f54a 100644
--- a/linux-use
06.07.2014 12:43, Chen Gang wrote:
> getchar() is a standard c library function which may return with failure
> (e.g. -1), so like another platforms, also need check it under WIN32.
Applied to -trivial queue, with a slight modification:
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -185,15 +185,21 @
Applied to -trivial, thanks!
/mjt
07.07.2014 23:13, Stefan Weil wrote:
[]
> index 35316c4..ff4f200 100644
> --- a/hw/virtio/vhost-backend.c
> +++ b/hw/virtio/vhost-backend.c
> @@ -14,8 +14,6 @@
>
> #include
>
> -extern const VhostOps user_ops;
> -
BTW, it looks like we still have just one VhostOps - this user_ops one -
despi
Applied to -trivial, thanks!
/mjt
31.07.2014 04:31, Peter Crosthwaite wrote:
> To avoid callsites with optional output having to NULL guard.
Isn't it a bit backwards? If we don't need output, maybe we should
not call hexdump in the first place?
Thanks,
/mjt
> Signed-off-by: Peter Crosthwaite
> ---
> Noting in-tree is affected
19.07.2014 13:09, Alex Bligh wrote:
> When live migrate fails due to a section length mismatch we currently
> see an error message like:
>
> Length mismatch: :00:03.0/virtio-net-pci.rom: 1 in != 2
>
> The section lengths are in fact in hex, so this should read
>
> Length mismatch: 00
Thanks, applied to -trivial.
/mjt
23 matches
Mail list logo
