Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-17 Thread Markus Armbruster
John Snow writes: > If a negative integer is used for the max_bytes parameter, QEMU currently > calls abort() and leaves behind a core dump. This patch adds a simple > error message to make the reason for the termination clearer. > > Signed-off-by: John Snow > --- > v2: Changed 0L constant to (u

Re: [Qemu-devel] can't boot debian wheezy sparc in qemu

2014-07-17 Thread Dennis Luehring
Am 18.07.2014 00:22, schrieb Mark Cave-Ayland: On 17/07/14 07:43, Dennis Luehring wrote: > Am 16.07.2014 00:21, schrieb Mark Cave-Ayland: >> At the moment my work is focused on getting the basic system emulation >> up and running, so I haven't spent much time looking at the graphics >> side at a

Re: [Qemu-devel] [PATCH] block/quorum: implement .bdrv_co_get_block_status

2014-07-17 Thread Liu Yuan
On Fri, Jul 18, 2014 at 11:11:31AM +0800, Fam Zheng wrote: > On Thu, 07/17 19:50, Liu Yuan wrote: > > - allow drive-mirror to create sprase mirror on images like qcow2 > > - allow qemu-img map to work as expected on quorum driver > > > > Cc: Benoit Canet > > Cc: Kevin Wolf > > Cc: Stefan Hajnocz

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tests: Add missing 'static' attributes (fix warnings from smatch)

2014-07-17 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Add missing 'static' attribute

2014-07-17 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qga: Add missing 'static' attribute

2014-07-17 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/usb: Add missing 'static' attribute

2014-07-17 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] doc: slirp supports ICMP echo if enabled in Linux

2014-07-17 Thread Michael Tokarev
10.07.2014 18:01, Gernot Hillier wrote: > > Since QEMU 0.15, slirp (user mode networking) supports ping to the > Internet, see e6d43cfb1f9 Applied to the trivial tree, after removing an extra empty line and rewording the last part to be "To allow ping for GID 100 (usually users group)", because n

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: Give error message if hostfwd_add/remove for unrecognized vlan/stack

2014-07-17 Thread Michael Tokarev
08.07.2014 15:39, Peter Maydell wrote: > On 26 June 2014 13:35, Peter Maydell wrote: >> On 16 June 2014 16:47, Peter Maydell wrote: >>> If the user specified a (vlan ID, slirp stack name) tuple in a monitor >>> hostfwd_add/remove command and we can't find it, give the user an >>> error message ra

[Qemu-devel] [PATCH for-2.2] spapr: add host Linux version information to device tree

2014-07-17 Thread cyrilbur
It may prove useful know which Linux distribution version the host machine is running when an issue in the guest arises but a user cannot access the host. Signed-off-by: Cyril Bur --- hw/ppc/spapr.c | 8 +++ target-ppc/kvm.c | 62 +++

Re: [Qemu-devel] [PATCH] block/quorum: implement .bdrv_co_get_block_status

2014-07-17 Thread Fam Zheng
On Thu, 07/17 19:50, Liu Yuan wrote: > - allow drive-mirror to create sprase mirror on images like qcow2 > - allow qemu-img map to work as expected on quorum driver > > Cc: Benoit Canet > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > block/quorum.c | 16 ++

Re: [Qemu-devel] [question] how to check if savevm is completed?

2014-07-17 Thread Zhang Haoyu
>> I run savevm by qemu-monitor, but how to check if savevm is completed? I >> haven't find the query interface. > >That is because savevm is synchronous. It blocks until the operation is >complete. You cannot use the QEMU monitor while savevm is executing. > So, only the asynchronous operations

Re: [Qemu-devel] [RFC PATCH 7/7] cpus: reclaim allocated vCPU objects

2014-07-17 Thread Gu Zheng
Hi Anshul, On 07/18/2014 12:24 AM, Anshul Makkar wrote: > Are we not going to introduce new command cpu_del for deleting the cpu ? > > I couldn't find any patch for addition of cpu_del command. Is this > intentional and we intend to use device_del (and similarly device_add) > for cpu hot(un)plug

Re: [Qemu-devel] [PATCH for-2.1] scsi: fix scsi disk symbol confusion in guest os

2014-07-17 Thread Gonglei (Arei)
> -Original Message- > From: Gonglei (Arei) > Sent: Friday, July 18, 2014 9:32 AM > To: 'Paolo Bonzini'; qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun > Subject: RE: [PATCH for-2.1] scsi: fix scsi disk symbol confusion in guest os > > Hi, > > > -Original Message- > > Fr

Re: [Qemu-devel] [PATCH for-2.1] scsi: fix scsi disk symbol confusion in guest os

2014-07-17 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, July 17, 2014 9:45 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun > Subject: Re: [PATCH for-2.1] scsi: fix scsi disk symbol confusion in guest os > > Il 17/07/2

[Qemu-devel] [PULL v2 4/7] qtest: fix vhost-user-test compilation with old GLib

2014-07-17 Thread Michael S. Tsirkin
From: Nikolay Nikolaev Mising G_TIME_SPAN_SECOND definition breaks the RHEL6 compilation as GLib version before 2.26 does not have it. In such case just define it. Reported-by: Kevin Wolf Signed-off-by: Nikolay Nikolaev Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- t

[Qemu-devel] [PULL v2 5/7] vhost-user: Fix VHOST_SET_MEM_TABLE processing

2014-07-17 Thread Michael S. Tsirkin
From: Nikolay Nikolaev qemu_get_ram_fd doesn't accept a guest physical address. ram_addr_t are opaque values that are assigned in qemu_ram_alloc. Find the ram_addr_t corresponding to the userspace_addr using qemu_ram_addr_from_host, and then call qemu_get_ram_fd on it. Thanks to Paolo Bonzini

[Qemu-devel] [PULL v2 1/7] pc: fix qemu exiting with error when -m X < 128 with old machines types

2014-07-17 Thread Michael S. Tsirkin
From: Igor Mammedov If machine doesn't support memory hotplug then staring QEMU with initial memory less than default will make QEMU exit with following error message: $QEMU -m 16 -M isapc qemu-system-i386: "-memory 'slots|maxmem'" is not supported by: isapc Set maxram_size to initial memory v

[Qemu-devel] [PULL v2 7/7] vhost-user: minor cleanups

2014-07-17 Thread Michael S. Tsirkin
assert to verify cast does not discard information minor style fixup. Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 3d23218..4e88d9c 100644 --- a/hw/virtio/

[Qemu-devel] [PULL v2 3/7] fix typo: apci -> acpi

2014-07-17 Thread Michael S. Tsirkin
From: Hu Tao Signed-off-by: Hu Tao Reviewed-by: Andreas Färber Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin MST: rebase --- hw/acpi/ich9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index e7d6c77..7b14bbb 1006

Re: [Qemu-devel] [musl] Re: Bogus struct stat64 for qemu-microblaze (user emulation)?

2014-07-17 Thread Edgar E. Iglesias
On Wed, Jul 16, 2014 at 11:59:58AM -0400, Rich Felker wrote: > On Wed, Jul 16, 2014 at 09:36:23AM +0100, Peter Maydell wrote: > > On 16 July 2014 05:02, Rich Felker wrote: > > > The qemu-microblaze definition of struct stat64 seems to mismatch the > > > kernel definition, which is using asm-generi

[Qemu-devel] [PULL v2 2/7] pc_piix: Reuse pc_compat_1_2() for pc-0.1[0123]

2014-07-17 Thread Michael S. Tsirkin
From: Eduardo Habkost pc-0.13 and older were missing some compat code that was present on newer machine-types: * x86_cpu_compat_disable_kvm_features(FEAT_1_ECX, CPUID_EXT_X2APIC); (pc-i440fx-1.7 and older) (added by commit ef02ef5f4536dba090b12360a6c862ef0e57e3bc) * x86_cpu_compat_set_featur

[Qemu-devel] [PULL 7/7] vhost-user: minor cleanups

2014-07-17 Thread Michael S. Tsirkin
assert to verify cast does not discard information minor style fixup. Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 3d23218..4e88d9c 100644 --- a/hw/virtio/

[Qemu-devel] [PULL v2 6/7] qtest: Adapt vhost-user-test to latest vhost-user changes

2014-07-17 Thread Michael S. Tsirkin
From: Nikolay Nikolaev A new field mmap_offset was added in the vhost-user message, we need to reflect this change in the test too. Signed-off-by: Nikolay Nikolaev Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-test.c | 11 +-- 1 file changed,

[Qemu-devel] [PULL v2 0/7] pc,vhost,test fixes

2014-07-17 Thread Michael S. Tsirkin
Resending. v1 has exactly the same patches but had the wrong text in the tag. Sorry about that. The following changes since commit 3f0838ab8557c6071a5931183b2d7fed568cd35c: qemu-char: add chr_add_watch support in mux chardev (2014-07-06 09:13:54 +0300) are available in the git repository at:

[Qemu-devel] [PULL 2/7] pc_piix: Reuse pc_compat_1_2() for pc-0.1[0123]

2014-07-17 Thread Michael S. Tsirkin
From: Eduardo Habkost pc-0.13 and older were missing some compat code that was present on newer machine-types: * x86_cpu_compat_disable_kvm_features(FEAT_1_ECX, CPUID_EXT_X2APIC); (pc-i440fx-1.7 and older) (added by commit ef02ef5f4536dba090b12360a6c862ef0e57e3bc) * x86_cpu_compat_set_featur

[Qemu-devel] [PULL 6/7] qtest: Adapt vhost-user-test to latest vhost-user changes

2014-07-17 Thread Michael S. Tsirkin
From: Nikolay Nikolaev A new field mmap_offset was added in the vhost-user message, we need to reflect this change in the test too. Signed-off-by: Nikolay Nikolaev Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-test.c | 11 +-- 1 file changed,

[Qemu-devel] [PULL 3/7] fix typo: apci -> acpi

2014-07-17 Thread Michael S. Tsirkin
From: Hu Tao Signed-off-by: Hu Tao Reviewed-by: Andreas Färber Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin MST: rebase --- hw/acpi/ich9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index e7d6c77..7b14bbb 1006

[Qemu-devel] [PULL 1/7] pc: fix qemu exiting with error when -m X < 128 with old machines types

2014-07-17 Thread Michael S. Tsirkin
From: Igor Mammedov If machine doesn't support memory hotplug then staring QEMU with initial memory less than default will make QEMU exit with following error message: $QEMU -m 16 -M isapc qemu-system-i386: "-memory 'slots|maxmem'" is not supported by: isapc Set maxram_size to initial memory v

[Qemu-devel] [PULL 5/7] vhost-user: Fix VHOST_SET_MEM_TABLE processing

2014-07-17 Thread Michael S. Tsirkin
From: Nikolay Nikolaev qemu_get_ram_fd doesn't accept a guest physical address. ram_addr_t are opaque values that are assigned in qemu_ram_alloc. Find the ram_addr_t corresponding to the userspace_addr using qemu_ram_addr_from_host, and then call qemu_get_ram_fd on it. Thanks to Paolo Bonzini

[Qemu-devel] [PULL 0/7] pc,vhost,virtio fixes, test

2014-07-17 Thread Michael S. Tsirkin
The following changes since commit 3f0838ab8557c6071a5931183b2d7fed568cd35c: qemu-char: add chr_add_watch support in mux chardev (2014-07-06 09:13:54 +0300) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes

[Qemu-devel] [PULL 4/7] qtest: fix vhost-user-test compilation with old GLib

2014-07-17 Thread Michael S. Tsirkin
From: Nikolay Nikolaev Mising G_TIME_SPAN_SECOND definition breaks the RHEL6 compilation as GLib version before 2.26 does not have it. In such case just define it. Reported-by: Kevin Wolf Signed-off-by: Nikolay Nikolaev Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- t

Re: [Qemu-devel] can't boot debian wheezy sparc in qemu

2014-07-17 Thread Mark Cave-Ayland
On 17/07/14 07:43, Dennis Luehring wrote: Am 16.07.2014 00:21, schrieb Mark Cave-Ayland: At the moment my work is focused on getting the basic system emulation up and running, so I haven't spent much time looking at the graphics side at all. I have noticed that the kernel falls back to the dum

Re: [Qemu-devel] anyway to boot from backing file virtual disk after delete snapshot?

2014-07-17 Thread Yuanzhen Gu
yes, I found the way, we can reboot from original virtual disk via pick boot from existing disk img. Best, Yuanzhen On Thu, Jul 17, 2014 at 5:31 PM, Eric Blake wrote: > On 07/17/2014 03:15 PM, Yuanzhen Gu wrote: > > Hello there, > > > > I take external disk-only snapshot, but deleted the snaps

Re: [Qemu-devel] pause and restore function before and after QEMU Live Snapshot

2014-07-17 Thread Yuanzhen Gu
I see, thank you very much, Eric! Best, Yuanzhen On Thu, Jul 17, 2014 at 5:26 PM, Eric Blake wrote: > On 07/17/2014 02:20 PM, Yuanzhen Gu wrote: > > Hi Eric, > > [please don't top-post on technical lists] > > > I enabled libvirt debugging, and saw the log file under > > /var/log/libvirt/libvir

Re: [Qemu-devel] anyway to boot from backing file virtual disk after delete snapshot?

2014-07-17 Thread Eric Blake
On 07/17/2014 03:15 PM, Yuanzhen Gu wrote: > Hello there, > > I take external disk-only snapshot, but deleted the snapshot by mistaken. > Is there anyway to reboot the system from backing file instead of > reinstalled the system again? thanks! Are you using libvirt? If so, this question is better

Re: [Qemu-devel] pause and restore function before and after QEMU Live Snapshot

2014-07-17 Thread Eric Blake
On 07/17/2014 02:20 PM, Yuanzhen Gu wrote: > Hi Eric, [please don't top-post on technical lists] > I enabled libvirt debugging, and saw the log file under > /var/log/libvirt/libvirtd.log, Which debugging filters did you enable? In particular, you'll want to turn on LIBVIRT_LOG_FILTERS="1:qemu" f

[Qemu-devel] anyway to boot from backing file virtual disk after delete snapshot?

2014-07-17 Thread Yuanzhen Gu
Hello there, I take external disk-only snapshot, but deleted the snapshot by mistaken. Is there anyway to reboot the system from backing file instead of reinstalled the system again? thanks! Best, Yuanzhen

[Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-17 Thread John Snow
If a negative integer is used for the max_bytes parameter, QEMU currently calls abort() and leaves behind a core dump. This patch adds a simple error message to make the reason for the termination clearer. Signed-off-by: John Snow --- v2: Changed 0L constant to (uint64_t)0 constant to match PRId6

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-17 Thread Andrey Korolyov
On Thu, Jul 17, 2014 at 5:25 PM, Marcin Gibuła wrote: >>> 2.1-rc2 behaves exactly the same. >>> >>> Interestingly enough, reseting guest system causes I/O to work again. So >>> it's not qemu that hangs on IO, rather it fails to notify guest about >>> completed operations that were issued during mi

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-17 Thread Marcin Gibuła
W dniu 2014-07-17 21:18, Dr. David Alan Gilbert pisze: I don't know if this is the same case, but Gerd showed me a migration failure that might be related. 2.0 seems OK, 2.1-rc0 is broken (and I've not found another working point in between yet). The test case involves booting a fedora livecd (

Re: [Qemu-devel] pause and restore function before and after QEMU Live Snapshot

2014-07-17 Thread Yuanzhen Gu
Hi Eric, Thank you very much for your suggestion, it do help. I enabled libvirt debugging, and saw the log file under /var/log/libvirt/libvirtd.log, for example, I saw 2014-07-17 20:06:55.992+: 4391: debug : qemuProcessHandleResume:575 : Transitioned guest ubuntu out of paused into resumed s

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-17 Thread Kay, Allen M
> That sounds great. Tiejun could you confirm that with windows driver guys too? I believe windows driver can also assume specific CPU/PCH combos. I will discuss this with native Windows driver guys. Preferably, the same code path can be used for both native and virtualization cases to avoid f

Re: [Qemu-devel] status for rc3/release

2014-07-17 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > So we just released rc2. The proposed schedule has > rc3 next Tuesday, with final release the Tuesday after. > > My thought is that we should aim for rc3 to add only > a fairly small number of focussed and "safe" bugfixes, > with the intention of

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-17 Thread Dr. David Alan Gilbert
I don't know if this is the same case, but Gerd showed me a migration failure that might be related. 2.0 seems OK, 2.1-rc0 is broken (and I've not found another working point in between yet). The test case involves booting a fedora livecd (using an IDE CDROM device) and after the migration we're

Re: [Qemu-devel] [PATCH for-2.1] po: Update German translation

2014-07-17 Thread Stefan Weil
Am 17.07.2014 20:50, schrieb Stefan Weil: > Line numbers changed, and some translations were missing after commit > 3d914488aee3dc1bf495e461aedf8fb4e5bb2270. > > Update also "Show Tabs" to a more common translation, and remove some > old unused lines at the end. > > Signed-off-by: Stefan Weil >

[Qemu-devel] [PATCH for-2.1] po: Update German translation

2014-07-17 Thread Stefan Weil
Line numbers changed, and some translations were missing after commit 3d914488aee3dc1bf495e461aedf8fb4e5bb2270. Update also "Show Tabs" to a more common translation, and remove some old unused lines at the end. Signed-off-by: Stefan Weil --- All other translations also need updates because of m

Re: [Qemu-devel] [question] how to check if savevm is completed?

2014-07-17 Thread Stefan Hajnoczi
On Thu, Jul 17, 2014 at 03:28:21PM +0800, Zhang Haoyu wrote: > I run savevm by qemu-monitor, but how to check if savevm is completed? I > haven't find the query interface. That is because savevm is synchronous. It blocks until the operation is complete. You cannot use the QEMU monitor while sav

Re: [Qemu-devel] status for rc3/release

2014-07-17 Thread Stefan Hajnoczi
On Thu, Jul 17, 2014 at 10:45:31AM +0100, Peter Maydell wrote: > So we just released rc2. The proposed schedule has > rc3 next Tuesday, with final release the Tuesday after. > > My thought is that we should aim for rc3 to add only > a fairly small number of focussed and "safe" bugfixes, > with the

Re: [Qemu-devel] [PATCH for-2.1] qcow2: Fix error path for unknown incompatible features

2014-07-17 Thread Stefan Hajnoczi
On Thu, Jul 17, 2014 at 11:41:53AM +0200, Kevin Wolf wrote: > qcow2's report_unsupported_feature() had two bugs: A 32 bit truncation > would prevent feature table entries for bits 32-63 from being used, and > it could assign errp multiple times if there was more than one unknown > feature, resultin

[Qemu-devel] [PATCH for-2.1] qemu-iotests: fix 028 failure due to disk image path

2014-07-17 Thread Stefan Hajnoczi
The disk image path is echoed by QEMU's readline when the "drive_backup disk ${TEST_IMG}.copy" HMP command is issued. Unfortunately it is very hard to filter out the path due to readline's character-by-character output (with terminal escape sequences). Just redirect this command to /dev/null for

Re: [Qemu-devel] [PATCH for-2.1] po: Fix Makefile rules

2014-07-17 Thread Stefan Weil
Am 17.07.2014 19:56, schrieb Stefan Weil: > Adding 'update' to the phony targets fixes this error: > > $ LANG=C make -C po update > make: Entering directory `/qemu/po' > LINK update > /qemu/po/de_DE.po: file not recognized: File format not recognized > collect2: error: ld returned 1 exit status

[Qemu-devel] [PATCH for-2.1] po: Fix Makefile rules

2014-07-17 Thread Stefan Weil
Adding 'update' to the phony targets fixes this error: $ LANG=C make -C po update make: Entering directory `/qemu/po' LINK update /qemu/po/de_DE.po: file not recognized: File format not recognized collect2: error: ld returned 1 exit status make: *** [update] Error 1 make: Leaving directory `/qe

[Qemu-devel] Debugging live migrate failures between 1.0 and 2.0

2014-07-17 Thread Alex Bligh
I am trying to get to the bottom of a live migrate failure between qemu 1.0 (sender) and qemu 2.0 (receiver). I think this should 'just work', correct? What I'm seeing is the live migrate starts correctly through QMP, but the first query_migrate call returns a failure. On the receive side it say

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Marcel Apfelbaum
On Thu, 2014-07-17 at 17:55 +0100, Peter Maydell wrote: > On 29 June 2014 10:09, Marcel Apfelbaum wrote: > > Replaced '_' with '-' to comply with QOM guidelines. > > Made the conversion from HMP to QMP in vl.c > > > > Signed-off-by: Marcel Apfelbaum > > > index a1686ef..7587c97 100644 > > --- a/

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Paolo Bonzini
Il 17/07/2014 18:47, Michael Roth ha scritto: > My argument for getting this into 2.1 had been to avoid tools picking up > these to-be-renamed property names from the start. At this point, I'm > not so sure whether it's worse to break management tools or potentially > some rarely used/tested opti

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Peter Maydell
On 29 June 2014 10:09, Marcel Apfelbaum wrote: > Replaced '_' with '-' to comply with QOM guidelines. > Made the conversion from HMP to QMP in vl.c > > Signed-off-by: Marcel Apfelbaum > index a1686ef..7587c97 100644 > --- a/vl.c > +++ b/vl.c > @@ -2820,15 +2820,25 @@ static int object_set_proper

Re: [Qemu-devel] [PATCH for-2.1] cadence_uart: check serial backend before using it.

2014-07-17 Thread Peter Maydell
On 16 July 2014 08:42, wrote: > From: KONRAD Frederic > > Segfault occurs when there are less than two serial backends with zynq > platform. > > This checks that s->chr is not NULL before using it. > > Signed-off-by: KONRAD Frederic > Reviewed-by: Peter Crosthwaite > --- > hw/char/cadence_ua

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Michael Roth
Quoting Andreas Färber (2014-07-17 10:48:59) > Am 17.07.2014 16:20, schrieb Paolo Bonzini: > > Il 17/07/2014 16:15, Marcel Apfelbaum ha scritto: > >> On Sun, 2014-06-29 at 14:37 +0300, Michael S. Tsirkin wrote: > >>> On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: > Replaced

Re: [Qemu-devel] [RFC PATCH 7/7] cpus: reclaim allocated vCPU objects

2014-07-17 Thread Anshul Makkar
Are we not going to introduce new command cpu_del for deleting the cpu ? I couldn't find any patch for addition of cpu_del command. Is this intentional and we intend to use device_del (and similarly device_add) for cpu hot(un)plug or just skipped to be added later. I have the patch for the same wh

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Andreas Färber
Am 17.07.2014 16:20, schrieb Paolo Bonzini: > Il 17/07/2014 16:15, Marcel Apfelbaum ha scritto: >> On Sun, 2014-06-29 at 14:37 +0300, Michael S. Tsirkin wrote: >>> On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: Replaced '_' with '-' to comply with QOM guidelines. Made t

Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types

2014-07-17 Thread Bruce Rogers
>>> On 7/8/2014 at 07:29 AM, wrote: > If machine doesn't support memory hotplug then staring QEMU > with initial memory less than default will make QEMU exit with > following error message: > > $QEMU -m 16 -M isapc > qemu-system-i386: "-memory 'slots|maxmem'" is not supported by: isapc > > Se

Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types

2014-07-17 Thread Bruce Rogers
>>> On 7/11/2014 at 12:06 PM, wrote: > On Tue, Jul 08, 2014 at 03:29:46PM +0200, Igor Mammedov wrote: >> If machine doesn't support memory hotplug then staring QEMU >> with initial memory less than default will make QEMU exit with >> following error message: >> >> $QEMU -m 16 -M isapc >> qemu-

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Paolo Bonzini
Il 17/07/2014 16:15, Marcel Apfelbaum ha scritto: On Sun, 2014-06-29 at 14:37 +0300, Michael S. Tsirkin wrote: On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: Replaced '_' with '-' to comply with QOM guidelines. Made the conversion from HMP to QMP in vl.c Signed-off-by: Marce

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-17 Thread Marcel Apfelbaum
On Sun, 2014-06-29 at 14:37 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 29, 2014 at 12:09:15PM +0300, Marcel Apfelbaum wrote: > > Replaced '_' with '-' to comply with QOM guidelines. > > Made the conversion from HMP to QMP in vl.c > > > > Signed-off-by: Marcel Apfelbaum > > Nothing to do with

[Qemu-devel] [RFC PATCH v2 13/49] pl031: add missed field to vmstate

2014-07-17 Thread Pavel Dovgalyuk
This patch adds timer which uses virtual clock to the VMState. Such timers are required for saving because virtual clock is the part of the virtual machine state. Signed-off-by: Pavel Dovgalyuk --- hw/timer/pl031.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/tim

[Qemu-devel] [RFC PATCH v2 24/49] target-arm: instructions counting code for replay

2014-07-17 Thread Pavel Dovgalyuk
This patch adds instructions counting into the target-specific part of arm simulator. In record/replay mode it inserts replay functions calls and instructions counter increment into the translated code. Signed-off-by: Pavel Dovgalyuk --- target-arm/Makefile.objs |1 + target-arm/helper.h

[Qemu-devel] [RFC PATCH v2 29/49] replay: recording and replaying clock ticks

2014-07-17 Thread Pavel Dovgalyuk
Clock ticks are considered as the sources of non-deterministic data for virtual machine. This patch implements saving the clock values when they are acquired (virtual, host clock, rdtsc, and some other timers). When replaying the execution corresponding values are read from log and transfered to th

[Qemu-devel] [RFC PATCH v2 18/49] migration: add vmstate for int8 and char arrays

2014-07-17 Thread Pavel Dovgalyuk
This patch adds macros for vmstate int8 and char arrays. Signed-off-by: Pavel Dovgalyuk --- include/migration/vmstate.h | 13 + vmstate.c |6 ++ 2 files changed, 19 insertions(+), 0 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration

Re: [Qemu-devel] [PATCH for-2.1] scsi: fix scsi disk symbol confusion in guest os

2014-07-17 Thread Paolo Bonzini
Il 17/07/2014 14:55, arei.gong...@huawei.com ha scritto: From: Gonglei Assuming that we hotplug three virtio-scsi disk as follow steps: 1. start vm with virtio-scsi as system disk (guest os: suse11 sp3 ). 2. hotplug disk 1 (as lun2) -drive file=/Images/TestImg/kvm-disk-scsi_001,if=none,id=dri

Re: [Qemu-devel] [PATCH RESEND] ui/gtk: Restore keyboard focus after Page change

2014-07-17 Thread Gerd Hoffmann
On Do, 2014-07-17 at 14:21 +0100, Stefan Hajnoczi wrote: > On Tue, Jul 08, 2014 at 02:28:57PM -0400, John Snow wrote: > > (Resending for correct email addresses via MAINTAINERS ...) > > > > In the GTK UI, after changing focus to the qemu monitor Notebook Page, > > when restoring focus to the virtu

[Qemu-devel] [RFC PATCH v2 23/49] cpu: invent instruction count for accurate replay

2014-07-17 Thread Pavel Dovgalyuk
This patch adds instructions count fields to cpu structure and invents several functions for increasing this counter while executing translation blocks. Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c | 14 - cpus.c |5 ++ exec.c |4 +

[Qemu-devel] [RFC PATCH v2 39/49] replay: snapshotting the virtual machine

2014-07-17 Thread Pavel Dovgalyuk
This patch adds 'period' parameter to the 'record' command line option. This parameters turns on periodic snapshotting of the VM which could be used by replay to move forward and backward in time. If 'period' parameter is not specified, only one snapshot is made at the start of the virtual machine.

[Qemu-devel] [RFC PATCH v2 20/49] block: add suffix parameter to bdrv_open functions

2014-07-17 Thread Pavel Dovgalyuk
This patch adds parameter with suffix for overlay filenames. This parameter will be used by replay to automatically create overlay files based on drive images supplied to VM. Signed-off-by: Pavel Dovgalyuk --- block.c | 44 ++-- block/blkde

[Qemu-devel] [RFC PATCH v2 22/49] replay: internal functions for replay log

2014-07-17 Thread Pavel Dovgalyuk
This patch adds functions to perform read and write operations with replay log. Signed-off-by: Pavel Dovgalyuk --- replay/Makefile.objs |1 replay/replay-internal.c | 141 ++ replay/replay-internal.h | 50 replay/replay.c

[Qemu-devel] [RFC PATCH v2 21/49] sysemu: system functions for replay

2014-07-17 Thread Pavel Dovgalyuk
This patch removes "static" specifier from several qemu function to make them visible to the replay module. It also invents several system functions that will be used by replay. Signed-off-by: Pavel Dovgalyuk --- arch_init.c |8 cpu-exec.c |6 -- cpu

[Qemu-devel] [RFC PATCH v2 31/49] replay: shutdown event

2014-07-17 Thread Pavel Dovgalyuk
This patch records and replays simulator shutdown event. Signed-off-by: Pavel Dovgalyuk --- include/sysemu/sysemu.h |1 + replay/replay-internal.h | 13 ++--- replay/replay.c | 11 +++ replay/replay.h |5 + vl.c |8 ++

[Qemu-devel] [RFC PATCH v2 30/49] replay: recording and replaying different timers

2014-07-17 Thread Pavel Dovgalyuk
This patch introduces functions for recording and replaying realtime sources, that do not use qemu-clock interface. These include return value of time() function in time_t and struct tm forms. Patch also adds warning to get_timedate function to prevent its usage in recording mode, because it may le

[Qemu-devel] [RFC PATCH v2 38/49] replay: command line options

2014-07-17 Thread Pavel Dovgalyuk
This patch introduces command line options for enabling recording or replaying virtual machine behavior. "-record" option starts recording of the execution and saves it into the log, specified with "fname" parameter. "-replay" option is intended for replaying previously saved log. Signed-off-by: P

[Qemu-devel] [RFC PATCH v2 34/49] replay: replay aio requests

2014-07-17 Thread Pavel Dovgalyuk
This patch adds identifier to aio requests. ID is used for creating bottom halves and identifying them while replaying. The patch also introduces several functions that make possible replaying of the aio requests. Signed-off-by: Pavel Dovgalyuk --- block.c | 79 ++

[Qemu-devel] [RFC PATCH v2 12/49] mc146818rtc: add missed field to vmstate

2014-07-17 Thread Pavel Dovgalyuk
This patch adds irq_reinject_on_ack_count field to VMState to allow correct saving/loading the state of MC146818 RTC. Signed-off-by: Pavel Dovgalyuk --- hw/timer/mc146818rtc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc

[Qemu-devel] [RFC PATCH v2 16/49] target: save cpu state fields

2014-07-17 Thread Pavel Dovgalyuk
This patch adds interrupt fields to VMState for correct saving the CPU state. Signed-off-by: Pavel Dovgalyuk --- target-arm/machine.c |5 - target-i386/machine.c |5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/target-arm/machine.c b/target-arm/machine.c inde

[Qemu-devel] [RFC PATCH v2 19/49] replay: global variables and function stubs

2014-07-17 Thread Pavel Dovgalyuk
This patch adds global variables, defines, functions declarations, and function stubs for deterministic VM replay used by external modules. Signed-off-by: Pavel Dovgalyuk --- Makefile.target |1 + replay/Makefile.objs |1 + replay/replay.c | 19 +++ replay/rep

[Qemu-devel] [RFC PATCH v2 37/49] replay: initialization and deinitialization

2014-07-17 Thread Pavel Dovgalyuk
This patch introduces the functions for enabling the record/replay and for freeing the resources when simulator closes. Signed-off-by: Pavel Dovgalyuk --- exec.c |1 replay/replay-internal.h |2 + replay/replay.c | 127

[Qemu-devel] [RFC PATCH v2 33/49] replay: bottom halves

2014-07-17 Thread Pavel Dovgalyuk
This patch introduces bottom half event for replay queue. It saves the events into the queue and process them at the checkpoints and instructions execution. Signed-off-by: Pavel Dovgalyuk --- async.c | 45 +++-- dma-helpers.c

[Qemu-devel] [RFC PATCH v2 11/49] piix: do not raise irq while loading vmstate

2014-07-17 Thread Pavel Dovgalyuk
This patch disables raising an irq while loading the state of PCI bridge. Signed-off-by: Pavel Dovgalyuk --- hw/pci-host/piix.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index e0e0946..86d6d20 100644 ---

[Qemu-devel] [RFC PATCH v2 32/49] replay: checkpoints

2014-07-17 Thread Pavel Dovgalyuk
This patch introduces checkpoints that synchronize cpu thread and iothread. When checkpoint is met in the code all asynchronous events from the queue are executed. Signed-off-by: Pavel Dovgalyuk --- block.c | 11 +++ cpus.c |2 +- include/qemu/tim

[Qemu-devel] [RFC PATCH v2 35/49] replay: thread pool

2014-07-17 Thread Pavel Dovgalyuk
This patch modifies thread pool to allow replaying asynchronous thread tasks synchronously in replay mode. Signed-off-by: Pavel Dovgalyuk --- block/raw-posix.c |6 +++-- block/raw-win32.c |4 ++- include/block/thread-pool.h |4 ++- replay/replay-events.c |

[Qemu-devel] [RFC PATCH v2 40/49] replay: recording of the user input

2014-07-17 Thread Pavel Dovgalyuk
This records user input (keyboard and mouse events) in record mode and replays these input events in replay mode. Signed-off-by: Pavel Dovgalyuk --- include/ui/input.h |2 + replay/Makefile.objs |1 replay/replay-events.c | 48 + replay/replay-input.c

[Qemu-devel] [RFC PATCH v2 25/49] target-i386: instructions counting code for replay

2014-07-17 Thread Pavel Dovgalyuk
This patch adds instructions counting into the target-specific part of i386/x86_64 simulator. In record/replay mode it inserts replay functions calls and instructions counter increment into the translated code. Signed-off-by: Pavel Dovgalyuk --- target-i386/Makefile.objs |1 + target-i386/

[Qemu-devel] [RFC PATCH v2 28/49] replay: asynchronous events infrastructure

2014-07-17 Thread Pavel Dovgalyuk
This patch adds module for saving and replaying asynchronous events. These events include network packets, keyboard and mouse input, USB packets, thread pool and bottom halves callbacks. All events are stored in the queue to be processed at synchronization points such as beginning of TB execution,

[Qemu-devel] [RFC PATCH v2 36/49] pl031: vmstate in replay mode

2014-07-17 Thread Pavel Dovgalyuk
This patch modifies vmstate for PL031 RTC. It removes querying of the rtc and virtual clocks while saving and restoring VM state, because in replay mode these clocks are stopped while saving. And reading the clock while restoring the VM state may lead to read of the incorrect values, because clocks

[Qemu-devel] [RFC PATCH v2 14/49] ide pci: reset status field before loading the vmstate

2014-07-17 Thread Pavel Dovgalyuk
This patch resets status field before loading the state of IDE BMDMA device. Resetting status is needed for replay, because it does not reset whole virtual machine before loading state of the VM. Signed-off-by: Pavel Dovgalyuk --- hw/ide/pci.c | 10 ++ 1 files changed, 10 insertions(+)

[Qemu-devel] [RFC PATCH v2 27/49] vga: do not use virtual clock for blinking cursor

2014-07-17 Thread Pavel Dovgalyuk
This patch changes virtual clock to realtime one in vga_draw_text and vga_update_display functions. Display update process depends on realtime clock. If we read virtual clock there, virtual machine becomes non-deterministic, because every read to virtual clock is written to the replay log. Signed-

[Qemu-devel] [RFC PATCH v2 43/49] replay: audio data record/replay

2014-07-17 Thread Pavel Dovgalyuk
This patch adds deterministic replay for audio adapter. Replay module saves data from the microphone and "end-of-playback" events. Support of audio record and replay is implemented only for Win32 hosts. Signed-off-by: Pavel Dovgalyuk --- audio/audio.c| 14 ++- audio/audio_win_int.h

[Qemu-devel] [RFC PATCH v2 17/49] target-i386: update fp status fix

2014-07-17 Thread Pavel Dovgalyuk
This patch adds calls to update_fp_status() function from several places where FPU state is changed. Signed-off-by: Pavel Dovgalyuk --- target-i386/cpu.c|1 + target-i386/cpu.h|1 + target-i386/fpu_helper.c |5 - target-i386/machine.c|2 +- 4 files changed

[Qemu-devel] [RFC PATCH v2 41/49] tap-win32: destroy the thread at exit

2014-07-17 Thread Pavel Dovgalyuk
This patch fixes resource leak caused by created thread which is not destroyed at exit. Signed-off-by: Pavel Dovgalyuk --- net/tap-win32.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 8aee611..efd1c75 100644 --- a/net/

[Qemu-devel] [RFC PATCH v2 26/49] replay: interrupts and exceptions

2014-07-17 Thread Pavel Dovgalyuk
This patch includes modifications of common cpu files. All interrupts and exceptions occured during recording are written into the replay log. These events allow correct replaying the execution by kicking cpu thread when one of these events is found in the log. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [RFC PATCH v2 47/49] replay: replay_break command

2014-07-17 Thread Pavel Dovgalyuk
This patch adds support for replay_break monitor command. This command sets the step (measured in executed instructions) where replay should be stopped. Signed-off-by: Pavel Dovgalyuk --- hmp-commands.hx | 14 ++ monitor.c | 15 +++ qapi-schema.json|

[Qemu-devel] [RFC PATCH v2 49/49] gdbstub: reverse debugging

2014-07-17 Thread Pavel Dovgalyuk
This patch introduces support of reverse debugging through the gdb remote protocol. Patch adds reverse-stepi and reverse-continue commands support to qemu. Other reverse commands should also work, because they reuse these ones. Signed-off-by: Pavel Dovgalyuk --- exec.c |

  1   2   >