Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-16 Thread Alexander Graf
> Am 17.06.2014 um 06:31 schrieb Paolo Bonzini : > > Il 17/06/2014 00:35, Alexander Graf ha scritto: >> >>> On 16.06.14 19:29, Gabriel L. Somlo wrote: >>> This series contains a few fixes and improvements in the emulation >>> of link auto-negotiation: >>> >>> - use auto-negotiation when the

[Qemu-devel] [PATCH v2 7/7] virtio-blk: Rename complete_request_early to complete_request_vring

2014-06-16 Thread Fam Zheng
The old name is misleading in its new usage, so rename it. Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index b6afa55..09bd2c7 100644 --- a/hw

[Qemu-devel] [PATCH v2 2/7] block: acquire AioContext in qmp_query_blockstats()

2014-06-16 Thread Fam Zheng
From: Stefan Hajnoczi Make query-blockstats safe for dataplane by acquiring the BlockDriverState's AioContext. This ensures that the dataplane IOThread and the main loop's monitor code do not race. Note the assumption that acquiring the drive's BDS AioContext also protects ->file and ->backing_

[Qemu-devel] [PATCH v2 6/7] virtio-blk: Unify {non-, }dataplane's request handlings

2014-06-16 Thread Fam Zheng
This drops request handling code from dataplane, and uses code from hw/block/virtio-blk.c. It starts to use multiwrite as non-dataplane does. Dataplane sets VirtIOBlock.complete_request to vring version, and calls into non-dataplane's process handling. In complete_request_early, qiov.size is adde

[Qemu-devel] [PATCH v2 4/7] virtio-blk: Export request handling functions to dataplane

2014-06-16 Thread Fam Zheng
So that dataplane can use virtio_blk_handle_request and virtio_submit_multiwrite. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 10 ++ include/hw/virtio/virtio-blk.h | 9 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw

[Qemu-devel] [PATCH v2 1/7] block: make bdrv_query_stats() static

2014-06-16 Thread Fam Zheng
From: Stefan Hajnoczi This function is only called from block/qapi.c. There is no need to keep it public. Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/qapi.c | 2 +- include/block/qapi.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/block/q

[Qemu-devel] [PATCH v2 3/7] virtio-blk: Make request completion function virtual

2014-06-16 Thread Fam Zheng
virtio_blk_req_complete will call VirtIOBlock.complete_request() to push data and notify guest. No functional change. Later, this will allow dataplane to provide it's own (vring_) version. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 9 - include/hw/virtio/virtio-blk.h

[Qemu-devel] [PATCH v2 0/7] virtio-blk: Unify request handling of dataplane

2014-06-16 Thread Fam Zheng
v2: Address Paolo's comments: * Schedule restart BH in the right AioContext. * Restore ->complete_request when stopping dataplane. This is based on top of my request converging series: [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Most of the request handlings

Re: [Qemu-devel] [PATCH v3 28/32] target-arm: make DFSR banked

2014-06-16 Thread Edgar E. Iglesias
On Fri, Jun 13, 2014 at 05:06:15PM -0500, Greg Bellows wrote: > I just wanted to point out that the change from array-notation to hard-code > numbers in the names undoes Edgar's EL2/EL3 changes. I prefer this way > over the array notation. Hi, This was discussed briefly here http://lists.gnu.org

Re: [Qemu-devel] [PATCH] block/iscsi: use 16 byte CDBs only when necessary

2014-06-16 Thread Peter Lieven
On 05.06.2014 11:12, Michael Tokarev wrote: 04.06.2014 18:00, ronnie sahlberg wrote: That would mean you get to use the 10 version of the cdb even for very large devices (as long as the IO is for blocks at the beginning of the device) and thus provide partial avoidance of this issue for those la

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-16 Thread Benjamin Herrenschmidt
On Tue, 2014-06-17 at 07:36 +0200, Paolo Bonzini wrote: > Il 17/06/2014 06:59, Benjamin Herrenschmidt ha scritto: > > Thanks. I've tried the other approach of adding new functions which > > means no overhead (hopefully) for the non-swap case and less invasive > > changes to vga_template.c. > > > >

Re: [Qemu-devel] [PATCH v3 05/32] target-arm: reject switching to monitor mode

2014-06-16 Thread Edgar E. Iglesias
On Wed, Jun 11, 2014 at 01:54:47AM +0200, Fabian Aggeler wrote: > From: Sergey Fedorov > > ...from non-secure state. > Reviewed-by: Edgar E. Iglesias > Signed-off-by: Sergey Fedorov > Signed-off-by: Fabian Aggeler > --- > target-arm/helper.c | 2 ++ > 1 file changed, 2 insertions(+) > > d

Re: [Qemu-devel] [PATCH v3 04/32] target-arm: add arm_is_secure() function

2014-06-16 Thread Edgar E. Iglesias
On Wed, Jun 11, 2014 at 01:54:46AM +0200, Fabian Aggeler wrote: > arm_is_secure() function allows to determine CPU security state > if the CPU implements Security Extensions/EL3. > arm_is_secure_below_el3() returns true if CPU is in secure state > below EL3. > > Signed-off-by: Sergey Fedorov > Si

Re: [Qemu-devel] Using virtio for inter-VM communication

2014-06-16 Thread Jan Kiszka
On 2014-06-17 07:24, Paolo Bonzini wrote: > Il 15/06/2014 08:20, Jan Kiszka ha scritto: >>> > I think implementing Xen hypercalls in jailhouse for grant table and >>> > event channels would actually make a lot of sense. The Xen >>> > implementation is 2.5kLOC and I think it should be possible to c

Re: [Qemu-devel] [RFC v2 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

2014-06-16 Thread Alistair Francis
Add Stefan Hajnoczi as it relies on his work (http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg06489.html) On Tue, Jun 17, 2014 at 2:18 PM, Alistair Francis wrote: > This patch adds the Cortex-A9 ARM CPU to the A9MPCore. > > The CPU is only created if the num-cpu property is set. > > This

[Qemu-devel] [PATCH] block/iscsi: use 16 byte CDBs also for big requests

2014-06-16 Thread Peter Lieven
READ10, WRITE10, WRITESAME10 only support requests up to 65536 blocks. This is 32MB for 512-Byte sectors. Change to READ16, WRITE16, WRITESAME16 just in case such a big request is issued. Signed-off-by: Peter Lieven --- block/iscsi.c | 13 + 1 file changed, 5 insertions(+), 8 delet

[Qemu-devel] [PATCH] target-ppc: fixed translation of mcrxr instruction

2014-06-16 Thread Sorav Bansal
Fixed bug in gen_mcrxr() in target-ppc/translate.c: The XER[SO], XER[OV], and XER[CA] flags are stored in the least significant bit (bit 0) of their respective registers. They need to be shifted left (by their respective offsets) to generate the final XER value. The old translation code for the 'mc

Re: [Qemu-devel] [PATCH 0/7] spapr: rework memory nodes

2014-06-16 Thread Alexey Kardashevskiy
On 06/17/2014 06:51 AM, Eduardo Habkost wrote: > On Mon, Jun 16, 2014 at 06:16:29PM +1000, Alexey Kardashevskiy wrote: >> On 06/16/2014 05:53 PM, Alexey Kardashevskiy wrote: >>> c4177479 "spapr: make sure RMA is in first mode of first memory node" >>> introduced regression which prevents from runni

Re: [Qemu-devel] [PATCH v3 06/32] target-arm: make arm_current_pl() return PL3

2014-06-16 Thread Edgar E. Iglesias
On Wed, Jun 11, 2014 at 01:54:48AM +0200, Fabian Aggeler wrote: > Make arm_current_pl() return PL3 for secure PL1 and monitor mode. > Increase MMU modes since mmu_index is directly infered from arm_ > current_pl(). Changes assertion in arm_el_is_aa64() to allow EL3. > > Signed-off-by: Fabian Aggel

[Qemu-devel] [PATCH] sheepdog: fix NULL dereference in sd_create

2014-06-16 Thread Liu Yuan
Following command qemu-img create -f qcow2 sheepdog:test 20g will cause core dump because aio_context is NULL in sd_create. We should initialize it by qemu_get_aio_context() to avoid NULL dereference. Cc: qemu-devel@nongnu.org Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- bl

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-16 Thread Paolo Bonzini
Il 17/06/2014 06:59, Benjamin Herrenschmidt ha scritto: Thanks. I've tried the other approach of adding new functions which means no overhead (hopefully) for the non-swap case and less invasive changes to vga_template.c. Patch below. What do you think ? This or the previous approach ? Then we ca

Re: [Qemu-devel] Using virtio for inter-VM communication

2014-06-16 Thread Paolo Bonzini
Il 15/06/2014 08:20, Jan Kiszka ha scritto: > I think implementing Xen hypercalls in jailhouse for grant table and > event channels would actually make a lot of sense. The Xen > implementation is 2.5kLOC and I think it should be possible to compact > it noticeably, especially if you limit yourse

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-16 Thread Benjamin Herrenschmidt
On Tue, 2014-06-17 at 06:40 +0200, Paolo Bonzini wrote: > Il 17/06/2014 05:07, Benjamin Herrenschmidt ha scritto: > > I've come up with the proof of concept below which changes the various > > line drawing functions in vga-template to select the right ld/st > > function. However that adds a per-lin

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-16 Thread Paolo Bonzini
Il 17/06/2014 05:07, Benjamin Herrenschmidt ha scritto: I've come up with the proof of concept below which changes the various line drawing functions in vga-template to select the right ld/st function. However that adds a per-line test (overhead I can hear some people shouting ! :-). Sounds per

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-16 Thread Paolo Bonzini
Il 17/06/2014 00:35, Alexander Graf ha scritto: On 16.06.14 19:29, Gabriel L. Somlo wrote: This series contains a few fixes and improvements in the emulation of link auto-negotiation: - use auto-negotiation when the link is bounced externally (e.g. via set_link down/up on the qemu mon

Re: [Qemu-devel] [PATCH 0/6] virtio-blk: Unify request handling of dataplane

2014-06-16 Thread Paolo Bonzini
Il 17/06/2014 05:44, Fam Zheng ha scritto: This is based on top of my request converging series: [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Most of the request handlings are already the same now between dataplane and non-dataplane, except the missing IO accountin

Re: [Qemu-devel] [PATCH 5/6] virtio-blk: Unify {non-, }dataplane's request handlings

2014-06-16 Thread Paolo Bonzini
Il 17/06/2014 05:45, Fam Zheng ha scritto: @@ -275,6 +123,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk, Error **errp) { VirtIOBlockDataPlane *s; +VirtIOBlock *vblk = VIRTIO_BLK(vdev); Error *local_err = NULL;

[Qemu-devel] [RFC v2 2/2] zynq: Update Zynq to init the CPU in the a9mpcore device

2014-06-16 Thread Alistair Francis
This patch removes the initialisation of the ARM Cortex-A9 in Zynq and instead allows the a9mpcore device to init the CPU. This also updates components that rely on the CPU and GIC, as they are now initialised in a slightly different way Signed-off-by: Alistair Francis --- V2: - Small changes bas

[Qemu-devel] [RFC v2 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

2014-06-16 Thread Alistair Francis
This patch adds the Cortex-A9 ARM CPU to the A9MPCore. The CPU is only created if the num-cpu property is set. This patch relies on Stefan Hajnoczi's v3 'virtio-blk: use alias properties in transport devices' patch. This is used to pass the CPU properties through to the mpcore. This patch allows

[Qemu-devel] [PATCH 3/6] virtio-blk: Make request completion function virtual

2014-06-16 Thread Fam Zheng
virtio_blk_req_complete will call VirtIOBlock.complete_request() to push data and notify guest. No functional change. Later, this will allow dataplane to provide it's own (vring_) version. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 9 - include/hw/virtio/virtio-blk.h

[Qemu-devel] [PATCH 6/6] virtio-blk: Rename complete_request_early to complete_request_vring

2014-06-16 Thread Fam Zheng
The old name is misleading in its new usage, so rename it. Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 47eb087..e79da1b 100644 --- a/hw

[Qemu-devel] [PATCH 5/6] virtio-blk: Unify {non-, }dataplane's request handlings

2014-06-16 Thread Fam Zheng
This drops request handling code from dataplane, and uses code from hw/block/virtio-blk.c. It starts to use multiwrite as non-dataplane does. Dataplane sets VirtIOBlock.complete_request to vring version, and calls into non-dataplane's process handling. In complete_request_early, qiov.size is adde

[Qemu-devel] [PATCH 0/6] virtio-blk: Unify request handling of dataplane

2014-06-16 Thread Fam Zheng
This is based on top of my request converging series: [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Most of the request handlings are already the same now between dataplane and non-dataplane, except the missing IO accounting, error reporting and multiwrite. With this

[Qemu-devel] [PATCH 1/6] block: make bdrv_query_stats() static

2014-06-16 Thread Fam Zheng
From: Stefan Hajnoczi This function is only called from block/qapi.c. There is no need to keep it public. Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/qapi.c | 2 +- include/block/qapi.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/block/q

[Qemu-devel] [PATCH 2/6] block: acquire AioContext in qmp_query_blockstats()

2014-06-16 Thread Fam Zheng
From: Stefan Hajnoczi Make query-blockstats safe for dataplane by acquiring the BlockDriverState's AioContext. This ensures that the dataplane IOThread and the main loop's monitor code do not race. Note the assumption that acquiring the drive's BDS AioContext also protects ->file and ->backing_

[Qemu-devel] [PATCH 4/6] virtio-blk: Export request handling functions to dataplane

2014-06-16 Thread Fam Zheng
So that dataplane can use virtio_blk_handle_request and virtio_submit_multiwrite. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 10 ++ include/hw/virtio/virtio-blk.h | 9 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw

[Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-16 Thread Benjamin Herrenschmidt
Hi folks ! WARNING: The patch below is NOT intended for merging for rather obvious reasons in its current form :-) So basically, we have a problem we need to solve in qemu powerpc related to the emulated VGA, as I mentioned in an earlier mail yesterday. The core issue stems from the fact that gr

Re: [Qemu-devel] Why I advise against using ivshmem

2014-06-16 Thread Stefan Hajnoczi
On Fri, Jun 13, 2014 at 10:10 PM, Paolo Bonzini wrote: > Il 13/06/2014 15:41, Vincent JARDIN ha scritto: >> I do repeat this use case that you had removed because vhost-user does >> not solve it yet: >> - ivshmem -> framework to be generic to have shared memory for many use cases (HPC,

Re: [Qemu-devel] [PATCH v4 0/5] This series adds iotest case for IO throttling.

2014-06-16 Thread Fam Zheng
On Thu, 06/05 16:47, Fam Zheng wrote: > There is a change in qemu-io sub-commands "aio_read" and "aio_write", which > makes the aio requests accounted and the statistics reflected in blockstats. > > Note that IO throttling implementation allows overcommiting of requests, so > the > actual IO happ

Re: [Qemu-devel] [PATCH 2/4] s390-virtio-bus: move common virtio properties to virtio s390 device class

2014-06-16 Thread Ming Lei
On Tue, Jun 17, 2014 at 12:04 AM, Cornelia Huck wrote: > On Mon, 16 Jun 2014 23:40:50 +0800 > Ming Lei wrote: > >> The two common virtio features can be defined per bus, so move all >> into virtio-s390 class device to make code more clean. >> >> Suggested-by: Paolo Bonzini >> Signed-off-by: Ming

Re: [Qemu-devel] [PATCH v10 3/6] rename parse_enum_option to qapi_enum_parse and make it public

2014-06-16 Thread Hu Tao
On Sat, Jun 14, 2014 at 09:07:19PM +0200, Max Reitz wrote: > On 12.06.2014 05:54, Hu Tao wrote: > >Signed-off-by: Hu Tao > >Suggested-by: Markus Armbruster > >--- > > blockdev.c | 22 ++ > > include/qapi/util.h | 17 + > > qapi/Makefile.objs | 2 +-

Re: [Qemu-devel] [PATCH 0/7] spapr: rework memory nodes

2014-06-16 Thread Eduardo Habkost
On Mon, Jun 16, 2014 at 05:25:00PM -0700, Nishanth Aravamudan wrote: [...] > > But you seem to claim you need 3 nodes with non-contiguous IDs. In that > > case, which exactly is the guest-visible difference you expect to get > > between: > > -numa node,nodeid=0,cpus=0-7,memory=0 \ > > -numa nod

Re: [Qemu-devel] [PATCH 0/7] spapr: rework memory nodes

2014-06-16 Thread Eduardo Habkost
On Mon, Jun 16, 2014 at 05:25:00PM -0700, Nishanth Aravamudan wrote: > On 16.06.2014 [17:51:50 -0300], Eduardo Habkost wrote: > > On Mon, Jun 16, 2014 at 06:16:29PM +1000, Alexey Kardashevskiy wrote: > > > On 06/16/2014 05:53 PM, Alexey Kardashevskiy wrote: > > > > c4177479 "spapr: make sure RMA is

Re: [Qemu-devel] [PATCH 0/7] spapr: rework memory nodes

2014-06-16 Thread Nishanth Aravamudan
On 16.06.2014 [17:51:50 -0300], Eduardo Habkost wrote: > On Mon, Jun 16, 2014 at 06:16:29PM +1000, Alexey Kardashevskiy wrote: > > On 06/16/2014 05:53 PM, Alexey Kardashevskiy wrote: > > > c4177479 "spapr: make sure RMA is in first mode of first memory node" > > > introduced regression which preven

Re: [Qemu-devel] [PATCH 7/7] numa: Allow empty nodes

2014-06-16 Thread Nishanth Aravamudan
On 16.06.2014 [17:31:24 -0300], Eduardo Habkost wrote: > On Mon, Jun 16, 2014 at 05:11:40PM -0300, Eduardo Habkost wrote: > [...] > > Wait, is the node ID visible to the guest at all? I believe it is a > > QEMU-internal thing, just to allow the NUMA nodes to be ordered in the > > command-line. I wo

Re: [Qemu-devel] [PATCH 7/7] numa: Allow empty nodes

2014-06-16 Thread Nishanth Aravamudan
On 16.06.2014 [17:11:40 -0300], Eduardo Habkost wrote: > On Mon, Jun 16, 2014 at 11:49:46AM -0700, Nishanth Aravamudan wrote: > > On 16.06.2014 [13:15:00 -0300], Eduardo Habkost wrote: > > > On Mon, Jun 16, 2014 at 05:53:53PM +1000, Alexey Kardashevskiy wrote: > > > > Currently NUMA nodes must go c

Re: [Qemu-devel] Help needed testing on ppc

2014-06-16 Thread BALATON Zoltan
On Thu, 12 Jun 2014, BALATON Zoltan wrote: On Wed, 7 May 2014, Alexander Graf wrote: On 05/07/2014 05:31 PM, Tom Musta wrote: On 5/6/2014 6:17 PM, BALATON Zoltan wrote: On Tue, 6 May 2014, Tom Musta wrote: (2) Your patch makes some store instructions compliant with the most recent ISAs but th

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] mac99: Change memory layout to better match PowerMac3, 1

2014-06-16 Thread BALATON Zoltan
Ping again. This patch already missed two pull requests without getting any comments. I hope you can look at it now. Regards, BALATON Zoltan On Mon, 9 Jun 2014, BALATON Zoltan wrote: Ping! On Sat, 12 Apr 2014, BALATON Zoltan wrote: Bring the memor

Re: [Qemu-devel] [PATCH v2 14/17] target-arm: A64: Emulate the HVC insn

2014-06-16 Thread Edgar E. Iglesias
On Wed, Jun 11, 2014 at 03:14:34PM -0500, Greg Bellows wrote: > On 9 June 2014 10:04, Edgar E. Iglesias wrote: > > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/cpu.h | 1 + > > target-arm/helper-a64.c| 1 + > > target-arm/helper.c

Re: [Qemu-devel] [PATCH v2 13/17] target-arm: Use uint16_t in syndrome generators with 16bit imms

2014-06-16 Thread Edgar E. Iglesias
On Wed, Jun 11, 2014 at 10:05:35PM +0100, Peter Maydell wrote: > On 11 June 2014 20:19, Greg Bellows wrote: > > Called out possibly missing fix below. Beside it, I'm convinced this change > > is beneficial, other than maybe for readability. > > "not convinced" ? > > Personally, I don't much car

[Qemu-devel] [PATCH] add input-send-event command

2014-06-16 Thread Marcelo Tosatti
Which allows specification of absolute/relative, up/down and console parameters. Suggested by Gerd Hoffman. --- qapi-schema.json | 18 qmp-commands.hx | 59 +++ ui/input.c | 31 3 fil

Re: [Qemu-devel] [PATCH V6 25/29] qapi event: convert SPICE events

2014-06-16 Thread Eric Blake
On 06/05/2014 06:22 AM, Wenchao Xia wrote: > SPICE_INITIALIZED, SPICE_CONNECTED, SPICE_DISCONNECTED and > SPICE_MIGRATE_COMPLETED are converted in one patch, since they > use some common functions. inet_strfamily() is removed since no > more caller exist now. s/caller/callers/ > > Note that ther

Re: [Qemu-devel] [PATCH V6 24/29] qapi event: convert VNC events

2014-06-16 Thread Eric Blake
On 06/05/2014 06:22 AM, Wenchao Xia wrote: > Since VNC_CONNECTED, VNC_DISCONNECTED, VNC_INITIALIZED share some > common functions, converts them in one patch. s/converts/convert/ > > Signed-off-by: Wenchao Xia > --- > docs/qmp/qmp-events.txt | 90 -- > qap

Re: [Qemu-devel] [PATCH V6 22/29] qapi event: convert other BLOCK_JOB events

2014-06-16 Thread Eric Blake
On 06/05/2014 06:22 AM, Wenchao Xia wrote: > Since BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are > related, converts them in one patch. The block_job_event_* functions s/converts/convert/ > are used to keep encapsulation of BlockJob structure. > > Signed-off-by: Wenchao Xia > --

Re: [Qemu-devel] [PATCH V6 21/29] qapi event: convert BLOCK_IMAGE_CORRUPTED

2014-06-16 Thread Eric Blake
On 06/05/2014 06:22 AM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > block/qcow2-refcount.c | 14 -- > docs/qmp/qmp-events.txt | 22 -- > qapi-event.json | 22 ++ > 3 files changed, 30 insertions(+), 28 deletions(-) >

[Qemu-devel] [Bug 1329956] Re: multi-core FreeBSD guest hangs after warm reboot

2014-06-16 Thread Matt
I'm having this same issue. Tried with both FreeNAS (which uses FreeBSD 9), and a minimal install of FreeBSD 10. Everything seems to work great up until you try to do a warm boot. I've compiled a custom FreeBSD kernel with everything unnecessary removed, and also changed the number of CPUs assigned

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/4] AUXV Fixes for PowerPC Linux User Mode

2014-06-16 Thread Alexander Graf
On 16.06.14 18:03, Tom Musta wrote: These patches improve the fidelity of the AUXV for the Power PC user mode targets. Specifically, the cache line sizes and hardware capabilities are improved so that they more closely match what would be seen on an actual system. Thanks, applied all to ppc-

Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-16 Thread Alexander Graf
On 16.06.14 19:29, Gabriel L. Somlo wrote: This series contains a few fixes and improvements in the emulation of link auto-negotiation: - use auto-negotiation when the link is bounced externally (e.g. via set_link down/up on the qemu monitor command line). - allow mii_tool on linux

[Qemu-devel] [Bug 1329956] Re: multi-core FreeBSD guest hangs after warm reboot

2014-06-16 Thread John Nielsen
Problem also remains with CPU microcode revision 0x427 (2014-04-10). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1329956 Title: multi-core FreeBSD guest hangs after warm reboot Status in QEMU:

Re: [Qemu-devel] [PATCH 0/7] spapr: rework memory nodes

2014-06-16 Thread Eduardo Habkost
On Mon, Jun 16, 2014 at 06:16:29PM +1000, Alexey Kardashevskiy wrote: > On 06/16/2014 05:53 PM, Alexey Kardashevskiy wrote: > > c4177479 "spapr: make sure RMA is in first mode of first memory node" > > introduced regression which prevents from running guests with memoryless > > NUMA node#0 which ma

[Qemu-devel] [Bug 1329956] Re: multi-core FreeBSD guest hangs after warm reboot

2014-06-16 Thread John Nielsen
I have the same result when running Qemu built today from: commit af44da87e926ff64260b95f4350d338c4fc113ca Merge: f277015 9dbae97 Author: Peter Maydell Date: Mon Jun 16 18:26:21 2014 +0100 I also tried a 3.15 kernel to see if any recent KVM changes would help, but the problem remains. -- You

Re: [Qemu-devel] [PATCH 7/7] numa: Allow empty nodes

2014-06-16 Thread Eduardo Habkost
On Mon, Jun 16, 2014 at 05:11:40PM -0300, Eduardo Habkost wrote: [...] > Wait, is the node ID visible to the guest at all? I believe it is a > QEMU-internal thing, just to allow the NUMA nodes to be ordered in the > command-line. I would even claim that the parameter is useless and > shouldn't have

Re: [Qemu-devel] [PATCH 7/7] numa: Allow empty nodes

2014-06-16 Thread Eduardo Habkost
On Mon, Jun 16, 2014 at 11:49:46AM -0700, Nishanth Aravamudan wrote: > On 16.06.2014 [13:15:00 -0300], Eduardo Habkost wrote: > > On Mon, Jun 16, 2014 at 05:53:53PM +1000, Alexey Kardashevskiy wrote: > > > Currently NUMA nodes must go consequently and QEMU ignores nodes > > > with @nodeid bigger th

Re: [Qemu-devel] [PATCH v4 0/2] qga: Add guest-fsfreeze-freeze-list command

2014-06-16 Thread Tomoki Sekiyama
Any comments for this patch? -- Tomoki Sekiyama On 6/5/14 10:57 , "Tomoki Sekiyama" wrote: >Hi, > >This is v4 patch for qemu-ga to add functions to freeze specific file >systems >mounted in a guest. > >PATCH 1 adds a guest-fsfreeze-freeze-list command, which takes an >additional >argument to

[Qemu-devel] [PATCH v4] configure: Enable TPM by default, add --disable-tpm

2014-06-16 Thread Cole Robinson
I don't see why tpm is disabled by default: it doesn't have any external dependencies, or change default behavior. Leaving it disabled is just going to cause it to bit rot. Enable it by default, and add a --disable-tpm option. Signed-off-by: Cole Robinson --- v4: Rebase to master Previous p

Re: [Qemu-devel] [PATCH 7/7] numa: Allow empty nodes

2014-06-16 Thread Nishanth Aravamudan
On 16.06.2014 [13:15:00 -0300], Eduardo Habkost wrote: > On Mon, Jun 16, 2014 at 05:53:53PM +1000, Alexey Kardashevskiy wrote: > > Currently NUMA nodes must go consequently and QEMU ignores nodes > > with @nodeid bigger than the number of NUMA nodes in the command line. > > Why would somebody need

Re: [Qemu-devel] [PATCH 5/7] spapr: Add a helper for node0_size calculation

2014-06-16 Thread Nishanth Aravamudan
On 16.06.2014 [17:53:51 +1000], Alexey Kardashevskiy wrote: > In multiple places there is a node0_size variable calculation > which assumes that NUMA node #0 and memory node #0 are the same > things which they are not. Since we are going to change it and > do not want to change it in multiple place

Re: [Qemu-devel] [Bug 1329956] [NEW] multi-core FreeBSD guest hangs after warm reboot

2014-06-16 Thread John Nielsen
Our KVM hosts run CentOS 6 plus a custom 3.12 kernel rather than Ubuntu or Debian, so I won't be able to use the PPA directly. However, I will build and test with the latest Qemu git sources. On Jun 16, 2014, at 12:17 PM, Serge Hallyn <1329...@bugs.launchpad.net> wrote: > Hi, > > could you verif

[Qemu-devel] [Bug 1285708] Missing required logs.

2014-06-16 Thread Brad Figg
This bug is missing log files that will aid in diagnosing the problem. >From a terminal window please run: apport-collect 1285708 and then change the status of the bug to 'Confirmed'. If, due to the nature of the issue you have encountered, you are unable to run this command, please add a commen

Re: [Qemu-devel] [PATCH 0/7] spapr: rework memory nodes

2014-06-16 Thread Nishanth Aravamudan
On 16.06.2014 [18:16:29 +1000], Alexey Kardashevskiy wrote: > On 06/16/2014 05:53 PM, Alexey Kardashevskiy wrote: > > c4177479 "spapr: make sure RMA is in first mode of first memory node" > > introduced regression which prevents from running guests with memoryless > > NUMA node#0 which may happen o

Re: [Qemu-devel] [Bug 1329956] [NEW] multi-core FreeBSD guest hangs after warm reboot

2014-06-16 Thread Serge Hallyn
Hi, could you verify that you have the same result when using https://launchpad.net/~ubuntu-virt/+archive/virt-daily-upstream status: incomplete importance: medium ** Changed in: qemu Importance: Undecided => Medium ** Changed in: qemu Status: New => Incomplete -- You received th

[Qemu-devel] [Bug 1285708] Re: FreeBSD Guest crash on boot due to xsave instruction issue

2014-06-16 Thread Serge Hallyn
Thanks for reporting this bug. Given the lkml.org fix, I assume this is in fact a kernel bug, so assigning it as such. This is presumably fix-released in utopic, but SRU-able to precise and trusty's backport kernels. I'm not clearn on how that process works, so leaving it like this. ** Also aff

Re: [Qemu-devel] [PULL] ppc patch queue 2014-06-16

2014-06-16 Thread Peter Maydell
On 16 June 2014 12:31, Alexander Graf wrote: > Hi Peter, > > This is my current patch queue for ppc. This time with working make check ;). > > I also don't send the 156 individual patches along this time. It'd end up in > a massive patch bomb that nobody reads anyway and for the most part duplicat

Re: [Qemu-devel] [PATCH v2 1/4] qmp: add query-memdev

2014-06-16 Thread Eric Blake
On 06/16/2014 04:05 AM, Hu Tao wrote: > Add qmp command query-memdev to query for information > of memory devices > > Signed-off-by: Hu Tao > --- > numa.c | 84 > > qapi-schema.json | 40 +++ > qmp-comman

Re: [Qemu-devel] [PATCH 6/6] migration: catch unknown flags in ram_load

2014-06-16 Thread Eric Blake
On 06/15/2014 09:15 PM, Juan Quintela wrote: > From: Peter Lieven > > if a saved vm has unknown flags in the memory data qemu > currently simply ignores this flag and continues which > yields in an unpredictable result. > > This patch catches all unknown flags and aborts the > loading of the vm.

[Qemu-devel] [PATCH v1 3/3] e1000: signal guest on successful link auto-negotiation

2014-06-16 Thread Gabriel L. Somlo
Generate a link status change interrupt once link auto-netotiation is successfully completed. This does not affect Linux and Windows (XP and 7 tested) in any way, but is needed by the stock OS X driver (AppleIntel8254XEthernet.kext), which would otherwise fail to notice the link status change event

[Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes

2014-06-16 Thread Gabriel L. Somlo
This series contains a few fixes and improvements in the emulation of link auto-negotiation: - use auto-negotiation when the link is bounced externally (e.g. via set_link down/up on the qemu monitor command line). - allow mii_tool on linux access to all the phy registers and flags it

[Qemu-devel] [PATCH v1 1/3] e1000: emulate auto-negotiation during external link status change

2014-06-16 Thread Gabriel L. Somlo
This patch emulates auto-negotiation when the network link status is modified externally (i.e. via "set_link off/on"). Also, a couple of cleanup items regarding the PHY status register: - unset AUTONEG_COMPLETE during link_down() - set AUTONEG_COMPLETE during autoneg_timer() only if we actual

[Qemu-devel] [PATCH v1 2/3] e1000: improve auto-negotiation reporting via mii-tool

2014-06-16 Thread Gabriel L. Somlo
Using mii-tool (on F20-live), the following output is produced: SIOCGMIIREG on ens3 failed: Input/output error ens3: no autonegotiation, 1000baseT-FD flow-control, link ok The first line (SIOCGMIIREG error) is due to mii-tool's inability to read the PHY auto-negotiation expansion register. On

Re: [Qemu-devel] [PATCH] rules.mak: remove $(sort) from extract-libs

2014-06-16 Thread Peter Maydell
On 16 June 2014 15:43, Paolo Bonzini wrote: > Duplicate removal was added to extract-libs in order to avoid including > the same library multiple times into the linking command line; this could > potentially happen when using "foo.mo-libs" (which adds the library to > all components, causing it to

[Qemu-devel] [PATCH v2 1/5] qmp: add query-memory-devices command

2014-06-16 Thread Igor Mammedov
... allowing to get state of present memory devices. Currently implemented only for PCDIMMDevice. Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake --- v3: * improve PCDIMMDeviceInfo doc comments * fix conflict with numa series v2: * fix typos an json syntax in QMP example * make 'id' opt

[Qemu-devel] [PATCH v2 4/5] qmp: add query-acpi-ospm-status command

2014-06-16 Thread Igor Mammedov
... to get ACPI OSPM status reported by ACPI devices via _OST method. Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake --- qapi-schema.json | 10 ++ qmp-commands.hx | 22 ++ qmp.c| 20 3 files changed, 52 insertions(+), 0 d

[Qemu-devel] [PATCH v2 5/5] qmp: add ACPI_DEVICE_OST event handling

2014-06-16 Thread Igor Mammedov
emits event when ACPI OSPM evaluates _OST method of ACPI device. Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake --- v2: - move event description at the beginning of file to preserve alphabet ordering in file - fix example json --- docs/qmp/qmp-events.txt | 10 ++ hw/acpi/

[Qemu-devel] [PATCH v2 3/5] acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices

2014-06-16 Thread Igor Mammedov
... using TYPE_ACPI_DEVICE_IF interface. Which provides status reporting of ACPI declared memory devices Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake --- v2: - set slot-type to DIMM - take into account that 'device' field could be optional --- hw/acpi/ich9.c |7 +

[Qemu-devel] [PATCH v2 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface

2014-06-16 Thread Igor Mammedov
... it will be used to abstract generic ACPI bits from device that implements ACPI interface. ACPIOSTInfo type is used for passing-through raw _OST event/status codes reported by guest OS to a management layer. It lets management tools interpret values as specified by ACPI spec if it is interested

[Qemu-devel] [PATCH v2 0/5] ACPI memory hotplug: QMP interfaces

2014-06-16 Thread Igor Mammedov
changes since v1: * amended doc comments * fix spelling/gramar errors in commit messages this is implemented on top of PCI tree with memory hotplug and NUMA seriesi queued there: Series adds following QMP commands: - query-memory-devices - query-acpi-ospm-status and event: - ACPI_DEVICE_OST

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-16 Thread Amit Shah
On (Mon) 16 Jun 2014 [17:07:01], Greg Kurz wrote: > Hi, > > I've reworked the patch set according to Alex's last remarks. Do any of the > other maintainers have pending remarks ? Should I wait or send a v9 now ? I'm yet to go through the series; I'll get to it in a day or two. Am

Re: [Qemu-devel] Hang on reboot in FreeBSD guest on Linux KVM host

2014-06-16 Thread John Nielsen
On Jun 16, 2014, at 10:39 AM, Paolo Bonzini wrote: > Il 16/06/2014 18:09, John Nielsen ha scritto: The only substantial difference on the hardware side is the CPU. The hosts where the problem occurs use "Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz", while the hosts that don't show th

Re: [Qemu-devel] [PATCH 3/5] acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices

2014-06-16 Thread Igor Mammedov
On Mon, 16 Jun 2014 10:14:16 -0600 Eric Blake wrote: > On 06/05/2014 08:36 AM, Igor Mammedov wrote: > > ... using TYPE_ACPI_DEVICE_IF interface. > > Which provides status reporting of ACPI declared memory devices > > > > Signed-off-by: Igor Mammedov > > --- > > v2: > > - set slot-type to DIMM

Re: [Qemu-devel] Hang on reboot in FreeBSD guest on Linux KVM host

2014-06-16 Thread Paolo Bonzini
Il 16/06/2014 18:09, John Nielsen ha scritto: The only substantial difference on the hardware side is the CPU. The hosts where the problem occurs use "Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz", while the hosts that don't show the problem use the prior revision, "Intel(R) Xeon(R) CPU E5-2650 0 @

[Qemu-devel] [PATCH 4/4] fixup! pc: implement pc-dimm device abstraction

2014-06-16 Thread Igor Mammedov
fix typecheck error in DEFINE_PROP_UINT64 when building with with clang, on OS X ram_addr_t is uintptr_t with size 8 bytes but compiler still refuses to accept type_check() macro as valid. It's still fixing consequences of how ram_addr_t is defined but it's safer this way than to change ram_addr_t

[Qemu-devel] [PATCH 2/4] fixup! pc: initialize memory hotplug address space

2014-06-16 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/pc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 37344ce..73daa07 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1261,7 +1261,7 @@ FWCfgState *pc_memory_init(MachineState *machine,

[Qemu-devel] [PATCH 3/4] fixup! pc: add memory hotplug handler to PC_MACHINE

2014-06-16 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/pc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 73daa07..e993b0f 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1564,8 +1564,8 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev,

[Qemu-devel] [PATCH 0/4] memory hotplug fixups when building with clang

2014-06-16 Thread Igor Mammedov
fixes build errors and warnings introduced by memory hotplug series when building with clang Igor Mammedov (4): pc: acpi: do not hardcode preprocessor fixup! pc: initialize memory hotplug address space fixup! pc: add memory hotplug handler to PC_MACHINE fixup! pc: implement pc-dimm device

[Qemu-devel] [PATCH 1/4] pc: acpi: do not hardcode preprocessor

2014-06-16 Thread Igor Mammedov
but use one provided by environment, in addition force C style preprocessing so that 'gcc -E' or "clang -E" wouldn't ignore .dsl files. Signed-off-by: Igor Mammedov --- hw/i386/Makefile.objs |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/i386/Makefile.objs b/hw/i386

Re: [Qemu-devel] [PATCH 5/5] qmp: add ACPI_DEVICE_OST event handling

2014-06-16 Thread Eric Blake
On 06/05/2014 08:36 AM, Igor Mammedov wrote: > emmits event when ACPI OSPM evaluates _OST method s/emmits/emits/ > of ACPI device. > > Signed-off-by: Igor Mammedov > --- > v2: > - move event decription at the beginning of file s/decription/description/ (but typos in the changelog don't matter

[Qemu-devel] [Bug 584146] Re: Virtual fat breaks with -snapshot

2014-06-16 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/584146 Title: Virtual fat breaks with -snapshot Status in QEMU: Confirmed

Re: [Qemu-devel] [PATCH 2/4] s390-virtio-bus: move common virtio properties to virtio s390 device class

2014-06-16 Thread Ming Lei
Hi Cornelia, Thanks for your test. On Tue, Jun 17, 2014 at 12:04 AM, Cornelia Huck wrote: > On Mon, 16 Jun 2014 23:40:50 +0800 > Ming Lei wrote: > >> The two common virtio features can be defined per bus, so move all >> into virtio-s390 class device to make code more clean. >> >> Suggested-by:

Re: [Qemu-devel] [PATCH 4/5] qmp: add query-acpi-ospm-status command

2014-06-16 Thread Eric Blake
On 06/05/2014 08:36 AM, Igor Mammedov wrote: > ... to get ACPI OSPM status reported by ACPI devices > via _OST method. > > Signed-off-by: Igor Mammedov > --- > qapi-schema.json | 10 ++ > qmp-commands.hx | 22 ++ > qmp.c| 20 >

Re: [Qemu-devel] [PATCH 7/7] numa: Allow empty nodes

2014-06-16 Thread Eduardo Habkost
On Mon, Jun 16, 2014 at 05:53:53PM +1000, Alexey Kardashevskiy wrote: > Currently NUMA nodes must go consequently and QEMU ignores nodes > with @nodeid bigger than the number of NUMA nodes in the command line. Why would somebody need a NUMA node with nodeid bigger than the number of NUMA nodes? NU

  1   2   3   4   >