Re: [Qemu-devel] [PATCH 00/25] qemu gtk ui overhaul

2014-05-21 Thread Paolo Bonzini
Il 22/05/2014 08:24, Gerd Hoffmann ha scritto: I suspect this is the menu bar. Current code tries to hide it by forcing the widget size to 0x0. In gtk2 this results in a small white line at the top of the screen, probably because the minimum widget size in gtk is 1x1. In gtk3 this doesn't work

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-21 Thread Alexey Kardashevskiy
On 05/21/2014 10:42 PM, Alexey Kardashevskiy wrote: > On 05/21/2014 08:35 PM, Alexander Graf wrote: >> >> On 21.05.14 12:13, Alexey Kardashevskiy wrote: >>> On 05/21/2014 07:50 PM, Alexander Graf wrote: On 21.05.14 11:33, Alexey Kardashevskiy wrote: > On 05/21/2014 07:13 PM, Alexander Graf

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-21 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 08:44:41AM +0200, Gerd Hoffmann wrote: > Hi, > > > > Another useful thing would be to not create the xen platform device in > > > case > > > "-nodefaults" was specified on the command line (that switch turns off a > > > bunch > > > of other devices present by default: v

Re: [Qemu-devel] [PATCH v2 1/7] iotests: Allow out-of-tree run

2014-05-21 Thread Fam Zheng
On Tue, 05/20 22:23, Max Reitz wrote: > As out-of-tree builds are preferred for qemu, running the qemu-iotests > in that out-of-tree build should be supported as well. To do so, a > symbolic link has to be created pointing to the check script in the > source directory. That script will check whethe

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-21 Thread Gerd Hoffmann
Hi, > > Another useful thing would be to not create the xen platform device in case > > "-nodefaults" was specified on the command line (that switch turns off a > > bunch > > of other devices present by default: vga, nic, cdrom, ...). > > Currently looks 'xen-platform' itself can't be created,

[Qemu-devel] [PATCH 2/2] dataplane: Support VIRTIO_BLK_T_SCSI_CMD

2014-05-21 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 46a6824..6a66196 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/bloc

[Qemu-devel] [PATCH 0/2] dataplane: Enable "scsi=on"

2014-05-21 Thread Fam Zheng
This makes the SG_IO code of non-dataplane available to dataplane, so that dataplane can use to allow scsi=on. Fam Fam Zheng (2): virtio-blk: Factor out virtio_blk_handle_scsi_req from virtio_blk_handle_scsi dataplane: Support VIRTIO_BLK_T_SCSI_CMD hw/block/dataplane/virtio-blk.c | 19

[Qemu-devel] [PATCH 1/2] virtio-blk: Factor out virtio_blk_handle_scsi_req from virtio_blk_handle_scsi

2014-05-21 Thread Fam Zheng
The common logic to process a scsi request in a VirtQueueElement is extracted to a function to share with dataplane. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 77 ++ include/hw/virtio/virtio-blk.h | 3 ++ 2 files changed, 43 insertions

Re: [Qemu-devel] [PATCH 00/25] qemu gtk ui overhaul

2014-05-21 Thread Gerd Hoffmann
Hi, > I noticed that some issues with the old code still exist: when "Show > tabs" is enabled and disabled again, QEMU adds some black scan lines at > the top of the VGA screen. This can be easily reproduced. Easily fixed, was just a missing "gd_update_windowsize" call. > Another small > probl

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-21 Thread Chen, Tiejun
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, May 22, 2014 1:40 PM > To: Chen, Tiejun > Cc: Anthony PERARD; Daniel P. Berrange; peter.mayd...@linaro.org; > xen-de...@lists.xensource.com; m...@redhat.com; > stefano.stabell...@eu.citrix.com; Kay, Alle

Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking

2014-05-21 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, May 22, 2014 1:44 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking > > > > /* lookup */ > > > -if (port_offset) > > >

Re: [Qemu-devel] [RFC] How to deal with the conflict between DE keymap and qemu console ?

2014-05-21 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, May 22, 2014 2:00 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org > Subject: Re: [RFC] How to deal with the conflict between DE keymap and qemu > console ? > > Hi, > > > > Works perfectly fine fo

Re: [Qemu-devel] [RFC] How to deal with the conflict between DE keymap and qemu console ?

2014-05-21 Thread Gerd Hoffmann
Hi, > > Works perfectly fine for me. > > What vnc client is this? > > > I tested two kinds of vnc clients: > 1) VNC Viewer Free Edition 4.1.2 > 2) TightVNC Viewer for Windows Version 2.6.4 Ah, windows vnc clients. I've tested with linux. I'll have a look. Do you have download links for me?

Re: [Qemu-devel] [PATCH] vnc: refuse to set a password with VNC_AUTH_NONE

2014-05-21 Thread Gerd Hoffmann
On Do, 2014-05-22 at 04:05 +, Gonglei (Arei) wrote: > > -Original Message- > > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > > Behalf Of Gerd Hoffmann > > Sent: Wednesday, May 21, 2014 6:54 PM > > To:

[Qemu-devel] [PATCH] inet_listen_opts: add error checking

2014-05-21 Thread Gerd Hoffmann
Don't use atoi() function which doesn't detect errors, switch to strtol and error out on failures. Also add a range check while being at it. Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbruster --- util/qemu-sockets.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-

Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking

2014-05-21 Thread Gerd Hoffmann
> > /* lookup */ > > -if (port_offset) > > -snprintf(port, sizeof(port), "%d", atoi(port) + port_offset); > > +if (port_offset) { > > +unsigned long long baseport; > > unsigned long long is not necessary, unsigned long is enough. > > > +if (parse_uint_full(por

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-21 Thread Gerd Hoffmann
Hi, > > According to our discussions, I realize we may have some plans or policies > > dedicated to how to assign devfn, but to support GFX passthrough for XEN, I > > think currently it may be a better solution to adopt #1 simply like this: > > > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_pi

Re: [Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-21 Thread Alexey Kardashevskiy
On 05/22/2014 08:11 AM, Alexander Graf wrote: > > On 21.05.14 16:21, Alexey Kardashevskiy wrote: >> At the moment only 4K pages are supported by sPAPRTCETable. Since sPAPR >> spec allows other page sizes and we are going to implement them, we need >> page size to be configrable. >> >> This adds @p

Re: [Qemu-devel] [PATCH] vnc: refuse to set a password with VNC_AUTH_NONE

2014-05-21 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Gerd Hoffmann > Sent: Wednesday, May 21, 2014 6:54 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann; Anthony Liguori > Subject

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-21 Thread Alexey Kardashevskiy
On 05/21/2014 11:23 PM, Alexander Graf wrote: > > On 21.05.14 14:30, Alexey Kardashevskiy wrote: >> On 05/21/2014 08:44 PM, Alexander Graf wrote: >>> On 21.05.14 08:20, Alexey Kardashevskiy wrote: This moves SPR initialization to helper functions. Signed-off-by: Alexey Kardashevskiy

Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking

2014-05-21 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Gerd Hoffmann > Sent: Wednesday, May 21, 2014 6:53 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann > Subject: [Qemu-devel] [P

Re: [Qemu-devel] [PATCH 1/9] target-ppc: Rename MMCR0/1 contants

2014-05-21 Thread Alexey Kardashevskiy
On 05/22/2014 02:55 AM, Tom Musta wrote: > On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote: >> MMCR0 and MMCR1 have different numbers for 32 and 64 bit POWERPC. >> We are going to support 64bit versions too so let's rename 32bit ones >> to avoid confusion. >> >> 604 uses same SPR number for MMCR0

Re: [Qemu-devel] [PATCH 7/9] KVM: target-ppc: Enable transactional state migration

2014-05-21 Thread Alexey Kardashevskiy
On 05/22/2014 04:11 AM, Tom Musta wrote: > On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote: >> This adds migration support for registers saved before transaction started. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> target-ppc/cpu.h | 19 +++ >> target-ppc/kvm.c |

Re: [Qemu-devel] [RFC] How to deal with the conflict between DE keymap and qemu console ?

2014-05-21 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Wednesday, May 21, 2014 8:25 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org > Subject: Re: [RFC] How to deal with the conflict between DE keymap and qemu > console ? > > On Mi, 2014-05-21 at 07:33 +, Gon

Re: [Qemu-devel] [RFC 0/3] cpu: add device_add foo-x86_64-cpu support

2014-05-21 Thread chen.fan.f...@cn.fujitsu.com
Hi, I think if we want to use 'device/device_add' to implement CPU, we must do some check before qemu_init_vcpu(). how can we to do that? Thanks, Chen On Tue, 2014-05-13 at 18:08 +0800, Chen Fan wrote: > this patches tried to make cpu hotplug with device_add, > and made -device foo-x86_64-cp

Re: [Qemu-devel] [PATCH v3 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-21 Thread Edgar E. Iglesias
On Wed, May 21, 2014 at 08:30:30PM +0100, Peter Maydell wrote: > On 19 May 2014 10:22, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Hi, > > > > I've been doing some work on modeling parts of EL2 and 3 + some of > > the system-wide virtualization features for ARMv8. A lot is miss

Re: [Qemu-devel] [PATCH v3 21/22] RFC: target-arm: A32: Use get_mem_index for load/stores

2014-05-21 Thread Edgar E. Iglesias
On Wed, May 21, 2014 at 08:27:52PM +0100, Peter Maydell wrote: > On 19 May 2014 10:23, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Avoid using IS_USER directly as the MMU-idx to simplify future > > changes to the MMU layout. > > > > Signed-off-by: Edgar E. Iglesias > > Review

Re: [Qemu-devel] [PATCH v3 19/22] target-arm: A64: Register VBAR_EL2

2014-05-21 Thread Edgar E. Iglesias
On Wed, May 21, 2014 at 08:22:27PM +0100, Peter Maydell wrote: > On 19 May 2014 10:23, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > > @@ -2356,6 +2370,12 @@ void register_cp_regs_for_features(ARMCPU *cpu) > > } > > if (arm_feature

Re: [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-21 Thread Edgar E. Iglesias
On Wed, May 21, 2014 at 08:10:53PM +0100, Peter Maydell wrote: > On 19 May 2014 10:22, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Adds support for ERET to Aarch64 EL2 and 3. > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/op_helper.c | 10 +- > > 1 fi

Re: [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-21 Thread Edgar E. Iglesias
On Wed, May 21, 2014 at 08:20:20PM +0100, Peter Maydell wrote: > On 19 May 2014 10:22, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Adds support for ERET to Aarch64 EL2 and 3. > > "AArch64". Also "to" here is ambiguous. The ARM ARM tries to Changed to AArch64. > keep the term

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-21 Thread Chen, Tiejun
Just ping, any concern about this? Thanks Tiejun > -Original Message- > From: qemu-devel-bounces+tiejun.chen=intel@nongnu.org > [mailto:qemu-devel-bounces+tiejun.chen=intel@nongnu.org] On Behalf Of > Chen, Tiejun > Sent: Wednesday, May 21, 2014 3:08 PM > To: Gerd Hoffmann; Anthony

Re: [Qemu-devel] [PATCH 2/2] target-mips: implement UserLocal Register

2014-05-21 Thread James Hogan
On Friday 16 May 2014 20:13:34 Petar Jovanovic wrote: > diff --git a/target-mips/cpu.h b/target-mips/cpu.h > index 6c2014e..bb18fb8 100644 > --- a/target-mips/cpu.h > +++ b/target-mips/cpu.h > @@ -227,6 +227,7 @@ struct CPUMIPSState { > target_ulong CP0_EntryLo0; > target_ulong CP0_EntryL

[Qemu-devel] Problem with qemu . . . bug id 1320030

2014-05-21 Thread Tim Dawson
Folks - I have been having a problem getting a usable qemu-2.0.0 (or 1.7.1, or current GIT for that matter) build under slackware 14.1. For some reason, the inter-thread communication hangs when built on this OS distro, and display hangs in virt-manager as well as the gtk display in qemu, ma

Re: [Qemu-devel] [PATCH 2/2] target-mips: implement UserLocal Register

2014-05-21 Thread James Hogan
Hi Petar, On Friday 16 May 2014 20:13:34 Petar Jovanovic wrote: > From: Petar Jovanovic > > From MIPS documentation (Volume III): > > UserLocal Register (CP0 Register 4, Select 2) > Compliance Level: Recommended. > > The UserLocal register is a read-write register that is not interpreted by >

Re: [Qemu-devel] [PATCH v3 15/22] target-arm: A64: Forbid ERET to unimplemented ELs

2014-05-21 Thread Edgar E. Iglesias
On Wed, May 21, 2014 at 08:06:32PM +0100, Peter Maydell wrote: > On 19 May 2014 10:22, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Check for EL2 support before returning to it. > > > > Reviewed-by: Peter Crosthwaite > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm

Re: [Qemu-devel] [PATCH v3 09/22] target-arm: A64: Introduce aarch64_banked_spsr_index()

2014-05-21 Thread Edgar E. Iglesias
On Wed, May 21, 2014 at 08:01:54PM +0100, Peter Maydell wrote: > On 19 May 2014 10:22, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add aarch64_banked_spsr_index(), used to map an Exception Level > > to an index in the banked_spsr array. > > > > diff --git a/target-arm/op_helper

Re: [Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-21 Thread Alexey Kardashevskiy
On 05/22/2014 08:11 AM, Alexander Graf wrote: > > On 21.05.14 16:21, Alexey Kardashevskiy wrote: >> At the moment only 4K pages are supported by sPAPRTCETable. Since sPAPR >> spec allows other page sizes and we are going to implement them, we need >> page size to be configrable. >> >> This adds @p

Re: [Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-21 Thread Alexander Graf
On 21.05.14 16:21, Alexey Kardashevskiy wrote: At the moment only 4K pages are supported by sPAPRTCETable. Since sPAPR spec allows other page sizes and we are going to implement them, we need page size to be configrable. This adds @page_shift into sPAPRTCETable and replaces SPAPR_TCE_PAGE_SHIFT

Re: [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias()

2014-05-21 Thread Paolo Bonzini
Il 21/05/2014 22:22, Stefan Hajnoczi ha scritto: Sometimes an object needs to present a property which is actually on another object, or it needs to provide an alias name for an existing property. Examples: a.foo -> b.foo a.old_name -> a.new_name The new object_property_add_alias() API allo

Re: [Qemu-devel] [PATCH 7/9] spapr_iommu: Get rid of window_size in sPAPRTCETable

2014-05-21 Thread Alexander Graf
On 21.05.14 16:21, Alexey Kardashevskiy wrote: This removes window_size as it is basically a copy of nb_table shifted by SPAPR_TCE_PAGE_SHIFT. As new dynamic DMA windows are going to support windows as big as the entire RAM and this number will be bigger that 32 capacity, we will have to do some

Re: [Qemu-devel] [PATCH 4/7] virtio-blk: use aliases instead of duplicate qdev properties

2014-05-21 Thread Paolo Bonzini
Il 21/05/2014 22:22, Stefan Hajnoczi ha scritto: virtio-blk-pci, virtio-blk-s390, and virtio-blk-ccw all duplicate the qdev properties of their VirtIOBlock child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Us

Re: [Qemu-devel] [PATCH v2] spapr_iommu: Enable multiple TCE requests

2014-05-21 Thread Alexander Graf
On 21.05.14 18:03, Alexey Kardashevskiy wrote: On 05/22/2014 01:23 AM, Alexey Kardashevskiy wrote: Currently only single TCE entry per request is supported (H_PUT_TCE). However PAPR+ specification allows multiple entry requests such as H_PUT_TCE_INDIRECT and H_STUFF_TCE. Having less transitions

[Qemu-devel] KVM call agenda for 2014-05-27

2014-05-21 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Thanks, Juan. Call details: 15:00 CEST 13:00 UTC 09:00 EDT Every two weeks If you need phone number details, contact me privately.

[Qemu-devel] [PATCH 3/7] virtio-blk: move x-data-plane qdev property to virtio-blk.h

2014-05-21 Thread Stefan Hajnoczi
Move the x-data-plane property. Originally it was outside since not every transport may wish to support dataplane. But that makes little sense when we have a dedicated CONFIG_VIRTIO_BLK_DATA_PLANE ifdef already. This move makes it easier to switch to property aliases in the next patch. Signed-o

Re: [Qemu-devel] [PATCH 00/25] qemu gtk ui overhaul

2014-05-21 Thread Stefan Weil
Am 21.05.2014 10:43, schrieb Gerd Hoffmann: > Hi, > > I'm trying to put the qemu gtk ui into shape. Fixing a bunch of > issues we have, and also make it ready for multihead support. > > Git tree is here: > git://git.kraxel.org/qemu rebase/ui-gtk-next > > please review, > Gerd > Hi Ger

[Qemu-devel] [PATCH 7/7] virtio-blk: move qdev properties into virtio-blk.c

2014-05-21 Thread Stefan Hajnoczi
There is no need to make DEFINE_VIRTIO_BLK_PROPERTIES() public. Inline it into virtio-blk.c so it cannot be used by mistake from other source files. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 12 +++- include/hw/virtio/virtio-blk.h | 23 ---

[Qemu-devel] [PATCH 2/7] virtio-blk: avoid qdev property definition duplication

2014-05-21 Thread Stefan Hajnoczi
It becomes unwiedly to duplicate all virtio-blk qdev property definitions due to an #ifdef. The C preprocessor syntax makes it a little hard to resolve this cleanly but we can extract the #ifdef and call a macro it defines later. Avoiding duplication is important since it will only get worse when

[Qemu-devel] [PATCH 6/7] virtio: fix virtio-blk child refcount in transports

2014-05-21 Thread Stefan Hajnoczi
object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-blk child is not finalized! Drop our reference

[Qemu-devel] [PATCH 5/7] virtio-blk: drop virtio_blk_set_conf()

2014-05-21 Thread Stefan Hajnoczi
This function is no longer used since parent objects now use child aliases to set the VirtIOBlkConf directly. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 6 -- include/hw/virtio/virtio-blk.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/hw/block/virtio-blk.c b

Re: [Qemu-devel] [PATCH 07/20] iscsi: Handle failure for potentially large allocations

2014-05-21 Thread Paolo Bonzini
Il 21/05/2014 18:28, Kevin Wolf ha scritto: Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the iscsi block driver. Signed-

[Qemu-devel] [PATCH 4/7] virtio-blk: use aliases instead of duplicate qdev properties

2014-05-21 Thread Stefan Hajnoczi
virtio-blk-pci, virtio-blk-s390, and virtio-blk-ccw all duplicate the qdev properties of their VirtIOBlock child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward property access

[Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias()

2014-05-21 Thread Stefan Hajnoczi
Sometimes an object needs to present a property which is actually on another object, or it needs to provide an alias name for an existing property. Examples: a.foo -> b.foo a.old_name -> a.new_name The new object_property_add_alias() API allows objects to alias a property on another object.

[Qemu-devel] [PATCH 0/7] virtio-blk: use alias properties in transport devices

2014-05-21 Thread Stefan Hajnoczi
Thanks for the feedback on the RFC. This time around the alias property is implemented at the QOM property level instead of at the qdev property level. The virtio transport/device split is broken as follows: 1. The virtio-blk device is never finalized because the transport devices (virtio-blk

Re: [Qemu-devel] [PATCH v3 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-21 Thread Peter Maydell
On 19 May 2014 10:22, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Hi, > > I've been doing some work on modeling parts of EL2 and 3 + some of > the system-wide virtualization features for ARMv8. A lot is missing > but I've got a series with enough to for example run KVM A64 guests > o

Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command

2014-05-21 Thread Tomoki Sekiyama
Hi Eric, thank you for the comments. On 5/20/14 18:46 , "Eric Blake" wrote: >On 05/20/2014 04:01 PM, Tomoki Sekiyama wrote: >> The patch below is for the command to get filesystems list. >> >> === >> From: Tomoki Sekiyama > >You'll want to resend it as a series of patches as a top-level thread

Re: [Qemu-devel] [PATCH v3 21/22] RFC: target-arm: A32: Use get_mem_index for load/stores

2014-05-21 Thread Peter Maydell
On 19 May 2014 10:23, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Avoid using IS_USER directly as the MMU-idx to simplify future > changes to the MMU layout. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Peter Maydell I think this makes sense; the bits involving the ldrt/strt

Re: [Qemu-devel] [PATCH v3 19/22] target-arm: A64: Register VBAR_EL2

2014-05-21 Thread Peter Maydell
On 19 May 2014 10:23, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > @@ -2356,6 +2370,12 @@ void register_cp_regs_for_features(ARMCPU *cpu) > } > if (arm_feature(env, ARM_FEATURE_EL2)) { > define_arm_cp_regs(cpu, v8_el2_cp_reginfo)

Re: [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-21 Thread Peter Maydell
On 19 May 2014 10:22, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Adds support for ERET to Aarch64 EL2 and 3. "AArch64". Also "to" here is ambiguous. The ARM ARM tries to keep the terminology straight to avoid confusion: exceptions are "taken from ELx" and "taken to ELx"; we "return

Re: [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-21 Thread Peter Maydell
On 19 May 2014 10:22, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Adds support for ERET to Aarch64 EL2 and 3. > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/op_helper.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/target-arm/op_helper

Re: [Qemu-devel] [PATCH v3 15/22] target-arm: A64: Forbid ERET to unimplemented ELs

2014-05-21 Thread Peter Maydell
On 19 May 2014 10:22, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Check for EL2 support before returning to it. > > Reviewed-by: Peter Crosthwaite > Signed-off-by: Edgar E. Iglesias > --- > target-arm/op_helper.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-)

Re: [Qemu-devel] [PATCH v3 09/22] target-arm: A64: Introduce aarch64_banked_spsr_index()

2014-05-21 Thread Peter Maydell
On 19 May 2014 10:22, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add aarch64_banked_spsr_index(), used to map an Exception Level > to an index in the banked_spsr array. > > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c > index f120b02..c05a839 100644 > --- a/target-ar

Re: [Qemu-devel] [PATCH 3/7] monitor: Add migrate_set_capability completion.

2014-05-21 Thread Dr. David Alan Gilbert
* Hani Benhabiles (kroo...@gmail.com) wrote: > Signed-off-by: Hani Benhabiles > --- > hmp-commands.hx | 1 + > hmp.h | 2 ++ > monitor.c | 21 + > 3 files changed, 24 insertions(+) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 45e1763..919af6e 1

[Qemu-devel] [PATCH v2 3/3] tests: e1000: test additional device IDs

2014-05-21 Thread Gabriel L. Somlo
Update e1000-test.c to check all currently supported devices. Suggested-by: Andreas Färber Signed-off-by: Gabriel Somlo --- tests/e1000-test.c | 33 ++--- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/tests/e1000-test.c b/tests/e1000-test.c index a8b

[Qemu-devel] [PATCH v2 1/3] e1000: avoid relying on device id (and soon, QOM) on data path

2014-05-21 Thread Gabriel L. Somlo
Introduce "is_8257x" boolean flag to E1000State, and set it during pci_e1000_init(), to avoid having to dynamically figure out device_id during set_interrupt_cause(). This will come in handy once we have a wider range of possible device IDs, and begin using QOM. Suggested-by: Michael S. Tsirkin S

[Qemu-devel] [PATCH v2 0/3] e1000: allow model/device_id selection on command line

2014-05-21 Thread Gabriel L. Somlo
This started out as a single patch (now patch 2/3): Allow selection of different card models from the qemu command line, to better accomodate a wider range of guests. New in v2: - moved check for 8257x out of the way of QOM, as suggested by Michael (patch 1/3) - resolved "Signed

[Qemu-devel] [PATCH v2 2/3] e1000: allow command-line selection of card model

2014-05-21 Thread Gabriel L. Somlo
Allow selection of different card models from the qemu command line, to better accomodate a wider range of guests. Signed-off-by: Romain Dolbeau Signed-off-by: Gabriel Somlo --- hw/net/e1000.c | 95 -- 1 file changed, 79 insertions(+), 16

Re: [Qemu-devel] [PATCH 7/9] KVM: target-ppc: Enable transactional state migration

2014-05-21 Thread Tom Musta
On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote: > This adds migration support for registers saved before transaction started. > > Signed-off-by: Alexey Kardashevskiy > --- > target-ppc/cpu.h | 19 +++ > target-ppc/kvm.c | 38 ++ > tar

[Qemu-devel] [Bug 1320030] Re: Qemu 2.0.0 display hangs with display=gtk or virt-manager

2014-05-21 Thread tadawson
Note: virt-manager fails if qemu compiled with -disable-gtk as well. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1320030 Title: Qemu 2.0.0 display hangs with display=gtk or virt-manager Status i

Re: [Qemu-devel] [PATCH 5/9] target-ppc: Add POWER8 SPRs

2014-05-21 Thread Tom Musta
On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote: > This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/ > EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs. > > This adds MMCR2/FSCR/MMCRS SPRs. > > Signed-off-by: Alexey Kardashevskiy > --- > target-ppc/cpu.h| 15 ++ >

[Qemu-devel] [Bug 1320030] Re: Qemu 2.0.0 with display=gtk hangs

2014-05-21 Thread tadawson
I note that this also occurs with virt-manager running the non-spice console. (The spice console is another issue . . . but not one with qemu . . . ) so the scope of this appears to now be inter-thread communication and *NOT* neccessarily GTK, but is far larger in scope than initially thought. **

[Qemu-devel] [Bug 1321028] Re: qemu-system-ppc : file systems are not shutting down clean

2014-05-21 Thread joh...@servergy.com
I am thinking since the VM hasn't terminated due to defect 1317603 , qemu-system-ppc has to be terminated with killwhich is not kill -9 ; I could see some inconsistencies with virtio device file not being sync'ed ; but the VM did unmount it; -- You received this bug notification because you

[Qemu-devel] [Bug 1321028] Re: qemu-system-ppc : file systems are not shutting down clean

2014-05-21 Thread joh...@servergy.com
/var/log/syslog attached as syslog.onboot when file system is dirty ; Since the VM terminated ; the device should have been umounted ; ** Attachment added: "syslog.onboot" https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1321028/+attachment/4116987/+files/syslog.onboot -- You received

[Qemu-devel] [Bug 1321028] Re: qemu-system-ppc : file systems are not shutting down clean

2014-05-21 Thread joh...@servergy.com
1. ssgyboot-break has no effect in the VM kernel; It is only used by jade-initrd-2.0.bin ; kernel cmdline: [0.00] pcpu-alloc: s28800 r8192 d16256 u53248 alloc=13*4096 [0.00] pcpu-alloc: [0] 0 [0.00] Built 1 zonelists in Zone order, mobility grouping on. Total pag es:

[Qemu-devel] [PATCH 01/20] block: Introduce qemu_try_blockalign()

2014-05-21 Thread Kevin Wolf
This function returns NULL instead of aborting when an allocation fails. Signed-off-by: Kevin Wolf --- block.c | 5 + include/block/block.h | 1 + include/qemu/osdep.h | 1 + util/oslib-posix.c| 16 ++-- util/oslib-win32.c| 9 +++-- 5 files changed,

[Qemu-devel] [PATCH 08/20] nfs: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the nfs block driver. Signed-off-by: Kevin Wolf --- block/nfs.c | 6 +-

[Qemu-devel] [PATCH 03/20] bochs: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the bochs block driver. Signed-off-by: Kevin Wolf --- block/bochs.c | 6 +++

[Qemu-devel] [PATCH 13/20] raw-posix: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the raw-posix block driver. Signed-off-by: Kevin Wolf --- block/raw-posix.c

Re: [Qemu-devel] [PATCH 4/9] target-ppc: Refactor init_proc_POWER8

2014-05-21 Thread Tom Musta
On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote: > This duplicates code of init_proc_POWER7() in init_proc_POWER8() as > there will be registers implemented in POWER7 and missing in POWER8 > so we need separate init functions for POWER7 and POWER8. > > Signed-off-by: Alexey Kardashevskiy > --- >

Re: [Qemu-devel] [PATCH 3/9] target-ppc: Add POWER7 SPRs

2014-05-21 Thread Tom Musta
On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote: > This adds TIR/SIAR/SDAR/MMCRA/MMCR0/MMCR1. > > This redefines UMMCRA (was MCCRA) and defines hypv version of if. > > Signed-off-by: Alexey Kardashevskiy > --- > target-ppc/cpu.h| 10 +- > target-ppc/translate_init.c | 41 ++

Re: [Qemu-devel] [PATCH 1/9] target-ppc: Rename MMCR0/1 contants

2014-05-21 Thread Tom Musta
On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote: > MMCR0 and MMCR1 have different numbers for 32 and 64 bit POWERPC. > We are going to support 64bit versions too so let's rename 32bit ones > to avoid confusion. > > 604 uses same SPR number for MMCR0 so it is included in this patch too. I'm not s

[Qemu-devel] [Bug 1321028] Re: qemu-system-ppc : file systems are not shutting down clean

2014-05-21 Thread Serge Hallyn
Can you explain what "ssgyboot=break" tells the kernel to do? Could you upload the guest's /var/log/syslog after reboot? Please show echo $? immediately after the qemu-system-ppc command has exited? ** Also affects: qemu Importance: Undecided Status: New ** Changed in: qemu (Ubuntu)

[Qemu-devel] [PATCH 05/20] curl: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the curl block driver. Signed-off-by: Kevin Wolf --- block/curl.c | 8 +

[Qemu-devel] [PATCH 16/20] vdi: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the vdi block driver. Signed-off-by: Kevin Wolf --- block/vdi.c | 20 ++

Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-21 Thread Peter Maydell
On 21 May 2014 17:33, Sergey Fedorov wrote: > On 21.05.2014 20:14, Christopher Covington wrote: >> On 05/21/2014 10:46 AM, Peter Maydell wrote: >>> (Also I'm not sure what the semantics of -kernel should be for >>> TZ-supporting CPUs -- boot the kernel in S or NS ?) >> While Linux works in secure

Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-21 Thread Sergey Fedorov
On 21.05.2014 20:41, Peter Maydell wrote: > If we want to have -kernel boot in NS then yes, the bootloader > stub is the place that code should go. > > The difficulty with -kernel being NS is that some guest kernels > for some boards may be assuming that they will run in secure state > and can dire

[Qemu-devel] [PATCH 19/20] vpc: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the vpc block driver. Signed-off-by: Kevin Wolf --- block/vpc.c | 6 +-

[Qemu-devel] [PATCH 12/20] qed: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the qed block driver. Signed-off-by: Kevin Wolf --- block/qed-check.c | 7 +

[Qemu-devel] [PATCH 17/20] vhdx: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the vhdx block driver. Signed-off-by: Kevin Wolf --- block/vhdx-log.c | 6

[Qemu-devel] [PATCH 11/20] qcow2: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the qcow2 block driver. Signed-off-by: Kevin Wolf --- block/qcow2-cache.c

[Qemu-devel] [PATCH 15/20] rbd: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the rbd block driver. Signed-off-by: Kevin Wolf --- block/rbd.c | 5 -

[Qemu-devel] [PATCH 14/20] raw-win32: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the raw-win32 block driver. Signed-off-by: Kevin Wolf --- block/win32-aio.c

[Qemu-devel] [PATCH 10/20] qcow1: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the qcow1 block driver. Signed-off-by: Kevin Wolf --- block/qcow.c | 29 +++

[Qemu-devel] [PATCH 06/20] dmg: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the dmg block driver. Signed-off-by: Kevin Wolf --- block/dmg.c | 11 ++

Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-21 Thread Sergey Fedorov
On 21.05.2014 20:14, Christopher Covington wrote: > Hi Peter, > > On 05/21/2014 10:46 AM, Peter Maydell wrote: >> On 13 May 2014 17:15, Fabian Aggeler wrote: >>> From: Svetlana Fedoseeva >>> >>> Define Security Extensions CPU feature. Set that feature for relevant CPUs. >> This is potentially tri

[Qemu-devel] [PATCH 09/20] parallels: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the parallels block driver. Signed-off-by: Kevin Wolf --- block/parallels.c

[Qemu-devel] [PATCH 07/20] iscsi: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the iscsi block driver. Signed-off-by: Kevin Wolf --- block/iscsi.c | 16 ++

[Qemu-devel] [PATCH 20/20] mirror: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the mirror block job. Signed-off-by: Kevin Wolf --- block/mirror.c | 7

[Qemu-devel] [PATCH 02/20] block: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses bounce buffer allocations in block.c. While at it, convert bdrv_commit() from plain g_malloc() to

[Qemu-devel] [PATCH 18/20] vmdk: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses the allocations in the vmdk block driver. Signed-off-by: Kevin Wolf --- block/vmdk.c | 12

[Qemu-devel] [PATCH 00/20] block: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
A not too small part of the recent CVEs were DoS scenarios by letting qemu abort with too large memory allocations. We generally "fixed" these cases by setting some limits on values read from image files that influence the size of allocations. Because we still need to allow reading large images, t

  1   2   3   4   >