[Qemu-devel] [Bug 1315257] [NEW] QEMU get black screen when adjust resolution in full screen mode.

2014-05-01 Thread James
Public bug reported: Description: QEMU cause X11 error when adjust resolution in full screen mode or start QEMU with "-full-screen". Additional info: * host OS infomation Archlinux 64bit * gest OS infomation Windows XP SP3 32bit * Archlinux package version(s) qemu 1.7.1-1 cinnamon 2.2.3-

Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers

2014-05-01 Thread Alexey Kardashevskiy
On 03/27/2014 01:35 AM, Paolo Bonzini wrote: > Il 26/03/2014 15:23, Alexey Kardashevskiy ha scritto: >>> Alex did not pick it up. And I use this patch in 2 of my series >>> (client-arch-support and power8 migration patch) so I would really love not >>> to post it twice. This does not need to go to

[Qemu-devel] [Bug 1315159] [NEW] Cannot invoke qemu-kvm with spice paramenter renderer

2014-05-01 Thread Phil Allred
Public bug reported: I'm running qemu-kvm version 2.0.0 on Fedora 20, spice server version 0.12.4-3. The spice user manual states that I can specify the type of rendering to be done by the client by providing: renderer= However, when I invoke qemu-kvm with the following option: -spice port=59

Re: [Qemu-devel] [Fwd: [PATCH 10/22] nfs: implement .bdrv_detach/attach_aio_context()]

2014-05-01 Thread Peter Lieven
Hi Stefan, for some reason I was not CC'ed in this email. Is there something wrong with the maintainer info? > Original Message > Subject: [Qemu-devel] [PATCH 10/22] nfs: implement > .bdrv_detach/attach_aio_context() > From:"Stefan Ha

Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Peter Lieven
Stefan Hajnoczi wrote: > Drop the assumption that we're using the main AioContext for Linux > AIO. Convert qemu_aio_set_fd_handler() to aio_set_fd_handler() and > timer_new_ms() to aio_timer_new(). > > The .bdrv_detach/attach_aio_context() interfaces also need to be > implemented to move the fd an

Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Peter Lieven
Am 01.05.2014 um 16:54 schrieb Stefan Hajnoczi : > Drop the assumption that we're using the main AioContext for Linux > AIO. Convert qemu_aio_set_fd_handler() to aio_set_fd_handler() and > timer_new_ms() to aio_timer_new(). > > The .bdrv_detach/attach_aio_context() interfaces also need to be >

Re: [Qemu-devel] [PATCH V5 28/28] qapi event: clean up

2014-05-01 Thread Eric Blake
On 04/30/2014 10:27 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > include/monitor/monitor.h | 40 - > monitor.c | 81 > > stubs/Makefile.objs|1 - > stubs/mon-protocol-event.c |6

Re: [Qemu-devel] [PATCH V26 12/32] change block layer to support both QemuOpts and QEMUOptionParamter

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:10:36PM +0800, Chunyan Liu wrote: > Change block layer to support both QemuOpts and QEMUOptionParameter. > After this patch, it will change backend drivers one by one. At the end, > QEMUOptionParameter will be removed and only QemuOpts is kept. > > Signed-off-by: Dong Xu

Re: [Qemu-devel] [PATCH V26 12/32] change block layer to support both QemuOpts and QEMUOptionParamter

2014-05-01 Thread Leandro Dorileo
Chunyan, On Tue, Apr 29, 2014 at 05:08:21PM +0800, Chunyan Liu wrote: > Change block layer to support both QemuOpts and QEMUOptionParameter. > After this patch, it will change backend drivers one by one. At the end, > QEMUOptionParameter will be removed and only QemuOpts is kept. This patch brea

Re: [Qemu-devel] [PATCH V5 06/28] monitor: change event functions as an implemention of new emit method

2014-05-01 Thread Eric Blake
On 04/30/2014 10:26 PM, Wenchao Xia wrote: > Now monitor has been hooked on the new event mechanism, so the patches > later can convert event callers one by one. qmp_query_events() is also > switched to use new generated event defines. Note that old function > monitor_protocol_event() is kept for e

Re: [Qemu-devel] [PATCH V5 03/28] qapi script: add event support

2014-05-01 Thread Eric Blake
On 04/30/2014 10:26 PM, Wenchao Xia wrote: > qapi-event.py will parse the schema and generate qapi-event.c, then > the API in qapi-event.c can be used to handle event in qemu code. > All API have prefix "qapi_event". > > The script mainly includes two parts: generate API for each event > define, g

Re: [Qemu-devel] [PATCH V26 17/32] nfs.c: replace QEMUOptionParameter with QemuOpts

2014-05-01 Thread Eric Blake
On 04/29/2014 03:10 AM, Chunyan Liu wrote: > Signed-off-by: Chunyan Liu > --- > block/nfs.c | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-devel] [PATCH V26 19/32] qcow2.c: replace QEMUOptionParameter with QemuOpts

2014-05-01 Thread Eric Blake
On 04/29/2014 03:10 AM, Chunyan Liu wrote: > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/qcow2.c | 265 > +++--- > include/qemu/option.h | 1 + > util/qemu-option.c| 2 +- > 3 files changed, 143 insertions(+)

Re: [Qemu-devel] [PATCH v3] apic: bump emulated lapic version to 0x14 on pc machines >= 2.1

2014-05-01 Thread Don Slutz
On 05/01/14 14:52, Alexander Graf wrote: On 01.05.14 19:22, Gabriel L. Somlo wrote: On Wed, Apr 30, 2014 at 09:44:32PM +0200, Alexander Graf wrote: diff --git a/hw/intc/apic.c b/hw/intc/apic.c index 2f40cba..4480bc4 100644 --- a/hw/intc/apic.c +++ b/hw/intc/apic.c @@ -32,6 +32,8 @@ #define S

Re: [Qemu-devel] [PATCH V26 15/32] gluster.c: replace QEMUOptionParameter with QemuOpts

2014-05-01 Thread Eric Blake
On 04/29/2014 03:10 AM, Chunyan Liu wrote: > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > Changes to V25: > * fix create_opts, OPT_STRING -> QEMU_OPT_STRING > > block/gluster.c | 81 > ++--- > 1 file changed, 42 insertio

Re: [Qemu-devel] [PATCH V26 11/32] QemuOpts: check NULL input for qemu_opts_del

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:08:20PM +0800, Chunyan Liu wrote: > To simplify later using of qemu_opts_del, accept NULL input. > > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Eric Blake > Signed-off-by: Chunyan Liu Reviewed-by: Leandro Dorileo > --- > util/qemu-option.c | 4 > 1 file chan

Re: [Qemu-devel] [PATCH V26 09/32] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:08:18PM +0800, Chunyan Liu wrote: > Add two temp conversion functions between QEMUOptionParameter to QemuOpts, > so that next patch can use it. It will simplify later patch for easier > review. And will be finally removed after all backend drivers switch to > QemuOpts. >

Re: [Qemu-devel] [PATCH V26 13/32] vvfat.c: handle cross_driver's create_options and create_opts

2014-05-01 Thread Eric Blake
On 05/01/2014 01:18 PM, Eric Blake wrote: > On 04/29/2014 03:10 AM, Chunyan Liu wrote: >> vvfat shares create options of qcow driver. To avoid vvfat broken when > > s/broken/breaking/ > >> qcow driver changes from QEMUOptionParameter to QemuOpts, let it able >> to handle both cases. >> >> +i

Re: [Qemu-devel] [PATCH V26 08/32] QemuOpts: add qemu_opts_print_help to replace print_option_help

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:08:17PM +0800, Chunyan Liu wrote: > print_option_help takes QEMUOptionParameter as parameter, add > qemu_opts_print_help to take QemuOptsList as parameter for later > replace work. > > Reviewed-by: Eric Blake > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu

Re: [Qemu-devel] [PATCH V26 13/32] vvfat.c: handle cross_driver's create_options and create_opts

2014-05-01 Thread Eric Blake
On 04/29/2014 03:10 AM, Chunyan Liu wrote: > vvfat shares create options of qcow driver. To avoid vvfat broken when s/broken/breaking/ > qcow driver changes from QEMUOptionParameter to QemuOpts, let it able > to handle both cases. > > Signed-off-by: Chunyan Liu > --- > block/vvfat.c | 19 +

Re: [Qemu-devel] [PATCH V26 07/32] QemuOpts: add qemu_opt_get_*_del functions for replace work

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:08:16PM +0800, Chunyan Liu wrote: > Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and > qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter > (get and delete). > > Several drivers are coded to parse a known subset of options,

Re: [Qemu-devel] [PATCH V26 06/32] QemuOpts: move qemu_opt_del ahead for later calling

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:08:15PM +0800, Chunyan Liu wrote: > In later patch, qemu_opt_get_del functions will be added, they will > first get the option value, then call qemu_opt_del to remove the option > from opt list. To prepare for that purpose, move qemu_opt_del ahead first. > > Reviewed-by:

Re: [Qemu-devel] [PATCH V26 05/32] QemuOpts: change opt->name|str from (const char *) to (char *)

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:08:14PM +0800, Chunyan Liu wrote: > qemu_opt_del() already assumes that all QemuOpt instances contain > malloc'd name and value; but it had to cast away const because > opts_start_struct() was doing its own thing and using static storage > instead. By using the correct t

Re: [Qemu-devel] [PATCH V26 04/32] qapi: output def_value_str when query command line options

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:08:13PM +0800, Chunyan Liu wrote: > Change qapi interfaces to output the newly added def_value_str when querying > command line options. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu Reviewed-by: Leandro Dorileo > --- > Changes to V25: > * update

Re: [Qemu-devel] [PATCH V26 03/32] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:08:12PM +0800, Chunyan Liu wrote: > Currently this function is not used anywhere. In later patches, it will > replace print_option_parameters. To avoid print info changes, change > qemu_opts_print from fprintf stderr to printf to keep consistent with > print_option_parame

Re: [Qemu-devel] [PATCH V26 02/32] QemuOpts: add def_value_str to QemuOptDesc

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:08:11PM +0800, Chunyan Liu wrote: > Add def_value_str (default value) to QemuOptDesc, to replace function of the > default value in QEMUOptionParameter. > > Improve qemu_opts_get_* functions: if find opt, return opt->str; otherwise, > if desc->def_value_str is set, retur

Re: [Qemu-devel] [PATCH V26 01/32] QemuOpts: move find_desc_by_name ahead for later calling

2014-05-01 Thread Leandro Dorileo
On Tue, Apr 29, 2014 at 05:08:10PM +0800, Chunyan Liu wrote: > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Eric Blake > Signed-off-by: Chunyan Liu Reviewed-by: Leandro Dorileo > --- > util/qemu-option.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-)

Re: [Qemu-devel] [PATCH v3] apic: bump emulated lapic version to 0x14 on pc machines >= 2.1

2014-05-01 Thread Alexander Graf
On 01.05.14 19:22, Gabriel L. Somlo wrote: On Wed, Apr 30, 2014 at 09:44:32PM +0200, Alexander Graf wrote: diff --git a/hw/intc/apic.c b/hw/intc/apic.c index 2f40cba..4480bc4 100644 --- a/hw/intc/apic.c +++ b/hw/intc/apic.c @@ -32,6 +32,8 @@ #define SYNC_TO_VAPIC 0x2 #defi

Re: [Qemu-devel] [PATCH] linux-user: Assert stack used for auxvec, envp, argv

2014-05-01 Thread Peter Maydell
Ping! Riku -- do you have this in your tree now? (I'm adding an aux entry for AT_HWCAP2 and I noticed the assert wasn't firing :-)) thanks -- PMM On 25 March 2014 23:21, James Hogan wrote: > Assert that the amount of stack space used for auxvec, envp & argv > exactly matches the amount allocat

[Qemu-devel] [PATCH] linux-user/signal.c: Set fault address in AArch64 signal info

2014-05-01 Thread Peter Maydell
Set the fault address correctly in the signal information passed to a signal handler for AArch64 guests. Signed-off-by: Peter Maydell --- This would be a candidate for stable except that it depends on the a64 system rework which added exception.vaddress. Hopefully not many guests care about the f

Re: [Qemu-devel] [PATCH v3] apic: bump emulated lapic version to 0x14 on pc machines >= 2.1

2014-05-01 Thread Gabriel L. Somlo
On Wed, Apr 30, 2014 at 09:44:32PM +0200, Alexander Graf wrote: > >diff --git a/hw/intc/apic.c b/hw/intc/apic.c > >index 2f40cba..4480bc4 100644 > >--- a/hw/intc/apic.c > >+++ b/hw/intc/apic.c > >@@ -32,6 +32,8 @@ > > #define SYNC_TO_VAPIC 0x2 > > #define SYNC_ISR_IRR_TO_VAPIC

[Qemu-devel] [Bug 1314857] Re: seg fault in ivshmem when using ioeventfd=on

2014-05-01 Thread Gene Snider
When I tried the same thing with git master (latest) I get a different error: qemu_chr_fe_claim_no_fail: error chardev "(null)" already used ** Also affects: qemu-kvm (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- dev

[Qemu-devel] [PATCH 19/22] dataplane: use the QEMU block layer for I/O

2014-05-01 Thread Stefan Hajnoczi
Stop using a custom Linux AIO request queue from ioq.h and instead use the QEMU block layer for I/O. This patch adjusts the VirtIOBlockRequest struct with fields needed for bdrv_aio_readv()/bdrv_aio_writev(). ioq.h used struct iovec and struct iocb, which we don't need directly anymore. Modify d

[Qemu-devel] [PULL 07/10] target-arm: Correct a comment refering to EL0

2014-05-01 Thread Peter Maydell
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Message-id: 1398926097-28097-5-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/op_helper.c b/target-arm/op_h

[Qemu-devel] [PATCH 26/26] tcg-ppc: Streamline USE_DIRECT_JUMP

2014-05-01 Thread Richard Henderson
With the TCG_REG_RA base, we can form any 2G displacement for 64-bit, which means we only need 4 insns for the 64-bit target instead of 7. Generate the mtctr and brctr insns once during translation and not part of ppc_tb_set_jmp_target. This means we can update only 2 insns, and we can arrange to

Re: [Qemu-devel] [PULL 0/7] smbios: make qemu generate smbios tables.

2014-05-01 Thread Peter Maydell
On 29 April 2014 13:11, Gerd Hoffmann wrote: > Hi, > > This patch series makes qemu generate smbios tables for 2.1 & newer > machine types. Most patches are created by Gabriel L. Somlo. For the > new machine type I've picked mst's patch though, so git should have an > easier job sorting things

[Qemu-devel] [PATCH 12/22] quorum: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Stefan Hajnoczi
Implement .bdrv_detach/attach_aio_context() interfaces to propagate detach/attach to BDRVQuorumState->bs[] children. The block layer takes care of ->file and ->backing_hd but doesn't know about our ->bs[] BlockDriverStates, which is also part of the graph. Cc: Benoît Canet Signed-off-by: Stefan

Re: [Qemu-devel] [PULL v2 0/4] vga: add secondary stdvga variant

2014-05-01 Thread Peter Maydell
On 28 April 2014 10:14, Gerd Hoffmann wrote: > Hi, > > This series adds a standard vga variant which doesn't occupy any legacy > ressources and thus can easily be used as secondary (or legacy-free) > graphics adapter. Programming must be done using the MMIO bar. > > bochsdrm (linux 3.14+) can d

[Qemu-devel] [PATCH 15/26] tcg-ppc64: Begin merging ppc32 with ppc64

2014-05-01 Thread Richard Henderson
Just enough to compile, assuming you edit config-host.mak manually. It will still abort at runtime, due to missing brcond2, setcond2, mulu2. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 104 +++-- tcg/ppc64/tcg-target.h | 20 +++--

[Qemu-devel] [PATCH 06/22] curl: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Stefan Hajnoczi
The curl block driver uses fd handlers, timers, and BHs. The fd handlers and timers are managed on behalf of libcurl, which controls them using callback functions that the block driver implements. The simplest way to implement .bdrv_detach/attach_aio_context() is to clean up libcurl in the old ev

[Qemu-devel] [PATCH 15/22] rbd: use BlockDriverState's AioContext

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext. Convert qemu_bh_new() to aio_bh_new() and qemu_aio_wait() to aio_poll(). The .bdrv_detach_aio_context() and .bdrv_attach_aio_context() interfaces are not needed since no fd handlers, timers, or BHs stay registered when requests have been d

[Qemu-devel] [PATCH 25/26] tcg-ppc64: Use the return address as a base pointer

2014-05-01 Thread Richard Henderson
This can significantly reduce code size for generation of (some) 64-bit constants. With the side effect that we know for a fact that exit_tb can use the register to good effect. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c | 105 +--

[Qemu-devel] [PATCH 24/26] tcg-ppc: Merge cache-utils into the backend

2014-05-01 Thread Richard Henderson
As a "utility", it only supported ppc, and in a way that other tcg backends provided directly in tcg-target.h. Removing this disparity is easier now that the two ppc backends are merged. Signed-off-by: Richard Henderson --- exec.c | 1 - include/qemu/cache-utils.h | 44

[Qemu-devel] [PATCH 16/22] sheepdog: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext. Convert qemu_aio_set_fd_handler() to aio_set_fd_handler() and qemu_aio_wait() to aio_poll(). The .bdrv_detach/attach_aio_context() interfaces also need to be implemented to move the socket fd handler from the old to the new AioContext. Cc

[Qemu-devel] [PATCH 22/26] tcg-ppc: Rename the tcg/ppc64 backend

2014-05-01 Thread Richard Henderson
The other tcg backends that support 32- and 64-bit modes use the 32-bit name for the port. Follow suit. Signed-off-by: Richard Henderson --- configure | 4 ++-- tcg/{ppc64 => ppc}/tcg-target.c | 0 tcg/{ppc64 => ppc}/tcg-target.h | 0 3 files changed, 2 insertions(+), 2 de

[Qemu-devel] [PATCH 16/26] tcg-ppc64: Merge ppc32 brcond2, setcond2, muluh

2014-05-01 Thread Richard Henderson
Now passes tcg_add_target_add_op_defs assertions, but not complete enough to function. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 96 +- tcg/ppc64/tcg-target.h | 2 +- 2 files changed, 96 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PATCH 23/26] qemu/osdep: Remove the need for qemu_init_auxval

2014-05-01 Thread Richard Henderson
Instead of getting backup auxv data from the env pointer given to main, read it from /proc/self/auxv. We can do this at any time, so we're not tied to any ordering wrt a call to qemu_init_auxval from main. Signed-off-by: Richard Henderson --- include/qemu/osdep.h | 12 linux-user/m

[Qemu-devel] [PATCH 14/26] tcg-ppc64: Fix sub2 implementation

2014-05-01 Thread Richard Henderson
All sorts of confusion on argument ordering. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 8d932eb..22cfa1e 100644 --- a/tcg/ppc64/tcg-target.c +

[Qemu-devel] [PATCH 19/26] tcg-ppc64: Support mulsh_i32

2014-05-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 5 + tcg/ppc64/tcg-target.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index cd68834..860c408 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target

[Qemu-devel] [PATCH 20/26] tcg-ppc64: Merge ppc32 shifts

2014-05-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 860c408..7bbb02e 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-

[Qemu-devel] [PATCH 13/26] tcg-ppc64: Merge 32-bit ABIs into the prologue / frame code

2014-05-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 39 --- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 635ff98..8d932eb 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-t

[Qemu-devel] [PATCH 18/26] tcg-ppc64: Merge ppc32 register usage

2014-05-01 Thread Richard Henderson
Good enough to run some instructions before things go awry. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 61 -- 1 file changed, 39 insertions(+), 22 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index d

[Qemu-devel] [PATCH 10/26] tcg-ppc64: Use the correct test in tcg_out_call

2014-05-01 Thread Richard Henderson
The correct test uses the _CALL_AIX macro, not a host-specific macro. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index a198a70..31c3a7a 100644 --- a/tcg/ppc6

[Qemu-devel] [PATCH 17/26] tcg-ppc64: Merge ppc32 qemu_ld/st

2014-05-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 290 +++-- 1 file changed, 206 insertions(+), 84 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 4b846a2..d333da0 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tc

[Qemu-devel] [PATCH 01/26] tcg-ppc: Use uintptr_t in ppc_tb_set_jmp_target

2014-05-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 2 +- tcg/ppc/tcg-target.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 0766e24..612b447 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec

[Qemu-devel] [PATCH 05/26] tcg-ppc64: Use tcg_out_{ld, st, cmp} internally

2014-05-01 Thread Richard Henderson
Rather than using tcg_out32 and opcodes directly. This allows us to remove LD_ADDR and CMP_L macros. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/p

[Qemu-devel] [PATCH 12/26] tcg-ppc64: Adjust tcg_out_call for ELFv2

2014-05-01 Thread Richard Henderson
From: Ulrich Weigand The new ELFv2 ABI, used by default on powerpc64le-linux hosts, introduced some changes that are incompatible with code currently generated by the ppc64 TGC target. In particular, we no longer use function descriptors. This patch adds support for the ELFv2 ABI in the ppc64 T

[Qemu-devel] [PATCH 09/26] tcg-ppc64: Better parameterize the stack frame

2014-05-01 Thread Richard Henderson
In preparation for supporting other ABIs. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 64 -- 1 file changed, 36 insertions(+), 28 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 44abf7b..a198a70 10

[Qemu-devel] [PATCH 08/26] tcg-ppc64: Fix TCG_TARGET_CALL_STACK_OFFSET

2014-05-01 Thread Richard Henderson
The calling convention reserves space for the 8 register parameters on the stack, so using only 6*8=48 as the offset was wrong. We never saw this bug because we don't have any helpers with more than 5 parameters. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 2 +- 1 file changed

[Qemu-devel] [PATCH 11/26] tcg-ppc64: Support the ppc64 elfv2 ABI

2014-05-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 4 1 file changed, 4 insertions(+) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 31c3a7a..d3cc237 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target.c @@ -1414,6 +1414,10 @@ static void tcg_out_qe

[Qemu-devel] [PATCH 03/26] tcg-ppc64: Move functions around

2014-05-01 Thread Richard Henderson
Code movement only. This will allow us to make use of the other tcg_out_* functions in tidying their implementations. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 1178 1 file changed, 589 insertions(+), 589 deletions(-) diff --

[Qemu-devel] [PATCH 07/26] tcg-ppc64: Move call macros out of tcg-target.h

2014-05-01 Thread Richard Henderson
These values are private to tcg.c; we don't need to expose this nonsense to the translators. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 5 + tcg/ppc64/tcg-target.h | 6 -- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64

[Qemu-devel] [PATCH 06/26] tcg-ppc64: Make TCG_AREG0 and TCG_REG_CALL_STACK enum constants

2014-05-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.h | 46 +++--- 1 file changed, 11 insertions(+), 35 deletions(-) diff --git a/tcg/ppc64/tcg-target.h b/tcg/ppc64/tcg-target.h index 29f479a..2c1cfc1 100644 --- a/tcg/ppc64/tcg-target.h +++ b/tcg/ppc

[Qemu-devel] [PATCH 04/26] tcg-ppc64: Relax register restrictions in tcg_out_mem_long

2014-05-01 Thread Richard Henderson
In order to be able to use tcg_out_ld/st sensibly with scratch registers, assert only when we'd incorrectly clobber a scratch. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg

[Qemu-devel] [PATCH 00/26] Merge ppc32/ppc64 tcg backends

2014-05-01 Thread Richard Henderson
The ppc32 backend isn't getting much love and attention recently, with all of the improvements coming from me into the ppc64 backend. Let's reduce the maint burden a bit and combine them. This does have a few other patches that are not strictly related to the merge of the backends, such as additi

[Qemu-devel] [PATCH 02/26] tcg-ppc64: Avoid some hard-codings of TCG_TYPE_I64

2014-05-01 Thread Richard Henderson
Using more appropriate _PTR or _REG where possible. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index c90ddcd..2f60924 100644 --- a/tcg/pp

Re: [Qemu-devel] [PATCH V5 05/28] qapi: define events in qapi schema

2014-05-01 Thread Eric Blake
On 04/30/2014 10:26 PM, Wenchao Xia wrote: > Some old type defines for spice and vnc are changed to let new > event defines use them instead of redefine. Note that define of > BlockErrorAction is moved from block.h to qapi schema, and it is > not merged with BlockdevOnError. In schema NIC_RX_FILTER

Re: [Qemu-devel] [PATCH 17/22] ssh: use BlockDriverState's AioContext

2014-05-01 Thread Stefan Hajnoczi
On Thu, May 1, 2014 at 5:03 PM, Richard W.M. Jones wrote: > On Thu, May 01, 2014 at 04:54:41PM +0200, Stefan Hajnoczi wrote: >> Drop the assumption that we're using the main AioContext. Use >> bdrv_get_aio_context() to register fd handlers in the right AioContext >> for this BlockDriverState. >>

[Qemu-devel] [PULL 00/10] target-arm queue

2014-05-01 Thread Peter Maydell
to staging (2014-05-01 14:17:33 +0100) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20140501 for you to fetch changes up to f42c5c8ec8aa0e15583487ffee62964830751623: hw/arm/virt: Add support for Cortex-A57 (2014-05-01 15:2

[Qemu-devel] [PULL 10/10] hw/arm/virt: Add support for Cortex-A57

2014-05-01 Thread Peter Maydell
Support the Cortex-A57 in the virt machine model. Signed-off-by: Peter Maydell Message-id: 1398362083-17737-4-git-send-email-peter.mayd...@linaro.org --- hw/arm/virt.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 9c4d337..ea4f02d 100644 --- a/hw/ar

[Qemu-devel] [PULL 01/10] target-arm: Implement XScale cache lockdown operations as NOPs

2014-05-01 Thread Peter Maydell
XScale defines some implementation-specific coprocessor registers for doing cache lockdown operations. Since QEMU doesn't model a cache no proper implementation is possible, but NOP out the registers so that guest code like u-boot that tries to use them doesn't crash. Reported-by: Signed-off-by:

[Qemu-devel] [PULL 04/10] target-arm: Make vbar_write 64bit friendly on 32bit hosts

2014-05-01 Thread Peter Maydell
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Reviewed-by: Alex Bennée Message-id: 1398926097-28097-2-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper

Re: [Qemu-devel] [PATCH V5 02/28] qapi: add event helper functions

2014-05-01 Thread Eric Blake
On 04/30/2014 10:26 PM, Wenchao Xia wrote: > This file holds some functions that do not need to be generated. > > Signed-off-by: Wenchao Xia > --- > include/qapi/qmp-event.h | 27 + > qapi/Makefile.objs |1 + > qapi/qmp-event.c | 74 > ++

[Qemu-devel] [PULL 06/10] target-arm: A64: Fix a typo when declaring TLBI ops

2014-05-01 Thread Peter Maydell
From: "Edgar E. Iglesias" Harmless typo as opc1 defaults to zero and opc2 gets re-declared to its correct value. Signed-off-by: Edgar E. Iglesias Reviewed-by: Alex Bennée Message-id: 1398926097-28097-4-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/helper

[Qemu-devel] [PULL 09/10] hw/arm/virt: Put GIC register banks on 64K boundaries

2014-05-01 Thread Peter Maydell
For an AArch64 CPU which supports 64K pages, having the GIC register banks at 4K offsets is potentially awkward. Move them out to being at 64K offsets. (This is harmless for AArch32 CPUs and for AArch64 CPUs with 4K pages, so it is simpler to use the same offsets everywhere than to try to use 64K o

[Qemu-devel] [PULL 03/10] target-arm: implement WFE/YIELD as a yield for AArch64

2014-05-01 Thread Peter Maydell
From: Rob Herring Like was done for AArch32 for WFE, implement both WFE and YIELD as a yield operation. This speeds up multi-core system emulation. Signed-off-by: Rob Herring Message-id: 1397588401-20366-1-git-send-email-robherri...@gmail.com Signed-off-by: Peter Maydell --- target-arm/transl

Re: [Qemu-devel] [PATCH 17/22] ssh: use BlockDriverState's AioContext

2014-05-01 Thread Richard W.M. Jones
On Thu, May 01, 2014 at 04:54:41PM +0200, Stefan Hajnoczi wrote: > Drop the assumption that we're using the main AioContext. Use > bdrv_get_aio_context() to register fd handlers in the right AioContext > for this BlockDriverState. > > The .bdrv_detach_aio_context() and .bdrv_attach_aio_context()

[Qemu-devel] [PULL 05/10] target-arm: A64: Handle blr lr

2014-05-01 Thread Peter Maydell
From: "Edgar E. Iglesias" For linked branches, updates to the link register happen conceptually after the read of the branch target register. Signed-off-by: Edgar E. Iglesias Reviewed-by: Alex Bennée Cc: qemu-sta...@nongnu.org Message-id: 1398926097-28097-3-git-send-email-edgar.igles...@gmail.

[Qemu-devel] [PULL 02/10] armv7m_nvic: fix CPUID Base Register

2014-05-01 Thread Peter Maydell
From: Rabin Vincent cp15.c0_cpuid is never initialized for ARMv7-M; take the value directly from cpu->midr instead. Signed-off-by: Rabin Vincent Message-id: 1398036308-32166-1-git-send-email-ra...@rab.in Signed-off-by: Peter Maydell --- hw/intc/armv7m_nvic.c | 2 +- 1 file changed, 1 insertio

[Qemu-devel] [PATCH 21/22] dataplane: implement async flush

2014-05-01 Thread Stefan Hajnoczi
Stop using the raw-posix file descriptor for synchronous qemu_fdatasync(). Use bdrv_aio_flush() instead and drop the VirtIOBlockDataPlane->fd field. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 43 ++--- 1 file changed, 27 insertions(+

[Qemu-devel] [PATCH 18/22] vmdk: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Stefan Hajnoczi
Implement .bdrv_detach/attach_aio_context() interfaces to propagate detach/attach to BDRVVmdkState->extents[].file. The block layer takes care of ->file and ->backing_hd but doesn't know about our extents BlockDriverStates, which is also part of the graph. Cc: Fam Zheng Signed-off-by: Stefan Haj

[Qemu-devel] [PATCH 13/22] block/raw-posix: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext for Linux AIO. Convert the Linux AIO event notifier to use aio_set_event_notifier(). The .bdrv_detach/attach_aio_context() interfaces also need to be implemented to move the event notifier handler from the old to the new AioContext. Signed-

[Qemu-devel] [PATCH 22/22] raw-posix: drop raw_get_aio_fd() since it is no longer used

2014-05-01 Thread Stefan Hajnoczi
virtio-blk data-plane now uses the QEMU block layer for I/O. We do not need raw_get_aio_fd() anymore. It was a layering violation anyway, so let's get rid of it. Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 34 -- include/block/block.h | 9 ---

[Qemu-devel] [PATCH 20/22] dataplane: delete IOQueue since it is no longer used

2014-05-01 Thread Stefan Hajnoczi
This custom Linux AIO request queue is no longer used by virtio-blk data-plane. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/Makefile.objs | 2 +- hw/block/dataplane/ioq.c | 117 --- hw/block/dataplane/ioq.h | 57 ---

[Qemu-devel] [PATCH 17/22] ssh: use BlockDriverState's AioContext

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext. Use bdrv_get_aio_context() to register fd handlers in the right AioContext for this BlockDriverState. The .bdrv_detach_aio_context() and .bdrv_attach_aio_context() interfaces are not needed since no fd handlers, timers, or BHs stay registe

[Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext for Linux AIO. Convert qemu_aio_set_fd_handler() to aio_set_fd_handler() and timer_new_ms() to aio_timer_new(). The .bdrv_detach/attach_aio_context() interfaces also need to be implemented to move the fd and timer from the old to the new Ai

[Qemu-devel] [PATCH 14/22] block/linux-aio: fix memory and fd leak

2014-05-01 Thread Stefan Hajnoczi
Hot unplugging -drive aio=native,file=test.img,format=raw images leaves the Linux AIO event notifier and struct qemu_laio_state allocated. Luckily nothing will use the event notifier after the BlockDriverState has been closed so the handler function is never called. It's still worth fixing this re

[Qemu-devel] [PATCH 11/22] qed: use BlockDriverState's AioContext

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext. Convert qemu_bh_new() to aio_bh_new() and qemu_aio_wait() to aio_poll() so we're using the BlockDriverState's AioContext. Implement .bdrv_detach/attach_aio_context() interfaces to move the QED_F_NEED_CHECK timer from the old AioContext to

[Qemu-devel] [PATCH 04/22] blkdebug: use BlockDriverState's AioContext

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext. Convert qemu_bh_new() to aio_bh_new() so we use the BlockDriverState's AioContext. The .bdrv_detach_aio_context() and .bdrv_attach_aio_context() interfaces are not needed since no fd handlers, timers, or BHs stay registered when requests h

[Qemu-devel] [PATCH 10/22] nfs: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext. The following functions need to be converted: * qemu_bh_new() -> aio_bh_new() * qemu_aio_set_fd_handler() -> aio_set_fd_handler() * qemu_aio_wait() -> aio_poll() The .bdrv_detach/attach_aio_context() interfaces also need to be implement

[Qemu-devel] [PATCH 09/22] nbd: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext. Convert qemu_aio_set_fd_handler() calls to aio_set_fd_handler(). The .bdrv_detach/attach_aio_context() interfaces also need to be implemented to move the socket fd handler from the old to the new AioContext. Cc: Paolo Bonzini Signed-off-

[Qemu-devel] [PATCH 05/22] blkverify: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext. Convert qemu_bh_new() to aio_bh_new() and qemu_aio_wait() to aio_poll() so we use the BlockDriverState's AioContext. Implement .bdrv_detach/attach_aio_context() interfaces to propagate detach/attach to BDRVBlkverifyState->test_file. The b

[Qemu-devel] [PATCH 03/22] block: add bdrv_set_aio_context()

2014-05-01 Thread Stefan Hajnoczi
Up until now all BlockDriverState instances have used the QEMU main loop for fd handlers, timers, and BHs. This is not scalable on SMP guests and hosts so we need to move to a model with multiple event loops on different host CPUs. bdrv_set_aio_context() assigns the AioContext event loop to use f

[Qemu-devel] [PATCH 02/22] block: acquire AioContext in bdrv_close_all()

2014-05-01 Thread Stefan Hajnoczi
bdrv_close_all() closes all BlockDriverState instances. It is called from vl.c:main() and qemu-nbd when shutting down. Some BlockDriverState instances may be running in another AioContext. Make sure to acquire the AioContext before closing the BlockDriverState. This will protect against race con

[Qemu-devel] [PULL 08/10] hw/arm/virt: Create the GIC ourselves rather than (ab)using a15mpcore_priv

2014-05-01 Thread Peter Maydell
Rather than having the virt machine model create an a15mpcore_priv device regardless of the actual CPU type in order to instantiate the GIC, move to having the machine model create the GIC directly. This corresponds to a system which uses a standalone GIC (eg the GIC-400) rather than the one built

[Qemu-devel] [PATCH 01/22] block: use BlockDriverState AioContext

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext. Convert qemu_aio_wait() to aio_poll() and qemu_bh_new() to aio_bh_new() so the BlockDriverState AioContext is used. Note there is still one qemu_aio_wait() left in bdrv_create() but we do not have a BlockDriverState there and only main loo

[Qemu-devel] [PATCH 00/22] dataplane: use QEMU block layer

2014-05-01 Thread Stefan Hajnoczi
This patch series switches virtio-blk data-plane from a custom Linux AIO request queue to the QEMU block layer. The previous "raw files only" limitation is lifted. All image formats and protocols can now be used with virtio-blk data-plane. How to review this series - I CC

[Qemu-devel] [PATCH 07/22] gluster: use BlockDriverState's AioContext

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext. Use aio_bh_new() instead of qemu_bh_new(). The .bdrv_detach_aio_context() and .bdrv_attach_aio_context() interfaces are not needed since no fd handlers, timers, or BHs stay registered when requests have been drained. Cc: Bharata B Rao Si

Re: [Qemu-devel] [PATCH V5 07/28] qapi event: convert SHUTDOWN

2014-05-01 Thread Eric Blake
On 04/30/2014 10:26 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > vl.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) This, and many of the subsequent patches in the series, are a bit misleading; I have to go back to 5/28 to make sure that both pieces of the convers

Re: [Qemu-devel] [PATCH V5 04/28] test: add test cases for qapi event

2014-05-01 Thread Eric Blake
On 04/30/2014 10:26 PM, Wenchao Xia wrote: > These cases will verify whether the expected qdict is built. > > Signed-off-by: Wenchao Xia > --- > tests/Makefile | 14 ++- > tests/qapi-schema/qapi-schema-test.json | 12 ++ > tests/qapi-schema/qapi-schema-test.out |

  1   2   >