Re: [Qemu-devel] [PATCH v6 00/37] AArch64 system emulation

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 8:43 AM, Peter Crosthwaite wrote: > On Fri, Apr 11, 2014 at 2:14 AM, Peter Maydell > wrote: >> Here's v5 of the AArch64 system emulation patchset. >> Still missing/TODO: >> * SMP support (needs PSCI emulation in QEMU; being prototyped) >> * save/restore (I have a patch

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-13 Thread Alexander Graf
On 12.04.14 23:44, Benjamin Herrenschmidt wrote: On Sat, 2014-04-12 at 16:31 +0200, Alexander Graf wrote: Don't we generate PHBs on the fly? How exactly is this going to help with the problem at hand? We can still assign the interrupts as a fixed function of the PHB number... Yes, but we cre

Re: [Qemu-devel] [PATCH v6 36/37] target-arm: Handle the CPU being in AArch32 mode in the AArch64 set_pc

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > The AArch64 implementation of the set_pc method needs to be updated to > handle the possibility that the CPU is in AArch32 mode; otherwise there > are weird crashes when doing interprocessing in system emulation mode > when an interrupt occur

Re: [Qemu-devel] [PATCH v6 31/37] target-arm: Implement AArch64 address translation operations

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > Implement the AArch64 address translation operations. > > Signed-off-by: Peter Maydell > --- > target-arm/cpu.h| 3 +-- > target-arm/helper.c | 53 > - > 2 files changed, 25 insertio

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-13 Thread Alexander Graf
On 12.04.14 17:51, Alexey Kardashevskiy wrote: On 04/11/2014 07:40 PM, Alexander Graf wrote: On 10.04.14 16:31, Alexey Kardashevskiy wrote: On 04/10/2014 10:34 PM, Alexander Graf wrote: On 03.04.14 15:14, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from

Re: [Qemu-devel] [PATCH 4/4] spapr: Add support for time base offset migration

2014-04-13 Thread Alexander Graf
On 13.04.14 07:56, Benjamin Herrenschmidt wrote: On Sun, 2014-04-13 at 00:38 +0100, Peter Maydell wrote: From a design standpoint I find that totally retarded btw :-) I agree it's bonkers; it's just that fixing it requires a big pile of design and implementation work from somebody; and in the

[Qemu-devel] [Bug 1307225] Re: Running a virtual machine on a Haswell system produces machine check events

2014-04-13 Thread Tobias-leupold
** Description changed: I'm running a virtual Windows SBS 2003 installation on a Xeon E3 Haswell system running Gentoo Linux. First, I used Qemu 1.5.3 (the latest stable version on Gentoo). I got a lot of machine check events ("mce: [Hardware Error]: Machine check events logged") in dmesg

Re: [Qemu-devel] [PATCH v6 30/37] target-arm: Implement auxiliary fault status registers

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > Implement the auxiliary fault status registers AFSR0_EL1 and > AFSR1_EL1. These are present on v7 and later, and have IMPDEF > behaviour; we choose to RAZ/WI for all cores. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite F

Re: [Qemu-devel] [PATCH v6 28/37] target-arm: Don't expose wildcard ID register definitions for ARMv8

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > In ARMv8 the 32 bit coprocessor ID register space is tidied up to > remove the wildcarded aliases of the MIDR and the RAZ behaviour > for the unassigned space where crm = 3..7. Make sure we don't > expose thes wildcards for v8 cores. This mea

Re: [Qemu-devel] [PATCH v6 26/37] target-arm: Implement ISR_EL1 register

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > Implement the ISR_EL1 register. This is actually present in > ARMv7 as well but was previously unimplemented. It is a > read-only register that indicates whether interrupts are > currently pending. > > Signed-off-by: Peter Maydell Reviewed-

Re: [Qemu-devel] [PATCH v6 25/37] target-arm: Implement AArch64 view of ACTLR

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > Implement the AArch64 view of the ACTLR (auxiliary control > register). Note that QEMU internally tends to call this > AUXCR for historical reasons. > So Ive noticed that in recent patches that where registers have multiple names, new trumps

Re: [Qemu-devel] [PATCH v6 24/37] target-arm: Implement AArch64 view of CONTEXTIDR

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > Implement AArch64 view of the CONTEXTIDR register. > We tighten up the condition when we flush the TLB on a CONTEXTIDR > write to avoid needlessly flushing the TLB every time on a 64 > bit system (and also on a 32 bit system using LPAE, as a

Re: [Qemu-devel] [PATCH v6 23/37] target-arm: Implement AArch64 views of AArch32 ID registers

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > All the AArch32 ID registers are visible from AArch64 > (in addition to the AArch64-specific ID_AA64* registers). > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- > target-arm/helper.c | 73 > +++

Re: [Qemu-devel] [PATCH v5 22/37] hw/arm/virt: Add support for Cortex-A57

2014-04-13 Thread Peter Crosthwaite
On Sat, Mar 29, 2014 at 2:10 AM, Peter Maydell wrote: > Support the Cortex-A57 in the virt machine model. > > Signed-off-by: Peter Maydell > --- > This should perhaps not be just stealing the a15mpcore_priv > on the basis that it's a GICv2... Yeh, I still think its a minimal change to just insta

Re: [Qemu-devel] [PATCH v6 20/37] target-arm: Implement ARMv8 MVFR registers

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > For ARMv8 there are two changes to the MVFR media feature registers: > * there is a new MVFR2 which is accessible from 32 bit code > * 64 bit code accesses these via the usual sysreg instructions >rather than with a floating-point speci

Re: [Qemu-devel] [PATCH v6 19/37] target-arm: Implement AArch64 EL1 exception handling

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > From: Rob Herring > > Implement exception handling for AArch64 EL1. Exceptions from AArch64 or > AArch32 EL0 are supported. > > Signed-off-by: Rob Herring > [PMM: fixed minor style nits; updated to match changes in > previous patches; adde

Re: [Qemu-devel] [PATCH v6 18/37] target-arm: Move arm_log_exception() into internals.h

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > Move arm_log_exception() into internals.h so we can use it from > helper-a64.c for the AArch64 exception entry code. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- > target-arm/helper.c| 31

Re: [Qemu-devel] [PATCH v6 16/37] target-arm: Implement SP_EL0, SP_EL1

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > Implement handling for the AArch64 SP_EL0 system register. > This holds the EL0 stack pointer, and is only accessible when > it's not being used as the stack pointer, ie when we're in EL1 > and EL1 is using its own stack pointer. We also prov

Re: [Qemu-devel] [PATCH v6 14/37] target-arm: Implement AArch64 views of fault status and data registers

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > From: Rob Herring > > Implement AArch64 views of ESR_EL1 and FAR_EL1, and make the 32 bit > DFSR, DFAR, IFAR share state with them as architecturally specified. > The IFSR doesn't share state with any AArch64 register visible at EL1, > so ju

Re: [Qemu-devel] [PATCH v6 10/37] target-arm: Add v8 mmu translation support

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > From: Rob Herring > > Add support for v8 page table walks. This supports stage 1 translations > for 4KB, 16KB and 64KB page sizes starting with 0 or 1 level. > > Signed-off-by: Rob Herring > [PMM: fix style nits, fold in 16/64K page support

Re: [Qemu-devel] [PATCH v6 06/37] target-arm: Provide syndrome information for MMU faults

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > From: Rob Herring > > Set up the required syndrome information when we detect an MMU fault. > > Signed-off-by: Rob Herring > [PMM: split out from exception handling patch, tweaked to bring > in line with how we create other kinds of syndro

Re: [Qemu-devel] [PATCH v6 04/37] target-arm: Provide correct syndrome information for cpreg access traps

2014-04-13 Thread Peter Crosthwaite
On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell wrote: > For exceptions taken to AArch64, if a coprocessor/system register > access fails due to a trap or enable bit then the syndrome information > must include details of the failing instruction (crn/crm/opc1/opc2 > fields, etc). Make the decoder c

Re: [Qemu-devel] [PATCH for-2.0] pc: ACPI BIOS: fix incorrect integer encoding for 0x{F-1}FFFF values

2014-04-13 Thread Stefan Weil
Am 13.04.2014 23:55, schrieb Igor Mammedov: > Fix typo in build_append_int() which causes integer > truncation when it's in range 0x{F-1} by packing it > as WordConst instead of required DWordConst. > > Signed-off-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 2 +- > 1 file changed, 1 ins

Re: [Qemu-devel] [PATCH RFC V2] virtio-net: announce self by guest

2014-04-13 Thread Jason Wang
On Fri, 2014-04-11 at 22:10 +0800, 陈梁 wrote: > Hi Jason, > Have you ever test that adds a bridge on the virtio-net in vm and migrate the > vm? I tested both ipv4 and ipv6, all work well. > The bridge may don't send garp packet(in my testing). Several questions: - The garp should be sent by guest

[Qemu-devel] [PATCH] arch_init.c: remove duplicate function

2014-04-13 Thread Amos Kong
We already have a function buffer_is_zero() in util/cutils.c Signed-off-by: Amos Kong --- arch_init.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch_init.c b/arch_init.c index 60c975d..342e5dc 100644 --- a/arch_init.c +++ b/arch_init.c @@ -152,11 +152,6 @@ int

Re: [Qemu-devel] [PATCH v2 3/4] vl.c: Enable adding devices to the system bus

2014-04-13 Thread Alistair Francis
On Fri, Apr 11, 2014 at 5:45 PM, Peter Maydell wrote: > On 11 April 2014 07:34, Alistair Francis wrote: >> This removes the old method to connect devices and replaces it >> with three calls to the three qdev-monitor functions added >> in the previous patch. >> >> This allows complete machines to

Re: [Qemu-devel] [PATCH v2 0/4] Allow sysbus devices to be attached via commandline

2014-04-13 Thread Alistair Francis
On Fri, Apr 11, 2014 at 7:13 PM, Peter Crosthwaite wrote: > On Fri, Apr 11, 2014 at 5:55 PM, Peter Maydell > wrote: >> On 11 April 2014 07:34, Alistair Francis wrote: >>> This patch allows sysbus devices to be attached via >>> command line arguments. >>> >>> This can be used to build an entire

Re: [Qemu-devel] '.' IDs and certain names breaks -global and -set

2014-04-13 Thread Alistair Francis
On Wed, Apr 9, 2014 at 9:58 PM, Peter Crosthwaite wrote: > On Wed, Apr 9, 2014 at 7:56 PM, Markus Armbruster wrote: >> We have a number of device model names containing '.'. They're unusable >> with -global. That's because "-global A.B.C=foo" gets parsed as >> >> driver = "A" >> propert

Re: [Qemu-devel] [PATCH v3 2/4] util/fifo: Generalise for common integer widths

2014-04-13 Thread Beniamino Galvani
On Wed, Apr 09, 2014 at 11:42:31PM -0700, Peter Crosthwaite wrote: > Add support for 16, 32 and 64 bit width FIFOs. The push and pop > functions are replicated to accept all four different integer types. > The element width of the FIFO is set at creation time. > > The backing storage for all eleme

[Qemu-devel] [PATCH for-2.0] pc: ACPI BIOS: fix incorrect integer encoding for 0x{F-1}FFFF values

2014-04-13 Thread Igor Mammedov
Fix typo in build_append_int() which causes integer truncation when it's in range 0x{F-1} by packing it as WordConst instead of required DWordConst. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c

[Qemu-devel] [Bug 1307225] Re: Running a virtual machine on a Haswell system produces machine check events

2014-04-13 Thread Tobias-leupold
** Description changed: I'm running a virtual Windows SBS 2003 installation on a Xeon E3 Haswell system running Gentoo Linux. First, I used Qemu 1.5.3 (the latest stable version on Gentoo). I got a lot of machine check events ("mce: [Hardware Error]: Machine check events logged") in dmesg

[Qemu-devel] [Bug 1307225] [NEW] Running a virtual machine on a Haswell system produces machine check events

2014-04-13 Thread Tobias-leupold
Public bug reported: I'm running a virtual Windows SBS 2003 installation on a Xeon E3 Haswell system running Gentoo Linux. First, I used Qemu 1.5.3 (the latest stable version on Gentoo). I got a lot of machine check events ("mce: [Hardware Error]: Machine check events logged") in dmesg that always

[Qemu-devel] [PATCH v9 3/4] qapi: Use an explicit input file

2014-04-13 Thread Lluís Vilanova
Use an explicit input file on the command-line instead of reading from standard input Signed-off-by: Lluís Vilanova --- Makefile | 12 ++-- docs/qapi-code-gen.txt |4 ++-- scripts/qapi-commands.py

[Qemu-devel] [PATCH v9 4/4] qapi: Add a primitive to include other files from a QAPI schema file

2014-04-13 Thread Lluís Vilanova
The primitive uses JSON syntax, and include paths are relative to the file using the directive: { 'include': 'path/to/file.json' } Signed-off-by: Lluís Vilanova --- docs/qapi-code-gen.txt | 11 + scripts/qapi.py| 66

[Qemu-devel] [PATCH v9 0/4] qapi: Allow modularization of QAPI schema files

2014-04-13 Thread Lluís Vilanova
Adds an include primitive to the syntax of QAPI schema files, allowing these to be modularized into multiple per-topic files in the future. Signed-off-by: Lluís Vilanova --- Changes in v9: * Do not catch unknown exceptions in "tests/qapi-schema/test-qapi.py". * Show primitive syntax in commit m

[Qemu-devel] [PATCH v9 2/4] qapi: [trivial] Do not catch unknown exceptions in "test-qapi.py"

2014-04-13 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- tests/qapi-schema/test-qapi.py |3 --- 1 file changed, 3 deletions(-) diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py index b3d1e1d..5a26ef3 100644 --- a/tests/qapi-schema/test-qapi.py +++ b/tests/qapi-schema/test-qapi.py @@ -18,

[Qemu-devel] [PATCH v9 1/4] qapi: [trivial] Break long command lines

2014-04-13 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile | 24 ++-- tests/Makefile | 20 2 files changed, 34 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index ec74039..84345ee 100644 --- a/Makefile +++ b/Makefile @@ -237,23 +237,35 @@ qapi

[Qemu-devel] [PATCHv90/4] qapi: Allow modularization of QAPI schema files

2014-04-13 Thread Lluís Vilanova
Adds an include primitive to the syntax of QAPI schema files, allowing these to be modularized into multiple per-topic files in the future. Signed-off-by: Lluís Vilanova --- Changes in v9: * Do not catch unknown exceptions in "tests/qapi-schema/test-qapi.py". * Show primitive syntax in commit m

Re: [Qemu-devel] [PATCH qemu 5/6] virtio-input: control device

2014-04-13 Thread Michael S. Tsirkin
On Fri, Apr 11, 2014 at 10:25:59AM +0200, Gerd Hoffmann wrote: > On Do, 2014-04-10 at 18:20 +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 10, 2014 at 02:10:20PM +0200, Gerd Hoffmann wrote: > > > On Do, 2014-04-10 at 14:05 +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 10, 2014 at 11:07:53A

Re: [Qemu-devel] Turning off default storage devices?

2014-04-13 Thread Andy Lutomirski
On Wed, Apr 9, 2014 at 8:13 PM, Peter Crosthwaite wrote: > On Thu, Apr 10, 2014 at 9:57 AM, Andy Lutomirski wrote: >> On Wed, Apr 9, 2014 at 4:53 PM, Peter Crosthwaite >> wrote: >>> Hi Andy, >>> >>> On Thu, Apr 10, 2014 at 5:55 AM, Andy Lutomirski >>> wrote: Currently, -M q35 boots linux

[Qemu-devel] [PATCH 3/3] monitor: Add device_add and device_del completion.

2014-04-13 Thread Hani Benhabiles
Also fix device_add completion including non-hotpluggable devices. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 ++ hmp.h | 2 ++ monitor.c | 38 -- 3 files changed, 28 insertions(+), 14 deletions(-) diff --git a/hmp-commands.hx b/

[Qemu-devel] [PATCH 1/3] monitor: Fix drive_del id argument type completion.

2014-04-13 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index f3fc514..6bf4797 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -176,7 +176,7 @@ ETEXI { .name = "drive_del",

[Qemu-devel] [PATCH 0/3] monitor: Improve command completion

2014-04-13 Thread Hani Benhabiles
This patch series adds a new callback to mon_cmd_t which will make adding completion support for more commands cleaner. It moves some existing commands completions to using the new callback and also fixes the completion for device_add and drive_del commands. Hani Benhabiles (3): monitor: Fix dr

[Qemu-devel] [PATCH 2/3] monitor: Add command_completion callback to mon_cmd_t.

2014-04-13 Thread Hani Benhabiles
Convert object_add and object_del commands to use the new callback. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 ++ hmp.h | 3 +++ monitor.c | 19 +-- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx in

[Qemu-devel] [PATCH] Add remove_boot_device_path() function for hot-unplug device

2014-04-13 Thread Jun Li
Add remove_boot_device_path() function to remove bootindex when hot-unplug a device. This patch fixed virtio-blk/virtio-net/scsi-disk/scsi-generic device. So it has fixed bug1086603, ref: https://bugzilla.redhat.com/show_bug.cgi?id=1086603 Signed-off-by: Jun Li --- hw/block/virtio-blk.c | 1 +

Re: [Qemu-devel] [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP

2014-04-13 Thread Borislav Petkov
Should we perhaps CC qemu-devel here for an opinion. Guys, this mail should explain the issue but in case there are questions, the whole thread starts here: http://lkml.kernel.org/r/20140407111725.GC25152@localhost Thanks. On Sat, Apr 12, 2014 at 01:35:49AM +0800, Jet Chen wrote: > On 04/12/201

Re: [Qemu-devel] [PATCH v2 00/17] monitor: Completion support for various commands

2014-04-13 Thread Hani Benhabiles
On Fri, Apr 11, 2014 at 01:50:57PM -0400, Luiz Capitulino wrote: > On Sun, 30 Mar 2014 11:58:22 +0100 > Hani Benhabiles wrote: > > > This patch series adds a new callback to mon_cmd_t which will make adding > > completion support for more commands cleaner. > > > > It then adds full or partial ar

[Qemu-devel] [PATCH v2] usb-ohci: Add vmstate descriptor

2014-04-13 Thread Alexey Kardashevskiy
This adds migration support for OHCI. This defines a descriptor for OHCIState. This changes some OHCIState field types to be migration compatible. This adds a descriptor for OHCIPort. This migrates the EOF timer if the USB was started at the time of migration. Cc: Gerd Hoffmann Cc: Peter Maydell