Re: [Qemu-devel] [PATCH 14/35] pc: exit QEMU if slots > 256

2014-04-06 Thread Igor Mammedov
On Fri, 4 Apr 2014 14:14:04 -0300 Eduardo Habkost wrote: > On Fri, Apr 04, 2014 at 03:36:39PM +0200, Igor Mammedov wrote: > > ... which is current ACPI implementation limit. > > > > Signed-off-by: Igor Mammedov > > With this we will have yet another hardcoded limit/assumption scattererd > in d

Re: [Qemu-devel] [PATCH 08/35] qdev: hotplug for buss-less devices

2014-04-06 Thread Igor Mammedov
On Mon, 07 Apr 2014 12:26:23 +1000 Alexey Kardashevskiy wrote: > On 04/05/2014 12:36 AM, Igor Mammedov wrote: > > Adds get_hotplug_handler() method to machine, and > > makes bus-less device to use it during hotplug > > as a means to discover hotplug handler controller. > > Returned controller is

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-06 Thread Gerd Hoffmann
On Do, 2014-04-03 at 11:42 +0200, Laszlo Ersek wrote: > (a) Gerd's packages: > > http://www.kraxel.org/repos/ > Under (a) you find some short instructions, and a set of RPMs that is > automatically rebuilt twice a day (IIRC). It polls the git repos once per hour and kicks a build on new commits.

[Qemu-devel] [Bug 1062220] Re: qemu-system-arm crashed with SIGABRT in cpu_abort()

2014-04-06 Thread Apport retracing service
** Tags added: trusty -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1062220 Title: qemu-system-arm crashed with SIGABRT in cpu_abort() Status in QEMU: New Status in “qemu” package in Ubuntu: I

[Qemu-devel] [PATCH 08/97] vmstate: Remove VMSTATE_UINTL_EQUAL_V

2014-04-06 Thread Juan Quintela
It was not used anywhere. Signed-off-by: Juan Quintela --- include/hw/hw.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/include/hw/hw.h b/include/hw/hw.h index 33bdb92..2b68ac3 100644 --- a/include/hw/hw.h +++ b/include/hw/hw.h @@ -51,22 +51,20 @@ int qemu_boot_

[Qemu-devel] [PATCH 65/97] vmstate: Remove version parameter from VMSTATE_STATIC_BUFFER

2014-04-06 Thread Juan Quintela
No user for it. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index b9d5a28..95e4e17 100644 --- a/include/migration/vmstate.h +++ b/include/mig

[Qemu-devel] [PATCH 43/97] vmstate: Remove unused VMSTATE_BUFFER_V

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index e7ceb59..fbf7dbe 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -654,

[Qemu-devel] [PATCH 47/97] vmstate: remove version from all variants of VMSTATE_STRUCT_POINTER*

2014-04-06 Thread Juan Quintela
There were no more users of them. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 3f2084b..61d677e 100644 --- a/include/migration/vm

[Qemu-devel] [PATCH 60/97] vmstate: VMSTATE_ARRAY_OF_POINTER didn't used the version_id field

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 5a26b6a..6d064de 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -296

[Qemu-devel] [PATCH 63/97] vmstate: Remove version paramenter from VMSTATE_ARRAY_OF_POINTER_TO_STRUCT

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/hw/ptimer.h | 2 +- include/migration/vmstate.h | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h index ef852bf..57a65e6 100644 --- a/include/hw/ptimer.h +++ b/include/hw/ptimer.h @@

[Qemu-devel] [PATCH 56/97] vmstate: Remove version_id fields that were not used

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 4 1 file changed, 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 553c909..95d0a9a 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -342,7 +342,6 @@ exter

[Qemu-devel] [PATCH 93/97] vmstate: Test for VMSTATE_PARTIAL_VBUFFER

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 79 1 file changed, 79 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 92e6bcc..6d8545c 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1100,

[Qemu-devel] [PATCH 18/97] vmstate: Test for VMSTATE_UINT32_TEST

2014-04-06 Thread Juan Quintela
Remove VMSTATE_UINT32_V, we are removing versioning. Move all users to VMSTATE_UINT32_TEST. Signed-off-by: Juan Quintela --- hw/arm/stellaris.c | 2 +- hw/display/pl110.c | 2 +- hw/gpio/pl061.c | 2 +- hw/intc/ioapic_common.c | 2 +- hw/misc/arm_sysctl.c

[Qemu-devel] [PATCH 55/97] vmstate: Remove version_id from VMSTATE_VBUFFER

2014-04-06 Thread Juan Quintela
None of its two users use it. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 2a38743..553c909 100644 --- a/include/migration/vmstate.h +++ b/in

[Qemu-devel] [PATCH 86/97] vmstate: Test for VMSTATE_PARTIAL_BUFFER

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 2fbcc02..7b49dda 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -954,10 +954,12 @@ static void test_array_sub(void)

[Qemu-devel] [PATCH 41/97] vmstate: Test for VMSTATE_UINT16_2DARRAY.

2014-04-06 Thread Juan Quintela
Remove unused _V version. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 5 + tests/test-vmstate.c| 10 ++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 24f2bcf..14c905a 100644

[Qemu-devel] [PATCH 73/97] vmstate: Remove version parameter from VMSTATE_VARRAY_UINT32

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/nvram/ds1225y.c | 2 +- hw/ppc/spapr_iommu.c| 3 ++- include/migration/vmstate.h | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/nvram/ds1225y.c b/hw/nvram/ds1225y.c index 332598b..cfedfa8 100644 --- a/hw/nvram/ds1225y

[Qemu-devel] [PATCH 20/97] vmstate: Test for VMSTATE_FLOAT64

2014-04-06 Thread Juan Quintela
Remove unused VMSTATE_FLOAT64_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 5 + tests/test-vmstate.c| 5 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 25032ef..eec4b13 100644 -

[Qemu-devel] [PATCH 04/97] vmstate: reduce code duplication

2014-04-06 Thread Juan Quintela
From: "Michael S. Tsirkin" move size offset and number of elements math out to functions, to reduce code duplication. Signed-off-by: Michael S. Tsirkin Cc: "Dr. David Alan Gilbert" Signed-off-by: Juan Quintela --- vmstate.c | 100 --

[Qemu-devel] [PATCH 24/97] vmstate: Test for VMSTATE_UINT16_EQUAL

2014-04-06 Thread Juan Quintela
We change only user of VMSTATE_UINT16_EQUAL_V to VMSTATE_UINT16_EQUAL_TEST. Signed-off-by: Juan Quintela --- hw/nvram/eeprom93xx.c | 7 ++- include/migration/vmstate.h | 8 tests/test-vmstate.c| 8 +++- 3 files changed, 17 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 46/97] vmstate: All ptimers users were at least at version 1 or more

2014-04-06 Thread Juan Quintela
So we can remove the version field. Signed-off-by: Juan Quintela --- include/hw/ptimer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h index 8ebacbb..ef852bf 100644 --- a/include/hw/ptimer.h +++ b/include/hw/ptimer.h @@ -28,7 +28,7

[Qemu-devel] [PATCH 61/97] vmstate: remove version parameter from VMSTATE_BUFFER_POINTER_UNSAFE

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/block/onenand.c | 2 +- hw/sd/sd.c | 2 +- include/migration/vmstate.h | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/block/onenand.c b/hw/block/onenand.c index 60d5311..87fbf00 100644 --- a/hw/block/onenand

[Qemu-devel] [PATCH 88/97] vmstate: Add tests for VMSTATE_BUFFER_TEST

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 63 1 file changed, 63 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 5609ff0..afcfbde 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1031,

[Qemu-devel] [PATCH 62/97] vmstate: Remove version, test and start parameter from VMSTATE_VBUFFER_UINT32

2014-04-06 Thread Juan Quintela
None of its users use them. Signed-off-by: Juan Quintela --- hw/char/exynos4210_uart.c | 2 +- hw/display/g364fb.c | 2 +- hw/dma/pl330.c | 8 hw/intc/exynos4210_gic.c| 2 +- hw/net/vmxnet3.c| 3 +-- hw/nvram/mac_nvram.c| 2 +- hw/sd/sdhci.

[Qemu-devel] [PATCH 72/97] vmstate: Introduce VMSTATE_VARRAY_UINT32_TEST

2014-04-06 Thread Juan Quintela
Use it on the only case were a version was used. Signed-off-by: Juan Quintela --- hw/misc/arm_sysctl.c| 5 +++-- include/migration/vmstate.h | 7 +-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/misc/arm_sysctl.c b/hw/misc/arm_sysctl.c index 0f61241..668681f 1006

[Qemu-devel] [PATCH 22/97] vmstate: Test for VMSTATE_BITMAP

2014-04-06 Thread Juan Quintela
Remove the unused version field (was unused). Signed-off-by: Juan Quintela --- hw/sd/sd.c | 2 +- include/migration/vmstate.h | 4 +- tests/test-vmstate.c| 90 + 3 files changed, 93 insertions(+), 3 deletions(-) diff --git a

[Qemu-devel] [PATCH 19/97] vmstate: Test for VMSTATE_UINT64_TEST

2014-04-06 Thread Juan Quintela
Remove VMSTATE_UINT64_V, we are removing versioning. Move all users to VMSTATE_UINT64_TEST. Signed-off-by: Juan Quintela --- hw/timer/mc146818rtc.c | 6 +++--- include/migration/vmstate.h | 9 +++-- target-i386/machine.c | 30 +++--- tests/test-vmstate.c

[Qemu-devel] [PATCH 68/97] vmstate: Remove version paramenter from VMSTATE_STRUCT_ARRAY

2014-04-06 Thread Juan Quintela
No users of that field left. Signed-off-by: Juan Quintela --- hw/arm/musicpal.c | 2 +- hw/audio/ac97.c | 2 +- hw/audio/es1370.c | 2 +- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/block/fdc.c| 2 +-

[Qemu-devel] [PATCH 70/97] vmstate: Remove unused version parameter from VMSTATE_STRUCT_VARRAY_INT32

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/input/stellaris_input.c | 2 +- include/migration/vmstate.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/input/stellaris_input.c b/hw/input/stellaris_input.c index 0609e80..07e7856 100644 --- a/hw/input/stellaris_input.c +++ b/hw/

[Qemu-devel] [PATCH 87/97] vmstate: Test for VMSTATE_BUFFER_START_MIDDLE

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 7b49dda..5609ff0 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -955,11 +955,13 @@ static void test_array_sub(void) t

[Qemu-devel] [PATCH 74/97] vmstate: Remove version parameter from VMSTATE_STRUCT_TEST

2014-04-06 Thread Juan Quintela
As we haven't yet moved everything that uses VMSTATE_STRUCT_TEST we create a temporary VMSTATE_STRUCT_INFO. This would allows us to not having to move fields to VMSTATE_STRUCT_TEST and then remove the version parameter. Signed-off-by: Juan Quintela --- hw/acpi/piix4.c | 2 +- includ

[Qemu-devel] [PATCH 39/97] vmstate: Test for VMSTATE_FLOAT64_ARRAY

2014-04-06 Thread Juan Quintela
Remove unused VMSTATE_FLOAT64_ARRAY_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 10 ++ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 35c7bef

[Qemu-devel] [PATCH 58/97] vmstate: Remove version parameter from VMSTATE_VARRAY_INT32

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- docs/migration.txt | 2 +- hw/block/fdc.c | 2 +- hw/display/qxl.c| 2 +- hw/display/vmware_vga.c | 2 +- hw/ide/core.c | 2 +- hw/pci/pci.c| 3 +-- include/migration/vmstate.h | 3 +-- target-arm

[Qemu-devel] [PATCH 69/97] vmstate: Remove version parameter from VMSTATE_STRUCT_ARRAY_TEST

2014-04-06 Thread Juan Quintela
No users left. Signed-off-by: Juan Quintela --- hw/char/escc.c | 2 +- hw/ide/internal.h | 2 +- hw/timer/i8254_common.c | 2 +- hw/timer/pxa2xx_timer.c | 2 +- hw/usb/hcd-xhci.c | 2 +- include/hw/acpi/pcihp.h | 2 +- include/migration/vmstate.h | 5

[Qemu-devel] [PATCH 85/97] vmstate: Test for VMSTATE_BUFFER

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 71 +++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index a087007..2fbcc02 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmst

[Qemu-devel] [PATCH 23/97] vmstate: Test for VMSTATE_UINT8_EQUAL

2014-04-06 Thread Juan Quintela
We intruduce another full test. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 2 +- tests/test-vmstate.c| 71 + 2 files changed, 72 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vms

Re: [Qemu-devel] [PATCH v5 08/11] spapr-iommu: add SPAPR VFIO IOMMU device

2014-04-06 Thread Alexey Kardashevskiy
On 04/03/2014 11:17 PM, Alexander Graf wrote: > > On 12.03.14 06:52, Alexey Kardashevskiy wrote: >> This adds SPAPR VFIO IOMMU device in order to support DMA operations >> for VFIO devices. > > Sorry if this has been mentioned before, but why exactly do you need a > separate IOMMU for VFIO? Could

[Qemu-devel] [PATCH 97/97] vmstate: Test for VMSTATE_VBUFFER_UINT32

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index ea24f26..4fa235d 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1104,13 +1104,18 @@ static void test_buffer_t

[Qemu-devel] [PATCH 95/97] vmstate: Create VMS_VBUFFER_UINT32

2014-04-06 Thread Juan Quintela
We were dereferencing an uint32_t as int32_t. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 3 ++- vmstate.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 6c503d9..976d83e 1

[Qemu-devel] [PATCH 91/97] vmstate: Remove unused VMSTATE_SUB_VBUFFER

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 84533eb..af38da7 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -644,9 +644,6 @@ extern

[Qemu-devel] [PATCH 82/97] vmstate: Test for VMSTATE_SYNTHETIC

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index f51c887..b3d77a2 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -95,6 +95,29 @@ TestSimple obj_si

[Qemu-devel] [PATCH 80/97] vmstate: Create VMSTATE_SYNTHETIC

2014-04-06 Thread Juan Quintela
It is used for fields that don't exist on the State. They are generated on the fly for migration. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 14 ++ target-alpha/machine.c | 16 +++- target-arm/machine.c| 18 ++ 3 files cha

[Qemu-devel] [PATCH 75/97] vmstate: Move all users of versioning to VMSTATE_STRUCT_TEST

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/usb/hcd-ehci-pci.c| 3 ++- hw/usb/hcd-ehci-sysbus.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c index 505741a..6ada623 100644 --- a/hw/usb/hcd-ehci-pci.c +++ b/hw/usb/hcd-ehci-pci.c @

[Qemu-devel] [PATCH 92/97] vmstate: Remove unused VMSTATE_PARTIAL_VBUFFER_UINT32

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index af38da7..6c7c751 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -641,9 +641,6 @@ extern

[Qemu-devel] [PATCH 90/97] vmstate: Test for VMSTATE_BUFFER_UNSAFE

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index afcfbde..92e6bcc 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -956,12 +956,14 @@ typedef struct Te

[Qemu-devel] [PATCH 67/97] vmstate: Move all users of versioning of VMSTATE_STRUCT_ARRAY to _TEST

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/char/escc.c | 4 ++-- hw/ide/internal.h | 3 ++- hw/timer/i8254_common.c | 5 +++-- target-i386/machine.c | 15 +-- 4 files changed, 16 insertions(+), 11 deletions(-) diff --git a/hw/char/escc.c b/hw/char/escc.c index 4875a2b..d

[Qemu-devel] [PATCH 81/97] vmstate: version_id is gone from fields

2014-04-06 Thread Juan Quintela
And after all this work, fields don't have version_id anymore. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 1 - vmstate.c | 5 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index

[Qemu-devel] [PATCH 79/97] vmstate: Create VMSTATE_OPENCODED_UNSAFE

2014-04-06 Thread Juan Quintela
This is trick, to use devices that haven't been converted inside vmstate state. It was already used on the "wild", so create a macro and convert the users. Signed-off-by: Juan Quintela --- hw/pci/msix.c | 10 +- hw/scsi/scsi-bus.c | 10 +- hw/usb/redirect.

[Qemu-devel] [PATCH 66/97] vmstate: Remove version field from VMSTATE_STRUCT_VARRAY_UINT32

2014-04-06 Thread Juan Quintela
No user of it. Signed-off-by: Juan Quintela --- hw/dma/pl330.c | 4 ++-- hw/timer/a9gtimer.c | 2 +- hw/timer/arm_mptimer.c | 2 +- hw/usb/hcd-xhci.c | 6 +++--- include/migration/vmstate.h | 3 +-- 5 files changed, 8 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 78/97] vmstate: Create VMSTATE_POINTER_UNSAFE

2014-04-06 Thread Juan Quintela
And use it on piix4 acpi. Comment asks for why this things happen! Signed-off-by: Juan Quintela --- hw/acpi/piix4.c | 15 +++ include/migration/vmstate.h | 8 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index

[Qemu-devel] [PATCH 77/97] vmstate: Create VMSTATE_VARRAY macro

2014-04-06 Thread Juan Quintela
Use it instead of hard-ecoding it on ich9 for GPE. Signed-off-by: Juan Quintela --- hw/acpi/ich9.c | 11 ++- include/migration/vmstate.h | 10 ++ 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 407ae89..f4801d1 10

Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-04-06 Thread Alexey Kardashevskiy
On 04/04/2014 11:28 PM, Alexander Graf wrote: > On 04/04/2014 07:17 AM, Alexey Kardashevskiy wrote: >> On 03/24/2014 04:28 PM, Alexey Kardashevskiy wrote: >>> Currently only migration fails if CPU version is different even a bit. >>> For example, migration from POWER7 v2.0 to POWER7 v2.1 fails beca

[Qemu-devel] [PATCH 76/97] vmstate: Remove version from all VMSTATE_STRUCT calls

2014-04-06 Thread Juan Quintela
It has no users at this point. Signed-off-by: Juan Quintela --- hw/acpi/piix4.c| 4 ++-- hw/arm/spitz.c | 2 +- hw/audio/pl041.c | 16 ++-- hw/block/fdc.c | 4 ++-- hw/char/exynos4210_uart.c |

[Qemu-devel] [PATCH 96/97] vmstate: Rename VMS_VBUFFER to VMST_VBUFFER_INT32 for consintency

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 6 +++--- vmstate.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 976d83e..145c198 100644 --- a/include/migration/vmstate.h +++

[Qemu-devel] [PATCH 48/97] vmstate: Port last 3 users of VMSTATE_ARRAY to VMSTATE_ARRAY_TEST

2014-04-06 Thread Juan Quintela
And then remove VMSTATE_ARRAY. Signed-off-by: Juan Quintela --- hw/net/vmxnet3.c| 13 +++-- include/migration/vmstate.h | 10 -- 2 files changed, 7 insertions(+), 16 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 781b06a..0c4d055 100644 --- a/hw/

[Qemu-devel] [PATCH 94/97] vmstate: ename VMSTATE_PARTIAL_VBUFFER to VMSTATE_VBUFFER_INT32

2014-04-06 Thread Juan Quintela
This is more consistent with VMSTATE_VBUFFER_UINT32 that also exist Signed-off-by: Juan Quintela --- hw/block/onenand.c | 2 +- include/migration/vmstate.h | 7 +-- tests/test-vmstate.c| 2 +- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/block/onenand.c

[Qemu-devel] [PATCH 84/97] vmstate: Test for VMSTATE_UINT32_SUB_ARRAY

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 49e98a8..a087007 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -873,6 +873,8 @@ static const VMStateDescription

[Qemu-devel] [PATCH 89/97] vmstate: Use VMSTATE_UINT8_2DARRAY instead of VMSTATE_BUFFER_TEST

2014-04-06 Thread Juan Quintela
In this two cases we have a 2D array, result is exactly the same, and one typechecks and the other don't, so change it. Signed-off-by: Juan Quintela --- hw/display/g364fb.c | 4 ++-- hw/net/smc91c111.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/display/g364fb.c b/

[Qemu-devel] [PATCH 45/97] vmstate: Remove unused version fields from ARM

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-ppc/machine.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/target-ppc/machine.c b/target-ppc/machine.c index d7807f8..4540fe2 100644 --- a/target-ppc/machine.c +++ b/target-ppc/machine.c @@ -120,11 +120,8 @@ static con

[Qemu-devel] [PATCH 83/97] vmstate: Test for VMSTATE_UINT8_SUB_ARRAY

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 76 1 file changed, 76 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index b3d77a2..49e98a8 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -864,6

[Qemu-devel] [PATCH 42/97] vmstate: Test for VMSTATE_UINT32_2DARRAY

2014-04-06 Thread Juan Quintela
Remove unused _V version. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 16 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 14c905a..e7ceb

[Qemu-devel] [PATCH 71/97] vmstate: Remove unused version parameter from VMSTATE_STRUCT_VARRAY_UINT8

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/timer/hpet.c | 2 +- include/migration/vmstate.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 2148568..0fd2eb0 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -304,7 +304,7 @@

[Qemu-devel] [PATCH 59/97] vmstate: Remove version_id from VMSTATE_VARRAY_UINT16_UNSAFE

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/nvram/eeprom93xx.c | 2 +- include/migration/vmstate.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/nvram/eeprom93xx.c b/hw/nvram/eeprom93xx.c index 7e09037..8f59509 100644 --- a/hw/nvram/eeprom93xx.c +++ b/hw/nvram/eeprom93x

[Qemu-devel] [PATCH 03/97] vmstate: return error in case of error

2014-04-06 Thread Juan Quintela
If there is an error while loading a field, we should stop reading and not continue with the rest of fields. Signed-off-by: Juan Quintela --- vmstate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/vmstate.c b/vmstate.c index bfa34cc..d82cccf 100644 --- a/vmstate.c +++ b/vmstate.c @@ -7

[Qemu-devel] [PATCH 37/97] vmstate: Test for VMSTATE_INT32_ARRAY{_TEST}

2014-04-06 Thread Juan Quintela
Change only user of _V to _TEST. Signed-off-by: Juan Quintela --- hw/pci-host/piix.c | 4 ++-- include/migration/vmstate.h | 12 ++-- tests/test-vmstate.c| 18 ++ 3 files changed, 26 insertions(+), 8 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci

[Qemu-devel] [PATCH 53/97] vmstate: Rename VMSTATE_POINTER_TEST without _TEST

2014-04-06 Thread Juan Quintela
The other didn't exist anymore. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index db70163..8dac300 100644 --- a/include/migration/vmstate.

[Qemu-devel] [PATCH 57/97] vmstate: Remove version_id from VMSTATE_SUB_ARRAY

2014-04-06 Thread Juan Quintela
None of its two users used it. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 95d0a9a..59afc3e 100644 --- a/include/migration/vmstate.h +++ b/i

[Qemu-devel] [PATCH 33/97] vmstate: Test for VMSTATE_UINT16_ARRAY

2014-04-06 Thread Juan Quintela
Remove unused VMSTATE_UINT16_ARRAY_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 7 ++- tests/test-vmstate.c| 5 + 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index c74cdf3..2579c4f 1

[Qemu-devel] [PATCH 32/97] vmstate: Test for VMSTATE_UINT8_ARRAY

2014-04-06 Thread Juan Quintela
Remove VMSTATE_UINT8_ARRAY_V that was unused. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 11 +++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index

[Qemu-devel] [PATCH 64/97] vmstate: Remove VMSTATE_BUFFER_MULTIPLY

2014-04-06 Thread Juan Quintela
It was unused. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 13 - vmstate.c | 3 --- 2 files changed, 16 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index ed70734..b9d5a28 100644 --- a/include/migration/vms

[Qemu-devel] [PATCH 50/97] vmstate: Remove unused VMSTATE_POINTER

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 - 1 file changed, 9 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index c9e72bb..141187c 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -203,15 +203,6 @@

[Qemu-devel] [PATCH 51/97] vmstate: Rename VMSTATE_SINGLE_TEST to VMSTATE_SINGLE

2014-04-06 Thread Juan Quintela
And as no user used the version_id, just remove the parameter. Signed-off-by: Juan Quintela --- hw/nvram/eeprom93xx.c | 2 +- hw/nvram/fw_cfg.c | 2 +- hw/timer/twl92230.c | 2 +- include/migration/vmstate.h | 36 +--- target-i386/machin

[Qemu-devel] [PATCH 31/97] vmstate: Test for VMSTATE_ARRAY_BOOL_TEST

2014-04-06 Thread Juan Quintela
We add all the boilerplate code for testing arrays. We change only user of VMSTATE_ARRAY_BOOL_V to VMSTATE_ARRAY_BOOL_TEST. Signed-off-by: Juan Quintela --- hw/audio/hda-codec.c| 3 +- include/migration/vmstate.h | 8 +-- tests/test-vmstate.c| 171

[Qemu-devel] [PATCH 49/97] vmstate: Port last user of VMSTATE_SINGLE to VMSTATE_SINGLE_TEST

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/timer/twl92230.c | 2 +- include/migration/vmstate.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/timer/twl92230.c b/hw/timer/twl92230.c index 7ded4ba..3aacaeb 100644 --- a/hw/timer/twl92230.c +++ b/hw/timer/twl92230.c @@ -7

[Qemu-devel] [PATCH 54/97] vmstate: Rename VMSTATE_ARRAY_TEST to VMSTATE_ARRAY

2014-04-06 Thread Juan Quintela
VMSTATE_ARRAY is not being used anymore. Signed-off-by: Juan Quintela --- hw/net/vmxnet3.c| 9 - include/migration/vmstate.h | 20 ++-- target-i386/machine.c | 6 +++--- target-ppc/machine.c| 4 ++-- 4 files changed, 19 insertions(+), 20 delet

[Qemu-devel] [PATCH 29/97] vmstate: s/VMSTATE_INT32_LE/VMSTATE_INT32_POSITIVE_LE/

2014-04-06 Thread Juan Quintela
From: "Michael S. Tsirkin" As the macro verifies the value is positive, rename it to make the function clearer. Signed-off-by: Michael S. Tsirkin Signed-off-by: Juan Quintela --- hw/pci/pci.c| 4 ++-- include/migration/vmstate.h | 3 +-- target-arm/machine.c| 2 +- tes

[Qemu-devel] [PATCH 38/97] vmstate: Test for VMSTATE_INT64_ARRAY

2014-04-06 Thread Juan Quintela
Remove unused VMSTATE_INT64_ARRAY_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 9 + 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 20062ff..35c

[Qemu-devel] [PATCH 52/97] vmstate: Move VMSTATE_2DARRAY to use _test

2014-04-06 Thread Juan Quintela
No user used versions, so easy to change. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 6d5073a..db70163 100644 --- a/includ

[Qemu-devel] [PATCH 36/97] vmstate: Test for VMSTATE_INT16_ARRAY

2014-04-06 Thread Juan Quintela
Remove unused VMSTATE_INT16_ARRAY_V Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 5 + 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 3271114..5e62206 1

[Qemu-devel] [PATCH 40/97] vmstate: Test for VMSTATE_UINT8_2DARRAY

2014-04-06 Thread Juan Quintela
Remove unused _V version. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 19 ++- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index f925cc6..24

[Qemu-devel] [PATCH 44/97] vmstate: Remove version from VMSTATE_BUFFER_UNSAFE

2014-04-06 Thread Juan Quintela
All users used 0 anyways. Rename VMSTATE_BUFFER_UNSAFE_INFO to VMSTATE_BUFFER_UNSAFE_TEST to be consistent with rest of fields. Signed-off-by: Juan Quintela --- hw/display/g364fb.c | 4 ++-- hw/net/smc91c111.c | 2 +- hw/pci/pci.c| 10 ++ hw/scsi/esp-p

[Qemu-devel] [PATCH 34/97] vmstate: Test for VMSTATE_UINT32_ARRAY{_TEST}

2014-04-06 Thread Juan Quintela
Once there, change only user of VMSTATE_UInT32_ARRAY_V. Signed-off-by: Juan Quintela --- hw/misc/arm_sysctl.c| 3 ++- include/migration/vmstate.h | 15 ++- tests/test-vmstate.c| 18 ++ 3 files changed, 26 insertions(+), 10 deletions(-) diff --git a/h

[Qemu-devel] [PATCH 30/97] vmstate: Move VMSTATE_TIMER_V to VMSTATE_TIMER_TEST

2014-04-06 Thread Juan Quintela
No test created, because it is basically imposible to create a timer by hand :-( Signed-off-by: Juan Quintela --- hw/timer/mc146818rtc.c | 2 +- include/migration/vmstate.h | 7 ++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818

[Qemu-devel] [PATCH 21/97] vmstate: Test for VMSTATE_UNUSED

2014-04-06 Thread Juan Quintela
Remove VMSTATE_UNUSED_V and fix only user. Signed-off-by: Juan Quintela --- hw/intc/ioapic_common.c | 3 ++- include/migration/vmstate.h | 11 ++- tests/test-vmstate.c| 5 + 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/intc/ioapic_common.c b/hw/int

[Qemu-devel] [PATCH 26/97] vmstate: Test for VMSTATE_UINT64_EQUAL

2014-04-06 Thread Juan Quintela
Remove unused VMSTATE_UINT64_EQUAL_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 2 ++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 267ce4e..55750f4 10

[Qemu-devel] [PATCH 16/97] vmstate: Test for VMSTATE_UINT8_TEST

2014-04-06 Thread Juan Quintela
Remove VMSTATE_UINT8_V, we are removing versioning. Move all users to VMSTATE_UINT8_TEST. Signed-off-by: Juan Quintela --- hw/char/serial.c| 2 +- hw/ide/core.c | 2 +- hw/net/ne2000.c | 2 +- hw/timer/ds1338.c | 2 +- hw/timer/hpet.c

[Qemu-devel] [PATCH 35/97] vmstate: Test for VMSTATE_UINT64_ARRAY{_TEST}

2014-04-06 Thread Juan Quintela
CHange users of _V to _TEST. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 12 ++-- target-i386/machine.c | 5 +++-- tests/test-vmstate.c| 22 ++ 3 files changed, 31 insertions(+), 8 deletions(-) diff --git a/include/migration/vmstate.

[Qemu-devel] [PATCH 10/97] vmstate: Remove unused VMSTATE_UINTTL_ARRAY_V

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/hw/hw.h | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/include/hw/hw.h b/include/hw/hw.h index 211eb8b..2c19297 100644 --- a/include/hw/hw.h +++ b/include/hw/hw.h @@ -53,21 +53,18 @@ int qemu_boot_set(const char *boot_order

[Qemu-devel] [PATCH 25/97] vmstate: Test for VMSTATE_UINT32_EQUAL

2014-04-06 Thread Juan Quintela
Remove unused VMSTATE_UINT32_EQUAL_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 2 ++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index e6f6a46..267ce4e 10

[Qemu-devel] [PATCH 27/97] vmstate: Test for VMSTATE_INT32_EQUAL

2014-04-06 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 2 +- tests/test-vmstate.c| 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 55750f4..9eec546 100644 --- a/include/migration/vmstate.h +++ b/in

[Qemu-devel] [PATCH 14/97] vmstate: Test for VMSTATE_INT32_TEST

2014-04-06 Thread Juan Quintela
Remove VMSTATE_INT32_V, we are removing versioning. Move all users to use tests. Signed-off-by: Juan Quintela --- hw/input/ps2.c | 2 +- include/migration/vmstate.h | 6 +++--- target-i386/machine.c | 4 ++-- tests/test-vmstate.c| 4 4 files changed, 10 insertions

[Qemu-devel] [PATCH 28/97] vmstate: Test for VMSTATE_INT32_LE

2014-04-06 Thread Juan Quintela
Add tests for less/more than the value on destination. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 4 ++-- tests/test-vmstate.c| 25 - 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migrati

[Qemu-devel] [PATCH 13/97] vmstate: Test for VMSTATE_INT16_TEST

2014-04-06 Thread Juan Quintela
Remove VMSTATES_INT16_V, we are removing versioning, would use only tests. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 6 +++--- tests/test-vmstate.c| 4 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration

[Qemu-devel] [PATCH 11/97] vmstate: Test for VMSTATE_BOOL_TEST

2014-04-06 Thread Juan Quintela
Remove VMSTATE_BOOL_V, we are removing versioning, would use only tests. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 6 ++-- tests/test-vmstate.c| 75 - 2 files changed, 77 insertions(+), 4 deletions(-) diff --git a/include

[Qemu-devel] [PATCH 17/97] vmstate: Test for VMSTATE_UINT16_TEST

2014-04-06 Thread Juan Quintela
Remove VMSTATE_UINT16_V, we are removing versioning. Move all users to VMSTATE_UINT16_TEST. Signed-off-by: Juan Quintela --- hw/char/serial.c| 2 +- hw/net/lan9118.c| 4 ++-- include/migration/vmstate.h | 9 +++-- target-i386/machine.c | 8 tests/test-vm

[Qemu-devel] [PATCH 06/97] vmstate: Refactor & increase tests for primitive types

2014-04-06 Thread Juan Quintela
This commit refactor the simple tests to test all integer types. We move to hex because it is easier to read values of different types. Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 195 +++ 1 file changed, 150 insertions(+), 45 deletions

[Qemu-devel] [PATCH 12/97] vmstate: Test for VMSTATE_INT8_TEST

2014-04-06 Thread Juan Quintela
Remove VMSTATE_INT8_V, we are removing versioning, would use only tests. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 6 +++--- tests/test-vmstate.c| 4 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/v

[Qemu-devel] [PATCH 15/97] vmstate: test for VMSTATE_INT64_TEST

2014-04-06 Thread Juan Quintela
Remove VMSTATE_INT64_V, we are removing versioning. Move all users to VMSTATE_INT64_TEST. Signed-off-by: Juan Quintela --- cpus.c | 2 +- hw/timer/mc146818rtc.c | 2 +- hw/usb/hcd-uhci.c | 2 +- include/migration/vmstate.h | 6 +++--- tests/test-vmstate.c

[Qemu-devel] [PATCH 09/97] vmstate: Change VMSTATE_INTTL_V to VMSTATE_INTTL_TEST

2014-04-06 Thread Juan Quintela
And fix all users. VMSTATE_UINT64_TEST don't exist. Create it. Signed-off-by: Juan Quintela --- include/hw/hw.h | 10 +- include/migration/vmstate.h | 3 +++ target-i386/machine.c | 4 ++-- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/include/hw/hw

[Qemu-devel] [PATCH 01/97] savevm: Ignore minimum_version_id_old if there is no load_state_old

2014-04-06 Thread Juan Quintela
From: Peter Maydell At the moment we require vmstate definitions to set minimum_version_id_old to the same value as minimum_version_id if they do not provide a load_state_old handler. Since the load_state_old functionality is required only for a handful of devices that need to retain migration co

  1   2   >