[Qemu-devel] [Bug 1299566] [NEW] virtio serial doesn't work with virtio nic

2014-03-29 Thread zielmicha
Public bug reported: If virtio NIC is not used virtserialport works and delivers data written to /dev/vport0p1 to localhost:: qemu-system-x86_64 -enable-kvm -kernel mykernel -initrd myramdisk -device virtio-serial -chardev socket,host=localhost,port=,id=agent -device virtserialport,charde

Re: [Qemu-devel] [PATCH 0/8] tcg: tidy the type of code_ptr

2014-03-29 Thread Peter Maydell
On 29 March 2014 00:27, Richard Henderson wrote: > Here's where I think we should go with the cleanup that Peter started. > > I've only converted a couple of the backends as examples. It's not 100% > mechanical, since one has to be aware of the change in the semantics of > pointer arithmetic (e.g

Re: [Qemu-devel] [PATCH] xbzrle: don't check the value in the vm ram repeatedly

2014-03-29 Thread Eric Blake
On 03/29/2014 09:12 AM, 陈梁 wrote: >/* word at a time for speed */ >if (!res) { >while (i < slen && > (*(long *)(old_buf + i)) == (*(long *)(new_buf + i))) { >i += sizeof(long); >zrun_len += sizeof(long); >} >

Re: [Qemu-devel] [PATCH] xbzrle: don't check the value in the vm ram repeatedly

2014-03-29 Thread Eric Blake
On 03/29/2014 09:00 AM, 陈梁 wrote: >>> You really need to do the "go over the rest" loop on an 8-byte temporary >>> variable. Ever since your patch made new_buf be a volatile buffer, >>> rather than a static copy, you MUST visit each byte of new_buf exactly once. >>> >> hmm, thanks. get it. Maybe

Re: [Qemu-devel] [PATCH] xbzrle: don't check the value in the vm ram repeatedly

2014-03-29 Thread Eric Blake
On 03/29/2014 08:15 AM, 陈梁 wrote: >> >> Insufficient. Observe what we did at line 52 when looking for the zero-run: >> /* word at a time for speed */ if (!res) { while (i < slen && (*(long *)(old_buf + i)) == (*(long *)(new_buf + i)))

Re: [Qemu-devel] [PATCH] xbzrle: don't check the value in the vm ram repeatedly

2014-03-29 Thread 陈梁
> On 03/29/2014 01:52 AM, arei.gong...@huawei.com wrote: >> From: ChenLiang >> >> xbzrle_encode_buffer checks the value in the ram repeatedly. >> It is risk if runs xbzrle_encode_buffer on changing data. >> And it is not necessary. >> >> Reported-by: Dr. David Alan Gilbert >> Signed-off-by: C

[Qemu-devel] [Bug 1299190] [NEW] Access to /proc/self/exe in linux-user mode

2014-03-29 Thread Yury Gribov
Public bug reported: This is based on a recent bug in GCC Bugzilla: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60681 It looks like libbacktrace (GCC runtime library used for obtaining stack traces) uses /proc/self/exe for error reporting. Currently this is mapped to qemu-arm which effectively di

Re: [Qemu-devel] [PATCH] xbzrle: don't check the value in the vm ram repeatedly

2014-03-29 Thread Eric Blake
On 03/29/2014 01:52 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > xbzrle_encode_buffer checks the value in the ram repeatedly. > It is risk if runs xbzrle_encode_buffer on changing data. > And it is not necessary. > > Reported-by: Dr. David Alan Gilbert > Signed-off-by: ChenLiang >

Re: [Qemu-devel] [PATCH v4 7/8] migration: optimize xbzrle by reducing data copy

2014-03-29 Thread Gonglei (Arei)
> > Hi Gonglei, > > I've got a world which has this patch series on, and it's producing some > XBZRLE > errors, > and I suspect that it's down to my original worries of running > xbzrle_encode_buffer > on changing data. > > My setup is a pair of machines, with a guest with 4GB RAM running SPECj

[Qemu-devel] [PATCH] xbzrle: don't check the value in the vm ram repeatedly

2014-03-29 Thread arei.gonglei
From: ChenLiang xbzrle_encode_buffer checks the value in the ram repeatedly. It is risk if runs xbzrle_encode_buffer on changing data. And it is not necessary. Reported-by: Dr. David Alan Gilbert Signed-off-by: ChenLiang Signed-off-by: Gonglei --- xbzrle.c | 4 1 file changed, 4 inserti

[Qemu-devel] [PATCH] rdma: Fix block during rdma migration

2014-03-29 Thread arei.gonglei
From: Mo Yuxiang If the networking break or there's something wrong with rdma device(ib0 with no IP) during rdma migration, the main_loop of qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event to fix this bug. Signed-off-by: Mo Yuxiang Signed-off-by: Gonglei --- migration-rdma.c