On Sat, Dec 7, 2013 at 5:24 AM, Peter Maydell wrote:
> On 6 December 2013 19:12, Michael Tokarev wrote:
>> 06.12.2013 22:43, Stefan Weil wrote:
>>> The memory region can be included by value instead of by reference in the
>>> device state (like it is done in other SoCs).
So following on from the
Cc: Michael Walle
Signed-off-by: Richard Henderson
---
target-lm32/translate.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/target-lm32/translate.c b/target-lm32/translate.c
index 6ea0ecd..3d2f2e8 100644
--- a/target-lm32/translate.c
+++ b/target-lm32/tran
Using the new opcodes we can reduce if/else trees to
a single statement.
Cc: Edgar E. Iglesias
Signed-off-by: Richard Henderson
---
target-cris/translate.c | 29 -
1 file changed, 4 insertions(+), 25 deletions(-)
diff --git a/target-cris/translate.c b/target-cris/tr
Am 29.11.2013 11:17, schrieb Paolo Bonzini:
> This series fixes hot-unplug of virtio devices, which can crash due to
> dangling pointer accesses.
>
> The current implementation supports guest-initiated hot-unplug via the
> virtio_bus_destroy_device function, but not hot-unplugging the virtio
> dev
On 12/06/2013 05:16 PM, Ren, Qiaowei wrote:
> Jinsong think that both kvm and host depend on these feature definition
> header file, so we firstly submit these files depended on.
Yes, but we can't turn on the feature without proper protection. Either
way, they are now in tip:x86/cpufeature.
> -Original Message-
> From: H. Peter Anvin [mailto:h...@zytor.com]
> Sent: Saturday, December 07, 2013 9:07 AM
> To: Ren, Qiaowei; Liu, Jinsong; Paolo Bonzini
> Cc: k...@vger.kernel.org; x...@kernel.org; Xudong Hao;
> qemu-devel@nongnu.org; linux-ker...@vger.kernel.org; Ingo Molnar; Thom
On 7 December 2013 00:55, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov
> ---
> target-arm/cpu-qom.h | 1 +
> target-arm/cpu.c | 13 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h
> index b55306a..116320c 100644
> --- a/t
On Sat, Dec 7, 2013 at 10:55 AM, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov
> ---
> target-arm/cpu.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/target-arm/cpu.c b/target-arm/cpu.c
> index f838499..6f548c7 100644
> --- a/target-arm/cpu.c
> +++ b/target-arm/cpu.c
> @@ -1
On 12/06/2013 04:23 PM, Ren, Qiaowei wrote:
>>>
>>> We need to either disable these features in lazy mode, or we need to
>>> force eager mode if these features are to be supported. The problem
>>> with the latter is that it means forcing eager mode regardless of if
>>> anything actually *uses* the
On Fri, 06 Dec 2013 22:59:29 +0400
Michael Tokarev wrote:
> 04.12.2013 10:27, Antony Pavlov wrote:
> > scripts/checkpatch.pl reports about some style problems,
> > this commit fixes some of them:
>
> Thanks, applied to trivial-patches queue.
>
> I'm a bit afraid of this sort of patches - there
ping
http://patchwork.ozlabs.org/patch/295442/
From: Andreas Färber [afaer...@suse.de]
Sent: Friday, November 29, 2013 6:04 PM
To: Petar Jovanovic; qemu-devel@nongnu.org
Cc: Petar Jovanovic; aurel...@aurel32.net; qemu-stable
Subject: Re: [Qemu-devel] [PATC
On Sat, Dec 7, 2013 at 10:55 AM, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov
> ---
> target-arm/cpu-qom.h | 1 +
> target-arm/cpu.c | 13 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h
> index b55306a..116320c 100644
>
Signed-off-by: Antony Pavlov
---
target-arm/cpu.c | 4
1 file changed, 4 insertions(+)
diff --git a/target-arm/cpu.c b/target-arm/cpu.c
index f838499..6f548c7 100644
--- a/target-arm/cpu.c
+++ b/target-arm/cpu.c
@@ -126,6 +126,10 @@ static void arm_cpu_reset(CPUState *s)
env->c
[RFC 1/2] ARM: cpu: add "hivecs" property (high vectors on reset)
[RFC 2/2] ARM: arm_cpu_reset: make possible to use high vectors for
Signed-off-by: Antony Pavlov
---
target-arm/cpu-qom.h | 1 +
target-arm/cpu.c | 13 +
2 files changed, 14 insertions(+)
diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h
index b55306a..116320c 100644
--- a/target-arm/cpu-qom.h
+++ b/target-arm/cpu-qom.h
@@ -128,6 +128,7 @
Retain the existing gen_aa32_* inlines, to aid compilation for A64.
Cc: Peter Maydell
Signed-off-by: Richard Henderson
---
target-arm/translate.c | 57 ++
1 file changed, 25 insertions(+), 32 deletions(-)
diff --git a/target-arm/translate.c b/tar
> -Original Message-
> From: Liu, Jinsong
> Sent: Saturday, December 07, 2013 6:13 AM
> To: H. Peter Anvin; Paolo Bonzini; Ren, Qiaowei
> Cc: k...@vger.kernel.org; x...@kernel.org; Xudong Hao;
> qemu-devel@nongnu.org; linux-ker...@vger.kernel.org; Ingo Molnar; Thomas
> Gleixner
> Subject:
This patch defines xstate feature and extends struct xsave_hdr_struct
to support Intel MPX.
Signed-off-by: Qiaowei Ren
Signed-off-by: Xudong Hao
Signed-off-by: Liu Jinsong
---
arch/x86/include/asm/processor.h | 12
arch/x86/include/asm/xsave.h |6 +-
2 files changed,
Paolo Bonzini writes:
> Resetting should be done in post-order, not pre-order. However,
> qdev_walk_children and qbus_walk_children do not allow this. Fix
> it by adding two extra arguments to the functions.
> Signed-off-by: Paolo Bonzini
> ---
> hw/core/qdev.c | 45
On Fri, 2013-12-06 at 23:06 +0100, Paolo Bonzini wrote:
> Il 06/12/2013 21:48, Alex Williamson ha scritto:
> > /* Extra debugging, trap acceleration paths for more logging */
> > #define VFIO_ALLOW_MMAP 1
> > #define VFIO_ALLOW_KVM_INTX 1
> > +#define VFIO_ALLOW_KVM_MSI 1
> > +#define VFIO_ALLOW
H. Peter Anvin wrote:
> On 12/06/2013 12:05 PM, Liu, Jinsong wrote:
>>>
>>> Since Peter already said the same, please undo these changes.
>>>
>>> Also, how is XSTATE_EAGER used? Should MPX be disabled when
>>> xsaveopt is disabled on the kernel command line? (Liu, how would
>>> this affect the
Il 06/12/2013 21:48, Alex Williamson ha scritto:
> /* Extra debugging, trap acceleration paths for more logging */
> #define VFIO_ALLOW_MMAP 1
> #define VFIO_ALLOW_KVM_INTX 1
> +#define VFIO_ALLOW_KVM_MSI 1
> +#define VFIO_ALLOW_KVM_MSIX 1
Why not make these device properties instead?
Paolo
The size of tlb_table is 4k on a 64-bit host. For overwriting
memory at this size, cacheline tricks can help.
Signed-off-by: Richard Henderson
---
cputlb.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/cputlb.c b/cputlb.c
index fff0afb..d2da404 100644
Don't duplicate the array length computation in the memset
when plain sizeof can produce the correct results.
Signed-off-by: Richard Henderson
---
cputlb.c| 2 +-
translate-all.c | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/cputlb.c b/cputlb.c
index d2da404..
On 12/06/2013 12:05 PM, Liu, Jinsong wrote:
>>
>> Since Peter already said the same, please undo these changes.
>>
>> Also, how is XSTATE_EAGER used? Should MPX be disabled when xsaveopt
>> is disabled on the kernel command line? (Liu, how would this affect
>> the KVM patches, too?)
>>
>> Paolo
>
Update to tag v3.13-rc3 (374b105797c3d4f29c685f3be535c35f5689b30e)
Signed-off-by: Alex Williamson
---
linux-headers/asm-arm/kvm.h |3 +
linux-headers/asm-powerpc/epapr_hcalls.h |4 +
linux-headers/asm-powerpc/kvm.h | 86 +-
linux-header
It's sometimes useful to be able to verify interrupts are passing
through correctly.
Signed-off-by: Alex Williamson
---
hw/misc/vfio.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index 09bdddf..f367537 100644
---
Add and remove groups from the KVM virtual VFIO device as we make
use of them. This allows KVM to optimize for performance and
correctness based on properties of the group.
Signed-off-by: Alex Williamson
---
hw/misc/vfio.c | 67
1 file
Public bug reported:
Whenever I run ``qemu-system-i386 -curses ...'' (with or without a ``-k
en-gb'') on OS X 10.9, the keyboard does not work properly. For example,
when attempting to switch to the QEMU console with Alt+2, I get:
``Warning: no scancode found for keysym 226
Warning: no scancode f
EDIT: I should have mentioned that this is using QEMU 1.6.1, but the
problem also occurs with 1.3.1. Also, in case it makes a difference, I
installed QEMU using Homebrew.
** Description changed:
Whenever I run ``qemu-system-i386 -curses ...'' (with or without a ``-k
en-gb'') on OS X 10.9, the
When MSI is enabled on Nvidia GeForce cards the driver seems to
acknowledge the interrupt by writing a 0xff byte to the MSI capability
ID register using the PCI config space mirror at offset 0x88000 from
BAR0. Without this, the device will only fire a single interrupt.
VFIO handles the PCI capabil
We were relying on msix_unset_vector_notifiers() to release all the
vectors when we disable MSI-X, but this only happens when MSI-X is
still enabled on the device. Perform further cleanup by releasing
any remaining vectors listed as in-use after this call. This caused
a leak of IRQ routes on hotp
Anthony,
The following changes since commit 7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e:
Open 2.0 development tree (2013-11-27 14:02:45 -0800)
are available in the git repository at:
git://github.com/awilliam/qemu-vfio.git tags/vfio-pci-for-qemu-20131206.0
for you to fetch changes up to 3e40b
Il 06/12/2013 20:04, Michael Tokarev ha scritto:
> 06.12.2013 19:08, Paolo Bonzini wrote:
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -2089,7 +2089,7 @@ ETEXI
>> DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
>> "-iscsi [user=user][,password=password]\n"
>> " [,header-digest=
Paolo Bonzini wrote:
> Il 07/12/2013 01:20, Qiaowei Ren ha scritto:
>> This patch defines xstate feature and extends struct xsave_hdr_struct
>> to support Intel MPX.
>>
>> Signed-off-by: Qiaowei Ren
>> Signed-off-by: Xudong Hao
>> Signed-off-by: Liu Jinsong
>> ---
>> arch/x86/include/asm/proce
On Fri, Dec 06, 2013 at 10:06:37AM +0100, Paolo Bonzini wrote:
> Il 04/12/2013 08:58, Wanlong Gao ha scritto:
> > According to this patch set, we are able to set guest nodes memory policy
> > like following:
> >
> > -numa node,nodeid=0,cpus=0, \
> > -numa mem,size=1024M,policy=membind,host-nodes
This definition has been moved to prep.c.
Signed-off-by: Michael Tokarev
---
hw/ppc/mac.h |1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/mac.h b/hw/ppc/mac.h
index 1e578dd..c1faf9c 100644
--- a/hw/ppc/mac.h
+++ b/hw/ppc/mac.h
@@ -34,7 +34,6 @@
#define MAX_CPUS 1
#define BIOS_SI
From: Stefan Weil
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCqobject/qerror.o
qobject/qerror.c: In function ‘qerror_from_info’:
qobject/qerror.c:53:5: error:
function might be possible candidate for ‘gnu_printf’ format attribute
[-Werror=suggest-attribute
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
Reviewed-by: Fam Zheng
Signed-off-by: Michael Tokarev
---
hw/net/virtio-net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index b75c753..90eca9a 100644
--- a/hw/net/virtio-net.c
+
From: Stefan Weil
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCm68k-softmmu/hw/m68k/mcf5206.o
hw/i386/acpi-build.c: In function ‘build_append_nameseg’:
hw/i386/acpi-build.c:294:5: error:
function might be possible candidate for ‘gnu_printf’ format attribute
On 6 December 2013 19:12, Michael Tokarev wrote:
> 06.12.2013 22:43, Stefan Weil wrote:
>> The memory region can be included by value instead of by reference in the
>> device state (like it is done in other SoCs).
>>
>> Signed-off-by: Stefan Weil
>> ---
>> hw/arm/highbank.c |7 +++
>> 1
From: Stefan Weil
Warning from ccc-analyzer:
libcacard/vcard_emul_nss.c:937:9: warning:
Value stored to 'cert_count' is never read
cert_count = options->vreader[i].cert_count;
^~~
Signed-off-by: Stefan Weil
Signed-off-by: Michael Tokarev
From: Don Koch
Prevent a call to put_kbd if null.
On shutdown of some OSes, the keyboard handler goes away before the
system is down. If a key is typed during this window, qemu crashes.
Signed-off-by: Don Koch
Signed-off-by: Michael Tokarev
---
ui/input.c |2 +-
1 file changed, 1 inserti
From: Antony Pavlov
scripts/checkpatch.pl reports about some style problems,
this commit fixes some of them:
ERROR: space prohibited before open square bracket '['
+.fields = (VMStateField []) {
ERROR: space prohibited after that '!' (ctx:BxW)
+if (! eeprom->eecs && eecs) {
From: Stefan Weil
Warning from ccc-analyzer:
libcacard/cac.c:192:13: warning: Value stored to 'ret' is never read
ret = VCARD_DONE;
^ ~~
Here 'ret' is assigned a value inside of a switch statement and also after
that switch statement.
Signed-off-by: Stefan W
From: Stefan Weil
Most code already used QEMUTimer without the redundant 'struct' keyword.
Signed-off-by: Stefan Weil
Reviewed-by: Andreas Färber
Signed-off-by: Michael Tokarev
---
hw/char/cadence_uart.c |4 ++--
hw/ppc/ppc.c |6 +++---
hw/ppc/ppc405_uc.c |2 +
Provide generic hotplug interface for devices.
Intended for replacing hotplug mechanism used by
PCI/PCIE/SHPC code.
Signed-off-by: Igor Mammedov
---
it's scsi-bus like interface, but abstracted from bus altogether
since all current users care about in hotplug handlers, it's
hotplug device and hot
From: Stefan Weil
Signed-off-by: Stefan Weil
Signed-off-by: Michael Tokarev
---
trace-events |5 +
ui/gtk.c | 19 +--
2 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/trace-events b/trace-events
index d196234..bc6788f 100644
--- a/trace-events
+++
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Stefan Weil
Signed-off-by: Michael Tokarev
---
.gitignore |1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 5584b5f..1c9d63d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,6 +3,7 @@ config-all-devices.*
From: Stefan Weil
This reduces the dependencies on trace.h.
Only two source files which need console.h also need trace.h.
Signed-off-by: Stefan Weil
Signed-off-by: Michael Tokarev
---
hw/display/vmware_vga.c |1 +
include/ui/console.h|1 -
ui/console.c|1 +
3 files
From: Stefan Weil
Signed-off-by: Stefan Weil
Reviewed-by: Gerd Hoffmann
Signed-off-by: Michael Tokarev
---
trace-events |2 ++
ui/console.c | 11 +++
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/trace-events b/trace-events
index 8695e9e..d196234 100644
--- a/tr
Here's the first trivial-patches pull request after 1.7.
It contains the few patches which were requested for 1.7
but hasn't been applied, plus a few more patches which
weren't supposed to be included in 1.7.
Please pull.
Thanks,
/mjt
The following changes since commit 7dc65c02fe3fb8f3146ce0b9f
From: Stefan Weil
This reduces the dependencies on trace.h.
Only one source file which needs hcd-ehci.h also needs trace.h.
Signed-off-by: Stefan Weil
Signed-off-by: Michael Tokarev
---
hw/usb/hcd-ehci.c |1 +
hw/usb/hcd-ehci.h |1 -
2 files changed, 1 insertion(+), 1 deletion(-)
dif
06.12.2013 22:43, Stefan Weil wrote:
> The memory region can be included by value instead of by reference in the
> device state (like it is done in other SoCs).
>
> Signed-off-by: Stefan Weil
> ---
> hw/arm/highbank.c |7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --
On 12/06/2013 10:22 AM, Kevin Wolf wrote:
> For an O_DIRECT request to succeed, it's not only necessary that all
> base addresses in the qiov are aligned, but also that each lengh in it
s/lengh/length/
> is aligned.
>
> Signed-off-by: Kevin Wolf
> ---
> block.c | 3 +++
> 1 file changed, 3 ins
Series is replacement for a more simple attempt to generalize hotplug API
http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02529.html
promted by Paolo in this patch review.
--
Refactor PCI specific hotplug API to a more generic/reusable one.
Model it after SCSI-BUS like hotplug API replacin
06.12.2013 19:08, Paolo Bonzini wrote:
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2089,7 +2089,7 @@ ETEXI
> DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
> "-iscsi [user=user][,password=password]\n"
> " [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n"
> -" [,in
From: Fam Zheng
This replaces _unsupported_qemu_io_options and check for support of
current cache mode, and allow to provide a default if user didn't
specify.
Signed-off-by: Fam Zheng
Reviewed-by: Wenchao Xia
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/026 | 3 ++-
tests/qem
04.12.2013 10:27, Antony Pavlov wrote:
> scripts/checkpatch.pl reports about some style problems,
> this commit fixes some of them:
Thanks, applied to trivial-patches queue.
I'm a bit afraid of this sort of patches - there are LOTS of
coding style issues in current qemu code base, and applying
a
From: Paolo Bonzini
Writing zeroes to a file can be done by punching a hole if
MAY_UNMAP is set.
Note that in this case ENOTSUP is not ignored, but makes
the block layer fall back to the generic implementation.
Signed-off-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
block/raw-posix.c
Am 06.12.2013 19:48, schrieb Michael Tokarev:
> 06.12.2013 16:52, Alexander Graf wrote:
>> When we're running in non-64bit mode with qemu-system-x86_64 we can
>> still end up with virtual addresses that are above the 32bit boundary
>> if a segment offset is set up.
>>
>> GNU Hurd does exactly that.
On Fri, Dec 06, 2013 at 09:23:22AM -0800, H. Peter Anvin wrote:
> On 12/06/2013 05:46 AM, Borislav Petkov wrote:
> > I'm guessing this and the struct lwp_struct above is being added so that
> > you can have the LWP XSAVE area size? If so, you don't need it: LWP
> > XSAVE area is 128 bytes at offset
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Reviewed-by: Peter Lieven
Signed-off-by: Stefan Hajnoczi
---
block/qcow2.c | 2 ++
block/qed.c | 2 ++
block/vdi.c | 1 +
block/vhdx.c | 3 +++
block/vpc.c | 1 +
5 files changed, 9 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2
SMTP does not preserve newlines. This is normally not a problem if the
email body uses DOS or UNIX newlines consistently. In 051.out we mix
UNIX newlines with DOS newlines (since QEMU monitor output uses \r\n).
This patch filters the QEMU monitor output so the golden master file
uses UNIX newlin
This patch changes bdrv_co_do_pwritev() to actually be what its name
promises. If requests aren't properly aligned, it performs a RMW.
Requests touching the same block are serialised against the RMW request.
Further optimisation of this is possible by differentiating types of
requests (concurrent
It will allow to reuse field in different BUSes, reducing code duplication.
Field is intended fot replacing 'hotplug_qdev' field in PCIBus and also
will allow not to add equivalent field to DimmBus with possiblitity
to refactor other BUSes to use it instead of custom field.
Signed-off-by: Igor Mam
06.12.2013 16:52, Alexander Graf wrote:
> When we're running in non-64bit mode with qemu-system-x86_64 we can
> still end up with virtual addresses that are above the 32bit boundary
> if a segment offset is set up.
>
> GNU Hurd does exactly that. It sets the segment offset to 0x8000 and
> puts
From: Fam Zheng
Format "raw" doesn't always work on certain file systems (e.g. tmpfs).
Use qcow2 to make the allocation status explicit and split into a new
case.
[Resolved merge conflict due to "qemu-io> " prompt filter, added 074 to
group file, and fixed up s/048/074/ copy-paste mistake.
--Ste
From: Wenchao Xia
This case can't run when IMGPROTO=nbd, since it needs to create some
internal snapshot which would fail for EOF write request, even when
TEST_IMG is exported with "-f raw" in common.rc, so set _supported_proto
to file.
_require_command() is changed to tip what util is missing,
The memory region can be included by value instead of by reference in the
device state (like it is done in other SoCs).
Signed-off-by: Stefan Weil
---
hw/arm/highbank.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
index fe98e
First waiting for all COR requests to complete and calling the
throttling function afterwards means that the request could be delayed
and we still need to wait for the COR request even if it was issued only
after the throttled write request.
Signed-off-by: Kevin Wolf
---
block.c | 8
1
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/058 | 19 ++-
tests/qemu-iotests/058.out | 12
2 files changed, 30 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/058 b/tests/qemu-iotests/058
inde
From: Peter Lieven
this patch shortens requests to end at an aligned sector so that
the next request starts aligned.
[Squashed Peter's fix for bdrv_get_info() failure discussed on the
mailing list.
--Stefan]
Reviewed-by: Paolo Bonzini
Signed-off-by: Peter Lieven
Signed-off-by: Stefan Hajnoczi
Split piix4_device_hotplug() into hotplug/unplug callbacks
and register them as "hotplug-device" interface implementation of
PIIX4_PM device.
Replace pci_bus_hotplug() wiring with setting link on
PCI BUS "hotplug-device" property to PIIX4_PM device.
Signed-off-by: Igor Mammedov
---
hw/acpi/piix
From: Max Reitz
Leaving the backing file open although it is not needed anymore can
cause problems if it is opened through a block driver which allows
exclusive access only and if the create function of the block driver
used for the top image (the one being created) tries to close and reopen
the
From: Peter Lieven
since the convert process is basically a sync operation it might
be benificial in some case to change the hardcoded I/O buffer
size to a greater value.
This patch increases the I/O buffer size if the output
driver advertises an optimal transfer length or discard alignment
that
On 6 December 2013 16:44, Richard Henderson wrote:
> On 12/07/2013 01:45 AM, Peter Maydell wrote:
>> On 5 December 2013 22:26, Richard Henderson wrote:
>>> On 12/06/2013 10:51 AM, Peter Maydell wrote:
+if (cond >= 0x0e) { /* condition "always" */
+tcg_src = read_cpu_reg(s, r
This separates the part of bdrv_co_do_readv() that needs to happen
before the request is modified to match the backend alignment, and a
part that needs to be executed afterwards and passes the request to the
BlockDriver.
Signed-off-by: Kevin Wolf
---
block.c | 61
Post-order is the only sensible direction for the reset signals.
For example, suppose pre-order is used and the parent has some data
structures that cache children state (for example a list of active
requests). When the reset method is invoked on the parent, these caches
could be in any state.
If
Il 06/12/2013 18:22, Kevin Wolf ha scritto:
> This patch series adds code to the block layer that allows performing
> I/O requests in smaller granularities than required by the host backend
> (most importantly, O_DIRECT restrictions). It achieves this for reads
> by rounding the request to host-sid
On 12/06/2013 09:35 AM, Paolo Bonzini wrote:
>
> Sorry for the back-and-forth, but I think this and the removal of
> XSTATE_FLEXIBLE (perhaps XSTATE_LAZY?) makes your v2 worse than v1.
>
> Since Peter already said the same, please undo these changes.
>
> Also, how is XSTATE_EAGER used? Should M
On 09/10/2013 05:27 AM, Aurelien Jarno wrote:
> The shl_i32 op might set some bits of the unused 32 high bits of the
> mask. Fix that by clearing the unused 32 high bits for all 32-bit ops
> except load/store which operate on tl values.
>
> Cc: Richard Henderson
> Cc: Paolo Bonzini
> Signed-off-
On 09/10/2013 05:27 AM, Aurelien Jarno wrote:
> Known-zero bits optimization is a great idea that helps to generate more
> optimized code. However the current implementation only works in very few
> cases as the computed mask is not saved.
>
> Fix this to make it really working.
>
> Cc: Richard H
On 09/10/2013 05:27 AM, Aurelien Jarno wrote:
> 32-bit versions of sar and shr ops should not propagate known-zero bits
> from the unused 32 high bits. For sar it could even lead to wrong code
> being generated.
>
> Cc: Richard Henderson
> Cc: Paolo Bonzini
> Cc: qemu-sta...@nongnu.org
> Signed-
On 09/10/2013 05:27 AM, Aurelien Jarno wrote:
> +CASE_OP_32_64(ld8u):
> +case INDEX_op_qemu_ld8u:
> +mask = 0xff;
> +break;
> +CASE_OP_32_64(ld16u):
> +case INDEX_op_qemu_ld16u:
> +mask = 0x;
> +break;
> +ca
Instead of implementing the alignment adjustment here, use the now
existing functionality of bdrv_co_do_preadv().
Signed-off-by: Kevin Wolf
---
block.c | 49 +
1 file changed, 13 insertions(+), 36 deletions(-)
diff --git a/block.c b/block.c
index
Il 06/12/2013 18:22, Kevin Wolf ha scritto:
> @@ -1227,6 +1288,7 @@ static BlockDriver bdrv_file = {
> .bdrv_aio_writev = raw_aio_writev,
> .bdrv_aio_flush = raw_aio_flush,
> .bdrv_aio_discard = raw_aio_discard,
> +.bdrv_opt_mem_align = raw_opt_mem_align,
>
> .bdrv_truncat
On 11/27/2013 08:50 PM, Sebastian Huber wrote:
> Synchronize the program counter before the power down helper call
> otherwise interrupts will return to the wrong context.
>
> Signed-off-by: Sebastian Huber
> ---
> target-sparc/translate.c |1 +
> 1 files changed, 1 insertions(+), 0 deletion
Am 06.12.2013 15:44, schrieb Vincenzo Maffione:
> This patch extends the frontend-backend interface so that it is possible
> to pass a new flag (QEMU_NET_PACKET_FLAG_MORE) when sending a packet to the
> other peer. The new flag acts as a hint for the receiving peer, which can
> accumulate a batch o
Ping.
r~
On 11/19/2013 07:57 PM, Richard Henderson wrote:
> Ping?
>
> r~
>
> On 09/20/2013 05:58 AM, Richard Henderson wrote:
>> We previously allocated 32-bits per temp for the next_free_temp entry.
>> We now allocate 4 bits per temp across the 4 bitmaps.
>>
>> Using a linked list meant that i
On 12/07/2013 01:52 AM, Alexander Graf wrote:
> When we're running in non-64bit mode with qemu-system-x86_64 we can
> still end up with virtual addresses that are above the 32bit boundary
> if a segment offset is set up.
>
> GNU Hurd does exactly that. It sets the segment offset to 0x8000 and
From: Paolo Bonzini
This is the same that is already done for WRITE SAME.
Signed-off-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
hw/scsi/scsi-disk.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 74e6a14..4138268 100644
--- a
From: Peter Lieven
Reviewed-by: Paolo Bonzini
Signed-off-by: Peter Lieven
Signed-off-by: Stefan Hajnoczi
---
include/block/block_int.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index ec0797e..8b132d7 100644
--- a/include/block
On 6 December 2013 16:59, Richard Henderson wrote:
> Sorry for missing this in the first round: For the silly corner case of Rd ==
> XZR, tcg_rd is dead after the branch.
>
> We could either move the tcg_rd assignment down into each basic block with the
> assignment to tcg_src, or simply add
>
>
Il 07/12/2013 01:20, Qiaowei Ren ha scritto:
> This patch defines xstate feature and extends struct xsave_hdr_struct
> to support Intel MPX.
>
> Signed-off-by: Qiaowei Ren
> Signed-off-by: Xudong Hao
> Signed-off-by: Liu Jinsong
> ---
> arch/x86/include/asm/processor.h | 12
> a
On 12/06/2013 05:46 AM, Borislav Petkov wrote:
>
> I'm guessing this and the struct lwp_struct above is being added so that
> you can have the LWP XSAVE area size? If so, you don't need it: LWP
> XSAVE area is 128 bytes at offset 832 according to my manuals so I'd
> guess having a u8 lwp_area[128]
Il 06/12/2013 18:03, Igor Mammedov ha scritto:
> +hotplug_dev = DEVICE(object_property_get_link(OBJECT(bus),
> "hotplug-device",
> + &local_err));
> +if (error_is_set(&local_err)) {
> +goto error_exit;
> +}
> +if (hotplug_dev
Signed-off-by: Kevin Wolf
---
block.c | 48 ++--
1 file changed, 26 insertions(+), 22 deletions(-)
diff --git a/block.c b/block.c
index 23ad09d..514a5c2 100644
--- a/block.c
+++ b/block.c
@@ -69,11 +69,11 @@ static int coroutine_fn bdrv_co_readv_em(Blo
Change the API so that specific requests can be marked serialising. Only
these requests are checked for overlaps then.
This means that during a Copy on Read operation, not all requests
overlapping other requests are serialised any more, but only those that
actually overlap with the specific COR re
Il 06/12/2013 18:03, Igor Mammedov ha scritto:
> Series is replacement for a more simple attempt to generalize hotplug API
> http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02529.html
> promted by Paolo in this patch review.
> --
>
> Refactor PCI specific hotplug API to a more generic/reus
1 - 100 of 269 matches
Mail list logo
