Re: [Qemu-devel] [PATCH 16/16] ipmi: Add SMBIOS table entry

BTW you included this: Cc: qemu-devel@nongnu.org, Andreas Färber , Bret Ketchum , Corey Minyard the last address: cminy...@mvista.com is bouncing. -- MST

Re: [Qemu-devel] [PATCH 2/2] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS

On Wed, Nov 13, 2013 at 01:04:10PM +0100, Igor Mammedov wrote: > On Wed, 13 Nov 2013 00:10:39 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Nov 12, 2013 at 07:26:02PM +0100, Paolo Bonzini wrote: > > > Il 12/11/2013 14:58, Igor Mammedov ha scritto: > > > > 'etc/reserved-memory-end' will allow

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

On Tue, Nov 12, 2013 at 11:08:07AM -0600, Corey Minyard wrote: > On 11/12/2013 10:43 AM, Eric Blake wrote: > > On 11/12/2013 09:33 AM, Corey Minyard wrote: > >> Allow a socket that connects to reconnect on a periodic basis if it > >> fails to connect at startup or if the connection drops while in u

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: > Postpone the addition of the ACPI and SMBIOS tables until after > device initialization. This allows devices to add entries to these > tables. > > Signed-off-by: Corey Minyard Why delay adding FW_CFG_ACPI_TABLES? These are normall

Re: [Qemu-devel] -vga std vs. -device VGA

On Thu, 2013-11-14 at 16:01 +1100, Alexey Kardashevskiy wrote: > So the question is - is there any proper (i. e. qemu-upstreamable) way to > detect a VGA device presence and create additional devices (OHCI, keyboard, > mouse) as "-vga" does it now? The machine reset callback is too late for that. >

Re: [Qemu-devel] [PATCH v3 5/6] bitops: add BITNR macro

On 11/13/2013 11:04 PM, Paolo Bonzini wrote: > Il 13/11/2013 03:40, Alexey Kardashevskiy ha scritto: >> I looked further and did not find any use of ffs/clz so I wonder what did >> you mean about bitops.h and what did I miss? I am confused. > > It's host-utils.h actually. The reason for the wrapp

Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Am 14.11.2013 00:09, schrieb Peter Maydell: > Fix build failures with clang when KVM is not enabled by > providing a stub version of kvm_arch_get_supported_cpuid(). > We retain the compile time check that this function isn't > called when CONFIG_KVM is not set by guarding the stub with > ifndef __O

Re: [Qemu-devel] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property

On 11/12/2013 12:31 AM, Andreas Färber wrote: > Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: >> This patch is to demonstrate a static property handling in PowerPC. >> Running QEMU with -cpu host,-vsx disables VSX bit in >> PowerPCCPU::env::flags. >> >> Signed-off-by: Alexey Kardashevskiy >>

[Qemu-devel] -vga std vs. -device VGA

Hi everyone. Here is a problem with the SPAPR machine and a libvirt's habit to use "-nodefaults". When we run QEMU with "-vga std", a VGA device is created from the machine_init callback and if VGA is added, then we automatically add a PCI USB OHCI adapter with a keyboard and everybody (SLOF, yab

Re: [Qemu-devel] [PATCH] qemu-iotests: Add "-c " to check

Tried on RH6.4 x86_64 on upstream, the value can be passed to the final vm boot command. Tested-by: Wenchao Xia

Re: [Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices

于 2013/11/14 3:37, Max Reitz 写道: > If a block device is unbacked, a streaming blockjob should immediately > finish instead of beginning to try to stream, then noticing the backing > file does not contain even the first sector (since it does not exist) > and then finishing normally. > > Signed-off-

Re: [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name

Just found timestamp of this series seems older than v1, so ping to correct it.

Re: [Qemu-devel] [PATCH V5 0/5] export internal snapshot by qemu-nbd

Hello, any more comments?

Re: [Qemu-devel] [PATCH V6 0/6] qcow2: rollback the modification on fail in snapshot creation

ping?

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

On 2013年11月14日 09:31, Wenchao Xia wrote: --- a/qapi-schema.json +++ b/qapi-schema.json @@ -948,8 +948,8 @@ # @tray_open: #optional True if the device has a tray and it is open # (only present if removable is true) # -# @dirty: #optional dirty bitmap information (only present i

[Qemu-devel] [PATCH] qapi: Add (Since 1.8) to BlockInfo.dirty-bitmaps

Signed-off-by: Fam Zheng --- qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 931d710..3f2b5ef 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -949,7 +949,7 @@ # (only present if removable is true)

[Qemu-devel] [PATCH] qemu-iotests: Add "-c " to check

The default cache mode for drive options is changed to writethrough, and overridable with "./check -c ". Signed-off-by: Fam Zheng --- tests/qemu-iotests/common | 13 - tests/qemu-iotests/iotests.py | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/tests/qe

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

On 2013年11月14日 10:13, Wenchao Xia wrote: 于 2013/11/13 22:40, Fam Zheng 写道: On Wed, Nov 13, 2013 at 10:19 PM, Kevin Wolf wrote: Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: We have multiple dirty bitmaps in BDS now, switch QAPI to allow query it (BlockInfo.dirty_bitmaps), and also drop

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

于 2013/11/13 22:40, Fam Zheng 写道: On Wed, Nov 13, 2013 at 10:19 PM, Kevin Wolf wrote: Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: We have multiple dirty bitmaps in BDS now, switch QAPI to allow query it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. Signed-off-by: Fam Zhe

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

On 11/13/2013 06:31 PM, Wenchao Xia wrote: > >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -948,8 +948,8 @@ >> # @tray_open: #optional True if the device has a tray and it is open >> # (only present if removable is true) >> # >> -# @dirty: #optional dirty bitmap infor

Re: [Qemu-devel] [PATCH 1/5] qemu-img: Convert by cluster size if target is compressed

On 2013年11月14日 09:34, Jeff Cody wrote: On Thu, Nov 14, 2013 at 09:18:35AM +0800, Fam Zheng wrote: On 2013年11月13日 23:23, Jeff Cody wrote: On Wed, Nov 13, 2013 at 08:53:10AM +0800, Fam Zheng wrote: If target block driver forces compression, qemu-img convert needs to write by cluster size as well

Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out qemu-io prompt in 035

On 2013年11月13日 22:02, Kevin Wolf wrote: Am 13.11.2013 um 13:40 hat Fam Zheng geschrieben: This change is manually copy&pasted into thunderbird. It has a super long line to kill `git send-email`, and is wrapped by email composer. So you need to pull to merge it. 'git send-email --no-validate' w

Re: [Qemu-devel] [PATCH 1/5] qemu-img: Convert by cluster size if target is compressed

On Thu, Nov 14, 2013 at 09:18:35AM +0800, Fam Zheng wrote: > On 2013年11月13日 23:23, Jeff Cody wrote: > >On Wed, Nov 13, 2013 at 08:53:10AM +0800, Fam Zheng wrote: > >>If target block driver forces compression, qemu-img convert needs to > >>write by cluster size as well as "-c" option. > >> > >>Parti

Re: [Qemu-devel] [PATCH v3] qemu-img: Fix overwriting 'ret' before using

On 2013年11月13日 20:43, Kevin Wolf wrote: From: Fam Zheng This patch moves ret assignment after reporting original error. We were lucky to pass qemu-iotests 048 (qemu-img compare case) but when I tried to run with TEST_DIR=/tmp (tmpfs), it fails with a "wrong" mismatch offset. This fixes two bug

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

--- a/qapi-schema.json +++ b/qapi-schema.json @@ -948,8 +948,8 @@ # @tray_open: #optional True if the device has a tray and it is open # (only present if removable is true) # -# @dirty: #optional dirty bitmap information (only present if the dirty -# bitmap is enabled)

Re: [Qemu-devel] [PATCH 5/5] mirror: Check for bdrv_get_info result

On 2013年11月13日 23:34, Jeff Cody wrote: On Wed, Nov 13, 2013 at 08:53:14AM +0800, Fam Zheng wrote: bdrv_get_info could fail. Add check before using the returned value. Signed-off-by: Fam Zheng --- block/mirror.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/mi

Re: [Qemu-devel] [PATCH 1/5] qemu-img: Convert by cluster size if target is compressed

On 2013年11月13日 23:23, Jeff Cody wrote: On Wed, Nov 13, 2013 at 08:53:10AM +0800, Fam Zheng wrote: If target block driver forces compression, qemu-img convert needs to write by cluster size as well as "-c" option. Particularly, this applies for converting to VMDK streamOptimized format. Signed-

Re: [Qemu-devel] [PATCH for-1.7] vfio-pci: Fix multifunction=on

Alex Williamson writes: > When an assigned device is initialized it copies the device config > space into the emulated config space. Unfortunately multifunction is > setup prior to the device initfn and gets clobbered. We need to > restore it just like pci-assign does. > > Signed-off-by: Alex W

Re: [Qemu-devel] [PATCH 12/14] VSX Stage 4: Add Scalar SP Fused Multiply-Adds

On 11/14/2013 06:49 AM, Tom Musta wrote: > I have reviewed the code and the spec and I cannot see a flaw. The sequence > is > effectively this: > > - float64_muladd - performs proper FMA for 64 bit numbers) > - float64_to_float32 - converts to single precision, including proper > rounding

[Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Fix build failures with clang when KVM is not enabled by providing a stub version of kvm_arch_get_supported_cpuid(). We retain the compile time check that this function isn't called when CONFIG_KVM is not set by guarding the stub with ifndef __OPTIMIZE__ (we assume that an optimizing build will do

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

On 13 November 2013 07:25, Paolo Bonzini wrote: > Il 13/11/2013 03:27, Richard Henderson ha scritto: >> I think it's also worthwhile to implement the kvm api in kvm-stub.c, >> unnecessary or not. If you really want compile-time feedback on those that >> ought to have been removed by optimization,

[Qemu-devel] [Bug 1246990] Re: [qemu-x86-64-linux-user 1.6.1] qemu: uncaught target signal 11 (Segmentation fault) - core dumped

** Changed in: qemu (Ubuntu) Importance: Undecided => Low ** Changed in: qemu (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1246990 Title: [qemu-x86-64-

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6)

> > > +if (guest_info->gb_align && above_4g_mem_size > holesize) { > > > +/* Round the allocation up to 2 MB to use more hugepages. > > To align to 2MB boundary, the number of hugepages is the same. Right. > > > + * Remove the slack from the [yyy] piece so that pieceonesize >

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On Wed, Nov 13, 2013 at 03:26:36PM -0500, Vlad Yasevich wrote: > On 11/13/2013 03:00 PM, Michael S. Tsirkin wrote: > >On Wed, Nov 13, 2013 at 11:21:18AM -0500, Vlad Yasevich wrote: > >>On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: > >>>On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wro

Re: [Qemu-devel] [PATCH 1.7] mips jazz: do not raise data bus exception when accessing invalid addresses

Ping for 1.7 Paolo Bonzini a écrit : Il 04/11/2013 23:26, Hervé Poussineau ha scritto: MIPS Jazz chipset doesn't seem to raise data bus exceptions on invalid accesses. However, there is no easy way to prevent them. Creating a big memory region for the whole address space doesn't prevent memory

Re: [Qemu-devel] [PATCH 15/16] smbios: Add a function to directly add an entry

On 11/13/2013 08:37 AM, Bret Ketchum wrote: > > Don't know if it matters much but this patch cannot be applied > without the prototype definition in 16/16. Thanks, I'll fix this. -corey > > > On Tue, Nov 12, 2013 at 10:33 AM, Corey Minyard > wrote: > > There was

Re: [Qemu-devel] [PATCH 11/16] ipmi: Add tests

On 11/13/2013 08:12 AM, Bret Ketchum wrote: > Having trouble with this patch (after the prior patches were > successfully applied): I was a couple of days behind and some other changes that came in conflicted with this. -corey > > git status > # On branch master > # Changes not staged for c

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

On 11/13/2013 02:55 AM, Gerd Hoffmann wrote: > Hi, > >> Allow a socket that connects to reconnect on a periodic basis if it >> fails to connect at startup or if the connection drops while in use. >> +chr->backend = i; >> +chr->recon_time = qemu_opt_get_number(opts, "reconnect", 0); >> +

Re: [Qemu-devel] [PATCH 12/14] VSX Stage 4: Add Scalar SP Fused Multiply-Adds

On 11/7/2013 6:13 PM, Richard Henderson wrote: > On 11/08/2013 09:30 AM, Richard Henderson wrote: >> On 11/08/2013 09:28 AM, Richard Henderson wrote: >>> On 11/07/2013 06:31 AM, Tom Musta wrote: } \ +

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

On 11/13/2013 03:29 AM, Fam Zheng wrote: > We have multiple dirty bitmaps in BDS now, switch QAPI to allow query > it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. > > Signed-off-by: Fam Zheng > --- > block.c | 20 > block/qapi.c | 5 +

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6)

On Wed, Nov 13, 2013 at 05:58:32PM -0200, Marcelo Tosatti wrote: > On Wed, Nov 13, 2013 at 06:13:15PM +0100, Paolo Bonzini wrote: > > > assert(piecetwosize <= holesize); > > > > > > piecetwosize = MIN(above_4g_mem_size, piecetwosize); > > > if ((above_4g_mem_siz

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

On 11/13/2013 07:19 AM, Kevin Wolf wrote: >> # >> -# @dirty: #optional dirty bitmap information (only present if the dirty >> -# bitmap is enabled) >> +# @dirty-bitmaps: #optional dirty bitmaps information (only present if the >> +# driver has one or more dirty bitmaps) >>

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/13/2013 03:00 PM, Michael S. Tsirkin wrote: On Wed, Nov 13, 2013 at 11:21:18AM -0500, Vlad Yasevich wrote: On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: What about this approach? This only updates the monitory when all t

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On Wed, Nov 13, 2013 at 11:21:18AM -0500, Vlad Yasevich wrote: > On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: > >On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: > >>What about this approach? This only updates the monitory when all the > >>bits have been written to. > >> > >>-vl

Re: [Qemu-devel] [PATCH for-1.7] acpi unit-test: ensure both 1.6 machine and default machine received the same acpi tables

On Wed, Nov 13, 2013 at 06:11:25PM +0200, Marcel Apfelbaum wrote: > Machines before 1.6 used ACPI supplied by SeaBios, > for 1.7+ machines the tables are build by qemu. > This patch checks that both machines have the same ACPI tables. > > Also checks the signature of FACS table. > > Signed-off-by

[Qemu-devel] [PATCH v2 1/7] split definitions for exec.c and translate-all.c radix trees

From: Paolo Bonzini The exec.c and translate-all.c radix trees are quite different, and the exec.c one in particular is not limited to the CPU---it can be used also by devices that do DMA, and in that case the address space is not limited to TARGET_PHYS_ADDR_SPACE_BITS bits. We want to make exec

[Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices

If a block device is unbacked, a streaming blockjob should immediately finish instead of beginning to try to stream, then noticing the backing file does not contain even the first sector (since it does not exist) and then finishing normally. Signed-off-by: Max Reitz --- block/stream.c | 5 +

[Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level compression

At the moment, memory radix tree is already variable width, but it can only skip the low bits of address. This is efficient if we have huge memory regions but inefficient if we are only using a tiny portion of the address space. After we have built up the map, detect configurations where a single

Re: [Qemu-devel] [PATCH for-1.7] acpi unit-test: add signatures and checksum verification

On Tue, Nov 12, 2013 at 06:32:24PM +0200, Marcel Apfelbaum wrote: > Loaded all ACPI tables from guest, making > a good environment for further unit tests. > > Checked that ACPI tables are corrected pointed > within the ACPI tree using their signatures. > Verified checksum for all the tables. > >

[Qemu-devel] [PATCH v2 6/7] exec: make address spaces 64-bit wide

From: Paolo Bonzini As an alternative to commit 818f86b (exec: limit system memory size, 2013-11-04) let's just make all address spaces 64-bit wide. This eliminates problems with phys_page_find ignoring bits above TARGET_PHYS_ADDR_SPACE_BITS and address_space_translate_internal consequently messi

[Qemu-devel] [PATCH v2 3/7] exec: extend skip field to 6 bit, page entry to 32 bit

Extend skip to 6 bit. As page entry doesn't fit in 16 bit any longer anyway, extend it to 32 bit. This doubles node map memory requirements, but follow-up patches will save this memory. Signed-off-by: Michael S. Tsirkin --- exec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-

[Qemu-devel] [PATCH] pc: add 1.8 machine type

I already have several patches that affect compatibility between 1.8 and 1.7 queued, so we need pc compat structures in place. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 27 +++ hw/i386/pc_q35.c | 24 ++-- 2 files changed, 45 insertions

[Qemu-devel] [PATCH v2 0/7] making address spaces 64 bit wide

At the moment, exec ignores high bits in each address, for efficiency. This is incorrect: devices can do full 64 bit DMA, it's only the CPU that is limited by target address space. Resolving such addresses can actually corrupt the pagetables, so using full 64 bit addresses is called for. However,

[Qemu-devel] [PATCH v2 7/7] exec: reduce L2_PAGE_SIZE

With the single exception of ppc with 16M pages, we get the same number of levels with L2_PAGE_SIZE = 10 as with L2_PAGE_SIZE = 9. by doing this we reduce memory footprint of a single level in the node memory map by 2x without runtime overhead. Signed-off-by: Michael S. Tsirkin --- exec.c | 2 +

[Qemu-devel] [PATCH v2 2/7] exec: replace leaf with skip

In preparation for dynamic radix tree depth support, rename is_leaf field to skip, telling us how many bits to skip to next level. Set to 0 for leaf. Signed-off-by: Michael S. Tsirkin --- exec.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c

[Qemu-devel] [PATCH v2 4/7] exec: pass hw address to phys_page_find

callers always shift by target page bits so let's just do this internally. Signed-off-by: Michael S. Tsirkin --- exec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index ec46aea..edb577f 100644 --- a/exec.c +++ b/exec.c @@ -216,10 +216,11 @@ static

Re: [Qemu-devel] [PULL 00/16] [for-1.7] Trivial patches for 2013-11-13

Am 13.11.2013 19:24, schrieb Michael Tokarev: > 13.11.2013 22:05, Stefan Weil wrote: [] >> The two trace.h related patches moved include statements from .h >> files to .c files. I compiled the resulting code on 64 bit Linux, >> also with cross compilation for MinGW, so win* won't be a problem. >> N

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6)

On Tue, Nov 12, 2013 at 07:16:37PM -0200, Marcelo Tosatti wrote: > > v2: condition enablement of new mapping to new machine types (Paolo) > v3: fix changelog > v4: rebase > v5: ensure alignment of piecetwo on 2MB GPA (Igor) > do not register zero-sized piece-one(Igor) > v6: fix memory leak

Re: [Qemu-devel] [PATCH 05/11] scsi-disk: reject ANCHOR=1 for UNMAP and WRITE SAME commands

On 11/12/2013 08:49 AM, Paolo Bonzini wrote: > Since we report ANC_SUP==0 in VPD page B2h, we need to return > an error (ILLEGAL REQUEST/INVALID FIELD IN CDB) for all WRITE SAME > requests with ANCHOR==1. > > Inspired by a similar patch to the LIO in-kernel target. > > Signed-off-by: Paolo Bonzin

Re: [Qemu-devel] [PULL 00/16] [for-1.7] Trivial patches for 2013-11-13

13.11.2013 22:05, Stefan Weil wrote: [] > The two trace.h related patches moved include statements from .h files > to .c files. > I compiled the resulting code on 64 bit Linux, also with cross > compilation for > MinGW, so win* won't be a problem. > > Nevertheless there remains a risk because my b

Re: [Qemu-devel] [PATCH] xen-pvdevice: make device-id property compulsory

On Wed, 13 Nov 2013, Paul Durrant wrote: > The intention of the Xen PV device is that it is used as a parent > device for PV drivers in Xen HVM guests and the set of PV drivers that > bind to the device is determined by its device ID (and possibly > vendor ID and revision). As such, the device shou

Re: [Qemu-devel] [PULL 00/16] [for-1.7] Trivial patches for 2013-11-13

Am 13.11.2013 14:01, schrieb Michael Tokarev: > Here's a next trivial-patches pull request, for patches collected > in almost 3 weeks. > > There's nothing extra-ordinary here, except of one thing: this is > keyboard maps handling series by Jan Krupa. While I don't expect > any breakage in this are

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW

Am 13.11.2013 12:53, schrieb Michael Tokarev: > 10.11.2013 21:49, Stefan Weil wrote: >> While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny >> (gcc-mingw32 4.4.2-3) shows these errors: > I guess you mean Debian lenny, not Ubuntu lenny here ;) And lenny > is an "old-old-stable" Debian

Re: [Qemu-devel] [PATCH 0/8 v4] s390-qemu: cpu hotplug

On 10/31/2013 01:21 PM, Jason J. Herne wrote: Pinging this for review. -- -- Jason J. Herne (jjhe...@linux.vnet.ibm.com)

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6)

> assert(piecetwosize <= holesize); > > piecetwosize = MIN(above_4g_mem_size, piecetwosize); > if ((above_4g_mem_size - piecetwosize) > 0) { > memory_region_init_alias(ram_above_4g, NULL, "ram-above-4g", >

[Qemu-devel] [Bug 1250360] Re: qcow2 image logical corruption after host crash

See also https://bugzilla.redhat.com/show_bug.cgi?id=1029344 for some more information ** Bug watch added: Red Hat Bugzilla #1029344 https://bugzilla.redhat.com/show_bug.cgi?id=1029344 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: add block driver sub-maintainers

Am 13.11.2013 um 17:17 hat Jeff Cody geschrieben: > On Wed, Nov 13, 2013 at 10:33:10AM +0100, Stefan Hajnoczi wrote: > > There are a number of contributors who maintain block drivers (image > > formats and protocols). They should be listed in the MAINTAINERS file > > so that get_maintainer.pl list

Re: [Qemu-devel] [PATCH 15/16] smbios: Add a function to directly add an entry

Am 13.11.2013 15:37, schrieb Bret Ketchum: > > Don't know if it matters much but this patch cannot be applied > without the prototype definition in 16/16. It does matter for bisecting, thanks for pointing it out! Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, G

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: What about this approach? This only updates the monitory when all the bits have been written to. -vlad Thanks! Some comments below. -- >8 -- Subject: [PATCH] e1000/rtl8139: upd

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: add block driver sub-maintainers

On Wed, Nov 13, 2013 at 10:33:10AM +0100, Stefan Hajnoczi wrote: > There are a number of contributors who maintain block drivers (image > formats and protocols). They should be listed in the MAINTAINERS file > so that get_maintainer.pl lists them. > > Note that commits are still merged through Ke

[Qemu-devel] [PATCH for-1.7] acpi unit-test: ensure both 1.6 machine and default machine received the same acpi tables

Machines before 1.6 used ACPI supplied by SeaBios, for 1.7+ machines the tables are build by qemu. This patch checks that both machines have the same ACPI tables. Also checks the signature of FACS table. Signed-off-by: Marcel Apfelbaum --- Note that for the moment we check only that the machines

Re: [Qemu-devel] [PATCH 12/16] ipmi: Add documentation

The actual default I/O address for KCS is 0xca2. On Tue, Nov 12, 2013 at 10:33 AM, Corey Minyard wrote: > Add some basic documentation for the IPMI device. > > Signed-off-by: Corey Minyard > --- > qemu-options.hx | 35 +++ > 1 file changed, 35 insertions(+

Re: [Qemu-devel] [PATCH 5/5] mirror: Check for bdrv_get_info result

On Wed, Nov 13, 2013 at 08:53:14AM +0800, Fam Zheng wrote: > bdrv_get_info could fail. Add check before using the returned value. > > Signed-off-by: Fam Zheng > --- > block/mirror.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/mirror.c b/block/mirror.c > in

[Qemu-devel] [PATCH] xen-pvdevice: make device-id property compulsory

The intention of the Xen PV device is that it is used as a parent device for PV drivers in Xen HVM guests and the set of PV drivers that bind to the device is determined by its device ID (and possibly vendor ID and revision). As such, the device should not have a default device ID, it should always

Re: [Qemu-devel] [PATCH 1/5] qemu-img: Convert by cluster size if target is compressed

On Wed, Nov 13, 2013 at 08:53:10AM +0800, Fam Zheng wrote: > If target block driver forces compression, qemu-img convert needs to > write by cluster size as well as "-c" option. > > Particularly, this applies for converting to VMDK streamOptimized > format. > > Signed-off-by: Fam Zheng > --- >

Re: [Qemu-devel] [PATCH 09/11] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

> Am 13.11.2013 um 15:39 schrieb Paolo Bonzini : > > Il 13/11/2013 15:14, Peter Lieven ha scritto: >> does BLKDISCARDZEROES ioctl guarantee that a device is >> zero initialized or does it just guarantee that a discard may not >> fail and that it reads as zeroes afterwards?

Re: [Qemu-devel] [PATCH v3] qemu-img: Fix overwriting 'ret' before using

On 11/13/2013 05:43 AM, Kevin Wolf wrote: > From: Fam Zheng > > This patch moves ret assignment after reporting original error. > > We were lucky to pass qemu-iotests 048 (qemu-img compare case) but when > I tried to run with TEST_DIR=/tmp (tmpfs), it fails with a "wrong" > mismatch offset. This

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

Il 13/11/2013 15:19, Kevin Wolf ha scritto: > I believe this is of limited use; if you ever have more than one dirty > bitmap, we're lacking information to associate it with the job it > belongs to. One option would be to extend BlockDirtyInfo to indicate > this, but another might be to actually ex

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

On Wed, Nov 13, 2013 at 10:19 PM, Kevin Wolf wrote: > Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: >> We have multiple dirty bitmaps in BDS now, switch QAPI to allow query >> it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. >> >> Signed-off-by: Fam Zheng > >> diff --git a/qap

Re: [Qemu-devel] [PATCH 09/11] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

Il 13/11/2013 15:14, Peter Lieven ha scritto: >>> >> does BLKDISCARDZEROES ioctl guarantee that a device is >>> >> zero initialized or does it just guarantee that a discard may not >>> >> fail and that it reads as zeroes afterwards? >> > >> > Only the latter. ".bdrv_has_zero_init" is only present

Re: [Qemu-devel] [PATCH 15/16] smbios: Add a function to directly add an entry

Don't know if it matters much but this patch cannot be applied without the prototype definition in 16/16. On Tue, Nov 12, 2013 at 10:33 AM, Corey Minyard wrote: > There was no way to directly add a table entry to the SMBIOS table, > even though the BIOS supports this. So add a function to

Re: [Qemu-devel] [PATCH v3 1/2] block: per caller dirty bitmap

Am 13.11.2013 um 15:33 hat Fam Zheng geschrieben: > On Wed, Nov 13, 2013 at 6:29 PM, Fam Zheng wrote: > > Previously a BlockDriverState has only one dirty bitmap, so only one > > caller (e.g. a block job) can keep track of writing. This changes the > > dirty bitmap to a list and creates a BdrvDirt

Re: [Qemu-devel] [PATCH 00/14] VSX Stage 4

On 11/7/2013 6:23 PM, Richard Henderson wrote: > Modulo my comments wrt the actual computation of fma, the patches all look > fine. > > But I'd like to also mention a pre-existing flaw/niggle in the ppc port. > > The conversions to/from in-register representation for the single-precision > value

Re: [Qemu-devel] [PATCH v3 1/2] block: per caller dirty bitmap

On Wed, Nov 13, 2013 at 6:29 PM, Fam Zheng wrote: > Previously a BlockDriverState has only one dirty bitmap, so only one > caller (e.g. a block job) can keep track of writing. This changes the > dirty bitmap to a list and creates a BdrvDirtyBitmap for each caller, the > lifecycle is managed with t

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

Had trouble with this one: git apply --verbos --check ../ipmi-patches/290708.mbox Checking patch hw/i386/pc.c... Hunk #1 succeeded at 622 (offset 15 lines). error: while searching for: fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)apic_id_limit); fw_cfg_add_i32(fw_cfg, FW_CFG_ID,

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: > We have multiple dirty bitmaps in BDS now, switch QAPI to allow query > it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. > > Signed-off-by: Fam Zheng > diff --git a/qapi-schema.json b/qapi-schema.json > index 81a375b..931d710 10

Re: [Qemu-devel] [PATCH 09/11] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

Am 13.11.2013 um 10:44 schrieb Paolo Bonzini : > Il 13/11/2013 07:29, Peter Lieven ha scritto: >> Wouldn't it be good to add bdi->can_write_zeroes_with_unmap here as well? > > We do: > >> +bdi->unallocated_blocks_are_zero = s->discard_zeroes; >> +bdi->can_write_zeroes_with_unmap = s->di

Re: [Qemu-devel] [PATCH v2] curses: fixup SIGWINCH handler mess

On 11/13/13 10:23, Gerd Hoffmann wrote: > Don't run code in the signal handler, only set a flag. > Use sigaction(2) to avoid non-portable signal(2) semantics. > Make #ifdefs less messy. > > Signed-off-by: Gerd Hoffmann > --- > ui/curses.c | 44 > 1 fi

Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out qemu-io prompt in 035

Am 13.11.2013 um 13:40 hat Fam Zheng geschrieben: > This change is manually copy&pasted into thunderbird. It has a super > long line to kill `git send-email`, and is wrapped by email > composer. So you need to pull to merge it. 'git send-email --no-validate' worked the last time I has something li

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6)

On Tue, 12 Nov 2013 19:16:37 -0200 Marcelo Tosatti wrote: > > v2: condition enablement of new mapping to new machine types (Paolo) > v3: fix changelog > v4: rebase > v5: ensure alignment of piecetwo on 2MB GPA (Igor) > do not register zero-sized piece-one(Igor) > v6: fix memory leak

Re: [Qemu-devel] [PATCH] qemu-iotests: Use cache=writeback in drive_add

Am 13.11.2013 um 13:27 hat Fam Zheng geschrieben: > This will allow running iotests on tmpfs, which is much faster, so we > can run more tests. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/iotests.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-

Re: [Qemu-devel] [RFC v2] target-arm: provide skeleton for a64 insn decoding

On Tue, Nov 12, 2013 at 2:29 PM, Claudio Fontana wrote: > provide a skeleton for a64 instruction decoding in translate-a64.c, > by dividing instructions into the classes defined by the > ARM Architecture Reference Manual(DDI0487A_a) C3 > > Signed-off-by: Claudio Fontana > Signed-off-by: Alex Benn

[Qemu-devel] [PULL 08/16] pci-assign: Fix error_report of pci-stub message

From: Cole Robinson Using multiple calls to error_report here means every line is prefaced with the (potentially long) pci-assign command line arguments. Use a single error_printf to preserve the intended formatting. Since this code path is always preceded by an error_report call, we don't lose

[Qemu-devel] [PULL 16/16] qga: Fix shutdown command of guest agent to work with SysV

From: whitearchey For now guest agent uses following command to shutdown system: shutdown -P +0 "blabla" but this syntax works only with shutdown command from systemd or upstart, because SysV shutdown requires -h switch. Following patch changes the command so it works with systemd, upstart and S

[Qemu-devel] [PULL 14/16] console: Replace conditional debug messages by trace methods

From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- trace-events |2 ++ ui/console.c | 11 +++ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/trace-events b/trace-events index 8695e9e..d196234 100644 --- a/tr

[Qemu-devel] [PULL 12/16] trace: Remove trace.h from console.h (less dependencies)

From: Stefan Weil This reduces the dependencies on trace.h. Only two source files which need console.h also need trace.h. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/display/vmware_vga.c |1 + include/ui/console.h|1 - ui/console.c|1 + 3 files

[Qemu-devel] [PULL 05/16] usb: drop unused USBNetState.inpkt field

From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Reviewed-by: Benoit Canet Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- hw/usb/dev-network.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c index 660d774..4c532b7 100644 --

[Qemu-devel] [PULL 06/16] vl: fix build when configured with no graphic support

From: Antony Pavlov The following error occurs when building with no graphic output support: vl.c: In function ‘main’: vl.c:2829:19: error: variable ‘ds’ set but not used [-Werror=unused-but-set-variable] DisplayState *ds; ^ cc1: all warnings being treated as e

[Qemu-devel] [PULL 11/16] console: Remove unused debug code

From: Stefan Weil The local function console_print_text_attributes is no longer used since commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f. Signed-off-by: Stefan Weil Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- ui/console.c | 33 - 1 file c

[Qemu-devel] [PULL 09/16] .travis.yml: basic compile and check recipes

From: Alex Bennée This adds a build matrix definition for travis-ci.org continuous integration service. It is usable on any public repository hosted on GitHub. Once you have created an account signed into Travis you can enable it on selected projects via travis-ci.org/profile. Alternatively you c

  1   2   >