[Qemu-devel] [PATCH v2] spapr: make sure RMA is in first mode of first memory node

2013-11-05 Thread Alexey Kardashevskiy
The SPAPR specification says that the RMA starts at the LPAR's logical address 0 and is the first logical memory block reported in the LPAR’s device tree. So SLOF only maps the first block and that block needs to span the full RMA. This makes sure that the RMA area is where SLOF expects it. Cc:

Re: [Qemu-devel] [PATCH 1/2] pc: add etc/e820 fw_cfg file

2013-11-05 Thread Gerd Hoffmann
On Di, 2013-11-05 at 18:48 +0100, Andrea Arcangeli wrote: > Hi, > > On Mon, Nov 04, 2013 at 01:17:10PM +0100, Gerd Hoffmann wrote: > > Unlike the existing FW_CFG_E820_TABLE entry which carries reservations > > only the new etc/e820 file also has entries for RAM. > > Acked, it looks the best the w

Re: [Qemu-devel] [PATCH uq/master] pci-assign: Remove dead code for direct I/O region access from userspace

2013-11-05 Thread Gleb Natapov
Alex can you review please? On Mon, Nov 04, 2013 at 02:42:55PM +0100, Jan Kiszka wrote: > This feature was already deprecated back then in qemu-kvm, ie. before > pci-assign went upstream. assigned_dev_ioport_rw will never be invoked > with resource_fd < 0. > > Signed-off-by: Jan Kiszka > --- >

Re: [Qemu-devel] USB Passthrough not working for Windows 7 guest

2013-11-05 Thread Jan Kiszka
On 2013-11-05 21:20, Jens Frederich wrote: >> On 2013-11-05 17:01, Frederich, Jens wrote: >>> Hi all, >>> >>> we're currently evaluating different RTOS systems (Windows CE, Intime, RTX, >>> etc.). >>> One system is Linux RT + KVM/QEMU with a Windows 7 guest. Up to now all >>> works fine, Linux RT h

Re: [Qemu-devel] [PATCH] spapr: add "compat" machine option

2013-11-05 Thread Paul Mackerras
On Mon, Sep 30, 2013 at 01:25:32PM +0200, Alexander Graf wrote: > > On 27.09.2013, at 10:06, Alexey Kardashevskiy wrote: > > > To be able to boot on newer hardware that the software support, > > PowerISA defines a logical PVR, one per every PowerISA specification > > version from 2.04. [snip] > >

Re: [Qemu-devel] [PATCH v2] cpu-exec: Fix compiler warning (-Werror=clobbered)

2013-11-05 Thread Stefan Weil
Am 05.11.2013 19:03, schrieb Andreas Färber: > Am 05.11.2013 18:52, schrieb Stefan Weil: >> Am 31.10.2013 20:41, schrieb Jan Kiszka: >>> On 2013-10-31 20:31, Stefan Weil wrote: Reloading of local variables after sigsetjmp is only needed for some buggy compilers. The code which s

Re: [Qemu-devel] [PATCH v2] linux-user: Fix stat64 syscall for SPARC64

2013-11-05 Thread Stefan Weil
Am 31.10.2013 05:33, schrieb Erik de Castro Lopo: > Stefan Weil wrote: > >> Some targets use a stat64 structure for the stat64 syscall while others >> use a stat structure. SPARC64 used the wrong kind. >> >> Instead of extending the conditional compilation in syscall.c, now a >> macro TARGET_HAS_ST

[Qemu-devel] [PATCH v2] qmp: access the local QemuOptsLists for drive option

2013-11-05 Thread Amos Kong
Currently we have three QemuOptsList (qemu_common_drive_opts, qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts is added to vm_config_groups[]. This patch changes query-command-line-options to access three local QemuOptsLists for drive option, and merge the description items toget

[Qemu-devel] [Bug 1248376] [NEW] "fstenv" gets the wrong result in qemu 1.6.1

2013-11-05 Thread Minghua Wang
Public bug reported: The float instruction "fstenv" gets the wrong result, when I tested it in QEMU 1.6.1. The detailed testing environments are: 1)the QEMU's guest OS is 32-bit windows 7 professional.(version: 6.1.7600). 2)the QEMU's host machine I used is 64-bit Fedora Core 13. I used the f

Re: [Qemu-devel] [PATCH 1.7] pc: get rid of builtin pvpanic for "-M pc-1.5"

2013-11-05 Thread Anthony Liguori
Paolo Bonzini writes: > This causes two slight backwards-incompatibilities between "-M pc-1.5" > and 1.5's "-M pc": Can you rebase this? It no longer applies because of the acpi building changes. Regards, Anthony Liguori > > (1) a fw_cfg file is removed with this patch. This is only a probl

Re: [Qemu-devel] [PATCH] spapr: add "compat" machine option

2013-11-05 Thread Paul Mackerras
On Tue, Nov 05, 2013 at 10:06:04AM +0100, Paolo Bonzini wrote: > Il 30/09/2013 14:57, Alexey Kardashevskiy ha scritto: > >> > Why is the option under -machine instead of -cpu? > > Because it is still the same CPU and the guest will still read the real > > PVR from the hardware (which it may not sup

Re: [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent

2013-11-05 Thread Wenchao Xia
于 2013/11/5 22:06, Luiz Capitulino 写道: On Tue, 05 Nov 2013 13:31:09 +0800 Wenchao Xia wrote: 于 2013/11/5 10:51, Luiz Capitulino 写道: On Tue, 05 Nov 2013 10:17:28 +0800 Wenchao Xia wrote: 于 2013/11/4 21:33, Luiz Capitulino 写道: On Mon, 04 Nov 2013 09:59:50 +0800 Wenchao Xia wrote: 于 2013/

Re: [Qemu-devel] [PATCH RFC 07/10] qapi script: support direct inheritance for struct

2013-11-05 Thread Wenchao Xia
于 2013/11/5 21:41, Eric Blake 写道: On 11/04/2013 05:37 PM, Wenchao Xia wrote: Now it is possible to inherit another struct inside data directly, which saves trouble to define trivial structure. Signed-off-by: Wenchao Xia --- docs/qapi-code-gen.txt | 21 + scripts/qapi-v

[Qemu-devel] [PATCH V6 5/5] blockdev: Add infinite loop check in drive_init()

2013-11-05 Thread Xu Wang
Check the backing file for a loop during image boot, to avoid a lack or response or segfault. Signed-off-by: Xu Wang --- blockdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/blockdev.c b/blockdev.c index b260477..7c0927f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -510,6 +510,12

[Qemu-devel] [PATCH V6 3/5] block: Add check infinite loop in bdrv_img_create()

2013-11-05 Thread Xu Wang
Backing file loop should be checked before qemu-img create command execution. If loop is found, qemu-img create should be stopped and an error printed. Signed-off-by: Xu Wang --- block.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 3443117..

[Qemu-devel] [PATCH V6 0/5] Refine and export backing file loop check

2013-11-05 Thread Xu Wang
If there is loop exists in the backing file chain, many problems could be caused by it, such as no response and segment fault during system boot. Hence stopping backing file loop appear is very necessary. These patches refine and export loop checking function from collect_image_ info_list() to bloc

[Qemu-devel] [PATCH V6 4/5] block: Add backing file loop check in change_backing_file()

2013-11-05 Thread Xu Wang
Backing file loop should be checked before calling change_backing_ file(). If loop appeared, this calling should be stopped and an error printed. Signed-off-by: Xu Wang --- block.c | 5 + 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index 8423e80..cb50bfd 100644 --- a/bloc

[Qemu-devel] [PATCH V6 2/5] qemu-img: Add infinite loop checking in bdrv_new_open()

2013-11-05 Thread Xu Wang
Every image should be checked if there is infinite loop in backing file chain before open it. So infinite loop check was added into bdrv_new_open(). If @filename is opened without the flag BDRV_O_NO_BACKING, the infinite loop check should be called. Signed-off-by: Xu Wang --- qemu-img.c | 8

[Qemu-devel] [PATCH V6 1/5] block/qemu-img: Refine and export infinite loop checking in collect_image_info_list()

2013-11-05 Thread Xu Wang
If there is a loop in the backing file chain, it could cause problems such as no response or a segfault during system boot. Hence detecting a backing file loop is necessary. This patch extracts the loop check from collect_image_info_list() in block.c into independent functions bdrv_backing_chain_ok

Re: [Qemu-devel] [PATCH] RFC: powerpc: add PVR compatibility check

2013-11-05 Thread Paul Mackerras
On Tue, Nov 05, 2013 at 05:16:33PM +0100, Andreas Färber wrote: > Am 05.11.2013 07:05, schrieb Alexander Graf: > > > > > > Am 05.11.2013 um 05:00 schrieb Paul Mackerras : > > > >> On Mon, Nov 04, 2013 at 10:05:58AM +0100, Alexander Graf wrote: > >>> > >>> Yeah, we really need to check that guest

Re: [Qemu-devel] [PATCH RFC 03/10] qapi script: check correctness of discriminator values in union

2013-11-05 Thread Wenchao Xia
于 2013/11/5 21:25, Eric Blake 写道: On 11/04/2013 05:37 PM, Wenchao Xia wrote: It will check whether the values specfied are wrotten correctly when s/specfied/specified/ s/wrotten/written/ discriminator is a pre-defined enum type, which help check whether the schema is in good form. It is all

[Qemu-devel] [PATCH for-1.7 2/2] tests: fix memleak in error path test for input visitor

2013-11-05 Thread Wenchao Xia
Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Cc: qemu-sta...@nongnu.org --- tests/test-qmp-input-visitor.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/test-qmp-input-visitor.c b/tests/test-qmp-input-visitor.c index 0beb8fb..1e1c6fa 100644 --- a/tests/test

[Qemu-devel] [PATCH for-1.7 1/2] qapi: fix memleak by adding implict struct functions in dealloc visitor

2013-11-05 Thread Wenchao Xia
Otherwise member "base" is leaked in a qapi_free_STRUCTURE() call. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Cc: qemu-sta...@nongnu.org --- qapi/qapi-dealloc-visitor.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/qapi/qapi-dealloc-visitor

[Qemu-devel] [PATCH for-1.7 0/2] fix qapi mem leaks

2013-11-05 Thread Wenchao Xia
The bugfix patches are picked up from RFC series: http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg00363.html Wenchao Xia (2): qapi: fix memleak by adding implict struct functions in dealloc visitor tests: fix memleak in error path test for input visitor qapi/qapi-dealloc-visitor.c

Re: [Qemu-devel] [PATCH RFC 09/10] tests: fix memleak in error path test for input visitor

2013-11-05 Thread Wenchao Xia
于 2013/11/5 21:20, Eric Blake 写道: On 11/04/2013 05:37 PM, Wenchao Xia wrote: Signed-off-by: Wenchao Xia Cc: qemu-sta...@nongnu.org --- tests/test-qmp-input-visitor.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Reviewed-by: Eric Blake You should repost your mem-leak patches

Re: [Qemu-devel] About the IO-mirroring functionality inside the qemu

2013-11-05 Thread Andrew Cathrow
http://wiki.qemu.org/Features/BlockJob - Original Message - > From: "Yaodong Yang" > To: qemu-devel@nongnu.org, qemu-disc...@nongnu.org > Cc: "Yaodong Yang" > Sent: Tuesday, November 5, 2013 9:07:27 PM > Subject: [Qemu-devel] About the IO-mirroring functionality inside the qemu > > Hi a

Re: [Qemu-devel] About the IO-mirroring functionality inside the qemu

2013-11-05 Thread Zhanghaoyu (A)
>Hi all, > >Does the Qemu have the storage migration tool, like the io-mirroring inside >the vmware? io-mirroring means for all the ioes, they are send to both source >and destination at the same time. drive_mirror maybe your choice. Thanks, Zhang Haoyu > >Thanks!

[Qemu-devel] About the IO-mirroring functionality inside the qemu

2013-11-05 Thread Yaodong Yang
Hi all, Does the Qemu have the storage migration tool, like the io-mirroring inside the vmware? io-mirroring means for all the ioes, they are send to both source and destination at the same time. Thanks!

[Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v3)

2013-11-05 Thread Marcelo Tosatti
v2: condition enablement of new mapping to new machine types (Paolo) v3: fix changelog - Align guest physical address and host physical address beyond guest 4GB on a 1GB boundary. Otherwise 1GB TLBs cannot be cached for the range. Signed-off-by: Marcelo Tosatti diff --git a/hw/i386/pc.

Re: [Qemu-devel] [PATCH] migration: avoid starting a new migration task while the previous one still exist

2013-11-05 Thread Zhanghaoyu (A)
Avoid starting a new migration task while the previous one still >>> exist. >>> >>> Can you explain how to reproduce the problem? >>> >> When network disconnection between source and destination happened, >> the migration thread stuck at below stack, >> Then I cancel the migration task, the m

[Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v2)

2013-11-05 Thread Marcelo Tosatti
Align guest physical address and host physical address beyond guest 4GB on a 1GB boundary, in case hugetlbfs is used. Otherwise 1GB TLBs cannot be cached for the range. Signed-off-by: Marcelo Tosatti diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 0c313fe..534e067 100644 --- a/hw/i386/pc.c +++

Re: [Qemu-devel] Multi-head support RFC

2013-11-05 Thread Dave Airlie
On Wed, Nov 6, 2013 at 6:42 AM, John Baboval wrote: > Hello, > > I am currently the device model maintainer for XenClient Enterprise. As you > may or may not know, we maintain a patch queue on top of QEMU (currently > 1.3) that adds functionality needed to support XCE features. > > One of the majo

Re: [Qemu-devel] [PATCH v3] ppc: introduce CPUPPCState::cpu_dt_id

2013-11-05 Thread Scott Wood
On Tue, 2013-11-05 at 07:00 +0100, Alexander Graf wrote: > > Am 05.11.2013 um 02:48 schrieb Scott Wood : > > > On Tue, 2013-11-05 at 12:26 +1100, Alexey Kardashevskiy wrote: > >> On 11/05/2013 06:42 AM, Scott Wood wrote: > >>> On Mon, 2013-11-04 at 10:41 +0100, Alexander Graf wrote: > What w

[Qemu-devel] [PATCH v3] Fix pc migration from qemu <= 1.5

2013-11-05 Thread Cole Robinson
The following commit introduced a migration incompatibility: commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe Author: David Gibson Date: Thu Jun 6 18:48:49 2013 +1000 pci: Replace pci_find_domain() with more general pci_root_bus_path() The issue is that i440fx savevm idstr went from :0

Re: [Qemu-devel] [PATCH v2] pci-assign: Fix error_report of pci-stub message

2013-11-05 Thread Cole Robinson
cc-ing qemu-trivial since this hasn't been picked up yet AFAICT. - Cole On 10/11/2013 11:52 AM, Cole Robinson wrote: > Using multiple calls to error_report here means every line is > prefaced with the (potentially long) pci-assign command line > arguments. > > Use a single error_printf to preser

Re: [Qemu-devel] [PATCH v2] Fix pc migration from qemu <= 1.5

2013-11-05 Thread Cole Robinson
On 11/04/2013 11:19 PM, Alex Williamson wrote: > On Tue, 2013-10-08 at 15:35 -0400, Cole Robinson wrote: >> The following commit introduced a migration incompatibility: >> >> commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe >> Author: David Gibson >> Date: Thu Jun 6 18:48:49 2013 +1000 >> >>

Re: [Qemu-devel] [PATCH v2] rdma: rename 'x-rdma' => 'rdma'

2013-11-05 Thread Eric Blake
On 10/26/2013 02:03 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > As far as we can tell, all known bugs have been fixed: > > 1. Parallel RDMA migrations are working > 2. IPv6 migration is working > 3. Libvirt patches are ready > 4. virt-test is working > > Signed-off-by:

Re: [Qemu-devel] [PATCH 00/20] Add an IPMI device to QEMU

2013-11-05 Thread Bret Ketchum
>> I was pointed at these patches as an example of useful >> functionality that's out of qemu merely for lack of review >> resources. I'd like to help. >> >> Now that we have code to generate ACPI tables >> directly in qemu, this series can be rebased on top of >> that, with no need for new FW CFG

Re: [Qemu-devel] Qemu IPMI support

2013-11-05 Thread Bret Ketchum
Will do, thanks. On Tue, Nov 5, 2013 at 7:53 AM, Michael S. Tsirkin wrote: > On Tue, Nov 05, 2013 at 07:27:42AM -0600, Bret Ketchum wrote: > > Gentlemen, > > > > Hope this email finds you well and hope you can point me in the right > > direction. I've a project which requires a VM to see

Re: [Qemu-devel] [Bug 1246012] Re: QEMU removes postgresql

2013-11-05 Thread Serge Hallyn
Quoting Joe Doe (joe.doe.launch...@mailinator.com): > You guys speak in technical terms that I can hardly understand. > postgresql-9.2 is not the default version for Ubuntu(I believe 9.1 is), but > can easily be installed by using the steps here -> > http://www.postgresql.org/download/linux/ubunt

[Qemu-devel] [Bug 1246012] Re: QEMU removes postgresql

2013-11-05 Thread Joe Doe
You guys speak in technical terms that I can hardly understand. postgresql-9.2 is not the default version for Ubuntu(I believe 9.1 is), but can easily be installed by using the steps here -> http://www.postgresql.org/download/linux/ubuntu/ . Anyways, the issue seems to be here: >sudo apt-get in

[Qemu-devel] [PATCH] MAINTAINERS: add git tree info for HMP, QMP and QAPI

2013-11-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 77edacf..02b85ee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -699,6 +699,7 @@ S: Supported F: monitor.c F: hmp.c F: hmp-commands.hx +T: git git://repo.or.cz

[Qemu-devel] Multi-head support RFC

2013-11-05 Thread John Baboval
Hello, I am currently the device model maintainer for XenClient Enterprise. As you may or may not know, we maintain a patch queue on top of QEMU (currently 1.3) that adds functionality needed to support XCE features. One of the major things we add is robust multi-head support. This includes

Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

2013-11-05 Thread Peter Maydell
On 5 November 2013 19:57, Anthony Liguori wrote: > This patch just requires that you explicitly select oss so it's not > breaking audio on BSD. That sounds to me like it's breaking audio for all the users for whom it previously worked out of the box without any particular configure or command lin

Re: [Qemu-devel] USB Passthrough not working for Windows 7 guest

2013-11-05 Thread Jens Frederich
>On 2013-11-05 17:01, Frederich, Jens wrote: >> Hi all, >> >> we're currently evaluating different RTOS systems (Windows CE, Intime, RTX, >> etc.). >> One system is Linux RT + KVM/QEMU with a Windows 7 guest. Up to now all >> works fine, Linux RT has good latency and KVM/Qemu setup was easy. But on

Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

2013-11-05 Thread Peter Maydell
On 5 November 2013 19:57, Anthony Liguori wrote: > Since the oss code can fail to initialize without handling it > gracefully, it really cannot be default on any platform. Can you describe what the actual problem is we're trying to fix here, please? I can't see a description of it in any of the m

Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno

2013-11-05 Thread Benoît Canet
Le Tuesday 05 Nov 2013 à 20:03:33 (+0100), Max Reitz a écrit : > error_setg_errno() may overwrite errno; therefore, its value should be > read before calling that function and not afterwards. > > Signed-off-by: Max Reitz > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

2013-11-05 Thread Anthony Liguori
Gerd Hoffmann writes: > On So, 2013-11-03 at 08:45 -0800, Anthony Liguori wrote: >> Modern Linux's no longer support /dev/dsp so enabling it by >> default causes audio failures on newer Linux distros. > > That will break sound on BSD. > > I think we should do something like this instead: > > ---

Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0

2013-11-05 Thread Peter Maydell
On 5 November 2013 19:31, Andreas Färber wrote: > Am 05.11.2013 20:09, schrieb Peter Maydell: >> I don't think there's any need to respin a patch >> just because somebody thinks it might be worth >> applying to stable. > > Point is, if you are ping'ing Anthony to apply this with his > fully-automa

Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0

2013-11-05 Thread Andreas Färber
Am 05.11.2013 20:09, schrieb Peter Maydell: > On 5 November 2013 18:45, Andreas Färber wrote: >> Am 05.11.2013 19:04, schrieb Peter Maydell: >>> Ping! >> >> A typo in the commit message has been reported > > What typo? Alex sent a reply claiming that there was > a missing space in the subject but

Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno

2013-11-05 Thread Eric Blake
On 11/05/2013 12:03 PM, Max Reitz wrote: > error_setg_errno() may overwrite errno; therefore, its value should be > read before calling that function and not afterwards. > > Signed-off-by: Max Reitz > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0

2013-11-05 Thread Peter Maydell
On 5 November 2013 18:45, Andreas Färber wrote: > Am 05.11.2013 19:04, schrieb Peter Maydell: >> Ping! > > A typo in the commit message has been reported What typo? Alex sent a reply claiming that there was a missing space in the subject but that appears to be entirely his email client's problem,

Re: [Qemu-devel] [PATCH v2 2/2] qemu-iotests: Add test for unbacked mirroring

2013-11-05 Thread Max Reitz
On 05.11.2013 10:00, Wenchao Xia wrote: > 于 2013/11/5 8:35, Max Reitz 写道: >> Add a new test for mirroring unbacked images in "absolute-paths" mode. >> This should work, if possible, but most importantly, qemu should never >> crash. >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/070

Re: [Qemu-devel] [PATCH v2 1/2] block/drive-mirror: Check for NULL backing_hd

2013-11-05 Thread Max Reitz
On 05.11.2013 04:32, Fam Zheng wrote: > > On 11/05/2013 08:35 AM, Max Reitz wrote: >> It should be possible to execute the QMP "drive-mirror" command in >> "none" sync mode and "absolute-paths" mode even for block devices >> lacking a backing file. >> >> "absolute-paths" does in fact not require a

Re: [Qemu-devel] [PATCH v2 0/9] Remove legacy unaligned bswap functions

2013-11-05 Thread Richard Henderson
On 11/06/2013 02:38 AM, Peter Maydell wrote: > This is a simple resend of a patchset which has been > on the list reviewed but unapplied for nine weeks, since > it's probably fallen out of Anthony's patches cache. > > > The bswap.h header includes a set of "legacy unaligned functions" > that (sin

[Qemu-devel] [PATCH] block: Save errno before error_setg_errno

2013-11-05 Thread Max Reitz
error_setg_errno() may overwrite errno; therefore, its value should be read before calling that function and not afterwards. Signed-off-by: Max Reitz --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 58efb5b..0e96a22 100644 --- a/block.c +++

Re: [Qemu-devel] [PULL v3 52/57] qom: Fix pointer to int property helpers' documentation

2013-11-05 Thread Andreas Färber
Am 05.11.2013 18:12, schrieb Andreas Färber: > From: "Michael S. Tsirkin" > > Relocate to alongside the other object_property_add_* helpers while at it. > > Signed-off-by: Andreas Färber Sorry Michael, forgot to edit the --author after resolving the merge conflict. Andreas -- SUSE LINUX Pro

[Qemu-devel] [Bug 1247478] Re: usb passthrough mass storage write data corruption

2013-11-05 Thread Sascha Krissler
it is apparently not a qemu bug, but either a libusb or (more likely) linux bug. it happens on linux 3.6 but not linux 3.4, with the difference of: (USBFS_CAP_NO_PACKET_SIZE_LIM | USBFS_CAP_BULK_SCATTER_GATHER) added to the hcd capabilities bitfield in 3.6 -- You received this bug notification be

Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0

2013-11-05 Thread Andreas Färber
Am 05.11.2013 19:04, schrieb Peter Maydell: > Ping! A typo in the commit message has been reported, and it has been requested to add Cc: qemu-sta...@nongnu.org. Since you neither CC qemu-trivial nor a particular maintainer that would fix those for you, you'll have to respin. Andreas > > thanks

Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0

2013-11-05 Thread Peter Maydell
Ping! thanks -- PMM On 21 October 2013 21:03, Peter Maydell wrote: > Our rules.mak adds '-rR' to MAKEFLAGS to indicate that we will be > explicitly specifying everything and not relying on any default > variables or rules. However we were accidentally relying on the > default ARFLAGS ("rv"). Thi

Re: [Qemu-devel] [PATCH v2] cpu-exec: Fix compiler warning (-Werror=clobbered)

2013-11-05 Thread Andreas Färber
Am 05.11.2013 18:52, schrieb Stefan Weil: > Am 31.10.2013 20:41, schrieb Jan Kiszka: >> On 2013-10-31 20:31, Stefan Weil wrote: >>> Reloading of local variables after sigsetjmp is only needed for some >>> buggy compilers. >>> >>> The code which should reload these variables causes compiler warnings

Re: [Qemu-devel] [PATCH v2] cpu-exec: Fix compiler warning (-Werror=clobbered)

2013-11-05 Thread Peter Maydell
On 5 November 2013 17:52, Stefan Weil wrote: > Am 31.10.2013 20:41, schrieb Jan Kiszka: >> On 2013-10-31 20:31, Stefan Weil wrote: >>> Reloading of local variables after sigsetjmp is only needed for some >>> buggy compilers. >>> >>> The code which should reload these variables causes compiler warn

Re: [Qemu-devel] [PATCH v2] cpu-exec: Fix compiler warning (-Werror=clobbered)

2013-11-05 Thread Stefan Weil
Am 31.10.2013 20:41, schrieb Jan Kiszka: > On 2013-10-31 20:31, Stefan Weil wrote: >> Reloading of local variables after sigsetjmp is only needed for some >> buggy compilers. >> >> The code which should reload these variables causes compiler warnings >> with gcc 4.7 when compiler optimizations are

Re: [Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

2013-11-05 Thread Andreas Färber
Am 04.11.2013 22:16, schrieb Paolo Bonzini: > Il 04/11/2013 21:51, Richard Henderson ha scritto: if test "$pie" = ""; then case "$cpu-$targetos" in -i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD) + i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm

Re: [Qemu-devel] [PATCH 1/2] pc: add etc/e820 fw_cfg file

2013-11-05 Thread Andrea Arcangeli
Hi, On Mon, Nov 04, 2013 at 01:17:10PM +0100, Gerd Hoffmann wrote: > Unlike the existing FW_CFG_E820_TABLE entry which carries reservations > only the new etc/e820 file also has entries for RAM. Acked, it looks the best the way to go if the objective is to keep backwards compatibility with older

Re: [Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

2013-11-05 Thread Andreas Färber
Am 04.11.2013 13:19, schrieb Dinar Valeev: > From: Dinar Valeev > > This patch enables pie for PowerPC and ARM architectures > > Signed-off-by: Dinar Valeev > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 91372f9..0130e7

Re: [Qemu-devel] USB Passthrough not working for Windows 7 guest

2013-11-05 Thread Jan Kiszka
On 2013-11-05 17:01, Frederich, Jens wrote: > Hi all, > > we're currently evaluating different RTOS systems (Windows CE, Intime, RTX, > etc.). > One system is Linux RT + KVM/QEMU with a Windows 7 guest. Up to now all > works fine, Linux RT has good latency and KVM/Qemu setup was easy. But one >

Re: [Qemu-devel] [PATCH] configure: detect endian via compile test

2013-11-05 Thread Peter Maydell
On 26 September 2013 21:54, Paolo Bonzini wrote: > Il 26/09/2013 05:22, Doug Goldstein ha scritto: >> On Mon, Sep 9, 2013 at 2:30 PM, Stefan Weil wrote: >>> Am 28.08.2013 10:21, schrieb James Hogan: On 1 July 2013 04:30, Mike Frysinger wrote: > This avoids needing to execute a program a

[Qemu-devel] [PATCH v2 3/9] bswap.h: Remove le16_to_cpupu()

2013-11-05 Thread Peter Maydell
Replace the legacy le16_to_cpupu() with lduw_le_p(). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Michael S. Tsirkin --- hw/acpi/core.c |3 +-- include/hw/pci/pci.h |2 +- include/qemu/bswap.h |5 - 3 files changed, 2 insertions(+), 8 deletions

[Qemu-devel] [PATCH v2 5/9] bswap.h: Remove be32_to_cpupu()

2013-11-05 Thread Peter Maydell
Replace the legacy be32_to_cpupu() with ldl_be_p(). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Michael S. Tsirkin --- hw/net/e1000.c |2 +- include/qemu/bswap.h |5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/net/e1000.c b/

[Qemu-devel] [PATCH v2 8/9] bswap.h: Remove cpu_to_be64wu()

2013-11-05 Thread Peter Maydell
Replace the legacy cpu_to_be64wu() with stq_be_p(). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Michael S. Tsirkin --- block/qcow2-cluster.c |2 +- include/qemu/bswap.h |5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/block/qcow2-clu

Re: [Qemu-devel] [PATCH v2] docs/memory.txt: Clarify and expand priority/overlap documentation

2013-11-05 Thread Peter Maydell
On 15 October 2013 15:42, Peter Maydell wrote: > The documentation of how overlapping memory regions behave and how > the priority system works was rather brief, and confusion about > priorities seems to be quite common for developers trying to understand > how the memory region system works, so e

[Qemu-devel] [PULL v3 52/57] qom: Fix pointer to int property helpers' documentation

2013-11-05 Thread Andreas Färber
From: "Michael S. Tsirkin" Relocate to alongside the other object_property_add_* helpers while at it. Signed-off-by: Andreas Färber --- include/qom/object.h | 73 +--- 1 file changed, 52 insertions(+), 21 deletions(-) diff --git a/include/qom/ob

Re: [Qemu-devel] [PATCH v2] docs/memory.txt: Clarify and expand priority/overlap documentation

2013-11-05 Thread Peter Maydell
On 5 November 2013 17:16, Michael S. Tsirkin wrote: > On Tue, Nov 05, 2013 at 05:11:09PM +, Peter Maydell wrote: >> On 15 October 2013 15:42, Peter Maydell wrote: >> > The documentation of how overlapping memory regions behave and how >> > the priority system works was rather brief, and confu

Re: [Qemu-devel] [PATCH v2] docs/memory.txt: Clarify and expand priority/overlap documentation

2013-11-05 Thread Michael S. Tsirkin
On Tue, Nov 05, 2013 at 05:11:09PM +, Peter Maydell wrote: > On 15 October 2013 15:42, Peter Maydell wrote: > > The documentation of how overlapping memory regions behave and how > > the priority system works was rather brief, and confusion about > > priorities seems to be quite common for dev

Re: [Qemu-devel] [PATCH for 1.7] pc: disable pci-info

2013-11-05 Thread Igor Mammedov
On Tue, 29 Oct 2013 15:35:07 +0100 Igor Mammedov wrote: > The BIOS that we ship in 1.7 does not use pci info > from host and so far isn't going to use it. > Taking in account problems it caused see 9604f70fdf and > to avoid future incompatibility issues, it's safest to > disable that interface by

Re: [Qemu-devel] [PATCH for 1.7] pc: disable pci-info

2013-11-05 Thread Michael S. Tsirkin
On Tue, Nov 05, 2013 at 06:11:16PM +0100, Igor Mammedov wrote: > On Tue, 29 Oct 2013 15:35:07 +0100 > Igor Mammedov wrote: > > > The BIOS that we ship in 1.7 does not use pci info > > from host and so far isn't going to use it. > > Taking in account problems it caused see 9604f70fdf and > > to av

[Qemu-devel] [PULL v3 00/58] QOM devices patch queue 2013-11-05

2013-11-05 Thread Andreas Färber
Hello Anthony, This is my updated QOM devices patch queue. Please pull. v3 is rebased on mst's pull so that make check passes and it contains new Reviewed-bys by Eric. Thanks, Andreas Cc: Anthony Liguori Cc: Peter Maydell Cc: Mian M. Hamayun Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: St

[Qemu-devel] [PATCH v2 2/9] bswap.h: Remove cpu_to_le32wu()

2013-11-05 Thread Peter Maydell
Replace the legacy cpu_to_le32wu() with stl_le_p(). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Michael S. Tsirkin --- hw/net/ne2000.c |2 +- include/hw/pci/pci.h |2 +- include/qemu/bswap.h |5 - 3 files changed, 2 insertions(+), 7 deletions(-

Re: [Qemu-devel] [PATCH] tests: fix 64-bit int literals for 32-bit hosts

2013-11-05 Thread Laszlo Ersek
On 11/05/13 17:42, Stefan Hajnoczi wrote: > On 32-bit hosts: > > CCtests/test-opts-visitor.o > tests/test-opts-visitor.c: In function 'test_value': > tests/test-opts-visitor.c:128: warning: integer constant is too large for > 'long' type > CCtests/test-bitops.o > tests/test-bitops.c:3

Re: [Qemu-devel] [PATCH] tests: fix 64-bit int literals for 32-bit hosts

2013-11-05 Thread Eric Blake
On 11/05/2013 09:42 AM, Stefan Hajnoczi wrote: > On 32-bit hosts: > > CCtests/test-opts-visitor.o > tests/test-opts-visitor.c: In function 'test_value': > tests/test-opts-visitor.c:128: warning: integer constant is too large for > 'long' type > CCtests/test-bitops.o > tests/test-bitop

Re: [Qemu-devel] [PATCH 00/20] Add an IPMI device to QEMU

2013-11-05 Thread Corey Minyard
On 11/05/2013 10:09 AM, Andreas Färber wrote: > Hi, > > Am 05.11.2013 14:56, schrieb Michael S. Tsirkin: >> On Wed, May 29, 2013 at 05:07:56PM -0500, miny...@acm.org wrote: >>> I have finally gotten some time to work on this, this series of >>> patches adds an IPMI interface to qemu. The changes a

[Qemu-devel] [PATCH v5] net: Adding netmap network backend

2013-11-05 Thread Vincenzo Maffione
This patch adds support for a network backend based on netmap. netmap is a framework for high speed packet I/O. You can use it to build extremely fast traffic generators, monitors, software switches or network middleboxes. Its companion software switch VALE lets you interconnect virtual machines. n

[Qemu-devel] [PATCH v2 9/9] bswap.h: Remove cpu_to_32wu()

2013-11-05 Thread Peter Maydell
Replace the legacy cpu_to_32wu() with stl_p(). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Michael S. Tsirkin --- hw/display/vga_template.h | 14 -- include/qemu/bswap.h |7 --- 2 files changed, 8 insertions(+), 13 deletions(-) diff --gi

[Qemu-devel] [PATCH v2 4/9] bswap.h: Remove le32_to_cpupu()

2013-11-05 Thread Peter Maydell
Replace the legacy le32_to_cpupu() with ldl_le_p(). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Michael S. Tsirkin --- hw/net/ne2000.c |2 +- include/hw/pci/pci.h |2 +- include/qemu/bswap.h |5 - 3 files changed, 2 insertions(+), 7 deletions(-

[Qemu-devel] [PATCH] tests: fix 64-bit int literals for 32-bit hosts

2013-11-05 Thread Stefan Hajnoczi
On 32-bit hosts: CCtests/test-opts-visitor.o tests/test-opts-visitor.c: In function 'test_value': tests/test-opts-visitor.c:128: warning: integer constant is too large for 'long' type CCtests/test-bitops.o tests/test-bitops.c:34: warning: integer constant is too large for 'long' type

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2013-11-05 Thread Jens Frederich
All devices work on other hypervisors like VMware Workstation etc... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/685096 Title: USB Passthrough not working for Windows 7 guest Status in QEMU: C

[Qemu-devel] [PATCH v2 7/9] bswap.h: Remove cpu_to_be32wu()

2013-11-05 Thread Peter Maydell
Replace the legacy cpu_to_be32wu() with stl_be_p(). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Michael S. Tsirkin --- hw/block/cdrom.c |6 +++--- hw/net/e1000.c |3 +-- hw/pci/pcie_aer.c|4 ++-- include/qemu/bswap.h |5 - 4 files

[Qemu-devel] [PATCH v2 0/9] Remove legacy unaligned bswap functions

2013-11-05 Thread Peter Maydell
This is a simple resend of a patchset which has been on the list reviewed but unapplied for nine weeks, since it's probably fallen out of Anthony's patches cache. The bswap.h header includes a set of "legacy unaligned functions" that (since commit c732a52d3 at the beginning of this year) are just

[Qemu-devel] [PATCH v2 1/9] bswap.h: Remove cpu_to_le16wu()

2013-11-05 Thread Peter Maydell
Replace the legacy cpu_to_le16wu() with stw_le_p(). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Michael S. Tsirkin --- hw/acpi/core.c |4 ++-- include/hw/pci/pci.h |2 +- include/qemu/bswap.h |5 - 3 files changed, 3 insertions(+), 8 deletions

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2013-11-05 Thread Jens Frederich
Hi Serge, for your information. I sent a mail to the devel mailing list. See below. I've tried to passthrough special Vector automotive usb in house devices. Look here: http://vector.com/vi_vn1600_en.html. What do you mean with "what commands you've tried"? I've tried three QEMU versions: 1. U

[Qemu-devel] [PATCH v2 6/9] bswap.h: Remove cpu_to_be16wu()

2013-11-05 Thread Peter Maydell
Replace the legacy cpu_to_be16wu() with stw_be_p(). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Michael S. Tsirkin --- hw/block/cdrom.c |4 ++-- hw/ide/atapi.c | 16 hw/net/e1000.c | 19 --- include/qemu/bswa

Re: [Qemu-devel] [libvirt] [PATCH RFC] blockdev: copy legacy and common opts to qemu_drive_opts

2013-11-05 Thread Amos Kong
Hi Kevin, On Mon, Nov 04, 2013 at 12:27:10PM +0100, Kevin Wolf wrote: > Am 04.11.2013 um 08:01 hat Amos Kong geschrieben: > > Currently we have three QemuOptsList (qemu_common_drive_opts, > > qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts > > is added to vm_config_groups[]. > >

Re: [Qemu-devel] [PATCH] integrator/cp: add support for REFCNTregisterr

2013-11-05 Thread Peter Maydell
On 5 November 2013 16:18, Alex Bennée wrote: > I suspect it would be worth updating the QEMU wiki pages and building a > simple vexpress image (or showing simple steps for the Linaro vexpress > builds). It's painful because of GPL issues if you just provide the binary... -- PMM

Re: [Qemu-devel] [PATCH] RFC: powerpc: add PVR compatibility check

2013-11-05 Thread Alexander Graf
On 05.11.2013, at 17:16, Andreas Färber wrote: > Am 05.11.2013 07:05, schrieb Alexander Graf: >> >> >> Am 05.11.2013 um 05:00 schrieb Paul Mackerras : >> >>> On Mon, Nov 04, 2013 at 10:05:58AM +0100, Alexander Graf wrote: Yeah, we really need to check that guest vpcu == host vcpu f

Re: [Qemu-devel] [PATCH] integrator/cp: add support for REFCNTregisterr

2013-11-05 Thread Alex Bennée
peter.mayd...@linaro.org writes: > On 5 November 2013 14:44, Jan Petrouš wrote: >> Hehe, duno, but when I started learning QEMU the Integrator devboard >> looked for me the nice start-up point = very simple to understand >> and only very basic, but still core, device list. > > QEMU's integrator

Re: [Qemu-devel] [Bug 1248168] [NEW] MIPS, self-modifying code and uncached memory

2013-11-05 Thread Antony Pavlov
On Tue, 05 Nov 2013 12:47:13 - Nikita Kanunnikov wrote: Could you please provide some additional information for error reproducing? (qemu version, necessary binary files, qemu cmdline etc) Par exemple I have tried to reproduce your error on qemu-1.6.1. I use qemu-system-mips (so it's big-en

Re: [Qemu-devel] [PATCH] RFC: powerpc: add PVR compatibility check

2013-11-05 Thread Andreas Färber
Am 05.11.2013 07:05, schrieb Alexander Graf: > > > Am 05.11.2013 um 05:00 schrieb Paul Mackerras : > >> On Mon, Nov 04, 2013 at 10:05:58AM +0100, Alexander Graf wrote: >>> >>> Yeah, we really need to check that guest vpcu == host vcpu for HV KVM. >> >> In general I agree, but the one difficulty

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2013-11-05 Thread Serge Hallyn
Hi Jens, could you tell us exactly what you are trying to pass through, what commands you've tried, and with what version of qemu (and, if hand- built, which options were passed to configure). 1.5 came with a new passthrough implementation, but alongside the old. So I wonder whether choosing the

Re: [Qemu-devel] [PATCH 00/20] Add an IPMI device to QEMU

2013-11-05 Thread Andreas Färber
Hi, Am 05.11.2013 14:56, schrieb Michael S. Tsirkin: > On Wed, May 29, 2013 at 05:07:56PM -0500, miny...@acm.org wrote: >> I have finally gotten some time to work on this, this series of >> patches adds an IPMI interface to qemu. The changes are roughly: >> >> patches 01-05 - Add the capability t

  1   2   3   >