Re: [Qemu-devel] Using TRIM to shrink qcow2 images

2013-10-03 Thread Alexey Kardashevskiy
Hi Paolo! On Thu, Aug 8, 2013 at 10:00 PM, Paolo Bonzini wrote: > On 08/08/2013 12:34 PM, Ralf Ramsauer wrote: > >> Hi, >> >> QCOW2 uses a similar idea like file holes (sparse files) on filesystems >> [1]. >> RAW Images also may use file holes. >> >> If qemu would support TRIM, then the guest

Re: [Qemu-devel] [PATCH V13 10/13] NUMA: add qmp command set-mem-policy to set memory policy for NUMA node

2013-10-03 Thread Marcelo Tosatti
On Wed, Oct 02, 2013 at 11:13:29PM -0300, Marcelo Tosatti wrote: > On Tue, Sep 17, 2013 at 11:16:22AM +0800, Wanlong Gao wrote: > > This QMP command allows user set guest node's memory policy > > through the QMP protocol. The qmp-shell command is like: > > set-mem-policy nodeid=0 policy=membind

[Qemu-devel] [PATCH 2/5] exec: Delete is_tcg_gen_code and GETRA_EXT

2013-10-03 Thread Richard Henderson
All implementations now boil down to GETRA. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 12 include/exec/softmmu_template.h | 4 ++-- translate-all.c | 12 3 files changed, 2 insertions(+), 26 deletions(-) diff --git a/includ

[Qemu-devel] [PATCH 5/5] configure: Remove CONFIG_QEMU_LDST_OPTIMIZATION

2013-10-03 Thread Richard Henderson
No longer used. Signed-off-by: Richard Henderson --- configure | 8 1 file changed, 8 deletions(-) diff --git a/configure b/configure index 23dbaaf..e6b6f14 100755 --- a/configure +++ b/configure @@ -3794,14 +3794,6 @@ echo "libs_softmmu=$libs_softmmu" >> $config_host_mak echo "ARCH

[Qemu-devel] [PATCH 1/5] tcg-aarch64: Update to helper_ret_*_mmu routines

2013-10-03 Thread Richard Henderson
A minimal update to use the new helpers with the return address argument. Cc: Claudio Fontana Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 18 -- tcg/aarch64/tcg-target.c | 28 2 files changed, 16 insertions(+), 30 deletions(-) di

[Qemu-devel] [PATCH 0/5] Remove CONFIG_QEMU_LDST_OPTIMIZATION

2013-10-03 Thread Richard Henderson
This patch set is based upon git://github.com/rth7680/qemu.git tcg-arm-pull With the first patch, to convert aarch64 away from the old ldst helpers, we wean exec-all.h from any knowledge of the tcg backend implementation. Which means we no longer need to involve configure in the backend implem

[Qemu-devel] [PATCH 4/5] tcg: Add tcg-be-ldst.h

2013-10-03 Thread Richard Henderson
Move TCGLabelQemuLdst and related stuff out of tcg.h. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 23 ++--- tcg/arm/tcg-target.c | 27 ++- tcg/i386/tcg-target.c| 30 ++-- tcg/ppc/tcg-target.c | 28 ++- tcg/ppc64/tcg-targ

[Qemu-devel] [PATCH 3/5] tcg: Add tcg-be-null.h

2013-10-03 Thread Richard Henderson
This is a no-op backend data implementation, for those targets that are not currently using the load/store optimization path. This is prepatory to always requiring these functions in all backends. Signed-off-by: Richard Henderson --- tcg/ia64/tcg-target.c | 2 ++ tcg/mips/tcg-target.c | 2 +

Re: [Qemu-devel] [PULL 3/6] vfio-pci: Lazy PCI option ROM loading

2013-10-03 Thread Alex Williamson
On Thu, 2013-10-03 at 20:46 +0200, Paolo Bonzini wrote: > Il 03/10/2013 17:39, Alex Williamson ha scritto: > > +static const MemoryRegionOps vfio_rom_ops = { > > +.read = vfio_rom_read, > > +.endianness = DEVICE_LITTLE_ENDIAN, > > +}; > > + > > I think you need to define a write callback t

Re: [Qemu-devel] [PULL 3/6] vfio-pci: Lazy PCI option ROM loading

2013-10-03 Thread Paolo Bonzini
Il 03/10/2013 17:39, Alex Williamson ha scritto: > +static const MemoryRegionOps vfio_rom_ops = { > +.read = vfio_rom_read, > +.endianness = DEVICE_LITTLE_ENDIAN, > +}; > + I think you need to define a write callback too (unless you're sure for some other reason that the area will never be

Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Richard Henderson
On 10/03/2013 10:28 AM, Richard Henderson wrote: > For the simple conditions, yes. For the more complex ones, > you might want to do the computation in 32-bit and extend > the result. Alternately, compute the condition with setcond_i32 and only extend that result to 64 bits. That means doing som

Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset

2013-10-03 Thread Paolo Bonzini
Il 03/10/2013 18:54, Michael S. Tsirkin ha scritto: > > For each PCI device I tried creating a VM with an instance of it (a few > > devices at a time), and did VM resets. Earlier versions were tested by > > the guy who reported the SCSI problems. > > x86 kvm only? Yes. Paolo

Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset

2013-10-03 Thread Michael S. Tsirkin
On Thu, Oct 03, 2013 at 05:58:30PM +0200, Paolo Bonzini wrote: > Il 03/10/2013 15:54, Michael S. Tsirkin ha scritto: > > On Thu, Oct 03, 2013 at 03:46:11PM +0200, Paolo Bonzini wrote: > >> PCI is handling resetting of its devices before the bus is reset, > >> but this is only necessary because qdev

[Qemu-devel] [PULL 0/6] VFIO updates for QEMU

2013-10-03 Thread Alex Williamson
The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-pci-for-qemu-20131003.0 for

[Qemu-devel] [PATCH v8 12/26] acpi: add rules to compile ASL source

2013-10-03 Thread Michael S. Tsirkin
Detect presence of IASL compiler and use it to process ASL source. If not there, use pre-compiled files in-tree. Add script to update the in-tree files. Note: distros are known to silently update iasl so detect correct iasl flags for the installed version on each run as opposed to at configure tim

[Qemu-devel] [PATCH v8 03/26] qom: add pointer to int property helpers

2013-10-03 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 21 ++ qom/object.c | 60 +

[Qemu-devel] [PULL 5/6] vfio-pci: Implement PCI hot reset

2013-10-03 Thread Alex Williamson
Now that VFIO has a PCI hot reset interface, take advantage of it. There are two modes that we need to consider. The first is when only one device within the set of devices affected is actually assigned to the guest. In this case the other devices are are just held by VFIO for isolation and we ca

Re: [Qemu-devel] [PATCH] cpu-exec(): also reload CPUClass *cc after longjmp return

2013-10-03 Thread Peter Maydell
On 3 October 2013 23:09, Juergen Lock wrote: > Local variable CPUClass *cc needs to be reloaded after return from longjmp > too. (This fixes the mips-softmmu crash observed on FreeBSD when qemu is > built with clang.) > > Signed-off-by: Juergen Lock > Found-by: Dimitry Andric > > --- a/cpu-exec

Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset

2013-10-03 Thread Paolo Bonzini
Il 03/10/2013 15:54, Michael S. Tsirkin ha scritto: > On Thu, Oct 03, 2013 at 03:46:11PM +0200, Paolo Bonzini wrote: >> PCI is handling resetting of its devices before the bus is reset, >> but this is only necessary because qdev is broken and usually does >> pre-order reset. Post-order is a much b

[Qemu-devel] [PATCHv4 2/2] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Will Newton
This adds support for the VSEL floating point selection instruction which was added in ARMv8. Signed-off-by: Will Newton --- target-arm/translate.c | 113 + 1 file changed, 113 insertions(+) Changes in v4: - Fix leak of temporaries - Extend con

[Qemu-devel] [PATCH 1/2] target-arm: Move call to disas_vfp_insn out of disas_coproc_insn.

2013-10-03 Thread Will Newton
Floating point is an extension to the instruction set rather than a coprocessor, so call it directly from the ARM and Thumb decode functions. Signed-off-by: Will Newton --- target-arm/translate.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/target-

[Qemu-devel] [PATCH] cpu-exec(): also reload CPUClass *cc after longjmp return

2013-10-03 Thread Juergen Lock
Local variable CPUClass *cc needs to be reloaded after return from longjmp too. (This fixes the mips-softmmu crash observed on FreeBSD when qemu is built with clang.) Signed-off-by: Juergen Lock Found-by: Dimitry Andric --- a/cpu-exec.c +++ b/cpu-exec.c @@ -681,6 +681,10 @@ int cpu_exec(CPUArc

[Qemu-devel] [Bug 1234179] Re: QEMU segfaults during Windows 7 unattended install

2013-10-03 Thread Michael Tokarev
That's a seabios update. It is interesting that qemu may crash due to different bios - this smells fishy, and it looks like there's some big security issue waiting to be discovered... ;) Lucas, I think you want to change --disable-strip into --enable-debug in your configure line, to be able to pr

[Qemu-devel] [PULL 4/6] vfio-pci: Cleanup error_reports

2013-10-03 Thread Alex Williamson
Remove carriage returns and tweak formatting for error_reports. Signed-off-by: Alex Williamson --- hw/misc/vfio.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 730dec5..a73e7f5 100644 --- a/hw/misc/vfio.c ++

[Qemu-devel] [PULL 2/6] vfio-pci: Test device reset capabilities

2013-10-03 Thread Alex Williamson
Not all resets are created equal. PM reset is not very reliable, especially for GPUs, so we might want to opt for a bus reset if a standard reset will only do a D3hot->D0 transition. We can also use this to tell if the standard reset will do a bus reset (if neither has_pm_reset or has_flr is prob

[Qemu-devel] [PULL 6/6] vfio: Fix debug output for int128 values

2013-10-03 Thread Alex Williamson
From: Alexey Kardashevskiy Memory regions can easily be 2^64 byte long and therefore overflow for just a bit but that is enough for int128_get64() to assert. This takes care of debug printing of huge section sizes. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Alex Williamson --- hw/mis

[Qemu-devel] [PULL 3/6] vfio-pci: Lazy PCI option ROM loading

2013-10-03 Thread Alex Williamson
During vfio-pci initfn, the device is not always in a state where the option ROM can be read. In the case of graphics cards, there's often no per function reset, which means we have host driver state affecting whether the option ROM is usable. Ideally we want to move reading the option ROM past a

[Qemu-devel] [PULL 1/6] vfio-pci: Add support for MSI affinity

2013-10-03 Thread Alex Williamson
When MSI is accelerated through KVM the vectors are only programmed when the guest first enables MSI support.  Subsequent writes to the vector address or data fields are ignored.  Unfortunately that means we're ignore updates done to adjust SMP affinity of the vectors. MSI SMP affinity already work

Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Richard Henderson
On 10/03/2013 08:10 AM, Will Newton wrote: > No, thanks for picking that up. I was wondering if that was valid and > the code seemed to work. What's the best way to work around the > problem? Just extend everything up to 64bits? For the simple conditions, yes. For the more complex ones, you might

[Qemu-devel] [PATCH v8 17/26] loader: allow adding ROMs in done callbacks

2013-10-03 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/loader.h | 1 + hw/core/loader.c| 6 +- vl.c| 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/includ

[Qemu-devel] [PATCH v8 26/26] ssdt-proc: update generated file

2013-10-03 Thread Michael S. Tsirkin
Update generated ssdt proc hex file (used for systems lacking IASL) after P_BLK length change. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-proc.hex.generated | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH v8 22/26] pvpanic: add API to access io port

2013-10-03 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 1 + hw/misc/pvpanic.c| 13 - 2 files changed, 13 insertions(+), 1

Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Will Newton
On 3 October 2013 15:34, Richard Henderson wrote: > On 10/03/2013 05:51 AM, Will Newton wrote: >> +case 0: /* eq: Z */ >> +tcg_gen_movcond_i64(TCG_COND_EQ, ftmp3, cpu_ZF, >> zero, >> +ftmp1, ftmp2); >> +

[Qemu-devel] [PATCH v8 21/26] ich9: APIs for pc guest info

2013-10-03 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in acpi tables, implemented using QOM, to various ich9 components. Some information is still missing in QOM, so we fall back on lookups by type instead. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw

[Qemu-devel] [PATCH v8 20/26] piix: APIs for pc guest info

2013-10-03 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest acpi tables. Some required information is still lacking in QOM, so we fall back on lookups by type and returning explicit types. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/piix4.h |

[Qemu-devel] [PATCH v8 19/26] acpi/piix: add macros for acpi property names

2013-10-03 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 10 ++ hw/acpi/piix4.c | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 085a621..5aefc5b 10

[Qemu-devel] [PATCH v8 25/26] ssdt: fix PBLK length

2013-10-03 Thread Michael S. Tsirkin
We don't really support CPU throttling, so supply 0 PBLK length. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-proc.dsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/ssdt-proc.dsl b/hw/i386/ssdt-proc.dsl ind

[Qemu-devel] [PATCH v8 18/26] i386: define pc guest info

2013-10-03 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Reviewed-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 9 + hw/i386/pc.c

[Qemu-devel] [PATCH v8 23/26] hpet: add API to find it

2013-10-03 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/timer/hpet.h | 2 ++ hw/timer/hpet.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h index 75

[Qemu-devel] [PATCH v8 09/26] q35: use macro for MCFG property name

2013-10-03 Thread Michael S. Tsirkin
Useful to make it accessible through QOM. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 2 ++ hw/pci-host/q35.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pcie_host.h b/i

[Qemu-devel] [PATCH v8 16/26] i386: add bios linker/loader

2013-10-03 Thread Michael S. Tsirkin
This adds a dynamic bios linker/loader. This will be used by acpi table generation code to: - load each table in the appropriate memory segment - link tables to each other - fix up checksums after said linking Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael

[Qemu-devel] [PATCH v8 08/26] pcie_host: expose address format

2013-10-03 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 21 + hw/pci/pcie_host.c | 21 - 2 files changed,

[Qemu-devel] [PATCH v8 07/26] pcie_host: expose UNMAPPED macro

2013-10-03 Thread Michael S. Tsirkin
Make it possible to test unmapped status through QMP. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 3 +++ hw/pci/pcie_host.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/pci/

[Qemu-devel] [PATCH v8 15/26] loader: use file path size from fw_cfg.h

2013-10-03 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/nvram/fw_cfg.h | 4 +++- hw/core/loader.c | 2 +- 2 files changed, 4 insertions(+), 2

[Qemu-devel] [PATCH v8 06/26] loader: support for unmapped ROM blobs

2013-10-03 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: same as ROM files really but use caller's buffer. Support incoking callback on access and return memory pointer making it easier for caller to update memory if necessary. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Reviewed-by: Laszlo Erse

[Qemu-devel] [PATCH v8 14/26] acpi: ssdt pcihp: updat generated file

2013-10-03 Thread Michael S. Tsirkin
update generated file, not sure what changed Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-pcihp.hex.generated | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/ssdt-pcihp.hex.generated b/hw/i386/ssdt-pc

[Qemu-devel] [PATCH v8 05/26] fw_cfg: interface to trigger callback on read

2013-10-03 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c | 33 - 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/include/hw/nvram/fw_cfg.h b/include/hw

[Qemu-devel] [PATCH v8 01/26] cleanup object.h: include error.h directly

2013-10-03 Thread Michael S. Tsirkin
From: Igor Mammedov qapi/error.h is simple enough to be included in qom/object.h direcly and prepares qom/object.h to use Error typedef. Signed-off-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PATCH v8 10/26] q35: expose mmcfg size as a property

2013-10-03 Thread Michael S. Tsirkin
Address is already exposed, expose size for symmetry. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 1 + hw/pci-host/q35.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/hw/pci/pcie

[Qemu-devel] [PATCH v8 02/26] qom: cleanup struct Error references

2013-10-03 Thread Michael S. Tsirkin
now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 50 +---

[Qemu-devel] [PATCH v8 04/26] pci: fix up w64 size calculation helper

2013-10-03 Thread Michael S. Tsirkin
BAR base was calculated incorrectly. Use existing pci_bar_address to get it right. Tested-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin --- hw/pci/pci.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 00554a0..c3f

[Qemu-devel] [PATCH v8 00/26] qemu: generate acpi tables for the guest

2013-10-03 Thread Michael S. Tsirkin
I sent v7 only today but that submission was botched: v7 was already sent yesterday, and missed a typo reported by Eric. Besides, I fixed whitespace issues noted by Igor. Resending properly, sorry about the noise. This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

Re: [Qemu-devel] [PATCH RFC 04/11] s390/qemu: cpu model cpu facilitiy support

2013-10-03 Thread Richard Henderson
On 10/02/2013 04:33 AM, Michael Mueller wrote: > +/* set a specific bit in facility set */ > +static void set_facility(unsigned int nr, void *facilities) > +{ > +unsigned char *ptr; > + > +if (nr >= MAX_S390_FACILITY_BIT) { > +return; > +} > +ptr = (unsigned char *) faciliti

Re: [Qemu-devel] [Bug 1180777] Re: RDP traffic freeze on quiet network

2013-10-03 Thread Serge Hallyn
Quoting Vasile Dumitrescu (launchpad.vas...@undeva.net): > I added a rtl8139c netcard to the VM and connected through it by RDP - > no more freezes. > > It looks like kvm does not play well with virtio network cards and RDP. > > Red Hat virtio net windows driver version: 62.65.104.6500, 6/19/2013

Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Richard Henderson
On 10/03/2013 05:51 AM, Will Newton wrote: > +case 0: /* eq: Z */ > +tcg_gen_movcond_i64(TCG_COND_EQ, ftmp3, cpu_ZF, zero, > +ftmp1, ftmp2); > +break; Does this compile when configured w

Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Peter Maydell
On 3 October 2013 23:31, Will Newton wrote: > On 3 October 2013 13:59, Peter Maydell wrote: >> This isn't what I meant. If our decoding matches up with the ARM ARM >> then this instruction pattern should already fall into disas_vfp_insn(), >> and we shouldn't need an extra check and call. (If it'

[Qemu-devel] [PATCH v3] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Will Newton
This adds support for the VSEL floating point selection instruction which was added in ARMv8. Signed-off-by: Will Newton --- target-arm/translate.c | 115 ++--- 1 file changed, 110 insertions(+), 5 deletions(-) Changes in v3: - Move calls to disas_v

Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Will Newton
On 3 October 2013 13:59, Peter Maydell wrote: > On 3 October 2013 21:51, Will Newton wrote: >> >> This adds support for the VSEL floating point selection instruction >> which was added in ARMv8. It is based on the previous patch[1] from >> Mans Rullgard, but attempts to address the feedback given

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-03 Thread Lei Li
On 10/03/2013 09:34 PM, Paolo Bonzini wrote: Il 03/10/2013 15:29, Lei Li ha scritto: On 10/03/2013 06:34 PM, Paolo Bonzini wrote: Il 03/10/2013 12:28, Lei Li ha scritto: The load_hook callback is only be called if the RAM_SAVE_FLAG_HOOK is received. To check this flags, it means there would be

Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset

2013-10-03 Thread Michael S. Tsirkin
On Thu, Oct 03, 2013 at 03:46:11PM +0200, Paolo Bonzini wrote: > PCI is handling resetting of its devices before the bus is reset, > but this is only necessary because qdev is broken and usually does > pre-order reset. Post-order is a much better definition. Drop > the unnecessary flexibility tha

[Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions

2013-10-03 Thread Paolo Bonzini
Resetting should be done in post-order, not pre-order. However, qdev_walk_children and qbus_walk_children do not allow this. Fix it by adding two extra arguments to the functions. Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 45 + incl

[Qemu-devel] [PATCH 1/4] pci: do not export pci_bus_reset

2013-10-03 Thread Paolo Bonzini
qbus_reset_all can be used instead. There is no semantic change because pcibus_reset returns 1 and takes care of the device tree traversal. Signed-off-by: Paolo Bonzini --- hw/pci/pci.c |8 ++-- hw/pci/pci_bridge.c |2 +- include/hw/pci/pci.h |1 - 3 files changed, 3 in

[Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset

2013-10-03 Thread Paolo Bonzini
PCI is handling resetting of its devices before the bus is reset, but this is only necessary because qdev is broken and usually does pre-order reset. Post-order is a much better definition. Drop the unnecessary flexibility that lets bus decide the reset order, convert to post-order, and make PCI

[Qemu-devel] [PATCH 2/4] pci: clean up resetting of IRQs

2013-10-03 Thread Paolo Bonzini
pci_device_reset will deassert the INTX pins, and this will make the irq_count array all-zeroes. Check that this is the case, and remove the existing loop which might even unsync irq_count and irq_state. Signed-off-by: Paolo Bonzini --- hw/pci/pci.c |7 --- 1 files changed, 4 insertions

[Qemu-devel] [PATCH 4/4] qdev: switch reset to post-order

2013-10-03 Thread Paolo Bonzini
Post-order is the only sensible direction for the reset signals. For example, suppose pre-order is used and the parent has some data structures that cache children state (for example a list of active requests). When the reset method is invoked on the parent, these caches could be in any state. If

[Qemu-devel] [PATCH] compatfd: switch to QemuThread

2013-10-03 Thread Paolo Bonzini
From: Jan Kiszka qemu_thread_create already does signal blocking and detaching for us. Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- util/compatfd.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/util/compatfd.c b/util/compatfd.c index 9cf3f

[Qemu-devel] [PATCH 3/3] vga: Mark relevant portio lists regions as coalesced MMIO flushing

2013-10-03 Thread Paolo Bonzini
From: Jan Kiszka This allows to remove the explicit qemu_flush_coalesced_mmio_buffer calls. Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- hw/display/qxl.c | 1 + hw/display/vga.c | 5 + 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/display/qxl.c b/hw/displ

[Qemu-devel] [PATCH 0/3] Coalesced MMIO flushing cleanups

2013-10-03 Thread Paolo Bonzini
Three patches from Jan. They've never been posted publicly, so I'm doing that to get them review and exposure. I'll send a pull request sometime next week. Paolo Jan Kiszka (3): portio: Allow to mark portio lists as coalesced MMIO flushing cirrus: Mark vga io region as coalesced MMIO flushi

[Qemu-devel] [PATCH 2/3] cirrus: Mark vga io region as coalesced MMIO flushing

2013-10-03 Thread Paolo Bonzini
From: Jan Kiszka This allows to remove the explicit qemu_flush_coalesced_mmio_buffer calls - the memory core will invoke them now. Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- hw/display/cirrus_vga.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/displa

[Qemu-devel] [PATCH 1/3] portio: Allow to mark portio lists as coalesced MMIO flushing

2013-10-03 Thread Paolo Bonzini
From: Jan Kiszka This will enable us to remove all remaining explicit calls of qemu_flush_coalesced_mmio_buffer in IO handlers. Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- include/exec/ioport.h | 2 ++ ioport.c | 9 + 2 files changed, 11 insertions(+) diff

[Qemu-devel] [PATCH v7 12/26] acpi: add rules to compile ASL source

2013-10-03 Thread Michael S. Tsirkin
Detect presence of IASL compiler and use it to process ASL source. If not there, use pre-compiled files in-tree. Add script to update the in-tree files. Note: distros are known to silently update iasl so detect correct iasl flags for the installed version on each run as opposed to at configure tim

[Qemu-devel] [PATCH v7 20/26] piix: APIs for pc guest info

2013-10-03 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest acpi tables. Some required information is still lacking in QOM, so we fall back on lookups by type and returning explicit types. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/piix4.h |

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-03 Thread Paolo Bonzini
Il 03/10/2013 15:29, Lei Li ha scritto: > On 10/03/2013 06:34 PM, Paolo Bonzini wrote: >> Il 03/10/2013 12:28, Lei Li ha scritto: >>> The load_hook callback is only be called if the RAM_SAVE_FLAG_HOOK is >>> received. >>> To check this flags, it means there would be a check action first in >>> unix

Re: [Qemu-devel] [PATCH] qemu-char: Fix potential out of bounds accessto local arrayss

2013-10-03 Thread Alex Bennée
s...@weilnetz.de writes: > Latest gcc-4.8 supports a new option -fsanitize=address which activates > an AddressSanitizer. This AddressSanitizer stops the QEMU system emulation > very early because two character arrays of size 8 are potentially written > with 9 bytes. > > Commit 6ea314d91439741e95

[Qemu-devel] [PATCH v7 26/26] ssdt-proc: update generated file

2013-10-03 Thread Michael S. Tsirkin
Update generated ssdt proc hex file (used for systems lacking IASL) after P_BLK length change. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-proc.hex.generated | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH v7 16/26] i386: add bios linker/loader

2013-10-03 Thread Michael S. Tsirkin
This adds a dynamic bios linker/loader. This will be used by acpi table generation code to: - load each table in the appropriate memory segment - link tables to each other - fix up checksums after said linking Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael

[Qemu-devel] [PATCH v7 21/26] ich9: APIs for pc guest info

2013-10-03 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in acpi tables, implemented using QOM, to various ich9 components. Some information is still missing in QOM, so we fall back on lookups by type instead. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw

Re: [Qemu-devel] [PATCH 0/8 RFC] migration: Introduce side channel for RAM

2013-10-03 Thread Lei Li
On 10/03/2013 06:34 PM, Paolo Bonzini wrote: Il 03/10/2013 12:28, Lei Li ha scritto: The load_hook callback is only be called if the RAM_SAVE_FLAG_HOOK is received. To check this flags, it means there would be a check action first in unix_accept_incoming_migration(), like: f = qemu_fopen_pipe(c

[Qemu-devel] [PATCH v7 25/26] ssdt: fix PBLK length

2013-10-03 Thread Michael S. Tsirkin
We don't really support CPU throttling, so supply 0 PBLK length. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-proc.dsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/ssdt-proc.dsl b/hw/i386/ssdt-proc.dsl ind

[Qemu-devel] [PATCH v7 19/26] acpi/piix: add macros for acpi property names

2013-10-03 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 10 ++ hw/acpi/piix4.c | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 085a621..5aefc5b 10

[Qemu-devel] [PATCH v7 23/26] hpet: add API to find it

2013-10-03 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/timer/hpet.h | 2 ++ hw/timer/hpet.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h index 75

[Qemu-devel] [PATCH v7 14/26] acpi: ssdt pcihp: updat generated file

2013-10-03 Thread Michael S. Tsirkin
update generated file, not sure what changed Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-pcihp.hex.generated | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/ssdt-pcihp.hex.generated b/hw/i386/ssdt-pc

[Qemu-devel] [PATCH v7 15/26] loader: use file path size from fw_cfg.h

2013-10-03 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/nvram/fw_cfg.h | 4 +++- hw/core/loader.c | 2 +- 2 files changed, 4 insertions(+), 2

[Qemu-devel] [PATCH v7 18/26] i386: define pc guest info

2013-10-03 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Reviewed-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 9 + hw/i386/pc.c

[Qemu-devel] [PATCH v7 06/26] loader: support for unmapped ROM blobs

2013-10-03 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: same as ROM files really but use caller's buffer. Support incoking callback on access and return memory pointer making it easier for caller to update memory if necessary. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Reviewed-by: Laszlo Erse

[Qemu-devel] [PATCH v7 22/26] pvpanic: add API to access io port

2013-10-03 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 1 + hw/misc/pvpanic.c| 13 - 2 files changed, 13 insertions(+), 1

[Qemu-devel] [PATCH v7 17/26] loader: allow adding ROMs in done callbacks

2013-10-03 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/loader.h | 1 + hw/core/loader.c| 6 +- vl.c| 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/includ

[Qemu-devel] [PATCH v7 09/26] q35: use macro for MCFG property name

2013-10-03 Thread Michael S. Tsirkin
Useful to make it accessible through QOM. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 2 ++ hw/pci-host/q35.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pcie_host.h b/i

[Qemu-devel] [PATCH v7 07/26] pcie_host: expose UNMAPPED macro

2013-10-03 Thread Michael S. Tsirkin
Make it possible to test unmapped status through QMP. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 3 +++ hw/pci/pcie_host.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/pci/

[Qemu-devel] [PATCH v7 10/26] q35: expose mmcfg size as a property

2013-10-03 Thread Michael S. Tsirkin
Address is already exposed, expose size for symmetry. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 1 + hw/pci-host/q35.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/hw/pci/pcie

[Qemu-devel] [PATCH v7 04/26] pci: fix up w64 size calculation helper

2013-10-03 Thread Michael S. Tsirkin
BAR base was calculated incorrectly. Use existing pci_bar_address to get it right. Tested-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin --- hw/pci/pci.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 00554a0..c3f

[Qemu-devel] [PATCH v7 03/26] qom: add pointer to int property helpers

2013-10-03 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 21 ++ qom/object.c | 60 +

[Qemu-devel] [PATCH v7 05/26] fw_cfg: interface to trigger callback on read

2013-10-03 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c | 33 - 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/include/hw/nvram/fw_cfg.h b/include/hw

[Qemu-devel] [PATCH v7 08/26] pcie_host: expose address format

2013-10-03 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 21 + hw/pci/pcie_host.c | 21 - 2 files changed,

[Qemu-devel] [PATCH v7 00/26] qemu: generate acpi tables for the guest

2013-10-03 Thread Michael S. Tsirkin
This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I think it's reasonable to merge it and then refactor as QOM properties cover more ground. In particular, merging this patchset blocks other projects so

[Qemu-devel] [PATCH v7 01/26] cleanup object.h: include error.h directly

2013-10-03 Thread Michael S. Tsirkin
From: Igor Mammedov qapi/error.h is simple enough to be included in qom/object.h direcly and prepares qom/object.h to use Error typedef. Signed-off-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PATCH v7 02/26] qom: cleanup struct Error references

2013-10-03 Thread Michael S. Tsirkin
now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 50 +---

Re: [Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Peter Maydell
On 3 October 2013 21:51, Will Newton wrote: > > This adds support for the VSEL floating point selection instruction > which was added in ARMv8. It is based on the previous patch[1] from > Mans Rullgard, but attempts to address the feedback given on that patch. > > [1] http://lists.nongnu.org/archi

[Qemu-devel] [PATCH v2] target-arm: Implement ARMv8 VSEL instruction.

2013-10-03 Thread Will Newton
This adds support for the VSEL floating point selection instruction which was added in ARMv8. It is based on the previous patch[1] from Mans Rullgard, but attempts to address the feedback given on that patch. [1] http://lists.nongnu.org/archive/html/qemu-devel/2013-06/msg03117.html Signed-off-by

[Qemu-devel] Emulation of Sp805 watch dog timer

2013-10-03 Thread VISWANADHULA BALAJI
Hi, I need to test the ARM's sp805 based watch dog timer from the qemu. But the model SP805 is not present in the qemu-1.5.93 source. Is there any possibility to add the SP805 based watch dog timer module to the Qemu. Please any one guide me. Thanks balaji

  1   2   >