[Qemu-devel] [Bug 1228285] [NEW] e1000 nic TCP performances

2013-09-20 Thread Vincent Autefage
Public bug reported: Hi, Here is the context : $ qemu -name A -m 1024 -net nic vlan=0,model=e1000 -net socket,vlan=0,listen=127.0.0.1:7000 $ qemu -name B -m 1024 -net nic vlan=0,model=e1000 -net socket,vlan=0,connect=127.0.0.1:7000 The bandwidth is really tiny : . Iperf3 reports about 30

Re: [Qemu-devel] [PATCH] linux-user: correct how SOL_SOCKET is converted from target to host and back

2013-09-20 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/274816/ From: Peter Maydell [peter.mayd...@linaro.org] Sent: Friday, September 13, 2013 7:36 PM To: Petar Jovanovic Cc: QEMU Developers; Riku Voipio; Petar Jovanovic; Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] li

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

2013-09-20 Thread Brad Smith
On 19/09/13 12:53 PM, Sebastian Herbszt wrote: Brad Smith wrote: On 20/01/13 1:12 PM, David Woodhouse wrote: The PCI Firmware Specification apparently requires that the PCI Data Structure be DWORD-aligned. The implementation in OVMF also requires this, so vgabios ROMs don't work there. With thi

Re: [Qemu-devel] [PATCH v4] ivshmem: allow the sharing of mmap'd files

2013-09-20 Thread Damien Millescamps
On 09/20/2013 10:45 PM, Benoît Canet wrote: > Le Friday 20 Sep 2013 à 20:34:47 (+0200), Damien Millescamps a écrit : >> This patch permits to share memory areas that do not specifically belong to >> /dev/shm. In such case, the file must be already present when launching qemu. >> A new parameter 'fi

Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-20 Thread Christoffer Dall
On Fri, Sep 20, 2013 at 11:09:47PM +0200, Paolo Bonzini wrote: > Il 20/09/2013 22:41, Christoffer Dall ha scritto: > >> > kvm_arm_gic_dist_readr > >> > kvm_arm_gic_dist_writer > >> > > >> > Why not get_reg/set_reg (I was quite surprised to see readr instead of > >> > reader :) and it took me a whi

Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-20 Thread Christoffer Dall
On Sat, Sep 21, 2013 at 06:22:23AM +0900, Peter Maydell wrote: > On 21 September 2013 04:50, Christoffer Dall > wrote: > > On Fri, Sep 06, 2013 at 04:13:32PM +0100, Peter Maydell wrote: > >> > /* these registers are mainly used for save/restore of KVM state */ > >> > uint8_t binary_poin

Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-20 Thread Paolo Bonzini
Il 20/09/2013 22:41, Christoffer Dall ha scritto: >> > kvm_arm_gic_dist_readr >> > kvm_arm_gic_dist_writer >> > >> > Why not get_reg/set_reg (I was quite surprised to see readr instead of >> > reader :) and it took me a while to understand the convention)? Or if >> > the name is too long, s/readr

Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-20 Thread Peter Maydell
On 21 September 2013 04:50, Christoffer Dall wrote: > On Fri, Sep 06, 2013 at 04:13:32PM +0100, Peter Maydell wrote: >> > /* these registers are mainly used for save/restore of KVM state */ >> > uint8_t binary_point[2][NCPU]; /* [0]: group 0, [1]: group 1 */ >> > +uint32_t active_pr

Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-20 Thread Christoffer Dall
On Fri, Sep 06, 2013 at 04:57:05PM +0200, Paolo Bonzini wrote: > Il 25/08/2013 17:47, Alexander Graf ha scritto: > > > > On 23.08.2013, at 21:10, Christoffer Dall wrote: > > > >> Save and restore the ARM KVM VGIC state from the kernel. We rely on > >> QEMU to marshal the GICState data structure

Re: [Qemu-devel] [PATCH v4] ivshmem: allow the sharing of mmap'd files

2013-09-20 Thread Benoît Canet
Le Friday 20 Sep 2013 à 20:34:47 (+0200), Damien Millescamps a écrit : > This patch permits to share memory areas that do not specifically belong to > /dev/shm. In such case, the file must be already present when launching qemu. > A new parameter 'file' has been added to specify the file to use. >

[Qemu-devel] [PATCH] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-20 Thread Benoît Canet
Some drivers will have driver specifics options but no filename. This new bool allow the block layer to treat them correctly. The first driver of this type will be the quorum driver. Signed-off-by: Benoit Canet --- block.c | 6 -- block/bochs.c | 1 + block/clo

Re: [Qemu-devel] [PATCH 03/17] blockdev: Introduce DriveInfo.enable_auto_del

2013-09-20 Thread Kevin Wolf
Am 20.09.2013 um 17:03 hat Eric Blake geschrieben: > On 09/20/2013 05:54 AM, Kevin Wolf wrote: > > BlockDriverStates shouldn't be affected by an unplugged guest device, > > except if created with the legacy -drive command line option or the > > drive_add HMP command. > > > > Make the automatic del

Re: [Qemu-devel] Merging the quorum block driver

2013-09-20 Thread Kevin Wolf
Am 20.09.2013 um 14:08 hat Benoît Canet geschrieben: > Le Thursday 19 Sep 2013 à 16:23:54 (+0200), Kevin Wolf a écrit : > > Am 19.09.2013 um 15:38 hat Benoît Canet geschrieben: > > > Le Thursday 19 Sep 2013 à 15:21:46 (+0200), Kevin Wolf a écrit : > > > > Am 19.09.2013 um 14:55 hat Benoît Canet ges

Re: [Qemu-devel] Qemu-KVM VETH

2013-09-20 Thread Tim Epkes
Agree in all points. Thanks for the information. I'll give the patch a try. Tim Sent from my iPhone On Sep 20, 2013, at 1:26 PM, Stefan Hajnoczi wrote: > On Fri, Sep 20, 2013 at 11:48:50AM -0400, Tim Epkes wrote: >> The problem aI face is that a bridge in the middle ( using taps) breaks >> L

[Qemu-devel] [PULL 06/17] MAINTAINERS: Add missing entry to filelist for TCI target

2013-09-20 Thread Michael Tokarev
From: Stefan Weil tci.c is also a maintained part of the TCI implementation. Signed-off-by: Stefan Weil Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d128ed0..4d634f2 100644

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2013-09-20 Thread Paolo Bonzini
Il 20/09/2013 19:58, Stefan Hajnoczi ha scritto: > The following changes since commit 6c2679fc19560699679200fb42ab4659bcbe7f79: > > Merge remote-tracking branch 'kiszka/queues/slirp' into staging (2013-09-17 > 10:01:24 -0500) > > are available in the git repository at: > > > git://github.c

Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-20 Thread Christoffer Dall
On Sun, Aug 25, 2013 at 04:47:59PM +0100, Alexander Graf wrote: > > On 23.08.2013, at 21:10, Christoffer Dall wrote: > > > Save and restore the ARM KVM VGIC state from the kernel. We rely on > > QEMU to marshal the GICState data structure and therefore simply > > synchronize the kernel state wit

Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-20 Thread Christoffer Dall
On Fri, Sep 06, 2013 at 04:13:32PM +0100, Peter Maydell wrote: > On 23 August 2013 21:10, Christoffer Dall wrote: > > Save and restore the ARM KVM VGIC state from the kernel. We rely on > > QEMU to marshal the GICState data structure and therefore simply > > synchronize the kernel state with the

[Qemu-devel] [PATCH] target-i386: Enable x2apic by default on more recent CPU models

2013-09-20 Thread Eduardo Habkost
This enables x2apic on the following CPU models: Conroe, Penryn, Nehalem, Westmere, Opteron_G[12345]. Normally we try to keep the CPU model definitions as close as the real CPUs as possible, but x2apic can be emulated by KVM without host CPU support for x2apic, and it improves performance by reduc

[Qemu-devel] [PULL 3/6] lsi: ignore write accesses to CTEST0 registers

2013-09-20 Thread Paolo Bonzini
From: Hervé Poussineau 53C895A datasheet says that this register is read/write, and that the value returned on read access is dependant of DMA FIFO state. However, nothing is said for written value. 53C810A datasheet gives more insight about this register: "This was a general purpose read/write

[Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-09-20 Thread Paolo Bonzini
From: Benoît Canet Some users running cpu intensive tasks checking the cache CPUID leaves at startup and making decisions based on the result reported that the guest was not reflecting the host CPUID leaves when -cpu host is used. This patch fix this. Signed-off-by: Benoît Canet [Rename new fi

[Qemu-devel] [PULL 15/17] kvm: Fix compiler warning (clang)

2013-09-20 Thread Michael Tokarev
From: Stefan Weil Report from clang analyzer: clock.c:42:15: warning: Value stored to 'cpu' during its initialization is never read Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/i386/kvm/clock.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386

[Qemu-devel] [PATCH v2 0/3] qemu-iotests with sample images, vhdx test, cleanup

2013-09-20 Thread Jeff Cody
Changes in v3: Patch 1: MANIFEST file dropped. Instead of bunzip2, use bzcat. Check error return of bzcat. Don't attempt to remove $SAMPLE_IMG_FILE if the variable is blank. Patch 2: MANIFEST file dropped. Patch 3: New patch. This adds some cleanup in the format of quotatio

Re: [Qemu-devel] [PATCH 2/2] rdma: simplify qemu_rdma_register_and_get_keys()

2013-09-20 Thread Isaku Yamahata
On Wed, Sep 18, 2013 at 11:01:16AM -0400, Michael R. Hines wrote: > The value of chunk_end changes based on whether or not the value of > block->is_ram_block is true of false. When is block->is_ram_block set to false? Looking at __qemu_rdma_add_block() and qemu_rdma_init_ram_blocks(), is_ram_blo

[Qemu-devel] [PULL 09/17] trace-events: Clean up with scripts/cleanup-trace-events.pl again

2013-09-20 Thread Michael Tokarev
From: Markus Armbruster Event qxl_render_blit_guest_primary_initialized is unused since commit c58c7b9, drop it. Commit 42e5b4c moved hw/ppc/xics.c to hw/intc/xics.c without updating the comment in trace-events. "scripts/cleanup-trace-events.pl trace-events | diff trace-events" is now clean aga

[Qemu-devel] [PULL 14/17] tcg-sparc: Fix parenthesis warning

2013-09-20 Thread Michael Tokarev
From: Richard Henderson error: suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses] Signed-off-by: Richard Henderson Signed-off-by: Michael Tokarev --- tcg/sparc/tcg-target.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/sparc/tcg-target.

Re: [Qemu-devel] [PATCH V4 0/3] qemu-iotests: add test for fd passing via SCM rights

2013-09-20 Thread Stefan Hajnoczi
On Mon, Sep 09, 2013 at 01:57:20PM +0200, Stefan Hajnoczi wrote: > On Fri, Sep 06, 2013 at 11:24:31AM +0800, Wenchao Xia wrote: > > tests/qemu-iotests/socket_scm_helper.c | 135 > > After a clean QEMU build ./check -raw fails now. This can be resolved by manuall

[Qemu-devel] [PULL 07/17] *-user: Improve documentation for lock_user function

2013-09-20 Thread Michael Tokarev
From: Stefan Weil Add a missing "function" and replace "and" by "any". BSD and Linux use the same documentation here, so fix both. Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- bsd-user/qemu.h |4 ++-- linux-user/qemu.h |4 ++-- 2 files ch

[Qemu-devel] [PULL 13/17] Makefile: Remove some more files when cleaning

2013-09-20 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- Makefile |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 362fe3e..f6da5fe 100644 --- a/Makefile +++ b/Makefile @@ -236,7 +236,8 @@ clean: find . -name '*.

[Qemu-devel] [PULL 1/1] kvm: fix traces to use %x instead of %d

2013-09-20 Thread Stefan Hajnoczi
From: Alexey Kardashevskiy KVM request types are normally defined using hex constants but QEMU traces print decimal values instead, which is not very convenient. This changes the request type format from %d to %x. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Andreas Färber Reviewed-by: Pa

[Qemu-devel] [PULL 03/17] docs: Fix IO port number for CPU present bitmap.

2013-09-20 Thread Michael Tokarev
From: Anthony PERARD Signed-off-by: Anthony PERARD Reviewd-By: Igor Mammedov Signed-off-by: Michael Tokarev --- docs/specs/acpi_cpu_hotplug.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt index 5dec0c

[Qemu-devel] [PULL 17/17] tests/.gitignore: ignore test-throttle

2013-09-20 Thread Michael Tokarev
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Benoit Canet Signed-off-by: Michael Tokarev --- tests/.gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index d11cc22..ae5280e 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -5,6

[Qemu-devel] [PULL 02/13] cpu: Move cpu state syncs up into cpu_dump_state()

2013-09-20 Thread Paolo Bonzini
From: James Hogan The x86 and ppc targets call cpu_synchronize_state() from their *_cpu_dump_state() callbacks to ensure that up to date state is dumped when KVM is enabled (for example when a KVM internal error occurs). Move this call up into the generic cpu_dump_state() function so that other

[Qemu-devel] [PATCH v2 2/3] block: qemu-iotests for vhdx, read sample dynamic image

2013-09-20 Thread Jeff Cody
This adds the VHDX format to the qemu-iotests format, and adds a read test. The test reads from an existing sample image, that was created with Hyper-V under Windwos Server 2012. The image file is a 1GB dynamic image, with 32MB blocks. The pattern 0xa5 exists from 0MB-33MB (past a block size bou

[Qemu-devel] [PATCH v3 2/2] migration: ram_handle_compressed

2013-09-20 Thread Isaku Yamahata
ram_handle_compressed() should be aware of size > TARGET_PAGE_SIZE. migration-rdma can call it with larger size. Signed-off-by: Isaku Yamahata --- Changes v2 -> v3: - use is_zero_range() changes v1 -> v2: - don't loop --- arch_init.c | 11 ++- 1 file changed, 6 insertions(+), 5 deleti

Re: [Qemu-devel] Hibernate and qemu-nbd

2013-09-20 Thread Mark Trumpold
>-Original Message- >From: Stefan Hajnoczi [mailto:stefa...@gmail.com] >Sent: Thursday, September 19, 2013 10:14 PM >To: 'Mark Trumpold' >Cc: 'qemu-devel', 'Paul Clements', nbd-gene...@lists.sourceforge.net, >bonz...@stefanha-thinkpad.redhat.com, w...@uter.be >Subject: Re: [Qemu-devel] Hi

[Qemu-devel] [PATCH v2 1/3] block: qemu-iotests - add basic ability to use binary sample images

2013-09-20 Thread Jeff Cody
For image formats that are not "QEMU native", but supported for compatibility, it is useful to verify that an image created with the 'gold standard' native tool can be read / written to successfully by QEMU. In addition to testing non-native images, this could also be useful to test against image

[Qemu-devel] [PULL 5/6] lsi: add 53C810 variant

2013-09-20 Thread Paolo Bonzini
From: Hervé Poussineau Currently, treat it exactly as a 53C895A. 53C895A is a 53C810 with more capabilities, so this should work. However, this lets us test different code paths on Linux, which don't use lastest features if it detect a 810, or on some OSes which only support 810 and not 895A (li

[Qemu-devel] [PULL 06/13] kvmvapic: Catch invalid ROM size

2013-09-20 Thread Paolo Bonzini
From: Jan Kiszka If not caught early, a zero-length ROM will cause a NULL-pointer access later on in patch_hypercalls when allocating a zero-length ROM copy and trying to read from it. CC: qemu-sta...@nongnu.org Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- hw/i386/kvmvapic.c | 1

[Qemu-devel] Stopping the VM due to an illegal instruction [was: QOM CPUState, part 13: Emptying CPU_COMMON]

2013-09-20 Thread Michael Walle
Hi, Am 2013-09-17 20:46, schrieb Richard Henderson: On 09/17/2013 10:46 AM, Michael Walle wrote: Am Montag, 9. September 2013, 18:47:21 schrieb Peter Maydell: For lm32 you might consider raising EXCP_BREAKPOINT; then if you have a gdb connected to the debug stub the developer will get dropped

Re: [Qemu-devel] [Qemu-trivial] [PATCH] kvm: Fix compiler warning (clang)

2013-09-20 Thread Michael Tokarev
18.09.2013 00:39, Stefan Weil wrote: Report from clang analyzer: clock.c:42:15: warning: Value stored to 'cpu' during its initialization is never read Thanks, applied to the trivial patches queue. /mjt

[Qemu-devel] [PULL 04/17] *-user: Fix typo in comment (ulocking -> unlocking)

2013-09-20 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- bsd-user/qemu.h |2 +- linux-user/qemu.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 325f564..1f8ec6e 100644 -

Re: [Qemu-devel] [PATCH 2/2] rdma: simplify qemu_rdma_register_and_get_keys()

2013-09-20 Thread Michael R. Hines
On 09/20/2013 12:59 PM, Isaku Yamahata wrote: On Wed, Sep 18, 2013 at 11:01:16AM -0400, Michael R. Hines wrote: The value of chunk_end changes based on whether or not the value of block->is_ram_block is true of false. When is block->is_ram_block set to false? Looking at __qemu_rdma_add_block()

[Qemu-devel] [PULL 08/17] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)

2013-09-20 Thread Michael Tokarev
From: Stefan Weil Debian busybox-static for alpha has a load address of 0x00012000 which is mapped to 0x2000 for 32 bit hosts. qemu-alpha uses the TCG opcodes qemu_ld32, qemu_ld64, qemu_st32 and qemu_st64 which all raise the assertion (taddr == host_addr). Remove all asserti

[Qemu-devel] [PATCH v2 2/2] virtio-blk: do not relay a previous driver's WCE configuration to the current

2013-09-20 Thread Paolo Bonzini
The following sequence happens: - the SeaBIOS virtio-blk driver does not support the WCE feature, which causes QEMU to disable writeback caching - the Linux virtio-blk driver resets the device, finds WCE is available but writeback caching is disabled; tells block layer to not send cache flush comm

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] ivshmem: allow the sharing of hugepages

2013-09-20 Thread Damien Millescamps
On 09/20/2013 06:49 PM, Michael Tokarev wrote: > Can you please send a v4 with the above changes? Hopefully you agree > with them. Overall, I like this new version too. Ok, I'll do that ASAP. I'll try to find a better wording for the error messages. At first I tried to modify the code as little

[Qemu-devel] [PULL 01/13] exec: always use MADV_DONTFORK

2013-09-20 Thread Paolo Bonzini
From: Andrea Arcangeli MADV_DONTFORK prevents fork to fail with -ENOMEM if the default overcommit heuristics decides there's too much anonymous virtual memory allocated. If the KVM secondary MMU is synchronized with MMU notifiers or not, doesn't make a difference in that regard. Secondly it's al

[Qemu-devel] [PULL 05/17] translate-all: Fix formatting of dump output

2013-09-20 Thread Michael Tokarev
From: Stefan Weil The page dump writes a table with 3 abi_ulong values in each row. These values take 8 or 16 characters (depending on sizeof abi_ulong). Fix the table headings to be aligned with the table columns. old: startend size prot 00012000-00012021e000 0

[Qemu-devel] [PULL 02/17] q35: Fix typo in constant DEFUALT -> DEFAULT.

2013-09-20 Thread Michael Tokarev
From: "Richard W.M. Jones" Signed-off-by: Richard W.M. Jones Signed-off-by: Michael Tokarev --- hw/pci-host/q35.c |2 +- include/hw/pci-host/q35.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 5473504..0cb652d

[Qemu-devel] [PULL 01/17] configure: Undefine _FORTIFY_SOURCE prior using it

2013-09-20 Thread Michael Tokarev
From: Michal Privoznik Currently, we are enforcing the _FORTIFY_SOURCE=2 without any previous detection if the macro has been already defined, e.g. by environment, or is just enabled by compiler by default. Signed-off-by: Michal Privoznik Signed-off-by: Jan Vesely Reviewed-by: Peter Maydell S

[Qemu-devel] [PULL 11/11] virtio-blk: do not relay a previous driver's WCE configuration to the current

2013-09-20 Thread Stefan Hajnoczi
From: Paolo Bonzini The following sequence happens: - the SeaBIOS virtio-blk driver does not support the WCE feature, which causes QEMU to disable writeback caching - the Linux virtio-blk driver resets the device, finds WCE is available but writeback caching is disabled; tells block layer to not

[Qemu-devel] [PULL 05/11] qemu-timer: do not take the lock in timer_pending

2013-09-20 Thread Stefan Hajnoczi
From: Paolo Bonzini We can deduce the result from expire_time, by making it always -1 if the timer is not in the active_timers list. We need to check against negative times passed to timer_mod_ns; clamping them to zero is not a problem because the only clock that has a zero value at VM startup i

[Qemu-devel] [PULL 09/11] block: don't lose data from last incomplete sector

2013-09-20 Thread Stefan Hajnoczi
From: Fam Zheng To read the last sector that is not aligned to sector boundary, current code for growable backends, since commit 893a8f6 "block: Produce zeros when protocols reading beyond end of file", drops the data and directly returns zeroes. That is incorrect. Signed-off-by: Fam Zheng Sign

[Qemu-devel] [PULL 00/17] Trivial patches for 2013-09-20

2013-09-20 Thread Michael Tokarev
Here is another trivial-patches pull request, which includes patches from previous week (with fixes for build failures -- one patch fixed and one removed) plus a few more patches accumulated during this week. Please pull. Thanks, /mjt The following changes since commit 6c2679fc19560699679200fb4

[Qemu-devel] [PULL 07/11] coroutine: fix /perf/nesting coroutine benchmark

2013-09-20 Thread Stefan Hajnoczi
From: Gabriel Kerneis The /perf/nesting benchmark is broken because the counters are not reset after each iteration. Therefore, nesting is done only on the first iteration, and skipped on every other. This patch fixes the issue, and reduces the number of iterations to make it possible to run the

[Qemu-devel] [PATCH v4] ivshmem: allow the sharing of mmap'd files

2013-09-20 Thread Damien Millescamps
This patch permits to share memory areas that do not specifically belong to /dev/shm. In such case, the file must be already present when launching qemu. A new parameter 'file' has been added to specify the file to use. A use case for this patch is sharing huge pages available through a hugetlbfs

[Qemu-devel] [PULL 2/2] e1000: NetClientInfo.receive_iov implemented

2013-09-20 Thread Stefan Hajnoczi
From: Vincenzo Maffione This patch implements the NetClientInfo.receive_iov method for the e1000 device emulation. In this way a network backend that uses qemu_sendv_packet() can deliver the fragmented packet without requiring an additional copy in the frontend/backend network code (nc_sendv_comp

[Qemu-devel] [PULL 16/17] exec: Fix broken build for MinGW (regression)

2013-09-20 Thread Michael Tokarev
From: Stefan Weil Commit 3435f39513a104294b5e3bbf3612047028d25cfc reduced the ifdeffery with this result for MinGW: exec.c: In function ‘qemu_ram_free’: exec.c:1239:17: warning: implicit declaration of function ‘munmap’ [-Wimplicit-function-declaration] exec.c:1239:17: warning: nested extern d

[Qemu-devel] [PULL 0/1] Tracing patches

2013-09-20 Thread Stefan Hajnoczi
The following changes since commit 6c2679fc19560699679200fb42ab4659bcbe7f79: Merge remote-tracking branch 'kiszka/queues/slirp' into staging (2013-09-17 10:01:24 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git tracing for you to fetch changes up to cbf5b9

Re: [Qemu-devel] [PATCH 0/2] Serious bugs in the handling of writeback caching

2013-09-20 Thread Stefan Hajnoczi
On Thu, Sep 19, 2013 at 06:48:52PM +0200, Paolo Bonzini wrote: > The first bug is simply that in 1.6.0 the default was changed by mistake > to cache=unsafe. This affects all block drivers. It is fixed in the > first patch. > > The second is that Linux guests that support the CONFIG_WCE option we

[Qemu-devel] [PULL 06/11] coroutine: add qemu_coroutine_yield benchmark

2013-09-20 Thread Stefan Hajnoczi
From: Gabriel Kerneis Current coroutine performance benchmarks test only coroutine creation, either directly or in a nested way. This patch adds a benchmark to evaluate the performance of qemu_coroutine_yield. Signed-off-by: Gabriel Kerneis Signed-off-by: Stefan Hajnoczi --- tests/test-corout

[Qemu-devel] [PULL 1/2] pcnet-pci: mark I/O and MMIO as LITTLE_ENDIAN

2013-09-20 Thread Stefan Hajnoczi
From: Aurelien Jarno Now that the memory subsystem is propagating the endianness correctly, the pcnet-pci device should have its I/O ports and MMIO memory marked as LITTLE_ENDIAN, as PCI devices are little endian. This makes the pcnet-pci NIC to work again on big endian MIPS Malta (default NIC).

[Qemu-devel] [PULL 0/2] Net patches

2013-09-20 Thread Stefan Hajnoczi
The following changes since commit 6c2679fc19560699679200fb42ab4659bcbe7f79: Merge remote-tracking branch 'kiszka/queues/slirp' into staging (2013-09-17 10:01:24 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch changes up to 97410dde60

[Qemu-devel] [PULL 03/11] qemu-timer: drop outdated signal safety comments

2013-09-20 Thread Stefan Hajnoczi
host_alarm_handler() is invoked from the signal processing thread (currently the iothread). Previously we did processing in a real signal handler with signalfd and therefore needed signal-safe timer code. Today host_alarm_handler() just marks the alarm timer as expired/pending and notifies the ma

Re: [Qemu-devel] Qemu-KVM VETH

2013-09-20 Thread Stefan Hajnoczi
On Fri, Sep 20, 2013 at 11:48:50AM -0400, Tim Epkes wrote: > The problem aI face is that a bridge in the middle ( using taps) breaks > LLDP ( L2 discovery protocol) and should break ISIS as well. Sockets > aren't bad, but if for some reason I take the listener VM down and bring > back up, then I h

[Qemu-devel] [PULL 12/17] target-i386: Fix segment cache dump

2013-09-20 Thread Michael Tokarev
From: Tobias Markus When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default operation size bit (D/B bit) is not set for Long Mode Data Segments since there are only Data Segments in Long Mode and no explicit 16/32/64-bit Descriptors. This patch fixes this by checking the Long Mode

Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec: Fix broken build for MinGW (regression)

2013-09-20 Thread Michael Tokarev
18.09.2013 09:48, Stefan Weil wrote: Commit 3435f39513a104294b5e3bbf3612047028d25cfc reduced the ifdeffery with this result for MinGW: exec.c: In function ‘qemu_ram_free’: exec.c:1239:17: warning: implicit declaration of function ‘munmap’ [-Wimplicit-function-declaration] exec.c:1239:17: warni

[Qemu-devel] [PULL 10/11] blockdev: do not default cache.no-flush to true

2013-09-20 Thread Stefan Hajnoczi
From: Paolo Bonzini That's why all my VMs were so fast lately. :) This changed in 1.6.0 by mistake in patch 29c4e2b (blockdev: Split up 'cache' option, 2013-07-18). Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- blockdev.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 11/17] iov: avoid "orig_len may be used unitialized" warning

2013-09-20 Thread Michael Tokarev
Signed-off-by: Wenchao Xia Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- util/iov.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/util/iov.c b/util/iov.c index f705586..bb46c04 100644 --- a/util/iov.c +++ b/util/iov.c @@ -181,13 +181,11 @@ ss

[Qemu-devel] [PULL 08/11] qcow2: Correct snapshots size for overlap check

2013-09-20 Thread Stefan Hajnoczi
From: Max Reitz Using s->snapshots_size instead of snapshots_size for the metadata overlap check in qcow2_write_snapshots leads to the detection of an overlap with the main qcow2 image header when deleting the last snapshot, since s->snapshots_size has not yet been updated and is therefore non-ze

[Qemu-devel] [PULL 04/11] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-20 Thread Stefan Hajnoczi
Introduce QEMUTimerList->active_timers_lock to protect the linked list of active timers. This allows qemu_timer_mod_ns() to be called from any thread. Note that vm_clock is not thread-safe and its use of qemu_clock_has_timers() works fine today but is also not thread-safe. The purpose of this pa

[Qemu-devel] [PULL 02/11] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-09-20 Thread Stefan Hajnoczi
Print a warning when opening a file O_DIRECT fails with EINVAL. This saves users a lot of time trying to figure out the EINVAL error, which is typical when attempting to open a file O_DIRECT on Linux tmpfs. Reported-by: Deepak C Shetty Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake ---

[Qemu-devel] [PULL 00/11] Block patches

2013-09-20 Thread Stefan Hajnoczi
The following changes since commit 6c2679fc19560699679200fb42ab4659bcbe7f79: Merge remote-tracking branch 'kiszka/queues/slirp' into staging (2013-09-17 10:01:24 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch changes up to ef5bc962

[Qemu-devel] [PULL 03/13] kvm: warn if num cpus is greater than num recommended

2013-09-20 Thread Paolo Bonzini
From: Andrew Jones The comment in kvm_max_vcpus() states that it's using the recommended procedure from the kernel API documentation to get the max number of vcpus that kvm supports. It is, but by always returning the maximum number supported. The maximum number should only be used for developmen

[Qemu-devel] [PULL 01/11] libcacard: link against qemu-error.o for error_report()

2013-09-20 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- libcacard/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 47827a0..4d15da4 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -4,7 +4,8 @@ TOOLS += vscclient$(EXESUF) # obje

[Qemu-devel] [PULL build-fix 0/6] SCSI patches for 2013-09-20

2013-09-20 Thread Paolo Bonzini
Anthony, The following changes since commit f4ff3b7ba1bcb77d5b5cdbd6e695df793761170b: spapr-vscsi: Report error on unsupported MAD requests (2013-09-12 13:15:54 +0200) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to f35c93

[Qemu-devel] [PULL 10/17] vscclient: remove unnecessary use of uninitialized variable

2013-09-20 Thread Michael Tokarev
Signed-off-by: Wenchao Xia Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- libcacard/vscclient.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index 5180d29..a3cb776 100644 --- a/libcacard/vscclient.c +++ b

Re: [Qemu-devel] [PATCH] Python-lang gdb script to extract x86_64 guest vmcore from qemu coredump

2013-09-20 Thread Laszlo Ersek
On 09/12/13 21:46, Laszlo Ersek wrote: > When qemu dies unexpectedly, for example in response to an explicit > abort() call, or (more importantly) when an external signal is delivered > to it that results in a coredump, sometimes it is useful to extract the > guest vmcore from the qemu process' mem

[Qemu-devel] [PULL 10/13] linux-headers: update to 3.11

2013-09-20 Thread Paolo Bonzini
From: Alexey Kardashevskiy Signed-off-by: Alexey Kardashevskiy Signed-off-by: Paolo Bonzini --- linux-headers/asm-arm64/kvm.h | 168 linux-headers/asm-arm64/kvm_para.h | 1 + linux-headers/asm-mips/kvm.h| 81 + linux-header

Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command

2013-09-20 Thread Eric Blake
On 09/20/2013 05:54 AM, Kevin Wolf wrote: > For examples see the changes to qmp-commands.hx. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 57 > qapi-schema.json | 270 > +++ > qmp-commands.hx | 59 > 3

[Qemu-devel] [PULL 04/13] fix steal time MSR vmsd callback to proper opaque type

2013-09-20 Thread Paolo Bonzini
From: Marcelo Tosatti Convert steal time MSR vmsd callback pointer to proper X86CPU type. Signed-off-by: Marcelo Tosatti Signed-off-by: Paolo Bonzini --- target-i386/machine.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/machine.c b/target-i386/machine

[Qemu-devel] [PULL 05/13] kvm irqfd: support direct msimessage to irq translation

2013-09-20 Thread Paolo Bonzini
From: Alexey Kardashevskiy On PPC64 systems MSI Messages are translated to system IRQ in a PCI host bridge. This is already supported for emulated MSI/MSIX but not for irqfd where the current QEMU allocates IRQ numbers from irqchip and maps MSIMessages to IRQ in the host kernel. This adds a new

[Qemu-devel] [PULL 00/13] KVM patches for 2013-09-20

2013-09-20 Thread Paolo Bonzini
Anthony, The following changes since commit 2d1fe1873a984d1c2c89ffa3d12949cafc718551: Merge remote-tracking branch 'pmaydell/tags/pull-target-arm-20130910' into staging (2013-09-11 14:46:52 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git u

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tests/.gitignore: ignore test-throttle

2013-09-20 Thread Michael Tokarev
Thanks, applied to the trivial patches queue. /mjt

[Qemu-devel] [PULL 13/13] target-i386: add feature kvm_pv_unhalt

2013-09-20 Thread Paolo Bonzini
From: Andrew Jones I don't know yet if want this feature on by default, so for now I'm just adding support for "-cpu ...,+kvm_pv_unhalt". Signed-off-by: Andrew Jones Reviewed-by: Eduardo Habkost Reviewed-by: Andreas Färber Signed-off-by: Paolo Bonzini --- target-i386/cpu.c | 2 +- 1 file ch

Re: [Qemu-devel] [PATCH 03/17] blockdev: Introduce DriveInfo.enable_auto_del

2013-09-20 Thread Eric Blake
On 09/20/2013 09:12 AM, Kevin Wolf wrote: > Am 20.09.2013 um 17:03 hat Eric Blake geschrieben: >> On 09/20/2013 05:54 AM, Kevin Wolf wrote: >>> BlockDriverStates shouldn't be affected by an unplugged guest device, >>> except if created with the legacy -drive command line option or the >>> drive_add

[Qemu-devel] [PULL 08/13] kvmvapic: Clear also physical ROM address when entering INACTIVE state

2013-09-20 Thread Paolo Bonzini
From: Jan Kiszka To avoid misinterpreting INACTIVE after migration as old qemu-kvm's STANDBY, also clear rom_state_paddr when going back to this state. CC: qemu-sta...@nongnu.org Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini --- hw/i386/kvmvapic.c | 2 ++ 1 file changed, 2 insertions

[Qemu-devel] [PULL 09/13] kvm: fix traces to use %x instead of %d

2013-09-20 Thread Paolo Bonzini
From: Alexey Kardashevskiy KVM request types are normally defined using hex constants but QEMU traces print decimal values instead, which is not very convenient. This changes the request type format from %d to %x. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Andreas Färber Reviewed-by: Pa

Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command

2013-09-20 Thread Kevin Wolf
Am 20.09.2013 um 17:22 hat Eric Blake geschrieben: > On 09/20/2013 05:54 AM, Kevin Wolf wrote: > > For examples see the changes to qmp-commands.hx. > > > > Signed-off-by: Kevin Wolf > > --- > > blockdev.c | 57 > > qapi-schema.json | 270 > > +

[Qemu-devel] [PULL 12/13] linux-headers: update to 3.12-rc1

2013-09-20 Thread Paolo Bonzini
From: Andrew Jones Signed-off-by: Andrew Jones Signed-off-by: Paolo Bonzini --- linux-headers/asm-x86/kvm_para.h | 1 + linux-headers/linux/kvm.h| 1 + linux-headers/linux/kvm_para.h | 1 + linux-headers/linux/vfio.h | 38 ++ 4 files chang

[Qemu-devel] [PULL 07/13] kvmvapic: Enter inactive state on hardware reset

2013-09-20 Thread Paolo Bonzini
From: Jan Kiszka ROM layout may change after reset of devices are hotplugged, so we have to pick up the physical address again when the ROM is initialized. This is best achieved by resetting the state to INACTIVE. CC: qemu-sta...@nongnu.org Signed-off-by: Jan Kiszka Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 2/2] vmdk: fix cluster size check for flat extents

2013-09-20 Thread Paolo Bonzini
Il 19/09/2013 13:31, Stefan Hajnoczi ha scritto: >> > We use the extent size as cluster size for flat extents (where no L1/L2 >> > table is allocated so it's safe). > Why is the extent size passed as the cluster size parameter? I think it's so that the flat extent doesn't take up too many cache en

[Qemu-devel] [PATCH v3 1/2] arch_init: make is_zero_page accept size

2013-09-20 Thread Isaku Yamahata
Later is_zero_page will be used for non TARGET_PAGE_SIZE range. And rename it to is_zero_range as it isn't page size any more. Signed-off-by: Isaku Yamahata --- arch_init.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/arch_init.c b/arch_init.c index e47e139..83

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] ivshmem: allow the sharing of hugepages

2013-09-20 Thread Michael Tokarev
16.09.2013 17:46, Damien Millescamps wrote: This patch permits to share memory areas that do not specifically belong to /dev/shm. In such case, the file must be already present when launching qemu. A new parameter 'file' has been added to specify the file to use. A use case for this patch is sha

[Qemu-devel] [PULL 2/6] lsi: check ssid versus sdid only if ssid is valid

2013-09-20 Thread Paolo Bonzini
From: Hervé Poussineau This prevents some (invalid) error messages on console. Signed-off-by: Hervé Poussineau Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 4cc0c6a.

Re: [Qemu-devel] [PATCH 5/8] [PATCH RFC v3] s390-qemu: cpu hotplug - ipi_states enhancements

2013-09-20 Thread Michael Mueller
On Thu, 19 Sep 2013 16:19:46 -0400 "Jason J. Herne" wrote: > On 09/05/2013 08:01 AM, Andreas Färber wrote: > > Am 01.08.2013 16:12, schrieb Jason J. Herne: > >> From: "Jason J. Herne" > >> > ... > > > > This is what got us into the link<> discussion last time. If we do > > > > for (i = 0; i < AR

[Qemu-devel] [PULL 4/6] lsi: remove todo

2013-09-20 Thread Paolo Bonzini
From: Hervé Poussineau LSI emulation has been tested with Linux on PPC platform. Signed-off-by: Hervé Poussineau Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 89d934b..87c 10064

[Qemu-devel] [PULL 1/6] lsi: use constant name instead of its value

2013-09-20 Thread Paolo Bonzini
From: Hervé Poussineau Signed-off-by: Hervé Poussineau Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 5affc82..4cc0c6a 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scs

[Qemu-devel] [PULL 6/6] block/iscsi: Drop iscsi_co_get_block_status for older versions of libiscsi

2013-09-20 Thread Paolo Bonzini
From: Stefan Weil Debian wheezy includes libiscsi-dev 1.4.0 which does not provide SCSI_PROVISIONING_TYPE_DEALLOCATED. Drop iscsi_co_get_block_status in this case to allow compilation without errors. Signed-off-by: Stefan Weil Signed-off-by: Paolo Bonzini --- block/iscsi.c | 6 ++ 1 file

Re: [Qemu-devel] Qemu-KVM VETH

2013-09-20 Thread Tim Epkes
Stefan, The problem aI face is that a bridge in the middle ( using taps) breaks LLDP ( L2 discovery protocol) and should break ISIS as well. Sockets aren't bad, but if for some reason I take the listener VM down and bring back up, then I have to bring down all connector VMs, which chains on itsel

  1   2   >