Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-18 Thread Paolo Bonzini
Il 19/07/2013 08:38, Alex Bligh ha scritto: > > However, I still don't quite see how the poll in the mainloop is > meant to exit when a timer expires. There's now no qemu_notify_event, > and no SIGALRM, and the timeout will still be infinite (unless I > calculate the timeout as the minimum across

Re: [Qemu-devel] [PATCH v2 10/17] block: define get_block_status return value

2013-07-18 Thread Peter Lieven
On 16.07.2013 18:29, Paolo Bonzini wrote: Define the return value of get_block_status. Bits 0, 1, 2 and 9-62 are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-7 are left for future extensions. The return code is compatible with the old is_allocated API: returning just 0 or 1 (aka

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-18 Thread Alex Bligh
Stefan, --On 19 July 2013 09:58:50 +0800 Stefan Hajnoczi wrote: Options: a) restore alarm timers (at least for the time being). Make all alarm timers do qemu_notify_event. However, only run the AioContext clock's timers within aio_poll. This is the least intrusive change. b

Re: [Qemu-devel] [PATCH v2 10/17] block: define get_block_status return value

2013-07-18 Thread Peter Lieven
On 16.07.2013 18:29, Paolo Bonzini wrote: Define the return value of get_block_status. Bits 0, 1, 2 and 9-62 are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-7 are left for future extensions. The return code is compatible with the old is_allocated API: returning just 0 or 1 (aka

Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd

2013-07-18 Thread Wenchao Xia
于 2013-7-17 22:23, Eric Blake 写道: On 07/17/2013 08:03 AM, Wenchao Xia wrote: This series allow user to read internal snapshot's contents without qemu-img convert. Another purpose is that, when qemu is online and have taken an internal snapshot, let user invoke qemu-nbd to do any thing on it exce

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-18 Thread Paolo Bonzini
Il 19/07/2013 03:58, Stefan Hajnoczi ha scritto: >> Options: >> >> a) restore alarm timers (at least for the time being). Make all >> alarm timers do qemu_notify_event. However, only run the AioContext >> clock's timers within aio_poll. This is the least intrusive change. >> >> b) c

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Peter Lieven
On 19.07.2013 07:58, Paolo Bonzini wrote: Il 18/07/2013 21:28, Peter Lieven ha scritto: thanks for the details. I think to have optimal performance and best change for unmapping in qemu-img convert it might be best to export the OPTIMAL UNMAP GRANULARITY Agreed about this. as well as the writ

[Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-18 Thread Pawit Pornkitprasan
The qmp_migrate method uses the 'blk' and 'inc' parameter without checking if they're valid or not (they may be uninitialized if command is received via QMP) Signed-off-by: Pawit Pornkitprasan --- migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration.c b/m

[Qemu-devel] [PATCH] migration: send total time in QMP at "completed" stage

2013-07-18 Thread Pawit Pornkitprasan
The "completed" stage sets total_time but not has_total_time and thus it is not sent via QMP reply (but sent via HMP nevertheless) Signed-off-by: Pawit Pornkitprasan --- migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration.c b/migration.c index 9f5a423..4c16f2e 100644 --- a/

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 21:28, Peter Lieven ha scritto: > thanks for the details. I think to have optimal performance and best > change for unmapping in qemu-img convert > it might be best to export the OPTIMAL UNMAP GRANULARITY Agreed about this. > as well as the write_zeroes_w_discard capability via the

Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand

2013-07-18 Thread Paolo Bonzini
Il 19/07/2013 06:48, Stefan Hajnoczi ha scritto: > On Thu, Jul 18, 2013 at 02:04:31PM -0600, Eric Blake wrote: >> On 07/03/2013 08:34 AM, Paolo Bonzini wrote: >>> This command dumps the metadata of an entire chain, in either tabular or >>> JSON >>> format. >>> >>> Signed-off-by: Paolo Bonzini >>>

Re: [Qemu-devel] [PATCH V5 0/8] add internal snapshot support at block device level

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 18, 2013 at 02:34:52PM +0200, Kevin Wolf wrote: > Am 11.07.2013 um 07:46 hat Wenchao Xia geschrieben: > > This series brings internal snapshot support at block devices level, now > > we > > have two three methods to do block snapshot lively: 1) backing chain, > > 2) internal one and

Re: [Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update callers

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 18, 2013 at 11:21:42PM +0200, Charlie Shepherd wrote: > This patch makes bdrv_flush a synchronous function and updates any callers > from > a coroutine context to use bdrv_co_flush instead. > > The motivation for this patch comes from the GSoC Continuation-Passing C > project. When co

Re: [Qemu-devel] [PATCH 3/4] block/raw: add .bdrv_get_info

2013-07-18 Thread Stefan Hajnoczi
On Mon, Jul 15, 2013 at 12:49:34PM +0200, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/raw.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/block/raw.c b/block/raw.c > index 8c81de9..f1682d4 100644 > --- a/block/raw.c > +++ b/block/raw.c > @@ -121,6 +121,11

Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Stefan Hajnoczi
On Mon, Jul 15, 2013 at 12:49:31PM +0200, Peter Lieven wrote: > this adds the proposed solution to add a generic mechanism to zeroize > a target in qemu-img if it has discard_zeroes but has_zero_init is 0. > > Peter Lieven (4): > block: add discard_zeroes and max_unmap to BlockDriverInfo > isc

Re: [Qemu-devel] Buildbots out of disk space

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 18, 2013 at 12:45:42PM +0200, Andreas Färber wrote: > Am 15.07.2013 08:43, schrieb Stefan Hajnoczi: > > On Mon, Jul 15, 2013 at 07:31:05AM +0200, Christian Berendt wrote: > >> Think we should clean up the registered build slaves. Here's a list > >> of offline slaves. Can they be removed

Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 18, 2013 at 02:04:31PM -0600, Eric Blake wrote: > On 07/03/2013 08:34 AM, Paolo Bonzini wrote: > > This command dumps the metadata of an entire chain, in either tabular or > > JSON > > format. > > > > Signed-off-by: Paolo Bonzini > > --- > > qemu-img-cmds.hx | 6 ++ > > qemu-img.c

Re: [Qemu-devel] [PATCH v2 00/17] Add qemu-img subcommand to dump file metadata

2013-07-18 Thread Stefan Hajnoczi
On Tue, Jul 16, 2013 at 06:29:11PM +0200, Paolo Bonzini wrote: > This series adds a subcommand to "map" that can dump file metadata. > Metadata that is dumped includes: > > - whether blocks are allocated in bs->file and, if so, where > > - whether blocks are zero > > - whether data is read from

Re: [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 18, 2013 at 10:37:32AM +0200, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan

Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 18, 2013 at 02:52:19PM +0200, Kevin Wolf wrote: > Even if the VM is already stopped, we cannot assume that all data has > already been successfully flushed to disk. The flush during the previous > vm_stop() could have failed. > > Run bdrv_flush_all() unconditionally so that we get an e

Re: [Qemu-devel] [PATCH v2 repost 8/9] i386: generate pc guest info

2013-07-18 Thread Hu Tao
<...> > +void ich9_lpc_set_guest_info(PcGuestInfo *guest_info) > +{ > +guest_info->sci_int = 9; > +guest_info->acpi_enable_cmd = ICH9_APM_ACPI_ENABLE; > +guest_info->acpi_disable_cmd = ICH9_APM_ACPI_DISABLE; > +} > + This function has to be called somewhere(ich9_lpc_pm_init?) to setup

Re: [Qemu-devel] [PATCH v7 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-18 Thread Tomoki Sekiyama
Hi Michael, > "CoCreateInstance(VSSCoordinator) failed. (Error: 80040154) Class not > registered I have seen this error when I ran 32bit qemu-ga on 64bit Windows (2008 server R2). Just in case, could you confirm qemu-ga.exe and qga-vss.dll are built for the correct architecture? Stopping VSS s

Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-18 Thread Mike Qiu
于 2013/7/19 1:14, Andreas Färber 写道: Hi, Am 18.07.2013 17:27, schrieb Mike Qiu: Hi all Any comments ? You should've CCed the USB maintainer whose file you are touching for review rather than just ppc people, see ./MAINTAINERS. I have CC to the usb naintainer Gerd Hoffmann, his files are hw/u

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 18, 2013 at 07:48:28PM +0100, Alex Bligh wrote: > Stefan, > > --On 17 July 2013 11:02:30 +0800 Stefan Hajnoczi wrote: > > >The steps to achieving this: > > > >1. Drop alarm timers from qemu-timer.c and calculate g_poll() timeout > > instead for the main loop. > > > >2. Introduce a

Re: [Qemu-devel] [PATCH V4 3/4] Add backing drive while performing backup.

2013-07-18 Thread Fam Zheng
On Thu, 07/18 15:13, Paolo Bonzini wrote: > Il 18/07/2013 08:39, Fam Zheng ha scritto: > > On Wed, 07/17 13:04, Ian Main wrote: > >> This patch adds the original source drive as a backing drive to our target > >> image so that the target image will appear complete during backup. This > >> is espec

Re: [Qemu-devel] [PATCH] linux-user: Fix target_stat and target_stat64 for OpenRISC

2013-07-18 Thread Jia Liu
Hi Peter, On Thu, Jul 18, 2013 at 6:18 PM, Peter Maydell wrote: > Ping? > Thank you, it looks good to me, please push it. > thanks > -- PMM > > On 6 July 2013 21:44, Peter Maydell wrote: >> OpenRISC uses the asm-generic versions of target_stat and >> target_stat64, but it was incorrectly using

[Qemu-devel] Is it possible to detect GPA access through the mapped HVA

2013-07-18 Thread Hu Yaohui
Hi I am new to QEMU. I want to know is it possible to detect the guest OS physical memory access through QEMU? What I am doing right now is use mprotect to set the mapped RAM as not accessible. Then register the SIGSEGV handler to handle the segmentation fault in qemu_kvm_eat_signals. But I always

[Qemu-devel] Fwd: Is it possible to detect GPA access through the mapped HVA

2013-07-18 Thread Hu Yaohui
Hi I am new to QEMU. I want to know is it possible to detect the guest OS physical memory access through QEMU? What I am doing right now is use mprotect to set the mapped RAM as not accessible. Then register the SIGSEGV handler to handle the segmentation fault in qemu_kvm_eat_signals. But I always

Re: [Qemu-devel] [PATCH] PPC: dbdma: macio: Fix format specifiers (build regression)

2013-07-18 Thread Alexander Graf
On 18.07.2013, at 21:49, Stefan Weil wrote: > Am 16.07.2013 07:54, schrieb Stefan Weil: >> Am 12.07.2013 18:48, schrieb Stefan Weil: >>> Fix a number of warnings for 32 bit builds (tested on MingW and Linux): >>> >>> CChw/ide/macio.o >>> qemu/hw/ide/macio.c: In function 'pmac_ide_atapi_tran

Re: [Qemu-devel] [PATCH v7 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-07-18 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-15 11:20:23) > Hi, > > This is v7 of patch series to add fsfreeze for Windows qemu-guest-agent. > > changes from v7: > - Fix COM initialization issue for Windows service thread (patch 07/10) > > v6: http://lists.nongnu.org/archive/html/qemu-devel/2013-07/msg0178

[Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update callers

2013-07-18 Thread Charlie Shepherd
This patch makes bdrv_flush a synchronous function and updates any callers from a coroutine context to use bdrv_co_flush instead. The motivation for this patch comes from the GSoC Continuation-Passing C project. When coroutines were introduced, synchronous functions in the block layer were convert

Re: [Qemu-devel] seccomp: remove unused syscalls - for 1.6

2013-07-18 Thread Paul Moore
On Thursday, July 18, 2013 10:31:46 PM Peter Maydell wrote: > On 18 July 2013 21:05, Paul Moore wrote: > > On Thursday, July 18, 2013 08:48:10 PM Peter Maydell wrote: > >> On 18 July 2013 20:39, Paul Moore wrote: > >> > On the plus side, I think libseccomp is very close to being pretty much > >>

Re: [Qemu-devel] seccomp: remove unused syscalls - for 1.6

2013-07-18 Thread Peter Maydell
On 18 July 2013 21:05, Paul Moore wrote: > On Thursday, July 18, 2013 08:48:10 PM Peter Maydell wrote: >> On 18 July 2013 20:39, Paul Moore wrote: >> > On the plus side, I think libseccomp is very close to being pretty much >> > feature complete (excluding new architectures that may pop up, at pr

[Qemu-devel] [Bug 1081416] Re: Qemu 1.2.0 crashes when using tcp serial console and GRUB boots

2013-07-18 Thread Ian Wells
I'm seeing this too. If someone cares to tell me how I get a core file from qemu-under-libvirt I will do that and report back on debugging. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1081416 Titl

[Qemu-devel] [Bug 1081416] Re: Qemu 1.2.0 crashes when using tcp serial console and GRUB boots

2013-07-18 Thread Ian Wells
(fairly sure it's in the iohandler based on a manual check of the symbols, though) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1081416 Title: Qemu 1.2.0 crashes when using tcp serial console and

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-18 Thread Scott Wood
On 07/18/2013 04:27:50 AM, Fabien Chouteau wrote: On 07/17/2013 11:02 PM, Scott Wood wrote: > On 07/17/2013 05:17:06 AM, Fabien Chouteau wrote: >> On 07/16/2013 07:50 PM, Scott Wood wrote: >> > On 07/16/2013 10:28:28 AM, Fabien Chouteau wrote: >> >> On 07/16/2013 04:06 AM, Scott Wood wrote: >> >>

[Qemu-devel] [PATCH v2 09/11] pseries: savevm support for PCI host bridge

2013-07-18 Thread Anthony Liguori
From: David Gibson This adds the necessary support for saving the state of the PAPR virtual PCI host bridge (or host bridges). Signed-off-by: David Gibson Reviewed-by: Anthony Liguori --- hw/ppc/spapr_pci.c | 49 + include/hw/pci-host/spapr

[Qemu-devel] [PATCH v2 04/11] pseries: savevm support for PAPR VIO logical tty

2013-07-18 Thread Anthony Liguori
From: David Gibson This patch adds the necessary VMStateDescription information to support savevm/loadvm for the spapr_tty (PAPR logical serial) device. Signed-off-by: David Gibson Reviewed-by: Anthony Liguori --- hw/char/spapr_vty.c | 16 1 file changed, 16 insertions(+) di

Re: [Qemu-devel] seccomp: remove unused syscalls - for 1.6

2013-07-18 Thread Paul Moore
On Thursday, July 18, 2013 08:48:10 PM Peter Maydell wrote: > On 18 July 2013 20:39, Paul Moore wrote: > > On the plus side, I think libseccomp is very close to being pretty much > > feature complete (excluding new architectures that may pop up, at present > > we are only x86, x86_64, x32, and ARM

Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand

2013-07-18 Thread Eric Blake
On 07/03/2013 08:34 AM, Paolo Bonzini wrote: > This command dumps the metadata of an entire chain, in either tabular or JSON > format. > > Signed-off-by: Paolo Bonzini > --- > qemu-img-cmds.hx | 6 ++ > qemu-img.c | 186 > +++ > 2 file

Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.

2013-07-18 Thread Eric Blake
On 07/18/2013 01:13 PM, Ian Main wrote: > On Thu, Jul 18, 2013 at 12:56:51PM -0600, Eric Blake wrote: >> On 07/18/2013 12:47 PM, Ian Main wrote: >>> qcow2 supports backing files so it makes sense to default to qcow2 >>> for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing >>> drive

Re: [Qemu-devel] [PATCH V4 1/4] Implement sync modes for drive-backup.

2013-07-18 Thread Eric Blake
On 07/18/2013 01:06 PM, Ian Main wrote: > On Thu, Jul 18, 2013 at 11:19:43AM -0600, Eric Blake wrote: >> On 07/17/2013 02:04 PM, Ian Main wrote: >>> This patch adds sync-modes to the drive-backup interface and >>> implements the FULL, NONE and TOP modes of synchronization. >>> >>> @@ -1807,6 +1807

Re: [Qemu-devel] [PATH 0/4] po/Makefile: Fix regression and some minor issues

2013-07-18 Thread Stefan Weil
Am 16.07.2013 07:16, schrieb Stefan Weil: > Am 05.07.2013 22:55, schrieb Stefan Weil: >> These patches are included: >> >> [PATCH 1/4] po/Makefile: Fix and improve help message >> [PATCH 2/4] po/Makefile: Fix *.mo generation for out-of-tree builds >> [PATCH 3/4] po/Makefile: Fix generation of messa

Re: [Qemu-devel] [PATCH] PPC: dbdma: macio: Fix format specifiers (build regression)

2013-07-18 Thread Stefan Weil
Am 16.07.2013 07:54, schrieb Stefan Weil: > Am 12.07.2013 18:48, schrieb Stefan Weil: >> Fix a number of warnings for 32 bit builds (tested on MingW and Linux): >> >> CChw/ide/macio.o >> qemu/hw/ide/macio.c: In function 'pmac_ide_atapi_transfer_cb': >> qemu/hw/ide/macio.c:134:9: error: format

Re: [Qemu-devel] seccomp: remove unused syscalls - for 1.6

2013-07-18 Thread Peter Maydell
On 18 July 2013 20:39, Paul Moore wrote: > On the plus side, I think libseccomp is very close to being pretty much > feature complete (excluding new architectures that may pop up, at present we > are only x86, x86_64, x32, and ARM) ...AArch64 ? :-) -- PMM

[Qemu-devel] [PATCH v2 11/11] xics: rename types to be sane and follow coding style

2013-07-18 Thread Anthony Liguori
>From Ben: Basically, in HW the layout of the interrupt network is: - One ICP per processor thread (the "presenter"). This contains the registers to fetch a pending interrupt (ack), EOI, and control the processor priority. - One ICS per logical source of interrupts (ie, one

[Qemu-devel] [PATCH v2 10/11] pseries: savevm support with KVM

2013-07-18 Thread Anthony Liguori
From: Alexey Kardashevskiy At present, the savevm / migration support for the pseries machine will not work when KVM is enabled. That's because KVM manages the guest's hash page table in the host kernel, so qemu has no visibility of it. This patch fixes this by using new kernel interfaces to ex

[Qemu-devel] [PATCH v2 01/11] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-18 Thread Anthony Liguori
From: Alexey Kardashevskiy The savevm code for the powerpc cpu emulation is currently based around the old register_savevm() rather than register_vmstate() method. It's also rather broken, missing some important state on some CPU models. This patch completely rewrites the savevm for target-ppc,

[Qemu-devel] [PATCH v2 07/11] pseries: savevm support for PAPR virtual SCSI

2013-07-18 Thread Anthony Liguori
From: David Gibson This patch adds the necessary support for saving the state of the PAPR VIO virtual SCSI device. This also saves and restores active SCSI requests. [aik: implemented vscsi_req save/restore] Signed-off-by: Alexey Kardashevskiy Cc: David Gibson --- hw/scsi/spapr_vscsi.c | 82 +

Re: [Qemu-devel] [PATCH v2 0/2] libqtest leak fix & cleanup

2013-07-18 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] seccomp: remove unused syscalls - for 1.6

2013-07-18 Thread Paul Moore
On Thursday, July 18, 2013 06:37:15 PM Paolo Bonzini wrote: > Il 18/07/2013 18:35, Eduardo Otubo ha scritto: > > On 07/18/2013 01:28 PM, Anthony Liguori wrote: > >> Eduardo Otubo writes: > >>> Hello all, > >> > >>> In this small patch series I basically: > >> Cover letter should be marked [PATCH

[Qemu-devel] [PATCH v2 05/11] spapr-tce: make sPAPRTCETable a proper device

2013-07-18 Thread Anthony Liguori
Model TCE tables as a device that's hooked up as a child object to the owner. Besides the code cleanup, we get a few nice benefits: 1) free actually works now (it was dead code before) 2) the TCE information is visible in the device tree 3) we can expose table information as properties such tha

[Qemu-devel] [PATCH v2 00/11] pseries: migration and QOM support

2013-07-18 Thread Anthony Liguori
This series is based on Alexey's series: spapr: migration, pci, msi, power8 Which in turn was based on work by David Gibson. I've removed the bits not related to migration and made the following changes: 1) QOMify TCE tables and XICS 2) Do everything in terms of VMStateDescriptions 3) Fi

Re: [Qemu-devel] [PATCH] ioport: remove LITTLE_ENDIAN mark for portio

2013-07-18 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/2] changes related to monitor flow control

2013-07-18 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] configure: Provide more helpful message if libvte not present

2013-07-18 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement

2013-07-18 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH v2 03/11] pseries: savevm support for PAPR VIO logical lan

2013-07-18 Thread Anthony Liguori
From: David Gibson This patch adds the necessary VMStateDescription information to support savevm/loadvm for the spapr_llan (PAPR logical lan) device. Signed-off-by: David Gibson Reviewed-by: Anthony Liguori --- hw/net/spapr_llan.c | 24 ++-- 1 file changed, 22 insertions(

[Qemu-devel] [PATCH v2 06/11] pseries: rework PAPR virtual SCSI

2013-07-18 Thread Anthony Liguori
From: Alexey Kardashevskiy The patch reimplements handling of indirect requests in order to simplify upcoming live migration support. - all pointers (except SCSIRequest*) were replaces with integer indexes and offsets; - DMA'ed srp_direct_buf kept untouched (ie. BE format); - vscsi_fetch_desc() i

[Qemu-devel] [PATCH v2 02/11] pseries: savevm support for VIO devices

2013-07-18 Thread Anthony Liguori
From: David Gibson This patch adds helpers to allow PAPR VIO devices to save state common to all VIO devices during savevm. Signed-off-by: David Gibson Reviewed-by: Anthony Liguori --- hw/ppc/spapr_vio.c | 20 include/hw/ppc/spapr_vio.h | 5 + 2 files changed

[Qemu-devel] [PATCH v2 08/11] pseries: savevm support for pseries machine

2013-07-18 Thread Anthony Liguori
From: David Gibson This adds the necessary pieces to implement savevm / migration for the pseries machine. The most complex part here is migrating the hash table - for the paravirtualized pseries machine the guest's hash page table is not stored within guest memory, but externally and the guest

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Peter Lieven
Am 18.07.2013 um 20:54 schrieb ronnie sahlberg : > BlockLimitsVPD OptimalUnmapGranularity also applies to unmapping with > writesame16 : > > An OPTIMAL UNMAP GRANULARITY field set to a non-zero value indicates > the optimal granularity in logical blocks > for unmap requests (e.g., an UNMAP comm

Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.

2013-07-18 Thread Ian Main
On Thu, Jul 18, 2013 at 12:56:51PM -0600, Eric Blake wrote: > On 07/18/2013 12:47 PM, Ian Main wrote: > > qcow2 supports backing files so it makes sense to default to qcow2 > > for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing > > drive and export it via nbd. Defaulting FULL and

Re: [Qemu-devel] [PATCH V4 1/4] Implement sync modes for drive-backup.

2013-07-18 Thread Ian Main
On Thu, Jul 18, 2013 at 11:19:43AM -0600, Eric Blake wrote: > On 07/17/2013 02:04 PM, Ian Main wrote: > > This patch adds sync-modes to the drive-backup interface and > > implements the FULL, NONE and TOP modes of synchronization. > > > > FULL performs as before copying the entire contents of the

Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.

2013-07-18 Thread Eric Blake
On 07/18/2013 12:47 PM, Ian Main wrote: > qcow2 supports backing files so it makes sense to default to qcow2 > for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing > drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE > breaks tests but that could be fixed if we

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread ronnie sahlberg
BlockLimitsVPD OptimalUnmapGranularity also applies to unmapping with writesame16 : An OPTIMAL UNMAP GRANULARITY field set to a non-zero value indicates the optimal granularity in logical blocks for unmap requests (e.g., an UNMAP command or a WRITE SAME (16) command with the UNMAP bit set to one)

Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.

2013-07-18 Thread Eric Blake
On 07/18/2013 12:03 PM, Ian Main wrote: >> >> Or we could simplify life by making 'format' mandatory for drive-backup; >> it was optional for 'drive-mirror' due to incremental implementation, >> but for 'drive-backup', we still have the opportunity to do things right >> from the first release. > >

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-18 Thread Alex Bligh
Stefan, --On 17 July 2013 11:02:30 +0800 Stefan Hajnoczi wrote: The steps to achieving this: 1. Drop alarm timers from qemu-timer.c and calculate g_poll() timeout instead for the main loop. 2. Introduce a per-AioContext aio_ctx_clock that can be used with qemu_new_timer() to create a Q

[Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.

2013-07-18 Thread Ian Main
qcow2 supports backing files so it makes sense to default to qcow2 for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE breaks tests but that could be fixed if we wanted it. Signed-off-by: Ian Main --- blockd

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Peter Lieven
Am 18.07.2013 um 16:35 schrieb Paolo Bonzini : > Il 18/07/2013 16:32, Peter Lieven ha scritto: >>> (Mis)alignment and granularity can be handled later. We can ignore them >>> for now. Later, if we decide the best way to support them is a flag, >>> we'll add it. Let's not put the cart bef

Re: [Qemu-devel] [PATCH v2 0/6] Clean up bogus default boot order

2013-07-18 Thread Anthony Liguori
Markus Armbruster writes: > Ping? This needs a rebase. Regards, Anthony Liguori > > Markus Armbruster writes: > >> This is on top of "[PATCH v4 00/12] Boot order tests", so it's >> protected by these tests. >> >> The first five patches are admittedly related to the stated purpose of >> this

Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.

2013-07-18 Thread Ian Main
On Thu, Jul 18, 2013 at 11:27:21AM -0600, Eric Blake wrote: > On 07/17/2013 02:04 PM, Ian Main wrote: > > qcow2 supports backing files so it makes sense to default to qcow2 > > for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing > > drive and export it via nbd. Defaulting FULL and

Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.

2013-07-18 Thread Ian Main
On Thu, Jul 18, 2013 at 11:32:52AM -0600, Eric Blake wrote: > On 07/18/2013 11:27 AM, Eric Blake wrote: > > >> if (!has_format) { > >> -format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : > >> bs->drv->format_name; > >> +format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : "qcow2"

Re: [Qemu-devel] [PATCH v8 0/3] Throttle-down guest to help with live migration convergence

2013-07-18 Thread Vinod, Chegu
Hi Peter, Thanks for catching this. Tthis was perhaps accidentally left out during merge to Juan's migration.next tree. I have informed Juan and he said he would take care of it. Vinod -Original Message- From: Peter Lieven [mailto:lieven-li...@dlhnet.de] Sent: Wednesday, July 17, 201

Re: [Qemu-devel] Watchdog device in Qemu user mode

2013-07-18 Thread kbastian
Hi Andreas, thanks alot. I only used user mode because I thought it is easier to implement. I will take a look into system mode. Best regards Bastian

Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.

2013-07-18 Thread Eric Blake
On 07/18/2013 11:27 AM, Eric Blake wrote: >> if (!has_format) { >> -format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : >> bs->drv->format_name; >> +format = mode == NEW_IMAGE_MODE_EXISTING ? NULL : "qcow2"; > > Is this the right thing to do? Or should we do: > > if (!has_fo

Re: [Qemu-devel] Watchdog device in Qemu user mode

2013-07-18 Thread Andreas Färber
Hi Bastian, Am 18.07.2013 19:09, schrieb kbast...@mail.uni-paderborn.de: > The processor is usually embedded and > programs run without operating systems or with custom ones designed for > hard realtime. Would it be much work to port from user mode to system mode? > I am using a c-compiler to crea

Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.

2013-07-18 Thread Eric Blake
On 07/17/2013 02:04 PM, Ian Main wrote: > qcow2 supports backing files so it makes sense to default to qcow2 > for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing > drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE > breaks tests but that could be fixed if we

Re: [Qemu-devel] Watchdog device in Qemu user mode

2013-07-18 Thread Peter Maydell
On 18 July 2013 18:09, wrote: > thanks for the fast response. The processor is usually embedded and programs > run without operating systems or with custom ones designed for hard > realtime. If this is your use case you should just implement system mode and not worry about implementing linux-use

Re: [Qemu-devel] [PATCH V4 1/4] Implement sync modes for drive-backup.

2013-07-18 Thread Eric Blake
On 07/17/2013 02:04 PM, Ian Main wrote: > This patch adds sync-modes to the drive-backup interface and > implements the FULL, NONE and TOP modes of synchronization. > > FULL performs as before copying the entire contents of the drive > while preserving the point-in-time using CoW. > NONE only copi

Re: [Qemu-devel] [PATCH] Bug Fix:Segmentation fault when use usb-ehci device

2013-07-18 Thread Andreas Färber
Hi, Am 18.07.2013 17:27, schrieb Mike Qiu: > Hi all > > Any comments ? You should've CCed the USB maintainer whose file you are touching for review rather than just ppc people, see ./MAINTAINERS. There's some typos in the commit message, but the change looks okay to me - although there were dis

Re: [Qemu-devel] Watchdog device in Qemu user mode

2013-07-18 Thread kbastian
Hi Peter, thanks for the fast response. The processor is usually embedded and programs run without operating systems or with custom ones designed for hard realtime. Would it be much work to port from user mode to system mode? I am using a c-compiler to create testprograms and these programs

Re: [Qemu-devel] [PATCH] util/iov: Fix -O1 uninitialized variable warning

2013-07-18 Thread Richard Henderson
On 07/18/2013 09:36 AM, Peter Maydell wrote: > On 18 July 2013 17:14, Richard Henderson wrote: >> At -O2, code in the form >> >> if (p) A; B; if (p) C; >> >> may be rearranged via "jump threading" into >> >> if (p) { A; B; C; } else { B; } >> >> But at -O1 this doesn't happen and we -Werror ou

Re: [Qemu-devel] Watchdog device in Qemu user mode

2013-07-18 Thread Peter Maydell
On 18 July 2013 17:44, wrote: > Hey everybody, > > I am fairly new to qemu development. So here is my question: > I would like to write a virtual watchdog device, which > is part of the emulated cpu. This is part of an Infineon > Tricore Implementation I am writing. For simplicities sake > I use

[Qemu-devel] Watchdog device in Qemu user mode

2013-07-18 Thread kbastian
Hey everybody, I am fairly new to qemu development. So here is my question: I would like to write a virtual watchdog device, which is part of the emulated cpu. This is part of an Infineon Tricore Implementation I am writing. For simplicities sake I use qemu user mode, to test my translation

Re: [Qemu-devel] [PATCH v2 0/6] Clean up bogus default boot order

2013-07-18 Thread Markus Armbruster
Ping? Markus Armbruster writes: > This is on top of "[PATCH v4 00/12] Boot order tests", so it's > protected by these tests. > > The first five patches are admittedly related to the stated purpose of > this series pretty much only by "I can't stand perpetuating this > stupid crap". Max Filippov

Re: [Qemu-devel] [PATCH v4 00/12] Boot order tests

2013-07-18 Thread Markus Armbruster
Ping? Markus Armbruster writes: > v4: > * Old PATCH 1-6 got merged, only tests left; cover letter changed > accordingly > * PATCH 1,6 unchanged > * PATCH 2 fix system-reset race (Anthony) > * New PATCH 4,11 to make libqos/fw_cfg usable for the ppc, Sun4 tests > * New PATCH 3 shanghaied from An

Re: [Qemu-devel] seccomp: remove unused syscalls - for 1.6

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 18:35, Eduardo Otubo ha scritto: > > > On 07/18/2013 01:28 PM, Anthony Liguori wrote: >> Eduardo Otubo writes: >> >>> Hello all, >>> >>> In this small patch series I basically: >> >> Cover letter should be marked [PATCH 0/2]. Otherwise it defeats >> filtering. >> >> Would like to

Re: [Qemu-devel] seccomp: remove unused syscalls - for 1.6

2013-07-18 Thread Eduardo Otubo
On 07/18/2013 01:28 PM, Anthony Liguori wrote: Eduardo Otubo writes: Hello all, In this small patch series I basically: Cover letter should be marked [PATCH 0/2]. Otherwise it defeats filtering. Would like to see a Reviewed-by from someone before applying this. I'm running some tests

Re: [Qemu-devel] [PATCH] util/iov: Fix -O1 uninitialized variable warning

2013-07-18 Thread Peter Maydell
On 18 July 2013 17:14, Richard Henderson wrote: > At -O2, code in the form > > if (p) A; B; if (p) C; > > may be rearranged via "jump threading" into > > if (p) { A; B; C; } else { B; } > > But at -O1 this doesn't happen and we -Werror out here on > the "may be used uninitialized" orig_len. P

Re: [Qemu-devel] [RFC 0/3] Determinitic behaviour with icount.

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 18:31, Frederic Konrad ha scritto: > On 18/07/2013 17:35, Paolo Bonzini wrote: >> Il 18/07/2013 17:06, Peter Maydell ha scritto: >>> On 18 July 2013 16:02, wrote: As I said in the last email, we have issues with determinism with icount. We are wondering if determinism

Re: [Qemu-devel] [RFC 0/3] Determinitic behaviour with icount.

2013-07-18 Thread Frederic Konrad
On 18/07/2013 17:35, Paolo Bonzini wrote: Il 18/07/2013 17:06, Peter Maydell ha scritto: On 18 July 2013 16:02, wrote: As I said in the last email, we have issues with determinism with icount. We are wondering if determinism is really ensured with icount? My opinion is that it *should* be de

Re: [Qemu-devel] [PATCH v2 0/8] Guest memory allocation fixes & cleanup

2013-07-18 Thread Markus Armbruster
Ping? Markus Armbruster writes: > All I wanted to do is exit(1) instead of abort() on guest memory > allocation failure [07/08]. But that lead me into a minor #ifdef bog, > and here's what I brought back. Enjoy! > > Testing: > * Christian Borntraeger reports v1 works fine under LPAR (new S390

[Qemu-devel] large size PCI windows vs ivshmem vs windows guests

2013-07-18 Thread Michael S. Tsirkin
Currently seabios simply looks for 64 bit BARs and sums them up to get the size of the region. The result is reported in the CRS method in ACPI tables. But this means that e.g. hotplug is broken - if we try to add a huge ivshmem device there won't be place for it in the 32 bit PCI hole, and a 64 bi

Re: [Qemu-devel] [PATCH v2 0/2] libqtest leak fix & cleanup

2013-07-18 Thread Markus Armbruster
Ping? Markus Armbruster writes: > v2: qtest_start() function comment > > Markus Armbruster (2): > libqtest: Plug fd and memory leaks in qtest_quit() > libqtest: New qtest_end() to go with qtest_start() > > tests/fdc-test.c| 2 +- > tests/hd-geo-test.c | 8 > tests/ide-test.c

Re: [Qemu-devel] seccomp: remove unused syscalls - for 1.6

2013-07-18 Thread Anthony Liguori
Eduardo Otubo writes: > Hello all, > > In this small patch series I basically: Cover letter should be marked [PATCH 0/2]. Otherwise it defeats filtering. Would like to see a Reviewed-by from someone before applying this. Regards, Anthony Liguori > > v2 update: > - set libseccomp 2.1.0 a

Re: [Qemu-devel] [RFC 1/3] icount: base rt_clock on icount.

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 18:23, Frederic Konrad ha scritto: > On 18/07/2013 17:36, Paolo Bonzini wrote: >> Il 18/07/2013 17:02, fred.kon...@greensocs.com ha scritto: >>> From: KONRAD Frederic >>> >>> This bases rt_clock on icount, as vm_clock. >>> So vm_clock = rt_clock. >>> >>> Signed-off-by: KONRAD Frederi

Re: [Qemu-devel] [RFC 1/3] icount: base rt_clock on icount.

2013-07-18 Thread Frederic Konrad
On 18/07/2013 17:36, Paolo Bonzini wrote: Il 18/07/2013 17:02, fred.kon...@greensocs.com ha scritto: From: KONRAD Frederic This bases rt_clock on icount, as vm_clock. So vm_clock = rt_clock. Signed-off-by: KONRAD Frederic --- qemu-timer.c | 6 +- 1 file changed, 5 insertions(+), 1 del

[Qemu-devel] [PATCH] util/iov: Fix -O1 uninitialized variable warning

2013-07-18 Thread Richard Henderson
At -O2, code in the form if (p) A; B; if (p) C; may be rearranged via "jump threading" into if (p) { A; B; C; } else { B; } But at -O1 this doesn't happen and we -Werror out here on the "may be used uninitialized" orig_len. Perform this transform by hand so that -O1 remains a viable debugg

Re: [Qemu-devel] [RFC 2/6] OptsVisitor: introduce list modes for interval flattening

2013-07-18 Thread Laszlo Ersek
On 07/18/13 16:56, Paolo Bonzini wrote: > Il 18/07/2013 15:59, Laszlo Ersek ha scritto: >> The new modes are equal-rank, exclusive sub-modes of LM_IN_PROGRESS. Teach >> opts_next_list(), opts_type_int() and opts_type_uint64() to handle them. > > Perhaps you could use a bitmap then: > > LM_NO

  1   2   3   >