Re: [Qemu-devel] [PATCH] ahci: Fix FLUSH command

2013-07-15 Thread Fam Zheng
On Mon, 07/15 11:34, Kevin Wolf wrote: > AHCI couldn't cope with asynchronous commands that aren't doing DMA, it > simply wouldn't complete them. Due to the bug fixed in commit f68ec837, > FLUSH commands would seem to have completed immediately even if they > were still running on the host. After t

Re: [Qemu-devel] [PATCH 00/17] Add qemu-img subcommand to dump file metadata

2013-07-15 Thread Peter Lieven
On 16.07.2013 05:41, Stefan Hajnoczi wrote: On Wed, Jul 03, 2013 at 04:34:14PM +0200, Paolo Bonzini wrote: This series adds a subcommand to "map" that can dump file metadata. Metadata that is dumped includes: - whether blocks are allocated in bs->file and, if so, where - whether blocks are zer

Re: [Qemu-devel] [PATCH 16/17] block: add default get_block_status implementation for protocols

2013-07-15 Thread Peter Lieven
On 03.07.2013 16:34, Paolo Bonzini wrote: Protocols return raw data, so you can assume the offsets to pass through unchanged. Signed-off-by: Paolo Bonzini --- block.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index cd371cd..ff8ced7 100644 ---

Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand

2013-07-15 Thread Paolo Bonzini
Il 16/07/2013 05:31, Stefan Hajnoczi ha scritto: > On Wed, Jul 03, 2013 at 04:34:26PM +0200, Paolo Bonzini wrote: >> > +if ((ret & BDRV_BLOCK_DATA) && >> > +!(ret & BDRV_BLOCK_OFFSET_VALID)) { >> > +error_report("File contains external or compressed >> > clusters.")

Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option

2013-07-15 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 15/07/2013 23:33, Eric Blake ha scritto: > Newer libvirt can be taught to append 'M' when it detects > it is talking to newer qemu. While you have a point that > it is annoying to force users to upgrade to a newer libvirt > merely b

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-15 Thread Paolo Bonzini
Il 16/07/2013 07:19, Alexey Kardashevskiy ha scritto: > In the past, IO space could not be mapped into the memory address space > so we introduced a workaround for that. Nowadays it does not look > necessary so we can remove the workaround and make sPAPR PCI > configuration simplier. > > This also

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-15 Thread Paolo Bonzini
Il 16/07/2013 03:27, Hu Tao ha scritto: > > I think it's the same. One "-numa mem" option = one "-device dimm" > > option; both define one range. Unused memory ranges may remain if you > > stumble upon a unusable range such as the PCI window. For example two > > "-numa mem,size=2G" options would

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-15 Thread Paolo Bonzini
Il 16/07/2013 01:04, Alex Bligh ha scritto: > Paolo, > > --On 15 July 2013 22:53:17 +0200 Paolo Bonzini wrote: > >> So far you are right. >> >> But this only happens if qemu_aio_wait() actually returns, so that on >> the next call we poll for timers. If QEMU is stuck in qemu_aio_wait()'s >> inf

Re: [Qemu-devel] [RFC PATCH v1 2/2] gluster: Add discard support for GlusterFS block driver

2013-07-15 Thread Stefan Hajnoczi
On Fri, Jul 12, 2013 at 12:30:08PM +0530, Bharata B Rao wrote: > gluster: Add discard support for GlusterFS block driver. Commit message duplicated into commit description.

Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-15 Thread Anand Avati
On 7/15/13 11:02 PM, Stefan Hajnoczi wrote: On Fri, Jul 12, 2013 at 12:28:54PM +0530, Bharata B Rao wrote: gluster: Use pkg-config to configure GlusterFS block driver The commit message is duplicated in the commit description. Use pkg-config to determine the version and library dependency fo

Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver

2013-07-15 Thread Stefan Hajnoczi
On Fri, Jul 12, 2013 at 12:28:54PM +0530, Bharata B Rao wrote: > gluster: Use pkg-config to configure GlusterFS block driver The commit message is duplicated in the commit description. > Use pkg-config to determine the version and library dependency > for GlusterFS block driver. > > Signed-off-b

Re: [Qemu-devel] [PATCH] block: Don't parse protocol from file.filename

2013-07-15 Thread Stefan Hajnoczi
On Wed, Jul 10, 2013 at 03:51:13PM +0200, Kevin Wolf wrote: > One of the major reasons for doing something new for -blockdev and > blockdev-add was that the old block layer code parses filenames instead > of just taking them literally. So we should really leave it untouched > when it's passing usin

Re: [Qemu-devel] [PATCH] PPC: dbdma: macio: Fix format specifiers (build regression)

2013-07-15 Thread Stefan Weil
Am 12.07.2013 18:48, schrieb Stefan Weil: > Fix a number of warnings for 32 bit builds (tested on MingW and Linux): > > CChw/ide/macio.o > qemu/hw/ide/macio.c: In function 'pmac_ide_atapi_transfer_cb': > qemu/hw/ide/macio.c:134:9: error: format '%lx' expects argument of type 'long > unsigned

[Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-15 Thread Alexey Kardashevskiy
In the past, IO space could not be mapped into the memory address space so we introduced a workaround for that. Nowadays it does not look necessary so we can remove the workaround and make sPAPR PCI configuration simplier. This also removes all byte swappings as it is not PHB's to take care of end

Re: [Qemu-devel] [PATH 0/4] po/Makefile: Fix regression and some minor issues

2013-07-15 Thread Stefan Weil
Am 05.07.2013 22:55, schrieb Stefan Weil: > These patches are included: > > [PATCH 1/4] po/Makefile: Fix and improve help message > [PATCH 2/4] po/Makefile: Fix *.mo generation for out-of-tree builds > [PATCH 3/4] po/Makefile: Fix generation of messages.po > [PATCH 4/4] po/Makefile: Use macro quiet

[Qemu-devel] [PATCH v2 2/2] object: Object apply the refcnt interface by Qref

2013-07-15 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- include/qom/object.h | 3 ++- qom/object.c | 15 +-- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 23fc048..6331972 100644 --- a/include/qom/object.h +++ b/include/qom/object.h

[Qemu-devel] [PATCH v2 1/2] refcnt: introduce Qref to abstract the refcnt interface

2013-07-15 Thread Liu Ping Fan
Qref is similar to kref. It hides the refcnt detail and provides a common interface. And this patch is based on the idiom of refcnt, and adopts some optimization about memory model, which finally falls back on gcc implementation. Signed-off-by: Liu Ping Fan --- v2: put Qref to a dedicated fil

[Qemu-devel] [PATCH v6] QEMUBH: make AioContext's bh re-entrant

2013-07-15 Thread Liu Ping Fan
BH will be used outside big lock, so introduce lock to protect between the writers, ie, bh's adders and deleter. The lock only affects the writers and bh's callback does not take this extra lock. Note that for the same AioContext, aio_bh_poll() can not run in parallel yet. Signed-off-by: Liu Ping

Re: [Qemu-devel] [PATCH v5 2/9] dump: Add API to write header of flatten format

2013-07-15 Thread Qiao Nuohan
On 07/16/2013 10:06 AM, Stefan Hajnoczi wrote: On Tue, Jul 09, 2013 at 03:30:07PM +0800, Qiao Nuohan wrote: +static int write_start_flat_header(int fd) +{ +char buf[MAX_SIZE_MDF_HEADER]; +MakedumpfileHeader mh; Why is buf[] necessary? You can write mh directly. The size of header s

Re: [Qemu-devel] [PATCH 00/17] Add qemu-img subcommand to dump file metadata

2013-07-15 Thread Stefan Hajnoczi
On Wed, Jul 03, 2013 at 04:34:14PM +0200, Paolo Bonzini wrote: > This series adds a subcommand to "map" that can dump file metadata. > Metadata that is dumped includes: > > - whether blocks are allocated in bs->file and, if so, where > > - whether blocks are zero > > - whether data is read from

Re: [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages

2013-07-15 Thread Qiao Nuohan
Thanks for your comments! On 07/16/2013 10:43 AM, Stefan Hajnoczi wrote: @@ -130,6 +139,13 @@ typedef struct DataCache { >off_t offset; /* offset of the file */ >} DataCache; > > +typedef struct PageDesc { > +off_t offset; /* the offset of the page data

Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand

2013-07-15 Thread Stefan Hajnoczi
On Wed, Jul 03, 2013 at 04:34:26PM +0200, Paolo Bonzini wrote: > +if ((ret & BDRV_BLOCK_DATA) && > +!(ret & BDRV_BLOCK_OFFSET_VALID)) { > +error_report("File contains external or compressed clusters."); What does "external clusters" mean? Did you mean encrypted?

Re: [Qemu-devel] [PATCH 02/12] trace+libvirt: start trace processing thread in final child process

2013-07-15 Thread Stefan Hajnoczi
On Mon, Jul 15, 2013 at 09:41:19PM +0200, Christian Borntraeger wrote: > When running with trace backend e.g. "simple" the writer thread needs to be > implemented in the same process context as the trace points that will be > processed. Under libvirtd control, qemu gets first started in daemonized

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-15 Thread Stefan Hajnoczi
On Mon, Jul 15, 2013 at 05:56:31PM +0800, Qiao Nuohan wrote: > On 07/09/2013 03:36 PM, Qiao Nuohan wrote: > >Still waiting for introspection... And comments about format will be very > >helpful. > > Hi Stefan and others, > > What do you think about the process of creating vmcore in kdump-compress

Re: [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages

2013-07-15 Thread Stefan Hajnoczi
On Tue, Jul 09, 2013 at 03:30:13PM +0800, Qiao Nuohan wrote: > if test "$seccomp" != "no" ; then > @@ -3872,6 +3914,14 @@ if test "$glx" = "yes" ; then >echo "GLX_LIBS=$glx_libs" >> $config_host_mak > fi > > +if test "$lzo" = "yes" ; then > + echo "CONFIG_LZO=y" >> $config_host_mak > +fi >

Re: [Qemu-devel] [PATCH v5 6/9] dump: Add API to write dump_bitmap

2013-07-15 Thread Stefan Hajnoczi
On Tue, Jul 09, 2013 at 03:30:11PM +0800, Qiao Nuohan wrote: > +/* set dump_bitmap sequencely */ > +static int set_dump_bitmap(int64_t last_pfn, int64_t pfn, uint32_t value, > + void *buf, DumpState *s) > +{ > +off_t old_offset, new_offset; > +off_t offset_bitmap1,

Re: [Qemu-devel] [PATCH v5 5/9] dump: add API to write dump header

2013-07-15 Thread Stefan Hajnoczi
On Tue, Jul 09, 2013 at 03:30:10PM +0800, Qiao Nuohan wrote: > +/* write common header, sub header and elf note to vmcore */ > +static int create_header32(DumpState *s) > +{ > +int ret = 0; > +DiskDumpHeader32 *dh; > +KdumpSubHeader32 *kh; > +size_t size; > + > +/* write common

Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space

2013-07-15 Thread Alexey Kardashevskiy
On 07/16/2013 12:05 PM, Anthony Liguori wrote: > On Mon, Jul 15, 2013 at 7:39 PM, Alexey Kardashevskiy wrote: >> On 07/16/2013 10:28 AM, Anthony Liguori wrote: >>> Alexey Kardashevskiy writes: >>> >>> The right solution is to drop the additional IO region on sPAPR and >>> remove the ISA devices m

Re: [Qemu-devel] [PATCH v5 2/9] dump: Add API to write header of flatten format

2013-07-15 Thread Stefan Hajnoczi
On Tue, Jul 09, 2013 at 03:30:07PM +0800, Qiao Nuohan wrote: > +static int write_start_flat_header(int fd) > +{ > +char buf[MAX_SIZE_MDF_HEADER]; > +MakedumpfileHeader mh; Why is buf[] necessary? You can write mh directly.

Re: [Qemu-devel] [PATCH 4/4] target-openrisc: Fix cpu_model by name

2013-07-15 Thread Jia Liu
On Tue, Jul 16, 2013 at 10:00 AM, Jia Liu wrote: > Fix cpu_model by name, make any and or1200 works both OK. > Sorry, I forgot add V2 in title. > Signed-off-by: Jia Liu > --- > target-openrisc/cpu.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/targ

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-15 Thread Scott Wood
On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: > This implementation doesn't include ring priority, TCP/IP Off-Load, QoS. > > Signed-off-by: Fabien Chouteau >From the code comments I gather this has been tested on VxWorks. Has it been tested on Linux, or anywhere else? > --- > default-conf

Re: [Qemu-devel] [PATCH 3/4] target-openrisc: Free typename

2013-07-15 Thread Jia Liu
On Tue, Jul 16, 2013 at 10:00 AM, Jia Liu wrote: > We should free typename here. > Sorry, I forgot add V2 in title. > Signed-off-by: Jia Liu > --- > target-openrisc/cpu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c > index 6d40f1b..e34

Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space

2013-07-15 Thread Anthony Liguori
On Mon, Jul 15, 2013 at 7:39 PM, Alexey Kardashevskiy wrote: > On 07/16/2013 10:28 AM, Anthony Liguori wrote: >> Alexey Kardashevskiy writes: >> >> The right solution is to drop the additional IO region on sPAPR and >> remove the ISA devices marking themselves as "little endian". > > > No, this i

[Qemu-devel] [PATCH V2 2/4] hw/openrisc: Use stderr output instead of qemu_log

2013-07-15 Thread Jia Liu
We should use stderr output instead of qemu_log in order to output ErrMsg onto the screen. Signed-off-by: Jia Liu --- hw/openrisc/openrisc_sim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index f0dabb9..9f0d9b

[Qemu-devel] [PATCH 4/4] target-openrisc: Fix cpu_model by name

2013-07-15 Thread Jia Liu
Fix cpu_model by name, make any and or1200 works both OK. Signed-off-by: Jia Liu --- target-openrisc/cpu.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index e348df0..6637166 100644 --- a/target-openrisc/cpu.c

[Qemu-devel] [PATCH 3/4] target-openrisc: Free typename

2013-07-15 Thread Jia Liu
We should free typename here. Signed-off-by: Jia Liu --- target-openrisc/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index 6d40f1b..e348df0 100644 --- a/target-openrisc/cpu.c +++ b/target-openrisc/cpu.c @@ -99,6 +99,7 @@ static ObjectCl

[Qemu-devel] [PATCH V2 1/4] hw/openrisc: Indent typo

2013-07-15 Thread Jia Liu
Indent typo. Signed-off-by: Jia Liu --- hw/openrisc/openrisc_sim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index 924438b..f0dabb9 100644 --- a/hw/openrisc/openrisc_sim.c +++ b/hw/openrisc/openrisc_sim.c @@ -8

[Qemu-devel] [PATCH V2 0/4] target-openrisc hw/openrisc: Some OpenRISC fix.

2013-07-15 Thread Jia Liu
Fix OpenRISC CPU and sim broad, we should free typename and check cpu models by name in cpu.c, and we should use stderr output in openrisc_sim.c. Jia Liu (4): hw/openrisc: Indent typo hw/openrisc: Use stderr output instead of qemu_log target-openrisc: Free typename target-openrisc: Fix cpu

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-15 Thread Hu Tao
On Mon, Jul 15, 2013 at 07:10:30PM +0200, Paolo Bonzini wrote: > Il 15/07/2013 19:05, Vasilis Liaskovitis ha scritto: > > from what i understand, we are currently favoring this numa option? (I saw > > it > > mentioned in Gao's numa patchset series as well) > > The two patchsets have some overlap,

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-15 Thread Hu Tao
On Sun, Jul 14, 2013 at 06:58:23PM +0200, Paolo Bonzini wrote: > Il 12/07/2013 04:39, Hu Tao ha scritto: > > > without necessity to specify to be hot-plugged DIMMs at startup, hot-plug > > > could become more flexible since arbitrarily sized DIMMs with required > > > NUMA > > > mapping could be sp

[Qemu-devel] ARRAYS :QMP Declaration

2013-07-15 Thread Saptarshi Sen
Hi, Is it possible to use fixed array data structures for use through the qmp-interface. My aim is to monitor IDE level activity in terms of sectors being accessed. So I plan to have a fixed size buffer. But I find no way of doing so when I use the qapi-schema.json. I think the qm

Re: [Qemu-devel] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-15 Thread Peter Crosthwaite
Hi Fabien, On Tue, Jul 16, 2013 at 12:23 AM, Fabien Chouteau wrote: > On 07/15/2013 04:00 AM, Peter Crosthwaite wrote: >> Hi Fabien, >> > > Hi Peter, > >> On Thu, Jul 11, 2013 at 3:10 AM, Fabien Chouteau >> wrote: >>> +#ifdef DEBUG_REGISTER >>> +printf("Write 0x%08x @ 0x" TARGET_FMT_plx" va

Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space

2013-07-15 Thread Alexey Kardashevskiy
On 07/16/2013 10:28 AM, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > >> On 07/16/2013 01:02 AM, Anthony Liguori wrote: >>> Alexey Kardashevskiy writes: >>> On 07/13/2013 06:03 PM, David Gibson wrote: > On Fri, Jul 12, 2013 at 05:37:19PM +1000, Alexey Kardashevskiy wrote:

Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space

2013-07-15 Thread Anthony Liguori
Alexey Kardashevskiy writes: > On 07/16/2013 01:02 AM, Anthony Liguori wrote: >> Alexey Kardashevskiy writes: >> >>> On 07/13/2013 06:03 PM, David Gibson wrote: On Fri, Jul 12, 2013 at 05:37:19PM +1000, Alexey Kardashevskiy wrote: > sPAPR PHB emulates IO ports on PCI via a special memo

Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space

2013-07-15 Thread Alexey Kardashevskiy
On 07/16/2013 01:02 AM, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > >> On 07/13/2013 06:03 PM, David Gibson wrote: >>> On Fri, Jul 12, 2013 at 05:37:19PM +1000, Alexey Kardashevskiy wrote: sPAPR PHB emulates IO ports on PCI via a special memory region which routes all reads/

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-15 Thread Alex Bligh
Paolo, --On 15 July 2013 22:53:17 +0200 Paolo Bonzini wrote: So far you are right. But this only happens if qemu_aio_wait() actually returns, so that on the next call we poll for timers. If QEMU is stuck in qemu_aio_wait()'s infinite-timeout poll(), it will never advance and process the time

[Qemu-devel] [PATCH 17/20] qdev: introduce qdev_prop_find_bit()

2013-07-15 Thread Igor Mammedov
helper to find a static property corresponding to a specific bit in a specified field. Signed-off-by: Igor Mammedov --- hw/core/qdev-properties.c| 15 +++ include/hw/qdev-properties.h | 13 + 2 files changed, 28 insertions(+) diff --git a/hw/core/qdev-properties.c b/

[Qemu-devel] [PATCH 15/21] target-i386: cpu: substitute '_' with '-' for +-foo feature bits as well

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2c8e710..12d5d29 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1598,13 +1598,13 @@ static void cpu_x86_parse_featurestr(X

[Qemu-devel] [PATCH 16/20] target-i386: set [+-]feature using static properties

2013-07-15 Thread Igor Mammedov
* Define static properties for cpuid feature bits * property names of CPUID feature bits are changed to have "feat-" prefix, so that it would be easy to distinguish them from other properties. * Convert [+-]cpuid_features to a set(QDict) of key, value pairs, where +foo => (f

[Qemu-devel] [PATCH 21/21] target-i386: remove unused *_feature_name arrays

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 99 --- 1 file changed, 99 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f01e496..43fc1c7 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -60,98 +60,7 @@ sta

[Qemu-devel] [PATCH 14/20] target-i386: cpu: convert 'model-id' to static property

2013-07-15 Thread Igor Mammedov
* check "if (model_id == NULL)" looks unnecessary now, since all builtin model-ids are not NULL and user shouldn't be able to set it NULL (cpumodel string parsing code takes care of it, if feature is specified as "model-id=" on command line, its parsing will result in an empty string as value). Si

[Qemu-devel] [PATCH 20/20] target-i386: remove unused *_feature_name arrays

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 99 --- 1 file changed, 99 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f01e496..43fc1c7 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -60,98 +60,7 @@ sta

[Qemu-devel] [PATCH 20/21] target-i386: use static properties to list CPUID features

2013-07-15 Thread Igor Mammedov
- breaks compabilty with previous output format by printing all features in one string with "feat-" prefixes. Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 44 ++-- 1 file changed, 10 insertions(+), 34 deletions(-) diff --git a/target-i386/cpu.c

[Qemu-devel] [PATCH 12/20] target-i386: cpu: convert 'stepping' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 4b8bcf1..c1fe87e 100644 ---

[Qemu-devel] [PATCH 19/21] target-i386: use static properties in check_features_against_host() to print CPUID feature names

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b49af58..f3de420 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -996,24 +996,6 @@ stati

[Qemu-devel] [PATCH 10/20] target-i386: cpu: convert 'family' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 39295ba..68b7694 100644 --- a/targ

[Qemu-devel] [PATCH 19/20] target-i386: use static properties to list CPUID features

2013-07-15 Thread Igor Mammedov
- it breaks compatibility with previous output format by printing all features in one string with "feat-" prefixes and all "_" replaced by "-" Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 44 ++-- 1 file changed, 10 insertions(+), 34 deletions(-)

[Qemu-devel] [PATCH 18/20] target-i386: use static properties in check_features_against_host() to print CPUID feature names

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b49af58..f3de420 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -996,24 +996,6 @@ stati

[Qemu-devel] [PATCH 17/21] target-i386: set [+-]feature using static properties

2013-07-15 Thread Igor Mammedov
* Define static properties for cpuid feature bits * property names of CPUID feature bits are changed to have "feat-" prefix, so that it would be easy to distinguish them from other properties. * Convert [+-]cpuid_features to a set(QDict) of key, value pairs, where +foo => (f

[Qemu-devel] [PATCH 18/21] qdev: introduce QDEV_FIND_PROP_FROM_BIT and qdev_prop_find_bit()

2013-07-15 Thread Igor Mammedov
helper to find a static property corresponding to a specific bit in specified field. Signed-off-by: Igor Mammedov --- hw/core/qdev-properties.c| 15 +++ include/hw/qdev-properties.h | 18 ++ 2 files changed, 33 insertions(+) diff --git a/hw/core/qdev-properties.c

[Qemu-devel] [PATCH 17/20] qdev: introduce QDEV_FIND_PROP_FROM_BIT and qdev_prop_find_bit()

2013-07-15 Thread Igor Mammedov
helper to find a static property corresponding to a specific bit in specified field. Signed-off-by: Igor Mammedov --- hw/core/qdev-properties.c| 15 +++ include/hw/qdev-properties.h | 18 ++ 2 files changed, 33 insertions(+) diff --git a/hw/core/qdev-properties.c

[Qemu-devel] [PATCH 09/20] target-i386: cpu: convert 'xlevel' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 9ca6ab4..39295ba 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1261,22 +1261,6 @@ static void x86_cp

[Qemu-devel] [PATCH 15/20] target-i386: cpu: convert 'tsc-frequency' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2c8e710..04c0a09 100644 --- a/targ

[Qemu-devel] [PATCH 16/21] target-i386: cpu: convert 'tsc-frequency' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 12d5d29..7a3adc1 100644 --- a/targ

[Qemu-devel] [PATCH 04/20] target-i386: convert 'hv_vapic' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: - rebase on top of hv_vapic in X86CPU --- target-i386/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 001c5ff..3013722 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1514,6 +1

[Qemu-devel] [PATCH 08/20] target-i386: cpu: convert 'level' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index edf15ad..9ca6ab4 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1261,22 +1261,6 @@ static void x86_cp

[Qemu-devel] [PATCH 11/20] target-i386: cpu: convert 'model' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 68b7694..4b8bcf1 100644 --- a/target-i

[Qemu-devel] [PATCH 07/20] target-i386: cleanup 'foo=val' feature handling

2013-07-15 Thread Igor Mammedov
features family, model, stepping, level, hv_spinlocks are treated similarly when passed from command line, so it's not necessary to handle each of them individually. Collapse them to one catch-all branch which will treat any not explicitly handled feature in format 'foo=val'. PS: Any unknown featu

[Qemu-devel] [PATCH 01/20] target-i386: Move hyperv_* static globals to X86CPU

2013-07-15 Thread Igor Mammedov
- since hyperv_* helper functions are used only in target-i386/kvm.c move them there as static helpers Requested-by: Eduardo Habkost Signed-off-by: Vadim Rozenfeld Signed-off-by: Igor Mammedov Signed-off-by: Andreas Färber --- target-i386/Makefile.objs | 2 +- target-i386/cpu-qom.h |

[Qemu-devel] [PATCH 13/20] target-i386: cpu: convert 'vendor' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: - afaerber: inline property definition inside of property array. --- target-i386/cpu.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index c1fe87e..2ae3565

[Qemu-devel] [PATCH 06/20] target-i386: cleanup 'foo' feature handling'

2013-07-15 Thread Igor Mammedov
features check, enforce, hv_relaxed and hv_vapic are treated as boolean set to 'on' when passed from command line, so it's not neccessary to handle each of them separetly. Collapse them to one catch-all branch which will treat any feature in format 'foo' as boolean set to 'on'. PS: Any unknown fe

[Qemu-devel] [PATCH 05/20] target-i386: convert 'check' and 'enforce' to static properties

2013-07-15 Thread Igor Mammedov
* additionally convert check_cpuid & enforce_cpuid to bool and make them members of CPUX86State * make 'enforce' feature independent from 'check' Signed-off-by: Igor Mammedov --- v2: - put check_cpuid and enforce_cpuid into X86CPU --- target-i386/cpu-qom.h | 2 ++ target-i386/cpu.c | 13

[Qemu-devel] [PATCH 02/20] target-i386: convert 'hv_spinlocks' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: - rebase on top of hyperv_spinlock_attempts in X86CPU --- target-i386/cpu.c | 48 +++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 14e9c7e..00c2882 10064

[Qemu-devel] [PATCH 03/20] target-i386: convert 'hv_relaxed' to static property

2013-07-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov v2: - rebase on top of hyperv_relaxed_timing in X86CPU --- target-i386/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 00c2882..001c5ff 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -

[Qemu-devel] [PATCH qom-cpu 00/21 v9] target-i386: convert CPU features into properties

2013-07-15 Thread Igor Mammedov
It's reordered and rebased v8 plus CPUID feature bits conversion to properties and cleanups that are removing unused anymore *_feature_name arrays. dynamic => static properties conversion is still making sense as cleanup of initfn(), consolidating all properties in one place and making uniform pro

[Qemu-devel] [PATCH] w32, w64: Add build rule for installer

2013-07-15 Thread Stefan Weil
The new rules in Makefile allow building installers for QEMU on Windows using NSIS, a package which is also available for Linux distributions (so cross builds are possible). The rules for NSIS are in qemu.nsi which also uses two new images. Signed-off-by: Stefan Weil --- This code is used to bu

Re: [Qemu-devel] [PATCH] QEMU-AER: Qemu changes to support AER for VFIO-PCI devices

2013-07-15 Thread Alex Williamson
On Sun, 2013-07-14 at 01:48 -0600, Vijay Mohan Pandarathil wrote: > Add support for error containment when a VFIO device assigned to a KVM > guest encounters an error. This is for PCIe devices/drivers that support AER > functionality. When the host OS is notified of an error in a device either > th

[Qemu-devel] [PATCH] vfio-pci: VGA quirk update

2013-07-15 Thread Alex Williamson
Turns out all the suspicions for AMD devices were correct, everywhere we read a BAR address that the address matches the config space offset, there's full access to PCI config space. Attempt to generalize some helpers to allow quirks to easily be added for mirrors and windows. Also fill in complet

Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option

2013-07-15 Thread Eric Blake
On 07/14/2013 05:34 AM, Paolo Bonzini wrote: >>> Such an incompatible change is not acceptable, as it would break >>> existing configurations. libvirt doesn't specify any suffix and expects >>> it to always mean "MB". >> >> Newer libvirt can be taught to append 'M' when it detects it is talking >>

Re: [Qemu-devel] [PATCHv3] block-migration: efficiently encode zero blocks

2013-07-15 Thread Eric Blake
On 07/15/2013 04:55 AM, Peter Lieven wrote: > this patch adds an efficient encoding for zero blocks by > adding a new flag indiciating a block is completly zero. s/indiciating/indicating/ s/completly/completely/ > > additionally bdrv_write_zeros() is used at the destination > to efficiently writ

Re: [Qemu-devel] [PATCH] ahci: Fix FLUSH command

2013-07-15 Thread Alex Williamson
On Mon, 2013-07-15 at 11:34 +0200, Kevin Wolf wrote: > AHCI couldn't cope with asynchronous commands that aren't doing DMA, it > simply wouldn't complete them. Due to the bug fixed in commit f68ec837, > FLUSH commands would seem to have completed immediately even if they > were still running on the

Re: [Qemu-devel] Buildbots out of disk space

2013-07-15 Thread Palle Lyckegaard
Hi Stefan, the default_solaris11express_sparc buildbot can be removed, since the box is not running (Solaris) anymore. Regards Palle On Mon, 15 Jul 2013, Stefan Hajnoczi wrote: Date: Mon, 15 Jul 2013 06:43:49 From: Stefan Hajnoczi To: Christian Berendt Cc: Stefan Weil , qemu-devel , p

Re: [Qemu-devel] [PATCH V3 0/2] Implement sync modes for drive-backup.

2013-07-15 Thread Paolo Bonzini
Il 15/07/2013 20:01, Ian Main ha scritto: > This patch adds sync modes on top of the work that Stefan Hajnoczi has done. > > These patches apply on kevin/block with > '[PATCH] block: add drive_backup HMP command' also applied. > > Hopefully all is in order as this is my first QEMU patch. Many t

Re: [Qemu-devel] [PATCH 2/2] seccomp: removing unused syscalls gtom whitelist

2013-07-15 Thread Paolo Bonzini
Il 15/07/2013 19:29, Eduardo Otubo ha scritto: > Signed-off-by: Eduardo Otubo > --- > qemu-seccomp.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/qemu-seccomp.c b/qemu-seccomp.c > index 1d5fd71..bfd372a 100644 > --- a/qemu-seccomp.c > +++ b/qemu-seccomp.c > @@ -108,7 +108,6 @@ s

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-15 Thread Paolo Bonzini
Il 15/07/2013 22:15, Alex Bligh ha scritto: > Paolo, > > --On 15 July 2013 16:25:01 +0200 Paolo Bonzini wrote: > > Thanks for the review. > >> Il 06/07/2013 18:24, Alex Bligh ha scritto: >>> Add timed bottom halves. A timed bottom half is a bottom half that >>> will not execute until a given ti

Re: [Qemu-devel] [APPLIED] Merge remote-tracking branch 'quintela/migration.next' into staging

2013-07-15 Thread Anthony Liguori
Peter Maydell writes: > On 15 July 2013 21:39, Anthony Liguori wrote: >> Pulled, thanks. >> >> Regards, >> >> Anthony Liguori > > [etc] > > New notification style or script hiccup? :-) Blek, sorry for the noise. New script hiccup. Regards, Anthony Liguori > > -- PMM

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-15 Thread Paolo Bonzini
Il 15/07/2013 19:49, Ian Main ha scritto: > OK well, I'll explain here my understanding. I apologize if I explain > more than needed but it might be good to get this out there anyway. No problem, it's better to be verbose than to have an extra iteration. > When we do the create with: > > bdrv_i

Re: [Qemu-devel] [APPLIED] Merge remote-tracking branch 'quintela/migration.next' into staging

2013-07-15 Thread Peter Maydell
On 15 July 2013 21:39, Anthony Liguori wrote: > Pulled, thanks. > > Regards, > > Anthony Liguori > > From MAILER-DAEMON Mon Jul 15 20:39:18 2013 > From: Anthony Liguori > To: Anthony Liguori > Cc: Anthony Liguori , qemu-devel@nongnu.org > Subject: Re: [APPLIED] Merge remote-tracking branch 'cohu

Re: [Qemu-devel] [APPLIED] Merge remote-tracking branch 'quintela/migration.next' into staging

2013-07-15 Thread Anthony Liguori
Pulled, thanks. Regards, Anthony Liguori >From MAILER-DAEMON Mon Jul 15 20:39:18 2013 From: Anthony Liguori To: Anthony Liguori Cc: Anthony Liguori , qemu-devel@nongnu.org Subject: Re: [APPLIED] Merge remote-tracking branch 'cohuck/virtio-ccw-upstr' into staging In-reply-to: <1373903207-27085

[Qemu-devel] [PULL 3/3] tcg: Remove temp_buf

2013-07-15 Thread Richard Henderson
All targets have been converted to allocating space for temporaries on the stack. No need to allocate space within the CPU_COMMON block. Signed-off-by: Richard Henderson --- include/exec/cpu-defs.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-d

[Qemu-devel] [PULL 0/3] Queued tcg patches

2013-07-15 Thread Richard Henderson
The following are the outstanding TCG patches (that I know of) that have been previously posted and reviewed. Please pull. r~ The following changes since commit 2562becfc126ed7678c662ee23b7c1fe135d8966: Merge remote-tracking branch 'cohuck/virtio-ccw-upstr' into staging (2013-07-15 14:02:

[Qemu-devel] [PULL 1/3] tcg/aarch64: implement ldst 12bit scaled uimm offset

2013-07-15 Thread Richard Henderson
From: Claudio Fontana implement the 12bit scaled unsigned immediate offset variant of LDR/STR. This improves code size by avoiding the movi + ldst_r for naturally aligned offsets in range. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 32

[Qemu-devel] [PULL 2/3] tcg/aarch64: Implement tlb lookup fast path

2013-07-15 Thread Richard Henderson
From: Jani Kokkonen Supports CONFIG_QEMU_LDST_OPTIMIZATION Signed-off-by: Jani Kokkonen Reviewed-by: Richard Henderson Reviewed-by: Claudio Fontana --- configure| 2 +- include/exec/exec-all.h | 14 +++ tcg/aarch64/tcg-target.c | 224 --

Re: [Qemu-devel] [PATCH] [RFC] aio/async: Add timed bottom-halves

2013-07-15 Thread Alex Bligh
Paolo, --On 15 July 2013 16:25:01 +0200 Paolo Bonzini wrote: Thanks for the review. Il 06/07/2013 18:24, Alex Bligh ha scritto: Add timed bottom halves. A timed bottom half is a bottom half that will not execute until a given time has passed (qemu_bh_schedule_at) or a given interval has pass

Re: [Qemu-devel] [PATCH v5 7/7] pci: Use paravirt interface for pcimem_start and pcimem64_start

2013-07-15 Thread Vasilis Liaskovitis
Hi, 2013/6/26 Hu Tao > From: Vasilis Liaskovitis > > Initialize the 32-bit and 64-bit pci starting offsets from values passed > in by > the qemu paravirt interface QEMU_CFG_PCI_WINDOW. Qemu calculates the > starting > offsets based on initial memory and hotplug-able dimms. > We should drop thi

[Qemu-devel] [PATCH 6/7] s390x/kvm: Reworked/fixed handling of cc3 in kvm_handle_css_inst()

2013-07-15 Thread Christian Borntraeger
From: Thomas Huth Consolidated the setting of the condition code in kvm_handle_css_inst(). For the (unhandled) instructions EQBS and SQBS, we have to return an operation exception instead of cc3. Also removed the is_ioinst() function to avoid decoding the opcode twice. Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH 4/7] s390x/ioinst: Fixed alignment check in SCHM instruction

2013-07-15 Thread Christian Borntraeger
From: Thomas Huth Register 2 only has to be aligned to a 32-byte boundary, not a full page boundary. Signed-off-by: Thomas Huth Acked-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390x/ioinst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s3

[Qemu-devel] [PATCH 3/7] s390x/ioinst: Throw addressing exception when memory_map failed

2013-07-15 Thread Christian Borntraeger
From: Thomas Huth So far, the IO instructions were throwing specification exceptions when there was a problem with accessing the memory. However, the better way is to throw an addressing exception instead. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeg

[Qemu-devel] [PATCH 5/7] s390x/ioinst: Fixed priority of operand exceptions

2013-07-15 Thread Christian Borntraeger
From: Thomas Huth Operand exceptions have a lower priority than specification and address exceptions. Thus the checks for operand exceptions must be done later. Signed-off-by: Thomas Huth Acked-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390x/ioinst.c | 30

[Qemu-devel] [PATCH 0/7] s390 fixes

2013-07-15 Thread Christian Borntraeger
Alex, here is a bunch of fixes/cleanups for s390. Heinz Graalfs (1): s390/sclpconsole: handle char layer busy conditions Thomas Huth (6): s390x/ioinst: Add missing alignment checks for IO instructions s390x/ioinst: Throw addressing exception when memory_map failed s390x/ioinst: Fixed ali

  1   2   3   4   >