[Qemu-devel] [PATCH v3 14/14] ioport: Move portio types to ioport.h

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka This decouples memory.h from ioport.h, concentrating all portio related types in a single header. Signed-off-by: Jan Kiszka --- include/exec/ioport.h | 17 +++-- include/exec/memory.h | 13 - 2 files changed, 11 insertions(+), 19 deletions(-) diff

[Qemu-devel] [PATCH v3 02/14] applesmc: replace register_ioport*

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka Convert over to memory regions to obsolete register_ioport*. Signed-off-by: Jan Kiszka --- hw/misc/applesmc.c | 50 ++ 1 files changed, 38 insertions(+), 12 deletions(-) diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c ind

[Qemu-devel] [PATCH v3 12/14] ioport: Remove unused old dispatching services

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka Remove unused ioport_register and isa_unassign_ioport along with everything that only those services used. Signed-off-by: Jan Kiszka --- include/exec/ioport.h |5 - include/exec/iorange.h | 31 -- include/exec/memory.h |9 -- ioport.c | 238 -

[Qemu-devel] [PATCH v3 07/14] Privatize register_ioport_read/write

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka No more users outside of ioport.c. Signed-off-by: Jan Kiszka --- include/exec/ioport.h |4 ioport.c |8 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/include/exec/ioport.h b/include/exec/ioport.h index fc28350..4953892 100644

[Qemu-devel] [PATCH v3 06/14] vt82c686: replace register_ioport*

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka Convert over to memory regions to obsolete register_ioport*. Signed-off-by: Jan Kiszka --- hw/isa/vt82c686.c | 40 ++-- 1 files changed, 26 insertions(+), 14 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 391d90d..e

[Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka The current ioport dispatcher is a complex beast, mostly due to the need to deal with old portio interface users. But we can overcome it without converting all portio users by embedding the required base address of a MemoryRegionPortio access into that data structure. That remove

[Qemu-devel] [PATCH v3 10/14] xen: Mark fixed platform I/O as unaligned

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka Before switching to the memory core dispatcher, we need to make sure that this pv-device will continue to receive unaligned portio accesses. Signed-off-by: Jan Kiszka --- hw/xen/xen_platform.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/xen/x

[Qemu-devel] [PATCH v3 01/14] adlib: replace register_ioport*

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka Convert over to memory regions to obsolete register_ioport*. CC: malc Signed-off-by: Jan Kiszka --- hw/audio/adlib.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index 6a7d377..8b9b81e 100644

[Qemu-devel] [PATCH v3 05/14] prep: replace register_ioport*

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka Convert over to memory regions to obsolete register_ioport*. Signed-off-by: Jan Kiszka --- hw/ppc/prep.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index 4fdc164..e7689ad 100644 --- a/hw/ppc/pre

[Qemu-devel] [PATCH v3 09/14] vmware-vga: Accept unaligned I/O accesses

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka Before switching to the memory core dispatcher, we need to make sure that this pv-device will continue to receive unaligned portio accesses. Signed-off-by: Jan Kiszka --- hw/display/vmware_vga.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/dis

[Qemu-devel] [PATCH v3 13/14] vmport: Disentangle read handler type from portio

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka In case the latter may vanish one day, make sure the vmport read handler type will remain unaffected. This is also conceptually cleaner. Signed-off-by: Jan Kiszka --- hw/misc/vmport.c |4 ++-- include/hw/i386/pc.h |6 -- 2 files changed, 6 insertions(+), 4 dele

[Qemu-devel] [PATCH v3 04/14] i82374: replace register_ioport*

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka Convert over to memory regions to obsolete register_ioport*. Signed-off-by: Jan Kiszka --- hw/dma/i82374.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c index 6192780..ecda5cb 100644 --- a/hw/dma/i8

[Qemu-devel] [PATCH v3 08/14] isa: implement isa_is_ioport_assigned via memory_region_find

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka Open-code isa_is_ioport_assigned via a memory region lookup. As all IO ports are now directly or indirectly registered via the memory API, this becomes possible and will finally allow us to drop the ioport tables. Signed-off-by: Jan Kiszka --- hw/acpi/piix4.c |9

[Qemu-devel] [PATCH v3 00/14] Refactor portio dispatching

2013-06-21 Thread Jan Kiszka
Changes in v3: - decouple vmport from portio types - removed portio traces from memory.h, consolidating it in ioport.h CC: Jan Kiszka CC: malc Jan Kiszka (14): adlib: replace register_ioport* applesmc: replace register_ioport* wdt_ib700: replace register_ioport* i82374: replace regist

[Qemu-devel] [PATCH v3 03/14] wdt_ib700: replace register_ioport*

2013-06-21 Thread Jan Kiszka
From: Jan Kiszka Convert over to memory regions to obsolete register_ioport*. Signed-off-by: Jan Kiszka --- hw/watchdog/wdt_ib700.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/watchdog/wdt_ib700.c b/hw/watchdog/wdt_ib700.c index d85c894..597a923 1006

[Qemu-devel] [PATCH 2/3] Makefile.target: CONFIG_NO_* variables deleted

2013-06-21 Thread akoskovacs0
From: Ákos Kovács CONFIG_NO_* variables replaced with the lnot logical function Signed-off-by: Ákos Kovács --- Makefile.target | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/Makefile.target b/Makefile.target index ce4391f..180f1ec 100644 --- a/Makefile.t

[Qemu-devel] [PATCH 3/3] default-configs/: CONFIG_GDBSTUB_XML removed

2013-06-21 Thread akoskovacs0
From: Ákos Kovács Makefile.target: Build gdbstub-xml.o only when TARGET_XML_FILES is not empty Signed-off-by: Ákos Kovács --- Makefile.target |2 +- default-configs/arm-linux-user.mak|2 -- default-configs/arm-softmmu.mak |1 - default-co

[Qemu-devel] [PATCH 1/3] rules.mak: New logical functions

2013-06-21 Thread akoskovacs0
From: Ákos Kovács New functions are added: lnot, land, lor, lif, eq, ne, isempty, notempty Example usage: obj-$(call lor,$(CONFIG_LINUX),$(CONFIG_BSD)) += feature.o Signed-off-by: Ákos Kovács --- rules.mak | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --

[Qemu-devel] [PATCH 0/3] Describing what patches do

2013-06-21 Thread akoskovacs0
From: Ákos Kovács Patch 1: Add new logical functions to rules.mak, to eliminate and simplify variables in the Makefiles. Example usage: obj-$(call lor,$(CONFIG_LINUX),$(CONFIG_BSD)) += feature.o Patch 2: Remove CONFIG_GDBSTUB_XML from default_configs/*.mak files and ma

[Qemu-devel] [PATCH v3] configure: Simplify alternate .text segment

2013-06-21 Thread Richard Henderson
For bsd-user and linux-user emulation modes QEMU needs to be linked at an alternate .text segment address, so that it's out of the way of the guest executable. Instead of including modified linker scripts for each arch, just set the address with -Ttext-segment if supported, or by using sed to edit

[Qemu-devel] [PATCH] PPC: Introduce an alias cache for faster lookups

2013-06-21 Thread Alexander Graf
When running QEMU with "-cpu ?" we walk through every alias for every target CPU we know about. This takes several seconds on my very fast host system. Let's introduce a class object cache in the alias table. Using that we don't have to go through the tedious work of finding our target class. Inst

[Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

2013-06-21 Thread Ronnie Sahlberg
Don't assume that SG_IO is always invoked with a simple buffer, check the iovec_count and if it is > 1 then we need to pass an array of iovectors to libiscsi instead of just a plain buffer. Signed-off-by: Ronnie Sahlberg --- block/iscsi.c | 56 +-

[Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi V2

2013-06-21 Thread Ronnie Sahlberg
List, Version 2 of patch to fix the crashbug for virtio and libiscsi Make block/iscsi.c aware that we might be called not with ioh containing a buffer for the data but that it might contain an array of io vectors. Updated to check LIBISCSI_FEATURE_IOVECTOR wether we can use iovectors or not.

Re: [Qemu-devel] [PATCH 3/3] KVM: PPC: enable irqfd

2013-06-21 Thread Alexey Kardashevskiy
On 06/22/2013 03:52 AM, Scott Wood wrote: > On 06/21/2013 04:22:55 AM, Alexey Kardashevskiy wrote: >> Signed-off-by: Alexey Kardashevskiy >> --- >> target-ppc/kvm.c |2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c >> index d6da146..e72c335 10064

Re: [Qemu-devel] KVM call agenda for 2013-06-25

2013-06-21 Thread Alexander Graf
On 20.06.2013, at 14:47, Michael S. Tsirkin wrote: > Please, send any topic that you are interested in covering. VFIO with platform devices Alex

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] e600 core for MPC86xx processors

2013-06-21 Thread Alexander Graf
On 21.06.2013, at 01:16, Alexander Graf wrote: > > On 26.05.2013, at 19:41, Julio Guerra wrote: > >> MPC86xx processors are based on the e600 core, which is not the case >> in qemu where it is based on the 7400 processor. >> >> This patch creates the e600 core and instantiates the MPC86xx >> p

Re: [Qemu-devel] [PATCH 2/2] PPC: Fix GDB read on code area for PPC6xx

2013-06-21 Thread Alexander Graf
On 21.06.2013, at 20:10, Jan Kiszka wrote: > On 2013-06-18 17:34, Alexander Graf wrote: >> >> On 18.06.2013, at 16:53, Fabien Chouteau wrote: >> >>> On PPC 6xx, data and code have separated TLBs. Until now QEMU was only >>> looking at data TLBs, which is not good when GDB wants to read code. >>

Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route

2013-06-21 Thread Benjamin Herrenschmidt
On Fri, 2013-06-21 at 17:10 -0600, Alex Williamson wrote: > MSI-X is rather ugly. As you suggest, we trap accesses to the MSI-X > table. We don't know how many vectors the guest is going to use, so we > incrementally add them by disabling and re-enabling with a new vector > count. The host deci

Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route

2013-06-21 Thread Alex Williamson
On Sat, 2013-06-22 at 08:21 +1000, Benjamin Herrenschmidt wrote: > On Sat, 2013-06-22 at 00:12 +0200, Alexander Graf wrote: > > On 21.06.2013, at 23:54, Benjamin Herrenschmidt wrote: > > > > > On Fri, 2013-06-21 at 15:46 +0200, Alexander Graf wrote: > > >> Not sure. We could just declare a "direct

Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route

2013-06-21 Thread Alexander Graf
On 21.06.2013, at 23:54, Benjamin Herrenschmidt wrote: > On Fri, 2013-06-21 at 15:46 +0200, Alexander Graf wrote: >> Not sure. We could just declare a "direct virq==irq" mode in which >> msi.data == virq == irq. No need for any translation then. > > Maybe. Beware that MSI data is only 16-bit on

Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route

2013-06-21 Thread Benjamin Herrenschmidt
On Sat, 2013-06-22 at 00:12 +0200, Alexander Graf wrote: > On 21.06.2013, at 23:54, Benjamin Herrenschmidt wrote: > > > On Fri, 2013-06-21 at 15:46 +0200, Alexander Graf wrote: > >> Not sure. We could just declare a "direct virq==irq" mode in which > >> msi.data == virq == irq. No need for any tra

Re: [Qemu-devel] [PATCH v2] int128: optimize and add test cases

2013-06-21 Thread Paolo Bonzini
Il 21/06/2013 17:10, Richard Henderson ha scritto: > On 06/21/2013 12:48 AM, Paolo Bonzini wrote: >> --- /dev/null >> +++ b/tests/test-int128.c >> @@ -0,0 +1,212 @@ >> +/* >> + * Test 64x64 -> 128 multiply subroutines > > Cutnpaste test description. Otherwise, > > Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH 2/3] KVM: add kvm_arch_irqchip_add_msi_route

2013-06-21 Thread Benjamin Herrenschmidt
On Fri, 2013-06-21 at 15:46 +0200, Alexander Graf wrote: > Not sure. We could just declare a "direct virq==irq" mode in which > msi.data == virq == irq. No need for any translation then. Maybe. Beware that MSI data is only 16-bit on the wire but we may not care here. One thing I'm not 100% certai

Re: [Qemu-devel] [PATCH 2/2] iscsi: add intelligent has_zero_init check

2013-06-21 Thread Peter Lieven
Von meinem iPhone gesendet Am 21.06.2013 um 22:00 schrieb Paolo Bonzini : > Il 20/06/2013 20:20, Peter Lieven ha scritto: >> +for (lba = 0; lba < iscsilun->num_blocks; lba += 1 << 26) { >> +nb_sectors = 1 << 26; >> +if (lba + nb_sectors > iscsilun->num_blocks) { >> +

Re: [Qemu-devel] [PATCH v2 00/13] Refactor portio dispatching

2013-06-21 Thread Paolo Bonzini
Il 21/06/2013 18:41, Jan Kiszka ha scritto: > First, this series converts the remaining users of register_ioport* to > portio lists. Then it replaces the current portio dispatcher with the > existing one for MMIO and removes several lines of code. This also allows > to build BQL-free portio on top

Re: [Qemu-devel] [PATCH] block: add apparent-size to query-block

2013-06-21 Thread Eric Blake
On 06/21/2013 05:18 PM, Federico Simoncelli wrote: > This patch adds the apparent-size entry to the query-block output. > The value represents the apparent size in bytes of the image, e.g. > file size (including the blocks not yet allocated) or block device > size. > > Signed-off-by: Federico Simo

Re: [Qemu-devel] [PATCH 1/2] iscsi: add support for bdrv_co_is_allocated()

2013-06-21 Thread Paolo Bonzini
Il 21/06/2013 18:06, ronnie sahlberg ha scritto: > Should we really mix co-routines and AIO in the same backend? > > Would it not be better to instead add a new bdrb_aio_is_allocaed and > use non-blocking async calls to libiscsi ? Certainly, but is_allocated's code is not the tidiest. I'm going

Re: [Qemu-devel] [PATCH 2/2] iscsi: add intelligent has_zero_init check

2013-06-21 Thread Paolo Bonzini
Il 20/06/2013 20:20, Peter Lieven ha scritto: > +for (lba = 0; lba < iscsilun->num_blocks; lba += 1 << 26) { > +nb_sectors = 1 << 26; > +if (lba + nb_sectors > iscsilun->num_blocks) { > +nb_sectors = iscsilun->num_blocks - lba; > +} > +nb_sectors *= (

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-06-21 Thread Anthony Liguori
Sage Weil writes: > Hi Anthony, Stefan, Paolo, > > [Resurrecting an old thread, here!] > > On Wed, 10 Apr 2013 Anthony Liguori wrote: > > Has any progress been made toward a generic dynamic linking solution for > block drivers? It is a conceptually simple change, but non-trivial for > anyone u

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-06-21 Thread Alex Bligh
--On 21 June 2013 11:42:34 -0700 Sage Weil wrote: Has any progress been made toward a generic dynamic linking solution for block drivers? It is a conceptually simple change, but non-trivial for anyone unfamiliar with the build system. In the mean time, the inability to dynamically link libr

Re: [Qemu-devel] [RFT PATCH v2] configure: Simplify alternate .text segment

2013-06-21 Thread Richard Henderson
On 06/20/2013 06:15 AM, Ed Maste wrote: > +try_ldflags="-Ttext-segment=$textseg_addr" Two problems: (1) you forgot "-Wl," here. (2) We're running into some strange problem with git submodule init dtc. >From config.log: > cc -Werror -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURC

Re: [Qemu-devel] [Qemu-trivial] [PATCH 00/13] A bunch of little socket + chardev fixes

2013-06-21 Thread Michael Tokarev
21.06.2013 14:38, Gerd Hoffmann wrote: > Hi, > > Here is a colletion of little bugfixes and minor improvements for the > chardev and socket code. Thank you Gerd! You had me busy for some time verifying it all ;) The series looks fine, except: > Gerd Hoffmann (13): > qemu-socket: zero-initi

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-06-21 Thread Sage Weil
Hi Anthony, Stefan, Paolo, [Resurrecting an old thread, here!] On Wed, 10 Apr 2013 Anthony Liguori wrote: > Stefan Hajnoczi writes: > > NACK > > > > I think we're solving the problem at the wrong level. Writing our own > > dynamic linker and adding boilerplate to juggle function pointers > > ev

Re: [Qemu-devel] [Qemu-trivial] [PATCH 09/13] qemu-char: use ChardevBackendKind in in CharDriver

2013-06-21 Thread Michael Tokarev
21.06.2013 14:38, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > qemu-char.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 5751391..1c0903f 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -3127,7 +3127,7 @@ typedef

Re: [Qemu-devel] [Qemu-trivial] [PATCH 03/13] qemu-socket: catch monitor_get_fd failures

2013-06-21 Thread Michael Tokarev
21.06.2013 14:38, Gerd Hoffmann wrote: > case SOCKET_ADDRESS_KIND_FD: > fd = monitor_get_fd(cur_mon, addr->fd->str, errp); > +if (fd < 0) { > +break; > +} > if (callback) { > qemu_set_nonblock(fd); > callback(fd, opaque);

Re: [Qemu-devel] [Qemu-trivial] [PATCH 01/13] qemu-socket: zero-initialize SocketAddress

2013-06-21 Thread Michael Tokarev
21.06.2013 14:38, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > util/qemu-sockets.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c > index fdd8dc4..364bd8c 100644 > --- a/util/qemu-sockets.c > +++ b/util/qemu-so

Re: [Qemu-devel] [PATCH v2 0/8] memory: remove old_portio usage

2013-06-21 Thread Jan Kiszka
On 2013-06-18 20:09, Hervé Poussineau wrote: > Jan Kiszka a écrit : >> On 2013-06-17 22:39, Hervé Poussineau wrote: >>> Jan Kiszka a écrit : On 2013-06-17 09:32, Paolo Bonzini wrote: > Il 16/06/2013 20:20, Hervé Poussineau ha scritto: >> Hervé Poussineau a écrit : >>> These propose

Re: [Qemu-devel] [PATCH 2/2] PPC: Fix GDB read on code area for PPC6xx

2013-06-21 Thread Jan Kiszka
On 2013-06-18 17:34, Alexander Graf wrote: > > On 18.06.2013, at 16:53, Fabien Chouteau wrote: > >> On PPC 6xx, data and code have separated TLBs. Until now QEMU was only >> looking at data TLBs, which is not good when GDB wants to read code. >> >> This patch adds a second call to get_physical_ad

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add signed*signed check to [u]int128_t test

2013-06-21 Thread Michael Tokarev
21.06.2013 17:01, Peter Maydell wrote: > clang 3.8 with -fsanitize=undefined will fail to link code containing an > int128_t * int128_t multiply (http://llvm.org/bugs/show_bug.cgi?id=16404) > so add this to our configure test for whether [u]int128_t are usable. I accept it as granted (with the fix

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: pass include directives to dtc via CPPFLAGS, not CFLAGS

2013-06-21 Thread Michael Tokarev
21.06.2013 17:00, Peter Maydell wrote: > The dtc submodule's makefile expects -I include directives to be > in CPPFLAGS, not CFLAGS. Getting this wrong meant that the include > directive would not be applied when generating the dependency .d > files. This in turn meant that we couldn't build libfdt

Re: [Qemu-devel] [PATCH 3/3] KVM: PPC: enable irqfd

2013-06-21 Thread Scott Wood
On 06/21/2013 04:22:55 AM, Alexey Kardashevskiy wrote: Signed-off-by: Alexey Kardashevskiy --- target-ppc/kvm.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index d6da146..e72c335 100644 --- a/target-ppc/kvm.c +++ b/target-ppc/kvm.c @@ -1973,6 +19

[Qemu-devel] [PATCH v2 05/13] prep: replace register_ioport*

2013-06-21 Thread Jan Kiszka
Convert over to memory regions to obsolete register_ioport*. Signed-off-by: Jan Kiszka --- hw/ppc/prep.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index 4fdc164..e7689ad 100644 --- a/hw/ppc/prep.c +++ b/hw/ppc/pr

Re: [Qemu-devel] [PATCH 1/2] iscsi: add support for bdrv_co_is_allocated()

2013-06-21 Thread Peter Lieven
Am 21.06.2013 19:13, schrieb ronnie sahlberg: > On Fri, Jun 21, 2013 at 10:06 AM, Peter Lieven wrote: >> Am 21.06.2013 18:31, schrieb Paolo Bonzini: >>> Il 21/06/2013 13:07, Kevin Wolf ha scritto: Note that you're blocking here. The preferred way would be something involving a yi

[Qemu-devel] [PATCH v2 11/13] ioport: Switch dispatching to memory core layer

2013-06-21 Thread Jan Kiszka
The current ioport dispatcher is a complex beast, mostly due to the need to deal with old portio interface users. But we can overcome it without converting all portio users by embedding the required base address of a MemoryRegionPortio access into that data structure. That removes the need to have

Re: [Qemu-devel] [PATCH 1/2] iscsi: add support for bdrv_co_is_allocated()

2013-06-21 Thread ronnie sahlberg
On Fri, Jun 21, 2013 at 10:06 AM, Peter Lieven wrote: > Am 21.06.2013 18:31, schrieb Paolo Bonzini: >> Il 21/06/2013 13:07, Kevin Wolf ha scritto: >>> Note that you're blocking here. The preferred way would be something >>> involving a yield from the coroutine and a reenter as soon as all

[Qemu-devel] [PATCH v2 04/13] i82374: replace register_ioport*

2013-06-21 Thread Jan Kiszka
Convert over to memory regions to obsolete register_ioport*. Signed-off-by: Jan Kiszka --- hw/dma/i82374.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c index 6192780..ecda5cb 100644 --- a/hw/dma/i82374.c +++ b/hw/dma

[Qemu-devel] [PATCH v2 12/13] ioport: Remove unused old dispatching services

2013-06-21 Thread Jan Kiszka
Remove unused ioport_register and isa_unassign_ioport along with everything that only those services used. Signed-off-by: Jan Kiszka --- include/exec/ioport.h |5 - include/exec/iorange.h | 31 -- include/exec/memory.h |9 -- ioport.c | 238

Re: [Qemu-devel] [PATCH 1/2] iscsi: add support for bdrv_co_is_allocated()

2013-06-21 Thread Peter Lieven
Am 21.06.2013 18:31, schrieb Paolo Bonzini: > Il 21/06/2013 13:07, Kevin Wolf ha scritto: >> Note that you're blocking here. The preferred way would be something >> involving a yield from the coroutine and a reenter as soon as all >> requests are done. Maybe a CoRwLock does what you nee

[Qemu-devel] [PATCH v2 02/13] applesmc: replace register_ioport*

2013-06-21 Thread Jan Kiszka
Convert over to memory regions to obsolete register_ioport*. Signed-off-by: Jan Kiszka --- hw/misc/applesmc.c | 50 ++ 1 files changed, 38 insertions(+), 12 deletions(-) diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 46f4fbd..83468dc

[Qemu-devel] [PATCH v2 08/13] isa: implement isa_is_ioport_assigned via memory_region_find

2013-06-21 Thread Jan Kiszka
Open-code isa_is_ioport_assigned via a memory region lookup. As all IO ports are now directly or indirectly registered via the memory API, this becomes possible and will finally allow us to drop the ioport tables. Signed-off-by: Jan Kiszka --- hw/acpi/piix4.c |9 + hw/isa/lpc_i

[Qemu-devel] [PATCH v2 06/13] vt82c686: replace register_ioport*

2013-06-21 Thread Jan Kiszka
Convert over to memory regions to obsolete register_ioport*. Signed-off-by: Jan Kiszka --- hw/isa/vt82c686.c | 40 ++-- 1 files changed, 26 insertions(+), 14 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 391d90d..e5cd4cd 100644 --- a

Re: [Qemu-devel] [PATCH] Graphics: Switch to 800x600x32 as default mode

2013-06-21 Thread Peter Maydell
On 21 June 2013 17:07, Mark Cave-Ayland wrote: > It seems to be that several OS images in my OpenBIOS test suite are > expecting either an 8-bit or 32-bit display depth. For example Darwin and > older versions of HelenOS will freeze if they don't have a 8bpp or 32bpp > display (and newer versions

[Qemu-devel] [PATCH v2 13/13] ioport: Move IOPortRead/WriteFunc typedefs to memory.h

2013-06-21 Thread Jan Kiszka
Move the function types required for MemoryRegionPortio to memory.h. This allows to let ioport.h depend on memory.h, which is more consistent instead than the other way around. Signed-off-by: Jan Kiszka --- include/exec/ioport.h |8 +--- include/exec/memory.h |4 +++- 2 files changed

[Qemu-devel] [PATCH v2 01/13] adlib: replace register_ioport*

2013-06-21 Thread Jan Kiszka
Convert over to memory regions to obsolete register_ioport*. CC: malc Signed-off-by: Jan Kiszka --- hw/audio/adlib.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index 6a7d377..8b9b81e 100644 --- a/hw/audio/adli

[Qemu-devel] [PATCH v2 07/13] Privatize register_ioport_read/write

2013-06-21 Thread Jan Kiszka
No more users outside of ioport.c. Signed-off-by: Jan Kiszka --- include/exec/ioport.h |4 ioport.c |8 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/include/exec/ioport.h b/include/exec/ioport.h index fc28350..4953892 100644 --- a/include/exec

[Qemu-devel] [PATCH v2 00/13] Refactor portio dispatching

2013-06-21 Thread Jan Kiszka
First, this series converts the remaining users of register_ioport* to portio lists. Then it replaces the current portio dispatcher with the existing one for MMIO and removes several lines of code. This also allows to build BQL-free portio on top once we enhance the memory layer accordingly. Chang

[Qemu-devel] [PATCH v2 03/13] wdt_ib700: replace register_ioport*

2013-06-21 Thread Jan Kiszka
Convert over to memory regions to obsolete register_ioport*. Signed-off-by: Jan Kiszka --- hw/watchdog/wdt_ib700.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/watchdog/wdt_ib700.c b/hw/watchdog/wdt_ib700.c index d85c894..597a923 100644 --- a/hw/watchdo

[Qemu-devel] [PATCH v2 10/13] xen: Mark fixed platform I/O as unaligned

2013-06-21 Thread Jan Kiszka
Before switching to the memory core dispatcher, we need to make sure that this pv-device will continue to receive unaligned portio accesses. Signed-off-by: Jan Kiszka --- hw/xen/xen_platform.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/xen/xen_platform.c b/hw/

[Qemu-devel] [PATCH v2 09/13] vmware-vga: Accept unaligned I/O accesses

2013-06-21 Thread Jan Kiszka
Before switching to the memory core dispatcher, we need to make sure that this pv-device will continue to receive unaligned portio accesses. Signed-off-by: Jan Kiszka --- hw/display/vmware_vga.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/display/vmware_vga.c b

Re: [Qemu-devel] [PATCH 1/3] qapi.py: Move common code to evaluate()

2013-06-21 Thread mdroth
On Wed, Jun 19, 2013 at 06:28:05PM +0200, Kevin Wolf wrote: > Don't duplicate more code than is really necessary. > > Signed-off-by: Kevin Wolf > --- > scripts/qapi.py | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) > > diff --git a/scripts/qapi.py b/scripts/q

Re: [Qemu-devel] [PATCH V2] PPC: Add dump_mmu() for 6xx

2013-06-21 Thread Alexander Graf
On 21.06.2013, at 15:26, Fabien Chouteau wrote: > "(qemu) info tlb" is a very useful tool for debugging, so I implemented > the missing 6xx version. > > Signed-off-by: Fabien Chouteau Thanks, applied to ppc-next. It seems like a bunch of this could be shared with the hash32 MMU model. Alex

Re: [Qemu-devel] [PATCH 1/2] iscsi: add support for bdrv_co_is_allocated()

2013-06-21 Thread Paolo Bonzini
Il 21/06/2013 13:07, Kevin Wolf ha scritto: >>> > > Note that you're blocking here. The preferred way would be something >>> > > involving a yield from the coroutine and a reenter as soon as all >>> > > requests are done. Maybe a CoRwLock does what you need? >> > Is there a document how to use it?

[Qemu-devel] [PATCH] block: add apparent-size to query-block

2013-06-21 Thread Federico Simoncelli
This patch adds the apparent-size entry to the query-block output. The value represents the apparent size in bytes of the image, e.g. file size (including the blocks not yet allocated) or block device size. Signed-off-by: Federico Simoncelli --- block/qapi.c |3 ++- qapi-schema.json |

Re: [Qemu-devel] QEMU Memory subsystem

2013-06-21 Thread Lluís Vilanova
Basim Baig writes: > Hello, > I am currently working on a project where I aim to log every memory access > made > by a virtual machine running inside of QEMU (for analyzing kernel behavior). > My > initial approach is to possibly hook into the QEMU mmu implementation and find > the place where t

Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning

2013-06-21 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Graphics: Switch to 800x600x32 as default mode

2013-06-21 Thread Mark Cave-Ayland
On 20/06/13 13:23, Alexander Graf wrote: On 20.06.2013, at 14:19, Peter Maydell wrote: On 20 June 2013 13:09, Alexander Graf wrote: We have stayed at 800x600x15 as default graphics mode for the last 9 years. If there ever was a reason to be there, surely nobody remembers it. However, recent

Re: [Qemu-devel] [PATCH 1/2] iscsi: add support for bdrv_co_is_allocated()

2013-06-21 Thread ronnie sahlberg
Should we really mix co-routines and AIO in the same backend? Would it not be better to instead add a new bdrb_aio_is_allocaed and use non-blocking async calls to libiscsi ? On Fri, Jun 21, 2013 at 2:18 AM, Kevin Wolf wrote: > Am 20.06.2013 um 20:20 hat Peter Lieven geschrieben: >> Signed-off-b

[Qemu-devel] [PATCH v2 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

2013-06-21 Thread Kevin Wolf
We don't have to duplicate the definition any more now that we may refer to a type instead. Signed-off-by: Kevin Wolf --- qapi-schema.json | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index a80ee40..54fbeef 100644 --- a/q

[Qemu-devel] [PATCH v2 2/3] qapi.py: Allow top-level type reference for command definitions

2013-06-21 Thread Kevin Wolf
If 'data' for a command definition isn't a dict, but a string, it is taken as a (struct) type name and the fields of this struct are directly used as parameters. This is useful for transactionable commands that can use the same type definition for both the transaction action and the arguments of t

[Qemu-devel] [PATCH v2 0/3] qapi: Top-level type reference for command definitions

2013-06-21 Thread Kevin Wolf
v2: - Updated documentation in patch 3 Kevin Wolf (3): qapi.py: Move common code to evaluate() qapi.py: Allow top-level type reference for command definitions qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync qapi-schema.json | 14 ++ scripts/qapi.py | 43 +

[Qemu-devel] [PATCH v2 1/3] qapi.py: Move common code to evaluate()

2013-06-21 Thread Kevin Wolf
Don't duplicate more code than is really necessary. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- scripts/qapi.py | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 02ad668..3a64769 100644 --- a/scripts/

Re: [Qemu-devel] [PATCH] hmp: Make "info block" output more readable

2013-06-21 Thread Luiz Capitulino
On Fri, 21 Jun 2013 10:43:19 -0500 Anthony Liguori wrote: > Kevin Wolf writes: > > > HMP is meant for humans and you should notice it. > > > > This changes the output format to use a bit more space to display the > > information more readable and leaves out irrelevant information (e.g. > > ment

Re: [Qemu-devel] Adding a persistent writeback cache to qemu

2013-06-21 Thread Sage Weil
On Fri, 21 Jun 2013, Stefan Hajnoczi wrote: > >> but if there's really a case for it with performance profiles then I > >> guess it would be necessary. But we should definitely get feedback from > >> the Ceph folks too. > > > > > > The specific problem we are trying to solve (in case that's not >

Re: [Qemu-devel] [PATCH] hmp: Make "info block" output more readable

2013-06-21 Thread Anthony Liguori
Kevin Wolf writes: > HMP is meant for humans and you should notice it. > > This changes the output format to use a bit more space to display the > information more readable and leaves out irrelevant information (e.g. > mention only that an image is encrypted, but not when it's not; display > I/O

Re: [Qemu-devel] Adding a persistent writeback cache to qemu

2013-06-21 Thread Sage Weil
On Fri, 21 Jun 2013, Alex Bligh wrote: > Sage, > > --On 20 June 2013 08:58:19 -0700 Sage Weil wrote: > > > > I'd like to hear from Ceph folks what their position on kernel rbd vs > > > librados is. Why one do they recommend for QEMU guests and what are the > > > pros/cons? > > > > I agree that

Re: [Qemu-devel] [PATCH v2] virtio-rng: Fix crash with non-default backend

2013-06-21 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3 00/16] -boot and -no-fd-bootchk fixes

2013-06-21 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH V2 4/9] NUMA: parse guest numa nodes memory policy

2013-06-21 Thread Bandan Das
Wanlong Gao writes: > The memory policy setting format is like: > mem-policy={membind|interleave|preferred},mem-hostnode=[+|!]{all|N-N} > And we are adding this setting as a suboption of "-numa", > the memory policy then can be set like following: > -numa node,nodeid=0,mem=1024,cpus=0,mem-policy

Re: [Qemu-devel] [PATCH 2/2] monitor: support sub commands in auto completion

2013-06-21 Thread Luiz Capitulino
On Fri, 21 Jun 2013 14:37:38 +0800 Wenchao Xia wrote: > This patch allow auot completion work normal in sub command case, > "info block [DEVICE]" can auto complete now, by re-enter the completion > function. Also, original "info" is treated as a special case, now it is > treated as a sub command

Re: [Qemu-devel] [PATCH 1/2] monitor: discard global variable in auto completion functions

2013-06-21 Thread Luiz Capitulino
On Fri, 21 Jun 2013 14:37:37 +0800 Wenchao Xia wrote: > In monitor_find_completion() and related functions, Global variable > *mon_cmds is not used any more, make them reenterable safely. > *cur_mon is also not used now. *info_cmds is still there, but soon > will be removed by a new way of sub co

Re: [Qemu-devel] Adding a persistent writeback cache to qemu

2013-06-21 Thread Liu Yuan
On 06/20/2013 11:58 PM, Sage Weil wrote: > On Thu, 20 Jun 2013, Stefan Hajnoczi wrote: >>> The concrete problem here is that flashcache/dm-cache/bcache don't >>> work with the rbd (librbd) driver, as flashcache/dm-cache/bcache >>> cache access to block devices (in the host layer), and with rbd >>>

Re: [Qemu-devel] [PATCH] configure: Add signed*signed check to [u]int128_t test

2013-06-21 Thread Peter Maydell
On 21 June 2013 14:01, Peter Maydell wrote: > clang 3.8 with -fsanitize=undefined will fail to link code containing an > int128_t * int128_t multiply (http://llvm.org/bugs/show_bug.cgi?id=16404) > so add this to our configure test for whether [u]int128_t are usable. I meant "clang 3.3" here -- ca

Re: [Qemu-devel] [PATCH] configure: Add signed*signed check to [u]int128_t test

2013-06-21 Thread Richard Henderson
On 06/21/2013 06:01 AM, Peter Maydell wrote: > clang 3.8 with -fsanitize=undefined will fail to link code containing an > int128_t * int128_t multiply (http://llvm.org/bugs/show_bug.cgi?id=16404) > so add this to our configure test for whether [u]int128_t are usable. > > Signed-off-by: Peter Mayde

Re: [Qemu-devel] [PATCH v2] int128: optimize and add test cases

2013-06-21 Thread Richard Henderson
On 06/21/2013 12:48 AM, Paolo Bonzini wrote: > --- /dev/null > +++ b/tests/test-int128.c > @@ -0,0 +1,212 @@ > +/* > + * Test 64x64 -> 128 multiply subroutines Cutnpaste test description. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

2013-06-21 Thread Luiz Capitulino
On Fri, 21 Jun 2013 11:31:28 +0100 Eric Blake wrote: > On 06/19/2013 05:28 PM, Kevin Wolf wrote: > > We don't have to duplicate the definition any more now that we may refer > > to a type instead. > > > > Signed-off-by: Kevin Wolf > > --- > > qapi-schema.json | 3 +-- > > 1 file changed, 1 ins

Re: [Qemu-devel] [PATCH v3] vl.c: Support multiple CPU ranges on -numa option

2013-06-21 Thread Bandan Das
Wanlong Gao writes: > On 06/21/2013 12:02 AM, Bandan Das wrote: >> Paolo Bonzini writes: >> >>> Il 20/06/2013 15:26, Eduardo Habkost ha scritto: On Thu, Jun 20, 2013 at 11:52:42AM +0200, Paolo Bonzini wrote: > Il 20/06/2013 11:30, Igor Mammedov ha scritto: So, basically th

[Qemu-devel] Backport of modern qemu rbd driver to qemu 1.0 + Precise packaging

2013-06-21 Thread Alex Bligh
I've backported the modern (qemu 1.5) rbd driver to qemu 1.0 (for anyone interested). This is designed for people who are conservative in hypervisor version, but like more bleeding edge storage. The main thing this adds is asynchronous flush to rbd, plus automatic control of rbd caching behaviour.

Re: [Qemu-devel] [PATCH] hmp: Make "info block" output more readable

2013-06-21 Thread Luiz Capitulino
On Fri, 21 Jun 2013 11:07:51 +0200 Kevin Wolf wrote: > Am 21.06.2013 um 05:27 hat Luiz Capitulino geschrieben: > > On Wed, 19 Jun 2013 16:10:55 +0200 > > Kevin Wolf wrote: > > > > > HMP is meant for humans and you should notice it. > > > > > > This changes the output format to use a bit more s

Re: [Qemu-devel] Adding a persistent writeback cache to qemu

2013-06-21 Thread Alex Bligh
Stefan, --On 21 June 2013 14:55:20 +0200 Stefan Hajnoczi wrote: I understand the limitations with kernel block devices - their setup/teardown is an extra step outside QEMU and privileges need to be managed. That basically means you need to use a management tool like libvirt to make it usable.

Re: [Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi

2013-06-21 Thread ronnie sahlberg
I can add the checks and resubmit. On Fri, Jun 21, 2013 at 12:38 AM, Paolo Bonzini wrote: > Il 21/06/2013 04:32, Ronnie Sahlberg ha scritto: >> Stefan, List >> >> Please find a patch that fixes the crashes for using virtio with libiscsi. >> The problem was that block/iscsi.c always assumed we got

  1   2   >