[Qemu-devel] [RFT PATCH v1 18/30] pci-bridge/pci_bridge_dev: Don't use DO_UPCAST

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Just use the defined PCI_DEVICE cast macro. Signed-off-by: Peter Crosthwaite --- hw/pci-bridge/pci_bridge_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c index 971b432..c845f38 10

[Qemu-devel] [RFT PATCH v1 17/30] pci/*: QOM casting sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Use standard QOM cast macro. Remove usages of DO_UPCAST, container_of() and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/pci/pci-hotplug.c | 18 ++ hw/pci/pci.c | 17 + hw/pci/pcie.c| 4 ++-- hw/pci

[Qemu-devel] [RFT PATCH v1 16/30] isa/*: QOM casting sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Use standard QOM cast macros. Remove usage of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/isa/i82378.c | 8 hw/isa/lpc_ich9.c | 6 +++--- hw/isa/piix4.c| 4 ++-- hw/isa/vt82c686.c | 14 +++--- 4 files chang

[Qemu-devel] [RFT PATCH v1 14/30] misc/ivshmem: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/misc/ivshmem.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/

[Qemu-devel] [RFT PATCH v1 15/30] xen/xen_platform: QOM casting sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/xen/xen_platform.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/hw/xen/xen_pl

[Qemu-devel] [RFT PATCH v1 13/30] virtio/vmware_vga: QOM casting sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style casting. Signed-off-by: Peter Crosthwaite --- hw/display/vmware_vga.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/display/vmware_vga.c b/hw/d

Re: [Qemu-devel] [PATCH qom-cpu 47/59] spapr: Abstract spapr_fix_cpu_dt() with qemu_for_each_cpu()

2013-06-10 Thread David Gibson
On Sun, Jun 09, 2013 at 09:13:14PM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber These days, spapr patches should be CCed to Alexey, instead of me. Though, fwiw, Reviewed-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT gibs

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Michael S. Tsirkin
On Tue, Jun 11, 2013 at 07:33:02AM +0200, Gerd Hoffmann wrote: > Hi, > > >* Use of glib's GArray makes it much easier to build > > up tables in code without need for iasl and code patching > > Nice. > > > Design: > > - each bus gets assigned a number 0-255 > > - genera

[Qemu-devel] [RFT PATCH v1 12/30] virtio/virtio-pci: QOM casting sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Use standard QOM cast macro. Remove usages of container_of() and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/virtio/virtio-pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci

[Qemu-devel] [RFT PATCH v1 11/30] misc/pci-testdev: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/misc/pci-testdev.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/misc/pci-testdev.c b/hw/misc/

[Qemu-devel] [RFT PATCH v1 10/30] acpi/piix4: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/acpi/piix4.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/p

[Qemu-devel] [RFT PATCH v1 09/30] ide/piix: QOM casting sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Use standard QOM cast macro. Remove usage of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/ide/piix.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index bf2856f..d0fdea3 100

[Qemu-devel] [RFT PATCH v1 08/30] ide/ich: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/ide/ahci.h | 5 + hw/ide/ich.c | 10 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/ide/ahci.h

[Qemu-devel] [RFT PATCH v1 07/30] scsi/esp-pci: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/scsi/esp-pci.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-p

[Qemu-devel] [RFT PATCH v1 06/30] scsi/megasas: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/scsi/megasas.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/m

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Michael S. Tsirkin
On Mon, Jun 10, 2013 at 08:25:15PM -0500, Anthony Liguori wrote: > > I do understand your desire to pass this stuff as parameters, but I > > really don't see it as feasible. I'm hoping that if you can write up > > some examples with specifics you'll either enlighten me or you'll see > > the diffic

[Qemu-devel] [RFT PATCH v1 05/30] scsi/lsi53c895a: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/scsi/lsi53c895a.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/hw/scsi/lsi53c89

[Qemu-devel] [RFT PATCH v1 04/30] usb/hcd-xhci: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/usb/hcd-xhci.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/

[Qemu-devel] [RFT PATCH v1 03/30] net/pcnet-pci: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/net/pcnet-pci.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/net/pcnet-pci.c b/hw/net/pcne

[Qemu-devel] [RFT PATCH v1 02/30] net/rtl8139: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/net/rtl8139.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/net/rtl8139.c b/hw

[Qemu-devel] [RFT PATCH v1 01/30] net/e1000: QOM Upcast Sweep

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/net/e1000.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000

[Qemu-devel] [RFT PATCH v1 00/30] PCI: Cleanup legacy casts in device land

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite There are a number of different cast implementations from various stages of QEMU development out in device model land. This series cleans up the ones involving TYPE_PCI_DEVICE to consistently use proper QOM casts for both up and down casts. Some were easy, some needed QOM

Re: [Qemu-devel] [PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-10 Thread Frederic Konrad
On 10/06/2013 19:00, Michael S. Tsirkin wrote: On Mon, Jun 10, 2013 at 11:53:04AM +0200, fred.kon...@greensocs.com wrote: From: KONRAD Frederic This fix a bug with scsi hotplug on virtio-scsi-pci: As virtio-scsi-pci doesn't have any scsi bus, we need to forward scsi-hot-add to the virtio-scsi

Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

2013-06-10 Thread Gerd Hoffmann
Hi, >> +static QEMUCursor *ptr_cursor; >> +static pixman_image_t *ptr_image; >> +static intptr_refresh; >> +static intpx, py, pw, ph; >> +static intmx, my, mon; >> + >> +/* options */ >> +static i

Re: [Qemu-devel] [PATCH] console: nicer initial screen

2013-06-10 Thread Gerd Hoffmann
Hi, >> This patch adds a text line to the in initial DisplaySurface, notifying >> the user that the display isn't initialized yet by the guest. > Dunno if I said this in the previous posting, but what about just > blitting an image? Why? And which one? > This text isn't internationalized. W

Re: [Qemu-devel] [PATCH] spice: Add -spice disable-agent-file-transfer cmdline option (rhbz#961850)

2013-06-10 Thread Gerd Hoffmann
On 06/08/13 15:37, Hans de Goede wrote: > Signed-off-by: Hans de Goede Patch added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Gerd Hoffmann
Hi, >* Use of glib's GArray makes it much easier to build > up tables in code without need for iasl and code patching Nice. > Design: > - each bus gets assigned a number 0-255 > - generated ACPI code writes this number > to a new BSEL register, then uses existing

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Michael S. Tsirkin
On Mon, Jun 10, 2013 at 01:58:41PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > This adds support for device hotplug behind > > pci bridges. Bridge devices themselves need > > to be pre-configured on qemu command line. > > > > One of the goals of this project was to > > demo

[Qemu-devel] [PATCH 5/5] sd: pass bool parameter for sd_init

2013-06-10 Thread liguang
Signed-off-by: liguang --- hw/sd/milkymist-memcard.c |2 +- hw/sd/omap_mmc.c |4 ++-- hw/sd/pl181.c |2 +- hw/sd/pxa2xx_mmci.c |2 +- hw/sd/sdhci.c |2 +- hw/sd/ssi-sd.c|2 +- 6 files changed, 7 insertions(+), 7 deletions(

[Qemu-devel] [PATCH 4/5] memory: use '=' instead of '|=' for memory_region_update_pending

2013-06-10 Thread liguang
because memory_region_update_pending is bool Signed-off-by: liguang --- memory.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/memory.c b/memory.c index 5cb8f4a..d99eecd 100644 --- a/memory.c +++ b/memory.c @@ -1114,7 +1114,7 @@ void memory_region_set_

[Qemu-devel] [PATCH 3/5] qemu-char: pass bool parameter for qemu_opt_get_bool

2013-06-10 Thread liguang
Signed-off-by: liguang --- qemu-char.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index d04b429..8092eb8 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2767,10 +2767,10 @@ static CharDriverState *qemu_chr_open_socket(QemuOpts *opts)

[Qemu-devel] [PATCH 2/5] vnc: pass bool parameter for vnc_listen_read

2013-06-10 Thread liguang
Signed-off-by: liguang --- ui/vnc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 7d22660..1a8b940 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2889,13 +2889,13 @@ static void vnc_listen_read(void *opaque, bool websocket) static void vnc_lis

[Qemu-devel] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect

2013-06-10 Thread liguang
type last parameter of vnc_connect if bool, so pass 'false' instead of '0' for it. Signed-off-by: liguang --- ui/vnc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index dfc7459..7d22660 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3283,7 +3283,7 @@

Re: [Qemu-devel] [PATCH] curl: refuse to open URL from HTTP server without range support

2013-06-10 Thread Fam Zheng
On Mon, Jun 10, 2013 at 5:21 PM, Stefan Hajnoczi wrote: > On Sun, Jun 09, 2013 at 10:34:54AM +0800, Fam Zheng wrote: >> @@ -110,14 +111,14 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, >> int action, >> return 0; >> } >> >> -static size_t curl_size_cb(void *ptr, size_t size, size

Re: [Qemu-devel] [PATCH qom-cpu 25/59] cpu: Change qemu_init_vcpu() argument to CPUState

2013-06-10 Thread li guang
在 2013-06-09日的 21:12 +0200,Andreas Färber写道: > This allows to move the call to CPUState's realizefn. > Therefore move the stub into libqemustub.a. > > Signed-off-by: Andreas Färber [...] > static void alpha_cpu_realizefn(DeviceState *dev, Error **errp) > { > -AlphaCPU *cpu = ALPHA_CPU(dev)

Re: [Qemu-devel] [PATCH 1/2] device_tree: Fix build with latest libfdt

2013-06-10 Thread Peter Crosthwaite
Hi Hans, On Fri, Jun 7, 2013 at 12:39 AM, Hans de Goede wrote: > We override libfdt_env.h with our own copy, and the latest libfdt expects > libfdt_env.h to define fdt##_t types. > This discussion is open on list, and AFAICT the consensus is to drop qemus libfdt_env.h altogether. QEMU should not

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-10 Thread Qiao Nuohan
On 06/10/2013 08:54 PM, Luiz Capitulino wrote: On Mon, 10 Jun 2013 10:15:35 +0800 Qiao Nuohan wrote: On 06/05/2013 10:15 AM, Luiz Capitulino wrote: I can review it until the end of this week. If this series is adding a new argument (which I believe is what it does) then there's only two ways

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Kevin O'Connor
On Mon, Jun 10, 2013 at 08:25:15PM -0500, Anthony Liguori wrote: > On Mon, Jun 10, 2013 at 8:19 PM, Kevin O'Connor wrote: > > I do understand your desire to pass this stuff as parameters, but I > > really don't see it as feasible. I'm hoping that if you can write up > > some examples with specifi

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Jordan Justen
On Mon, Jun 10, 2013 at 6:03 PM, Anthony Liguori wrote: > On Mon, Jun 10, 2013 at 7:28 PM, Jordan Justen wrote: >> It couldn't hurt if more people that actually care about this spoke up >> on edk2-devel about the issue, or perhaps within a UEFI working group. >> Because, I know that they've stopp

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Hi Kevin, On Mon, Jun 10, 2013 at 8:19 PM, Kevin O'Connor wrote: > On Mon, Jun 10, 2013 at 07:51:55PM -0500, Anthony Liguori wrote: >> I think that we can pretty much touch a table once pulling all of the >> info from QOM and then from a SeaBIOS point of view, never have to >> touch it again. > >

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Kevin O'Connor
On Mon, Jun 10, 2013 at 07:51:55PM -0500, Anthony Liguori wrote: > I think that we can pretty much touch a table once pulling all of the > info from QOM and then from a SeaBIOS point of view, never have to > touch it again. Thanks. I do think it would help if you could go through the details of a

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Hi Jordan, On Mon, Jun 10, 2013 at 7:28 PM, Jordan Justen wrote: > On Mon, Jun 10, 2013 at 2:45 PM, Anthony Liguori > wrote: >> OVMF is proprietary. > > I don't agree that not-OSI means proprietary. I call it blue if that makes you all feel better :-) But no matter what the word we use it, th

[Qemu-devel] [PATCH v2 5/5] intc/xilinx_intc: Dont lower IRQ when HIE cleared

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite This is a little strange. It is lowering the parent IRQ pin on input when HIE is cleared. There is no such behaviour in the real hardware. ISR changes based on interrupt pin state are already guarded on HIE being set. So we can just delete this if in its entirety. Signed

[Qemu-devel] [PATCH v2 4/5] intc/xilinx_intc: Inhibit write to ISR when HIE

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite When the Hardware Interrupt Enable (HIE) bit is set, software cannot change ISR. Add write guard accordingly. Signed-off-by: Peter Crosthwaite --- hw/intc/xilinx_intc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc

[Qemu-devel] [PATCH v2 3/5] intc/xilinx_intc: Handle level interrupt retriggering

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Acking a level sensitive interrupt should have no effect if the interrupt pin is still asserted. The current implementation requires and edge condition to occur for setting a level sensitive IRQ, which means an ACK can clear a level sensitive interrupt, until the original

[Qemu-devel] [PATCH v2 2/5] intc/xilinx_intc: Don't clear level sens. IRQs without ACK

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite For level sensitive interrupts, ISR bits are cleared when the input pin is lowered. This is incorrect. Only software can clear ISR bits (via IAR or direct write to ISR with !MER(2)). Signed-off-by: Peter Crosthwaite --- hw/intc/xilinx_intc.c | 8 +--- 1 file change

[Qemu-devel] [PATCH v2 0/5] Xilinx Intc Fixes

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite Various fixups to the Xilinx Interrupt controller following a review against TRM and RTL descriptions. Tested as working for microblaze and microblazeel Linux. change from v1: Fixed S3ADSP UART interrupt - done first for bisectability (Now tested as working on s3asdsp d

[Qemu-devel] [PATCH v2 1/5] microblaze/petalogix_s3adsp1800_mmu: Fix UART IRQ

2013-06-10 Thread peter . crosthwaite
From: Peter Crosthwaite The UART IRQ is edge sensitive, whereas the machine was registering it as level sensitive. Fix. Signed-off-by: Peter Crosthwaite --- hw/microblaze/petalogix_s3adsp1800_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/microblaze/petalogix_s3a

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Hi Kevin, On Mon, Jun 10, 2013 at 7:23 PM, Kevin O'Connor wrote: > On Mon, Jun 10, 2013 at 06:34:29PM -0500, Anthony Liguori wrote: >> Kevin O'Connor writes: >> >> For the MADT table, right now SeaBIOS needs the CPU count. That can be >> found by counting the number of CPU nodes. Today cpus ar

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/5] intc/xilinx_intc: Use qemu_set_irq

2013-06-10 Thread Peter Crosthwaite
On Sat, Jun 8, 2013 at 8:36 AM, Michael Tokarev wrote: > 07.06.2013 06:39, Peter Crosthwaite wrote: >>> Use qemu_set_irq rather than if-elsing qemu_irq_(lower|raise). No >>> functional change, just reduces verbosity. > > Thanks, applied to the trivial patches queue. > Thanks, I need to respin th

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Jordan Justen
On Mon, Jun 10, 2013 at 2:45 PM, Anthony Liguori wrote: > OVMF is proprietary. I don't agree that not-OSI means proprietary. I agree that the FAT driver is not 'free software' and I agree that is a problem for usage with free software projects, such as QEMU. This is a big deal, but unfortunately

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Kevin O'Connor
On Mon, Jun 10, 2013 at 06:34:29PM -0500, Anthony Liguori wrote: > Kevin O'Connor writes: > > > On Mon, Jun 10, 2013 at 04:45:53PM -0500, Anthony Liguori wrote: > >> This discussion comes down to two things I think: (a) our existing > >> firmware interface is pretty poor (b) we are duplicating wo

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
David Woodhouse writes: > On Mon, 2013-06-10 at 18:34 -0500, Anthony Liguori wrote: >> Internally within QEMU, this initial discussion started by saying that >> any ACPI generation within QEMU should happen strictly with QOM >> methods. This was the crux of my argument, if QOM is the only >> int

Re: [Qemu-devel] [PATCH v4 00/12] target-i386: remove some macros

2013-06-10 Thread li guang
ping ... this patch-set got Reviewed-by from Andreas and Richard, 在 2013-05-28二的 16:19 +0800,li guang写道: > remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF > as suggested by Richard Henderson > > v4: fix alignment issue in patch 6. > > Li Guang (12) > target-i386/helper:

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread David Woodhouse
On Mon, 2013-06-10 at 18:34 -0500, Anthony Liguori wrote: > Internally within QEMU, this initial discussion started by saying that > any ACPI generation within QEMU should happen strictly with QOM > methods. This was the crux of my argument, if QOM is the only > interface we need, everything is th

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Kevin O'Connor writes: > On Mon, Jun 10, 2013 at 04:45:53PM -0500, Anthony Liguori wrote: >> This discussion comes down to two things I think: (a) our existing >> firmware interface is pretty poor (b) we are duplicating work because of >> firmware licensing. >> >> We can fix (a) and there's lots

Re: [Qemu-devel] [PATCH qom-cpu 02/59] kvm: Change cpu_synchronize_state() argument to CPUState

2013-06-10 Thread Andreas Färber
Am 10.06.2013 04:00, schrieb li guang: > 在 2013-06-09日的 21:12 +0200,Andreas Färber写道: >> Change Monitor::mon_cpu to CPUState as well. >> In cpu_sychronize_all_states() use qemu_for_each_cpu() now. > > Oh, s/sychronize/synchronize Fixed, thanks for noticing! > with that, > Reviewed-by: liguang

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Kevin O'Connor
On Mon, Jun 10, 2013 at 04:45:53PM -0500, Anthony Liguori wrote: > This discussion comes down to two things I think: (a) our existing > firmware interface is pretty poor (b) we are duplicating work because of > firmware licensing. > > We can fix (a) and there's lots of value in doing that in terms

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ioport/memory: check that both .read and .write callbacks are defined

2013-06-10 Thread Edgar E. Iglesias
On Tue, Jun 11, 2013 at 08:30:12AM +1000, Peter Crosthwaite wrote: > Hi Michael, > > On Tue, Jun 11, 2013 at 3:06 AM, Michael S. Tsirkin wrote: > > On Mon, Jun 10, 2013 at 07:14:45PM +1000, Peter Crosthwaite wrote: > >> Hi, > >> > >> On Mon, Jun 10, 2013 at 3:27 PM, Gerd Hoffmann wrote: > >> >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ioport/memory: check that both .read and .write callbacks are defined

2013-06-10 Thread Peter Crosthwaite
Hi Michael, On Tue, Jun 11, 2013 at 3:06 AM, Michael S. Tsirkin wrote: > On Mon, Jun 10, 2013 at 07:14:45PM +1000, Peter Crosthwaite wrote: >> Hi, >> >> On Mon, Jun 10, 2013 at 3:27 PM, Gerd Hoffmann wrote: >> > Hi, >> > >> >> Maybe instead (or in addition to), we should provide a dummy >> >>

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.

2013-06-10 Thread Peter Crosthwaite
Hi Michael, On Tue, Jun 11, 2013 at 1:29 AM, Michael Tokarev wrote: > 10.06.2013 19:17, Michael Tokarev пишет: >> 03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote: >>> From: Peter Crosthwaite >>> >>> Some cosmetic fixes to char/serial fixing some checkpatch errors. >> >> These are all cosmet

Re: [Qemu-devel] [PATCH qom-cpu 11/59] monitor: Simplify do_inject_mce()

2013-06-10 Thread Andreas Färber
Am 10.06.2013 19:14, schrieb Luiz Capitulino: > On Sun, 9 Jun 2013 21:12:38 +0200 > Andreas Färber wrote: > >> Use qemu_get_cpu() to avoid open-coded CPU loop. >> >> Signed-off-by: Andreas Färber > > Reviewed-by: Luiz Capitulino Thanks, applied to qom-cpu (with commit message improved): http

Re: [Qemu-devel] [PATCH qom-cpu 27/59] cpu: Turn cpu_unassigned_access() into a CPUState hook

2013-06-10 Thread Andreas Färber
Am 09.06.2013 21:12, schrieb Andreas Färber: > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > index a69c09c..814d067 100644 > --- a/include/qom/cpu.h > +++ b/include/qom/cpu.h [...] > @@ -383,6 +401,21 @@ void cpu_interrupt(CPUState *cpu, int mask); > > #endif /* USER_ONLY */ > > +#ifnde

Re: [Qemu-devel] [PATCH] Unbreak -no-quit for GTK when SDL is disabled

2013-06-10 Thread Anthony Liguori
Peter Wu writes: > When QEMU is built without SDL support, -no-quit would print an error message > that SDL is disabled. Since GTK also supports -no-quit, enable the option when > GTK or SDL is enabled at compile time. > > While at it, do not create the no_quit variable when it is not used. > > S

Re: [Qemu-devel] [PATCH qom-cpu 09/59] cpus: Simplify hw_error()

2013-06-10 Thread Andreas Färber
Am 09.06.2013 21:12, schrieb Andreas Färber: > Use new qemu_for_each_cpu(). > > Signed-off-by: Andreas Färber > --- > cpus.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/cpus.c b/cpus.c > index 1975c5c..9195bc3 100644 > --- a/cpus.c > +++ b/cpus.c > @

Re: [Qemu-devel] [PATCH] softfloat: Fix shift128Right for shift counts 64..127

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/2] gdbstub runstate check follow-ups

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/2] configure: improve handling of target lists

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] gtk: don't resize window when enabling scaling

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v5] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] gtk: use better icon

2013-06-10 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Laszlo Ersek writes: > On 06/10/13 21:57, Anthony Liguori wrote: >> Laszlo Ersek writes: > >> >> I don't understand this piece. >> >> Other than TianoCore being a weird environment, what made this more >> difficult than it is to generate the tables in QEMU? > > QEMU can pass down two kinds of

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-10 Thread Peter Maydell
On 10 June 2013 21:47, Michael Tokarev wrote: > Or else > > ./configure --disable-system --enable-virtfs > > (which makes no sense by its own but does not error out) > will fail to build, because it will define CONFIG_VIRTFS, > and the makefile will try to build virtfs-proxy-helper > manpage (but

[Qemu-devel] [PATCH] Unbreak -no-quit for GTK when SDL is disabled

2013-06-10 Thread Peter Wu
When QEMU is built without SDL support, -no-quit would print an error message that SDL is disabled. Since GTK also supports -no-quit, enable the option when GTK or SDL is enabled at compile time. While at it, do not create the no_quit variable when it is not used. Signed-off-by: Peter Wu --- in

Re: [Qemu-devel] [PATCH qom-cpu 31/59] monitor: Simplify do_info_numa()

2013-06-10 Thread Andreas Färber
Am 10.06.2013 09:20, schrieb Markus Armbruster: > Andreas Färber writes: > >> Use new qemu_for_each_cpu(). >> >> Signed-off-by: Andreas Färber >> --- >> monitor.c | 27 +++ >> 1 file changed, 19 insertions(+), 8 deletions(-) >> >> diff --git a/monitor.c b/monitor.c >> in

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Laszlo Ersek
Sorry about replying to myself... On 06/10/13 22:43, Laszlo Ersek wrote: > It's not a design purity argument, just what's cheaper. You probably consider SMBIOS/ACPI table generation "guest code" that has no place in the machine emulator. You're likely willing to expose the needed bits on a case-

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-10 Thread Michael Tokarev
11.06.2013 00:47, Michael Tokarev wrote: > Or else > > ./configure --disable-system --enable-virtfs > > (which makes no sense by its own but does not error out) > will fail to build, because it will define CONFIG_VIRTFS, > and the makefile will try to build virtfs-proxy-helper > manpage (but not

[Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-10 Thread Michael Tokarev
Or else ./configure --disable-system --enable-virtfs (which makes no sense by its own but does not error out) will fail to build, because it will define CONFIG_VIRTFS, and the makefile will try to build virtfs-proxy-helper manpage (but not the executable). Cc: qemu-triv...@nongnu.org Cc: M. Moh

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Laszlo Ersek
On 06/10/13 21:57, Anthony Liguori wrote: > Laszlo Ersek writes: >> Please take a look at my series for OVMF that adds basic support for >> SMBIOS tables. It took me three days of basically uninterrupted coding >> and two approaches to throw away until I got something submittable (with >> default

[Qemu-devel] [PATCH] target-sparc: Replace free by g_free

2013-06-10 Thread Stefan Weil
The wrong function was reported by cppcheck. Signed-off-by: Stefan Weil --- target-sparc/cpu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c index 290b580..13bb7bb 100644 --- a/target-sparc/cpu.c +++ b/target-sparc/cpu.c @@ -614,7

[Qemu-devel] [PATCH] hw/xen: Use g_free instead of free and fix potential memory leaks

2013-06-10 Thread Stefan Weil
The wrong functions and the missing calls of g_free were reported by cppcheck. Signed-off-by: Stefan Weil --- hw/xen/xen_pt_config_init.c |4 ++-- xen-all.c |8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/

[Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value

2013-06-10 Thread Stefan Weil
This fixes a warning from cppcheck. Signed-off-by: Stefan Weil --- hw/scsi/vmw_pvscsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index 48d12f4..446f723 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -389,7

[Qemu-devel] [PATCH] device tree: Fix cppcheck warning

2013-06-10 Thread Stefan Weil
Fix this cppcheck warning: Checking device_tree.c... device_tree.c:216: style: Checking if unsigned variable 'r' is less than zero. Signed-off-by: Stefan Weil --- device_tree.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device_tree.c b/device_tree.c index 56af24b..6

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Laszlo Ersek writes: > On 06/10/13 20:58, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >>> This adds support for device hotplug behind >>> pci bridges. Bridge devices themselves need >>> to be pre-configured on qemu command line. >>> >>> One of the goals of this project was to >>>

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
Peter Maydell writes: > On 10 June 2013 19:58, Anthony Liguori wrote: >> We only care about supporting one version of SeaBIOS. SeaBIOS should >> only care about supporting one version of QEMU. We're not asking it to >> support multiple versions. > > I'm confused, how does this work in cross-ve

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Laszlo Ersek
On 06/10/13 20:58, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > >> This adds support for device hotplug behind >> pci bridges. Bridge devices themselves need >> to be pre-configured on qemu command line. >> >> One of the goals of this project was to >> demonstrate the advantages of gen

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Peter Maydell
On 10 June 2013 19:58, Anthony Liguori wrote: > We only care about supporting one version of SeaBIOS. SeaBIOS should > only care about supporting one version of QEMU. We're not asking it to > support multiple versions. I'm confused, how does this work in cross-version migration? The BIOS is par

Re: [Qemu-devel] [PULL 0/2] tcg: Remove redundant tcg_target_init checks

2013-06-10 Thread Anthony Liguori
Richard Henderson writes: > Ping. Aurelien/Blue, can you pull this? Regards, Anthony Liguori > > > On 06/05/2013 05:59 AM, Richard Henderson wrote: >> Reviewing the tcg/aarch64 patch set, and comparing that to >> existing hosts made me remember that I've wanted to do this >> for quite some ti

Re: [Qemu-devel] [PATCH v2] gtk: implement -full-screen

2013-06-10 Thread Anthony Liguori
Peter Wu writes: > Aiming for GTK as replacement for SDL, a feature like -full-screen should also > be implemented. > > Bringing the window into full-screen mode is done by activating the > "Fullscreen" > menu item. This is done after showing the windows to make the cursor and menu > hidden. > >

Re: [Qemu-devel] [PATCH] qemu: piix: PCI bridge ACPI hotplug support

2013-06-10 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > This adds support for device hotplug behind > pci bridges. Bridge devices themselves need > to be pre-configured on qemu command line. > > One of the goals of this project was to > demonstrate the advantages of generating > ACPI tables in QEMU. > In my opinion, it d

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

2013-06-10 Thread Peter Lieven
Am 10.06.2013 um 18:10 schrieb mdroth : > On Mon, Jun 10, 2013 at 12:14:20PM +0200, Peter Lieven wrote: >> on incoming migration do not memset pages to zero if they already read as >> zero. >> this will allocate a new zero page and consume memory unnecessarily. even >> if we madvise a MADV_DONTN

Re: [Qemu-devel] [PATCH v2 0/4] tcg-arm: Implement tcg_register_jit

2013-06-10 Thread Richard Henderson
Ping. On 06/05/2013 10:29 AM, Richard Henderson wrote: > Changes v1-v2: > The suggestions for improvement I got from round 1 apply to all > of the hosts, not just arm. > > > r~ > > > Richard Henderson (4): > tcg: Fix high_pc fields in .debug_info > tcg: Move the CIE and FDE header definit

Re: [Qemu-devel] [PATCH 0/5] tcg-arm: Runtime detection of architecture

2013-06-10 Thread Richard Henderson
Ping. On 06/06/2013 11:05 AM, Richard Henderson wrote: > Two prepatory generic tcg patches, to allow non-constant values for > the various TCG_TARGET_HAS_foo macros. > > When in patch 3 this gets used, the code inlined in the translators > will be able to check the relevant variable and emit eit

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] KVM: PPC: Add dummy kvm_arch_init_irq_routing()

2013-06-10 Thread Scott Wood
On 06/08/2013 02:24:21 AM, Michael Tokarev wrote: 06.06.2013 07:59, Alexey Kardashevskiy wrote: > From: Scott Wood > > The common KVM code insists on calling kvm_arch_init_irq_routing() > as soon as it sees kernel header support for it (regardless of whether > QEMU supports it). Provide a du

Re: [Qemu-devel] [PULL 0/2] tcg: Remove redundant tcg_target_init checks

2013-06-10 Thread Richard Henderson
Ping. On 06/05/2013 05:59 AM, Richard Henderson wrote: > Reviewing the tcg/aarch64 patch set, and comparing that to > existing hosts made me remember that I've wanted to do this > for quite some time. > > Now with two reviews, please pull. > > > r~ > > > The following changes since commit 88

Re: [Qemu-devel] [PATCH 1/4] tcg: Split rem requirement from div requirement

2013-06-10 Thread Richard Henderson
Ping. On 05/30/2013 10:53 AM, Richard Henderson wrote: > There are several hosts with only a "div" insn. Remainder is computed > manually from the quotient and inputs. We can do this generically. > > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.h | 2 ++ > tcg/hppa/tcg-targe

[Qemu-devel] [PATCH] ide-test: fix failure for test_flush

2013-06-10 Thread Michael Roth
bd07684aacfb61668ae2c25b7dd00b64f3d7c7f3 added a test to ensure BSY flag is set when a flush request is in flight. It does this by setting a blkdebug breakpoint on flush_to_os before issuing a CMD_FLUSH_CACHE. It then resumes CMD_FLUSH_CACHE operation and checks that BSY is unset. The actual unset

Re: [Qemu-devel] [PATCH v2]booke: timer: Deactivate timer for target_bit above 61

2013-06-10 Thread Alexander Graf
On 10.06.2013, at 19:20, Scott Wood wrote: > On 06/10/2013 09:26:18 AM, Alexander Graf wrote: >> On 06/10/2013 02:47 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Andreas Färber [mailto:afaer...@suse.de] Sent: Monday, June 10, 2013 5:43 PM To: Bhushan Bhara

[Qemu-devel] [PATCH v2] gtk: implement -full-screen

2013-06-10 Thread Peter Wu
Aiming for GTK as replacement for SDL, a feature like -full-screen should also be implemented. Bringing the window into full-screen mode is done by activating the "Fullscreen" menu item. This is done after showing the windows to make the cursor and menu hidden. v2: drop -no-frame implementation,

  1   2   3   >