Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-14 Thread Gerd Hoffmann
On 05/15/13 08:05, Lei Li wrote: > On 05/14/2013 07:35 PM, Gerd Hoffmann wrote: >> On 04/25/13 07:29, Lei Li wrote: >>> +/* Sending the current led state message to the client */ >>> +if (ledstate != current_led_state(vs)) { >>> +vnc_led_state_change(vs); >>> +} >> This check ne

Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-14 Thread Laszlo Ersek
On 05/15/13 08:05, Lei Li wrote: > On 05/14/2013 07:35 PM, Gerd Hoffmann wrote: >> On 04/25/13 07:29, Lei Li wrote: >>> +/* Sending the current led state message to the client */ >>> +if (ledstate != current_led_state(vs)) { >>> +vnc_led_state_change(vs); >>> +} >> This check ne

Re: [Qemu-devel] [SeaBIOS] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-14 Thread Gerd Hoffmann
Hi, > Actually, this is a very good example. In more modern boxes like Flex, > there's a PCI-Express backplane that all of the nodes are connected to > with a common set of slots for all nodes. You can configure in firmware > how the slots map to each node. Well, we don't configure the dynami

[Qemu-devel] Fwd: Re: [PATCH v4 2/2] Add AT24Cxx I2C EEPROM device model

2013-05-14 Thread Weng Fan
Hi. I want to use this patch for qemu-system-arm. But an error occurred during initialization of the i2c device. The error message is : qemu-system-arm: drive property not set qemu-system-arm: Initialization of device at24 failed The command is: qemu-system-arm -M versatilepb -nographic -kernel

Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-14 Thread Lei Li
On 05/14/2013 07:35 PM, Gerd Hoffmann wrote: On 04/25/13 07:29, Lei Li wrote: +/* Sending the current led state message to the client */ +if (ledstate != current_led_state(vs)) { +vnc_led_state_change(vs); +} This check never becomes true as the vnc modifier/led state just g

[Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr

2013-05-14 Thread Hu Tao
target_phys_addr_t has been already replaced by hwaddr, but this one is introduced after. Signed-off-by: Hu Tao --- target-moxie/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-moxie/helper.c b/target-moxie/helper.c index 6e0ac2a..5cfe889 100644 --- a/target-m

Re: [Qemu-devel] [PATCH] chardev: Get filename for new qapi backend

2013-05-14 Thread Gerd Hoffmann
On 05/15/13 05:52, Lei Li wrote: > This patch add the filename when the new qapi backend init from opts. > > Commit 2c5f488293c7d0cd095635c74157c2526e2c4947 add support for > qapi-based chardev initialization, but miss the filename of the > char device as below: > > (qemu) info chardev > parallel

Re: [Qemu-devel] [PATCH 9/9 v2] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-14 Thread Qiao Nuohan
On 05/15/2013 10:55 AM, Eric Blake wrote: On 05/14/2013 08:29 PM, Qiao Nuohan wrote: Make monitor command 'dump-guest-memory' dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'e

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-14 Thread Michael Tokarev
15.05.2013 08:49, Michael Tokarev wrote: > 15.05.2013 01:52, Michael Roth wrote: >> Hi everyone, >> >> The following new patches are queued for QEMU stable v1.4.2: > [] >> Please CC qemu-sta...@nongnu.org on any patches you think should be >> included in the release. The cut-off date is 05-20-2013

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-14 Thread Michael Tokarev
15.05.2013 01:52, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.4.2: [] > Please CC qemu-sta...@nongnu.org on any patches you think should be > included in the release. The cut-off date is 05-20-2013 for new patches. FWIW, I've CC'ed the "cpu_unlin

[Qemu-devel] [Bug 1179357] Re: Assigned ID could not be used for net-client name

2013-05-14 Thread Lei Li
Yes, I agree with that this is a bug. The id of virtio-net-device should be 'id1' not 'virtio-net-device.0'. ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

[Qemu-devel] [PATCH 2/2] pc: reject do pc_acpi_init if acpi_enabled is false

2013-05-14 Thread liguang
Signed-off-by: liguang --- hw/i386/pc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 197d218..77025a8 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -982,7 +982,7 @@ void pc_acpi_init(const char *default_dsdt) { char *filename;

[Qemu-devel] [PATCH 1/2] vl: boolize acpi_enabled

2013-05-14 Thread liguang
Signed-off-by: liguang --- include/hw/acpi/acpi.h |2 +- vl.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h index 635be7b..b01a9dc 100644 --- a/include/hw/acpi/acpi.h +++ b/include/hw/acpi/acpi.h @

Re: [Qemu-devel] [0/8] RFC: VFIO and guest side IOMMUs, revisited

2013-05-14 Thread David Gibson
On Tue, May 14, 2013 at 11:58:16AM +0200, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 14/05/2013 04:39, David Gibson ha scritto: > > On Mon, May 13, 2013 at 03:30:26PM +0200, Paolo Bonzini wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > >> > >> Il 13/

[Qemu-devel] [PATCH] chardev: Get filename for new qapi backend

2013-05-14 Thread Lei Li
This patch add the filename when the new qapi backend init from opts. Commit 2c5f488293c7d0cd095635c74157c2526e2c4947 add support for qapi-based chardev initialization, but miss the filename of the char device as below: (qemu) info chardev parallel0: filename=(null) serial0: filename=(null) compa

Re: [Qemu-devel] [Qemu-ppc] [PATCH 09/11] memory: Add iova to IOMMUTLBEntry

2013-05-14 Thread David Gibson
On Tue, May 14, 2013 at 10:53:35AM -0600, Alex Williamson wrote: > On Tue, 2013-05-14 at 19:13 +1000, David Gibson wrote: > > Currently, the IOMMUTLBEntry structure contains the translated address, > > but not the IOVA (original untranslated address). We're going to need it > > for upcoming change

Re: [Qemu-devel] [PATCH v2 00/11] curl: fix curl read

2013-05-14 Thread Fam Zheng
On Tue, 05/14 10:22, Stefan Hajnoczi wrote: > On Tue, May 14, 2013 at 10:26:19AM +0800, Fam Zheng wrote: > > - CURLDataCache holds the user data read from libcurl, it is in a list > >ordered by access, the used cache is moved to list head on access, so > >the tail element is freed first. B

Re: [Qemu-devel] [Qemu-ppc] [PATCH 11/11] vfio: Add guest side IOMMU support

2013-05-14 Thread David Gibson
On Tue, May 14, 2013 at 08:51:08PM -0600, Alex Williamson wrote: > On Wed, 2013-05-15 at 11:33 +1000, David Gibson wrote: > > On Tue, May 14, 2013 at 11:15:26AM -0600, Alex Williamson wrote: > > > On Tue, 2013-05-14 at 19:13 +1000, David Gibson wrote: > > > > This patch uses the new IOMMU notifiers

Re: [Qemu-devel] [PATCH] curl: fix curl read

2013-05-14 Thread Fam Zheng
On Thu, 05/09 17:16, Stefan Hajnoczi wrote: > On Thu, May 09, 2013 at 02:56:50PM +0800, Fam Zheng wrote: > > On Thu, 05/09 08:41, Stefan Hajnoczi wrote: > > > On Fri, May 03, 2013 at 04:00:09PM +0800, Fam Zheng wrote: > > > > +cache = curl_find_cache(s, aio_base, aio_bytes); > > > > +if (ca

[Qemu-devel] [PATCH 1/9 v2] Add API to manipulate dump_bitmap

2013-05-14 Thread Qiao Nuohan
Struct dump_bitmap is associated with a tmp file, and the tmp file can be used to save data of bitmap in kdump-compressed format temporarily. The following patch will use these functions to get the data of bitmap and cache them into tmp files. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe

Re: [Qemu-devel] [PATCH 9/9 v2] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-14 Thread Eric Blake
On 05/14/2013 08:29 PM, Qiao Nuohan wrote: > Make monitor command 'dump-guest-memory' dump in kdump-compressed format. > The command's usage: > dump [-p] protocol [begin] [length] [format] > 'format' is used to specified the format of vmcore and can be: > 1. 'elf': ELF format, without compression

Re: [Qemu-devel] [Qemu-ppc] [PATCH 11/11] vfio: Add guest side IOMMU support

2013-05-14 Thread Alex Williamson
On Wed, 2013-05-15 at 11:33 +1000, David Gibson wrote: > On Tue, May 14, 2013 at 11:15:26AM -0600, Alex Williamson wrote: > > On Tue, 2013-05-14 at 19:13 +1000, David Gibson wrote: > > > This patch uses the new IOMMU notifiers to allow VFIO pass through devices > > > to work with guest side IOMMUs,

[Qemu-devel] [PATCH 9/9 v2] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-14 Thread Qiao Nuohan
Make monitor command 'dump-guest-memory' dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'elf': ELF format, without compression 2. 'zlib': kdump-compressed format, with zlib-compre

[Qemu-devel] [PATCH 7/9 v2] Add API to free buf used by creating header, bitmap and page

2013-05-14 Thread Qiao Nuohan
When calling create_header, create_dump_bitmap and create_pages, some memory spaces are allocated. The following patch will use this function to free these spaces. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c | 19 +++ 1 files changed, 19 insertions(+), 0 d

[Qemu-devel] [PATCH 8/9 v2] Add API to write header, bitmap and page into vmcore

2013-05-14 Thread Qiao Nuohan
The following patch will use these functions to write cached data into vmcore. Header is cached in DumpState, and bitmap and page are cached in tmp files. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c| 259 + inc

[Qemu-devel] [PATCH 6/9 v2] Add API to create page

2013-05-14 Thread Qiao Nuohan
Add API to get data of page desc and page data and save them into tmp files. The following patch will use these functions to gather data of page desc and page data, then write them into vmcore Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c| 259

[Qemu-devel] [PATCH 5/9 v2] Add API to create data of dump bitmap

2013-05-14 Thread Qiao Nuohan
Add API to get data of the 1st and 2nd dump bitmap and save them into tmp files. The following patch will use these functions to gather data of dump bitmap, then write them into vmcore. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c| 98 +++

[Qemu-devel] [PATCH 2/9 v2] Add API to manipulate cache_data

2013-05-14 Thread Qiao Nuohan
Struct dump_bitmap is associated with a tmp file, and the tmp file can be used to save data of page desc and page data in kdump-compressed format temporarily. The following patch will use these function to get the data of page desc and page data and cache them in tmp files. Signed-off-by: Qiao Nuo

[Qemu-devel] [PATCH 3/9 v2] Move includes and struct definition to dump.h

2013-05-14 Thread Qiao Nuohan
Move includes and definition of struct DumpState into include/sysemu/dump.h. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c| 29 - include/sysemu/dump.h | 30 ++ 2 files changed, 30 insertions(+), 29 de

[Qemu-devel] [PATCH 4/9 v2] Add API to create header of vmcore

2013-05-14 Thread Qiao Nuohan
Add API to create header, sub header of vmcore in kdump-compressed format. The data is store in struct DumpState. The following patch will use this function to gather data of header, then write them into vmcore. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c|

[Qemu-devel] [PATCH 0/9 v2] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-14 Thread Qiao Nuohan
Hi, all The last version is here: http://lists.gnu.org/archive/html/qemu-devel/2013-05/msg00803.html Command 'dump-guest-memory' was introduced to dump guest's memory. But the vmcore's format is only elf32 or elf64. The message is here: http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg0337

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-14 Thread Wenchao Xia
于 2013-5-6 21:22, Luiz Capitulino 写道: On Mon, 06 May 2013 10:09:43 +0800 Wenchao Xia wrote: 于 2013-5-3 10:51, Wenchao Xia 写道: 于 2013-5-2 20:02, Luiz Capitulino 写道: On Thu, 02 May 2013 10:05:08 +0800 Wenchao Xia wrote: 于 2013-4-30 3:05, Luiz Capitulino 写道: On Fri, 26 Apr 2013 16:46:57 +02

Re: [Qemu-devel] [Qemu-ppc] [PATCH 07/11] vfio: Introduce VFIO address spaces

2013-05-14 Thread David Gibson
On Tue, May 14, 2013 at 10:53:12AM -0600, Alex Williamson wrote: > On Tue, 2013-05-14 at 19:13 +1000, David Gibson wrote: > > The only model so far supported for VFIO passthrough devices is the model > > usually used on x86, where all of the guest's RAM is mapped into the > > (host) IOMMU and there

Re: [Qemu-devel] [Qemu-ppc] [PATCH 11/11] vfio: Add guest side IOMMU support

2013-05-14 Thread David Gibson
On Tue, May 14, 2013 at 11:15:26AM -0600, Alex Williamson wrote: > On Tue, 2013-05-14 at 19:13 +1000, David Gibson wrote: > > This patch uses the new IOMMU notifiers to allow VFIO pass through devices > > to work with guest side IOMMUs, as long as the host-side VFIO iommu has > > sufficient capabil

Re: [Qemu-devel] [Qemu-ppc] [PATCH 10/11] memory: Add iommu map/unmap notifiers

2013-05-14 Thread David Gibson
On Tue, May 14, 2013 at 11:23:16PM +0200, Paolo Bonzini wrote: > Il 14/05/2013 11:13, David Gibson ha scritto: > > This patch adds a NotifierList to MemoryRegions which represent IOMMUs > > allowing other parts of the code to register interest in mappings or > > unmappings from the IOMMU. All IOMM

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-14 Thread TeLeMan
On Tue, May 14, 2013 at 7:55 PM, Paolo Bonzini wrote: > Il 14/05/2013 13:48, Paolo Bonzini ha scritto: >> Il 14/05/2013 13:39, TeLeMan ha scritto: >>> On Tue, May 14, 2013 at 6:46 PM, Paolo Bonzini wrote: Il 14/05/2013 12:24, TeLeMan ha scritto: > On Tue, May 14, 2013 at 3:51 PM, Stefan

Re: [Qemu-devel] [RFC PATCH 2/2] mem: prepare address_space listener rcu style

2013-05-14 Thread liu ping fan
On Tue, May 14, 2013 at 5:34 PM, Paolo Bonzini wrote: > Il 14/05/2013 07:47, liu ping fan ha scritto: >> On Mon, May 13, 2013 at 5:31 PM, Paolo Bonzini wrote: >>> Il 13/05/2013 05:21, Liu Ping Fan ha scritto: From: Liu Ping Fan Each address space listener has PhysPageMap *cur_map,

[Qemu-devel] [Bug 1179731] Re: is networking broken on windows hosts?

2013-05-14 Thread therock247uk
tried the patch did not work though still hangs/crashes has issues -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1179731 Title: is networking broken on windows hosts? Status in QEMU: New Bug de

[Qemu-devel] [PATCH 11/15] cpu-exec: wrap tcg_qemu_tb_exec() in a fn to restore the PC

2013-05-14 Thread Michael Roth
From: Peter Maydell If tcg_qemu_tb_exec() returns a value whose low bits don't indicate a link to an indexed next TB, this means that the TB execution never started (eg because the instruction counter hit zero). In this case the guest PC has to be reset to the address of the start of the TB. Ref

[Qemu-devel] [PATCH 09/15] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-14 Thread Michael Roth
From: Laszlo Ersek The qemu guest agent creates a bunch of files with insecure permissions when started in daemon mode. For example: -rw-rw-rw- 1 root root /var/log/qemu-ga.log -rw-rw-rw- 1 root root /var/run/qga.state -rw-rw-rw- 1 root root /var/log/qga-fsfreeze-hook.log In addition, at

[Qemu-devel] [PATCH 15/15] qga: unlink just created guest-file if fchmod() or fdopen() fails on it

2013-05-14 Thread Michael Roth
From: Laszlo Ersek We shouldn't allow guest filesystem pollution on error paths. Suggested-by: Eric Blake Signed-off-by: Laszlo Ersek Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino Signed-off-by: Michael Roth (cherry picked from commit 2b720018060179b394f8ce736983373ab80dd37c) Signed

[Qemu-devel] [PATCH 08/15] tcg/optimize: fix setcond2 optimization

2013-05-14 Thread Michael Roth
From: Aurelien Jarno When setcond2 is rewritten into setcond, the state of the destination temp should be reset, so that a copy of the previous value is not used instead of the result. Reported-by: Michael Tokarev Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno (cherry picked fro

[Qemu-devel] [PATCH 12/15] Handle CPU interrupts by inline checking of a flag

2013-05-14 Thread Michael Roth
From: Peter Maydell Fix some of the nasty TCG race conditions and crashes by implementing cpu_exit() as setting a flag which is checked at the start of each TB. This avoids crashes if a thread or signal handler calls cpu_exit() while the execution thread is itself modifying the TB graph (which ma

[Qemu-devel] [PATCH 07/15] target-mips: Fix accumulator arguments to gen_helper_dmult(u)

2013-05-14 Thread Michael Roth
From: Richard Sandiford gen_muldiv was passing int accumulator arguments directly to gen_helper_dmult(u). This patch fixes it to use TCGs, via the gen_helper_0e2i wrapper. Fixes an --enable-debug-tcg build failure reported by Juergen Lock. Signed-off-by: Richard Sandiford Signed-off-by: Micha

[Qemu-devel] [PATCH 10/15] tcg: Document tcg_qemu_tb_exec() and provide constants for low bit uses

2013-05-14 Thread Michael Roth
From: Peter Maydell Document tcg_qemu_tb_exec(). In particular, its return value is a combination of a pointer to the next translation block and some extra information in the low two bits. Provide some #defines for the values passed in these bits to improve code clarity. Signed-off-by: Peter May

[Qemu-devel] [PATCH 04/15] tap: properly initialize vhostfds

2013-05-14 Thread Michael Roth
From: Jason Wang Only tap->vhostfd were checked net_init_tap_one(), but tap->vhostfds were forgot, this will lead qemu to ignore all fds passed by management through vhostfds, and tries to create vhost_net device itself. Fix by adding this check also. Reportyed-by: Michal Privoznik Cc: Michal P

[Qemu-devel] [PATCH 14/15] qga: distinguish binary modes in "guest_file_open_modes" map

2013-05-14 Thread Michael Roth
From: Laszlo Ersek In Windows guests this may make a difference. Since the original patch (commit c689b4f1) sought to be pedantic and to consider theoretical corner cases of portability, we should fix it up where it failed to come through in that pursuit. Suggested-by: Eric Blake Reviewed-by:

[Qemu-devel] [PATCH 05/15] virtio-ccw: Check indicators location.

2013-05-14 Thread Michael Roth
From: Cornelia Huck If a guest neglected to register (secondary) indicators but still runs with notifications enabled, we might end up writing to guest zero; avoid this by checking for valid indicators and only writing to the guest and generating an interrupt if indicators have been setup. Cc: q

[Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-14 Thread Michael Roth
Hi everyone, The following new patches are queued for QEMU stable v1.4.2: https://github.com/mdroth/qemu/commits/stable-1.4-staging The release is planned for 05-24-2013: http://wiki.qemu.org/Planning/1.4 Please CC qemu-sta...@nongnu.org on any patches you think should be included in the relea

[Qemu-devel] [PATCH 06/15] configure: Pick up libseccomp include path

2013-05-14 Thread Michael Roth
From: Andreas Färber openSUSE 12.3 has seccomp.h in /usr/include/libseccomp-1.0.1, so add `pkg-config --cflags libseccomp` output to QEMU_CFLAGS. Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber Signed-off-by: Michael Tokarev (cherry picked from commit 372e47e9b5e31c493823d7f512716644f

[Qemu-devel] [PATCH 13/15] translate-all.c: Remove cpu_unlink_tb()

2013-05-14 Thread Michael Roth
From: Peter Maydell The (unsafe) function cpu_unlink_tb() is now unused, so we can simply remove it and any code that was only used by it. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Blue Swirl (cherry picked from commit 3a808cc407744c30daa7470b5f191cde1fbc1aae

[Qemu-devel] [PATCH 03/15] rng random backend: check for -EAGAIN errors on read

2013-05-14 Thread Michael Roth
From: Amit Shah Not handling EAGAIN triggers the assert qemu/backends/rng-random.c:44:entropy_available: assertion failed: (len != -1) Aborted (core dumped) This happens when starting a guest with '-device virtio-rng-pci', issuing a 'cat /dev/hwrng' in the guest, while also doing 'cat /dev/rand

[Qemu-devel] [PATCH 02/15] qdev: Fix QOM unrealize behavior

2013-05-14 Thread Michael Roth
From: Andreas Färber Since commit 249d41720b7dfbb5951b430b9eefdbee7464f515 (qdev: Prepare "realized" property) setting realized = true would register the device's VMStateDescription, but realized = false would not unregister it. Fix that. Moving the code from unparenting also revealed that we we

[Qemu-devel] [PATCH 01/15] nbd: unlock mutex in nbd_co_send_request() error path

2013-05-14 Thread Michael Roth
From: Stefan Hajnoczi Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini (cherry picked from commit 6760c47aa42ce30efdd12c132f73c8749c575995) Signed-off-by: Michael Roth --- block/nbd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [Qemu-devel] [PATCH 10/11] memory: Add iommu map/unmap notifiers

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 11:13, David Gibson ha scritto: > This patch adds a NotifierList to MemoryRegions which represent IOMMUs > allowing other parts of the code to register interest in mappings or > unmappings from the IOMMU. All IOMMU implementations will need to call > memory_region_notify_iommu() to i

Re: [Qemu-devel] [PATCH 09/11] memory: Add iova to IOMMUTLBEntry

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 11:13, David Gibson ha scritto: > Currently, the IOMMUTLBEntry structure contains the translated address, > but not the IOVA (original untranslated address). We're going to need it > for upcoming changes, so add it in here, and populate it correctly in our > one existing iommu implem

Re: [Qemu-devel] [Bug 1179731] Re: is networking broken on windows hosts?

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 18:50, therock247uk ha scritto: > trying other network adapters does not help either i tried the > model=rtl8139 and the xp guest says limited or no connectivty. > Please test the patch that was sent in this thread. http://article.gmane.org/gmane.comp.emulators.qemu/211335/raw Pao

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Peter Maydell
On 14 May 2013 19:30, Brad Smith wrote: > On Tue, May 14, 2013 at 02:05:21PM +0200, Paolo Bonzini wrote: >> This should fix building the GTK+ front-end on BSDs. >> >> Signed-off-by: Paolo Bonzini >> --- >> include/qemu-common.h | 12 >> qemu-char.c | 10 -- >> ui/g

Re: [Qemu-devel] [PATCH 10/11] memory: Add iommu map/unmap notifiers

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 19:15, Alex Williamson ha scritto: > On Tue, 2013-05-14 at 19:13 +1000, David Gibson wrote: >> > This patch adds a NotifierList to MemoryRegions which represent IOMMUs >> > allowing other parts of the code to register interest in mappings or >> > unmappings from the IOMMU. All IOMMU

[Qemu-devel] [PATCH for-1.5] configure: Detect uuid on MacOSX (fixes compile failure)

2013-05-14 Thread Peter Maydell
Commit 7791dba3ec broke compilation on MacOSX, because it introduced a new include of util.h. On MacOSX this includes pwd.h which in turn includes the system uuid/uuid.h, which causes a compile failure if QEMU was configured without CONFIG_UUID due to a conflict between the system header and our fa

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Eric Blake
On 05/14/2013 01:28 PM, Laszlo Ersek wrote: > Not to argue with this, just a general note: most of whatever is > portable from the terminal IO interfaces belongs into indeed. > > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/termios.h.html > > Traditionally nonportable stuff related

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Peter Maydell
On 14 May 2013 13:05, Paolo Bonzini wrote: > This should fix building the GTK+ front-end on BSDs. > > Signed-off-by: Paolo Bonzini Hi. This patch breaks the build on MacOSX: manooth$ make block/vdi.o CHK version_gen.h CCblock/vdi.o block/vdi.c:124:20: error: static declaration of

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

2013-05-14 Thread Wolfgang Richter
On Tue, May 14, 2013 at 12:45 PM, Paolo Bonzini wrote: > No, I'll just reuse the same hooks within block/mirror.c (almost... it > looks like I need after_write too, not just before_write :( that's a > pity). Basically: > > 1) before the write, if there is space in the job's buffers, allocate a >

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Laszlo Ersek
On 05/14/13 18:35, Paolo Bonzini wrote: > Il 14/05/2013 18:15, Brad Smith ha scritto: >> On Tue, May 14, 2013 at 04:10:56PM -, Anthony Liguori wrote: >>> Applied. Thanks. >>> >>> Regards, >>> >>> Anthony Liguori >> >> The patch was not updated to take into consideration my comment from bug >>

Re: [Qemu-devel] [PATCH v4 09/12] linux-user: Add signal handling for AArch64

2013-05-14 Thread John Rigby
On Tue, May 14, 2013 at 10:31 AM, Richard Henderson wrote: > On 05/13/2013 09:32 PM, John Rigby wrote: >> +#ifdef TARGET_AARCH64 >> + return state->sp; >> +#else >> return state->regs[13]; >> +#endif > > Merge error. You changed that to xreg[31]. Thanks, fixed locally for v5.

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Brad Smith
On Tue, May 14, 2013 at 02:05:21PM +0200, Paolo Bonzini wrote: > This should fix building the GTK+ front-end on BSDs. > > Signed-off-by: Paolo Bonzini > --- > include/qemu-common.h | 12 > qemu-char.c | 10 -- > ui/gtk.c | 1 - > 3 files changed, 12 i

Re: [Qemu-devel] [PATCH for-1.5 1/2] w32: Fix configure test for -march=i486

2013-05-14 Thread Stefan Weil
Am 11.05.2013 21:46, schrieb Stefan Weil: > The latest version of MinGW needs a test for __sync_val_compare_and_swap > to fix a missing symbol linker error. > > Reported-by: Igor Mitsyanko > Signed-off-by: Stefan Weil > --- > configure |1 + > 1 file changed, 1 insertion(+) > > diff --git a/

Re: [Qemu-devel] [PATCH v4] Add 'maxqdepth' as an option to tty character devices.

2013-05-14 Thread John Baboval
On 05/10/2013 11:28 PM, Eric Blake wrote: On 05/07/2013 04:39 PM, John Baboval wrote: From: "John V. Baboval" This parameter will cause writes to tty backed chardevs to return -EAGAIN if the backing tty has buffered more than the specified number of characters. When data is sent, the TIOCOUTQ

Re: [Qemu-devel] [PATCH 10/11] memory: Add iommu map/unmap notifiers

2013-05-14 Thread Alex Williamson
On Tue, 2013-05-14 at 19:13 +1000, David Gibson wrote: > This patch adds a NotifierList to MemoryRegions which represent IOMMUs > allowing other parts of the code to register interest in mappings or > unmappings from the IOMMU. All IOMMU implementations will need to call > memory_region_notify_iom

Re: [Qemu-devel] [PATCH 11/11] vfio: Add guest side IOMMU support

2013-05-14 Thread Alex Williamson
On Tue, 2013-05-14 at 19:13 +1000, David Gibson wrote: > This patch uses the new IOMMU notifiers to allow VFIO pass through devices > to work with guest side IOMMUs, as long as the host-side VFIO iommu has > sufficient capability and granularity to match the guest side. This works > by tracking all

[Qemu-devel] [Bug 1179731] Re: is networking broken on windows hosts?

2013-05-14 Thread therock247uk
trying other network adapters does not help either i tried the model=rtl8139 and the xp guest says limited or no connectivty. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1179731 Title: is network

Re: [Qemu-devel] [PATCH 09/11] memory: Add iova to IOMMUTLBEntry

2013-05-14 Thread Alex Williamson
On Tue, 2013-05-14 at 19:13 +1000, David Gibson wrote: > Currently, the IOMMUTLBEntry structure contains the translated address, > but not the IOVA (original untranslated address). We're going to need it > for upcoming changes, so add it in here, and populate it correctly in our > one existing iom

Re: [Qemu-devel] [PATCH 07/11] vfio: Introduce VFIO address spaces

2013-05-14 Thread Alex Williamson
On Tue, 2013-05-14 at 19:13 +1000, David Gibson wrote: > The only model so far supported for VFIO passthrough devices is the model > usually used on x86, where all of the guest's RAM is mapped into the > (host) IOMMU and there is no IOMMU visible in the guest. > > This patch begins to relax this m

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 17:48, Wolfgang Richter ha scritto: > On Tue, May 14, 2013 at 6:04 AM, Paolo Bonzini > wrote: > > Il 14/05/2013 10:50, Kevin Wolf ha scritto: > > Or, to translate it into our existing terminology, drive-mirror > > implements a passive mirror,

[Qemu-devel] [Bug 1179664] Re: migration.c:293: undefined reference to `__sync_val_compare_and_swap_4'

2013-05-14 Thread therock247uk
therock247uk@dell-PC ~ $ gcc --version gcc.exe (GCC) 4.7.2 Copyright (C) 2012 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. therock247uk@dell-PC ~ $ -- You rec

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 18:15, Brad Smith ha scritto: > On Tue, May 14, 2013 at 04:10:56PM -, Anthony Liguori wrote: >> Applied. Thanks. >> >> Regards, >> >> Anthony Liguori > > The patch was not updated to take into consideration my comment from bug > 114 so > what was commited is just as broken

[Qemu-devel] [Bug 1179731] Re: is networking broken on windows hosts?

2013-05-14 Thread therock247uk
latest git as of yesterday compiled under mingw using qemu-system-i386 -localtime -m 512 windows.img when ever it connects to the internet qemu hangs. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/117

Re: [Qemu-devel] [PATCH v4 09/12] linux-user: Add signal handling for AArch64

2013-05-14 Thread Richard Henderson
On 05/13/2013 09:32 PM, John Rigby wrote: > +#ifdef TARGET_AARCH64 > + return state->sp; > +#else > return state->regs[13]; > +#endif Merge error. You changed that to xreg[31]. r~

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Anthony Liguori
Brad Smith writes: > On Tue, May 14, 2013 at 04:10:56PM -, Anthony Liguori wrote: >> Applied. Thanks. >> >> Regards, >> >> Anthony Liguori > > The patch was not updated to take into consideration my comment from bug > 114 so > what was commited is just as broken as before the patch.

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

2013-05-14 Thread Richard Henderson
On 05/14/2013 08:16 AM, Richard Henderson wrote: > On 05/14/2013 07:05 AM, Claudio Fontana wrote: >>> Conditional branch range is +-1MB. You'll never see a TB that large. You >>> don't need to emit a branch-across-branch. >> >> Is there maybe a way to do it right even in the corner case where we

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5] spitz: fix compilation failure due to pty.h namespace pollution

2013-05-14 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2 for-1.5 0/4] qcow2: Catch some L1 table index overflows

2013-05-14 Thread Richard W.M. Jones
On Tue, May 14, 2013 at 04:14:32PM +0200, Kevin Wolf wrote: > Kevin Wolf (4): > qcow2: Catch some L1 table index overflows > block: Add hint to -EFBIG error message > qcow2.py: Subcommand for changing header fields > qemu-iotests: Try creating huge qcow2 image > > block.c

Re: [Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Brad Smith
On Tue, May 14, 2013 at 04:10:56PM -, Anthony Liguori wrote: > Applied. Thanks. > > Regards, > > Anthony Liguori The patch was not updated to take into consideration my comment from bug 114 so what was commited is just as broken as before the patch. -- This message has been scanned f

Re: [Qemu-devel] [PATCH for-1.5] readline: Handle xterm escape sequences for Home/End keys

2013-05-14 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [RESEND PATCH for-1.5] acpi: add dummy write function for acpi timer

2013-05-14 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5 0/2] Fix hot-unplug of devices with ROM or RAM

2013-05-14 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-14 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH moxie] Fix bug in tlb_fill.

2013-05-14 Thread Richard Henderson
On 05/13/2013 01:33 PM, Max Filippov wrote: > memory access at points (1) and (2) can abort the instruction (it did so > b/o the bug, but it may do so legitimately when you add MMU support), > but it has modified REG(1) at those points, which will not be restored. > It's probably worth carrying reg

[Qemu-devel] [PATCH for-1.5 1/3] Revert "versatile_pci: Put the host bridge PCI device at slot 29"

2013-05-14 Thread Peter Maydell
This reverts commit 5f37ef92b7690423ac6311d3c597e182fc5f8fe6. It turns out that some kernels incorrectly depend on the old QEMU behaviour of not putting the host PCI bridge device where the hardware puts it, because they use a swizzling IRQ mapping which is incorrect but happens to match up with ol

[Qemu-devel] [PATCH for-1.5 2/3] hw/pci-host/versatile.c: Update autodetect to detect newer kernels

2013-05-14 Thread Peter Maydell
Newer versatilepb kernels still don't get the IRQ mapping right for the PCI controller, but they get it differently wrong (they add a fixed +64 offset to everything they write to PCI_INTERRUPT_LINE). Update the autodetection to handle these too, and include a more detailed comment on the various di

[Qemu-devel] [PATCH for-1.5 0/3] hw/pci-host/versatile: Fix issues with newer kernels

2013-05-14 Thread Peter Maydell
The reworking of the versatile PCI controller model so that it actually behaved like hardware included an attempt to autodetect whether the guest Linux kernel was assuming the old broken behaviour. Unfortunately it turns out that there are several different variant broken kernels which behave sligh

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

2013-05-14 Thread Wolfgang Richter
On Tue, May 14, 2013 at 6:04 AM, Paolo Bonzini wrote: > Il 14/05/2013 10:50, Kevin Wolf ha scritto: > > Or, to translate it into our existing terminology, drive-mirror > > implements a passive mirror, you're proposing an active one (which we > > do want to have). > > > > With an active mirror, we

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

2013-05-14 Thread Wolfgang Richter
On Tue, May 14, 2013 at 4:50 AM, Kevin Wolf wrote: > Or, to translate it into our existing terminology, drive-mirror > implements a passive mirror, you're proposing an active one (which we > do want to have). > > With an active mirror, we'll want to have another choice: The mirror can > be synchr

Re: [Qemu-devel] [PATCH v2] blockdev: Rename BlockdevAction -> TransactionAction

2013-05-14 Thread Eric Blake
On 05/14/2013 05:50 AM, Kevin Wolf wrote: > There's no reason to restrict transactions to operations related to > block devices, so rename the type now before schema introspection stops > us from doing so. > > Also change the schema documentation of 'transaction' to not refer to > block devices or

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

2013-05-14 Thread Wolfgang Richter
On Tue, May 14, 2013 at 4:40 AM, Stefan Hajnoczi wrote: > QEMU is accumulating many different approaches to snapshots and > mirroring. They all have their pros and cons so it's not possible to > support only one approach for all use cases. > > The suggested approach is writing a BlockDriver which

[Qemu-devel] [PATCH for-1.5 3/3] hw/pci-host/versatile.c: Provide property for forcing broken IRQ mapping

2013-05-14 Thread Peter Maydell
Although we try our best to automatically detect broken versions of Linux which assume the old broken IRQ mapping we used to implement for our model of the Versatile PCI controller, it turns out that some particularly new kernels manage to outwit the autodetection. We therefore provide a property

Re: [Qemu-devel] [PATCH v2] blockdev: Rename BlockdevAction -> TransactionAction

2013-05-14 Thread Stefan Hajnoczi
On Tue, May 14, 2013 at 01:50:27PM +0200, Kevin Wolf wrote: > There's no reason to restrict transactions to operations related to > block devices, so rename the type now before schema introspection stops > us from doing so. > > Also change the schema documentation of 'transaction' to not refer to

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

2013-05-14 Thread Richard Henderson
On 05/14/2013 05:25 AM, Peter Maydell wrote: >> Yes, I agree. I could not find an image which triggered that >> > code path for register rotation amounts. > Try PPC : rlwmn will generate a rotl (as will other insns). > rlwmn will only generate constant rotations; at issue are variable rotations.

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

2013-05-14 Thread Richard Henderson
On 05/14/2013 07:05 AM, Claudio Fontana wrote: >> Conditional branch range is +-1MB. You'll never see a TB that large. You >> don't need to emit a branch-across-branch. > > Is there maybe a way to do it right even in the corner case where we have > a huge list of hundreds of thousands of instruc

  1   2   3   >