Re: [Qemu-devel] [PATCH] 9p: Be robust against paths without FS_IOC_GETVERSION

2013-05-09 Thread Gabriel de Perthuis
Le 10/05/2013 05:30, Aneesh Kumar K.V a écrit : > Gabriel de Perthuis writes: > >> The current implementation checked for supported filesystems at mount >> time, but actual support depends on the path. Don't error out when >> finding unversioned paths. > > Can you elaborate this a bit ? ioctl

[Qemu-devel] kvm process disappears

2013-05-09 Thread Stefan Priebe - Profihost AG
Hello list, i've now seen this several times. A VM is suddently down no segfault nothing the kvm process just disappears... Anybody any idea how to debug this? Sadly i can't reproduce. Qemu version is 1.4.1. Greets Stefan

Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm

2013-05-09 Thread liu ping fan
On Thu, May 9, 2013 at 11:26 PM, Stefan Hajnoczi wrote: > On Thu, May 09, 2013 at 05:00:20PM +0800, liu ping fan wrote: >> On Thu, May 9, 2013 at 4:30 PM, Stefan Hajnoczi wrote: >> > On Thu, May 09, 2013 at 08:40:21AM +0800, Liu Ping Fan wrote: >> >> From: Liu Ping Fan >> >> >> >> Hosts threads

Re: [Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.

2013-05-09 Thread Andreas Färber
Am 15.03.2013 19:14, schrieb Frediano Ziglio: > Modern notebook support 136x768 resolution. The resolution width is 1366? > not multiple of 16 causing some problems. "a multiple"? (me not a native English speaker) > > Qemu VGA emulation require width resolution to be multiple of 8. "QEMU" >

Re: [Qemu-devel] [PATCH] 9p: Be robust against paths without FS_IOC_GETVERSION

2013-05-09 Thread Aneesh Kumar K.V
Gabriel de Perthuis writes: > The current implementation checked for supported filesystems at mount > time, but actual support depends on the path. Don't error out when > finding unversioned paths. Can you elaborate this a bit ? > > This fix allows booting a linux kernel with the same / filesy

Re: [Qemu-devel] [PATCH 01/10] qapi: qapi-types.py, native list support

2013-05-09 Thread Amos Kong
On Thu, May 09, 2013 at 09:20:53PM -0500, Michael Roth wrote: > Teach type generators about native types so they can generate the > appropriate linked list types. > > Signed-off-by: Michael Roth > --- > scripts/qapi-types.py | 43 --- > scripts/qapi.py

[Qemu-devel] [Patch] Support for bridged networking on Mac OS X

2013-05-09 Thread Alasdair McLeay
tun tap can be implemented on Mac OS X using http://tuntaposx.sourceforge.net It behaves in the same way as FreeBSD/OpenBSD implementations, but Qemu needs a patch to use the OpenBS/FreeBSD code. As per the patch listed in this forum thread: http://forum.gns3.net/post17679.html#p17679 And also

[Qemu-devel] [PATCH 10/10] qapi: add native list coverage for QMP input visitor tests

2013-05-09 Thread Michael Roth
This exercises schema-generated visitors for native list types and does some sanity checking on validity of deserialized data. Signed-off-by: Michael Roth --- tests/test-qmp-input-visitor.c | 186 1 file changed, 186 insertions(+) diff --git a/tests/tes

[Qemu-devel] [PATCH 08/10] qapi: add native list coverage for visitor serialization tests

2013-05-09 Thread Michael Roth
Signed-off-by: Michael Roth --- tests/test-visitor-serialization.c | 248 +--- 1 file changed, 230 insertions(+), 18 deletions(-) diff --git a/tests/test-visitor-serialization.c b/tests/test-visitor-serialization.c index fed6810..b31911f 100644 --- a/tests/test-

[Qemu-devel] [PATCH 09/10] qapi: add native list coverage for QMP output visitor tests

2013-05-09 Thread Michael Roth
This exercises schema-generated visitors for native list types and does some sanity checking on validity of serialized data. Signed-off-by: Michael Roth --- qapi-schema-test.json |7 ++ tests/test-qmp-output-visitor.c | 176 +++ 2 files changed,

[Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-09 Thread Michael Roth
Currently our JSON parser assumes that numbers lacking a mantissa are integers and attempts to store them as QInt/int64 values. This breaks in the case where the number overflows/underflows int64 values (which is still valid JSON) Fix this by detecting such cases and using a QFloat to store the va

[Qemu-devel] [PATCH 07/10] qapi: fix visitor serialization tests for numbers/doubles

2013-05-09 Thread Michael Roth
We never actually stored the stringified double values into the strings before we did the comparisons. This left number/double values completely uncovered in test-visitor-serialization tests. Fixing this exposed a bug in our handling of large whole number values in QEMU's JSON parser which is now

[Qemu-devel] [PATCH 05/10] qapi: fix leak in unit tests

2013-05-09 Thread Michael Roth
qmp_output_get_qobject() increments the qobject's reference count. Since we currently pass this straight into qobject_to_json() so we can feed the data into a QMP input visitor, we never actually free the underlying qobject when qmp_output_visitor_cleanup() is called. This causes leaks on all of th

[Qemu-devel] [PATCH 04/10] qapi: enable generation of native list code

2013-05-09 Thread Michael Roth
Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs qapi-types.c/qapi-visit.c Signed-off-by: Michael Roth --- Makefile |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 7dc0204..9695c9d 100644 --- a/Makefile +++ b/Makefile @@ -

[Qemu-devel] [PATCH 03/10] qapi: qapi-visit.py, native list support

2013-05-09 Thread Michael Roth
Teach visitor generators about native types so they can generate the appropriate visitor routines. Signed-off-by: Michael Roth --- scripts/qapi-visit.py | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-

[Qemu-devel] [PATCH 02/10] qapi: qapi-visit.py, fix list handling for union types

2013-05-09 Thread Michael Roth
Currently we assume non-list types when generating visitor routines for union types. This is broken, since values like ['Type'] need to mapped to 'TypeList'. We already have a type_name() function to handle this that we use for generating struct visitors, so use that here as well. Signed-off-by:

[Qemu-devel] [PATCH 01/10] qapi: qapi-types.py, native list support

2013-05-09 Thread Michael Roth
Teach type generators about native types so they can generate the appropriate linked list types. Signed-off-by: Michael Roth --- scripts/qapi-types.py | 43 --- scripts/qapi.py | 21 + 2 files changed, 61 insertions(+), 3 dele

[Qemu-devel] [PATCH v2 00/10] qapi: add support for lists of native types

2013-05-09 Thread Michael Roth
These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git qapi-native-lists Sending this now since a number of series have popped up in the past that wanted this, and Amos has some pending patches (query-mac-tables) that rely on this as well. T

Re: [Qemu-devel] [PATCH 9/9] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-09 Thread Zhang Xiaohe
于 2013年05月09日 22:51, Eric Blake 写道: On 05/08/2013 11:27 PM, Zhang Xiaohe wrote: 于 2013年05月09日 01:16, Eric Blake 写道: On 05/08/2013 02:50 AM, qiaonuohan wrote: Thanks for your suggestion. I will fix it like: { 'enum': 'DumpCompressionFormat', 'data': [ 'zlib', 'lzo', 'snappy' ] } For zlib

Re: [Qemu-devel] [RFC PATCH 0/8] MemoryRegion and FlatView refcounting, replace hostmem with memory_region_find

2013-05-09 Thread liu ping fan
On Thu, May 9, 2013 at 10:50 PM, Paolo Bonzini wrote: > Il 09/05/2013 02:53, liu ping fan ha scritto: >> On Wed, May 8, 2013 at 11:44 PM, Paolo Bonzini wrote: >>> Il 08/05/2013 08:20, liu ping fan ha scritto: On Mon, May 6, 2013 at 10:25 PM, Paolo Bonzini wrote: > Hi, > > this i

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-09 Thread Chegu Vinod
On 5/9/2013 1:24 PM, Igor Mammedov wrote: On Thu, 9 May 2013 12:43:20 -0700 Chegu Vinod wrote: If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest for some dur

Re: [Qemu-devel] [PATCH v6 00/11] rdma: migration support

2013-05-09 Thread Michael R. Hines
Some more followup questions below to help me debug before I start digging in... On 05/09/2013 06:20 PM, Chegu Vinod wrote: Setting aside the mlock() freezes for the moment, let's first fix your crashing problem on the destination-side. Let's make that a priority before we fix the mlock

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-09 Thread Chegu Vinod
On 5/9/2013 1:05 PM, Igor Mammedov wrote: On Thu, 9 May 2013 12:43:20 -0700 Chegu Vinod wrote: If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest for some dur

Re: [Qemu-devel] [PATCH v6 00/11] rdma: migration support

2013-05-09 Thread Chegu Vinod
On 5/9/2013 10:20 AM, Michael R. Hines wrote: Comments inline. FYI: please CC mrhi...@us.ibm.com, because it helps me know when to scroll threw the bazillion qemu-devel emails. I have things separated out into folders and rules, but a direct CC is better =) Sure will do. On 05/03/2013

Re: [Qemu-devel] Profiling sparc64 emulation

2013-05-09 Thread Richard Henderson
On 05/09/2013 01:11 PM, Artyom Tarasenko wrote: > Is it possible to disable some optimisations, or the whole > optimisation completely? > I see no command line switches for that. No command-line switches. See the top lines of tcg/tcg.c for compile-time disabling. r~

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-09 Thread Igor Mammedov
On Thu, 9 May 2013 12:43:20 -0700 Chegu Vinod wrote: > If a user chooses to turn on the auto-converge migration capability > these changes detect the lack of convergence and throttle down the > guest. i.e. force the VCPUs out of the guest for some duration > and let the migration thread catc

Re: [Qemu-devel] Profiling sparc64 emulation

2013-05-09 Thread Artyom Tarasenko
On Thu, May 9, 2013 at 8:30 PM, Aurelien Jarno wrote: > On Wed, May 08, 2013 at 11:02:24PM +0200, Artyom Tarasenko wrote: >> On Wed, May 8, 2013 at 12:57 AM, Aurelien Jarno wrote: >> > On Tue, May 07, 2013 at 11:29:20PM +0200, Artyom Tarasenko wrote: >> >> On Tue, May 7, 2013 at 1:38 PM, Torbjorn

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-09 Thread Igor Mammedov
On Thu, 9 May 2013 12:43:20 -0700 Chegu Vinod wrote: > If a user chooses to turn on the auto-converge migration capability > these changes detect the lack of convergence and throttle down the > guest. i.e. force the VCPUs out of the guest for some duration > and let the migration thread catc

[Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-09 Thread Chegu Vinod
If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest for some duration and let the migration thread catchup and help converge. Verified the convergence using the foll

[Qemu-devel] [RFC PATCH v5 1/3] Introduce async_run_on_cpu()

2013-05-09 Thread Chegu Vinod
Introduce an asynchronous version of run_on_cpu() i.e. the caller doesn't have to block till the call back routine finishes execution on the target vcpu. Signed-off-by: Chegu Vinod --- cpus.c| 29 + include/qemu-common.h |1 + include/qom/cpu.

[Qemu-devel] [RFC PATCH v5 0/3] Throttle-down guest to help with live migration convergence.

2013-05-09 Thread Chegu Vinod
Busy enterprise workloads hosted on large sized VM's tend to dirty memory faster than the transfer rate achieved via live guest migration. Despite some good recent improvements (& using dedicated 10Gig NICs between hosts) the live migration does NOT converge. If a user chooses to force convergence

[Qemu-devel] [RFC PATCH v5 2/3] Add 'auto-converge' migration capability

2013-05-09 Thread Chegu Vinod
The auto-converge migration capability allows the user to specify if they choose live migration seqeunce to automatically detect and force convergence. Signed-off-by: Chegu Vinod --- include/migration/migration.h |2 ++ migration.c |9 + qapi-schema.json

Re: [Qemu-devel] Profiling sparc64 emulation

2013-05-09 Thread Paolo Bonzini
Il 09/05/2013 20:30, Aurelien Jarno ha scritto: > 13,16% libglib-2.0.so.0.3200.4 [.] g_hash_table_lookup > 8,18% libglib-2.0.so.0.3200.4 [.] g_str_hash > 2,47% qemu-system-ppc64[.] object_class_dynamic_cast > 1,97% qemu-system-ppc64[.] type_is_ancestor That's worrisome

Re: [Qemu-devel] Profiling sparc64 emulation

2013-05-09 Thread Aurelien Jarno
On Wed, May 08, 2013 at 11:02:24PM +0200, Artyom Tarasenko wrote: > On Wed, May 8, 2013 at 12:57 AM, Aurelien Jarno wrote: > > On Tue, May 07, 2013 at 11:29:20PM +0200, Artyom Tarasenko wrote: > >> On Tue, May 7, 2013 at 1:38 PM, Torbjorn Granlund wrote: > >> > The 2nd table of http://gmplib.org/

Re: [Qemu-devel] Reporting Heisenbugs in qemu

2013-05-09 Thread Blue Swirl
On Wed, May 8, 2013 at 10:18 AM, Paolo Bonzini wrote: > >> Paolo Bonzini writes: >> >> I guess that's the register windows. There's only so much you can do to >> optimize them, and heavily recursive workloads (like Perl, or the RTL >> half of GCC) pay a hefty price. >> >> Two qemu targets

Re: [Qemu-devel] sparc-linux-user: Fix missing symbols in .rel/.rela.plt sections

2013-05-09 Thread Blue Swirl
On Wed, May 8, 2013 at 7:18 AM, Michael Tokarev wrote: > Ping #2? > > 06.04.2013 10:08, Michael Tokarev wrote: >> This patch was submitted more than a year ago (at Jan-2012). >> Is it still needed? If yes, why it hasn't been applied? Well, is it still needed? >> >> It still applies cleanly to t

Re: [Qemu-devel] [PATCH] target-mips: clean-up in BIT_INSV

2013-05-09 Thread Peter Maydell
On 9 May 2013 18:28, Petar Jovanovic wrote: > @@ -2921,7 +2922,7 @@ target_ulong helper_##name(CPUMIPSState *env, > target_ulong rs, \ > return rt; \ > } \ >

Re: [Qemu-devel] [RFC] reverse execution.

2013-05-09 Thread Blue Swirl
On Tue, May 7, 2013 at 6:27 PM, KONRAD Frédéric wrote: > Hi, > > We are trying to find a way to do reverse execution happen with QEMU. > > Actually, it is possible to debug the guest through the gdbstub, we want to > make the reverse execution possible with GDB as well. > > How we are trying to ma

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/7] pci: add MPC105 PCI host bridge emulation

2013-05-09 Thread Blue Swirl
On Tue, May 7, 2013 at 5:48 AM, Hervé Poussineau wrote: > Andreas Färber a écrit : > >> Am 06.05.2013 22:57, schrieb Hervé Poussineau: >>> >>> Alexander Graf a écrit : On 05/03/2013 07:57 AM, Hervé Poussineau wrote: > > Alexander Graf a écrit : >> >> Am 02.05.2013 um 22:0

Re: [Qemu-devel] [PATCH for 1.5] target-i386 ROR r8/r16 imm instruction fix

2013-05-09 Thread Richard Henderson
On 05/09/2013 10:40 AM, Aurelien Jarno wrote: > Fix EFLAGS corruption by ROR r8/r16 imm instruction located at the end > of the TB, similarly to commit 089305ac for the non-immediate case. > > Reported-by: Hervé Poussineau > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > target-

Re: [Qemu-devel] [PATCH] target-mips: clean-up in BIT_INSV

2013-05-09 Thread Aurelien Jarno
On Thu, May 09, 2013 at 07:28:37PM +0200, Petar Jovanovic wrote: > From: Petar Jovanovic > > This is a small follow-up change to "fix incorrect behaviour for INSV". > > It includes two minor modifications: > > - sizefilter is constant so it can be moved inside of the block, > - (int64_t)0x01 is

Re: [Qemu-devel] [PATCH for 1.5] Revert "target-i386: Use movcond to implement rotate flags."

2013-05-09 Thread Aurelien Jarno
On Wed, May 01, 2013 at 08:06:51AM +0200, Hervé Poussineau wrote: > This commit breaks boot of MS-DOS 6.22, which stops at: > MODE CON CODEPAGE PREPARE=((850) C:\DOS\EGA.CPI) > > This reverts part of commit 34d80a55ff8517fd37bcfea5063b9797e2bd9132. > > Signed-off-by: Hervé Poussineau > --- > >

[Qemu-devel] [PATCH for 1.5] target-i386 ROR r8/r16 imm instruction fix

2013-05-09 Thread Aurelien Jarno
Fix EFLAGS corruption by ROR r8/r16 imm instruction located at the end of the TB, similarly to commit 089305ac for the non-immediate case. Reported-by: Hervé Poussineau Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- target-i386/translate.c |1 + 1 file changed, 1 insertion(+) dif

[Qemu-devel] [PATCH] target-mips: clean-up in BIT_INSV

2013-05-09 Thread Petar Jovanovic
From: Petar Jovanovic This is a small follow-up change to "fix incorrect behaviour for INSV". It includes two minor modifications: - sizefilter is constant so it can be moved inside of the block, - (int64_t)0x01 is replaced with 1LL for ease of reading. No functional change. Signed-off-by: Pe

Re: [Qemu-devel] [PATCH v6 00/11] rdma: migration support

2013-05-09 Thread Michael R. Hines
Comments inline. FYI: please CC mrhi...@us.ibm.com, because it helps me know when to scroll threw the bazillion qemu-devel emails. I have things separated out into folders and rules, but a direct CC is better =) On 05/03/2013 07:28 PM, Chegu Vinod wrote: Hi Michael, I picked up the qemu

Re: [Qemu-devel] (i386) TCG is broken in 1.5-rc0 with guest kernel 3.2?

2013-05-09 Thread Michael Tokarev
09.05.2013 20:52, Aurelien Jarno wrote: > On Thu, May 09, 2013 at 09:43:20AM -0700, Richard Henderson wrote: >> On 05/08/2013 02:03 AM, Michael Tokarev wrote: >>> I just tried 1.5-rc0 (32bit x86 userspace), and guest kernel crashes in an interesting way right at init time. qemu-syst

Re: [Qemu-devel] (i386) TCG is broken in 1.5-rc0 with guest kernel 3.2?

2013-05-09 Thread Aurelien Jarno
On Thu, May 09, 2013 at 09:43:20AM -0700, Richard Henderson wrote: > On 05/08/2013 02:03 AM, Michael Tokarev wrote: > > I just tried 1.5-rc0 (32bit x86 userspace), and guest kernel > >> crashes in an interesting way right at init time. > >> > >> qemu-system-x86_64 -net none -kernel /boot/vmlinuz-

Re: [Qemu-devel] [PATCH 01/40] memory: assert that PhysPageEntry's ptr does not overflow

2013-05-09 Thread Paolo Bonzini
Il 09/05/2013 05:41, liu ping fan ha scritto: > On Wed, May 8, 2013 at 12:08 AM, Paolo Bonzini wrote: >> >> >> - Messaggio originale - >>> Da: "Peter Maydell" >>> A: "Paolo Bonzini" >>> Cc: qemu-devel@nongnu.org, a...@ozlabs.ru, "jan kiszka" >>> , qemul...@gmail.com, >>> stefa...@redhat

Re: [Qemu-devel] (i386) TCG is broken in 1.5-rc0 with guest kernel 3.2?

2013-05-09 Thread Richard Henderson
On 05/08/2013 02:03 AM, Michael Tokarev wrote: > I just tried 1.5-rc0 (32bit x86 userspace), and guest kernel >> crashes in an interesting way right at init time. >> >> qemu-system-x86_64 -net none -kernel /boot/vmlinuz-3.2-amd64 -append >> console=ttyS0 -serial file:serial >> Irritatingly, th

[Qemu-devel] [PATCH 2/2] pci-assign: Add MSI affinity support

2013-05-09 Thread Alex Williamson
Track the last MSIMessage programmed so we can determine when it has changed and update the routing to the guest. Signed-off-by: Alex Williamson --- hw/i386/kvm/pci-assign.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/

[Qemu-devel] [PATCH 1/2] pci-assign: Refactor MSI virq array

2013-05-09 Thread Alex Williamson
Convert the msi_virq array into a struct array so we can easily add a place to track the MSIMessage for each vector. Signed-off-by: Alex Williamson --- hw/i386/kvm/pci-assign.c | 51 +++--- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/

[Qemu-devel] [PATCH 0/2] pci-assign: MSI affinity support

2013-05-09 Thread Alex Williamson
I posted these about 6 months ago and Jan felt we should implement MSI notifiers like we have for MSI-X. That still hasn't happened. This is a pretty trivial addition to pci-assign and could easily be ported to MSI notifiers if anyone cares enough down the road to implement them. I don't feel tha

[Qemu-devel] [PATCH] vfio-pci: Add support for MSI affinity

2013-05-09 Thread Alex Williamson
When MSI is accelerated through KVM the vectors are only programmed when the guest first enables MSI support.  Subsequent writes to the vector address or data fields are ignored.  Unfortunately that means we're ignore updates done to adjust SMP affinity of the vectors. MSI SMP affinity already work

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-05-09 Thread Jonathan Jefferson
** Changed in: linux (Ubuntu) Status: Incomplete => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1100843 Title: Live Migration Causes Performance Issues Status in QEMU: New Sta

Re: [Qemu-devel] [PATCH for-1.4.y 3/4] Handle CPU interrupts by inline checking of a flag

2013-05-09 Thread Michael Tokarev
09.05.2013 19:30, Michael Tokarev wrote: > Fix some of the nasty TCG race conditions and crashes by implementing ... Somehow this went out without proper authorship line, dunno why. I can resent if needed, adding: From: Peter Maydell Thanks, /mjt

[Qemu-devel] [PATCH for-1.4.y 4/4] translate-all.c: Remove cpu_unlink_tb()

2013-05-09 Thread Michael Tokarev
From: Peter Maydell The (unsafe) function cpu_unlink_tb() is now unused, so we can simply remove it and any code that was only used by it. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Blue Swirl (cherry picked from commit 3a808cc407744c30daa7470b5f191cde1fbc1aae

[Qemu-devel] [PATCH for-1.4.y 3/4] Handle CPU interrupts by inline checking of a flag

2013-05-09 Thread Michael Tokarev
Fix some of the nasty TCG race conditions and crashes by implementing cpu_exit() as setting a flag which is checked at the start of each TB. This avoids crashes if a thread or signal handler calls cpu_exit() while the execution thread is itself modifying the TB graph (which may happen in system emu

[Qemu-devel] [PATCH for-1.4.y 1/4] tcg: Document tcg_qemu_tb_exec() and provide constants for low bit uses

2013-05-09 Thread Michael Tokarev
From: Peter Maydell Document tcg_qemu_tb_exec(). In particular, its return value is a combination of a pointer to the next translation block and some extra information in the low two bits. Provide some #defines for the values passed in these bits to improve code clarity. Signed-off-by: Peter May

[Qemu-devel] [PATCH for-1.4.y 2/4] cpu-exec: wrap tcg_qemu_tb_exec() in a fn to restore the PC

2013-05-09 Thread Michael Tokarev
From: Peter Maydell If tcg_qemu_tb_exec() returns a value whose low bits don't indicate a link to an indexed next TB, this means that the TB execution never started (eg because the instruction counter hit zero). In this case the guest PC has to be reset to the address of the start of the TB. Ref

[Qemu-devel] [PATCH for-1.4.y 0/4] Drop the irredeemably racy cpu_unlink_tb()

2013-05-09 Thread Michael Tokarev
This is a backport of the patch series by Peter Maydell, as found at http://thread.gmane.org/gmane.comp.emulators.qemu/196629 , to 1.4.y stable tree, very similar to what's been done for 1.1 tree. The difference is in context and because some code were moved between exec.c and translate-all.c, but

Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm

2013-05-09 Thread Stefan Hajnoczi
On Thu, May 09, 2013 at 05:00:20PM +0800, liu ping fan wrote: > On Thu, May 9, 2013 at 4:30 PM, Stefan Hajnoczi wrote: > > On Thu, May 09, 2013 at 08:40:21AM +0800, Liu Ping Fan wrote: > >> From: Liu Ping Fan > >> > >> Hosts threads which handle vring should have high MemoryListener priority > >>

Re: [Qemu-devel] [PATCH] curl: fix curl read

2013-05-09 Thread Stefan Hajnoczi
On Thu, May 09, 2013 at 02:56:50PM +0800, Fam Zheng wrote: > On Thu, 05/09 08:41, Stefan Hajnoczi wrote: > > On Fri, May 03, 2013 at 04:00:09PM +0800, Fam Zheng wrote: > > > +cache = curl_find_cache(s, aio_base, aio_bytes); > > > +if (cache) { > > > +curl_complete_io(s, acb, cache);

Re: [Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-05-09 Thread Stefan Hajnoczi
On Thu, May 09, 2013 at 02:24:20PM +0800, Dong Xu Wang wrote: > On Thu, Apr 18, 2013 at 6:03 PM, Stefan Hajnoczi wrote: > > On Wed, Apr 10, 2013 at 04:11:52PM +0800, Dong Xu Wang wrote: > >> +static coroutine_fn int add_cow_co_flush(BlockDriverState *bs) > >> +{ > >> +BDRVAddCowState *s = bs->

Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm

2013-05-09 Thread Paolo Bonzini
Il 09/05/2013 10:54, liu ping fan ha scritto: > On Thu, May 9, 2013 at 4:44 PM, Michael S. Tsirkin wrote: >> On Thu, May 09, 2013 at 08:40:21AM +0800, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> Hosts threads which handle vring should have high MemoryListener priority >>> than kvm. For cur

[Qemu-devel] [RFC v2] virtio-balloon: automatic ballooning support

2013-05-09 Thread Luiz Capitulino
Automatic ballooning consists of dynamically adjusting the guest's balloon according to memory pressure in the host and in the guest. This commit implements the host side of automatic balloning, which basically consists of: 1. Registering with the memory.pressure_level API (from the Linux me

Re: [Qemu-devel] [PATCH 9/9] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-09 Thread Eric Blake
On 05/08/2013 11:27 PM, Zhang Xiaohe wrote: > 于 2013年05月09日 01:16, Eric Blake 写道: >> On 05/08/2013 02:50 AM, qiaonuohan wrote: >>> >>> Thanks for your suggestion. I will fix it like: >>> >>> { 'enum': 'DumpCompressionFormat', >>>'data': [ 'zlib', 'lzo', 'snappy' ] } >>> >>> For zlib is treated

Re: [Qemu-devel] [RFC PATCH 0/8] MemoryRegion and FlatView refcounting, replace hostmem with memory_region_find

2013-05-09 Thread Paolo Bonzini
Il 09/05/2013 02:53, liu ping fan ha scritto: > On Wed, May 8, 2013 at 11:44 PM, Paolo Bonzini wrote: >> Il 08/05/2013 08:20, liu ping fan ha scritto: >>> On Mon, May 6, 2013 at 10:25 PM, Paolo Bonzini wrote: Hi, this is an alternative approach to refactoring of dataplane's HostMem

Re: [Qemu-devel] [PATCH] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-09 Thread Bruce Rogers
>>> On 5/7/2013 at 05:47 AM, Anthony Liguori wrote: > From: Laszlo Ersek > > The qemu guest agent creates a bunch of files with insecure permissions > when started in daemon mode. For example: > > -rw-rw-rw- 1 root root /var/log/qemu-ga.log > -rw-rw-rw- 1 root root /var/run/qga.state >

Re: [Qemu-devel] [Xen-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.

2013-05-09 Thread Pasi Kärkkäinen
On Fri, Mar 15, 2013 at 06:14:30PM +, Frediano Ziglio wrote: > Modern notebook support 136x768 resolution. The resolution width is > not multiple of 16 causing some problems. > > Qemu VGA emulation require width resolution to be multiple of 8. > > VNC implementation require width resolution t

Re: [Qemu-devel] "virsh edit" failed to take effect on KVM

2013-05-09 Thread Eric Blake
On 05/09/2013 05:42 AM, Gonglei (Arei) wrote: > Hi all, >we use the command "virsh edit" to modify the VM configuration > information online on KVM Platform(libvirt-1.0.0 and qemu-1.4), > but it does not take effect after reboot. However, it works fine on Xen > Platform. This sort of quest

Re: [Qemu-devel] [PATCH 0/8] qapi: add support for lists of native types

2013-05-09 Thread mdroth
On Thu, May 09, 2013 at 03:31:08PM +0200, Laszlo Ersek wrote: > On 05/09/13 01:33, Michael Roth wrote: > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qapi-native-lists > > > > Sending this now since a number of series hav

Re: [Qemu-devel] [PATCH 6/8] qapi: add native list coverage for visitor serialization tests

2013-05-09 Thread mdroth
On Thu, May 09, 2013 at 02:31:03PM +0200, Laszlo Ersek wrote: > On 05/09/13 01:33, Michael Roth wrote: > > > +case PTYPE_NUMBER: { > > +numberList *ptr; > > +char *double1, *double2; > > +if (cur_head) { > > +ptr = cur_head; > > +

Re: [Qemu-devel] [PATCH 0/8] qapi: add support for lists of native types

2013-05-09 Thread Laszlo Ersek
On 05/09/13 01:33, Michael Roth wrote: > These patches apply on top of qemu.git master, and can also be obtained from: > git://github.com/mdroth/qemu.git qapi-native-lists > > Sending this now since a number of series have popped up in the past that > wanted this, and Amos has some pending patches

Re: [Qemu-devel] [PATCH for 1.5] tcg/optimize: fix setcond2 optimization

2013-05-09 Thread Richard Henderson
On 2013-05-08 15:42, Aurelien Jarno wrote: When setcond2 is rewritten into setcond, the state of the destination temp should be reset, so that a copy of the previous value is not used instead of the result. Reported-by: Michael Tokarev Cc: Richard Henderson Signed-off-by: Aurelien Jarno Rev

Re: [Qemu-devel] "virsh edit" failed to take effect on KVM

2013-05-09 Thread Laszlo Ersek
On 05/09/13 13:42, Gonglei (Arei) wrote: > Hi all, >we use the command "virsh edit" to modify the VM configuration > information online on KVM Platform(libvirt-1.0.0 and qemu-1.4), > but it does not take effect after reboot. However, it works fine on Xen > Platform. > >for an example

Re: [Qemu-devel] [PATCH 6/8] qapi: add native list coverage for visitor serialization tests

2013-05-09 Thread Laszlo Ersek
On 05/09/13 01:33, Michael Roth wrote: > +case PTYPE_NUMBER: { > +numberList *ptr; > +char *double1, *double2; > +if (cur_head) { > +ptr = cur_head; > +cur_head = ptr->next; > +} else { > +cur_h

[Qemu-devel] "virsh edit" failed to take effect on KVM

2013-05-09 Thread Gonglei (Arei)
Hi all, we use the command "virsh edit" to modify the VM configuration information online on KVM Platform(libvirt-1.0.0 and qemu-1.4), but it does not take effect after reboot. However, it works fine on Xen Platform. for an example,a VM is running with the following configuration infor

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-05-09 Thread Andreas Färber
Am 09.05.2013 10:09, schrieb Michael Tokarev: > 22.02.2013 22:09, Peter Maydell wrote: >> cpu-exec: wrap tcg_qemu_tb_exec() in a fn to restore the PC > > This needed a "back merge" of env+cpu states back to cpu. > Maybe we should somehow revisit the whole concept of the > two, because it's sorta

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-05-09 Thread Michael Tokarev
09.05.2013 13:01, Peter Maydell wrote: > On 9 May 2013 09:09, Michael Tokarev wrote: >> Now, the resulting thing compiles (ha!), but I'm not >> really sure how to test it. I ran a few random apps >> using qemu-i386 and qemu-arm, it appears to work. > > You need to test TCG system emulation too,

[Qemu-devel] [PULL for-1.5] spice: bugfix queue

2013-05-09 Thread Gerd Hoffmann
Hi, Tiny spice patch queue, featuring a single qxl bugfix. please pull, Gerd The following changes since commit 47ec15cdd44877e553ed0bd0a16aea8a295dad62: Update version for 1.5.0-rc1 (2013-05-08 15:54:47 -0500) are available in the git repository at: git://anongit.freedesktop.org/spic

[Qemu-devel] [PATCH] qxl: Call spice_qxl_driver_unload from qxl_enter_vga_mode

2013-05-09 Thread Gerd Hoffmann
From: Hans de Goede With a SPICE_DISPLAY_CAP_MONITORS_CONFIG capable client, the client needs to know what part of the primary to use for each monitor. If the guest driver does not support this, the server sends messages to the client for a single monitor spanning the entire primary. As soon as

Re: [Qemu-devel] [PATCH 2/2] mem: highlight the listener's priority as enum

2013-05-09 Thread liu ping fan
On Thu, May 9, 2013 at 5:21 PM, Peter Maydell wrote: > On 9 May 2013 01:40, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> It will make the priority prominent, when new listener added. >> All the priority's value are kept unchanged, except for vhost >> and hostmem.(Changes introduced by prev pa

Re: [Qemu-devel] [PATCH 2/2] mem: highlight the listener's priority as enum

2013-05-09 Thread Peter Maydell
On 9 May 2013 01:40, Liu Ping Fan wrote: > From: Liu Ping Fan > > It will make the priority prominent, when new listener added. > All the priority's value are kept unchanged, except for vhost > and hostmem.(Changes introduced by prev patch) Any chance of something somewhere which explains why th

Re: [Qemu-devel] [PATCH 2/2] mem: highlight the listener's priority as enum

2013-05-09 Thread liu ping fan
On Thu, May 9, 2013 at 4:31 PM, Stefan Hajnoczi wrote: > On Thu, May 09, 2013 at 08:40:22AM +0800, Liu Ping Fan wrote: >> diff --git a/include/exec/memory.h b/include/exec/memory.h >> index 9e88320..77e0d40 100644 >> --- a/include/exec/memory.h >> +++ b/include/exec/memory.h >> @@ -192,6 +192,16 @

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-05-09 Thread Peter Maydell
On 9 May 2013 09:09, Michael Tokarev wrote: > Now, the resulting thing compiles (ha!), but I'm not > really sure how to test it. I ran a few random apps > using qemu-i386 and qemu-arm, it appears to work. You need to test TCG system emulation too, and in particular something with multiple guest

Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm

2013-05-09 Thread liu ping fan
On Thu, May 9, 2013 at 4:30 PM, Stefan Hajnoczi wrote: > On Thu, May 09, 2013 at 08:40:21AM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Hosts threads which handle vring should have high MemoryListener priority >> than kvm. For currently code, take the following scenario: >> kvm_regio

Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm

2013-05-09 Thread liu ping fan
On Thu, May 9, 2013 at 4:44 PM, Michael S. Tsirkin wrote: > On Thu, May 09, 2013 at 08:40:21AM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Hosts threads which handle vring should have high MemoryListener priority >> than kvm. For currently code, take the following scenario: >> kvm_re

Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm

2013-05-09 Thread Michael S. Tsirkin
On Thu, May 09, 2013 at 08:40:21AM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > Hosts threads which handle vring should have high MemoryListener priority > than kvm. For currently code, take the following scenario: > kvm_region_add() run earlier before vhost_region_add(), then in guest,

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-mips: add missing check_dspr2 for multiply instructions

2013-05-09 Thread Michael Tokarev
08.05.2013 18:09, Petar Jovanovic wrote: > From: Petar Jovanovic > > The emulator needs to check in hflags if DSP unit has been turned off before > it generates code for MUL_PH, MUL_S_PH, MULQ_S_W, and MULQ_RS_W. > > Signed-off-by: Petar Jovanovic > --- > target-mips/translate.c |1 + > 1

Re: [Qemu-devel] [PATCH 2/2] mem: highlight the listener's priority as enum

2013-05-09 Thread Stefan Hajnoczi
On Thu, May 09, 2013 at 08:40:22AM +0800, Liu Ping Fan wrote: > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 9e88320..77e0d40 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -192,6 +192,16 @@ struct MemoryRegionSection { > > typedef struct MemoryList

Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm

2013-05-09 Thread Stefan Hajnoczi
On Thu, May 09, 2013 at 08:40:21AM +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > Hosts threads which handle vring should have high MemoryListener priority > than kvm. For currently code, take the following scenario: > kvm_region_add() run earlier before vhost_region_add(), then in guest,

Re: [Qemu-devel] qemu-img problem when create a file larger than fs's size

2013-05-09 Thread yuxh
On 05/09/2013 03:44 PM, Stefan Hajnoczi wrote: On Wed, May 08, 2013 at 01:18:17PM +0800, yuxh wrote: I have to consult you a qemu-img's problem. Is this reasonable to create a file which is larger than the available size of the fs by qemu-img cmd ? When I use qemu-img create a file which is

[Qemu-devel] [PATCH 4/4] translate-all.c: Remove cpu_unlink_tb()

2013-05-09 Thread Michael Tokarev
From: Peter Maydell The (unsafe) function cpu_unlink_tb() is now unused, so we can simply remove it and any code that was only used by it. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Blue Swirl (cherry picked from commit 3a808cc407744c30daa7470b5f191cde1fbc1aae

[Qemu-devel] [PATCH 1/4] tcg: Document tcg_qemu_tb_exec() and provide constants for low bit uses

2013-05-09 Thread Michael Tokarev
From: Peter Maydell Document tcg_qemu_tb_exec(). In particular, its return value is a combination of a pointer to the next translation block and some extra information in the low two bits. Provide some #defines for the values passed in these bits to improve code clarity. Signed-off-by: Peter May

[Qemu-devel] [PATCH 3/4] Handle CPU interrupts by inline checking of a flag

2013-05-09 Thread Michael Tokarev
From: Peter Maydell Fix some of the nasty TCG race conditions and crashes by implementing cpu_exit() as setting a flag which is checked at the start of each TB. This avoids crashes if a thread or signal handler calls cpu_exit() while the execution thread is itself modifying the TB graph (which ma

Re: [Qemu-devel] [PATCH 1/2] clean unnecessary code: don't check g_strdup arg for NULL

2013-05-09 Thread Michael Tokarev
09.05.2013 11:53, Dong Xu Wang wrote: > Signed-off-by: Dong Xu Wang Thank you Dong, (re)applied both patches to the trivial patch queue. /mjt

[Qemu-devel] [PATCH 2/4] cpu-exec: wrap tcg_qemu_tb_exec() in a fn to restore the PC

2013-05-09 Thread Michael Tokarev
From: Peter Maydell If tcg_qemu_tb_exec() returns a value whose low bits don't indicate a link to an indexed next TB, this means that the TB execution never started (eg because the instruction counter hit zero). In this case the guest PC has to be reset to the address of the start of the TB. Ref

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-05-09 Thread Michael Tokarev
[Rehashing a relatively old thread. It is available, in particular, at http://thread.gmane.org/gmane.comp.emulators.qemu/196629] 22.02.2013 22:09, Peter Maydell wrote: > This patch series gets rid of cpu_unlink_tb(), which is irredeemably > racy, since it modifies the TB graph with no locking fr

[Qemu-devel] [PATCH 2/2] remove double semicolons

2013-05-09 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- block/nbd.c | 2 +- fsdev/virtfs-proxy-helper.c | 4 ++-- hw/9pfs/virtio-9p-local.c | 2 +- hw/i386/pc_q35.c| 2 +- hw/intc/imx_avic.c | 2 +- hw/usb/host-linux.c | 4 ++-- qga/channel-win32.c | 2 +- 7 files c

[Qemu-devel] [PATCH 1/2] clean unnecessary code: don't check g_strdup arg for NULL

2013-05-09 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- util/uri.c | 2 +- vl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/util/uri.c b/util/uri.c index 4238729..e348c17 100644 --- a/util/uri.c +++ b/util/uri.c @@ -2162,7 +2162,7 @@ query_params_append (struct QueryParams *ps, }

  1   2   >