Re: [Qemu-devel] [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH)

2013-05-07 Thread Alexander Graf
On 08.05.2013, at 08:50, Aurelien Jarno wrote: > On Tue, May 07, 2013 at 09:30:24PM +0200, Torbjorn Granlund wrote: >> I realised a possible problem with my suggested patch. >> >> What about a 32-bit processor? Then NARROW_MODE macro is identical 0. >> >> The pre-patch behaviour was then to ig

Re: [Qemu-devel] [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH)

2013-05-07 Thread Aurelien Jarno
On Tue, May 07, 2013 at 09:30:24PM +0200, Torbjorn Granlund wrote: > I realised a possible problem with my suggested patch. > > What about a 32-bit processor? Then NARROW_MODE macro is identical 0. > > The pre-patch behaviour was then to ignore the L bit and decode both > 32-bit and 64-bit instr

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.5.0-rc0 is now available

2013-05-07 Thread Dongsheng Song
On Wed, May 8, 2013 at 12:27 AM, Anthony Liguori wrote: > > Hi, > > On behalf of the QEMU Team, I'd like to announce the availability of the > first release candidate for the QEMU 1.5 release. This release is meant > for testing purposes and should not be used in a production environment. > > htt

Re: [Qemu-devel] qemu-img problem when create a file larger than fs's size

2013-05-07 Thread Fam Zheng
I think it's the system admin to be responsible for the risk of over provisioning. We have host sparse file[1] (as your example) for preallocated image (for example, -f raw), as well as sparse image (as supported in qcow2, vmdk, etc.). There are cases that host file system is extended or the vm dis

Re: [Qemu-devel] [RFC PATCH 0/8] MemoryRegion and FlatView refcounting, replace hostmem with memory_region_find

2013-05-07 Thread liu ping fan
On Mon, May 6, 2013 at 10:25 PM, Paolo Bonzini wrote: > Hi, > > this is an alternative approach to refactoring of dataplane's HostMem > code. Here, I take Ping Fan's idea of RCU-style updating of the > region list and apply it to the AddressSpace's FlatView. With this In fact, I am worrying abo

[Qemu-devel] qemu-img problem when create a file larger than fs's size

2013-05-07 Thread yuxh
Hello all, I have to consult you a qemu-img's problem. Is this reasonable to create a file which is larger than the available size of the fs by qemu-img cmd ? When I use qemu-img create a file which is larger than the available size of the fs, the creation is completed succesfully. However

Re: [Qemu-devel] unknown keycodes

2013-05-07 Thread Ali
Daniel P. Berrange redhat.com> writes: > > Good, those are the interesting bits I wanted to see > > > _XKB_RULES_NAMES(STRING) = "base", "empty", "empty", "", "" > > I'll prepare a patch to test out which ought to fix OS-X > > Regards, > Daniel Any luck with this patch? I'm having the same i

[Qemu-devel] [PATCH] vhost: make priority higher than kvm

2013-05-07 Thread Liu Ping Fan
From: Liu Ping Fan vhost should have high priority than kvm. Take the following scenario: kvm_region_add earlier before vhost_region_add, then vring's desc[i] can refer addressX known by guest, and then used by guest. But vhost does not know this yet, and the vring handler will fail. Signed-of

Re: [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros

2013-05-07 Thread li guang
ping ... 在 2013-04-23二的 16:16 +0800,liguang写道: > remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF > as suggested by Richard Henderson > > Li Guang (12) >target-i386/helper: remove EAX macro >target-i386/helper: remove EBX macro >target-i386/helper: remove ECX

[Qemu-devel] Few Qs related to using qemu-nbd for exporting snapshot

2013-05-07 Thread Deepak C Shetty
Hi Anthony & the List, I am looking at using qemu-nbd to export an existing snapshot to a Backup virtual appliance (VA) and had the following Qs in that context... 1) Exporting an image using unix socket (-k option) Vs using --connect=/dev/nbd0, which one is better / preferred ? The idea

Re: [Qemu-devel] question about concurrent block job

2013-05-07 Thread Zhangleiqiang
Hi, Stefan: > The tricky parts are: > > 1. Extending the QMP API to support multiple block jobs. Old clients >only know how to deal with 1 block job but they should continue to >work. I think the block-job related qmp commands which are needed to change are as follows: 1. cmds for job

Re: [Qemu-devel] [PATCH 2/2] qga: try to unlink just created guest-file if fchmod() fails on it

2013-05-07 Thread Eric Blake
On 05/07/2013 06:35 PM, Laszlo Ersek wrote: >> This fixes the case of a mode file if fchmod fails, but doesn't fix >> the case of a mode 0666 file if fchmod succeeds but fdopen fails. It >> also requires that unlink() while open works (true for most Unix >> systems, but false for Windows syst

Re: [Qemu-devel] [PATCH] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-07 Thread Anthony Liguori
Anthony Liguori writes: > Applied. Thanks. Hi, This was an automated response so it doesn't acknowledge the fact that since this was a CVE, I applied the original patch regardless of review feedback to avoid any confusion about whether the CVE has been addressed. In the past, we've modified t

Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-07 Thread Jan Kiszka
On 2013-05-08 01:37, Jordan Justen wrote: > On Tue, May 7, 2013 at 3:25 PM, Paolo Bonzini wrote: >> Il 08/05/2013 00:01, Jordan Justen ha scritto: >>> On Tue, May 7, 2013 at 1:35 PM, Paolo Bonzini wrote: Il 07/05/2013 19:15, Jordan Justen ha scritto: > A slot that uses KVM_MEM_READONLY c

Re: [Qemu-devel] [PATCH 2/2] qga: try to unlink just created guest-file if fchmod() fails on it

2013-05-07 Thread Laszlo Ersek
On 05/07/13 19:30, Eric Blake wrote: > On 05/07/2013 10:56 AM, Laszlo Ersek wrote: >> We shouldn't allow guest filesystem pollution on error paths. >> >> Suggested-by: Eric Blake >> Signed-off-by: Laszlo Ersek >> --- >> qga/commands-posix.c |1 + >> 1 files changed, 1 insertions(+), 0 deleti

Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-07 Thread Jordan Justen
On Tue, May 7, 2013 at 3:25 PM, Paolo Bonzini wrote: > Il 08/05/2013 00:01, Jordan Justen ha scritto: >> On Tue, May 7, 2013 at 1:35 PM, Paolo Bonzini wrote: >>> Il 07/05/2013 19:15, Jordan Justen ha scritto: A slot that uses KVM_MEM_READONLY can be read from and code can execute from t

Re: [Qemu-devel] [PATCH v2] linux-user: improve target_to_host_sock_type conversion

2013-05-07 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/232770/ From: Petar Jovanovic Sent: Tuesday, April 30, 2013 3:20 AM To: Andreas Färber Cc: Aurelien Jarno; Petar Jovanovic; blauwir...@gmail.com; riku.voi...@linaro.org; qemu-devel@nongnu.org; r...@twiddle.net; Alexan

Re: [Qemu-devel] Reporting Heisenbugs in qemu

2013-05-07 Thread Torbjorn Granlund
Artyom Tarasenko writes: Meaning it's even faster than estimated? That's fast. I don't see in the table, how long does the build take? About one hour. That's for: configure + make + make check TESTS= (The host is a 4X 3.6 GHz Bulldozer Zambezi.) -- Torbjörn

Re: [Qemu-devel] [PATCH RFC 0/3] seabios: move acpi table formatting out of bios

2013-05-07 Thread Kevin O'Connor
On Tue, May 07, 2013 at 09:00:48PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 25, 2013 at 12:02:20PM +0300, Michael S. Tsirkin wrote: > > Untested yet, but I thought I'd share the > > BIOS bits so we can agree on direction. > > > > In particular check out ROM sizes: > > - Before patchset with

Re: [Qemu-devel] [libvirt]virtio serial device problem

2013-05-07 Thread Alexey Kardashevskiy
On 05/07/2013 07:50 PM, Paolo Bonzini wrote: > Il 07/05/2013 09:20, Li Zhang ha scritto: >> Hi all, >> >> When we use the latest version of QEMU to build ovirt, >> we get this error reported from libvirt. > > What QEMU commit is this? b3e6d591b05538056d665572f3e3bbfb3cbb70e7 > It might have be

Re: [Qemu-devel] Reporting Heisenbugs in qemu

2013-05-07 Thread Aurelien Jarno
On Tue, May 07, 2013 at 11:29:20PM +0200, Artyom Tarasenko wrote: > On Tue, May 7, 2013 at 1:38 PM, Torbjorn Granlund wrote: > > The 2nd table of http://gmplib.org/devel/testsystems.html shows all > > emulated systems I am using, most of which are qemu-based. > > Do I read it correct that qemu-sy

[Qemu-devel] Possible ppc comparision optimisation

2013-05-07 Thread Torbjorn Granlund
The current ppc gen_op_cmp generates a long sequence of instructions, using a plain series of three disjoint compares. It is possible to compute the 3 result bits more cleverly. Below is a possible replacement gen_op_cmp. (It is tested by booting GNU/Linux ppx64, but not much more than that.) S

Re: [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering

2013-05-07 Thread Jan Kiszka
On 2013-05-07 23:03, Jordan Justen wrote: > On Sun, Mar 24, 2013 at 11:06 AM, Jan Kiszka wrote: >> On 2013-02-25 16:44, Jan Kiszka wrote: >>> On 2013-02-25 16:39, Anthony Liguori wrote: Jan Kiszka writes: > This is in fact very simply: When the input in grabbed, everything > sho

[Qemu-devel] [PATCH v4] Add 'maxqdepth' as an option to tty character devices.

2013-05-07 Thread John Baboval
From: "John V. Baboval" This parameter will cause writes to tty backed chardevs to return -EAGAIN if the backing tty has buffered more than the specified number of characters. When data is sent, the TIOCOUTQ ioctl is invoked to determine the current TTY output buffer depth. Background: Some dev

Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-07 Thread Paolo Bonzini
Il 08/05/2013 00:01, Jordan Justen ha scritto: > On Tue, May 7, 2013 at 1:35 PM, Paolo Bonzini wrote: >> Il 07/05/2013 19:15, Jordan Justen ha scritto: >>> A slot that uses KVM_MEM_READONLY can be read from and code >>> can execute from the region, but writes will trap. >>> >>> For regions that ar

Re: [Qemu-devel] [PATCH] Add 'maxqdepth' as an option to tty character devices.

2013-05-07 Thread John Baboval
Sorry about fumbling with the tools. The wiki link is very helpful. I'll give it another go in a little while. -Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Tuesday, May 07, 2013 1:17 PM To: John Baboval Cc: qemu-devel@nongnu.org; John Baboval Subject: Re: [Qemu-de

Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-07 Thread Peter Maydell
On 7 May 2013 23:01, Jordan Justen wrote: > I think qemu would be better served by mr->readtrap and mr->writetrap > booleans. I'm not convinced, because from QEMU's point of view "trap" ought to mean "deliver a fault to the guest", which isn't what we want to do for writes here. -- PMM

Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-07 Thread Jordan Justen
On Tue, May 7, 2013 at 1:35 PM, Paolo Bonzini wrote: > Il 07/05/2013 19:15, Jordan Justen ha scritto: >> A slot that uses KVM_MEM_READONLY can be read from and code >> can execute from the region, but writes will trap. >> >> For regions that are readonly and also not writeable, we >> force the slo

Re: [Qemu-devel] [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH)

2013-05-07 Thread Alexander Graf
Am 07.05.2013 um 21:30 schrieb Torbjorn Granlund : > I realised a possible problem with my suggested patch. > > What about a 32-bit processor? Then NARROW_MODE macro is identical 0. > > The pre-patch behaviour was then to ignore the L bit and decode both > 32-bit and 64-bit instruction in the

Re: [Qemu-devel] Reporting Heisenbugs in qemu

2013-05-07 Thread Artyom Tarasenko
On Tue, May 7, 2013 at 11:43 PM, Torbjorn Granlund wrote: > Artyom Tarasenko writes: > > Do I read it correct that qemu-system-ppc64 with the slowdown factor > of 33 is ~3 times faster than qemu-system-sparc64 with the slowdown > factor of 96 ? > > You read it correctly. > > But please see

Re: [Qemu-devel] Reporting Heisenbugs in qemu

2013-05-07 Thread Torbjorn Granlund
Artyom Tarasenko writes: Do I read it correct that qemu-system-ppc64 with the slowdown factor of 33 is ~3 times faster than qemu-system-sparc64 with the slowdown factor of 96 ? You read it correctly. But please see the caveat at the table end. Do they both use Debian Wheezy guest? You

Re: [Qemu-devel] [PATCH v4 0/6] KVM flash memory support

2013-05-07 Thread Jordan Justen
On Tue, May 7, 2013 at 1:28 PM, Paolo Bonzini wrote: > Il 07/05/2013 19:15, Jordan Justen ha scritto: >> git://github.com/jljusten/qemu.git kvm-flash-v4 >> >> Utilize KVM_CAP_READONLY_MEM to support PC system flash emulation >> with KVM. >> >> v4: >> * With a machine type of isapc, don't mark the

Re: [Qemu-devel] Reporting Heisenbugs in qemu

2013-05-07 Thread Artyom Tarasenko
On Tue, May 7, 2013 at 1:38 PM, Torbjorn Granlund wrote: > The 2nd table of http://gmplib.org/devel/testsystems.html shows all > emulated systems I am using, most of which are qemu-based. Do I read it correct that qemu-system-ppc64 with the slowdown factor of 33 is ~3 times faster than qemu-syste

Re: [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering

2013-05-07 Thread Jordan Justen
On Sun, Mar 24, 2013 at 11:06 AM, Jan Kiszka wrote: > On 2013-02-25 16:44, Jan Kiszka wrote: >> On 2013-02-25 16:39, Anthony Liguori wrote: >>> Jan Kiszka writes: >>> This is in fact very simply: When the input in grabbed, everything should be exclusively passed to the guest - except it

Re: [Qemu-devel] [PATCH] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-07 Thread Eric Blake
On 05/07/2013 02:28 PM, mdroth wrote: >> >> This points out that: >> >> 1. the documentation for guest-file-open is insufficient to describe our >> limitations (for example, although C11 requires support for the "wx" >> flag, this patch forbids that flag) > > Got a pointer? I can fix up the docs i

Re: [Qemu-devel] [PATCH v4 4/6] pflash_cfi01: memory region should be set to enable readonly mode

2013-05-07 Thread Paolo Bonzini
Il 07/05/2013 19:15, Jordan Justen ha scritto: > This causes any writes to the memory region to trap to the > device handler. > > This is also important for KVM, because this allows the memory > region to be set using KVM_MEM_READONLY, which allows the memory > region to be read & executed. (Witho

Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-07 Thread Paolo Bonzini
Il 07/05/2013 19:15, Jordan Justen ha scritto: > A slot that uses KVM_MEM_READONLY can be read from and code > can execute from the region, but writes will trap. > > For regions that are readonly and also not writeable, we > force the slot to be removed so reads or writes to the region > will trap

Re: [Qemu-devel] [PATCH v4 0/6] KVM flash memory support

2013-05-07 Thread Paolo Bonzini
Il 07/05/2013 19:15, Jordan Justen ha scritto: > git://github.com/jljusten/qemu.git kvm-flash-v4 > > Utilize KVM_CAP_READONLY_MEM to support PC system flash emulation > with KVM. > > v4: > * With a machine type of isapc, don't mark the BIOS as read-only. >isapc + seabios will not boot if the

Re: [Qemu-devel] [PATCH] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-07 Thread mdroth
On Tue, May 07, 2013 at 09:55:06AM -0600, Eric Blake wrote: > On 05/07/2013 05:47 AM, Anthony Liguori wrote: > > From: Laszlo Ersek > > > > The qemu guest agent creates a bunch of files with insecure permissions > > when started in daemon mode. For example: > > > > -rw-rw-rw- 1 root root /var/

Re: [Qemu-devel] [PATCH 00/40] Memory-related changes sneak peek for 1.6

2013-05-07 Thread Paolo Bonzini
Il 07/05/2013 20:51, Peter Maydell ha scritto: > On 7 May 2013 15:16, Paolo Bonzini wrote: >> Patches 1-10 are small changes, some of them bugfixes for the IOMMU >> portion of the patches. >> >> Patches 11-13 introduce three new address_space APIs and clean up >> the dispatch logic a bit by removi

Re: [Qemu-devel] [PATCH 1/2] qga: distinguish binary modes in "guest_file_open_modes" map

2013-05-07 Thread mdroth
On Tue, May 07, 2013 at 11:27:03AM -0600, Eric Blake wrote: > On 05/07/2013 10:56 AM, Laszlo Ersek wrote: > > In Windows guests this may make a difference. > > > > Suggested-by: Eric Blake > > Signed-off-by: Laszlo Ersek > > --- > > qga/commands-posix.c | 22 -- > > 1 file

Re: [Qemu-devel] [PATCH 40/40] memory: add reference counting to FlatView

2013-05-07 Thread Paolo Bonzini
Il 07/05/2013 20:00, Jan Kiszka ha scritto: > On 2013-05-07 16:17, Paolo Bonzini wrote: >> With this change, a FlatView can be used even after a concurrent >> update has replaced it. Because we do not have RCU, we use a >> mutex to protect the small critical sections that read/write the >> as->cur

Re: [Qemu-devel] [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH)

2013-05-07 Thread Torbjorn Granlund
I realised a possible problem with my suggested patch. What about a 32-bit processor? Then NARROW_MODE macro is identical 0. The pre-patch behaviour was then to ignore the L bit and decode both 32-bit and 64-bit instruction in the same way. Apparently that is correct behaviour. (The manual is

Re: [Qemu-devel] [PATCH 1/2] qga: distinguish binary modes in "guest_file_open_modes" map

2013-05-07 Thread Peter Maydell
On 7 May 2013 18:27, Eric Blake wrote: > On 05/07/2013 10:56 AM, Laszlo Ersek wrote: >> In Windows guests this may make a difference. >> >> Suggested-by: Eric Blake >> Signed-off-by: Laszlo Ersek > Oh, and only NOW do I notice that this is in a file named > commands-posix.c that doesn't get com

Re: [Qemu-devel] [PATCH 00/40] Memory-related changes sneak peek for 1.6

2013-05-07 Thread Peter Maydell
On 7 May 2013 15:16, Paolo Bonzini wrote: > Patches 1-10 are small changes, some of them bugfixes for the IOMMU > portion of the patches. > > Patches 11-13 introduce three new address_space APIs and clean up > the dispatch logic a bit by removing memory_region_section_addr. > > Patches 14-22 intro

Re: [Qemu-devel] [PATCH] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-07 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-05-07 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5] configure: Check that "libtool" is not the MacOSX one

2013-05-07 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 20/40] pci: use memory core for iommu support

2013-05-07 Thread Peter Maydell
On 7 May 2013 15:16, Paolo Bonzini wrote: > From: Avi Kivity > > Use the new iommu support in the memory core for iommu support. The only > user, spapr, is also converted, but it still provides a DMAContext > interface until the non-PCI bits switch to AddressSpace. > > Cc: Michael S. Tsirkin >

[Qemu-devel] [RFC] reverse execution.

2013-05-07 Thread KONRAD Frédéric
Hi, We are trying to find a way to do reverse execution happen with QEMU. Actually, it is possible to debug the guest through the gdbstub, we want to make the reverse execution possible with GDB as well. How we are trying to make that working (basically without optimisation): -QEMU takes regul

Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling

2013-05-07 Thread Jan Kiszka
On 2013-05-07 19:26, Jan Kiszka wrote: > Well, the alternative is to handle a sub-page dispatch (ie. calling into > subpage_[ram_]read/write just like address_space_rw: take the necessary > lock that protect mapping changes, look into the sub-page and pick up > the target region, invoke memory_regi

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: fix 017 018 for vmdk

2013-05-07 Thread Jeff Cody
On Tue, May 07, 2013 at 07:13:05PM +0800, Fam Zheng wrote: > 017 and 018 use /bin/mv to move base img from t.IMGFMG to t.IMGFMT.base > after filling data, this is not enough for vmdk, when t.IMGFMT is only a > description text file who points to t-{flat,s001,f001,...}.IMGFMT as > data extent, so te

Re: [Qemu-devel] [PATCH 19/40] dma: eliminate old-style IOMMU support

2013-05-07 Thread Peter Maydell
On 7 May 2013 15:16, Paolo Bonzini wrote: > The translate function in the DMAContext is now always NULL. > Remove every reference to it. > --- a/include/sysemu/dma.h > +++ b/include/sysemu/dma.h > -static inline int dma_memory_rw_relaxed(DMAContext *dma, dma_addr_t addr, > -

Re: [Qemu-devel] [PATCH 14/40] memory: iommu support

2013-05-07 Thread Peter Maydell
On 7 May 2013 15:16, Paolo Bonzini wrote: > From: Avi Kivity > > Add a new memory region type that translates addresses it is given, > then forwards them to a target address space. This is similar to > an alias, except that the mapping is more flexible than a linear > translation and trucation,

Re: [Qemu-devel] [PATCH 1/3] qemu-iotests: exclude vmdk for test 042

2013-05-07 Thread Jeff Cody
On Tue, May 07, 2013 at 07:13:03PM +0800, Fam Zheng wrote: > Zero sized disk is not supported by qemu vmdk driver, exclude vmdk from > the test script. > > As tested on vmware-vdiskmanager and vmware workstation, zero sized disk > is not supported by vmware, either. > > Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: exclude vmdk from 043

2013-05-07 Thread Jeff Cody
On Tue, May 07, 2013 at 07:13:04PM +0800, Fam Zheng wrote: > 043 tests recursive backing file by changing backing file. VMDK has not > implemented this yet. > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/043 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qe

Re: [Qemu-devel] [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH)

2013-05-07 Thread Torbjorn Granlund
Alexander Graf writes: > The first hunk is just a comment about suspicious code. I don't suggest > to apply that. The "suspicious" code is correct. The Rc update should indeed be SF-mode dependent. With the other 4 hunks, qemu-ppc64 is now able to execute GMP's testsuite to completion, us

Re: [Qemu-devel] [PATCH 40/40] memory: add reference counting to FlatView

2013-05-07 Thread Jan Kiszka
On 2013-05-07 20:00, Jan Kiszka wrote: > On 2013-05-07 16:17, Paolo Bonzini wrote: >> With this change, a FlatView can be used even after a concurrent >> update has replaced it. Because we do not have RCU, we use a >> mutex to protect the small critical sections that read/write the >> as->current_

Re: [Qemu-devel] [PATCH 12/40] memory: add address_space_translate

2013-05-07 Thread Peter Maydell
On 7 May 2013 15:16, Paolo Bonzini wrote: > Using phys_page_find to translate an AddressSpace to a MemoryRegionSection > is unwieldy. It requires to pass the page index rather than the address, > and later memory_region_section_addr has to be called. Replace > memory_region_section_addr with a f

Re: [Qemu-devel] [PATCH 40/40] memory: add reference counting to FlatView

2013-05-07 Thread Jan Kiszka
On 2013-05-07 16:17, Paolo Bonzini wrote: > With this change, a FlatView can be used even after a concurrent > update has replaced it. Because we do not have RCU, we use a > mutex to protect the small critical sections that read/write the > as->current_map pointer. Accesses to the FlatView can be

Re: [Qemu-devel] [PATCH RFC 0/3] seabios: move acpi table formatting out of bios

2013-05-07 Thread Michael S. Tsirkin
On Thu, Apr 25, 2013 at 12:02:20PM +0300, Michael S. Tsirkin wrote: > Untested yet, but I thought I'd share the > BIOS bits so we can agree on direction. > > In particular check out ROM sizes: > - Before patchset with DSDT enabled > Total size: 127880 Fixed: 59060 Free: 3192 (used 97.6% of 1

Re: [Qemu-devel] [PATCH 2/2] qga: try to unlink just created guest-file if fchmod() fails on it

2013-05-07 Thread Eric Blake
On 05/07/2013 10:56 AM, Laszlo Ersek wrote: > We shouldn't allow guest filesystem pollution on error paths. > > Suggested-by: Eric Blake > Signed-off-by: Laszlo Ersek > --- > qga/commands-posix.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-posix.c

Re: [Qemu-devel] [PATCH 11/40] memory: add address_space_valid

2013-05-07 Thread Peter Maydell
On 7 May 2013 15:16, Paolo Bonzini wrote: > Checking whether an address space is possible in the old-style > IOMMU implementation, but there is no equivalent in the memory API. This sentence appears to be missing a clause ("whether an address space is valid" ?) > Implement it with a lookup of th

Re: [Qemu-devel] [PATCH 08/40] memory: limit sections in the radix tree to the actual address space size

2013-05-07 Thread Alexander Graf
On 05/07/2013 07:24 PM, Paolo Bonzini wrote: - Messaggio originale - Da: "Peter Maydell" A: "Paolo Bonzini" Cc: qemu-devel@nongnu.org, a...@ozlabs.ru, "jan kiszka", qemul...@gmail.com, "Avi Kivity" , stefa...@redhat.com, da...@gibson.dropbear.id.au Inviato: Martedì, 7 maggio 2013 19:13

Re: [Qemu-devel] [PATCH 1/2] qga: distinguish binary modes in "guest_file_open_modes" map

2013-05-07 Thread Eric Blake
On 05/07/2013 10:56 AM, Laszlo Ersek wrote: > In Windows guests this may make a difference. > > Suggested-by: Eric Blake > Signed-off-by: Laszlo Ersek > --- > qga/commands-posix.c | 22 -- > 1 files changed, 16 insertions(+), 6 deletions(-) > > diff --git a/qga/commands-p

Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling

2013-05-07 Thread Jan Kiszka
On 2013-05-07 14:35, Paolo Bonzini wrote: > Il 06/05/2013 22:46, Peter Maydell ha scritto: >> On 6 May 2013 15:26, Jan Kiszka wrote: >>> Simplify the sub-page handling by implementing it directly in the >>> dispatcher instead of using a redirection memory region. We extend the >>> phys_sections en

[Qemu-devel] [PATCH v4 4/6] pflash_cfi01: memory region should be set to enable readonly mode

2013-05-07 Thread Jordan Justen
This causes any writes to the memory region to trap to the device handler. This is also important for KVM, because this allows the memory region to be set using KVM_MEM_READONLY, which allows the memory region to be read & executed. (Without this, KVM will not support executing from the memory reg

Re: [Qemu-devel] [PATCH 09/40] memory: create FlatView for new address spaces

2013-05-07 Thread Peter Maydell
On 7 May 2013 15:16, Paolo Bonzini wrote: > A new address space has an empty FlatView. In order to create it, we > must (a) call memory_region_transaction_commit after the address space is > inserted into the list; (b) force memory_region_transaction_commit to > do something. > > This bug was lat

Re: [Qemu-devel] [PATCH 08/40] memory: limit sections in the radix tree to the actual address space size

2013-05-07 Thread Paolo Bonzini
- Messaggio originale - > Da: "Peter Maydell" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, a...@ozlabs.ru, "jan kiszka" > , qemul...@gmail.com, "Avi Kivity" > , stefa...@redhat.com, da...@gibson.dropbear.id.au > Inviato: Martedì, 7 maggio 2013 19:13:16 > Oggetto: Re: [Qemu-devel]

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5-git gpu clock control doesn`t work after guest reboot

2013-05-07 Thread commiethebeastie
>Are you attempting to rebind the HD6850 to host drivers after qemu is shutdown No, I did not rebind HD6850 to the host system. System hangs at shutdown guest >HD6850 - works fully, host hang on guest poweroff Yes. -- You received this bug notification because you are a member of qemu- devel-m

[Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions

2013-05-07 Thread Jordan Justen
A slot that uses KVM_MEM_READONLY can be read from and code can execute from the region, but writes will trap. For regions that are readonly and also not writeable, we force the slot to be removed so reads or writes to the region will trap. (A memory region in this state is not executable within k

Re: [Qemu-devel] [PATCH 1/2] qga: distinguish binary modes in "guest_file_open_modes" map

2013-05-07 Thread Eric Blake
On 05/07/2013 10:56 AM, Laszlo Ersek wrote: > In Windows guests this may make a difference. > > Suggested-by: Eric Blake > Signed-off-by: Laszlo Ersek > --- > qga/commands-posix.c | 22 -- > 1 files changed, 16 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake -- E

Re: [Qemu-devel] [PATCH] Add 'maxqdepth' as an option to tty character devices.

2013-05-07 Thread Eric Blake
On 05/07/2013 10:51 AM, John Baboval wrote: > From: "John V. Baboval" > > This parameter will cause writes to tty backed chardevs to return > -EAGAIN if the backing tty has buffered more than the specified > number of characters. When data is sent, the TIOCOUTQ ioctl is invoked > to determine the

[Qemu-devel] [PATCH v4 0/6] KVM flash memory support

2013-05-07 Thread Jordan Justen
git://github.com/jljusten/qemu.git kvm-flash-v4 Utilize KVM_CAP_READONLY_MEM to support PC system flash emulation with KVM. v4: * With a machine type of isapc, don't mark the BIOS as read-only. isapc + seabios will not boot if the BIOS is read-only. This matches the current behavior of isa

[Qemu-devel] [PATCH v4 1/6] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-07 Thread Jordan Justen
The isapc machine with seabios currently requires the BIOS region to be read/write memory rather than read-only memory. KVM currently cannot support the BIOS as a ROM region, but qemu in non-KVM mode can. Based on this, isapc machine currently only works with KVM. To work-around this isapc issue,

[Qemu-devel] [PATCH v4 6/6] pc_sysfw: change rom_only default to 0

2013-05-07 Thread Jordan Justen
Now KVM can support a flash memory. This feature depends on KVM_CAP_READONLY_MEM, which was introduced in Linux 3.7. Flash memory will only be enabled if a pflash device is created. (For example, by using the -pflash command line parameter.) Signed-off-by: Jordan Justen --- hw/block/pc_sysfw.c

[Qemu-devel] [PATCH v4 5/6] pc_sysfw: allow flash (-pflash) memory to be used with KVM

2013-05-07 Thread Jordan Justen
When pc-sysfw.rom_only != 0, flash memory will be usable with kvm. In order to enable flash memory mode, a pflash device must be created. (For example, by using the -pflash command line parameter.) Usage of a flash memory device with kvm requires the KVM READONLY memory capability, and kvm will ab

[Qemu-devel] [PATCH v4 2/6] kvm: add kvm_readonly_mem_enabled

2013-05-07 Thread Jordan Justen
Signed-off-by: Jordan Justen --- include/sysemu/kvm.h | 10 ++ kvm-all.c|6 ++ kvm-stub.c |1 + 3 files changed, 17 insertions(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 9735c1d..13c4b2e 100644 --- a/include/sysemu/kvm.h +++ b/in

Re: [Qemu-devel] [PATCH 08/40] memory: limit sections in the radix tree to the actual address space size

2013-05-07 Thread Peter Maydell
On 7 May 2013 15:16, Paolo Bonzini wrote: > From: Avi Kivity > > The radix tree is statically sized to fit TARGET_PHYS_ADDR_SPACE_BITS. > If a larger memory region is registered, it will overflow. > > Fix by limiting any section in the radix tree to the supported size. > > This problem was not ob

Re: [Qemu-devel] [PATCH 9/9] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-07 Thread Eric Blake
On 05/07/2013 01:16 AM, Qiao Nuohan wrote: > Make monitor command 'dump-guest-memory' dump in kdump-compressed format. > The command's usage: > dump [-p] protocol [flags] [begin] [length] > With 'flags' set, the core file will be in kdump-compress format, and without > it, the format is ELF. 'fla

Re: [Qemu-devel] [Qemu-ppc] Incorrect handling of more PPC64 insns (PATCH)

2013-05-07 Thread Alexander Graf
On 05/07/2013 05:58 PM, Torbjorn Granlund wrote: OK, so took to reading some of translate to see how well it agrees with the PPC architecture definition. I spotted a bug with cmp, which was repeated 4 times. Somebody decided that NARROW_MODE should affect the handling of cmp instructions, which

Re: [Qemu-devel] [PATCH v2] memory: Rename readable flag to romd_mode

2013-05-07 Thread Peter Maydell
On 7 May 2013 18:04, Jan Kiszka wrote: > "Readable" is a very unfortunate name for this flag because even a > rom_device region will always be readable from the guest POV. What > differs is the mapping, just like the comments had to explain already. > Also, readable could currently be understood a

[Qemu-devel] [PATCH v2] memory: Rename readable flag to romd_mode

2013-05-07 Thread Jan Kiszka
"Readable" is a very unfortunate name for this flag because even a rom_device region will always be readable from the guest POV. What differs is the mapping, just like the comments had to explain already. Also, readable could currently be understood as being a generic region flag, but it only appli

[Qemu-devel] [PATCH v3] Add 'maxqdepth' as an option to tty character devices.

2013-05-07 Thread John Baboval
Includes changes requested by Eric Blake and Paolo Bonzini

[Qemu-devel] [PATCH 2/2] qga: try to unlink just created guest-file if fchmod() fails on it

2013-05-07 Thread Laszlo Ersek
We shouldn't allow guest filesystem pollution on error paths. Suggested-by: Eric Blake Signed-off-by: Laszlo Ersek --- qga/commands-posix.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 2eec712..d301b1f 100644 --- a/qg

[Qemu-devel] [PATCH 1/2] qga: distinguish binary modes in "guest_file_open_modes" map

2013-05-07 Thread Laszlo Ersek
In Windows guests this may make a difference. Suggested-by: Eric Blake Signed-off-by: Laszlo Ersek --- qga/commands-posix.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 04c6951..2eec712 100644 --

[Qemu-devel] [PATCH] Add 'maxqdepth' as an option to tty character devices.

2013-05-07 Thread John Baboval
From: "John V. Baboval" This parameter will cause writes to tty backed chardevs to return -EAGAIN if the backing tty has buffered more than the specified number of characters. When data is sent, the TIOCOUTQ ioctl is invoked to determine the current TTY output buffer depth. Background: Some dev

Re: [Qemu-devel] [PATCH] Add 'maxqdepth' as an option to tty character devices.

2013-05-07 Thread John Baboval
Hmm. I seem to have screwed up the "In-Reply-To" on this one. Sorry about that. On 05/07/2013 12:36 PM, John Baboval wrote: From: "John V. Baboval" This parameter will cause writes to tty backed chardevs to return -EAGAIN if the backing tty has buffered more than the specified number of chara

[Qemu-devel] [PATCH] Add 'maxqdepth' as an option to tty character devices.

2013-05-07 Thread John Baboval
From: "John V. Baboval" This parameter will cause writes to tty backed chardevs to return -EAGAIN if the backing tty has buffered more than the specified number of characters. When data is sent, the TIOCOUTQ ioctl is invoked to determine the current TTY output buffer depth. Background: Some dev

[Qemu-devel] (no subject)

2013-05-07 Thread John Baboval
Thanks for the feedback. I've made the maxqdepth parameter optional as requested.

[Qemu-devel] [ANNOUNCE] QEMU 1.5.0-rc0 is now available

2013-05-07 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 1.5 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.5.0-rc0.tar.bz2 You can help improve

Re: [Qemu-devel] [PATCH 1/9] Add API to manipulate dump_bitmap

2013-05-07 Thread Daniel P. Berrange
On Tue, May 07, 2013 at 10:14:11AM -0600, Eric Blake wrote: > On 05/07/2013 01:16 AM, Qiao Nuohan wrote: > > Struct dump_bitmap is associated with a tmp file, and the tmp file can be > > used > > to save data of bitmap in kdump-compressed format temporarily. > > The following patch will use these

Re: [Qemu-devel] Reporting Heisenbugs in qemu

2013-05-07 Thread Torbjorn Granlund
Aurelien Jarno writes: Which version of QEMU are you using? This looks like a bug that has appeared in version 1.3.0 and fixed in version 1.4.1. The corresponding commit in master is 52ae646d4a3ebdcdcc973492c6a56f2c49b6578f I cannot tell exactly, since I didn't keep sources to each qemu co

Re: [Qemu-devel] [PATCH 01/40] memory: assert that PhysPageEntry's ptr does not overflow

2013-05-07 Thread Peter Maydell
On 7 May 2013 17:08, Paolo Bonzini wrote: >> Da: "Peter Maydell" >> Why is the limit we're asserting not the same as the maximum >> size that we pass to g_renew() below? > > That's a minimum size, isn't it? Doh, so it is. > I'm asserting that the physical section number doesn't overflow into >

Re: [Qemu-devel] [PATCH 1/9] Add API to manipulate dump_bitmap

2013-05-07 Thread Eric Blake
On 05/07/2013 01:16 AM, Qiao Nuohan wrote: > Struct dump_bitmap is associated with a tmp file, and the tmp file can be used > to save data of bitmap in kdump-compressed format temporarily. > The following patch will use these functions to get the data of bitmap and > cache > them into tmp files. >

Re: [Qemu-devel] [PATCH 04/40] memory: Rename readable flag to romd_mode

2013-05-07 Thread Peter Maydell
On 7 May 2013 15:16, Paolo Bonzini wrote: > From: Jan Kiszka > > "Readable" is a very unfortunate name for this flag because even a > rom_device region will always be readable from the guest POV. What > differs is the mapping, just like the comments had to explain already. > Also, readable could

Re: [Qemu-devel] [PATCH 01/40] memory: assert that PhysPageEntry's ptr does not overflow

2013-05-07 Thread Paolo Bonzini
- Messaggio originale - > Da: "Peter Maydell" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, a...@ozlabs.ru, "jan kiszka" > , qemul...@gmail.com, > stefa...@redhat.com, da...@gibson.dropbear.id.au > Inviato: Martedì, 7 maggio 2013 17:44:59 > Oggetto: Re: [Qemu-devel] [PATCH 01/40] m

Re: [Qemu-devel] [PATCH 03/40] memory: Replace open-coded memory_region_is_romd

2013-05-07 Thread Peter Maydell
On 7 May 2013 15:16, Paolo Bonzini wrote: > From: Jan Kiszka > > Improves readability. > > Signed-off-by: Jan Kiszka Still Reviewed-by: Peter Maydell :-) -- PMM

Re: [Qemu-devel] Incorrect handling of more PPC64 insns (PATCH)

2013-05-07 Thread Torbjorn Granlund
OK, so took to reading some of translate to see how well it agrees with the PPC architecture definition. I spotted a bug with cmp, which was repeated 4 times. Somebody decided that NARROW_MODE should affect the handling of cmp instructions, which is contrary to the ISA documentation. The first h

[Qemu-devel] [PATCH 06/40] memory: make memory_global_sync_dirty_bitmap take an AddressSpace

2013-05-07 Thread Paolo Bonzini
Suggested-by: Peter Maydell Signed-off-by: Paolo Bonzini --- arch_init.c |2 +- include/exec/memory.h |7 +++ memory.c |3 +-- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/arch_init.c b/arch_init.c index 49c5dc2..5d32ecf 100644 --- a/arch_

  1   2   3   >