Re: [Qemu-devel] [PATCH 4/7] m48t59: register a QOM type for each nvram type we support

2013-05-03 Thread Hervé Poussineau
Artyom Tarasenko a écrit : On Fri, May 3, 2013 at 7:50 AM, Hervé Poussineau wrote: Artyom Tarasenko a écrit : On Thu, May 2, 2013 at 10:09 PM, Hervé Poussineau wrote: As m48t59 devices can only be created with m48t59_init() or m48t59_init_isa(), we know exactly which nvram types are require

Re: [Qemu-devel] KVM VM(rhel-5.5) %si is too high when TX/RX packets

2013-05-03 Thread Zhanghaoyu (A)
> I running a VM(RHEL-5.5) on KVM hypervisor(linux-3.8 + QEMU-1.4.1), and > direct-assign intel 82576 VF to the VM. When TX/RX packets on VM to the other > host via iperf tool, top tool result on VM shown that the %si is too high, > approximately 95% ~ 100%, but from the view of host, the VM's t

Re: [Qemu-devel] Support for 1366x768 (720p) resolution?

2013-05-03 Thread John Baboval
Josh, Somehow missed this message going by. Sorry about that. The 720p support patch (and variable VRAM size) slipped off my radar. I'm going to try and get another batch of interesting patches from the XenClient Enterprise device model ready to submit in the coming weeks, and I'll add that o

Re: [Qemu-devel] [PATCH v6 00/11] rdma: migration support

2013-05-03 Thread Chegu Vinod
Hi Michael, I picked up the qemu bits from your github branch and gave it a try. (BTW the setup I was given temporary access to has a pair of MLX's IB QDR cards connected back to back via QSFP cables) Observed a couple of things and wanted to share..perhaps you may be aware of them alrea

Re: [Qemu-devel] [PATCH 4/7] m48t59: register a QOM type for each nvram type we support

2013-05-03 Thread Artyom Tarasenko
On Fri, May 3, 2013 at 7:50 AM, Hervé Poussineau wrote: > Artyom Tarasenko a écrit : > >> On Thu, May 2, 2013 at 10:09 PM, Hervé Poussineau >> wrote: >>> >>> As m48t59 devices can only be created with m48t59_init() or >>> m48t59_init_isa(), >>> we know exactly which nvram types are required. Regi

Re: [Qemu-devel] Support for 1366x768 (720p) resolution?

2013-05-03 Thread Josh Triplett
Thanks! - Josh Triplett On Fri, May 03, 2013 at 04:41:51PM -0400, John Baboval wrote: > Josh, > > Somehow missed this message going by. Sorry about that. > > The 720p support patch (and variable VRAM size) slipped off my > radar. I'm going to try and get another batch of interesting patches > f

[Qemu-devel] VFIO VGA test branches

2013-05-03 Thread Alex Williamson
Hi folks, A number of people have been trying VFIO's VGA support, a few have even been successful. Resetting devices has been a problem and makes it very, very difficult to really use VGA assignment effectively. The code in the branches below attempts to address this. Discrete graphics devices

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5-git gpu clock control doesn`t work after guest reboot

2013-05-03 Thread Alex Williamson
Try these: git://github.com/awilliam/linux-vfio.git vfio-vga-reset git://github.com/awilliam/qemu-vfio.git vfio-vga-reset When using both this kernel and this qemu, we'll do a PCI bus reset, which should give you much more consistent behavior both between instances of the guest and at guest reset

Re: [Qemu-devel] [PATCH v2 2/2] ARM: Add mach-virt platform

2013-05-03 Thread John Rigby
On Fri, May 3, 2013 at 8:29 AM, Peter Maydell wrote: > On 30 April 2013 17:04, John Rigby wrote: >> Add mach-virt platform support cooresponding to > > "corresponding" > > I wonder if we should just call this "virt" ? > >> /arch/arm/mach-virt in kernel tree. >> >> For now it is not virtual but in

Re: [Qemu-devel] [PATCH for-1.5 v2 0/5] virtio: fix bus command line compatibility.

2013-05-03 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] audio: Enable all cards

2013-05-03 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2] TLS support for VNC Websockets

2013-05-03 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 1.5] win32: fix compilation again

2013-05-03 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL] Trivial patches for 2013-05-02

2013-05-03 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5] qdev: skip bus check for bus-less devices in qdev_unplug()

2013-05-03 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5] libqos: Relocate I2C files

2013-05-03 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL 1.5 v6 0/4] fix win32 compilation

2013-05-03 Thread Anthony Liguori
Stefan Weil writes: > Am 29.04.2013 12:11, schrieb Paolo Bonzini: >> Here is a fix for the Win32 compilation problem that Blue reported, >> and another two nits I found while testing. After these patches, a >> cross libtool is not needed anymore to build on Win32. >> >> The following changes sin

[Qemu-devel] 1.4.1 won't build with --enable-debug-tcg (or --enable-debug)

2013-05-03 Thread Juergen Lock
Hi! The failure is in the mips64-softmmu target: (at least) [...] CCmips64-softmmu/target-mips/translate.o ..qemu-1.4.1/target-mips/translate.c::2780:35 : error: passing 'int' to parameter of incompatible type 'TCGv_i32' gen_helper_dmult(cpu_env, acc, t0, t1);

[Qemu-devel] [PULL 1/1] target-arm: Fix incorrect check of kvm_vcpu_ioctl return value

2013-05-03 Thread Peter Maydell
kvm_vcpu_ioctl() returns -ETHING on error, not ETHING -- correct an incorrect check in kvm_arch_init_vcpu(). This would not have had any significant ill-effects -- we would just have propagated the less useful ENOENT up to the caller rather than the more accurate EINVAL in the unlikely case that th

[Qemu-devel] [PULL 0/1] target-arm queue

2013-05-03 Thread Peter Maydell
Last target-arm pullreq before the hardfreeze; just a single patch. (Actually it's a bugfix patch so strictly it could go in post-freeze, but anyway.) Please pull. thanks -- PMM The following changes since commit 743bddb4b35ceaaf6f95aea581a4130dcae6205a: Merge remote-tracking branch 'stefanh

[Qemu-devel] [PULL 1/1] i.MX: implement a more correct version of EPIT timer.

2013-05-03 Thread Peter Maydell
From: Jean-Christophe DUBOIS This patch is providing a complete version of the EPIT timer. Note, however that the GPT timer in the same file is still not complete. Signed-off-by: Jean-Christophe DUBOIS Message-id: 1365624982-15647-1-git-send-email-...@tribudubois.net Reviewed-by: Peter Chubb

[Qemu-devel] [PULL 0/1] arm-devs queue

2013-05-03 Thread Peter Maydell
Final arm-devs pullreq before hardfreeze; just the one patch (unfortunately I haven't seen a respin from Peter C with a fix to the compile failure in his SPIPS series, so that hsa missed the boat.) Please pull. thanks -- PMM The following changes since commit 743bddb4b35ceaaf6f95aea581a4130dcae

Re: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties

2013-05-03 Thread Andreas Färber
Am 03.05.2013 18:46, schrieb Anthony Liguori: > Andreas Färber writes: > >> Hello, >> >> It's easier adapting the infrastructure to our needs than working around it: >> X86CPU already has QOM properties today. What's lacking is model subclasses, >> and with the one X86CPU type its global properti

Re: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties

2013-05-03 Thread Igor Mammedov
On Fri, 03 May 2013 11:46:59 -0500 Anthony Liguori wrote: > Andreas Färber writes: > > > Hello, > > > > It's easier adapting the infrastructure to our needs than working around it: > > X86CPU already has QOM properties today. What's lacking is model subclasses, > > and with the one X86CPU type

Re: [Qemu-devel] [PULL 1.5 v6 0/4] fix win32 compilation

2013-05-03 Thread Stefan Weil
Am 29.04.2013 12:11, schrieb Paolo Bonzini: > Here is a fix for the Win32 compilation problem that Blue reported, > and another two nits I found while testing. After these patches, a > cross libtool is not needed anymore to build on Win32. > > The following changes since commit 75f6e8b0f121b6a

Re: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties

2013-05-03 Thread Anthony Liguori
Andreas Färber writes: > Hello, > > It's easier adapting the infrastructure to our needs than working around it: > X86CPU already has QOM properties today. What's lacking is model subclasses, > and with the one X86CPU type its global properties are overwritten by models. > But we already know the

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Andreas Färber
Am 03.05.2013 18:04, schrieb Jean-Christophe DUBOIS: > So I added a libi2c-imx.c file, a ds1338-test.c file ... (Note that in light of http://patchwork.ozlabs.org/patch/241004/ this will likely become libqos/i2c-imx.c.) > but when I run "make check" I get the following. [...] > $ make check [...]

[Qemu-devel] [PATCH 7/9] iohandler: associate with main event loop via a QSource

2013-05-03 Thread Michael Roth
This introduces a GlibQContext wrapper around the main GMainContext event loop, and associates iohandlers with it via a QSource (which GlibQContext creates a GSource from so that it can be driven via GLib. A subsequent patch will drive the GlibQContext directly) We also add "QContext-aware" functi

[Qemu-devel] [PATCH 6/9] QContext: add unit tests

2013-05-03 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile.objs |6 +- qcontext/Makefile.objs |1 + qom/Makefile.objs |6 +- tests/Makefile |7 ++ tests/test-qcontext.c | 259 5 files changed, 276 insertions(+), 3 deletions(-

[Qemu-devel] [PATCH 4/9] QContext: QEMU event loop context, abstract base class

2013-05-03 Thread Michael Roth
This class provided interfaces and helper functions for an event loop context modelled closely on GLib's GMainContext. It drives a number of QSources, which are in turn modelled on GLib GSources, and driven in very similar fashion (prepare/poll/check/dispatch interfaces). It also provides a mechani

[Qemu-devel] [PATCH 5/9] GlibQContext: a QContext wrapper around GMainContexts

2013-05-03 Thread Michael Roth
This QContext implementation wraps a GMainContext and maps most interfaces to the obvious/corresponding GMainContext interfaces. It can be used as a near drop-in replacement for event loops based directly around GMainContexts, and provides support for direct handling of GSources (which is unique t

[Qemu-devel] [PATCH 9/9] dataplane: use a QContext event loop in place of custom thread

2013-05-03 Thread Michael Roth
virtio-blk dataplane currently creates/manages it's own thread to offload work to a separate event loop. This patch insteads allows us to specify a QContext-based event loop by adding a "context" property for virtio-blk we can use like so: qemu ... \ -object glib-qcontext,id=ctx0,threaded=y

[Qemu-devel] [PATCH 8/9] main-loop: drive main event loop via QContext

2013-05-03 Thread Michael Roth
This series attaches the global AioContext's GSource to the QContext we've layered on top of the main GMainContext. This, paired with the similar treatment given to IOHandlers earlier, allows us to drive the main loop without using fill/poll functions to add/dispatch events that are external to our

[Qemu-devel] [PATCH 3/9] QSource: QEMU event source object

2013-05-03 Thread Michael Roth
This references QContext, which will be introduced later (and also references this). These will likely be squashed eventually, but we leave them separate for now for easier review. This implements a QOM-based event source object which is used in much the same way as a GSource. Signed-off-by: Mich

[Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

2013-05-03 Thread Michael Roth
These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git qcontext OVERVIEW This series introduces a set of QOM classes/interfaces for event registration/handling: QContext and QSource, which are based closely on their GMainContext/GSource GLib

[Qemu-devel] [PATCH 1/9] qom: add qom_init_completion

2013-05-03 Thread Michael Roth
This is similar in concept to "realize", though semantics are a bit more open-ended: And object might in some cases need a number of properties to be specified before it can be "used"/"started"/etc. This can't always be done via an open-ended new() function, the main example being objects that aro

[Qemu-devel] [PATCH 2/9] qom: add object_property_add_unnamed_child

2013-05-03 Thread Michael Roth
This interface allows us to add a child property without specifying a name. Instead, a unique name is created and passed back after adding the property. Signed-off-by: Michael Roth --- include/qom/object.h | 16 qom/object.c | 25 + 2 files ch

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Jean-Christophe DUBOIS
On 05/03/2013 05:20 PM, Andreas Färber wrote: Am 03.05.2013 17:16, schrieb Jean-Christophe DUBOIS: Andreas, On 05/02/2013 02:38 PM, Andreas Färber wrote: Hi, Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: Signed-off-by: Jean-Christophe DUBOIS --- default-configs/arm-softmmu.mak |

Re: [Qemu-devel] [PATCH qom-cpu 5/9] target-i386: Add ECX information to FeatureWordInfo

2013-05-03 Thread Eduardo Habkost
On Fri, May 03, 2013 at 05:16:46PM +0200, Andreas Färber wrote: > Am 22.04.2013 21:00, schrieb Eduardo Habkost: > > FEAT_7_0_EBX uses ECX as input, so we have to take that into account > > when reporting feature word values. > > > > Signed-off-by: Eduardo Habkost > > --- > > target-i386/cpu.c |

Re: [Qemu-devel] [PATCH qom-cpu 9/9] target-i386: Add "filtered-features" property to X86CPU

2013-05-03 Thread Eric Blake
On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > This property will contain all the features that were removed from the > CPU because they are not supported by the host. > > This way, libvirt or other management tools can emulate the > check/enforce behavior by checking if filtered-properties is a

Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-03 Thread Eric Blake
On 05/03/2013 08:58 AM, Andreas Färber wrote: > >> I agree that libvirt would very much like to have this in 1.5. How >> can I help in reviewing things? > > Apart from the usual QMP considerations that you will know much better > than me, I have two concerns here: > 1) Polluting the QOM namespac

Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-03 Thread Igor Mammedov
On Fri, 03 May 2013 16:58:44 +0200 Andreas Färber wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 02.05.2013 21:48, schrieb Eric Blake: > > On 05/02/2013 01:43 PM, Eduardo Habkost wrote: > >>> > >>> As mentioned earlier I'd prefer to defer the property design > >>> rather than p

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Andreas Färber
Am 03.05.2013 17:16, schrieb Jean-Christophe DUBOIS: > Andreas, > > On 05/02/2013 02:38 PM, Andreas Färber wrote: >> Hi, >> >> Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: >>> Signed-off-by: Jean-Christophe DUBOIS >>> --- >>> default-configs/arm-softmmu.mak | 2 + >>> hw/i2c/Makefile

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Jean-Christophe DUBOIS
Andreas, On 05/02/2013 02:38 PM, Andreas Färber wrote: Hi, Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: Signed-off-by: Jean-Christophe DUBOIS --- default-configs/arm-softmmu.mak | 2 + hw/i2c/Makefile.objs| 1 + hw/i2c/imx_i2c.c| 374 +++

Re: [Qemu-devel] [PATCH qom-cpu 5/9] target-i386: Add ECX information to FeatureWordInfo

2013-05-03 Thread Andreas Färber
Am 22.04.2013 21:00, schrieb Eduardo Habkost: > FEAT_7_0_EBX uses ECX as input, so we have to take that into account > when reporting feature word values. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --g

Re: [Qemu-devel] [PATCH qom-cpu 8/9] target-i386: Introduce X86CPU.filtered_features field

2013-05-03 Thread Eric Blake
On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > This field will contain the feature bits that were filtered out because > of missing host support. Yes, libvirt would definitely like to know that. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu-qom.h | 3 +++ > target-i386/cpu.c

Re: [Qemu-devel] [PATCH qom-cpu 7/9] target-i386: Use FeatureWord loop on filter_features_for_kvm()

2013-05-03 Thread Eric Blake
On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > Instead of open-coding the filtering code for each feature word, change > the existing code to use the feature_word_info array, that have exactly > the same CPUID eax/ecx/register values for each feature word. > > Signed-off-by: Eduardo Habkost > -

Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property

2013-05-03 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 02.05.2013 21:48, schrieb Eric Blake: > On 05/02/2013 01:43 PM, Eduardo Habkost wrote: >>> >>> As mentioned earlier I'd prefer to defer the property design >>> rather than putting it lightly reviewed into 1.5 and living >>> with some ABI. If libvir

Re: [Qemu-devel] [PATCH qom-cpu 6/9] target-i386: Add "feature-words" property

2013-05-03 Thread Eric Blake
On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > This property will be useful for libvirt, as libvirt already has logic > based on low-level feature bits (not feature names), so it will be > really easy to convert the current libvirt logic to something using the > "feature-words" property. > > The

Re: [Qemu-devel] [PATCH v2 09/12] linux-user: Add signal handling for AArch64

2013-05-03 Thread Peter Maydell
On 30 April 2013 07:38, John Rigby wrote: > +/* set up the stack frame for unwinding */ > +err |= __put_user(env->xregs[29], &sf->fp); __put_user can't fail so all this collection of error status is unnecessary. (Every address we write with it has to be covered by the lock_user_struct() c

Re: [Qemu-devel] [PATCH V4 5/5] block: make all steps in qmp_transaction() as callback

2013-05-03 Thread Eric Blake
On 05/01/2013 08:26 PM, Wenchao Xia wrote: > Make it easier to add other operations to qmp_transaction() by using > callbacks, with external snapshots serving as an example implementation > of the callbacks. > > Signed-off-by: Wenchao Xia > --- > blockdev.c | 92 +++

Re: [Qemu-devel] [PATCH V4 1/5] block: package preparation code in qmp_transaction()

2013-05-03 Thread Eric Blake
On 05/01/2013 08:26 PM, Wenchao Xia wrote: > The code before really committing is moved into a function. Most > code are simply moved from qmp_transaction(), except that on fail it s/are/is/ > just return now. Other code such as input parsing is not touched, s/return/returns/ > to make it easie

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/8] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-05-03 Thread David Gibson
On Fri, May 03, 2013 at 01:29:28PM +0200, Andreas Färber wrote: > Am 03.05.2013 03:38, schrieb David Gibson: > > The savevm code for the powerpc cpu emulation is currently based around > > the old register_savevm() rather than register_vmstate() method. It's also > > rather broken, missing some im

Re: [Qemu-devel] [PATCH V4 4/5] block: package rollback code in qmp_transaction()

2013-05-03 Thread Eric Blake
On 05/01/2013 08:26 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > blockdev.c | 11 --- > 1 files changed, 8 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org s

Re: [Qemu-devel] [PATCH v2 2/2] ARM: Add mach-virt platform

2013-05-03 Thread Peter Maydell
On 30 April 2013 17:04, John Rigby wrote: > Add mach-virt platform support cooresponding to "corresponding" I wonder if we should just call this "virt" ? > /arch/arm/mach-virt in kernel tree. > > For now it is not virtual but instantiates a pl011 uart > and and sp804 timer. The uart is need fo

Re: [Qemu-devel] [PATCH qom-cpu 6/9] target-i386: Add "feature-words" property

2013-05-03 Thread Eric Blake
On 05/03/2013 07:17 AM, Eduardo Habkost wrote: > > We could, but maybe it would make the interface harder to use and not > easier? > > Even when two feature words are returned in the same CPUID leaf, they > are independent and separate feature-words that must be checked > individually by libvirt,

Re: [Qemu-devel] [PATCH V4 3/5] block: package committing code in qmp_transaction()

2013-05-03 Thread Eric Blake
On 05/01/2013 08:26 PM, Wenchao Xia wrote: > The code is simply moved into a separate function. > > Signed-off-by: Wenchao Xia > --- > blockdev.c | 19 --- > 1 files changed, 12 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-91

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-05-03 Thread Andreas Färber
Hi, Am 03.05.2013 15:50, schrieb Jason J. Herne: > I've done some investigating into using the device_add hmp/qmp command > to support hot-plugging cpus on S390. The alternative suggestion was to > simply use a new cpu_add hmp/qmp command. A cpu-add QMP command has been merged by now. Using it w

Re: [Qemu-devel] [libvirt] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Daniel P. Berrange
On Fri, May 03, 2013 at 08:52:59AM -0500, Anthony Liguori wrote: > "Daniel P. Berrange" writes: > > > On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: > >> Kevin Wolf writes: > >> >> >> + > >> >> >> +if (strcmp(type, "ide-cd") == 0) { > >> >> >> +disk_type = D

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-05-03 Thread Igor Mammedov
On Fri, 03 May 2013 09:50:50 -0400 "Jason J. Herne" wrote: > I've done some investigating into using the device_add hmp/qmp command > to support hot-plugging cpus on S390. The alternative suggestion was to > simply use a new cpu_add hmp/qmp command. > > device_add accepts all of the same opti

Re: [Qemu-devel] [PATCH v2 1/2] ARM: Allow boards to provide an fdt blob

2013-05-03 Thread Peter Maydell
On 30 April 2013 17:04, John Rigby wrote: > If no fdt is provided on command line and the new field > get_dtb in struct arm_boot_info is set then call it to > get a device tree blob. > > Also allow dumping of device tree by calling qemu_devtree_dumpdtb > near the end of load_dtb. "Also ..." in a

Re: [Qemu-devel] [libvirt] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: >> Kevin Wolf writes: >> >> >> + >> >> >> +if (strcmp(type, "ide-cd") == 0) { >> >> >> +disk_type = DT_CDROM; >> >> >> +} else if (strcmp(type, "isa-fdc") == 0) { >> >> >>

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-05-03 Thread Jason J. Herne
I've done some investigating into using the device_add hmp/qmp command to support hot-plugging cpus on S390. The alternative suggestion was to simply use a new cpu_add hmp/qmp command. device_add accepts all of the same options as the -device command line parameter takes. This would imply th

Re: [Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints

2013-05-03 Thread Eduardo Habkost
On Fri, May 03, 2013 at 02:12:14PM +0200, Andreas Färber wrote: > Am 03.05.2013 14:01, schrieb Stefan Hajnoczi: > > From: Kazuya Saito > > > > This patch adds tracepoints at ioctl to kvm. Tracing these ioctl is > > useful for clarification whether the cause of troubles is qemu or kvm. > > > > Si

[Qemu-devel] [PATCH for-1.5] qdev: skip bus check for bus-less devices in qdev_unplug()

2013-05-03 Thread Igor Mammedov
Since commit 2f7bd829db "qdev: Fix device_add bus assumptions" it's possible to device_add bus-less device, but if such device is unplugged it will dereference NULL parent_bus in qdev_unplug(). Fix it by taking in account that parent_bus might be NULL and skipping bus check. Signed-off-by: Igor M

Re: [Qemu-devel] [PATCH qom-cpu 6/9] target-i386: Add "feature-words" property

2013-05-03 Thread Eduardo Habkost
On Fri, May 03, 2013 at 01:34:23PM +0200, Igor Mammedov wrote: > On Mon, 22 Apr 2013 16:00:17 -0300 > Eduardo Habkost wrote: > > > This property will be useful for libvirt, as libvirt already has logic > > based on low-level feature bits (not feature names), so it will be > > really easy to conve

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] bsd-user: OS-agnostic 64-bit SYSCTL types

2013-05-03 Thread Michael Tokarev
30.04.2013 17:29, Ed Maste wrote: > Use existence of type as #ifdef condition rather than FreeBSD-specific > version check, as suggested by Patrick Welche. > > Also handle the signed (CTLTYPE_S64) case identically to the unsigned > (CTLTYPE_U64) case, per later patches in the FreeBSD ports tree >

Re: [Qemu-devel] [PATCH v2 12/12] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > Signed-off-by: Pavel Hrdina > --- > savevm.c | 35 --- > 1 file changed, 12 insertions(+), 23 deletions(-) > > diff --git a/savevm.c b/savevm.c > index 2e849b8..45d46c6 100644 > --- a/savevm.c > +++ b/savevm.c

Re: [Qemu-devel] [PATCH v2 11/12] qapi: Convert savevm

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > QMP command vm-snapshot-save takes one parameter name and the name is > mandatory. The command returns SnapshotInfo on success, otherwise it returns > an error message. If there is a snapshot with the same name it also returns > an error messag

Re: [Qemu-devel] [PATCH v2 10/12] savevm: update error reporting of qemu_savevm_state() and related functions

2013-05-03 Thread Kevin Wolf
Am 24.04.2013 um 17:32 hat Pavel Hrdina geschrieben: > Signed-off-by: Pavel Hrdina > --- > include/sysemu/sysemu.h | 7 --- > migration.c | 6 +++--- > savevm.c| 38 +++--- > 3 files changed, 26 insertions(+), 25 deletions(-) > --

Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

2013-05-03 Thread Andreas Färber
Am 02.05.2013 20:33, schrieb Jean-Christophe DUBOIS: > On 05/02/2013 02:16 PM, Peter Crosthwaite wrote: >> On Thu, May 2, 2013 at 5:53 AM, Jean-Christophe DUBOIS >> wrote: >>> +static int imx_i2c_init(SysBusDevice *dev) >>> +{ >> Use of the SysBusDeviceClass::init function is deprecated. Please us

Re: [Qemu-devel] [RFC] Moving Hard Freeze to Monday, May 6th.

2013-05-03 Thread Mark Cave-Ayland
On 01/05/13 17:24, Rob Landley wrote: On 04/30/2013 01:36:39 PM, Anthony Liguori wrote: The current release schedule has hard freeze happening tomorrow. There are a few things still outstanding including cpu hotplug and updating SeaBIOS. We still need to resolve how to handle the softfloat cod

Re: [Qemu-devel] [libvirt] [PATCH 3/3] gtk: add devices menu to allow changing removable block devices

2013-05-03 Thread Daniel P. Berrange
On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote: > Kevin Wolf writes: > >> >> + > >> >> +if (strcmp(type, "ide-cd") == 0) { > >> >> +disk_type = DT_CDROM; > >> >> +} else if (strcmp(type, "isa-fdc") == 0) { > >> >> +disk_type = DT_FLOPPY; > >

Re: [Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints

2013-05-03 Thread Andreas Färber
Am 03.05.2013 14:01, schrieb Stefan Hajnoczi: > From: Kazuya Saito > > This patch adds tracepoints at ioctl to kvm. Tracing these ioctl is > useful for clarification whether the cause of troubles is qemu or kvm. > > Signed-off-by: Kazuya Saito > Reviewed-by: Paolo Bonzini > Signed-off-by: Stef

[Qemu-devel] [PATCH 4/4] trace: document ftrace backend

2013-05-03 Thread Stefan Hajnoczi
From: Eiichi Tsukata Add documentation of ftrace backend. Signed-off-by: Eiichi Tsukata Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt | 16 1 file changed, 16 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index cf53c17..60ff9c5 100644 --- a/docs/tracin

[Qemu-devel] [PATCH 3/4] trace: Add ftrace tracing backend

2013-05-03 Thread Stefan Hajnoczi
From: Eiichi Tsukata This patch adds a ftrace tracing backend which sends trace event to ftrace marker file. You can effectively compare qemu trace data and kernel(especially, kvm.ko when using KVM) trace data. The ftrace backend is restricted to Linux only. To try out the ftrace backend: $ ./

[Qemu-devel] [PATCH 2/4] kvm-all: add kvm_run_exit tracepoint

2013-05-03 Thread Stefan Hajnoczi
From: Kazuya Saito This patch enable us to know exit reason of KVM_RUN. It will help us know where the trouble is caused. Signed-off-by: Kazuya Saito Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- kvm-all.c| 1 + trace-events | 2 ++ 2 files changed, 3 insertions(+) diff

[Qemu-devel] [PULL 0/4] Tracing patches

2013-05-03 Thread Stefan Hajnoczi
This tracing pull request is long overdue for QEMU 1.5. Eiichi Tsukata's ftrace backend makes it easy to correlate QEMU events with host kernel events. He also reports good performance. Kazuya Saito's trace events make it easier to observe the KVM run loop. The following changes since commit 8c

[Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints

2013-05-03 Thread Stefan Hajnoczi
From: Kazuya Saito This patch adds tracepoints at ioctl to kvm. Tracing these ioctl is useful for clarification whether the cause of troubles is qemu or kvm. Signed-off-by: Kazuya Saito Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- kvm-all.c| 4 trace-events | 5

[Qemu-devel] [PATCH 2/2] tap: properly initialize vhostfds

2013-05-03 Thread Stefan Hajnoczi
From: Jason Wang Only tap->vhostfd were checked net_init_tap_one(), but tap->vhostfds were forgot, this will lead qemu to ignore all fds passed by management through vhostfds, and tries to create vhost_net device itself. Fix by adding this check also. Reportyed-by: Michal Privoznik Cc: Michal P

[Qemu-devel] [PATCH 14/15] nbd: support large NBD requests

2013-05-03 Thread Stefan Hajnoczi
The Linux nbd driver recently increased the maximum supported request size up to 32 MB: commit 078be02b80359a541928c899c2631f39628f56df Author: Michal Belczyk Date: Tue Apr 30 15:28:28 2013 -0700 nbd: increase default and max request sizes Raise the default max request size

[Qemu-devel] [PATCH 1/2] net: make network client name unique

2013-05-03 Thread Stefan Hajnoczi
From: Amos Kong assign_name() creates a name MODEL.NUM, where MODEL is the client's model, and NUM is the number of MODELs that already exist. Markus added NIC naming for non-VLAN clients in commit 53e51d85. commit d33d93b2 incorrectly added a judgement of net-hub. It caused net clients created

[Qemu-devel] [PATCH 11/15] vmdk: add bdrv_co_write_zeroes

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Use special offset to write zeroes efficiently, when zeroed-grain GTE is available. If zero-write an allocated cluster, cluster is leaked because its offset pointer is overwritten by "0x1". Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 86 +

[Qemu-devel] [PATCH 10/15] vmdk: store fields of VmdkMetaData in cpu endian

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Previously VmdkMetaData.offset is stored little endian while other fields are cpu endian. This changes offset to cpu endian and convert before writing to image. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 17 - 1 file changed, 8 in

[Qemu-devel] [PULL 0/2] Net patches

2013-05-03 Thread Stefan Hajnoczi
Two bug fixes for QEMU 1.5. The following changes since commit 8ca27ce2e1150486ea2db4116a03706b28294f16: Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2013-05-02 10:57:01 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetc

[Qemu-devel] [PATCH 15/15] qemu-iotests: Filter out 'adapter_type'

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Filter out vmdk creation option 'adapter_type' for vmdk. So that tests with an explicit './check -o adapter_type=XXX' will not fail. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/common.rc | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/common.rc

[Qemu-devel] [PATCH 08/15] vmdk: Add option to create zeroed-grain image

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Add image create option "zeroed-grain" to enable zeroed-grain GTE feature of vmdk sparse extents. When this option is on, header version of newly created extent will be 2 and VMDK4_FLAG_ZERO_GRAIN flag bit will be set. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH 13/15] nbd: use g_slice_new() instead of a freelist

2013-05-03 Thread Stefan Hajnoczi
Use GLib's efficient slice allocator instead of open-coding the request freelist. This patch simplifies the NBDRequest code. Now we qemu_blockalign() the req->data buffer each time but the next patch switches from a fixed size buffer to a dynamic size anyway. Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH 12/15] qemu-iotests: Filter out vmdk creation options

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Cover new image creation options for vmdk, so we can use '-o zeroed_grain=XXX' and '-o subformat=XXX' to run the tests successfully. Signed-off-by: Fam Zheng Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/common.rc | 2 ++ 1 file changed, 2 inse

[Qemu-devel] [PATCH 09/15] vmdk: change magic number to macro

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Two hard coded flag bits are changed to macros. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index cc19e20..0463d3b 100644 --- a/block/vmdk.c +++ b/bloc

[Qemu-devel] [PATCH 07/15] vmdk: add support for “zeroed‐grain” GTE

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Introduced support for zeroed-grain GTE, as specified in Virtual Disk Format 5.0[1]. Recent VMware hosted platform products support a new “zeroed‐grain” grain table entry (GTE). The zeroed‐grain GTE returns all zeros on read. In other words, the zeroed‐grain GTE indi

[Qemu-devel] [PATCH 06/15] vmdk: named return code.

2013-05-03 Thread Stefan Hajnoczi
From: Fam Zheng Internal routines in vmdk.c previously return -1 on error and 0 on success. More return values are useful for future changes such as zeroed-grain GTE. Change all the magic `return 0` and `return -1` to macro names: * VMDK_OK 0 * VMDK_ERROR (-1) * VMDK_UNALLOC (-2) * VM

[Qemu-devel] [PATCH 05/15] blockdev: Replace "undefined error" in qmp_block_resize

2013-05-03 Thread Stefan Hajnoczi
From: Kevin Wolf We have an errno value that can be displayed, so we should just do that. An easy way to reproduce this case is to resize a raw image to a size that is too large for the host file system. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- blo

[Qemu-devel] [PATCH 01/15] qemu: add castagnoli crc32c checksum algorithm

2013-05-03 Thread Stefan Hajnoczi
From: Jeff Cody This adds the Castagnoli CRC32C algorithm, using the 0x11EDC6F41 polynomial. This is extracted from the linux kernel cryptographic crc32.c module. The algorithm is based on: Castagnoli93: Guy Castagnoli and Stefan Braeuer and Martin Herrman "Optimization of Cyclic

[Qemu-devel] [PATCH 03/15] block: initial VHDX driver support framework - supports open and probe

2013-05-03 Thread Stefan Hajnoczi
From: Jeff Cody This is the initial block driver framework for VHDX image support (i.e. Hyper-V image file formats), that supports opening VHDX files, and parsing the headers. This commit does not yet enable: - reading - writing - updating the header - differencing files (images

[Qemu-devel] [PATCH 02/15] block: vhdx header for the QEMU support of VHDX images

2013-05-03 Thread Stefan Hajnoczi
From: Jeff Cody This is based on Microsoft's VHDX specification: "VHDX Format Specification v0.95", published 4/12/2012 https://www.microsoft.com/en-us/download/details.aspx?id=29681 These structures define the various header, metadata, and other block structures defined in the VHDX spec

[Qemu-devel] [PATCH 04/15] block: add read-only support to VHDX image format.

2013-05-03 Thread Stefan Hajnoczi
From: Jeff Cody This adds in read-only support to the VHDX image format. This supports reads for fixed-size, and dynamic sized VHDX images. Differencing files are still unsupported. The image must be opened without BDRV_O_RDWR set, because we do not yet update the headers. I.e., pass 'readonl

[Qemu-devel] [PULL 00/15] Block patches

2013-05-03 Thread Stefan Hajnoczi
Details on the patches: 1. Fam Zheng's VMDK zeroed-grain GTEs implements zero cluster support in VMDK. We need this to correctly read files containing zero clusters - it's essentially a bugfix. 2. Jeff Cody's VHDX series implements read-only support for the new Hyper-V image f

Re: [Qemu-devel] [PATCH 2/7] qom: handle registration of new types when initializing the first ones

2013-05-03 Thread Andreas Färber
Am 02.05.2013 22:08, schrieb Hervé Poussineau: > When initializing all types in object_class_foreach, called by > object_class_get_list, > some new types may be registered. Those will change the type internal > hashtable which > is currently enumerated, and may crash QEMU. > > Fix it, by adding

Re: [Qemu-devel] [PATCH 7/7] prep: QOM'ify System I/O

2013-05-03 Thread Andreas Färber
Am 02.05.2013 22:09, schrieb Hervé Poussineau: > Most of the functionality is extracted from hw/ppc/prep.c. > Also add support for board identification/equipment registers. > > Document it for the IBM 43p emulation. > > Cc: Julio Guerra > Signed-off-by: Hervé Poussineau > --- > docs/ibm_43p.cf

  1   2   >