Re: [Qemu-devel] [PATCH] ppc: initialize GPRs as per epapr

2013-04-25 Thread Alexander Graf
On 26.04.2013, at 08:51, Bhushan Bharat-R65777 wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Friday, April 26, 2013 11:51 AM >> To: Bhushan Bharat-R65777 >> Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Wood Scott-B07421; Bhushan >> Bharat-R6

Re: [Qemu-devel] ppc64-linux-user broken since "PPC: Unify dcbzl code path" ?

2013-04-25 Thread Alexander Graf
On 22.04.2013, at 08:37, Riku Voipio wrote: > Hi, > > While testing my linux-user smoke-testing setup, I noticed that > with current qemu head: > > ./ppc64-linux-user/qemu-ppc64 ../../qemu-smoke/ppc64/busybox ls > busybox: malloc.c:3096: sYSMALLOc: Assertion `(old_top == (((mbinptr) (((char >

Re: [Qemu-devel] [PATCH 3/4] s390-ccw.img: Fix compile warning in s390 ccw virtio code

2013-04-25 Thread Alexander Graf
On 23.04.2013, at 13:45, Christian Borntraeger wrote: > On 23/04/13 13:31, Alexander Graf wrote: >> On 04/23/2013 01:23 PM, Christian Borntraeger wrote: >>> Lets fix this gcc warning: >>> >>> virtio.c: In function ‘vring_send_buf’: >>> virtio.c:125:35: error: operation on ‘vr->next_idx’ may be u

Re: [Qemu-devel] [PATCH] ppc: initialize GPRs as per epapr

2013-04-25 Thread Alexander Graf
On 26.04.2013, at 08:17, Bharat Bhushan wrote: > ePAPR defines the initial values of cpu registers. This patch initialize > the GPRs as per ePAPR specification. > > This resolves the issue of guest reboot/reset (guest hang on reboot). Why does it hang only on reboot, not on initial bootup? >

[Qemu-devel] [PATCH] ppc: initialize GPRs as per epapr

2013-04-25 Thread Bharat Bhushan
ePAPR defines the initial values of cpu registers. This patch initialize the GPRs as per ePAPR specification. This resolves the issue of guest reboot/reset (guest hang on reboot). Signed-off-by: Bharat Bhushan Signed-off-by: Stuart Yoder --- hw/ppc/e500.c |7 +++ 1 files changed, 7 ins

[Qemu-devel] [0/4] RFC: Preparations for VFIO and guest IOMMUs (v2)

2013-04-25 Thread David Gibson
This patch series represents a second attempt at better integration of the vfio code with qemu's handling of guest IOMMUs. It is based on Paolo Bonzini's tree at git://github.com/bonzini/qemu.git (iommu branch). ddThis series should open the way for using VFIO with a guest system containing an IO

[Qemu-devel] [PATCH 3/4] vfio: Move container list to iommu MemoryRegion

2013-04-25 Thread David Gibson
At the moment, vfio maintains a global list of containers that are assumed to be more or less interchangeable, since they are all set up with a MemoryListener to have all of system memory mapped. However, that only makes sense if all the containers are used on devices which really do expect a dma

[Qemu-devel] [PATCH 4/4] vfio: Only use memory listeners when appropriate

2013-04-25 Thread David Gibson
Currently, vfio registers a MemoryListener for every vfio container we create, to keep the container's mappings in sync with main system memory. That's only correct though, if the context the container is attached to represents a dma address space which actually matches main system memory - roughly

[Qemu-devel] [PATCH 2/4] vfio: Associate VFIO groups with (guest) IOMMU address spaces

2013-04-25 Thread David Gibson
The only model so far supported for VFIO passthrough devices is the model usually used on x86, where all of the guest's RAM is mapped into the (host) IOMMU and there is no IOMMU visible in the guest. Later, however we want to also support guest visible IOMMUs. In order to do that the vfio subsyst

[Qemu-devel] [PATCH 1/4] Fix vmw_pvscsi.c for iommu support changes

2013-04-25 Thread David Gibson
vmw_pvscsi.c directly calls pci_dma_sglist_init() instead of using the helper for PCI devices, which means it was broken by Paolo Bonzini's recent addition of iommu support to the memory API. This fixes it. Signed-off-by: David Gibson --- hw/scsi/vmw_pvscsi.c |2 +- 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH v6 02/20] tcg: Log the contents of the prologue with -d out_asm

2013-04-25 Thread Aurelien Jarno
On Tue, Apr 23, 2013 at 01:46:34PM -0700, Richard Henderson wrote: > This makes it easier to verify changes to the code > generating the prologue. > > Reviewed-by: Aurelien Jarno > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff -

Re: [Qemu-devel] [PATCH] virtio: abort on zero config length

2013-04-25 Thread Jason Wang
On 04/26/2013 06:27 AM, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > >> On Thu, Apr 25, 2013 at 03:20:20PM -0500, Anthony Liguori wrote: >>> Jason Wang writes: >>> In fact we don't support zero length config length for virtio device. >>> virtio-rng? >> It has config_len == 0? In

[Qemu-devel] [PATCH] qemu-doc: Option -ignore-environment removed.

2013-04-25 Thread Thomas Schwinge
Has been removed in commit fc9c54124d134dbd76338a92a91804dab2df8166. Signed-off-by: Thomas Schwinge --- qemu-doc.texi |3 --- 1 file changed, 3 deletions(-) diff --git qemu-doc.texi qemu-doc.texi index dfea4d3..64493eb 100644 --- qemu-doc.texi +++ qemu-doc.texi @@ -2683,9 +2683,6 @@ Set the

[Qemu-devel] [PATCH v2] linux-user: Restore original behavior of the -E and -U command-line options.

2013-04-25 Thread Thomas Schwinge
Revert the change in behavior that had been introducecd in commit fc9c54124d134dbd76338a92a91804dab2df8166 for the -E and -U command-line options, but keep the comma-splitting for the QEMU_SET_ENV and QEMU_UNSET_ENV environment variables. Signed-off-by: Thomas Schwinge --- linux-user/main.c |

[Qemu-devel] [Bug 1172613] [NEW] [qemu 1.4.1] inconsistent behavior on different architecture

2013-04-25 Thread Cauchy Song
Public bug reported: Running with qemu 1.4.1 and eglibc 2.17 on Debian Linux 7.0 for amd64 armhf $ arm-linux-gnueabihf-gcc hello.c $ qemu-arm ./a.out /lib/ld-linux-armhf.so.3: No such file or directory $ qemu-arm arm-linux-gnueabihf/lib/ld-2.17.so ./a.out ./a.ou

[Qemu-devel] [PATCH v21 8/8] Wire up disabled wait a panicked event on s390

2013-04-25 Thread Hu Tao
From: Christian Borntraeger On s390 the disabled wait state indicates a state of attention. For example Linux uses that state after a panic. Lets put the system into panicked state. An alternative implementation would be to state disabled-wait instead of pause in the action field. (e.g. z/OS, z

[Qemu-devel] [PATCH v21 7/8] pvpanic: create pvpanic by default for machine 1.5

2013-04-25 Thread Hu Tao
Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- hw/i386/pc_piix.c| 12 hw/i386/pc_q35.c | 7 +++ hw/misc/pvpanic.c| 7 +++ include/hw/i386/pc.h | 3 +++ 4 files changed, 29 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 89b4cb4.

[Qemu-devel] [PATCH v21 6/8] pvpanic: add document of pvpanic

2013-04-25 Thread Hu Tao
Signed-off-by: Hu Tao --- docs/specs/pvpanic.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 docs/specs/pvpanic.txt diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt new file mode 100644 index 000..c7bbacc --- /dev/null +++ b/

[Qemu-devel] [PATCH v21 4/8] fw_cfg: add required header files

2013-04-25 Thread Hu Tao
If fw_cfg.h is included alone, gcc gives error messages like these: error: unknown type name ‘uint32_t’ error: unknown type name ‘size_t’ error: unknown type name ‘hwaddr’ ... Signed-off-by: Hu Tao --- include/hw/nvram/fw_cfg.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/

[Qemu-devel] [PATCH v21 3/8] introduce a new qom device to deal with panicked event

2013-04-25 Thread Hu Tao
pvpanic device is used to send guest panic event from guest to qemu. When guest panic happens, pvpanic device driver will write a event number to IO port 0x505(which is the IO port occupied by pvpanic device, by default). On receiving the event, pvpanic device will pause guest cpu(s), and send a q

[Qemu-devel] [PATCH v21 2/8] add a new qevent: QEVENT_GUEST_PANICKED

2013-04-25 Thread Hu Tao
This event will be emited when qemu detects guest panic. Signed-off-by: Wen Congyang Signed-off-by: Hu Tao --- QMP/qmp-events.txt| 14 ++ include/monitor/monitor.h | 1 + monitor.c | 1 + 3 files changed, 16 insertions(+) diff --git a/QMP/qmp-events.txt b/

[Qemu-devel] [PATCH v21 1/8] add a new runstate: RUN_STATE_GUEST_PANICKED

2013-04-25 Thread Hu Tao
The guest will be in this state when it is panicked. Signed-off-by: Wen Congyang Signed-off-by: Hu Tao --- include/sysemu/sysemu.h | 1 + qapi-schema.json| 5 - qmp.c | 3 +-- vl.c| 13 +++-- 4 files changed, 17 insertions(+), 5 delet

[Qemu-devel] [PATCH v21 5/8] pvpanic: pass configurable ioport to seabios

2013-04-25 Thread Hu Tao
This lets seabios patch the corresponding SSDT entry. Also add fw_cfg object to /machine/fw_cfg so we can reference it elsewhere. Signed-off-by: Hu Tao --- hw/misc/pvpanic.c | 14 ++ hw/nvram/fw_cfg.c | 8 +++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/hw/m

[Qemu-devel] [PATCH v21 0/8] Add pvpanic device to deal with guest panic event

2013-04-25 Thread Hu Tao
This series introduces a new simulated device, pvpanic, to notify qemu when guest panic event happens. Along with this series, there are two patches to add seabios ACPI driver and kernel ACPI driver for the device, respectively. Tested with: - qemu(kvm)/qemu(tcg) - qemu piix/q35 - default

[Qemu-devel] [RFC PATCH v5 10/14] net: make netclient re-entrant with refcnt

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan With refcnt, NetClientState's user can run agaist deleter. Signed-off-by: Liu Ping Fan --- hw/qdev-properties-system.c | 14 + include/net/net.h |3 ++ net/hub.c |3 ++ net/net.c | 46 +

[Qemu-devel] [RFC PATCH v5 12/14] slirp: make slirp event dispatch based on slirp instance, not global

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Split slirp_pollfds_fill/_poll actions into each slirp, so that SlirpState can run on dedicated context. Each slirp socket will corresponds to a GPollFD, and its SlirpState stands for a GSource(EventsGSource). Finally different SlirpState can run on different context. The logi

[Qemu-devel] [RFC PATCH v5 13/14] slirp: handle race condition

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Slirp and its peer can run on different context at the same time. Using lock to protect. Lock rule: no extra lock can be hold after slirp->lock. This will protect us from deadlock when calling to peer. As to coding style, they accord to the nearby code's style. Signed-off-by:

[Qemu-devel] [RFC PATCH v5 09/14] net: introduce lock to protect NetClientState's peer's access

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Introduce nc->peer_lock to shield off the race of nc->peer's reader and deleter. With it, after deleter finish, no new qemu_send_packet_xx() will append packet to peer->send_queue, therefore no new reference from packet->sender to nc will exist in nc->peer->send_queue. Signed-

[Qemu-devel] [RFC PATCH v5 14/14] slirp: use lock to protect the slirp_instances

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan slirps will run on dedicated thread, and dynamically join or disjoin this list, so need lock to protect the global list. Signed-off-by: Liu Ping Fan --- include/qemu/module.h |2 ++ slirp/slirp.c | 20 2 files changed, 22 insertions(+), 0 d

[Qemu-devel] [RFC PATCH v5 07/14] net: hub use lock to protect ports list

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Hub ports will run on multi-threads, so use lock to protect them. Signed-off-by: Liu Ping Fan --- net/hub.c | 25 - 1 files changed, 24 insertions(+), 1 deletions(-) diff --git a/net/hub.c b/net/hub.c index df32074..812a6dc 100644 --- a/net/hub.c +

[Qemu-devel] [RFC PATCH v5 05/14] net: port socket to GSource

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Port NetSocketState onto NetClientSource. The only thing specail is that owning to the socket's state machine changes, we need to change the handler. We implement that by destroy the old NetClientSource and attach a new one with NetSocketState. Signed-off-by: Liu Ping Fan ---

[Qemu-devel] [RFC PATCH v5 11/14] slirp: make timeout local

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Each slirp has its own time to caculate timeout. Signed-off-by: Liu Ping Fan --- slirp/slirp.c | 22 ++ slirp/slirp.h |3 +++ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index bd9b7cb..08c6b26 10064

[Qemu-devel] [RFC PATCH v5 08/14] net: introduce lock to protect NetQueue

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan NetQueue will be accessed by nc and its peers at the same time, need lock to protect it. Signed-off-by: Liu Ping Fan --- net/queue.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/net/queue.c b/net/queue.c index 859d02a..2856c1d 100644 --

[Qemu-devel] [RFC PATCH v5 06/14] net: port tap-win32 onto GSource

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- net/tap-win32.c | 31 +-- 1 files changed, 29 insertions(+), 2 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 91e9e84..7a84195 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -635,13 +635,

[Qemu-devel] [RFC PATCH v5 04/14] net: port vde onto GSource

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- net/vde.c | 31 +-- 1 files changed, 29 insertions(+), 2 deletions(-) diff --git a/net/vde.c b/net/vde.c index 4dea32d..6dbde04 100644 --- a/net/vde.c +++ b/net/vde.c @@ -30,10 +30,12 @@ #include "qemu-common.h"

[Qemu-devel] [RFC PATCH v5 02/14] net: introduce bind_ctx to NetClientInfo

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Introduce bind_ctx interface for NetClientState. It will help to bind NetClientState with a GSource. Currently, these GSource attached with default context, but in future, after resolving all the race condition in network layer, NetClientStates can run on different threads Sig

[Qemu-devel] [RFC PATCH v5 03/14] net: port tap onto GSource

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- net/tap.c | 64 +++- 1 files changed, 54 insertions(+), 10 deletions(-) diff --git a/net/tap.c b/net/tap.c index daab350..5f4d59f 100644 --- a/net/tap.c +++ b/net/tap.c @@ -41,6 +41,7 @

[Qemu-devel] [RFC PATCH v5 01/14] util: introduce gsource event abstraction

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan Introduce two structs EventGSource, EventsGSource EventGSource is used to abstract the event with single backend file. EventsGSource is used to abstract the event with dynamically changed backend file, ex, slirp. Signed-off-by: Liu Ping Fan --- util/Makefile.objs |1 +

[Qemu-devel] [RFC PATCH v5 00/14] port network layer onto glib

2013-04-25 Thread Liu Ping Fan
From: Liu Ping Fan summary: patch1: GSource event abstraction patch2~6: port network backend to glib patch7~10: make network core re-entrant patch11~14: port the slirp backend onto glib v4->v5: 1.use GList to reimplement EventsGSource 2.make readable()/writable() return events whic

Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm

2013-04-25 Thread Wenchao Xia
于 2013-4-25 20:21, Eric Blake 写道: On 04/25/2013 12:58 AM, Wenchao Xia wrote: +char buf[256]; I know this fixed-size buffer is just a copy-and-paste from other code that displays snapshot information, but I really hate it. On the other hand, I can tolerate if we have it as an intermed

Re: [Qemu-devel] [PATCH v2 03/12] savevm: update bdrv_snapshot_find() to find snapshot by id or name and add error parameter

2013-04-25 Thread Wenchao Xia
于 2013-4-25 20:16, Eric Blake 写道: On 04/25/2013 12:31 AM, Wenchao Xia wrote: + +if (!found) { +error_setg(errp, "Failed to find snapshot '%s'", name ? name : id); suggest not to set error, since it is a normal case. The way I understand it, failure to find a snapshot might ne

Re: [Qemu-devel] [PATCH v2] microblaze: Add internal base vectors reg

2013-04-25 Thread Peter Crosthwaite
On Wed, Apr 24, 2013 at 9:31 PM, wrote: > From: "Edgar E. Iglesias" > > Configurable at CPU synthesis/instantiation. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Peter Crosthwaite > --- > > Peter Crosthwaite commented off-list that it would be a good idea > to make this a device propert

Re: [Qemu-devel] [PATCH RFT for-1.5 v1 0/2] Fix DTC sub-module issues

2013-04-25 Thread Edgar E. Iglesias
On Mon, Apr 22, 2013 at 02:40:09PM +1000, peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > Two issues reported by Blue for building the DTC submodule with clang > and mingw. Applied Fixes the mingw build on my setup, thanks. Cheers, Edgar > > > Peter Crosthwaite (2): > Ma

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-25 Thread Luiz Capitulino
On Thu, 25 Apr 2013 17:19:15 -0500 Anthony Liguori wrote: > Luiz Capitulino writes: > > > On Thu, 25 Apr 2013 20:55:40 - > > Anthony Liguori wrote: > > > >> Applied. Thanks. > > > > Really? This contains the screendump extension we agreed on not doing. > > Nope, just a bug in my notify s

Re: [Qemu-devel] [SeaBIOS] [PATCH RFC 0/3] seabios: move acpi table formatting out of bios

2013-04-25 Thread Kevin O'Connor
On Fri, Apr 26, 2013 at 12:11:24AM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 25, 2013 at 08:19:48PM +0200, Fred . wrote: > > With ACPI moved out of SeaBIOS to QEMU, how will ACPI work when using > > SeaBIOS > > without QEMU? > > > > Like if using SeaBIOS with Boch, KVM or Coreboot? > > KVM

Re: [Qemu-devel] [PATCH] virtio: abort on zero config length

2013-04-25 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Thu, Apr 25, 2013 at 03:20:20PM -0500, Anthony Liguori wrote: >> Jason Wang writes: >> >> > In fact we don't support zero length config length for virtio device. >> >> virtio-rng? > > It has config_len == 0? In that case guest using virtio-rng can crash > qem

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-25 Thread Anthony Liguori
Eric Blake writes: > On 04/25/2013 03:17 PM, Luiz Capitulino wrote: >> On Thu, 25 Apr 2013 20:55:40 - >> Anthony Liguori wrote: >> >>> Applied. Thanks. >> >> Really? This contains the screendump extension we agreed on not doing. > > I tend to agree that we should revert the QMP change; A

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-25 Thread Anthony Liguori
Luiz Capitulino writes: > On Thu, 25 Apr 2013 20:55:40 - > Anthony Liguori wrote: > >> Applied. Thanks. > > Really? This contains the screendump extension we agreed on not doing. Nope, just a bug in my notify script. Somehow was triggered by merging Gerd's pull request. I'll investigate.

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-25 Thread Eric Blake
On 04/25/2013 03:17 PM, Luiz Capitulino wrote: > On Thu, 25 Apr 2013 20:55:40 - > Anthony Liguori wrote: > >> Applied. Thanks. > > Really? This contains the screendump extension we agreed on not doing. I tend to agree that we should revert the QMP change; without a way to introspect whethe

Re: [Qemu-devel] Purpose of qemu-common.h (was Re: [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients)

2013-04-25 Thread Michael S. Tsirkin
On Thu, Apr 25, 2013 at 05:57:41PM -0300, Eduardo Habkost wrote: > On Thu, Apr 25, 2013 at 03:45:04PM -0500, Anthony Liguori wrote: > > Eduardo Habkost writes: > > > > > On Thu, Apr 25, 2013 at 02:03:05PM -0500, Anthony Liguori wrote: > > >> Laszlo Ersek writes: > > >> > --- /dev/null > > >> > +

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-25 Thread Luiz Capitulino
On Thu, 25 Apr 2013 20:55:40 - Anthony Liguori wrote: > Applied. Thanks. Really? This contains the screendump extension we agreed on not doing.

Re: [Qemu-devel] [PATCH 2/2] block: move bdrv_dev_change_media_cb() to callers that really need it

2013-04-25 Thread Luiz Capitulino
On Thu, 25 Apr 2013 20:18:35 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Commit 9ca111544c64b5abed2e79cf52e19a8f227b347b moved the call to > > bdrv_dev_change_media_cb() outside the media check in bdrv_close(), > > this added a regression where spurious DEVICE_TRAY_MOVED even

Re: [Qemu-devel] [SeaBIOS] [PATCH RFC 0/3] seabios: move acpi table formatting out of bios

2013-04-25 Thread Michael S. Tsirkin
On Thu, Apr 25, 2013 at 08:19:48PM +0200, Fred . wrote: > With ACPI moved out of SeaBIOS to QEMU, how will ACPI work when using SeaBIOS > without QEMU? > > Like if using SeaBIOS with Boch, KVM or Coreboot? KVM merged with QEMU, so it will use romfiles too. Others will have two options: - keep us

Re: [Qemu-devel] [PATCH v4 1/7] refer to FWCfgState explicitly

2013-04-25 Thread Michael S. Tsirkin
On Thu, Apr 25, 2013 at 01:44:20PM -0500, Anthony Liguori wrote: > Laszlo Ersek writes: > > > Currently some places use pointer-to-void even though they mean > > pointer-to-FWCfgState. Clean them up. > > > > Signed-off-by: Laszlo Ersek > > Acked-by: Michael S. Tsirkin > > Reviewed-by: Anthony

Re: [Qemu-devel] [PATCH] virtio: abort on zero config length

2013-04-25 Thread Michael S. Tsirkin
On Thu, Apr 25, 2013 at 03:20:20PM -0500, Anthony Liguori wrote: > Jason Wang writes: > > > In fact we don't support zero length config length for virtio device. > > virtio-rng? It has config_len == 0? In that case guest using virtio-rng can crash qemu or read qemu memory: uint32_t virtio_con

[Qemu-devel] Purpose of qemu-common.h (was Re: [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients)

2013-04-25 Thread Eduardo Habkost
On Thu, Apr 25, 2013 at 03:45:04PM -0500, Anthony Liguori wrote: > Eduardo Habkost writes: > > > On Thu, Apr 25, 2013 at 02:03:05PM -0500, Anthony Liguori wrote: > >> Laszlo Ersek writes: > >> > --- /dev/null > >> > +++ b/hw/i386/acpi.h > >> > + > >> > +#include > >> > >> QEMU style would norm

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-25 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] qemu-char: Set foo_tag = 0 when returning FALSE from callbacks

2013-04-25 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/3] Kill the "use flash device for BIOS unless KVM" misfeature

2013-04-25 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Remove unnecessary FreeBSD #include

2013-04-25 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL v2 0/6] console: qom-ify consoles

2013-04-25 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-25 Thread Anthony Liguori
Eduardo Habkost writes: > On Thu, Apr 25, 2013 at 02:03:05PM -0500, Anthony Liguori wrote: >> Laszlo Ersek writes: >> > --- /dev/null >> > +++ b/hw/i386/acpi.h >> > + >> > +#include >> >> QEMU style would normally be to use qemu-common.h here but honestly I >> prefer using system headers when

[Qemu-devel] [PULL] monitor: introduce query-command-line-options

2013-04-25 Thread Luiz Capitulino
From: Amos Kong Libvirt has no way to probe if an option or property is supported, This patch introduces a new qmp command to query command line option information. hmp command isn't added because it's not needed. Signed-off-by: Amos Kong CC: Luiz Capitulino CC: Osier Yang CC: Anthony Liguori

[Qemu-devel] [PULL for-1.5] QMP queue

2013-04-25 Thread Luiz Capitulino
Our lovely new command to query command-line options by Amos. The changes (since 9953f8822cc316eec9962f0a2858c3439a80adec) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Amos Kong (1): monitor: introduce query-command-line-options qapi-schema.

Re: [Qemu-devel] [PATCH 04/15] target-i386: introduce apic-id property

2013-04-25 Thread Eduardo Habkost
On Thu, Apr 25, 2013 at 04:05:26PM +0200, Igor Mammedov wrote: [...] > +static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, void *opaque, > + const char *name, Error **errp) > +{ > +X86CPU *cpu = X86_CPU(obj); > +const int64_t min = 0; > +const in

Re: [Qemu-devel] [PATCH] virtio: abort on zero config length

2013-04-25 Thread Anthony Liguori
Jason Wang writes: > In fact we don't support zero length config length for virtio device. virtio-rng? > And it can lead outbound memory access. So abort on zero config length > to catch the bug earlier. Not sure what you mean, but virtio-rng has a zero length config space. Regards, Anthony

Re: [Qemu-devel] [PATCH v6 10/11] rdma: core logic

2013-04-25 Thread Anthony Liguori
"Michael R. Hines" writes: > On 04/25/2013 03:45 PM, Anthony Liguori wrote: >> mrhi...@linux.vnet.ibm.com writes: >> >>> From: "Michael R. Hines" >>> >>> Code that does need to be visible is kept >>> well contained inside this file and this is the only >>> new additional file to the entire patch

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-25 Thread Eduardo Habkost
On Thu, Apr 25, 2013 at 02:03:05PM -0500, Anthony Liguori wrote: > Laszlo Ersek writes: > > --- /dev/null > > +++ b/hw/i386/acpi.h > > + > > +#include > > QEMU style would normally be to use qemu-common.h here but honestly I > prefer using system headers when it's possible. Just FYI. I thought

Re: [Qemu-devel] [PATCH v6 10/11] rdma: core logic

2013-04-25 Thread Michael R. Hines
On 04/25/2013 03:45 PM, Anthony Liguori wrote: mrhi...@linux.vnet.ibm.com writes: From: "Michael R. Hines" Code that does need to be visible is kept well contained inside this file and this is the only new additional file to the entire patch - good progress. This file includes the entire pro

Re: [Qemu-devel] [PATCH 0/4 v4] Support for LED state extension to Qemu VNC server

2013-04-25 Thread Anthony Liguori
Lei Li writes: > Hi guys, > > This patch series tries to add support for LED state > extension to Qemu VNC server. The proposal has been sent > few days ago as link below: > > http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html > > The previous version as link: > > http://lists.non

Re: [Qemu-devel] [RFC 6/7] target-i386: change CPUID model of 486 to 8

2013-04-25 Thread Eduardo Habkost
CCing H. Peter Anvin. (Sorry, I thought git-send-email was configured to CC everybody mentioned in the SoB lines). On Thu, Apr 25, 2013 at 03:43:05PM -0300, Eduardo Habkost wrote: > This changes the model number of 486 to 8 (DX4) which matches the > feature set presented, and actually has the CPU

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-25 Thread Anthony Liguori
Laszlo Ersek writes: > This patch reuses some code from SeaBIOS, which was originally under > LGPLv2 and then relicensed to GPLv3 or LGPLv3, in QEMU under GPLv2+. This > relicensing has been acked by all contributors that had contributed to the > code since the v2->v3 relicense. ACKs approving th

Re: [Qemu-devel] [PATCH v2 06/12] block: update error reporting for bdrv_snapshot_list() and related functions

2013-04-25 Thread Eric Blake
On 04/24/2013 09:32 AM, Pavel Hrdina wrote: > Now the bdrv_snapshot_list function returns only number of snapshots. In case > that there is any error, the proper error message is set and return value is > 0. > The return value is no longer for testing for errors because there should be > only > o

Re: [Qemu-devel] [PATCH v4 6/7] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h

2013-04-25 Thread Anthony Liguori
Laszlo Ersek writes: > From: Michael S. Tsirkin > > Signed-off-by: Michael S. Tsirkin > > Signed-off-by: Laszlo Ersek > Acked-by: Michael S. Tsirkin Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > include/hw/i386/apic.h |2 ++ > hw/i386/pc.c |2 -- > 2 fi

Re: [Qemu-devel] [PATCH v4 5/7] hw/acpi: export acpi_checksum()

2013-04-25 Thread Anthony Liguori
Laszlo Ersek writes: > Again, this enables reuse when preparing per-table fw_cfg blobs later. > > Signed-off-by: Laszlo Ersek > Acked-by: Michael S. Tsirkin Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > include/hw/acpi/acpi.h |2 ++ > hw/acpi/core.c |2 +- >

Re: [Qemu-devel] [PATCH v4 4/7] hw/acpi: export default ACPI headers using the type just introduced

2013-04-25 Thread Anthony Liguori
Laszlo Ersek writes: > This enables reuse when preparing per-table fw_cfg blobs later. > > Signed-off-by: Laszlo Ersek > Acked-by: Michael S. Tsirkin > --- > include/hw/acpi/acpi.h |2 ++ > hw/acpi/core.c | 39 --- > 2 files changed, 26 inserti

Re: [Qemu-devel] Git head build problem (popcountl vs. system headers)

2013-04-25 Thread Peter Maydell
On 25 April 2013 19:36, Martin Husemann wrote: > But this still leaves two questions open: > > - why not use an unsigned return value for your homegrown version? We follow gcc's API, which returns int for __builtin_popcountl. > - would it be preferable to use official/optimized versions if >

Re: [Qemu-devel] [PATCH v4 2/7] acpi_table_install(): fix funcparam formatting in leading comment

2013-04-25 Thread Anthony Liguori
Laszlo Ersek writes: > Signed-off-by: Laszlo Ersek > Acked-by: Michael S. Tsirkin Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/acpi/core.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/acpi/core.c b/hw/acpi/core.c > index 64b8718..69

Re: [Qemu-devel] [PATCH v4 3/7] hw/acpi: extract standard table headers as a standalone structure

2013-04-25 Thread Anthony Liguori
Laszlo Ersek writes: > This enables reuse when preparing per-table fw_cfg blobs later. > > Signed-off-by: Laszlo Ersek > Acked-by: Michael S. Tsirkin > --- > include/hw/acpi/acpi.h | 11 +++ > hw/acpi/core.c | 48 > +--- > 2 file

[Qemu-devel] [RFC 7/7] target-i386: Disable direct passthrough of PMU CPUID leaf by default

2013-04-25 Thread Eduardo Habkost
The current code handling the CPUID 0xA leaf simply forwards all data from GET_SUPPORTED_CPUID directly to the guest, breaking migration between hosts with different number of PMU counters. This patch disables this behavior, except on older machine-types (for compatibility) and on the "host" CPU m

Re: [Qemu-devel] [PATCH v4 1/7] refer to FWCfgState explicitly

2013-04-25 Thread Anthony Liguori
Laszlo Ersek writes: > Currently some places use pointer-to-void even though they mean > pointer-to-FWCfgState. Clean them up. > > Signed-off-by: Laszlo Ersek > Acked-by: Michael S. Tsirkin Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/i386/multiboot.h |4 +++- > i

[Qemu-devel] [RFC 6/7] target-i386: change CPUID model of 486 to 8

2013-04-25 Thread Eduardo Habkost
This changes the model number of 486 to 8 (DX4) which matches the feature set presented, and actually has the CPUID instruction. This adds compatibility calls to the pc-1.4 init function, to keep model=0 on pc-1.4 and older. Signed-off-by: H. Peter Anvin Signed-off-by: Eduardo Habkost --- This

[Qemu-devel] [RFC 4/7] pc: Use separate init functions for pc-*-1.4

2013-04-25 Thread Eduardo Habkost
The pc-*-1.4 machine-types will have some compatibility calls, so make them use different init functions from pc-*-1.5. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 9 +++-- hw/i386/pc_q35.c | 7 ++- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_pi

[Qemu-devel] [RFC 5/7] target-i386: n270 can MOVBE

2013-04-25 Thread Eduardo Habkost
From: Borislav Petkov The Atom core (cpu name "n270" in QEMU speak) supports MOVBE. This is needed when booting 3.8 and later linux kernels built with the MATOM target because we require MOVBE in order to boot properly now. Cc: "H. Peter Anvin" Cc: Richard Henderson Signed-off-by: Borislav Pet

[Qemu-devel] [RFC 2/7] target-i386: Introduce compat function to set CPUID 'level'

2013-04-25 Thread Eduardo Habkost
Introduce x86_cpu_compat_set_level(), which can be used by machine-type init functions to keep compatibility when CPU models are changed. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 22 ++ target-i386/cpu.h | 1 + 2 files changed, 23 insertions(+) diff --git a/ta

[Qemu-devel] [RFC 3/7] target-i386: Introduce compat function to set CPUID 'model'

2013-04-25 Thread Eduardo Habkost
Introduce x86_cpu_compat_set_model(), which can be used by machine-type init functions to change the 'model' value of CPU models for compatibility. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 22 ++ target-i386/cpu.h | 1 + 2 files changed, 23 insertions(+) diff

[Qemu-devel] [RFC 1/7] target-i386: Introduce generic CPUID feature compat function

2013-04-25 Thread Eduardo Habkost
Introduce x86_cpu_compat_set_features(), that can be used to set/unset feature bits on specific CPU models for machine-type compatibility. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 26 ++ target-i386/cpu.h | 4 2 files changed, 30 insertions(+) diff --

[Qemu-devel] [RFC 0/7] CPUID fixes for 1.5

2013-04-25 Thread Eduardo Habkost
This series contain multiple CPUID fixes for 1.5. As we still don't have static QOM properties on the CPU class available yet, I implemented machine-typed compatibility using simple static-variable-based mechanisms. I am sending this as RFC as it depends on the previous feature-words series I have

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-25 Thread Blue Swirl
On Tue, Apr 23, 2013 at 8:29 AM, Igor Mammedov wrote: > kvm/ioapic is relying on the fact that SysBus device > maps mmio regions with offset counted from start of system memory. > But if ioapic's region is moved to another sub-region which doesn't > start at the beginning of system memory then usi

Re: [Qemu-devel] Git head build problem (popcountl vs. system headers)

2013-04-25 Thread Martin Husemann
On Thu, Apr 25, 2013 at 06:09:36PM +0100, Richard Henderson wrote: > On 2013-04-25 14:38, Laszlo Ersek wrote: > >> is the K&R header supplanted by ISO . > >>Is there any good reason that we're including it at all? > > > >- is a portable SUS/POSIX header: > > > >http://pubs.opengroup.org/onlinepubs

[Qemu-devel] [PATCH] Rename hexdump to avoid FreeBSD libutil conflict

2013-04-25 Thread Ed Maste
On FreeBSD libutil is used for openpty(), but it also provides a hexdump() which conflicts with QEMU's. Signed-off-by: Ed Maste --- hw/dma/pl330.c| 4 ++-- include/qemu-common.h | 2 +- util/hexdump.c| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/dma/pl

Re: [Qemu-devel] [SeaBIOS] [PATCH RFC 0/3] seabios: move acpi table formatting out of bios

2013-04-25 Thread Fred .
With ACPI moved out of SeaBIOS to QEMU, how will ACPI work when using SeaBIOS without QEMU? Like if using SeaBIOS with Boch, KVM or Coreboot? On Thu, Apr 25, 2013 at 11:02 AM, Michael S. Tsirkin wrote: > Untested yet, but I thought I'd share the > BIOS bits so we can agree on direction. > > In

Re: [Qemu-devel] [PATCH 2/2] block: move bdrv_dev_change_media_cb() to callers that really need it

2013-04-25 Thread Markus Armbruster
Luiz Capitulino writes: > Commit 9ca111544c64b5abed2e79cf52e19a8f227b347b moved the call to > bdrv_dev_change_media_cb() outside the media check in bdrv_close(), > this added a regression where spurious DEVICE_TRAY_MOVED events > are emitted at shutdown. > > To fix that this commit moves the bdrv

Re: [Qemu-devel] VFIO-VGA Issue

2013-04-25 Thread deniv
Sorry for the long delay. Alex Williamson: > On Thu, 2013-04-11 at 13:59 -0400, de...@lavabit.com wrote: >>> On Wed, 2013-04-10 at 16:32 -0400, de...@lavabit.com wrote: >> However, turning gfx_passthru off did >> the trick. Win7 started loading with cirrus and switched to HD7750 >> hal

Re: [Qemu-devel] Git head build problem (popcountl vs. system headers)

2013-04-25 Thread Eric Blake
On 04/25/2013 11:09 AM, Richard Henderson wrote: > On 2013-04-25 14:38, Laszlo Ersek wrote: >>> is the K&R header supplanted by ISO . >>> Is there any good reason that we're including it at all? >> >> - is a portable SUS/POSIX header: >> >> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs

Re: [Qemu-devel] [Qemu-stable] Something broken with ceph-rbd images since couple of days ( after block-changes)

2013-04-25 Thread Kevin Wolf
Am 25.04.2013 um 19:25 hat Stefan Priebe - Profihost AG geschrieben: > Ist this qemu 1.4.1? Did you received the patch? > > Stefan No, this is actually about git master. Not sure why this was directed to qemu-stable. Kevin > Am 25.04.2013 um 16:13 schrieb Oliver Francke : > > > Cool, > > > >

Re: [Qemu-devel] [PULL] libcacard and ccid fixes

2013-04-25 Thread Cole Robinson
On 04/24/2013 04:06 AM, Alon Levy wrote: > The following changes since commit bb71623811686ce3c34ce724f073f5c5dd95f51b: > > Move TPM passthrough specific command line options to backend structure > (2013-04-23 10:40:40 -0500) > > are available in the git repository at: > > git://people.free

Re: [Qemu-devel] Virtioserial changed behavior after f7f7464afdb9f

2013-04-25 Thread KONRAD Frédéric
On 25/04/2013 16:41, Michal Privoznik wrote: I've noticed some strange behavior after the commit from $subj: $ qemu-system-x86_64 -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x7 \ -device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=channel0,name=org.qemu.gue

Re: [Qemu-devel] [PATCH] Remove unnecessary FreeBSD #include

2013-04-25 Thread Ed Maste
On 25 April 2013 12:59, Peter Maydell wrote: > (Our other use of __FreeBSD_version is preceded by a direct > include of sys/param.h in translate-all.c.) I noticed that one. It's checking for __FreeBSD_version >= 700104, which corresponds to a point in time a little before the 7.1 release. Since

Re: [Qemu-devel] Git head build problem (popcountl vs. system headers)

2013-04-25 Thread Richard Henderson
On 2013-04-25 14:38, Laszlo Ersek wrote: is the K&R header supplanted by ISO . Is there any good reason that we're including it at all? - is a portable SUS/POSIX header: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/strings.h.html Huh. Ok, fine, but what do we think we're using

  1   2   3   >