Re: [Qemu-devel] [BUG latest master] - qemu segfaults when issuing screendump cmd

2013-04-17 Thread Gerd Hoffmann
>> Can you try this? >> git://git.kraxel.org/qemu rebase/pixman >> > With current master, qemu crashes. FYI: pull req sent, anthony merged, so it is fixed in master now. autotest might need adaptions nevertheless, on headless configurations (-vga none) qemu starts throwing errors now (due to l

Re: [Qemu-devel] [PATCH] console: unbreak cocoa

2013-04-17 Thread Gerd Hoffmann
Hi, >> -} else if (is_graphic_console()) { >> +} else if (qemu_console_is_graphic(NULL)) { > > This isn't the only use of is_graphic_console(); compare > the patch I sent last night: > > http://patchwork.ozlabs.org/patch/237347/ Yea, just found it in my inbox.

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-17 Thread Gerd Hoffmann
On 04/17/13 21:16, Peter Maydell wrote: > Fix failures to compile introduced by recent console commits > 1dbfa00503, 81c0d5a6) which removed is_graphic_console() and > vga_hw_update() without updating the cocoa UI backend to match. > > Signed-off-by: Peter Maydell Reviewed-by: Gerd Hoffmann ch

Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-17 Thread Stefan Hajnoczi
On Thu, Apr 18, 2013 at 5:00 AM, Wenchao Xia wrote: > 于 2013-4-17 22:42, Stefan Hajnoczi 写道: > >> On Mon, Apr 01, 2013 at 06:01:30PM +0800, Wenchao Xia wrote: >>> >>> /* New and old BlockDriverState structs for group snapshots */ >>> -typedef struct BlkTransactionStates { >>> +typedef struct Bdr

Re: [Qemu-devel] [PATCH] console: unbreak cocoa

2013-04-17 Thread Peter Maydell
On 18 April 2013 07:20, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/cocoa.m |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > index 048cc97..14b784d 100644 > --- a/ui/cocoa.m > +++ b/ui/cocoa.m > @@ -495,7 +495,7 @@ QemuC

Re: [Qemu-devel] [PULL v4 00/24] console: console overhaul continued

2013-04-17 Thread Gerd Hoffmann
Hi, > LINK arm-softmmu/qemu-system-arm > Undefined symbols for architecture x86_64: > "_is_graphic_console", referenced from: > -[QemuCocoaView handleEvent:] in cocoa.o > "_vga_hw_update", referenced from: > _cocoa_refresh in cocoa.o Patch on the way (via git send-email), can

[Qemu-devel] [PATCH] console: unbreak cocoa

2013-04-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/cocoa.m |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 048cc97..14b784d 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -495,7 +495,7 @@ QemuCocoaView *cocoaView; if (keycode == 58 || keycod

Re: [Qemu-devel] [PATCH 0/3] another round of qemu-char fixes

2013-04-17 Thread Gerd Hoffmann
On 04/17/13 12:17, Paolo Bonzini wrote: > Il 17/04/2013 09:06, Gerd Hoffmann ha scritto: cheers, Gerd >> Trapped into the next issue. Added qmp monitor to the virtual machine, >> linked to unix socket. Start playing with the qom-* scrips in QMP. >> qemu hangs after the first qmp-list

[Qemu-devel] [PATCH v7] sheepdog: add discard/trim support for sheepdog

2013-04-17 Thread Liu Yuan
From: Liu Yuan The 'TRIM' command from VM that is to release underlying data storage for better thin-provision is already supported by the Sheepdog. This patch adds the TRIM support at QEMU part. For older Sheepdog that doesn't support it, we return 0(success) to upper layer. Cc: MORITA Kazuta

[Qemu-devel] [PATCH v6] sheepdog: add discard/trim support for sheepdog

2013-04-17 Thread Liu Yuan
From: Liu Yuan The 'TRIM' command from VM that is to release underlying data storage for better thin-provision is already supported by the Sheepdog. This patch adds the TRIM support at QEMU part. For older Sheepdog that doesn't support it, we return 0(success) to upper layer. Cc: MORITA Kazuta

Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method

2013-04-17 Thread Gleb Natapov
On Mon, Apr 15, 2013 at 02:05:31PM +0200, Paolo Bonzini wrote: > Now that we have a CPU object with a reset method, it is better to > keep the KVM reset close to the CPU reset. Using qemu_register_reset > as we do now keeps them far apart. > > Signed-off-by: Paolo Bonzini > --- > v2->v3: a

[Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from submodule DTC

2013-04-17 Thread peter . crosthwaite
From: Peter Crosthwaite Configure to use the DTC submodule to build libfdt when no system libfdt is found. Prompt to install the DTC submodule if --enable-fdt is set but no DTC can be found. DTC has no out-of-tree build capability, so the configure will symlink the Makefile and scripts directory

[Qemu-devel] [PATCH v5 2/3] dtc: add submodule

2013-04-17 Thread peter . crosthwaite
From: Peter Crosthwaite Add dtc submodule as a fallback for old distros. Picking version 1.3.0. as this is the most recently tagged stable version. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- .gitmodules |3 +++ dtc |1 + 2 files changed, 4 insertions(+),

[Qemu-devel] [PATCH v5 1/3] configure: Put cross compile flags in EXTRA_CFLAGS

2013-04-17 Thread peter . crosthwaite
From: Peter Crosthwaite The cross compile CFLAGS are needed to properly build pixman (and any other submodules). Only the EXTRA_CFLAGS set is passed to submodules not QEMU_CFLAGS, so put the cross compile flags in EXTRA_CFLAGS instead. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.co

[Qemu-devel] [PATCH v5 0/3] DTC as submodule

2013-04-17 Thread peter . crosthwaite
From: Peter Crosthwaite These two patches add and use dtc as a submodule as per the RFC: http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg05000.html There is a remaining action item to mandate libfdt for arm/microblaze and PPC which is left as follow up work for after review of this seri

Re: [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-04-17 Thread Wenchao Xia
于 2013-4-18 2:14, Eric Blake 写道: On 04/17/2013 04:51 AM, Pavel Hrdina wrote: On 17.4.2013 12:19, Wenchao Xia wrote: 于 2013-4-17 15:52, Pavel Hrdina 写道: Hi Wenchao, unfortunately no. According to new design of savevm, loadvm and delvm I need also search for snapshots that have the specified na

[Qemu-devel] [PATCH 01/16 v2] cpu: make kvm-stub.o a part of CPU library

2013-04-17 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v3: put ifndef around msi.h in kvm-stub.c instead of in msi.h v2: remove unnecessary kvm-stub.o from "System emulator target" section --- Makefile.target | 14 +++--- include/sysemu/kvm.h | 4 ++-- kvm-stub.c | 7 ++- 3 files chan

Re: [Qemu-devel] [PATCH V12 06/18] block: add check for VM snapshot in bdrv_query_snapshot_info_list()

2013-04-17 Thread Wenchao Xia
于 2013-4-18 4:52, Eric Blake 写道: On 04/13/2013 02:56 AM, Wenchao Xia wrote: This patch adds a parameter to tell whether return valid snapshots for whole VM only. Note that the snapshot check logic is copied from do_info_snapshots(), which is different with load_vmstate() and will be change

Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-17 Thread Wenchao Xia
于 2013-4-17 22:42, Stefan Hajnoczi 写道: On Mon, Apr 01, 2013 at 06:01:30PM +0800, Wenchao Xia wrote: /* New and old BlockDriverState structs for group snapshots */ -typedef struct BlkTransactionStates { +typedef struct BdrvActionOps { +int (*commit)(BlockdevAction *action, void **p_opaque,

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-17 Thread Amos Kong
Hi Stefan, On Tue, Apr 16, 2013 at 10:11:50AM +0200, Stefan Hajnoczi wrote: > On Thu, Apr 11, 2013 at 11:11:58PM +0800, Amos Kong wrote: > > +static MacTableInfo *virtio_net_query_mactable(NetClientState *nc) > > +{ > > +for (i = 0; i < n->mac_table.first_multi; i++) { > > +info-

[Qemu-devel] [PATCH 5/5] vmxcap: Update according to SDM of January 2013

2013-04-17 Thread Marcelo Tosatti
From: Jan Kiszka This adds reporting of VMCS shadowing, #VE, IA32_SMBASE, unrestricted VMWRITE and fixes the range of the MSEG revision ID. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- scripts/kvm/vmxcap | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PATCH 4/5] target-i386: kvm: save/restore steal time MSR

2013-04-17 Thread Marcelo Tosatti
Read and write steal time MSR, so that reporting is functional across migration. Signed-off-by: Marcelo Tosatti Signed-off-by: Gleb Natapov --- target-i386/cpu.h | 1 + target-i386/kvm.c | 13 + target-i386/machine.c | 21 + 3 files changed, 35 insertion

[Qemu-devel] [PATCH 2/5] vmxcap: Augment reported information

2013-04-17 Thread Marcelo Tosatti
From: Jan Kiszka Parse the Basic VMX Information MSR and add the bit for the new posted interrupts. Signed-off-by: Jan Kiszka Signed-off-by: Gleb Natapov --- scripts/kvm/vmxcap | 14 ++ 1 file changed, 14 insertions(+) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index 63

[Qemu-devel] [PATCH 1/5] vmxcap: Open MSR file in unbuffered mode

2013-04-17 Thread Marcelo Tosatti
From: Jan Kiszka Python may otherwise decide to to read larger chunks, applying the seek only on the software buffer. This will return results from the wrong MSRs. Signed-off-by: Jan Kiszka Signed-off-by: Gleb Natapov --- scripts/kvm/vmxcap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[Qemu-devel] [PATCH 3/5] vmxcap: Report APIC register emulation and RDTSCP control

2013-04-17 Thread Marcelo Tosatti
From: Jan Kiszka Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- scripts/kvm/vmxcap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index a1a44a0..a79f816 100755 --- a/scripts/kvm/vmxcap +++ b/scripts/kvm/vmxcap @@ -157,10 +157,12 @@ c

[Qemu-devel] [PATCH 0/5] [PULL] qemu-kvm.git uq/master queue

2013-04-17 Thread Marcelo Tosatti
The following changes since commit 1773d9ee6e7138e3956081670215e8bc0ae14828: virtio-net: cleanup: init and exit function. (2013-04-17 10:28:59 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master for you to fetch changes up to 007e986ff

Re: [Qemu-devel] [PATCH] qemu-iotests: Test subformats for vmdk

2013-04-17 Thread Fam Zheng
On Wed, 04/17 15:06, Kevin Wolf wrote: > Am 17.04.2013 um 14:58 hat Fam Zheng geschrieben: > > Added format options for testing vmdk subformats: > > > > $ ./check -h > > Usage: ./check [options] [testlist] > > > > common options > > -v verbose > > > > check optio

[Qemu-devel] [PATCH v19 6/7] pvpanic: create pvpanic by default for machine 1.5

2013-04-17 Thread Hu Tao
Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- hw/i386/pc_piix.c| 16 ++-- hw/i386/pc_q35.c | 15 ++- hw/misc/pvpanic.c| 7 +++ include/hw/i386/pc.h | 3 +++ 4 files changed, 38 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i

[Qemu-devel] [PATCH v19 4/7] pvpanic: pass configurable ioport to seabios

2013-04-17 Thread Hu Tao
This lets seabios patch the corresponding SSDT entry. Signed-off-by: Hu Tao --- hw/misc/pvpanic.c | 14 ++ hw/nvram/fw_cfg.c | 8 +++- include/hw/nvram/fw_cfg.h | 2 ++ 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/misc/pvpanic.c b/hw/misc/pv

[Qemu-devel] [PATCH v19 2/7] add a new qevent: QEVENT_GUEST_PANICKED

2013-04-17 Thread Hu Tao
This event will be emited when qemu detects guest panic. Signed-off-by: Wen Congyang Signed-off-by: Hu Tao --- QMP/qmp-events.txt| 14 ++ include/monitor/monitor.h | 1 + monitor.c | 1 + 3 files changed, 16 insertions(+) diff --git a/QMP/qmp-events.txt b/

[Qemu-devel] [PATCH v19 5/7] pvpanic: add document of pvpanic

2013-04-17 Thread Hu Tao
Signed-off-by: Hu Tao --- docs/specs/pvpanic.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 docs/specs/pvpanic.txt diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt new file mode 100644 index 000..c7bbacc --- /dev/null +++ b/

[Qemu-devel] [PATCH v19 7/7] Wire up disabled wait a panicked event on s390

2013-04-17 Thread Hu Tao
From: Christian Borntraeger On s390 the disabled wait state indicates a state of attention. For example Linux uses that state after a panic. Lets put the system into panicked state. An alternative implementation would be to state disabled-wait instead of pause in the action field. (e.g. z/OS, z

[Qemu-devel] [PATCH v19 1/7] add a new runstate: RUN_STATE_GUEST_PANICKED

2013-04-17 Thread Hu Tao
The guest will be in this state when it is panicked. Signed-off-by: Wen Congyang Signed-off-by: Hu Tao --- include/sysemu/sysemu.h | 1 + qapi-schema.json| 5 - qmp.c | 3 +-- vl.c| 13 +++-- 4 files changed, 17 insertions(+), 5 delet

[Qemu-devel] [PATCH v19 3/7] introduce a new qom device to deal with panicked event

2013-04-17 Thread Hu Tao
pvpanic device is used to send guest panic event from guest to qemu. When guest panic happens, pvpanic device driver will write a event number to IO port 0x505(which is the IO port occupied by pvpanic device, by default). On receiving the event, pvpanic device will pause guest cpu(s), and send a q

[Qemu-devel] [PATCH v19 0/7] Add pvpanic device to deal with guest panic event

2013-04-17 Thread Hu Tao
This series introduces a new simulated device, pvpanic, to notify qemu when guest panic event happens. Along with this series, there are two patches to add seabios ACPI driver and kernel ACPI driver for the device, respectively. Tested with: - qemu(kvm)/qemu(tcg) - qemu piix/q35 - default

Re: [Qemu-devel] [SeaBIOS] [RFC][PATCH 1/2] acpi: add ASL for Embedded Controller

2013-04-17 Thread li guang
在 2013-04-17三的 07:46 -0600,Marc Jones写道: > What EC is this for? The device and interface is defined by the spec, > but the offsets and methods are custom for every EC. > > you're mostly right, the specific content ACPI space will vary for different boards, this one just for a common case > >

Re: [Qemu-devel] [SeaBIOS] [RFC][PATCH 2/2] hw: add Embedded Controller chip emulation

2013-04-17 Thread li guang
No, sorry. As this is RFC patch, I sent it only for demo my thought. 在 2013-04-17三的 12:41 +0200,Mark Marshall写道: > Hi. > > > At least one major bug (noted below), have you tested all of this yet? > > > MM > > > On 17 April 2013 09:23, liguang wrote: > this work implemented Embedded

Re: [Qemu-devel] [SeaBIOS] [RFC][PATCH 0/2] Embedded Controller chip emulation

2013-04-17 Thread li guang
Oh, No, that's a private interface for Intel's AMT, this is a chip embedded in mainboard. 在 2013-04-17三的 11:04 +0200,Fred .写道: > HECI ? > http://en.wikipedia.org/wiki/Host_Embedded_Controller_Interface > > > > On Wed, Apr 17, 2013 at 9:32 AM, li guang > wrote: > Embedded Controller chi

Re: [Qemu-devel] [RFC][PATCH 2/2] hw: add Embedded Controller chip emulation

2013-04-17 Thread li guang
在 2013-04-17三的 19:54 +0200,Andreas Färber写道: > Am 17.04.2013 09:23, schrieb liguang: > > this work implemented Embedded Controller chip emulation > > which was defined at ACPI SEPC v5 chapter 12: > > "ACPI Embedded Controller Interface Specification" > > > > commonly Embedded Controller will emula

Re: [Qemu-devel] [PULL v4 00/11] rdma: migration support

2013-04-17 Thread Anthony Liguori
mrhi...@linux.vnet.ibm.com writes: > From: "Michael R. Hines" > > The following changes since commit e0a83fc2c1582dc8d4453849852ebe6c258b7c3a: > > qom: do nothing on unparent of object without parent (2013-04-16 16:10:21 > -0500) > > are available in the git repository at: > > g...@github.co

[Qemu-devel] [PULL v4 01/11] rdma: export yield_until_fd_readable()

2013-04-17 Thread mrhines
From: "Michael R. Hines" The RDMA event channel can be made non-blocking just like a TCP socket. Exporting this function allows us to yield so that the QEMU monitor remains available. Signed-off-by: Michael R. Hines --- include/block/coroutine.h |6 ++ qemu-coroutine-io.c | 23

[Qemu-devel] [PULL v4 10/11] rdma: print out throughput while debugging

2013-04-17 Thread mrhines
From: "Michael R. Hines" It's very helpful when debugging to print out migration throughput after each iteration round to compare the different migration technologies. Signed-off-by: Michael R. Hines --- migration.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PULL v4 04/11] rdma: export ram_handle_compressed()

2013-04-17 Thread mrhines
From: "Michael R. Hines" This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Signed-off-by: Michael R. Hines --- arch_init.c | 24 include/migration/migration.h |2 ++ 2 files changed, 18

[Qemu-devel] [PULL v4 11/11] rdma: add documentation

2013-04-17 Thread mrhines
From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Signed-off-by: Michael R. Hines --- docs/rdma.txt | 360 + 1 file changed, 360 insertions(+) create mode 100644 docs/rdm

[Qemu-devel] [PULL v4 06/11] rdma: new QEMUFileOps hooks

2013-04-17 Thread mrhines
From: "Michael R. Hines" These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included are the prototypes

[Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration

2013-04-17 Thread mrhines
From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. It is enabled by default. Signed-off-by: Michael R. Hines --- migration.c | 10 ++ qapi-schema.json |8 +++- 2 files changed, 17 in

[Qemu-devel] [PULL v4 03/11] rdma: introduce qemu_file_mode_is_not_valid()

2013-04-17 Thread mrhines
From: "Michael R. Hines" QEMUFileRDMA also has read and write modes. This function is now shared to reduce code duplication. Signed-off-by: Michael R. Hines --- include/migration/qemu-file.h |2 ++ savevm.c | 20 +--- 2 files changed, 15 insertions(+)

[Qemu-devel] [PULL v4 00/11] rdma: migration support

2013-04-17 Thread mrhines
From: "Michael R. Hines" The following changes since commit e0a83fc2c1582dc8d4453849852ebe6c258b7c3a: qom: do nothing on unparent of object without parent (2013-04-16 16:10:21 -0500) are available in the git repository at: g...@github.com:hinesmr/qemu.git rdma_patch_v4 for you to fetch c

[Qemu-devel] [PULL v4 05/11] rdma: export qemu_fflush()

2013-04-17 Thread mrhines
From: "Michael R. Hines" RDMA uses this to flush the control channel before sending its own message to handle page registrations. Signed-off-by: Michael R. Hines --- include/migration/qemu-file.h |1 + savevm.c |2 +- 2 files changed, 2 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL v4 09/11] rdma: send pc.ram

2013-04-17 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Signed-off-by: Michael R. Hines --- arch_init.c | 35 +++

[Qemu-devel] [PULL v4 02/11] rdma: introduce qemu_ram_foreach_block()

2013-04-17 Thread mrhines
From: "Michael R. Hines" This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Signed-off-by: Michael R. Hines --- exec.c|9 + include/exec/cpu-common.h |5

Re: [Qemu-devel] [PATCH V12 10/18] qmp: add interface query-snapshots

2013-04-17 Thread Eric Blake
On 04/13/2013 02:56 AM, Wenchao Xia wrote: > This interface returns info of valid internal snapshots for whole vm. > > Signed-off-by: Wenchao Xia > --- > block/qapi.c | 17 +++ > qapi-schema.json | 14 + > qmp-commands.hx | 58 > +

Re: [Qemu-devel] [PATCH V12 08/18] block: add image info query function bdrv_query_image_info()

2013-04-17 Thread Eric Blake
On 04/13/2013 02:56 AM, Wenchao Xia wrote: > This patch adds function bdrv_query_image_info(), which will > retrieve image info in qmp object format. The implementation is > based on the code moved from qemu-img.c, but uses block layer > function to get snapshot info. > > Signed-off-by: Wenchao

Re: [Qemu-devel] [PATCH V12 07/18] block: change VM snapshot checking logic

2013-04-17 Thread Eric Blake
On 04/13/2013 02:56 AM, Wenchao Xia wrote: > Original logic is different with load_vmstate(), this patch change it s/with/from/ s/change/changes/ > to be exactly the same with load_vmstate(), so any VM snapshot shown in s/with/as/ > qmp/hmp should succeed in load_vmstate(). Looking through g

Re: [Qemu-devel] [PATCH 01/16] cpu: make kvm-stub.o a part of CPU library

2013-04-17 Thread Paolo Bonzini
> > +#ifndef CONFIG_USER_ONLY > > #include "qemu-common.h" > > #include "hw/pci/pci.h" > > > > @@ -47,4 +48,5 @@ static inline bool msi_present(const PCIDevice *dev) > > return dev->cap_present & QEMU_PCI_CAP_MSI; > > } > > > > +#endif Please put the #ifndef in the .c file instead. P

[Qemu-devel] target-i386: enable SVM lock for Phenom processors

2013-04-17 Thread prasadjoshi . linux
From: Prasad Joshi Signed-off-by: Prasad Joshi --- target-i386/cpu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e2302d8..540e450 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -455,7 +455,7 @@ static x86_def_t bu

Re: [Qemu-devel] [PATCH V12 06/18] block: add check for VM snapshot in bdrv_query_snapshot_info_list()

2013-04-17 Thread Eric Blake
On 04/13/2013 02:56 AM, Wenchao Xia wrote: > This patch adds a parameter to tell whether return valid snapshots > for whole VM only. > Note that the snapshot check logic is copied from do_info_snapshots(), > which is different with load_vmstate() and will be changed in next patch. > > Signed-o

[Qemu-devel] [PATCH] run: Introduce --use-malloc-perturb specific qemu flag

2013-04-17 Thread Lucas Meneghel Rodrigues
Setting the environment variable MALLOC_PERTURB_ to a non zero value [1] helps to find out some subtle memory allocation problems, and it is being used in our test grid. However, by default, the virt test runner doesn't use it. Add the new, qemu test specific --use-malloc-perturb flag and set it t

[Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-17 Thread Peter Maydell
Fix failures to compile introduced by recent console commits 1dbfa00503, 81c0d5a6) which removed is_graphic_console() and vga_hw_update() without updating the cocoa UI backend to match. Signed-off-by: Peter Maydell --- ui/cocoa.m | 8 1 file changed, 4 insertions(+), 4 deletions(-) dif

[Qemu-devel] [Bug 1169375] Re: qemu.git master -> qemu segfaults during tcp migration (and other modes when using MALLOC_PERTURB_=1)

2013-04-17 Thread Lucas Meneghel Rodrigues
Problem fixed with this commit, recently pushed to master: commit 7dda5dc82a776a39a7996020c188eb2a29187117 Author: Paolo Bonzini Date: Tue Apr 9 17:43:43 2013 +0200 migration: initialize RAM to zero Using qemu_memalign only leaves the RAM zero by chance, because libc will usua

Re: [Qemu-devel] [PATCH V12 02/18] block: distinguish id and name in bdrv_find_snapshot()

2013-04-17 Thread Eric Blake
On 04/16/2013 07:09 PM, Eric Blake wrote: > On 04/13/2013 02:56 AM, Wenchao Xia wrote: >> To make it clear about id and name in searching, the API is changed >> a bit to distinguish them, and caller can choose to search by id or name. >> Searching will be done with higher priority of id. This fun

Re: [Qemu-devel] [BUG latest master] - qemu segfaults when issuing screendump cmd

2013-04-17 Thread Lucas Meneghel Rodrigues
On Tue, 2013-04-16 at 09:39 +0200, Gerd Hoffmann wrote: > On 04/15/13 18:49, Lucas Meneghel Rodrigues wrote: > > Latest qemu.git master is failing big time to pass sanity checks: > > > > https://bugs.launchpad.net/qemu/+bug/1169254 > > > > We've had some issues with the test jobs, and finally man

Re: [Qemu-devel] [PULL v3 4/7] rdma: core logic

2013-04-17 Thread Michael R. Hines
Thanks. Comments inline On 04/17/2013 05:16 AM, Paolo Bonzini wrote: +/* + * Create protection domain and completion queues + */ +static int qemu_rdma_alloc_pd_cq(RDMAContext *rdma) +{ +/* allocate pd */ +rdma->pd = ibv_alloc_pd(rdma->verbs); +if (!rdma->pd) { +fprintf(

Re: [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-04-17 Thread Eric Blake
On 04/17/2013 12:14 PM, Eric Blake wrote: > Or, written another way, to implement the same results in only two coded > loops: Missed a line: > > if name is set: > if there is a snapshot with that name (loop 1): > if id is set: > if id matches: >

Re: [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-04-17 Thread Eric Blake
On 04/17/2013 04:51 AM, Pavel Hrdina wrote: > On 17.4.2013 12:19, Wenchao Xia wrote: >> 于 2013-4-17 15:52, Pavel Hrdina 写道: >>> Hi Wenchao, >>> >>> unfortunately no. According to new design of savevm, loadvm and delvm I >>> need also search for snapshots that have the specified name and id. >>> >>

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-04-17 Thread Eduardo Habkost
On Wed, Apr 17, 2013 at 08:06:37PM +0200, Andreas Färber wrote: > Hi Jens, > > Am 03.04.2013 08:42, schrieb Jens Freimann: > > this is what our approach to CPU hotplug looks like. > > With respect to Igor's CPU hotplug series, how should we proceed? > > Should we change the interface to > > qemu

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-04-17 Thread Andreas Färber
Hi Jens, Am 03.04.2013 08:42, schrieb Jens Freimann: > this is what our approach to CPU hotplug looks like. > With respect to Igor's CPU hotplug series, how should we proceed? > Should we change the interface to > qemu_system_cpu_add_notifier/qemu_system_cpu_hotplug_request/cpu-add etc? I am wo

Re: [Qemu-devel] [RFC][PATCH 2/2] hw: add Embedded Controller chip emulation

2013-04-17 Thread Andreas Färber
Am 17.04.2013 09:23, schrieb liguang: > this work implemented Embedded Controller chip emulation > which was defined at ACPI SEPC v5 chapter 12: > "ACPI Embedded Controller Interface Specification" > > commonly Embedded Controller will emulate keyboard, > mouse, handle ACPI defined operations and

Re: [Qemu-devel] Qemu Unix-Signals

2013-04-17 Thread Edgar E. Iglesias
On Wed, Apr 17, 2013 at 03:04:48PM +0200, Andreas Färber wrote: > Hi, > > Am 17.04.2013 11:21, schrieb Moese, Michael: > >> I think your best bet is to ask GreenSocs if you need support for this > >> codebase. > > > > I think you'd be right when you point me to GreenSocs, but.. they don't > > s

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-17 Thread Paolo Bonzini
Il 17/04/2013 17:36, Hans de Goede ha scritto: >>> >> >> I'm not sure why all users of qemu_chr_fe_add_watch believe that the >> watch will be one-shot. This is definitely not what g_io_create_watch >> does... > > It is supposed to depend on the return value of the callback, if you > return False

Re: [Qemu-devel] [PULL 5/8] rdma: core rdma logic

2013-04-17 Thread Paolo Bonzini
Il 17/04/2013 17:59, Michael R. Hines ha scritto: >>> Failure already happens for unknown capabilities. >> Maybe I misread the code, but all I saw is: >> >> +if (cap.flags & RDMA_CAPABILITY_CHUNK_REGISTER) { >> +rdma->chunk_register_destination = true; >> +} else if (cap

[Qemu-devel] timer question

2013-04-17 Thread steven.see...@frontier.com
Hello everyone. I am writing a device driver on qemu using a PCI card that I modelled bare functionality in so we can test the driver while the board is made. I have a couple of questions that I can't find having been addressed in the past. The system is x86_64 running Ubuntu. I am using KVM on

Re: [Qemu-devel] [PULL v3 7/7] rdma: add documentation

2013-04-17 Thread Michael R. Hines
On 04/17/2013 11:52 AM, Eric Blake wrote: On 04/16/2013 10:20 PM, mrhi...@linux.vnet.ibm.com wrote: +Experimental: Next, decide if you want dynamic page registration. +For example, if you have an 8GB RAM virtual machine, but only 1GB +is in active use, then disabling this feature will cause all

Re: [Qemu-devel] [PULL v3 2/7] rdma: new QEMUFileOps hooks

2013-04-17 Thread Michael R. Hines
Acknowledged. On 04/17/2013 06:13 AM, Orit Wasserman wrote: On 04/17/2013 07:20 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also

Re: [Qemu-devel] [PULL 5/8] rdma: core rdma logic

2013-04-17 Thread Michael R. Hines
On 04/17/2013 04:58 AM, Paolo Bonzini wrote: No, I really mean it. No dead code. We included the one useful option as a capability, and that should be it. Acknowledged =) Failure already happens for unknown capabilities. Maybe I misread the code, but all I saw is: +if (cap.flags

Re: [Qemu-devel] [PULL v3 3/7] rdma: introduce capability for chunk registration

2013-04-17 Thread Michael R. Hines
On 04/17/2013 11:44 AM, Eric Blake wrote: On 04/16/2013 10:20 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. It is enabled by default. Signed-off-by: Michael R. H

Re: [Qemu-devel] [PULL v3 7/7] rdma: add documentation

2013-04-17 Thread Eric Blake
On 04/16/2013 10:20 PM, mrhi...@linux.vnet.ibm.com wrote: > +Experimental: Next, decide if you want dynamic page registration. > +For example, if you have an 8GB RAM virtual machine, but only 1GB > +is in active use, then disabling this feature will cause all 8GB to > +be pinned and resident in

Re: [Qemu-devel] [PULL v3 3/7] rdma: introduce capability for chunk registration

2013-04-17 Thread Eric Blake
On 04/16/2013 10:20 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This capability allows you to disable dynamic chunk registration > for better throughput on high-performance links. > > It is enabled by default. > > Signed-off-by: Michael R. Hines > --- > +++ b/qapi-sch

Re: [Qemu-devel] [SeaBIOS] [RFC][PATCH 1/2] acpi: add ASL for Embedded Controller

2013-04-17 Thread Marc Jones
What EC is this for? The device and interface is defined by the spec, but the offsets and methods are custom for every EC. Marc On Wed, Apr 17, 2013 at 1:22 AM, liguang wrote: > defined at ACPI SPEC v5 chapter 12: > "ACPI Embedded Controller Interface Specification" > > Signed-off-by: liguang

Re: [Qemu-devel] [SeaBIOS] [RFC][PATCH 2/2] hw: add Embedded Controller chip emulation

2013-04-17 Thread Mark Marshall
Hi. At least one major bug (noted below), have you tested all of this yet? MM On 17 April 2013 09:23, liguang wrote: > this work implemented Embedded Controller chip emulation > which was defined at ACPI SEPC v5 chapter 12: > "ACPI Embedded Controller Interface Specification" > > commonly Emb

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-17 Thread Hans de Goede
Ji, On 04/16/2013 11:34 AM, Paolo Bonzini wrote: Il 16/04/2013 11:15, Gerd Hoffmann ha scritto: On 04/10/13 15:23, Paolo Bonzini wrote: After attaching the source, we have to remove the reference we hold to it, because we do not hold anymore a pointer to the source. If we do not do this, remo

[Qemu-devel] [PATCH 05/13] elfload: use abi_short/ushort instead of target_short/ushort

2013-04-17 Thread Paolo Bonzini
The alignment is a characteristic of the ABI, not the CPU. Signed-off-by: Paolo Bonzini --- configure| 2 -- include/exec/cpu-defs.h | 2 -- include/exec/user/abitypes.h | 7 +++ linux-user/elfload.c | 6 +++--- 4 files changed, 10 insertions(+), 7 deletions(

[Qemu-devel] [PATCH 10/13] configure: move common libraries to config-host.mak

2013-04-17 Thread Paolo Bonzini
Move -lm to the end of the line, so that it can be picked up as a dependency by pixman in the static build case. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- Makefile.target | 10 +- configure | 4 +++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a

Re: [Qemu-devel] Target-agnostic virtio?

2013-04-17 Thread Rob Landley
On 04/14/2013 04:38:23 AM, Artyom Tarasenko wrote: On Sat, Apr 13, 2013 at 7:03 PM, Rob Landley wrote: > On 03/26/2013 02:34:50 AM, Artyom Tarasenko wrote: >> >> On Tue, Mar 26, 2013 at 1:52 AM, Rob Landley wrote: >> > Can the virtio things (serial, network, block, virtfs) be used on >> > ar

Re: [Qemu-devel] [PATCH v2 17/17] aio: drop io_flush argument

2013-04-17 Thread Stefan Hajnoczi
On Wed, Apr 17, 2013 at 03:15:56PM +0200, Paolo Bonzini wrote: > Il 17/04/2013 15:07, Stefan Hajnoczi ha scritto: > > The .io_flush() handler no longer exists and has no users. Drop the > > io_flush argument to aio_set_fd_handler() and related functions. > > > > The AioFlushEventNotifierHandler t

Re: [Qemu-devel] [PATCH v2 05/17] aio: stop using .io_flush()

2013-04-17 Thread Stefan Hajnoczi
On Wed, Apr 17, 2013 at 03:20:02PM +0200, Paolo Bonzini wrote: > Il 17/04/2013 15:07, Stefan Hajnoczi ha scritto: > > > > Due to this change we need to update tests/test-aio.c which asserts > > aio_poll() return values. Note that QEMU doesn't actually rely on these > > return values so only tests

Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-17 Thread Stefan Hajnoczi
On Mon, Apr 01, 2013 at 06:01:30PM +0800, Wenchao Xia wrote: > /* New and old BlockDriverState structs for group snapshots */ > -typedef struct BlkTransactionStates { > +typedef struct BdrvActionOps { > +int (*commit)(BlockdevAction *action, void **p_opaque, Error **errp); > +void (*rollba

[Qemu-devel] [PATCH 03/13] elfload: fix size of registers for N32

2013-04-17 Thread Paolo Bonzini
Registers are 64-bit in size for the MIPS n32 ABI. Define target_elf_greg_t accordingly, and use the correct function to do endian swaps. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- linux-user/elfload.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-

Re: [Qemu-devel] [PATCH RFC] vhost: fix vhost force with msix=off

2013-04-17 Thread Michael S. Tsirkin
On Wed, Apr 17, 2013 at 02:03:12PM +0200, Christian Borntraeger wrote: > On 15/04/13 16:40, Michael S. Tsirkin wrote: > > In response to a bug report on IRC: this should fix it I think? > > Need to test properly but out of time for today, > > compiled only. Hope this helps. > > > > Signed-off-by:

[Qemu-devel] [PATCH 04/13] elfload: use tswapreg consistently in elf_core_copy_regs

2013-04-17 Thread Paolo Bonzini
Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- linux-user/elfload.c | 114 +-- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 9d5dbb8..bc2e9f1 100644 --- a/linux-user/e

[Qemu-devel] [PATCH 09/13] configure: move CONFIG_QEMU_LDST_OPTIMIZATION to config-host.mak

2013-04-17 Thread Paolo Bonzini
Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- configure | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/configure b/configure index f4bfa14..1495214 100755 --- a/configure +++ b/configure @@ -3587,6 +3587,15 @@ echo "extra_ldflags=$EXTRA_LDFLA

[Qemu-devel] [PATCH 12/13] configure: CONFIG_NO_XEN is duplicated

2013-04-17 Thread Paolo Bonzini
We already define it in Makefile.target. But we need to avoid a curious double negation in order to eliminate it. Tested-by: Stefano Stabellini Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- configure| 3 --- include/hw/xen/xen.h | 2 +- 2 files changed, 1 insertion(+

[Qemu-devel] [PATCH 13/13] configure: remove duplicate test

2013-04-17 Thread Paolo Bonzini
We already had a test to add -march=i486 when needed. Make the existing test independent of vhost-net, so that it is also used under Win32. Signed-off-by: Paolo Bonzini --- configure | 56 ++-- 1 file changed, 26 insertions(+), 30 deletions(-)

[Qemu-devel] [PATCH 11/13] configure: eliminate target_libs_softmmu

2013-04-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure| 4 +--- default-configs/lm32-softmmu.mak | 1 + hw/display/Makefile.objs | 5 +++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 35f90e3..6e775aa 100755 --- a/configure +++ b/

[Qemu-devel] [PATCH 07/13] elfload: only give abi_long/ulong the alignment specified by the target

2013-04-17 Thread Paolo Bonzini
Previously, this was done for target_long/ulong, and propagated to abi_long/ulong via a typedef. But target_long/ulong should not have any specific alignment, it is never used to access guest memory. Signed-off-by: Paolo Bonzini --- configure| 9 - include/exec/cpu-

[Qemu-devel] [PATCH 08/13] elfload: use abi_llong/ullong instead of target_llong/ullong

2013-04-17 Thread Paolo Bonzini
The alignment is a characteristic of the ABI, not the CPU. Signed-off-by: Paolo Bonzini --- configure| 4 include/exec/cpu-defs.h | 2 -- include/exec/user/abitypes.h | 10 ++ linux-user/elfload.c | 4 ++-- 4 files changed, 12 insertions(+), 8 del

[Qemu-devel] [PATCH 06/13] elfload: use abi_int/uint instead of target_int/uint

2013-04-17 Thread Paolo Bonzini
The alignment is a characteristic of the ABI, not the CPU. Signed-off-by: Paolo Bonzini --- configure| 3 --- include/exec/cpu-defs.h | 2 -- include/exec/user/abitypes.h | 9 + linux-user/elfload.c | 14 +++--- 4 files changed, 16 insertions(+

[Qemu-devel] [PATCH 02/13] elfload: fix size of ABI-dependent fields in core dumps

2013-04-17 Thread Paolo Bonzini
Some fields in core dumps are 32-bit in 32-or-64 environments (ppc64abi32, sparc32plus). Use abi_long/ulong for those. Also, the fields of target_elf_siginfo are ints. Use tswap32 to convert them. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- linux-user/elfload.c | 18 +

[Qemu-devel] [PATCH v3 00/13] TARGET_*_ALIGNMENT cleanup, and config-target.mak trimming

2013-04-17 Thread Paolo Bonzini
This series expands on the one I sent yesterday, but also fixes some confusion between target (CPU) and ABI types in linux-user/elfload.c. target_short/int/llong and the corresponding unsigned types are renamed to abi_short/int/llong, and TARGET_*_ALIGNMENT is similarly renamed to ABI_*_ALIGNMENT.

[Qemu-devel] [PATCH 01/13] configure: QEMU_INCLUDES are the same for all subtargets

2013-04-17 Thread Paolo Bonzini
Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- configure | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/configure b/configure index 4c4f6f6..a6e9104 100755 --- a/configure +++ b/configure @@ -3986,6 +3986,19 @@ if test "$trace_defa

  1   2   3   >