Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-07 Thread Amit Shah
On (Wed) 03 Apr 2013 [15:08:40], Anthony Liguori wrote: > Amit Shah writes: > > > On (Tue) 02 Apr 2013 [07:52:19], Anthony Liguori wrote: > >> Amit Shah writes: > >> > >> >> > backends/rng-random.c:44:entropy_available: assertion failed: (len != > >> >> > -1) > >> >> > > >> >> > without this f

Re: [Qemu-devel] Use of flash for x86 BIOS

2013-04-07 Thread Xiao Guangrong
On 03/23/2013 03:09 AM, Jordan Justen wrote: > Admittedly, I've been completely ineffectual in resolving the kvm > portion. More recently I tried to make use of KVM_MEM_READONLY to > address this. I was able to get an VM exit on writes to flash, but not > able to get the memory region to convert t

[Qemu-devel] [RFC PATCH v3 4/5] net: port vde onto glib

2013-04-07 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- net/vde.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/net/vde.c b/net/vde.c index 4dea32d..be5a032 100644 --- a/net/vde.c +++ b/net/vde.c @@ -60,6 +60,16 @@ static ssize_t vde_receive(NetClientState *nc, const uint8_t *b

[Qemu-devel] [RFC PATCH v3 0/5] port network layer onto glib

2013-04-07 Thread Liu Ping Fan
This series focus on network backend (excluding slirp). The related patch for core's re-entrant (queue.c net.c) will be sent out separatelly. The choice between GSource or AioContext is not decided yet. If we choose AioContext, I think we need to expand extra interface for readable() and writabl

[Qemu-devel] [RFC PATCH v3 5/5] net: port socket to glib

2013-04-07 Thread Liu Ping Fan
Port NetSocketState onto NetClientSource. The only thing specail is that owning to the socket's state machine changes, we need to change the handler. We implement that by destroy the old NetClientSource and attach a new one with NetSocketState. Signed-off-by: Liu Ping Fan --- net/socket.c | 152

[Qemu-devel] [RFC PATCH v3 3/5] net: resolve race of tap backend and its peer

2013-04-07 Thread Liu Ping Fan
When vhost net enabled, we should be sure that the user space fd handler is not in flight Signed-off-by: Liu Ping Fan --- net/tap.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index e19bb07..a3947eb 100644 --- a/net/tap.c +++ b/net/tap.c @@

[Qemu-devel] [RFC PATCH v3 1/5] net: introduce glib function for network

2013-04-07 Thread Liu Ping Fan
Bind each NetClientState with a GSource(ie,NetClientSource). Currently, these GSource attached with default context, but in future, after resolving the race between handlers and the interface exposed by NetClientInfo and other re-entrant issue, we can run NetClientState on different threads Signed

[Qemu-devel] [RFC PATCH v3 2/5] net: port tap onto glib

2013-04-07 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- net/tap.c | 58 +++--- 1 files changed, 47 insertions(+), 11 deletions(-) diff --git a/net/tap.c b/net/tap.c index daab350..e19bb07 100644 --- a/net/tap.c +++ b/net/tap.c @@ -70,25 +70,48 @@ static int tap_can_

[Qemu-devel] [PATCH 7/7] target-ppc: Synchronize VPA state with KVM

2013-04-07 Thread David Gibson
For PAPR guests, KVM tracks the various areas registered with the H_REGISTER_VPA hypercall. For full emulation, of course, these are tracked within qemu. At present these values are not synchronized. This is a problem for reset (qemu's reset of the VPA address is not pushed to KVM) and will also

[Qemu-devel] [PATCH 2/7] pseries: Generate device paths for VIO devices

2013-04-07 Thread David Gibson
This patch implements a get_dev_path qdev hook for the pseries paravirtual VIO bus. With upcoming savevm support, this will become very important for scsi disks hanging of VIO virtual SCSI adapters. scsibus_get_dev_path uses the get_dev_path of the parent adapter if available, but otherwise just

[Qemu-devel] [PATCH 4/7] pseries: Fixes and enhancements to L1 cache properties

2013-04-07 Thread David Gibson
PAPR requires that the device tree's CPU nodes have several properties with information about the L1 cache. We already create two of these properties, but with incorrect names - "[id]cache-block-size" instead of "[id]-cache-block-size" (note the extra hyphen). We were also missing some of the req

[Qemu-devel] [PATCH 1/7] pseries: Convert VIO code to QOM style type safe(ish) casts

2013-04-07 Thread David Gibson
Curerntly the pseries VIO device code contains quite a few explicit uses of DO_UPCAST and plain C casts. This is (obviously) type unsafe, and not the conventional way of doing things in the QOM model. This patch converts the code to use the QOM convention of per-type macros to do verified casts w

[Qemu-devel] [PATCH 5/7] target-ppc: Add more stubs for POWER7 PMU registers

2013-04-07 Thread David Gibson
In addition to the performance monitor registers found on nearly all 6xx chips, the POWER7 has two additional counters (PMC5 & PMC6) and an extra control register (MMCRA). This patch adds stub support for them to qemu - the registers won't do anything, but with this change won't cause illegal inst

[Qemu-devel] [PATCH 6/7] pseries: Fix some small errors in XICS logic

2013-04-07 Thread David Gibson
Under certain circumstances the emulation for the pseries "XICS" interrupt controller was clearing a pending interrupt from the XISR register, without also clearing the corresponding priority variable. This will cause problems later when can trigger sanity checks in the under-development in-kernel

[Qemu-devel] [0/7] Pending pseries updates

2013-04-07 Thread David Gibson
Hi Alex, Here's my latest batch of pending pseries updates. Mostly pretty small bugfixes and extensions.

[Qemu-devel] [PATCH 3/7] pseries: Fix incorrect calculation of RMA size in certain configurations

2013-04-07 Thread David Gibson
For the pseries machine, we need to advertise to the guest the size of its RMA - that is the amount of memory it can access with the MMU off. For HV KVM, this is constrained by the hardware limitations on the virtual RMA of one hash PTE per PTE group in the hash page table. We already had code to

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Synchronize VPA state with KVM

2013-04-07 Thread David Gibson
On Fri, Mar 15, 2013 at 01:22:08PM +0100, Alexander Graf wrote: > > On 14.03.2013, at 02:53, David Gibson wrote: > > > For PAPR guests, KVM tracks the various areas registered with the > > H_REGISTER_VPA hypercall. For full emulation, of course, these are tracked > > within qemu. At present th

Re: [Qemu-devel] [0/6] Simple extensions to VMStateDescription features

2013-04-07 Thread David Gibson
On Thu, Mar 14, 2013 at 01:42:24PM +0100, Juan Quintela wrote: > David Gibson wrote: > > Jean, Anthony, > > > > This series contains a bunch of straightforward extensions to the > > suite of functions and macros for using in VMStateDescription > > structures. Mostly these fill fairly obvious gaps

[Qemu-devel] 答复: question about performance of dataplane

2013-04-07 Thread Zhangleiqiang
> -邮件原件- > 发件人: Anthony Liguori [mailto:anth...@codemonkey.ws] > 发送时间: 2013年4月7日 22:06 > 收件人: Zhangleiqiang; Stefan Hajnoczi; stefa...@redhat.com > 抄送: Zhangleiqiang; Luohao (brian); qemu-devel@nongnu.org; Haofeng; > leiqzhang > 主题: Re: [Qemu-devel] question about performance of dataplane

Re: [Qemu-devel] [PATCH v17 5/6] pvpanic: create pvpanic device by default

2013-04-07 Thread Hu Tao
On Fri, Apr 05, 2013 at 01:14:16PM +0200, Paolo Bonzini wrote: > Il 05/04/2013 08:36, Hu Tao ha scritto: > > Also parse command line options for ioport and set > > it accordingly. > > This does not do the correct thing for versioned machine types like "-M > pc-1.4". Also, adding stuff to vl.c is

Re: [Qemu-devel] [PATCH 06/22] cpu: introduce CPUClass.resume() method

2013-04-07 Thread li guang
Reviewed-by: liguang 在 2013-04-05五的 16:36 +0200,Igor Mammedov写道: > ... and call it if defined from CPUClass.realize() if CPU was hotplugged > > by default leave .resume() unset (i.e. NULL) and override it for softmmu > in qemu_init_vcpu() if it's still unset. > > Signed-off-by: Igor Mammedov >

Re: [Qemu-devel] [PATCH 02/22] target-i386: split APIC creation from initialization in x86_cpu_realizefn()

2013-04-07 Thread li guang
Reviewed-by: liguang 在 2013-04-05五的 16:36 +0200,Igor Mammedov写道: > When APIC is hotplugged during CPU hotplug, device_set_realized() > calls device_reset() on it. And if QEMU runs in KVM mode, following > call chain will fail: > apic_reset_common() > -> kvm_apic_vapic_base_update() >

Re: [Qemu-devel] [PATCH 13/22] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-07 Thread li guang
在 2013-04-05五的 16:37 +0200,Igor Mammedov写道: > * introduce processor status bitmask visible to guest at 0xaf00 addr, > where Seabios expects it > * set bit corresponding to APIC ID in processor status bitmask on > receiving CPU hot-plug notification > * trigger CPU hot-plug SCI, expected by Seab

Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast

2013-04-07 Thread li guang
This patch should be combined with [PATCH 07/22] 在 2013-04-05五的 16:37 +0200,Igor Mammedov写道: > Signed-off-by: Igor Mammedov > --- > hw/ioapic_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ioapic_common.c b/hw/ioapic_common.c > index d4aff29..561b987 100644

Re: [Qemu-devel] [PATCH 11/22] cpu: introduce get_firmware_id() method and override it for target-i386

2013-04-07 Thread li guang
在 2013-04-05五的 16:37 +0200,Igor Mammedov写道: > get_firmware_id() adds possibily for generic code to get guest visible > CPI id without accessing CPUArchState. If target doesn't override it, > it will return cpu_index. > > Override it on target-i386 to return APIC ID. > > Signed-off-by: Igor Mammed

Re: [Qemu-devel] [PATCH][RFC v2 2/7] hw/power: add main power chip implementation

2013-04-07 Thread li guang
在 2013-04-05五的 10:23 +0100,Peter Maydell写道: > On 5 April 2013 09:45, li guang wrote: > > 在 2013-04-05五的 09:35 +0100,Peter Maydell写道: > >> What actual hardware is this supposed to be modelling? > >> I don't believe there's such a thing as a 'generic > >> power controller' that makes sense for all a

Re: [Qemu-devel] [PATCH][RFC v2 3/7] vl: create power chip device

2013-04-07 Thread li guang
在 2013-04-05五的 13:48 +0200,Paolo Bonzini写道: > Il 05/04/2013 06:28, liguang ha scritto: > > Signed-off-by: liguang > > --- > > vl.c |4 > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/vl.c b/vl.c > > index aeed7f4..a14549e 100644 > > --- a/vl.c > > +++ b/vl.c >

Re: [Qemu-devel] [PATCH v2] hw/i386/pc: reject to boot a wrong header magic kernel

2013-04-07 Thread li guang
在 2013-04-05五的 14:59 +0200,Stefan Hajnoczi写道: > On Mon, Apr 01, 2013 at 09:21:57AM +0800, liguang wrote: > > if head magic is missing or wrong unexpectedly, we'd > > better to reject booting. > > e.g. > > I make a mistake to boot a vmlinuz for MIPS(which > > I think it's for x86) like this: > > qem

[Qemu-devel] [Bug 1162644] Re: qemu-system-x86_64 crashed with SIGABRT in __assert_fail_base()

2013-04-07 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qemu (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1162644 Title: qemu

Re: [Qemu-devel] [PATCH arm-devs v1 04/15] xilinx_spips: Add verbose LQSPI debug output

2013-04-07 Thread Peter Crosthwaite
On Sat, Apr 6, 2013 at 4:42 AM, Peter Maydell wrote: > On 3 April 2013 05:32, Peter Crosthwaite wrote: >> You really need this is you want to track a guest banging on LQSPI. >> >> Signed-off-by: Peter Crosthwaite >> --- >> >> hw/xilinx_spips.c |5 - >> 1 files changed, 4 insertions(+),

Re: [Qemu-devel] [PATCH arm-devs v1 03/15] xilinx_spips: Inhibit interrupts in LQSPI mode

2013-04-07 Thread Peter Crosthwaite
Hi Peter, On Sat, Apr 6, 2013 at 4:41 AM, Peter Maydell wrote: > On 3 April 2013 05:27, Peter Crosthwaite wrote: >> The real hardware does not produce interrupts in LQSPI mode. Inhibit >> generation of interrupts when the LQ_MODE bit is set. >> >> Signed-off-by: Peter Crosthwaite >> --- >> >>

Re: [Qemu-devel] [PATCH v2] qemu-char: eliminate busy waiting on can_read returning zero

2013-04-07 Thread Peter Crosthwaite
Hi Paolo, On Mon, Apr 8, 2013 at 4:49 AM, Paolo Bonzini wrote: > Il 06/04/2013 21:00, Amit Shah ha scritto: >> On (Fri) 05 Apr 2013 [17:59:33], Paolo Bonzini wrote: >>> The character backend refactoring introduced an undesirable busy wait. >>> The busy wait happens if can_read returns zero and th

Re: [Qemu-devel] [PATCH v2 2/5] register: Add Register API

2013-04-07 Thread Peter Crosthwaite
Hi Peter, On Fri, Apr 5, 2013 at 7:49 PM, Peter Crosthwaite wrote: > On Fri, Apr 5, 2013 at 7:26 PM, Peter Maydell > wrote: >> On 5 April 2013 09:43, Peter Crosthwaite >> wrote: >>> This API provides some encapsulation of registers and factors our some >>> common functionality to common code.

[Qemu-devel] [Bug 1165383] Re: executable qemu-1.4.0/i386-linux-user/./qemu-i386 gives a segmentation fault

2013-04-07 Thread Kashyap Chamarthy
Can you please provide some more information here. e.g. - qemu command-line used - how did you trigger it - libvirt/or direct qemu-kvm binary - segentation fault/tracedetails -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [PATCH v2] qemu-char: eliminate busy waiting on can_read returning zero

2013-04-07 Thread Paolo Bonzini
Il 06/04/2013 21:00, Amit Shah ha scritto: > On (Fri) 05 Apr 2013 [17:59:33], Paolo Bonzini wrote: >> The character backend refactoring introduced an undesirable busy wait. >> The busy wait happens if can_read returns zero and there is data available >> on the character device's file descriptor. T

Re: [Qemu-devel] 答复: 答复: 答复: question about performance of dataplane

2013-04-07 Thread Abel Gordon
张磊强 wrote on 07/04/2013 07:10:24 PM: > > HI, Abel & Stefan: > > After thinking twice about the benchmarks and the idea of > dataplane, I am still confused. Please note while I am familiar with the documentation and architecture of dataplane, I didn't contribute to the dataplane code. So S

[Qemu-devel] [Bug 1154328] Re: qemu locks up on typing 41 characters at once into serial console

2013-04-07 Thread Andreas Gustafsson
My automated test is still hanging, but since commit 893986fe94eb229f2317f50fac0e35e068eb66ba, it no longer hangs silently, but instead outputs a seemingly endless stream of assertion failure messages: (process:5928): GLib-CRITICAL **: g_source_get_context: assertion `!SOURCE_DESTROYED (source)

Re: [Qemu-devel] 答复: 答复: 答复: question about performance of dataplane

2013-04-07 Thread Abel Gordon
Zhangleiqiang wrote on 07/04/2013 04:34:45 PM: > Hi, Abel Gordon: > >The CPU info of host is as follows: > >Physical CPU:2 >Core Per Phy CPU: 6 >HT: enabled > >According to your advice, I have finished another benchmark which > ensures vcpus (32) i

Re: [Qemu-devel] question about performance of dataplane

2013-04-07 Thread Anthony Liguori
Zhangleiqiang writes: > Hi, Stefan: > > I have done some testing to compare the performance of dataplane and > non-dataplane. But the result did not meet my expectations, the performance > of disk with dataplane enabled did not have advantage over non-dataplane. > > The following

[Qemu-devel] 答复: 答复: 答复: question about performance of dataplane

2013-04-07 Thread Zhangleiqiang
Hi, Abel Gordon: The CPU info of host is as follows: Physical CPU: 2 Core Per Phy CPU: 6 HT: enabled According to your advice, I have finished another benchmark which ensures vcpus (32) is more t

Re: [Qemu-devel] 答复: 答复: question about performance of dataplane

2013-04-07 Thread Abel Gordon
qemu-devel-bounces+abelg=il.ibm@nongnu.org wrote on 07/04/2013 02:31:20 PM: > From: Zhangleiqiang > To: Stefan Hajnoczi , > Cc: Zhangleiqiang , Stefan Hajnoczi > , "Luohao \(brian\)" , > "qemu-devel@nongnu.org" , Haofeng > Date: 07/04/2013 02:31 PM > Subject: [Qemu-devel] 答复: 答复: question

[Qemu-devel] 答复: 答复: question about performance of dataplane

2013-04-07 Thread Zhangleiqiang
Hi, Stefan: Follow your advice, I have finished the benchmarks with multiple vcpu (smp) and parallel I/O workloads. The results still show that the performance of disk with dataplane enabled did not have advantage over non-dataplane under Random write mode. But under the Sequen