Re: [Qemu-devel] [PATCH v3 17/27] tcg-ppc64: Implement bswap64

2013-04-01 Thread Alexander Graf
On 02.04.2013, at 06:23, Richard Henderson wrote: > Reviewed-by: Aurelien Jarno > Signed-off-by: Richard Henderson Is this faster than a load/store with std/ldbrx? Alex > --- > tcg/ppc64/tcg-target.c | 35 +++ > tcg/ppc64/tcg-target.h | 2 +- > 2 files changed

Re: [Qemu-devel] [PATCH] target-ppc: Enable ISEL on POWER7

2013-04-01 Thread Alexander Graf
On 01.04.2013, at 17:06, Aurelien Jarno wrote: > ISEL is a Power ISA 2.06 instruction and thus is available on POWER7. > Given this is trapped and emulated by the Linux kernel, I guess it went > unnoticed. > > Cc: Alexander Graf > Signed-off-by: Aurelien Jarno Thanks, applied to ppc-next. Al

Re: [Qemu-devel] [2/2] [vmxnet3] const_cpu_to_le64 wrapping for feature bits dropped

2013-04-01 Thread Alexander Graf
On 28.03.2013, at 09:53, Dmitry Fleytman wrote: > Byte swap is redundant because shared memory reading functions > already swap bytes when required > > Signed-off-by: Dmitry Fleytman Acked-by: Alexander Graf It might be worth to run an x86 guest with vmxnet3 on a big endian host machine to

Re: [Qemu-devel] [PATCH 2/5] hostmem: make hostmem global and RAM hotunplg safe

2013-04-01 Thread li guang
在 2013-04-01一的 16:20 +0800,Liu Ping Fan写道: > From: Liu Ping Fan > > The hostmem listener will translate gpa to hva quickly. Make it > global, so other component can use it. > Also this patch adopt MemoryRegionOps's ref/unref interface to > make it survive the RAM hotunplug. > > Signed-off-by: Li

Re: [Qemu-devel] [PATCH 4/5] virtio-blk: release reference to RAM's memoryRegion

2013-04-01 Thread li guang
在 2013-04-01一的 16:20 +0800,Liu Ping Fan写道: > From: Liu Ping Fan > > virtio-blk will reference to RAM's memoryRegion when the req has been > done. do you mean unreference after req completed? > So we can avoid to call bdrv_drain_all() when RAM hot unplug. > > Signed-off-by: Liu Ping Fan > -

[Qemu-devel] [PATCH v3 17/27] tcg-ppc64: Implement bswap64

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 35 +++ tcg/ppc64/tcg-target.h | 2 +- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index d8131ec..1806364

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-04-01 Thread Nicholas A. Bellinger
Hello Wenchao, On Tue, 2013-04-02 at 11:28 +0800, Wenchao Xia wrote: > Hi, Nicholas > Have this serial been merged to qemu 1.4? Not just yet. Asias, MST, Paolo and myself have been working recently on the series for qemu 1.4. > If not, I am rebasing it to > upstream, hope no one else is work

[Qemu-devel] [PATCH v3 21/27] tcg-ppc64: Use I constraint for mul

2013-04-01 Thread Richard Henderson
The mul_i32 pattern was loading non-16-bit constants into a register, when we can get the middle-end to do that for us. The mul_i64 pattern was not considering that MULLI takes 64-bit inputs. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 24 +

[Qemu-devel] [PATCH v3 04/27] tcg-ppc64: Introduce and use tcg_out_ext32u

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 3587d0e..84e30ad 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/

[Qemu-devel] [PATCH v3 26/27] tcg-ppc64: Implement add2/sub2_i64

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 56 ++ tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 58 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index

[Qemu-devel] [PATCH v3 24/27] tcg-ppc64: Implement movcond

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 59 ++ tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 61 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index

[Qemu-devel] [PATCH v3 22/27] tcg-ppc64: Use TCGType throughout compares

2013-04-01 Thread Richard Henderson
The optimization/bug being fixed is that tcg_out_cmp was not applying the right type to loading a constant, in the case it can't be implemented directly. Rather than recomputing the TCGType enum from the arch64 bool, pass around the original TCGType throughout. Reviewed-by: Aurelien Jarno Signed

[Qemu-devel] [PATCH v3 19/27] tcg-ppc64: Handle constant inputs for some compound logicals

2013-04-01 Thread Richard Henderson
Since we have special code to handle and/or/xor with a constant, apply the same to andc/orc/eqv with a constant. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 44 ++-- 1 file changed, 34 insertions(+), 10 deleti

[Qemu-devel] [PATCH v3 18/27] tcg-ppc64: Implement compound logicals

2013-04-01 Thread Richard Henderson
Mostly copied from the ppc32 port. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 34 ++ tcg/ppc64/tcg-target.h | 20 ++-- 2 files changed, 44 insertions(+), 10 deletions(-) diff --git a/tcg/ppc64/tcg-ta

[Qemu-devel] [PATCH v3 11/27] tcg-ppc64: Tidy or and xor patterns.

2013-04-01 Thread Richard Henderson
Handle constants in common code; we'll want to reuse that later. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 55 -- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git a/tcg/ppc64/tcg-target.

[Qemu-devel] [PATCH v3 27/27] tcg-ppc64: Implement mulu2/muls2_i64

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 27 +++ tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 0e60589..cdfc07b 10064

[Qemu-devel] [PATCH v3 25/27] tcg-ppc64: Use getauxval for ISA detection

2013-04-01 Thread Richard Henderson
Glibc 2.16 includes an easy way to get feature bits previously buried in /proc or the program startup auxiliary vector. Use it. Signed-off-by: Richard Henderson --- configure | 18 ++ tcg/ppc64/tcg-target.c | 16 +++- 2 files changed, 33 insertions(+), 1

[Qemu-devel] [PATCH v3 09/27] tcg-ppc64: Rearrange integer constant constraints

2013-04-01 Thread Richard Henderson
We'll need a zero, and Z makes more sense for that. Make sure we have a full compliment of signed and unsigned 16 and 32-bit tests. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 43 +-- 1 file changed, 33 inser

[Qemu-devel] [PATCH v3 23/27] tcg-ppc64: Rewrite setcond

2013-04-01 Thread Richard Henderson
Never use MFCR, as the latency is really high. Even MFOCRF, at half the latency of MFCR, isn't as fast as we can do with carry tricks. The ADDIC+SUBFE trick only works for word-sized operands, as we need carry-out from bit 63. So for ppc64 we must extend 32-bit inputs. Use ISEL if available. R

[Qemu-devel] [PATCH v3 20/27] tcg-ppc64: Implement deposit

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 12 tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 9a24d20..bd12b5c 100644 --- a/tcg/ppc

[Qemu-devel] [PATCH v3 08/27] tcg-ppc64: Introduce and use TAI and SAI

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 138 +++-- 1 file changed, 66 insertions(+), 72 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index a4951c5..31b0cb7 100644 --- a/tcg

[Qemu-devel] [PATCH v3 14/27] tcg-ppc64: Streamline qemu_ld/st insn selection

2013-04-01 Thread Richard Henderson
Using a table to look up insns of the right width and sign. Include support for the Power 2.05 LDBRX and STDBRX insns included in e.g. Power6. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 166 + 1 file changed, 56 insertions(+), 11

[Qemu-devel] [PATCH v3 06/27] tcg-ppc64: Introduce and use tcg_out_shri64

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 9199ac4..82e1da7 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-targ

[Qemu-devel] [PATCH v3 16/27] tcg-ppc64: Implement bswap16 and bswap32

2013-04-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 43 +++ tcg/ppc64/tcg-target.h | 18 ++ 2 files changed, 53 insertions(+), 8 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index c512714..d8131ec 1006

[Qemu-devel] [PATCH v3 13/27] tcg-ppc64: Improve and_i64 with constant

2013-04-01 Thread Richard Henderson
Use RLDICL and RLDICR. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 64 +++--- 1 file changed, 50 insertions(+), 14 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index ad6db6c..51a5545 100644 --- a/tcg/ppc6

[Qemu-devel] [PATCH v3 05/27] tcg-ppc64: Introduce and use tcg_out_shli64

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 84e30ad..9199ac4 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg

[Qemu-devel] [PATCH v3 10/27] tcg-ppc64: Improve constant add and sub ops.

2013-04-01 Thread Richard Henderson
Use SUBFIC to implement subtraction with constant op1. Improve constant addition -- previously we'd emit useless addis with 0. Use new constraints to force the driver to pull full 64-bit constants into a register. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-

[Qemu-devel] [PATCH v3 15/27] tcg-ppc64: Implement rotates

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 39 +++ tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 8c19f98..c

[Qemu-devel] [PATCH v3 07/27] tcg-ppc64: Cleanup tcg_out_movi

2013-04-01 Thread Richard Henderson
The test for using movi32 was sub-optimal for TCG_TYPE_I32, comparing a signed 32-bit quantity against an unsigned 32-bit quantity. When possible, use addi+oris for 32-bit unsigned constants. Otherwise, standardize on addi+oris+ori instead of addis+ori+rldicl. Reviewed-by: Aurelien Jarno Signed

[Qemu-devel] [PATCH v3 02/27] tcg-ppc64: Use TCGReg everywhere

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 833fe0c..762ca1b 100644 --- a/tcg/ppc64/tcg-tar

[Qemu-devel] [PATCH v3 12/27] tcg-ppc64: Improve and_i32 with constant

2013-04-01 Thread Richard Henderson
Use RLWINM Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 9718ef6..ad6db6c 100644

[Qemu-devel] [PATCH v3 03/27] tcg-ppc64: Introduce and use tcg_out_rlw

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 72 ++ 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 762ca1b..3587d0e 100644 --- a/tcg

[Qemu-devel] [PATCH v3 01/27] disas: Disassemble all ppc insns for the host

2013-04-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- disas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/disas.c b/disas.c index 74d3ba0..67103e0 100644 --- a/disas.c +++ b/disas.c @@ -325,6 +325,7 @@ void disas(FILE *out, void *code, unsigned long size) s.info.mach = bf

[Qemu-devel] [PATCH v3 00/27] Modernize tcg/ppc64

2013-04-01 Thread Richard Henderson
Changes v2-v3: * Incorporated feedback from Aurelien's review. Tree updated at git://github.com/rth7680/qemu.git tcg-ppc64 r~ Richard Henderson (27): disas: Disassemble all ppc insns for the host tcg-ppc64: Use TCGReg everywhere tcg-ppc64: Introduce and use tcg_out_rlw tcg-ppc64:

[Qemu-devel] Ongoing big-endian vmxnet3 breakage

2013-04-01 Thread Richard Henderson
The build has been broken for *far* too long. Can we please apply *any* of the patches that have been posted to fix it. Even if the patch is not 100% correct, a non-working driver is preferred to a compile error that affects unrelated development. r~

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-04-01 Thread Wenchao Xia
Hi, Nicholas Have this serial been merged to qemu 1.4? If not, I am rebasing it to upstream, hope no one else is working on that. > From: Nicholas Bellinger > > Hello Anthony & Co, > > This is the fourth installment to add host virtualized target support for > the mainline tcm_vhost fabric dr

Re: [Qemu-devel] [PATCH V10 15/17] block: dump to buffer for bdrv_image_info_dump()

2013-04-01 Thread Wenchao Xia
于 2013-4-2 3:17, Eric Blake 写道: On 03/22/2013 08:19 AM, Wenchao Xia wrote: This allow hmp use this function, just like qemu-img. It also returns a pointer now to make it easy to use. -void bdrv_image_info_dump(ImageInfo *info) +GCC_FMT_ATTR(3, 4) +static void snprintf_tail(char **p_buf,

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-01 Thread Wenchao Xia
于 2013-4-1 23:52, Eric Blake 写道: On 04/01/2013 04:01 AM, Wenchao Xia wrote: Last operaton should be cancelled first. s/operaton/operation/ [I don't care enough about US vs. UK to say whether canceled or cancelled looks better] Signed-off-by: Wenchao Xia --- blockdev.c |2 +- 1 f

Re: [Qemu-devel] Virtualbox svga card in KVM

2013-04-01 Thread Sriram Murthy
Hi,     I am looking into hw/vga.c and hw/vga-pci.c as a starting point in my effort to get vbox svga card into kvm.     However, given my very basic understanding of VGA/SVGA standards, can somebody throw some light on the inner workings of the std vga card in kvm?     Also, are there any good

[Qemu-devel] 答复: question about performance of dataplane

2013-04-01 Thread Zhangleiqiang
Hi, Stefan: I have also finished the perf testing under Fedora 17 using IOZone, and the results also shown that the performance of disk with dataplane enabled did not have advantage over non-dataplane. 1. Environment: a). Qemu 1.4 master branch b). kernel: 3.5.0-2.fc17.

Re: [Qemu-devel] [Xen-devel] frequently ballooning results in qemu exit

2013-04-01 Thread Hanweidong
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 2013年4月1日 22:39 > To: Hanweidong > Cc: Stefano Stabellini; Tim (Xen.org); George Dunlap; Andrew Cooper; > Yanqiangjun; qemu-devel@nongnu.org; xen-de...@lists.xen.org; Gonglei > (Arei); Anthon

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-01 Thread Nicholas A. Bellinger
On Fri, 2013-03-29 at 09:14 +0100, Paolo Bonzini wrote: > Il 29/03/2013 03:53, Nicholas A. Bellinger ha scritto: > > On Thu, 2013-03-28 at 06:13 -0400, Paolo Bonzini wrote: > >>> I think it's the right thing to do, but maybe not the right place > >>> to do this, need to reset after all IO is done,

[Qemu-devel] [Bug 1163065] [NEW] target-i386 cpu_get_phys_page_debug checks bits in wrong order

2013-04-01 Thread Brendan Dolan-Gavitt
Public bug reported: In target-i386 cpu_get_phys_page_debug, the CR4_PAE bit is checked before CR0_PG. This means that if paging is disabled but the PAE bit has been set in CR4, cpu_get_phys_page_debug will return the wrong result (it will try to translate the address as virtual rather than using

Re: [Qemu-devel] [SeaBIOS] [PATCH v16] Add pvpanic device driver

2013-04-01 Thread Kevin O'Connor
On Sun, Mar 31, 2013 at 05:34:10PM +0300, Gleb Natapov wrote: > On Sat, Mar 30, 2013 at 09:20:09AM -0400, Kevin O'Connor wrote: > > On Fri, Mar 29, 2013 at 02:49:12PM +0100, Paolo Bonzini wrote: > > > Il 29/03/2013 14:33, Kevin O'Connor ha scritto: > > > > On Fri, Mar 29, 2013 at 04:18:44PM +0800,

Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device

2013-04-01 Thread Kevin O'Connor
On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote: > On 03/28/2013 05:03 AM, Paolo Bonzini wrote: > >There is work on moving ACPI tables to QEMU. Please work with the other > >developers (Kevin of course, and Michael and Laszlo who I have CCed) on > >this. > > Kevin, Do you have a pref

[Qemu-devel] [PATCH-v2 3/3] vhost: Skip uninitialized VQs in vhost_virtqueue_[start, stop]

2013-04-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds virtio_queue_valid() checks in vhost_virtqueue_start() and vhost_virtqueue_stop() to avoid uninitialized VQs during vhost-scsi-pci seabios operation, where we currently expect only the request VQ to have been initialized before virtio-scsi LLD guest hand-o

[Qemu-devel] [PATCH-v2 2/3] virtio-pci: Add virtio_queue_valid checks ahead of virtio_queue_get_num

2013-04-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a number of virtio_queue_valid() checks to virtio-pci ahead of virtio_queue_get_num() usage in order to skip operation upon the detection of an uninitialized VQ. There is one exception in virtio_ioport_read():VIRTIO_PCI_QUEUE_NUM, where virtio_queue_get_n

[Qemu-devel] [PATCH-v2 1/3] virtio: add API to check that ring is setup

2013-04-01 Thread Nicholas A. Bellinger
From: Michael S. Tsirkin virtio scsi makes it legal to only setup a subset of rings. The only way to detect the ring is setup seems to be to check whether PA was written to. Add API to do this, and teach code to use it instead of checking hardware queue size. (nab: use .vring.desc instead of .

[Qemu-devel] [PATCH-v2 0/3] virtio/vhost: Add checks for uninitialized VQs

2013-04-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, This series adds a virtio_queue_valid() for use by virtio-pci code in order to prevent opreations upon uninitialized VQs, which is currently expected to occur during seabios setup of virtio-scsi with in-flight vhost-scsi-pci device code. On the vhost side, it

Re: [Qemu-devel] [PATCH 0/3] virtio/vhost: Add checks for uninitialized VQs

2013-04-01 Thread Nicholas A. Bellinger
On Sun, 2013-03-31 at 10:46 +0300, Michael S. Tsirkin wrote: > On Fri, Mar 29, 2013 at 04:33:09AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi folks, > > > > This series adds a virtio_queue_valid() for use by virtio-pci code in > > order to prevent opreations upon

Re: [Qemu-devel] [PATCH 3/3] vhost: Check+skip uninitialized VQs in vhost_verify_ring_mappings

2013-04-01 Thread Nicholas A. Bellinger
On Sun, 2013-03-31 at 10:45 +0300, Michael S. Tsirkin wrote: > On Fri, Mar 29, 2013 at 04:33:12AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > With the virtio_queue_valid() checks in place to skip uninitialized VQs > > within virtio-pci code, go ahead and skip the same

Re: [Qemu-devel] [PATCH 2/3] virtio-pci: Add virtio_queue_valid checks ahead of virtio_queue_get_num

2013-04-01 Thread Nicholas A. Bellinger
On Sun, 2013-03-31 at 10:37 +0300, Michael S. Tsirkin wrote: > On Fri, Mar 29, 2013 at 04:33:11AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds a number of virtio_queue_valid() checks to virtio-pci > > ahead of virtio_queue_get_num() usage in order to sk

Re: [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly

2013-04-01 Thread Alberto Garcia
On Wed, Mar 27, 2013 at 08:29:41PM +0100, Hans de Goede wrote: > Signed-off-by: Hans de Goede > Cc: Alberto Garcia Sorry for the delay, just came back from holidays :) I've just tested it and the change looks fine to me. Signed-off-by: Alberto Garcia Berto

[Qemu-devel] [Bug 1162963] Re: migration fails with error about ram device

2013-04-01 Thread Serge Hallyn
Specifying the memory size, the memballoon info, and hard drive files on the receiving end makes it work. ** No longer affects: qemu ** Changed in: qemu (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

[Qemu-devel] [Bug 1162963] [NEW] migration fails with error about ram device

2013-04-01 Thread Serge Hallyn
Public bug reported: On one machine I call ./qemu-system-x86_64 -m 1024 -drive file=/srv/z.img,if=virtio,cache=none -vnc :1 -monitor stdio on another, I call ./qemu-system-x86_64 -incoming tcp:0.0.0.0: -vnc :1 -monitor stdio then in the first monitor I call migrate -b tcp:10.42.43.1:

[Qemu-devel] [Bug 1162644] Re: qemu-system-x86_64 crashed with SIGABRT in __assert_fail_base()

2013-04-01 Thread Serge Hallyn
Ok, thanks - i did run it 3 or 4 times. How often would you say it fails for you? I will mark this as affecting the upstream qemu project based on comment #10. ** Also affects: qemu Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: Incomplete => New -- Yo

Re: [Qemu-devel] [PATCH 0/3] piix_pci cleanups

2013-04-01 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory

2013-04-01 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] qemu-bridge-helper: force usage of a very high MAC address for the bridge

2013-04-01 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3 0/6] virtio-balloon refactoring.

2013-04-01 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] hw/milkymist-softusb: set buffer in softusb_read_{dmem, pmem} error path

2013-04-01 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH 6/9] vfio-pci: Add extra debugging

2013-04-01 Thread Alex Williamson
Often when debugging it's useful to be able to disable bypass paths so no interactions with the device are missed. Add some extra debug options to do this. Also add device info on read/write BAR accesses, which is useful when debugging more than one assigned device. A couple DPRINTFs also had re

[Qemu-devel] [PATCH 9/9] vfio: cleanup includes

2013-04-01 Thread Alex Williamson
Starting to get messy, put the back in alphabetical order. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 0d2a445..693a9ff 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_pci.c @@ -19,

Re: [Qemu-devel] [PATCH 01/12] target-i386: consolidate error propagation in x86_cpu_realizefn()

2013-04-01 Thread Eduardo Habkost
On Thu, Mar 21, 2013 at 03:28:34PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost > --- > target-i386/cpu.c | 17 ++--- > 1 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index a06

[Qemu-devel] [PATCH 5/9] qemu vfio-pci: Graphics device quirks

2013-04-01 Thread Alex Williamson
Graphics cards have a number of different backdoors. Some of these are alternative ways to get PCI BAR addresses, some of them are complete mirrors of PCI config space available through MMIO and I/O port access. These quirks cover a number of ATI Radeon and Nvidia devices. On the ATI/AMD side, t

[Qemu-devel] [PATCH 7/9] vfio-pci: Move devices to D0 on reset

2013-04-01 Thread Alex Williamson
Guests may leave devices in a low power state at reboot, but we expect devices to be woken up for the next boot. Make this happen. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index

[Qemu-devel] [PATCH 4/9] qemu vfio-pci: Add support for VGA MMIO and I/O port access

2013-04-01 Thread Alex Williamson
Most VGA cards need some kind of quirk to fully operate since they hide backdoors to get to other registers outside of PCI config space within the registers, but this provides the base infrastructure. If we could identity map PCI resources for assigned devices we would need a lot fewer quirks. To

[Qemu-devel] [PATCH 8/9] vfio: Add bootindex support

2013-04-01 Thread Alex Williamson
Signed-off-by: Alex Williamson --- hw/vfio_pci.c |5 + 1 file changed, 5 insertions(+) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index d310730..0d2a445 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_pci.c @@ -30,6 +30,7 @@ #include "qemu/event_notifier.h" #include "exec/address-spaces.h" #

[Qemu-devel] [PATCH 3/9] vfio-pci: Add PCIe capability mangling based on bus type

2013-04-01 Thread Alex Williamson
Windows seems to pay particular interest to the PCIe header type of devices and will fail to load drivers if we attach Endpoint devices or Legacy Endpoint devices to the Root Complex. We can use pci_bus_is_express and pci_bus_is_root to determine the bus type and mangle the type appropriately: *

[Qemu-devel] [PATCH 2/9] vfio-pci: Generalize PCI config mangling

2013-04-01 Thread Alex Williamson
Kernel-side vfio virtualizes all of config space, but some parts are unique to Qemu. For instance we may or may not expose the ROM BAR, Qemu manages MSI/MSIX, and Qemu manages the multi-function bit so that single function devices can appear as multi-function and vica versa. Generalize this into a

[Qemu-devel] [PATCH 1/9] linux-headers: Update to v3.9-rc2

2013-04-01 Thread Alex Williamson
Unedited scripts/update-linux-headers.sh run against v3.9-rc2 tag Signed-off-by: Alex Williamson --- linux-headers/linux/vfio.h |9 + 1 file changed, 9 insertions(+) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index f787b72..e094121 100644 --- a/linux-header

[Qemu-devel] [GIT PULL 0/9] vfio-pci updates & VGA support

2013-04-01 Thread Alex Williamson
Hi Anthony, The following changes since commit 174d4d215fb49b4d43196e62f22c2533431b260e: tcg/mips: Implement muls2_i32 (2013-04-01 18:49:17 +0200) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-pci-for-qemu-20130401.0 for you to fetch changes up t

Re: [Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-01 Thread Alex Bligh
Stefano, --On 1 April 2013 16:44:05 +0100 Stefano Stabellini wrote: Note this patch is compile-tested only. I think the patch looks good, just a minor comment. Thanks. I guess I ought to actually test it works then :-) +/* fill info + * Temporarily write zero sectors as we won'

[Qemu-devel] [RFC 4/4] target-i386: Use qapi for x86_cpu_get_feature_words()

2013-04-01 Thread Eduardo Habkost
Add a schema for QAPI definitions that will be used by *-user. Example output: $ ./QMP/qmp --path=/tmp/m qom-get --path=/machine/unattached/device[1] --property=feature-words item[0].cpuid-register: EDX item[0].cpuid-input-eax: 2147483658 item[0].features: 0 item[1].cpuid-register: EAX

[Qemu-devel] [RFC 3/4] target-i386: Add "feature-words" property

2013-04-01 Thread Eduardo Habkost
This property will be useful for libvirt, as libvirt already has logic based on low-level feature bits (not feature names), so it will be really easy to convert the current libvirt logic to something using the "feature-words" property. The property will have two main use cases: - Checking host ca

[Qemu-devel] [RFC 1/4] target-i386: Add ECX information to FeatureWordInfo

2013-04-01 Thread Eduardo Habkost
FEAT_7_0_EBX uses ECX as input, so we have to take that into account when reporting feature word values. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 4b43759..974a8c

[Qemu-devel] [RFC 2/4] target-i386: Move feature word array outside get_register_name_32()

2013-04-01 Thread Eduardo Habkost
The array will be used by the "feature-words" properties to output the register enum value. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 974a8c6..20

[Qemu-devel] [RFC 0/4] target-i386: Add "feature-words" CPU object property

2013-04-01 Thread Eduardo Habkost
As the work to get X86CPU subclasses static properties defined is taking very long to get reviewed and we risk not getting it finished in 1.5, I am sending an alternative mechanism to allow libvirt to probe for CPU model information. It's interesting to note that this alternative solution is actua

Re: [Qemu-devel] [PATCH V10 15/17] block: dump to buffer for bdrv_image_info_dump()

2013-04-01 Thread Eric Blake
On 03/22/2013 08:19 AM, Wenchao Xia wrote: > This allow hmp use this function, just like qemu-img. > It also returns a pointer now to make it easy to use. > > > -void bdrv_image_info_dump(ImageInfo *info) > +GCC_FMT_ATTR(3, 4) > +static void snprintf_tail(char **p_buf, int *p_size, const char

[Qemu-devel] [Bug 1162644] Re: qemu-system-x86_64 crashed with SIGABRT in __assert_fail_base()

2013-04-01 Thread Lucas Meneghel Rodrigues
On my F19 box, it's failing about 2/3 of the attempts. What is funny is that on the Ubuntu 13.04 box, I can't get the problem reproduced anymore, for some reason beyond me. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device

2013-04-01 Thread Corey Bryant
On 03/28/2013 05:03 AM, Paolo Bonzini wrote: Il 26/03/2013 15:14, Corey Bryant ha scritto: This patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connects them to the RS

Re: [Qemu-devel] [PATCH 0/5] Translation improvements

2013-04-01 Thread Anthony Liguori
Aurelien Jarno writes: > This patch series marks a few more messages as translatable, improves > po/Makefile and add French translation. Reviewed-by: Anthony Liguori Regards, Anthony Liguori > > Aurelien Jarno (5): > gtk: make more messages translatable > po/Makefile: simplify > po/Mak

[Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown

2013-04-01 Thread Bruce Rogers
While investigating why a 32 bit Windows 2003 guest wasn't able to successfully perform a shutdown /h, it was discovered that commit afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 inadvertently dropped the initialization of the s4_val used to handle s4 shutdown. Initialize the value as before. Signed-of

[Qemu-devel] [PATCH 5/5] po: add French translation

2013-04-01 Thread Aurelien Jarno
Cc: Anthony Liguori Signed-off-by: Aurelien Jarno --- po/fr_FR.po | 62 +++ 1 file changed, 62 insertions(+) create mode 100644 po/fr_FR.po diff --git a/po/fr_FR.po b/po/fr_FR.po new file mode 100644 index 000..27d8636 --- /dev/null

[Qemu-devel] [PATCH 2/5] po/Makefile: simplify

2013-04-01 Thread Aurelien Jarno
In the hope we get more translations, we should not have to modify po/Makefile for each of them. Cc: Anthony Liguori Signed-off-by: Aurelien Jarno --- po/Makefile | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/po/Makefile b/po/Makefile index 2b4420f..2c0193e

[Qemu-devel] [PATCH 0/5] Translation improvements

2013-04-01 Thread Aurelien Jarno
This patch series marks a few more messages as translatable, improves po/Makefile and add French translation. Aurelien Jarno (5): gtk: make more messages translatable po/Makefile: simplify po/Makefile: correctly pass QEMU version po: update existing translation files po: add French trans

[Qemu-devel] [PATCH 4/5] po: update existing translation files

2013-04-01 Thread Aurelien Jarno
Cc: Paolo Bonzini Cc: Kevin Wolf Cc: Anthony Liguori Signed-off-by: Aurelien Jarno --- po/de_DE.po| 41 - po/it.po | 41 - po/messages.po | 36 3 files changed,

[Qemu-devel] [PATCH 3/5] po/Makefile: correctly pass QEMU version

2013-04-01 Thread Aurelien Jarno
Cc: Anthony Liguori Signed-off-by: Aurelien Jarno --- po/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/Makefile b/po/Makefile index 2c0193e..8297ab5 100644 --- a/po/Makefile +++ b/po/Makefile @@ -34,7 +34,7 @@ install: $(OBJS) @msgfmt -o $@ $(SRC_PATH

[Qemu-devel] [PATCH 1/5] gtk: make more messages translatable

2013-04-01 Thread Aurelien Jarno
Anthony Liguori Signed-off-by: Aurelien Jarno --- ui/gtk.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index a5a8156..9692c56 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -210,11 +210,11 @@ static void gd_update_caption(GtkDisplayState *s) bool

Re: [Qemu-devel] [PATCH] linux-user: change do_semop to return target errno when unsuccessful

2013-04-01 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/229787/ From: Peter Maydell [peter.mayd...@linaro.org] Sent: Thursday, March 21, 2013 7:03 PM To: Petar Jovanovic Cc: qemu-devel@nongnu.org; riku.voi...@linaro.org; Petar Jovanovic Subject: Re: [Qemu-devel] [PATCH] li

Re: [Qemu-devel] [Bug 1154328] [NEW] qemu locks up on typing 41 characters at once into serial console

2013-04-01 Thread Aurelien Jarno
On Mon, Apr 01, 2013 at 12:26:16PM +0530, Amit Shah wrote: > On (Tue) 12 Mar 2013 [21:31:29], Andreas Gustafsson wrote: > > > Now cut-and-paste a string containing at least 41 characters into the > > terminal window. I used a string containing 41 copies of the letter > > "X". You can use o

Re: [Qemu-devel] [PATCH v2 12/27] tcg-ppc64: Improve and_i32 with constant

2013-04-01 Thread Richard Henderson
On 2013-04-01 07:55, Aurelien Jarno wrote: >+static void tcg_out_andi32(TCGContext *s, TCGReg dst, TCGReg src, uint32_t c) >+{ >+int mb, me; >+ >+if ((c & 0x) == c) { >+tcg_out32(s, ANDI | SAI(src, dst, c)); >+return; >+} else if ((c & 0x) == c) { >+

Re: [Qemu-devel] [PATCH v2 25/27] tcg-ppc64: Use getauxval for ISA detection

2013-04-01 Thread Richard Henderson
On 2013-04-01 08:00, Aurelien Jarno wrote: I wonder if the same could be used for arm with AT_PLATFORM to detect ARM v5/v6/v7. Yes you can. Once the ppc64 patch set was in, I was planning on seeing what I could infer from the ARM HWCAP bits. E.g. if you have neon then you're at least arm6, et

Re: [Qemu-devel] [PULL 6/6] Monitor: Make output buffer dynamic

2013-04-01 Thread Anthony Liguori
Luiz Capitulino writes: > Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush() > to retry on qemu_chr_fe_write() errors. However, the Monitor's output > buffer can keep growing while the retry is not issued and this can > cause the buffer to overflow. > > To reproduce this issu

[Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect

2013-04-01 Thread Alex Bligh
This commit delays the point at which bdrv_new (and hence blk_open on the underlying device) is called from blk_init to blk_connect. This ensures that in an inbound live migrate, the block device is not opened until it has been closed at the other end. This is in preparation for supporting devices

Re: [Qemu-devel] [PATCH v2 12/27] tcg-ppc64: Improve and_i32 with constant

2013-04-01 Thread Aurelien Jarno
On Mon, Apr 01, 2013 at 08:43:24AM -0700, Richard Henderson wrote: > On 2013-04-01 07:55, Aurelien Jarno wrote: > >>>+static void tcg_out_andi32(TCGContext *s, TCGReg dst, TCGReg src, > >>>uint32_t c) > >>>+{ > >>>+int mb, me; > >>>+ > >>>+if ((c & 0x) == c) { > >>>+tcg_out32(s

Re: [Qemu-devel] [PATCH v2 27/27] tcg-ppc64: Implement mulu2/muls2_i64

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:10PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 27 +++ > tcg/ppc64/tcg-target.h | 4 ++-- > 2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b

Re: [Qemu-devel] [PATCH v2 26/27] tcg-ppc64: Implement add2/sub2_i64

2013-04-01 Thread Aurelien Jarno
On Mon, Mar 04, 2013 at 04:33:09PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 56 > ++ > tcg/ppc64/tcg-target.h | 4 ++-- > 2 files changed, 58 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 1/7] virtio-console: Also throttle when less was written then requested

2013-04-01 Thread Hans de Goede
Hi, On 03/29/2013 10:31 AM, Amit Shah wrote: On (Thu) 28 Mar 2013 [14:28:11], Hans de Goede wrote: This is necessary so that we get properly woken up to write the rest. Signed-off-by: Hans de Goede Acked-by: Amit Shah --- hw/virtio-console.c | 5 +++-- 1 file changed, 3 insertions(+), 2 d

Re: [Qemu-devel] [PATCH V10 13/17] hmp: switch snapshot info function to qmp based one

2013-04-01 Thread Eric Blake
On 03/22/2013 08:19 AM, Wenchao Xia wrote: > This patch using new added function in last commit which retrieve > info from qmp for snapshot info. > > Signed-off-by: Wenchao Xia > --- > monitor.c |2 +- > savevm.c | 64 > - > 2

  1   2   >