Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-20 Thread Gerd Hoffmann
On 03/20/13 17:59, Alon Levy wrote: >> > I thought we previously discussed this? Just implement a migration >> > hook >> > in the spice code. > We did and Gerd objected so I sent this to have this discussion again, with > him. migration section != migration hook. I think what Anthony asks for i

Re: [Qemu-devel] [PATCH v3] pciinit: Enable default VGA device

2013-03-20 Thread Gerd Hoffmann
On 03/20/13 17:58, Alex Williamson wrote: > As QEMU gains PCI bridge and PCIe root port support, we won't always > find the VGA device on the root bus. We therefore need to add support > to find and enable a VGA device and the path to it through the VGA > Enable support in the PCI bridge control r

[Qemu-devel] [RFC qemu PATCH] only writing out the last byte of MAC makes it have effect

2013-03-20 Thread Amos Kong
The lengcy guests don't have mac programming command, we don't know when it's safe to use MAC. This patch changed qemu to makes MAC change effect when the last byte of MAC is written to config space. MAC address takes first 6 bytes of config space of virtio-net, the addr is 5 when the last byte is

Re: [Qemu-devel] [RFC] qmp interface for save vmstate to image

2013-03-20 Thread Wenchao Xia
Hi, Pavel Sorry for late response. > Hi Wenchao, > > It seems the we are working on the same thing. You are trying to improve > the size of vmstate if you want to save it to file or as an internal > snapshot. > > I'm also working on that issue and I think that my solution could be > also used f

Re: [Qemu-devel] [PATCH][RFC 03/14] qdev: remove redundant abort()

2013-03-20 Thread li guang
ping ... can this change be accepted? 在 2013-03-18一的 09:26 +0100,Andreas Färber写道: > Am 13.03.2013 09:01, schrieb liguang: > > Signed-off-by: liguang > > --- > > hw/qdev.c |3 +-- > > 1 files changed, 1 insertions(+), 2 deletions(-) > > > > diff --git a/hw/qdev.c b/hw/qdev.c > > index 689cd

Re: [Qemu-devel] [PATCH][RFC 01/14] gitignore: ignore more files

2013-03-20 Thread li guang
ping ... can this change be accepted? 在 2013-03-13三的 16:01 +0800,liguang写道: > ignore *.patch, *.gcda, *.gcno > > Signed-off-by: liguang > --- > .gitignore |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/.gitignore b/.gitignore > index 27ad002..9c234a3 100644 > -

[Qemu-devel] [PATCH] rdma: don't make pages writeable if not requiested

2013-03-20 Thread Michael S. Tsirkin
core/umem.c seems to get the arguments to get_user_pages in the reverse order: it sets writeable flag and breaks COW for MAP_SHARED if and only if hardware needs to write the page. This breaks memory overcommit for users such as KVM: each time we try to register a page to send it to remote, this b

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael S. Tsirkin
On Tue, Mar 19, 2013 at 01:49:34PM -0400, Michael R. Hines wrote: > I also did a test using RDMA + cgroup, and the kernel killed my QEMU :) > > So, infiniband is not smart enough to know how to avoid pinning a > zero page, I guess. > > - Michael > > On 03/19/2013 01:14 PM, Paolo Bonzini wrote: >

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael S. Tsirkin
On Wed, Mar 20, 2013 at 04:56:01PM -0400, Michael R. Hines wrote: > > Forgive me, vmsplice system call? Or some other interface? > > I'm not following.. > > On 03/20/2013 04:46 PM, Michael S. Tsirkin wrote: > >On Wed, Mar 20, 2013 at 04:39:00PM -0400, Michael R. Hines wrote: > >>Unmapped vir

Re: [Qemu-devel] [PATCH 07/23] console: switch color_table_rgb to pixman_color_t

2013-03-20 Thread Søren Sandmann
Gerd Hoffmann writes: > @@ -255,7 +250,10 @@ enum color_names { > }; > #endif > > -static const uint32_t color_table_rgb[2][8] = { > +#define QEMU_RGB(r, g, b) \ > +{ .red = r << 8, .green = g << 8, .blue = b << 8, .alpha = 0 } Are you sure y

Re: [Qemu-devel] QEMU Migration

2013-03-20 Thread Mrugani Kurtadikar
I want to get information in terms of number of active qemu processes. How can I track this information from host? As you said, the commands 'info migrate' can be run in qemu console. For this, I have to switch to qemu console. How can I get the information whether the qemu processes are live or su

[Qemu-devel] [RFC virt-spec PATCH] only writing out the last byte of MAC makes it have effect

2013-03-20 Thread Amos Kong
The lengcy guests don't have mac programming command, we don't know when it's safe to use MAC. We can change QEMU to make MAC change effect when the last byte of MAC is written to config space. Signed-off-by: Amos Kong --- virtio-spec.lyx | 11 ++- 1 file changed, 10 insertions(+), 1 del

Re: [Qemu-devel] [SeaBIOS] [PATCH v3] pciinit: Enable default VGA device

2013-03-20 Thread Paul Menzel
Dear Alex, Am Mittwoch, den 20.03.2013, 10:58 -0600 schrieb Alex Williamson: > As QEMU gains PCI bridge and PCIe root port support, could you give a commit or version for QEMU please. > we won't always find the VGA device on the root bus. We therefore > need to add support to find and enable a

[Qemu-devel] [PATCH] QOM-ify TPM

2013-03-20 Thread Stefan Berger
With much code borrowed from the rng QOM implementation. Signed-off-by: Stefan Berger --- backends/Makefile.objs |2 backends/tpm.c | 154 include/qemu/tpm.h | 170 + include/tpm/tpm.

Re: [Qemu-devel] [PATCH] block: fix bdrv_exceed_iops_limits wait computation

2013-03-20 Thread Zhi Yong Wu
On Wed, 2013-03-20 at 16:12 +0100, Stefan Hajnoczi wrote: > On Wed, Mar 20, 2013 at 03:56:33PM +0100, Benoît Canet wrote: > > > But I don't understand why bs->slice_time is modified instead of keeping > > > it constant at 100 ms: > > > > > > bs->slice_time = wait_time * BLOCK_IO_SLICE_TIME * 10

Re: [Qemu-devel] [RFC PATCH v4 07/30] Add SIZE type to qdev properties

2013-03-20 Thread li guang
在 2013-03-20三的 08:24 -0600,Eric Blake写道: > On 03/20/2013 12:06 AM, li guang wrote: > > >> +return snprintf(dest, len, "%0.03f%c", (double)*ptr/div, suffixes[i]); > > ^^ ^^^ > >> +} > >> + > > > > IMHO, you may need (double)(*ptr/div),

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-20 Thread li guang
在 2013-03-20三的 10:50 +,Peter Maydell写道: > On 20 March 2013 00:56, li guang wrote: > > 在 2013-03-19二的 10:15 +,Peter Maydell写道: > >> The point is that how exactly power controllers connect > >> to devices, and which devices respond to reset/suspend/etc > >> is a property of the individual ma

Re: [Qemu-devel] [PATCH 02/11] change element type from "char" to "unsigned char" in ACPI table data

2013-03-20 Thread Laszlo Ersek
On 03/21/13 00:40, Eric Blake wrote: > On 03/20/2013 05:23 PM, Laszlo Ersek wrote: >> The data is binary, not textual. >> >> Also, acpi_table_add() abuses the "char *f" pointer -- which normally >> points to file names to load -- to poke into the table. Introduce "char >> unsigned *table_start" for

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-20 Thread Laszlo Ersek
On 03/21/13 00:45, Eric Blake wrote: > On 03/20/2013 05:23 PM, Laszlo Ersek wrote: >> Signed-off-by: Laszlo Ersek >> --- >> qapi-schema.json | 58 >> ++ > > No counterpart change to qmp-commands.hx showing a valid usage? This is not a qmp co

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-20 Thread Eric Blake
On 03/20/2013 05:23 PM, Laszlo Ersek wrote: > Signed-off-by: Laszlo Ersek > --- > qapi-schema.json | 58 > ++ No counterpart change to qmp-commands.hx showing a valid usage? > 1 files changed, 58 insertions(+), 0 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH 02/11] change element type from "char" to "unsigned char" in ACPI table data

2013-03-20 Thread Eric Blake
On 03/20/2013 05:23 PM, Laszlo Ersek wrote: > The data is binary, not textual. > > Also, acpi_table_add() abuses the "char *f" pointer -- which normally > points to file names to load -- to poke into the table. Introduce "char > unsigned *table_start" for that purpose. > > Signed-off-by: Laszlo E

[Qemu-devel] [PATCH 10/11] pc_acpi_init(): don't bail as soon as failing to find default DSDT

2013-03-20 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/i386/pc.c | 33 + 1 files changed, 17 insertions(+), 16 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 23f9800..0a5d4d4 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -888,9 +888,7 @@ void pc_cpus_init(const char

[Qemu-devel] [PATCH 02/11] change element type from "char" to "unsigned char" in ACPI table data

2013-03-20 Thread Laszlo Ersek
The data is binary, not textual. Also, acpi_table_add() abuses the "char *f" pointer -- which normally points to file names to load -- to poke into the table. Introduce "char unsigned *table_start" for that purpose. Signed-off-by: Laszlo Ersek --- hw/pc.h |2 +- hw/acpi.c | 17 +

[Qemu-devel] [PATCH 11/11] i386/pc: build ACPI MADT for fw_cfg clients

2013-03-20 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/pc.h |3 + hw/acpi.c|7 +-- hw/i386/pc.c | 128 ++ 3 files changed, 134 insertions(+), 4 deletions(-) diff --git a/hw/pc.h b/hw/pc.h index b8574a2..2a4358f 100644 --- a/hw/pc.h +++ b/hw/

[Qemu-devel] [PATCH 09/11] Introduce IO_APIC_DEFAULT_ADDRESS for 0xfec00000

2013-03-20 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/i386/pc.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index c0a1bff..23f9800 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -72,6 +72,8 @@ #define FW_CFG_E820_TABLE (FW_CFG_ARCH_LOCAL + 3) #define F

[Qemu-devel] [PATCH 05/11] acpi_table_add(): accept QemuOpts and parse it with OptsVisitor

2013-03-20 Thread Laszlo Ersek
As one consequence, strtok() -- which modifies its argument -- is replaced with g_strsplit(). Signed-off-by: Laszlo Ersek --- hw/pc.h|2 +- include/sysemu/arch_init.h |3 +- arch_init.c|4 +- hw/acpi.c | 139 ++

[Qemu-devel] [PATCH 08/11] extract/unify the constant 0xfee00000 as APIC_DEFAULT_ADDRESS

2013-03-20 Thread Laszlo Ersek
A common dependency of the constant's current users: - hw/apic_common.c - hw/i386/kvmvapic.c - target-i386/cpu.c is "target-i386/cpu.h". Signed-off-by: Laszlo Ersek --- target-i386/cpu.h |2 ++ hw/apic_common.c |2 +- hw/i386/kvmvapic.c |2 -- target-i386/cpu.c |4 +--- 4 fil

[Qemu-devel] [PATCH 07/11] like acpi_table_install(), acpi_table_add() should propagate Errors

2013-03-20 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/pc.h |2 +- arch_init.c |9 +++-- hw/acpi.c|9 ++--- hw/i386/pc.c |8 ++-- 4 files changed, 16 insertions(+), 12 deletions(-) diff --git a/hw/pc.h b/hw/pc.h index 7aaba3c..b8574a2 100644 --- a/hw/pc.h +++ b/hw/pc.h @@ -113

[Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-20 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- qapi-schema.json | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index fdaa9da..aae6767 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3442

[Qemu-devel] [PATCH 06/11] acpi_table_add(): extract and reimplement internals

2013-03-20 Thread Laszlo Ersek
The new function acpi_table_install() installs any blob the caller passes in. In the next patches this function will be promoted from helper role to extern. Reimplementing the logic should make it easier to understand. It also removes a buffer overflow when has_header && cumulative_file_s

[Qemu-devel] [PATCH 01/11] strip some whitespace

2013-03-20 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- target-i386/cpu.h |2 +- arch_init.c |2 +- vl.c |8 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 48f41ca..5284ebc 100644 --- a/target-i386/cpu.h +++ b/target-i38

[Qemu-devel] [PATCH 03/11] acpi_table_add(): report fatal errors through an internal Error object

2013-03-20 Thread Laszlo Ersek
The upcoming changes will need a cleanup section at the end of the function, plus OptsVisitor reports errors via Error. For now keep channeling any Errors to stderr. Signed-off-by: Laszlo Ersek --- hw/acpi.c | 33 +++-- 1 files changed, 19 insertions(+), 14 deletion

[Qemu-devel] [PATCH 00/11] build ACPI MADT for fw_cfg clients

2013-03-20 Thread Laszlo Ersek
This series reworks the internals of the -acpitable command line option, and if that option is not specified, produces the APIC (MADT) table inside qemu, to be consumed over fw_cfg (alongside the DSDT). checkpatch.pl raises quite a few complaints on the start-to-end diff of this series, but all of

Re: [Qemu-devel] kvm suspend performance

2013-03-20 Thread Eric Blake
On 03/20/2013 04:44 PM, Thomas Knauth wrote: > Hi Stefan, > > thanks for taking the time to reply. > > On Wed, Mar 20, 2013 at 9:11 AM, Stefan Hajnoczi wrote: > >> Which QEMU or libvirt command are you using to suspend the guest to >> disk? >> > > virsh save Then this is as much a libvirt q

Re: [Qemu-devel] QOM-ify QemuConsoles ...

2013-03-20 Thread Stefan Berger
On 03/20/2013 09:39 AM, Andreas Färber wrote: Hi Gerd, Am 20.03.2013 10:55, schrieb Gerd Hoffmann: I think the next logical step ahead is to QOM-ify the QemuConsoles, so we can link the QemuConsole to the thing actually backing it. For a graphical console that would be the emlated graphic devi

Re: [Qemu-devel] kvm suspend performance

2013-03-20 Thread Thomas Knauth
Hi Stefan, thanks for taking the time to reply. On Wed, Mar 20, 2013 at 9:11 AM, Stefan Hajnoczi wrote: > Which QEMU or libvirt command are you using to suspend the guest to > disk? > virsh save > Why do you say it is CPU-bound? Did you use a tool like vmstat or > simply because it does 3

Re: [Qemu-devel] [PATCH 2/2] QMP: TPM QMP and man page documentation updates

2013-03-20 Thread Eric Blake
On 03/20/2013 10:34 AM, Corey Bryant wrote: > Signed-off-by: Corey Bryant > --- > qemu-options.hx |3 +- > qmp-commands.hx | 58 > +++ > 2 files changed, 60 insertions(+), 1 deletions(-) Reviewed-by: Eric Blake [No cover letter meant I

Re: [Qemu-devel] [PATCH 1/2] QMP: Remove duplicate TPM type from query-tpm

2013-03-20 Thread Eric Blake
On 03/20/2013 10:34 AM, Corey Bryant wrote: > Signed-off-by: Corey Bryant > --- > hmp.c|8 > qapi-schema.json | 12 > tpm/tpm.c|9 - > 3 files changed, 12 insertions(+), 17 deletions(-) Reviewed-by: Eric Blake Safe to do now, because

Re: [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations

2013-03-20 Thread Eric Blake
On 03/20/2013 12:39 PM, Kevin Wolf wrote: > A file name may only specified if no host or socket path is specified. > The latter two may not appear at the same time either. > > Signed-off-by: Kevin Wolf > --- > block/nbd.c | 14 ++ > 1 file changed, 14 insertions(+) Reviewed-by: Eric

Re: [Qemu-devel] [PATCH v2 10/12] block: Allow omitting the file name when using driver-specific options

2013-03-20 Thread Eric Blake
On 03/20/2013 12:39 PM, Kevin Wolf wrote: > After this patch, using -drive with an empty file name continues to open > the file if driver-specific options are used. If no driver-specific > options are specified, the semantics stay as it was: It defines a drive > without an inserted medium. > > In

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 03:56:18PM -0400, Luiz Capitulino wrote: > On Wed, 20 Mar 2013 14:39:55 -0500 > mdroth wrote: > > > So I wonder if, rather than pursuing option 3, we just introduce an > > interface that does what we really want and returns handles as UUIDs, > > then mark the existing inte

Re: [Qemu-devel] QEMU Migration

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 01:26:22PM +0530, Mrugani Kurtadikar wrote: > Hi, >We are trying qemu migration. > Suppose VM1 is migrated from hostA to hostB. > After complete migration, VM1 starts on hostB. But VM1 on hostA > remains in suspended mode. > We want to identify all live VMs on hostA. > W

Re: [Qemu-devel] [PATCH] tcg-optimize: Fold sub r,0,x to neg r,x

2013-03-20 Thread Blue Swirl
On Wed, Mar 20, 2013 at 12:13 AM, Richard Henderson wrote: > On 2013-02-23 08:43, Blue Swirl wrote: >>> >>> Signed-off-by: Richard Henderson >>> >--- >>> > tcg/optimize.c | 33 - >>> > 1 file changed, 32 insertions(+), 1 deletion(-) >>> > >>> >I noticed this while

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael R. Hines
Forgive me, vmsplice system call? Or some other interface? I'm not following.. On 03/20/2013 04:46 PM, Michael S. Tsirkin wrote: On Wed, Mar 20, 2013 at 04:39:00PM -0400, Michael R. Hines wrote: Unmapped virtual addresses cannot be pinned for RDMA (the hardware will break), but there's no

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael S. Tsirkin
On Wed, Mar 20, 2013 at 04:45:05PM -0400, Michael R. Hines wrote: > On 03/20/2013 04:37 PM, Michael S. Tsirkin wrote: > >On Wed, Mar 20, 2013 at 04:24:14PM -0400, Michael R. Hines wrote: > >>On 03/20/2013 11:55 AM, Michael S. Tsirkin wrote: > >>>Then, later, in a separate patch, I can implement /de

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael R. Hines
On 03/20/2013 04:37 PM, Michael S. Tsirkin wrote: On Wed, Mar 20, 2013 at 04:24:14PM -0400, Michael R. Hines wrote: On 03/20/2013 11:55 AM, Michael S. Tsirkin wrote: Then, later, in a separate patch, I can implement /dev/pagemap support. When that's done, RDMA dynamic registration will actuall

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael S. Tsirkin
On Wed, Mar 20, 2013 at 04:39:00PM -0400, Michael R. Hines wrote: > Unmapped virtual addresses cannot be pinned for RDMA (the hardware > will break), > but there's no way to know they are unmapped without checking > another data structure. So for RDMA, when you try to register them, this will faul

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael R. Hines
Agreed. Very useful for KSM. Unmapped virtual addresses cannot be pinned for RDMA (the hardware will break), but there's no way to know they are unmapped without checking another data structure. - Michael On 03/20/2013 04:31 PM, Michael S. Tsirkin wrote: OK sure, this could be useful to de

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael S. Tsirkin
On Wed, Mar 20, 2013 at 04:24:14PM -0400, Michael R. Hines wrote: > On 03/20/2013 11:55 AM, Michael S. Tsirkin wrote: > >Then, later, in a separate patch, I can implement /dev/pagemap support. > > > >When that's done, RDMA dynamic registration will actually take effect and > >benefit from actually

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael S. Tsirkin
On Wed, Mar 20, 2013 at 04:20:06PM -0400, Michael R. Hines wrote: > On 03/20/2013 03:06 PM, Michael S. Tsirkin wrote: > > No, not just ballooning. Overcommit (i.e. cgroups). > > Anytime cgroups kicks out a page (or anytime the balloon kicks in), > the page would become unmapped. > >

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael R. Hines
On 03/20/2013 11:55 AM, Michael S. Tsirkin wrote: Then, later, in a separate patch, I can implement /dev/pagemap support. When that's done, RDMA dynamic registration will actually take effect and benefit from actually verifying that the page is mapped or not. - Michael Mapped into guest? You me

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael R. Hines
On 03/20/2013 03:06 PM, Michael S. Tsirkin wrote: No, not just ballooning. Overcommit (i.e. cgroups). Anytime cgroups kicks out a page (or anytime the balloon kicks in), the page would become unmapped. OK but we still need to send that page to remote. It's in swap but has guest data in there, yo

Re: [Qemu-devel] [PATCH 22/23] gtk: show a window for each graphical QemuConsole

2013-03-20 Thread Peter Maydell
On 20 March 2013 09:43, Gerd Hoffmann wrote: > Multihead support: For each graphical console we'll create a gtk > window, so with multiple graphics cards installed you get a gtk window > for each. vte tabs are attached to the console #0 window. So is this going to mean arm's vexpress-a9 gets a

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread Luiz Capitulino
On Wed, 20 Mar 2013 14:39:55 -0500 mdroth wrote: > So I wonder if, rather than pursuing option 3, we just introduce an > interface that does what we really want and returns handles as UUIDs, > then mark the existing interfaces as deprecated (and then remove them > within the next 300 years so our

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 02:38:35PM -0400, Luiz Capitulino wrote: > On Wed, 20 Mar 2013 13:14:21 -0500 > mdroth wrote: > > > > > > > > > +handle = s->pstate.fd_counter++; > > > > > > > > +if (s->pstate.fd_counter < 0) { > > > > > > > > +s->pstate.fd_counter = 0; > > > > > > > > +

Re: [Qemu-devel] [PATCH] vmxcap: Update according to SDM of January 2013

2013-03-20 Thread Marcelo Tosatti
On Sun, Mar 17, 2013 at 11:45:50AM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > This adds reporting of VMCS shadowing, #VE, IA32_SMBASE, unrestricted > VMWRITE and fixes the range of the MSEG revision ID. > > Signed-off-by: Jan Kiszka Applied, thanks.

Re: [Qemu-devel] [PATCH 22/23] gtk: show a window for each graphical QemuConsole

2013-03-20 Thread Igor Mitsyanko
On 03/20/2013 01:43 PM, Gerd Hoffmann wrote: > >> Multihead support: For each graphical console we'll create a gtk >> window, so with multiple graphics cards installed you get a gtk window >> for each. vte tabs are attached to the console #0 window. >> --- >> ui/gtk.c | 40 +++

Re: [Qemu-devel] [PATCH 12/23] console: simplify screendump

2013-03-20 Thread Igor Mitsyanko
On 03/20/2013 01:43 PM, Gerd Hoffmann wrote: > >> Screendumps are alot simpler as we can update non-active >> QemuConsoles now. So we only need to update the QemuConsole >> we want write out, then dump the DisplaySurface content into >> a ppm file. Done. >> >> No console switching needed. No spe

Re: [Qemu-devel] [PATCH 09/23] console: displaystate init revamp

2013-03-20 Thread Igor Mitsyanko
On 03/20/2013 01:43 PM, Gerd Hoffmann wrote: > >> We have only one DisplayState, so there is no need for the "next" >> linking, rip it. Also consolidate all displaystate initialization >> into init_displaystate(). This function is called by vl.c after >> creating the devices (and thus all QemuCon

Re: [Qemu-devel] [PATCH 07/23] console: switch color_table_rgb to pixman_color_t

2013-03-20 Thread Igor Mitsyanko
On 03/20/2013 01:43 PM, Gerd Hoffmann wrote: > >> Now that all text console rendering uses pixman we can easily >> switch the color tables to use pixman_color_t directly. >> >> Signed-off-by: Gerd Hoffmann >> --- >> ui/console.c | 24 >> 1 file changed, 8 insertions(+

[Qemu-devel] [PATCH v2 07/12] block: Introduce .bdrv_parse_filename callback

2013-03-20 Thread Kevin Wolf
If a driver needs structured data and not just a string, it can provide a .bdrv_parse_filename callback now that parses the command line string into separate options. Keeping this separate from .bdrv_open_filename ensures that the preferred way of directly specifying the options always works as wel

[Qemu-devel] [PATCH v2 02/12] block: Pass bdrv_file_open() options to block drivers

2013-03-20 Thread Kevin Wolf
Specify -drive file.option=... on the command line to pass the option to the protocol instead of the format driver. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block.c | 63 --- 1 file changed, 56 insertions(+), 7 deletions(-

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael S. Tsirkin
On Wed, Mar 20, 2013 at 12:08:40PM -0400, Michael R. Hines wrote: > > On 03/20/2013 11:55 AM, Michael S. Tsirkin wrote: > >On Wed, Mar 20, 2013 at 11:15:48AM -0400, Michael R. Hines wrote: > >>OK, can we make a deal? =) > >> > >>I'm willing to put in the work to perform the dynamic registration >

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-20 Thread Anthony Liguori
Alon Levy writes: >> Alon Levy writes: >> >> > Signed-off-by: Alon Levy >> > --- >> > include/char/char.h | 12 >> > qemu-char.c | 7 +++ >> > 2 files changed, 19 insertions(+) >> > >> > diff --git a/include/char/char.h b/include/char/char.h >> > index 0326b2a..0fdca

[Qemu-devel] [PATCH v2 10/12] block: Allow omitting the file name when using driver-specific options

2013-03-20 Thread Kevin Wolf
After this patch, using -drive with an empty file name continues to open the file if driver-specific options are used. If no driver-specific options are specified, the semantics stay as it was: It defines a drive without an inserted medium. In order to achieve this, bdrv_open() must be made safe t

[Qemu-devel] [PATCH v2 08/12] block: Rename variable to avoid shadowing

2013-03-20 Thread Kevin Wolf
bdrv_open() uses two different variables called options. Rename one of them to avoid confusion and to allow the outer one to be accessed everywhere. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 09/12] block: Make find_image_format safe with NULL filename

2013-03-20 Thread Kevin Wolf
In order to achieve this, the .bdrv_probe callbacks of all drivers must cope with this. The DMG driver is the only one that bases its decision on the filename and it needs to be changed. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/dmg.c | 13 ++--- 1 file changed, 10 ins

[Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations

2013-03-20 Thread Kevin Wolf
A file name may only specified if no host or socket path is specified. The latter two may not appear at the same time either. Signed-off-by: Kevin Wolf --- block/nbd.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/block/nbd.c b/block/nbd.c index 67f1df2..3d711b2 100644 ---

[Qemu-devel] [PATCH v2 01/12] block: Add options QDict to bdrv_file_open() prototypes

2013-03-20 Thread Kevin Wolf
The new parameter is unused yet. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block.c | 14 +++--- block/blkdebug.c | 5 +++-- block/blkverify.c | 5 +++-- block/cow.c | 2 +- block/curl.c | 3 ++- block/gluster.

[Qemu-devel] [PATCH v2 04/12] nbd: Keep hostname and port separate

2013-03-20 Thread Kevin Wolf
The NBD block supports an URL syntax, for which a URL parser returns separate hostname and port fields. It also supports the traditional qemu syntax encoded in a filename. Until now, after parsing the URL to get each piece of information, a new string is built to be fed to socket functions. Instea

[Qemu-devel] [PATCH v2 11/12] nbd: Use default port if only host is specified

2013-03-20 Thread Kevin Wolf
The URL method already takes care to apply the default port when none is specfied. Directly specifying driver-specific options required the port number until now. Allow leaving it out and apply the default. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/nbd.c | 19 ++---

[Qemu-devel] [PATCH v2 03/12] qemu-socket: Make socket_optslist public

2013-03-20 Thread Kevin Wolf
Allow other users to create the QemuOpts needed for inet_connect_opts(). Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- include/qemu/sockets.h | 2 ++ util/qemu-sockets.c| 24 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/include/qemu/sock

[Qemu-devel] [PATCH v2 06/12] nbd: Accept -drive options for the network connection

2013-03-20 Thread Kevin Wolf
The existing parsers for the file name now parse everything into the bdrv_open() options QDict. Instead of using these parsers, you can now directly specify the options on the command line, like this: qemu-system-x86_64 -drive file=nbd:,file.port=1234,file.host=::1 Clearly the file=... part c

[Qemu-devel] [PATCH v2 05/12] nbd: Remove unused functions

2013-03-20 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- include/block/nbd.h | 2 -- nbd.c | 19 --- 2 files changed, 21 deletions(-) diff --git a/include/block/nbd.h b/include/block/nbd.h index 9b52d50..0903d7a 100644 --- a/include/block/nbd.h +++ b/include/block/nb

[Qemu-devel] [PATCH v2 00/12] block: Driver-specific options for protocols

2013-03-20 Thread Kevin Wolf
Kevin Wolf (12): block: Add options QDict to bdrv_file_open() prototypes block: Pass bdrv_file_open() options to block drivers qemu-socket: Make socket_optslist public nbd: Keep hostname and port separate nbd: Remove unused functions nbd: Accept -drive options for the network connection

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread Luiz Capitulino
On Wed, 20 Mar 2013 13:14:21 -0500 mdroth wrote: > > > > > > > +handle = s->pstate.fd_counter++; > > > > > > > +if (s->pstate.fd_counter < 0) { > > > > > > > +s->pstate.fd_counter = 0; > > > > > > > +} > > > > > > > > > > > > Is this handling the overflow case? Can't fd 0 be

Re: [Qemu-devel] [PATCH 10/11] block: Allow omitting the file name when using driver-specific options

2013-03-20 Thread Kevin Wolf
Am 20.03.2013 um 03:27 hat Eric Blake geschrieben: > > +++ b/block/nbd.c > > @@ -174,7 +174,6 @@ static void nbd_parse_filename(const char *filename, > > QDict *options, > > > > /* extract the host_spec - fail if it's not nbd:... */ > > if (!strstart(file, "nbd:", &host_spec)) { > > -

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 01:40:56PM -0400, Luiz Capitulino wrote: > On Wed, 20 Mar 2013 12:26:30 -0500 > mdroth wrote: > > > On Wed, Mar 20, 2013 at 12:58:51PM -0400, Luiz Capitulino wrote: > > > On Wed, 20 Mar 2013 11:03:08 -0500 > > > mdroth wrote: > > > > > > > On Wed, Mar 20, 2013 at 10:54:5

Re: [Qemu-devel] [SeaBIOS] [PATCH v3] pciinit: Enable default VGA device

2013-03-20 Thread Alex Williamson
On Wed, 2013-03-20 at 19:05 +0100, Paul Menzel wrote: > Dear Alex, > > > Am Mittwoch, den 20.03.2013, 10:58 -0600 schrieb Alex Williamson: > > As QEMU gains PCI bridge and PCIe root port support, > > could you give a commit or version for QEMU please. This would be targeted towards QEMU 1.5. M

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread Luiz Capitulino
On Wed, 20 Mar 2013 12:26:30 -0500 mdroth wrote: > On Wed, Mar 20, 2013 at 12:58:51PM -0400, Luiz Capitulino wrote: > > On Wed, 20 Mar 2013 11:03:08 -0500 > > mdroth wrote: > > > > > On Wed, Mar 20, 2013 at 10:54:51AM -0400, Luiz Capitulino wrote: > > > > > > > > On Fri, 1 Mar 2013 11:40:27 -

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 12:58:51PM -0400, Luiz Capitulino wrote: > On Wed, 20 Mar 2013 11:03:08 -0500 > mdroth wrote: > > > On Wed, Mar 20, 2013 at 10:54:51AM -0400, Luiz Capitulino wrote: > > > > > > On Fri, 1 Mar 2013 11:40:27 -0600 > > > Michael Roth wrote: > > > > > > > Hosts hold on to h

Re: [Qemu-devel] Cortex-M4F Floating Point system registers

2013-03-20 Thread Fabien Chouteau
On 03/20/2013 05:43 PM, Peter Maydell wrote: > On 20 March 2013 16:05, Fabien Chouteau wrote: >> I'm looking at the ARMv7-M profile and the implementation in QEMU. >> Looks like M3 is supported and I'd like to work on M4F (FP context save >> and lazy FP context save). > > This is going to be inter

Re: [Qemu-devel] [PATCH 21/23] gtk: custom cursor support

2013-03-20 Thread Anthony Liguori
Gerd Hoffmann writes: >>> +static void gd_mouse_set(DisplayChangeListener *dcl, >>> + int x, int y, int visible) >>> +{ >>> +/* should warp pointer to x, y here */ >> >> This is just a matter of doing: >> >> gdk_window_get_root_coords(window, x, y, &x_root, &y_ro

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-20 Thread Alon Levy
> Alon Levy writes: > > > Signed-off-by: Alon Levy > > --- > > include/char/char.h | 12 > > qemu-char.c | 7 +++ > > 2 files changed, 19 insertions(+) > > > > diff --git a/include/char/char.h b/include/char/char.h > > index 0326b2a..0fdcaf9 100644 > > --- a/include/ch

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-20 Thread Alon Levy
> Alon Levy writes: > > > Signed-off-by: Alon Levy > > --- > > include/char/char.h | 12 > > qemu-char.c | 7 +++ > > 2 files changed, 19 insertions(+) > > > > diff --git a/include/char/char.h b/include/char/char.h > > index 0326b2a..0fdcaf9 100644 > > --- a/include/ch

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread Luiz Capitulino
On Wed, 20 Mar 2013 11:03:08 -0500 mdroth wrote: > On Wed, Mar 20, 2013 at 10:54:51AM -0400, Luiz Capitulino wrote: > > > > On Fri, 1 Mar 2013 11:40:27 -0600 > > Michael Roth wrote: > > > > > Hosts hold on to handles provided by guest-file-open for periods that can > > > span beyond the life

[Qemu-devel] [PATCH v3] pciinit: Enable default VGA device

2013-03-20 Thread Alex Williamson
As QEMU gains PCI bridge and PCIe root port support, we won't always find the VGA device on the root bus. We therefore need to add support to find and enable a VGA device and the path to it through the VGA Enable support in the PCI bridge control register. Signed-off-by: Alex Williamson --- v3:

Re: [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-20 Thread Alex Williamson
On Wed, 2013-03-20 at 17:46 +0100, Gerd Hoffmann wrote: > Hi, > > >> With qemu/master you can just use 'qemu -L /path/to/seabios/out' instead > >> and qemu will pick up both bios.bin and dsdt from the fresh seabios > >> build directory then (and anything else it doesn't find there from the > >>

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-20 Thread David Scott
Hi, On 20/03/13 10:24, Stefano Stabellini wrote: That is true. My guess is that nobody really migrates HVM guests without PV drivers installed (it's not even possible on XenServer but xl let you do that if you want to). When the PV drivers initialize at boot time, the IDE disk is closed. Theref

Re: [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-20 Thread Gerd Hoffmann
Hi, >> With qemu/master you can just use 'qemu -L /path/to/seabios/out' instead >> and qemu will pick up both bios.bin and dsdt from the fresh seabios >> build directory then (and anything else it doesn't find there from the >> default locations). > > Thanks, yes that's it. QEMU only seems to

Re: [Qemu-devel] Cortex-M4F Floating Point system registers

2013-03-20 Thread Peter Maydell
On 20 March 2013 16:05, Fabien Chouteau wrote: > I'm looking at the ARMv7-M profile and the implementation in QEMU. > Looks like M3 is supported and I'd like to work on M4F (FP context save > and lazy FP context save). This is going to be interesting because we don't currently have any mechanisms

Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-20 Thread Corey Bryant
I just resubmitted this patch as part of another series, so please ignore this one. -- Regards, Corey Bryant On 03/15/2013 01:17 PM, Corey Bryant wrote: Signed-off-by: Corey Bryant --- qemu-options.hx | 3 ++- qmp-commands.hx | 59 +

[Qemu-devel] [PATCH 1/2] QMP: Remove duplicate TPM type from query-tpm

2013-03-20 Thread Corey Bryant
Signed-off-by: Corey Bryant --- hmp.c|8 qapi-schema.json | 12 tpm/tpm.c|9 - 3 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hmp.c b/hmp.c index b0a861c..d319897 100644 --- a/hmp.c +++ b/hmp.c @@ -631,11 +631,11 @@ vo

[Qemu-devel] [PATCH 2/2] QMP: TPM QMP and man page documentation updates

2013-03-20 Thread Corey Bryant
Signed-off-by: Corey Bryant --- qemu-options.hx |3 +- qmp-commands.hx | 58 +++ 2 files changed, 60 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 06dd565..b4e3a2d 100644 --- a/qemu-options.hx +++ b/q

Re: [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-20 Thread Alex Williamson
On Wed, 2013-03-20 at 08:17 +0100, Gerd Hoffmann wrote: > Hi, > > > Turns out it's this: > > > > commit 76e58028d28e78431f9de3cee0b3c88d807fa39d > > Author: Kevin O'Connor > > Date: Wed Mar 6 21:50:09 2013 -0500 > > > > acpi: Eliminate BDAT parameter passing to DSDT code. > > > >

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

2013-03-20 Thread Michael R. Hines
On 03/20/2013 11:20 AM, Paolo Bonzini wrote: Il 19/03/2013 19:40, Paolo Bonzini ha scritto: That however gives me an idea... Instead of the full drain at the end of an iteration, does it make sense to do a "partial" drain at every chunk full, so that you don't have > N bytes pending and the dow

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-20 Thread Michael R. Hines
On 03/20/2013 11:55 AM, Michael S. Tsirkin wrote: On Wed, Mar 20, 2013 at 11:15:48AM -0400, Michael R. Hines wrote: OK, can we make a deal? =) I'm willing to put in the work to perform the dynamic registration on the destination side, but let's go a step further and piggy-back on the effort:

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-20 Thread mdroth
On Wed, Mar 20, 2013 at 10:54:51AM -0400, Luiz Capitulino wrote: > > On Fri, 1 Mar 2013 11:40:27 -0600 > Michael Roth wrote: > > > Hosts hold on to handles provided by guest-file-open for periods that can > > span beyond the life of the qemu-ga process that issued them. Since these > > are issu

[Qemu-devel] Cortex-M4F Floating Point system registers

2013-03-20 Thread Fabien Chouteau
Hello QEMU ARM folks, I'm looking at the ARMv7-M profile and the implementation in QEMU. Looks like M3 is supported and I'd like to work on M4F (FP context save and lazy FP context save). I wonder how the FPU system registers, and more generally how the co-processor registers are implemented in Q

Re: [Qemu-devel] QOM-ify QemuConsoles ...

2013-03-20 Thread Gerd Hoffmann
Hi, > I think the first step is to figure out what the relationships are. I > was looking through the changes and vaguely, it appears that its: > > - Each UI has one or more DisplayChangeListeners Yes. > - Each DisplayChangeListener can be mapped to 1 or more QemuConsoles Each DisplayChan

  1   2   3   >