Re: [Qemu-devel] [PATCH 5/5] pseries: Move XICS initialization before cpu initialization

2013-03-15 Thread Alexander Graf
Am 16.03.2013 um 06:41 schrieb Benjamin Herrenschmidt : > On Sat, 2013-03-16 at 06:33 +0100, Alexander Graf wrote: We're changing that notion in the in-kernel XICS discussions. The >> flow will look like this: * create vcpus * create XICS * foreach (vcpu) * e

Re: [Qemu-devel] [PATCH 5/5] pseries: Move XICS initialization before cpu initialization

2013-03-15 Thread Benjamin Herrenschmidt
On Sat, 2013-03-16 at 06:33 +0100, Alexander Graf wrote: > >> We're changing that notion in the in-kernel XICS discussions. The > flow will look like this: > >> > >> * create vcpus > >> * create XICS > >> * foreach (vcpu) > >> * enable_cap(vcpu, CAP_XICS_SERVER, xics_handle) > > > > This

Re: [Qemu-devel] [PATCH 5/5] pseries: Move XICS initialization before cpu initialization

2013-03-15 Thread Alexander Graf
Am 16.03.2013 um 04:14 schrieb Benjamin Herrenschmidt : > On Fri, 2013-03-15 at 13:33 +0100, Alexander Graf wrote: >> On 14.03.2013, at 02:53, David Gibson wrote: >> >>> Currently, the pseries machine initializes the cpus, then the XICS >>> interrupt controller. However, to support the upcomi

Re: [Qemu-devel] [PATCH v8 13/24] hw/arm: add FTI2C010 I2C controller support

2013-03-15 Thread Peter Crosthwaite
On Fri, Mar 15, 2013 at 11:15 PM, Kuo-Jung Su wrote: > From: Kuo-Jung Su > > The FTI2C010 is a simple I2C master controller. > > Signed-off-by: Kuo-Jung Su > --- > hw/arm/Makefile.objs |1 + > hw/arm/faraday_a369_soc.c |6 ++ > hw/arm/fti2c010.c | 212 > ++

Re: [Qemu-devel] [PATCH v8 05/24] hw/arm: add FTDDRII030 DDRII controller support

2013-03-15 Thread Peter Crosthwaite
Hi Kuo-Jung, On Fri, Mar 15, 2013 at 11:13 PM, Kuo-Jung Su wrote: > From: Kuo-Jung Su > > The FTDDRII030 is a DDRII SDRAM controller which is responsible for > SDRAM initialization. > In QEMU we emulate only the SDRAM enable function. > > Signed-off-by: Kuo-Jung Su > --- > hw/arm/Makefile.objs

Re: [Qemu-devel] [PATCH 5/5] pseries: Move XICS initialization before cpu initialization

2013-03-15 Thread Benjamin Herrenschmidt
On Fri, 2013-03-15 at 13:33 +0100, Alexander Graf wrote: > On 14.03.2013, at 02:53, David Gibson wrote: > > > Currently, the pseries machine initializes the cpus, then the XICS > > interrupt controller. However, to support the upcoming in-kernel XICS > > implementation we will need to initialize

[Qemu-devel] [Bug 1155403] Re: virtio cdrom detected as hard disk

2013-03-15 Thread Serge Hallyn
I see, misunderstood. Reproduced with latest git://git.qemu.org/qemu.git as well, so marked as affecting upstream QEMU project. ** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH v2] Add option to mlock qemu and guest memory

2013-03-15 Thread Marcelo Tosatti
On Thu, Feb 14, 2013 at 08:21:51PM +, Satoru Moriya wrote: > We have some plans to migrate legacy enterprise systems which require > low latency (10 msec order) to kvm virtualized environment. In our > usecase, the system runs with other untrusted guests and so locking > memory which is used by

Re: [Qemu-devel] [PATCH v11 0/3] Xilinx Zynq PL330 support

2013-03-15 Thread Peter Crosthwaite
Hi Peter, On Sat, Mar 16, 2013 at 1:00 AM, Peter Maydell wrote: > On 27 February 2013 05:17, Peter Crosthwaite > wrote: >> These patches add support for the Primcell PL330 DMA controller and add it to >> the Xilinx Zynq machine model. Patch 2 is the device model. Patch 3 is the >> machine model

[Qemu-devel] [PATCH] net: increase buffer size to accommodate Jumbo frame pkts over netdev UDP socket

2013-03-15 Thread sfeldma
From: Scott Feldman Socket buffer sizes were hard-coded to 4K. Bump this up to 12K to handle typical MTU=9000 Jumbo frame pkt. Ran into this limitation when using -netdev UDP sockets to connect VM-to-VM, where VM interface is configure with MTU=9000. Using virtio_net NIC model. Test is simp

[Qemu-devel] large memory requirements for translate.c a barrier

2013-03-15 Thread Todd T. Fries
PID USERNAME PRI NICE SIZE RES STATE WAIT TIMECPU COMMAND 28818 todd 640 1142M 53M onproc/0 - 2:01 17.24% cc1 For systems with lower limits on user process memory, this prevents things from building. For systems with less physical ram, this presents lots of s

Re: [Qemu-devel] [PATCH] pvevent: pvevent device driver

2013-03-15 Thread Matthew Garrett
On Thu, 2013-03-14 at 16:51 +0800, Hu Tao wrote: > + { "MSFT0001", 0}, This seems wrong, and it looks like qemu agrees. Can you resubmit when there's agreement on the name? > + acpi_evaluate_object(handle, "WRPT", &arg_list, NULL); Is there a spec for this? Is the only reason for this

[Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer

2013-03-15 Thread Peter Lieven
Signed-off-by: Peter Lieven --- include/qemu-common.h |2 ++ util/cutils.c | 40 2 files changed, 42 insertions(+) diff --git a/include/qemu-common.h b/include/qemu-common.h index b59328f..51a7677 100644 --- a/include/qemu-common.h +++ b/inc

[Qemu-devel] [PATCHv2 0/9] buffer_is_zero / migration optimizations

2013-03-15 Thread Peter Lieven
this is v2 of my patch series with various optimizations in zero buffer checking and migration tweaks. hopefully properly threaded this time. thanks especially to Eric Blake and Paolo Bonzini for their comments. the patches can also be fetched from: git://github.com/plieven/qemu.git [branch migr

[Qemu-devel] [PATCHv2 3/9] buffer_is_zero: use vector optimizations if possible

2013-03-15 Thread Peter Lieven
performance gain on SSE2 is approx. 20-25%. altivec is not tested. performance for unsigned long arithmetic is unchanged. Signed-off-by: Peter Lieven --- util/cutils.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/util/cutils.c b/util/cutils.c index 857dd7d..00d98fb 100644 --- a/

[Qemu-devel] [PATCHv2 1/9] move vector definitions to qemu-common.h

2013-03-15 Thread Peter Lieven
vector optimizations will now be used at various places not just in is_dup_page() in arch_init.c this patch also adds a zero splat vector. Signed-off-by: Peter Lieven --- arch_init.c | 20 include/qemu-common.h | 24 2 files changed, 2

[Qemu-devel] [PATCHv2 6/9] migration: add an indicator for bulk state of ram migration

2013-03-15 Thread Peter Lieven
the first round of ram transfer is special since all pages are dirty and thus all memory pages are transferred to the target. this patch adds a boolean variable to track this stage. Signed-off-by: Peter Lieven --- arch_init.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch_init.c

[Qemu-devel] [PATCHv2 4/9] bitops: use vector algorithm to optimize find_next_bit()

2013-03-15 Thread Peter Lieven
this patch adds the usage of buffer_find_nonzero_offset() to skip large areas of zeroes. compared to loop unrolling presented in an earlier patch this adds another 50% performance benefit for skipping large areas of zeroes. loop unrolling alone added close to 100% speedup. Signed-off-by: Peter Li

[Qemu-devel] [PATCHv2 7/9] migration: do not sent zero pages in bulk stage

2013-03-15 Thread Peter Lieven
during bulk stage of ram migration if a page is a zero page do not send it at all. the memory at the destination reads as zero anyway. even if there is an madvise with QEMU_MADV_DONTNEED at the target upon receival of a zero page I have observed that the target starts swapping if the memory is ove

[Qemu-devel] [PATCHv2 5/9] migration: search for zero instead of dup pages

2013-03-15 Thread Peter Lieven
virtually all dup pages are zero pages. remove the speical is_dup_page() function and use the optimized buffer_is_zero() function instead. Signed-off-by: Peter Lieven --- arch_init.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/arch_init.c b/arch_init.c

[Qemu-devel] [PATCHv2 9/9] migration: use XBZRLE only after bulk stage

2013-03-15 Thread Peter Lieven
at the beginning of migration all pages are marked dirty and in the first round a bulk migration of all pages is performed. currently all these pages are copied to the page cache regardless if there are frequently updated or not. this doesn't make sense since most of these pages are never transfer

[Qemu-devel] [PATCHv2 8/9] migration: do not search dirty pages in bulk stage

2013-03-15 Thread Peter Lieven
avoid searching for dirty pages just increment the page offset. all pages are dirty anyway. Signed-off-by: Peter Lieven --- arch_init.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_init.c index a3dc20d..ca281ad 100644 --- a/arch_init.c +++

[Qemu-devel] Trouble with adding TCG branch instructions

2013-03-15 Thread Soumyadeep Ghosh
Hi, I am trying to modify the translate.c file for ARM target to add some extra operations for every add/subtract instruction in the target code. Following are the main modifications I need to make: 1. Added new registers to CPUArmState and added corresponding TCG registers (already done) 2. F

Re: [Qemu-devel] [PATCH] hw/arm/nseries: don't print to stdout or stderr

2013-03-15 Thread Andreas Färber
Am 15.03.2013 18:29, schrieb Peter Maydell: > Remove various bits of printing to stdout or stderr from the > nseries code, replacing it with a qemu log message where there's > an appropriate log category, and just dropping the output for > some of the more debug-like printing. > > In particular, t

[Qemu-devel] [PATCH v9 08/10] virtio-blk: cleanup: init and exit functions.

2013-03-15 Thread fred . konrad
From: KONRAD Frederic As all virtio-blk-* are switched to the new API, we can remove the separate init/exit for the old API. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-blk.c | 85 ++--- hw/virtio.h | 2 -- 2

[Qemu-devel] [PATCH v9 10/10] virtio-blk: cleanup: remove qdev field.

2013-03-15 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed, just drop it. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-blk.c | 3 +-- hw/virtio-blk.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 663edcd..

[Qemu-devel] [PATCH v9 06/10] virtio-blk-s390: switch to the new API.

2013-03-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-s390 is modified for the new API. The device virtio-blk-s390 extends virtio-s390-device as before. It creates and connects a virtio-blk during the init. The properties are not modified. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/

[Qemu-devel] [PATCH v9 05/10] virtio-blk-pci: switch to new API.

2013-03-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-pci is modified for the new API. The device virtio-blk-pci extends virtio-pci. It creates and connects a virtio-blk during the init. The properties are not changed. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-pci.c | 121 ++

[Qemu-devel] [PATCH v9 07/10] virtio-blk-ccw switch to new API.

2013-03-15 Thread fred . konrad
From: KONRAD Frederic Here the virtio-ccw-s390 is modified for the new API. The device virtio-ccw-s390 extends virtio-ccw-device as before. It creates and connects a virtio-ccw during the init. The properties are not modified. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/s

[Qemu-devel] [PATCH v9 04/10] virtio-blk: add the virtio-blk device.

2013-03-15 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-blk.c | 98 ++--- hw/virtio-blk.h | 21 + hw/virti

[Qemu-devel] [PATCH v9 03/10] virtio-blk: don't use pointer for configuration.

2013-03-15 Thread fred . konrad
From: KONRAD Frederic The configuration field must not be a pointer as it will be used for virtio-blk properties. So *blk is replaced by blk in VirtIOBlock structure. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-blk.c | 8 hw/virtio-blk.h | 2 +- 2 files ch

[Qemu-devel] [PATCH v9 09/10] virtio-blk: cleanup: QOM cast

2013-03-15 Thread fred . konrad
From: KONRAD Frederic Use QOM casts inside virtio-blk. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Maydell --- hw/virtio-blk.c | 33 ++--- hw/virtio-blk.h | 2 +- 2 files changed, 15 insertions(+), 20 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-bl

[Qemu-devel] [PATCH v9 01/10] virtio: make virtio device's structures public.

2013-03-15 Thread fred . konrad
From: KONRAD Frederic These structures must be made public to avoid two memory allocations for refactored virtio devices. Signed-off-by: KONRAD Frederic Reviewed-by: Andreas Färber Reviewed-by: Peter Maydell Changes V4 <- V3: * Rebased on current git. Changes V3 <- V2: * Style correc

[Qemu-devel] [PATCH v9 00/10] virtio-blk refactoring.

2013-03-15 Thread fred . konrad
From: KONRAD Frederic This is the next part of virtio-refactoring. Basically it creates virtio-blk device which extends virtio-device. Then a virtio-blk can be connected on a virtio-bus. virtio-blk-pci, virtio-blk-s390x, virtio-blk-ccw are created too, they extend respectively virtio-pci, virtio

[Qemu-devel] [PATCH v9 02/10] virtio-x-bus: fix allow_hotplug assertion.

2013-03-15 Thread fred . konrad
From: KONRAD Frederic This set allow_hotplug for each existing virtio-x-bus, allowing the refactored devices to be hot pluggable. Signed-off-by: KONRAD Frederic --- hw/s390x/s390-virtio-bus.c | 2 +- hw/s390x/virtio-ccw.c | 2 +- hw/virtio-pci.c| 2 +- 3 files changed, 3 inser

Re: [Qemu-devel] [PATCH 2/2] qga schema: document generic QERR_UNSUPPORTED

2013-03-15 Thread mdroth
On Fri, Mar 15, 2013 at 07:07:51PM +0100, Laszlo Ersek wrote: > Part of the wording was shamelessly stolen from Michael Roth's email. :) series: Reviewed-by: Michael Roth > > Suggested-by: Michael Roth > Signed-off-by: Laszlo Ersek > --- > qga/qapi-schema.json | 11 +++ > 1 files

Re: [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable

2013-03-15 Thread Laszlo Ersek
On 03/15/13 18:55, Kevin Wolf wrote: > However this won't be the last time that I have to deal with an Error > object, so I thought I'd check what is good practice. Seems no such > thing has established yet, which is an answer, even though not the one I > was hoping for. What I've gathered from d

[Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.

2013-03-15 Thread Frediano Ziglio
Modern notebook support 136x768 resolution. The resolution width is not multiple of 16 causing some problems. Qemu VGA emulation require width resolution to be multiple of 8. VNC implementation require width resolution to be multiple of 16. This patch remove these limits. Was tested with a Windo

Re: [Qemu-devel] [PATCH 0/2] documentation fixups for the qga schema

2013-03-15 Thread Eric Blake
On 03/15/2013 12:07 PM, Laszlo Ersek wrote: > Laszlo Ersek (2): > qga schema: mark optional GuestLogicalProcessor.can-offline with > #optional > qga schema: document generic QERR_UNSUPPORTED > > qga/qapi-schema.json | 18 +++--- > 1 files changed, 15 insertions(+), 3 deletio

[Qemu-devel] [PATCH 1/2] qga schema: mark optional GuestLogicalProcessor.can-offline with #optional

2013-03-15 Thread Laszlo Ersek
Suggested-by: Eric Blake Signed-off-by: Laszlo Ersek --- qga/qapi-schema.json |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index dac4e6f..2af3515 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -562,9 +

[Qemu-devel] [PATCH 15/17] xilinx_spips: Fix bus setup conditional check

2013-03-15 Thread Peter Maydell
From: Nathan Rossi The R_LQPSI_CFG register has the LQSPI_CFG_SEP_BUS and LQSPI_CFG_TWO_MEM bits. Signed-off-by: Nathan Rossi Signed-off-by: Peter Crosthwaite Message-id: d76c8e364c80a42352ae4f0661aff2cd17ad32a4.1362373359.git.peter.crosthwa...@xilinx.com Signed-off-by: Peter Maydell --- hw

[Qemu-devel] [PATCH 2/2] qga schema: document generic QERR_UNSUPPORTED

2013-03-15 Thread Laszlo Ersek
Part of the wording was shamelessly stolen from Michael Roth's email. Suggested-by: Michael Roth Signed-off-by: Laszlo Ersek --- qga/qapi-schema.json | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 2af3515..71

[Qemu-devel] [PATCH 0/2] documentation fixups for the qga schema

2013-03-15 Thread Laszlo Ersek
Laszlo Ersek (2): qga schema: mark optional GuestLogicalProcessor.can-offline with #optional qga schema: document generic QERR_UNSUPPORTED qga/qapi-schema.json | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH] target-mips: fix rndrashift_short_acc and code for EXTR_ instructions

2013-03-15 Thread Petar Jovanovic
From: Petar Jovanovic Fix for rndrashift_short_acc to set correct value to higher 64 bits. This change also corrects conditions when bit 23 of the DSPControl register is set. The existing test files have been extended with several examples that trigger the issues. One bug/example in the test fil

Re: [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable

2013-03-15 Thread Kevin Wolf
Am 15.03.2013 um 17:55 hat Laszlo Ersek geschrieben: > On 03/15/13 09:37, Kevin Wolf wrote: > > Am 14.03.2013 um 16:52 hat Laszlo Ersek geschrieben: > >> On 03/14/13 15:57, Kevin Wolf wrote: > >>> Signed-off-by: Kevin Wolf > >>> --- > >>> After rebasing this I saw that Anthony already committed a

Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-15 Thread Eric Blake
On 03/15/2013 11:17 AM, Corey Bryant wrote: > Signed-off-by: Corey Bryant > --- > qemu-options.hx | 3 ++- > qmp-commands.hx | 59 > + > 2 files changed, 61 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake eblake re

Re: [Qemu-devel] [PATCH build-breaker] qga/main.c: Don't use g_key_file_get/set_int64

2013-03-15 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH 03/17] hw/arm_sysctl: Implement SYS_CFG_MUXFPGA writes as a no-op

2013-03-15 Thread Peter Maydell
SYS_CFG_MUXFPGA allows the guest to select whether the video output should come from the motherboard's LCD controller or the daughterboard's one. Since QEMU doesn't currently support selecting the video output like this, implement as a no-op, so Linux doesn't complain about the register not being i

Re: [Qemu-devel] [PATCH 08/28] qcow2: Allow lazy refcounts to be enabled on the command line

2013-03-15 Thread Anthony Liguori
Paolo Bonzini writes: > Il 15/03/2013 16:14, Stefan Hajnoczi ha scritto: >> From: Kevin Wolf >> >> qcow2 images now accept a boolean lazy_refcounts options. Use it like >> this: >> >> -drive file=test.qcow2,lazy_refcounts=on >> >> If the option is specified on the command line, it overrides

Re: [Qemu-devel] [PATCH] pseries: Fix breakage in CPU QOM conversion

2013-03-15 Thread Andreas Färber
Am 15.03.2013 04:59, schrieb David Gibson: > Commit 259186a7d2f7184efc96ae99bc5658e6159f53ad "cpu: Move halted and > interrupt_request fields to CPUState" broke the pseries machine. That's > because it uses CPU() instead of ENV_GET_CPU() to convert from the global > first_cpu pointer (still a CPUA

[Qemu-devel] [PATCH] hw/arm/nseries: don't print to stdout or stderr

2013-03-15 Thread Peter Maydell
Remove various bits of printing to stdout or stderr from the nseries code, replacing it with a qemu log message where there's an appropriate log category, and just dropping the output for some of the more debug-like printing. In particular, this will get rid of the 'mipid_reset' message you curren

[Qemu-devel] [PATCH 09/17] hw/arm_sysctl: Implement SYS_CFG_OSC function

2013-03-15 Thread Peter Maydell
Implement the SYS_CFG_OSC function. Since the idea of programmable clock rates doesn't make much sense for QEMU, we simply allow the clock rate to be read back as written. The number and value of the daughterboard oscillators varies between daughterboards, so we provide an array property to allow t

Re: [Qemu-devel] [PATCH] s390: Fix cpu refactoring fallout.

2013-03-15 Thread Andreas Färber
Am 15.03.2013 10:57, schrieb Cornelia Huck: > Commit 259186a7 "cpu: Move halted and interrupt_request fields to CPUState" > seems to have missed one instance in target-s390x/kvm.c: > > /home/cohuck/git/qemu/target-s390x/kvm.c: In function > ‘kvm_arch_process_async_events’: > /home/cohuck/git/qemu

Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage

2013-03-15 Thread Igor Mitsyanko
> On 03/15/2013 09:12 PM, Peter Maydell wrote: > >> On 10 March 2013 13:47, Igor Mitsyanko wrote: >> >>> hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for >>> dynamically >>> allocated buffer migration, this was causing memory corruption. >>> Use VMSTATE_BUFFER_POINTER_UNSAFE (

Re: [Qemu-devel] [PATCH v2] Add option to mlock qemu and guest memory

2013-03-15 Thread Satoru Moriya
Ping. Can anyone else review this patch? Regards, Satoru On 03/12/2013 05:40 AM, Paolo Bonzini wrote: > Il 14/02/2013 21:21, Satoru Moriya ha scritto: >> We have some plans to migrate legacy enterprise systems which require >> low latency (10 msec order) to kvm virtualized environment. In our

[Qemu-devel] [PATCH 06/17] qdev: Implement (variable length) array properties

2013-03-15 Thread Peter Maydell
Add support for declaring array properties for qdev devices. These work by defining an initial static property 'len-arrayname' which the user of the device should set to the desired size of the array. When this property is set, memory is allocated for the array elements, and dynamic properties "arr

[Qemu-devel] [PATCH 16/17] xilinx_spips: Add missing dual-bus snoop commands

2013-03-15 Thread Peter Maydell
From: Nathan Rossi Added additional commands to the switch to check for when snooping commands in dual bus mode setups. Cleaned up code to use an enum. Signed-off-by: Nathan Rossi Signed-off-by: Peter Crosthwaite Message-id: 848c116c711dab0af10729a487968384aadd9faf.1362373359.git.peter.crosth

[Qemu-devel] [PATCH 01/17] hw/vexpress: Pass proc_id via VEDBoardInfo

2013-03-15 Thread Peter Maydell
Pass the daughterboard-specific proc_id property to the code that creates the sysctl device via the VEDBoardInfo struct, rather than by having the daughterboard init function write to a uint32_t* argument. This is a cleaner way to pass the info around, and is in line with the way we are going to ha

[Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-15 Thread Corey Bryant
Signed-off-by: Corey Bryant --- qemu-options.hx | 3 ++- qmp-commands.hx | 59 + 2 files changed, 61 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 30fb85d..3b3cd0f 100644 --- a/qemu-options.hx +++ b/qem

[Qemu-devel] [PATCH 12/17] pl330: Initial version

2013-03-15 Thread Peter Maydell
From: Peter Crosthwaite Device model for Primecell PL330 DMA controller. Signed-off-by: Peter Crosthwaite Signed-off-by: Kirill Batuzov Tested-by: Igor Mitsyanko Reviewed-by: Igor Mitsyanko Reviewed-by: Peter Maydell Message-id: 098aac26233d7334bed2bca4f06f539638ca6d24.1361853677.git.peter

[Qemu-devel] [PATCH 04/17] hw/arm_sysctl: Implement SYS_CFG_DVIMODE as a no-op

2013-03-15 Thread Peter Maydell
SYS_CFG_DVIMODE allows the guest to select whether the output DVI signal is VGA, SVGA, XGA, SGA or UXGA. Since this makes no difference to QEMU, implement writes as a no-op so Linux doesn't complain. Signed-off-by: Peter Maydell --- hw/arm_sysctl.c |8 1 file changed, 8 insertions(+

[Qemu-devel] [PATCH 10/17] hw/vexpress: Set reset values for daughterboard oscillators

2013-03-15 Thread Peter Maydell
Set the reset values for the VExpress daughterboard oscillators via the new sysctl properties. Signed-off-by: Peter Maydell --- hw/arm/vexpress.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c index a2dc759..2e1a5d0 1

[Qemu-devel] [PATCH 13/17] xilinx_zynq: added pl330 to machine model

2013-03-15 Thread Peter Maydell
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Message-id: 5bc295bd2aa50dfe573f428574dbd7d8add7b3f8.1361853677.git.peter.crosthwa...@xilinx.com Signed-off-by: Peter Maydell --- hw/arm/xilinx_zynq.c | 24 1 file changed, 24 inser

[Qemu-devel] [PATCH 08/17] hw/vexpress: Pass voltage sensor properties to sysctl device

2013-03-15 Thread Peter Maydell
Pass voltage sensor properties to the sysctl device. Since these are daughterboard specific, we specify them via the VEDBoardInfo structure. Signed-off-by: Peter Maydell Message-id: 1359985476-29380-9-git-send-email-peter.mayd...@linaro.org --- hw/arm/vexpress.c | 30 ++

[Qemu-devel] [PATCH 05/17] hw/arm_sysctl: Convert from qdev init to instance_init

2013-03-15 Thread Peter Maydell
Convert this device from old-style qdev init to an instance_init function. We don't need a realize function yet, though. Signed-off-by: Peter Maydell --- hw/arm_sysctl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c index

[Qemu-devel] [PATCH 02/17] hw/arm_sysctl: Handle SYS_CFGCTRL in a more structured way

2013-03-15 Thread Peter Maydell
The SYS_CFGCTRL register consists of separate fields for DCC, function, site, position and device, as well as a read/write bit. Refactor the code handling SYS_CFGCTRL writes to make it easier to add support for functions like SYS_CFG_OSC which support multiple device fields. We also pull the handli

[Qemu-devel] [PATCH 07/17] hw/arm_sysctl: Implement SYS_CFG_VOLT

2013-03-15 Thread Peter Maydell
Implement the SYS_CFG_VOLT registers which return the voltage of various supplies on motherboard and daughterboard. Since QEMU implements a perfectly stable power supply these registers always return a constant value. The number and value of the daughterboard voltages is dependent on the specific d

[Qemu-devel] [PULL 00/17] arm-devs queue

2013-03-15 Thread Peter Maydell
Another arm-devs pullreq: xilinx fixes from Peter C, the pl330 model, and my vexpress fixes for the system control regs. Please pull. thanks -- PMM The following changes since commit dc0b0616f726956001be09e9a65a6e0b0bd939db: Merge remote-tracking branch 'stefanha/block' into staging (2013-03-

[Qemu-devel] [PATCH 17/17] xilinx_spips: QOM styling fixes

2013-03-15 Thread Peter Maydell
From: Peter Crosthwaite Few fixes for the latest QOM styling guides. Signed-off-by: Peter Crosthwaite Message-id: de9daeee6c142e8b57ad042fd680cedcdc94d2fc.1362373359.git.peter.crosthwa...@xilinx.com Signed-off-by: Peter Maydell --- hw/xilinx_spips.c | 29 - 1 fi

Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage

2013-03-15 Thread Peter Maydell
On 10 March 2013 13:47, Igor Mitsyanko wrote: > hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for > dynamically > allocated buffer migration, this was causing memory corruption. > Use VMSTATE_BUFFER_POINTER_UNSAFE (wich has an additional VMS_POINTER flag > set) instead. > > N

[Qemu-devel] [PATCH 11/17] iov: Factor out hexdumper

2013-03-15 Thread Peter Maydell
From: Peter Crosthwaite Factor out the hexdumper functionality from iov for all to use. Useful for creating verbose debug printfery that dumps packet data. Signed-off-by: Peter Crosthwaite Message-id: faaac219c55ea586d3f748befaf5a2788fd271b8.1361853677.git.peter.crosthwa...@xilinx.com Signed-o

[Qemu-devel] [PATCH 14/17] xilinx_spips: Set unused IRQs to NULL

2013-03-15 Thread Peter Maydell
From: Peter Crosthwaite Unused CS lines should init to 0 to avoid segfaulting when accessing an unattached QSPI controller. Signed-off-by: Peter Crosthwaite Message-id: c1e45198032106e69e8fe9339fc2e6348d524fcd.1362373359.git.peter.crosthwa...@xilinx.com Signed-off-by: Peter Maydell --- hw/xi

Re: [Qemu-devel] [PATCH 08/28] qcow2: Allow lazy refcounts to be enabled on the command line

2013-03-15 Thread Paolo Bonzini
Il 15/03/2013 16:14, Stefan Hajnoczi ha scritto: > From: Kevin Wolf > > qcow2 images now accept a boolean lazy_refcounts options. Use it like > this: > > -drive file=test.qcow2,lazy_refcounts=on > > If the option is specified on the command line, it overrides the default > specified by the qc

Re: [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable

2013-03-15 Thread Laszlo Ersek
On 03/15/13 09:37, Kevin Wolf wrote: > Am 14.03.2013 um 16:52 hat Laszlo Ersek geschrieben: >> On 03/14/13 15:57, Kevin Wolf wrote: >>> Signed-off-by: Kevin Wolf >>> --- >>> After rebasing this I saw that Anthony already committed a fix that is >>> very close to my v1. I don't intend to actually c

Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory

2013-03-15 Thread Paolo Bonzini
Il 15/03/2013 17:09, Peter Maydell ha scritto: > On 15 March 2013 16:00, Paolo Bonzini wrote: >> Il 15/03/2013 15:34, Peter Maydell ha scritto: >>> I rather suspect sysbus_add_io and sysbus_del_io should also be >>> removed, but since their users are in PPC and x86 platforms I'll >>> let somebody

Re: [Qemu-devel] [PATCH 11/20] qemu-char: use a glib timeout instead of qemu-timer

2013-03-15 Thread Laurent Desnogues
On Fri, Mar 15, 2013 at 4:44 PM, Anthony Liguori wrote: > Laurent Desnogues writes: > >> Hello, >> >> On Tue, Mar 5, 2013 at 6:51 PM, Amit Shah wrote: >>> From: Anthony Liguori >>> >>> Signed-off-by: Anthony Liguori >>> Signed-off-by: Amit Shah >>> --- >>> qemu-char.c | 68 >>> +

Re: [Qemu-devel] [RFC] qmp interface for save vmstate to image

2013-03-15 Thread Stefan Hajnoczi
On Fri, Mar 15, 2013 at 03:24:38PM +0800, Wenchao Xia wrote: > I'd like to add a new way to save vmstate, which will based on the > migration thread, but will write contents to block images, instead > of fd as stream. Following is the method to add API: Hi Wenchao, What use cases are there besid

[Qemu-devel] [Bug 1155677] [NEW] snapshot=on fails with non file-based storage

2013-03-15 Thread Richard Jones
Public bug reported: The snapshot=on option doesn't work with an nbd block device: /usr/bin/qemu-system-x86_64 \ [...] -device virtio-scsi-pci,id=scsi \ -drive file=nbd:localhost:61930,snapshot=on,format=raw,id=hd0,if=none \ -device scsi-hd,drive=hd0 \ [...] gives the error: qemu-sy

Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory

2013-03-15 Thread Peter Maydell
On 15 March 2013 16:00, Paolo Bonzini wrote: > Il 15/03/2013 15:34, Peter Maydell ha scritto: >> I rather suspect sysbus_add_io and sysbus_del_io should also be >> removed, but since their users are in PPC and x86 platforms I'll >> let somebody else do that part :-) > > sysbus_add_io and sysbus_de

[Qemu-devel] [PATCH 02/28] block: Add options QDict to bdrv_open() prototype

2013-03-15 Thread Stefan Hajnoczi
From: Kevin Wolf It doesn't do anything yet except storing the options QDict in the BlockDriverState. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi --- block.c | 47 +++-

[Qemu-devel] [PATCH 06/28] blockdev: Keep a copy of DriveInfo.serial

2013-03-15 Thread Stefan Hajnoczi
From: Kevin Wolf Pointing to a QemuOpts element is surprising and can lead to subtle use-after-free errors when the QemuOpts is freed after all options are parsed. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- blockdev.c| 5 - include/sysemu/blockdev.h | 2 +

[Qemu-devel] [PATCH 18/28] main-loop: add qemu_get_aio_context()

2013-03-15 Thread Stefan Hajnoczi
It is very useful to get the main loop AioContext, which is a static variable in main-loop.c. I'm not sure whether qemu_get_aio_context() will be necessary in the future once devices focus on using their own AioContext instead of the main loop AioContext, but for now it allows us to refactor code

Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory

2013-03-15 Thread Paolo Bonzini
Il 15/03/2013 15:34, Peter Maydell ha scritto: > I rather suspect sysbus_add_io and sysbus_del_io should also be > removed, but since their users are in PPC and x86 platforms I'll > let somebody else do that part :-) sysbus_add_io and sysbus_del_io are actually a good match for the I/O address spa

[Qemu-devel] [PATCH 14/28] qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount()

2013-03-15 Thread Stefan Hajnoczi
We already flush when the function completes. There is no need to flush after every compressed cluster. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 4 1 file changed, 4 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c ind

[Qemu-devel] [RFC V7 22/32] qcow2: Add qcow2_dedup_is_running to probe if dedup is running.

2013-03-15 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2-dedup.c |6 ++ block/qcow2.h |1 + 2 files changed, 7 insertions(+) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 68a09ff..cd47e2c 100644 --- a/block/qcow2-dedup.c +++ b/block/qcow2-dedup.c @@ -1070,3 +1070,9 @@ void qc

[Qemu-devel] [RFC V7 15/32] qcow2: Load and save deduplication table header extension.

2013-03-15 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2.c | 49 + 1 file changed, 49 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index ca38cc3..eaddcb6 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -53,9 +53,18 @@ typedef struct { uint3

Re: [Qemu-devel] [PATCH V27 1/7] Support for TPM command line options

2013-03-15 Thread Corey Bryant
On 03/15/2013 03:36 AM, Markus Armbruster wrote: I missed this one, because it wasn't cc'ed to QMP maintainers, the subject mentions only command line, not QMP, and even the body talks only about the human monitor command, not QMP. Noticed it only when git-pull touched qapi-schema.json. Pleas

[Qemu-devel] [PATCH 26/28] qemu-iotests: add tests for rebasing zero clusters

2013-03-15 Thread Stefan Hajnoczi
From: Paolo Bonzini If zero clusters are erroneously treated as unallocated, "qemu-img rebase" will copy the backing file's contents onto the cluster. The bug existed also in image streaming, but since the root cause was in qcow2's is_allocated implementation it is enough to test it with qemu-im

Re: [Qemu-devel] [PULL 00/28] Block patches

2013-03-15 Thread Anthony Liguori
Stefan Hajnoczi writes: > The last block pull request from March 12 broke the virtio-blk serial property > and was not applied. > > This pull request includes the patches from March 12, Kevin's fixed "[PATCH v2 > 0/8] block: Add driver specific options", and patches from this week that I > have

Re: [Qemu-devel] [PATCH] hw/vexpress: set default block type to SD

2013-03-15 Thread Peter Maydell
On 15 March 2013 15:42, Aurelien Jarno wrote: > On Fri, Mar 15, 2013 at 03:35:48PM +, Peter Maydell wrote: >> I'm not convinced this is a good thing -- I think you should have >> to know that you're attaching an SD card and not a hard disk, >> because the performance is much worse. In particul

Re: [Qemu-devel] [PATCH 11/20] qemu-char: use a glib timeout instead of qemu-timer

2013-03-15 Thread Anthony Liguori
Laurent Desnogues writes: > Hello, > > On Tue, Mar 5, 2013 at 6:51 PM, Amit Shah wrote: >> From: Anthony Liguori >> >> Signed-off-by: Anthony Liguori >> Signed-off-by: Amit Shah >> --- >> qemu-char.c | 68 >> - >> 1 file changed, 4

Re: [Qemu-devel] [PATCH] hw/vexpress: set default block type to SD

2013-03-15 Thread Aurelien Jarno
On Fri, Mar 15, 2013 at 03:35:48PM +, Peter Maydell wrote: > On 5 March 2013 00:44, Aurelien Jarno wrote: > > On Tue, Mar 05, 2013 at 08:22:57AM +0800, Peter Maydell wrote: > >> What effect does this actually have on the user experience? > > > > The effect is that the user don't has to specify

Re: [Qemu-devel] [PATCH] hw/vexpress: set default block type to SD

2013-03-15 Thread Peter Maydell
On 5 March 2013 00:44, Aurelien Jarno wrote: > On Tue, Mar 05, 2013 at 08:22:57AM +0800, Peter Maydell wrote: >> What effect does this actually have on the user experience? > > The effect is that the user don't has to specify the interface type. > Basically: > > -drive file=/path/to/file,if=sd >

[Qemu-devel] [PATCH 15/28] qcow2: make is_allocated return true for zero clusters

2013-03-15 Thread Stefan Hajnoczi
From: Paolo Bonzini Otherwise, live migration of the top layer will miss zero clusters and let the backing file show through. This also matches what is done in qed. QCOW2_CLUSTER_ZERO clusters are invalid in v2 image files. Check this directly in qcow2_get_cluster_offset instead of replicating

Re: [Qemu-devel] [PATCH v2 5/5] xilinx_spips: seperate SPI and QSPI as two classes

2013-03-15 Thread Peter Maydell
On 4 March 2013 05:04, Peter Crosthwaite wrote: > Make SPI and QSPI different classes. QSPIPS is setup as a child of SPIPS. > Only QSPI has the LQSPI functionality, so move all that to the child class. > > Signed-off-by: Peter Crosthwaite > +typedef struct { > +XilinxSPIPS parent; The QOM co

[Qemu-devel] [PATCH 27/28] qemu-iotests: use -nographic in test case 007

2013-03-15 Thread Stefan Hajnoczi
A comment explains that -nographic hangs test case 007. This is no longer the case so add -nographic. This makes the test suite faster and more pleasant to run since no windows pop up. I am not sure exactly when -nographic starting working for this case but there is no fundamental reason why gra

[Qemu-devel] [PATCH 28/28] blockdev: Fix up copyright and permission notice

2013-03-15 Thread Stefan Hajnoczi
From: Markus Armbruster Screwed up in commit 666daa68. Thanks to Kevin Wolf for reminding me to fix this. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- blockdev.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/blockdev.c b/blockdev.c index

[Qemu-devel] [PATCH 05/28] qemu-option: Add qemu_opts_absorb_qdict()

2013-03-15 Thread Stefan Hajnoczi
From: Kevin Wolf This adds a function that adds all entries of a QDict to a QemuOpts if the keys are known, and leaves only the rest in the QDict. This way a single QDict of -drive options can be processed in multiple places (generic block layer, block driver, backing file block driver, etc.), w

[Qemu-devel] [PATCH 21/28] aio: add a ThreadPool instance to AioContext

2013-03-15 Thread Stefan Hajnoczi
This patch adds a ThreadPool to AioContext. It's possible that some AioContext instances will never use the ThreadPool, so defer creation until aio_get_thread_pool(). The reason why AioContext should have the ThreadPool is because the ThreadPool is bound to a AioContext instance where the work it

[Qemu-devel] [PATCH 22/28] block: add bdrv_get_aio_context()

2013-03-15 Thread Stefan Hajnoczi
For now bdrv_get_aio_context() is just a stub that calls qemu_aio_get_context() since the block layer is currently tied to the main loop AioContext. Add the stub now so that the block layer can begin accessing its AioContext. Signed-off-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini --- block.

  1   2   3   >