[Qemu-devel] [Bug 1127053] Re: assertion failed in exec.c while attempting to start a guest (latest commit)

2013-03-10 Thread Milos Ivanovic
I'm surprised nobody has commented on this. It's definitely a bug - at least on my distribution (Gentoo Linux). Here is a gdb backtrace with debugging symbols included: eclipse ~ # gdb qemu-system-x86_64 GNU gdb (Gentoo 7.5.1 p2) 7.5.1 Copyright (C) 2012 Free Software Foundation, Inc. License GPLv

Re: [Qemu-devel] Cross-compiling QEMU for ARM

2013-03-10 Thread Peter Crosthwaite
Hi Peter, On Mon, Mar 11, 2013 at 1:04 AM, Peter Maydell wrote: > On 10 March 2013 14:36, Leonid Bloch wrote: >> I am using Buildroot as my toolchain, and the farthest I got was: >> $ ./configure --cpu=armv7hl --static --cc=arm-linux-cc >> $ make >> ...And then I get a lot of errors about libint

Re: [Qemu-devel] Cross-compiling QEMU for ARM

2013-03-10 Thread Peter Crosthwaite
Hi Peter, On Mon, Mar 11, 2013 at 12:59 AM, Peter Maydell wrote: > Question for the qemu-devel folks: does anybody have a situation > where they genuinely need to pass --cpu to configure (ie the > autodetection is wrong or insufficient)? [configure does mention > one case, which is when cross-com

Re: [Qemu-devel] [PATCH V8 00/20] qmp/hmp interfaces for internal snapshot info

2013-03-10 Thread Wenchao Xia
于 2013-3-7 15:36, Markus Armbruster 写道: > I intend to review at least the QMP interfaces. Unfortunately, I'm > struggling with getting my review queue under control. Please be > patient. > Thanks for your attention. I am coding for next version to address Eric's comments, please ignore this ve

Re: [Qemu-devel] [PULL 00/46] migration queue

2013-03-10 Thread Anthony Liguori
Juan Quintela writes: > Hi, Anthony > > please pull the migraiton queue, it includes: > - paolo cleanup & remove buffering series (already reviewed upstream) > - v2 of XBZRLE fixes from Orit After waiting for 10 minutes for repo.or.cz to respond, I gave up. I try again later but repo.or.cz has

Re: [Qemu-devel] [PULL 00/18] hw/ reorganization, part 1

2013-03-10 Thread Anthony Liguori
Paolo Bonzini writes: > Il 05/03/2013 18:17, Paolo Bonzini ha scritto: >> This includes the mechanical changes, as well as moving stuff >> out of hw/. Boards and devices referencing CPU are moved to >> per-arch subdirectories. This part was uncontroversial, and >> I have already posted it separ

[Qemu-devel] propose to implement power device

2013-03-10 Thread li guang
Hi, all By now all devices of QEMU do not have much more power management consideration, for example, if system do suspend, it will call all registered notifiers, this was loosely required, and the code to do power management state transition seems just do 'ugly emulation', rather than be consciou

Re: [Qemu-devel] propose to implement ower device

2013-03-10 Thread li guang
在 2013-03-07四的 21:41 +0800,Wenchao Xia写道: > 于 2013-3-7 11:40, li guang 写道: > > Hi, Anthony and all > > > > By now all devices of QEMU do not have much more > > power management consideration, for example, if > > system do suspend, it will call all registered notifiers, > > this was loosely required

Re: [Qemu-devel] [PULL] chardev: qapi conversion continued

2013-03-10 Thread Anthony Liguori
Hi, This no longer merges cleanly after the charflow series. I don't think it should be too bad to rebase. If you have any problems, let me know. Regards, Anthony Liguori Gerd Hoffmann writes: > Hi, > > This pull adds support for the missing chardev types and finally > re-enabling the hmp

Re: [Qemu-devel] [PATCH 1/2] baum: fix build

2013-03-10 Thread Stefan Weil
Am 09.03.2013 10:56, schrieb Blue Swirl: 08744c98115cfa144ed3493556024e400b2e2573 removed hw/baum.h but did not adjust hw/baum.c, breaking build. Fix. Signed-off-by: Blue Swirl --- hw/baum.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/baum.c b/hw/baum.c index d

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Sun, Mar 10, 2013 at 12:15:11PM -0600, Alex Williamson wrote: > On Sun, 2013-03-10 at 12:13 -0600, Alex Williamson wrote: > > On Sun, 2013-03-10 at 18:16 +0200, Michael S. Tsirkin wrote: > > > On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > > > > Rather than have everyone call

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Sun, Mar 10, 2013 at 12:13:27PM -0600, Alex Williamson wrote: > On Sun, 2013-03-10 at 18:16 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > > > Rather than have everyone call pci_bridge_map_irq() themselves and > > > come up with incorrect

Re: [Qemu-devel] [PER] Re: socket, mcast looping back frames -> IPv6 broken

2013-03-10 Thread Samuel Thibault
Stefan Hajnoczi, le Wed 06 Mar 2013 13:29:37 +0100, a écrit : > > What do people think about it? > > We should fix the layer that introduces the problem. Therefore I think > the fix needs to be net/socket.c. > > Unfortunately net/socket.c does not have the concept of a link-layer > address, so w

Re: [Qemu-devel] Compile error on FC17

2013-03-10 Thread Peter Maydell
On 10 March 2013 19:36, Gerhard Wiesinger wrote: > On 10.03.2013 18:04, Peter Maydell wrote: >> This is an example of a longstanding problem we have, where the >> makefile's dependency rules aren't able to cope with changes to the project >> source file structure, and so clean, distclean and incre

Re: [Qemu-devel] Compile error on FC17

2013-03-10 Thread Gerhard Wiesinger
On 10.03.2013 18:04, Peter Maydell wrote: Oh, right. Tracing functions moved from trace.h to the files in the trace/ subdirectory. This means that if you didn't do a make clean or distclean before doing the git update then the new makefile knows nothing about the old trace.h file and so won't d

Re: [Qemu-devel] Compile error on FC17

2013-03-10 Thread Laszlo Ersek
On 03/10/13 18:04, Peter Maydell wrote: > On 10 March 2013 15:15, Gerhard Wiesinger wrote: >> Tried make clean and make distclean already before I reported the issue. >> >> If I'm suppressing "warning as errors" I'm still getting errors: >> >> hw/usb/hcd-xhci.c: In function ‘xhci_set_ep_dequeue’:

Re: [Qemu-devel] [PATCH 3/3] memory_region_init_ram_ptr: only allow n*TARGET_PAGE_SIZE memory sizes

2013-03-10 Thread Igor Mitsyanko
On 10.03.2013 18:27, Peter Maydell wrote: On 10 March 2013 22:21, Igor Mitsyanko wrote: Registering memory regions using preallocated memory which size is not a multiple of target page size will result in inconsistency in QEMU memory system. Do not allow to do that at all by checking for that

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Alex Williamson
On Sun, 2013-03-10 at 12:13 -0600, Alex Williamson wrote: > On Sun, 2013-03-10 at 18:16 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > > > Rather than have everyone call pci_bridge_map_irq() themselves and > > > come up with incorrect mapping

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Alex Williamson
On Sun, 2013-03-10 at 18:16 +0200, Michael S. Tsirkin wrote: > On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > > Rather than have everyone call pci_bridge_map_irq() themselves and > > come up with incorrect mapping functions let's use the default PCI > > defined swizzle function

Re: [Qemu-devel] Cross-compiling QEMU for ARM

2013-03-10 Thread Peter Maydell
On 10 March 2013 16:28, Leonid Bloch wrote: > Tried that at first, but then getting an error: > Error: pkg-config binary 'arm-linux-pkg-config' not found This means you need to fix your cross compile set up. It should have a cross-version of pkg-config, which should be named 'arm-linux-pkg-config

Re: [Qemu-devel] Compile error on FC17

2013-03-10 Thread Peter Maydell
On 10 March 2013 15:15, Gerhard Wiesinger wrote: > Tried make clean and make distclean already before I reported the issue. > > If I'm suppressing "warning as errors" I'm still getting errors: > > hw/usb/hcd-xhci.c: In function ‘xhci_set_ep_dequeue’: > hw/usb/hcd-xhci.c:1471:5: error: too many arg

Re: [Qemu-devel] Cross-compiling QEMU for ARM

2013-03-10 Thread Leonid Bloch
On Sun, Mar 10, 2013 at 4:59 PM, Peter Maydell wrote: > On 10 March 2013 14:36, Leonid Bloch wrote: >> I want to cross compile QEMU itself to run on ARM, but all my searches >> lead me to tutorials for cross compiling other programs for ARM and >> testing them with QEMU, which is not what I need.

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > Rather than have everyone call pci_bridge_map_irq() themselves and > come up with incorrect mapping functions let's use the default PCI > defined swizzle function unless told otherwise. Then we can also > clean out the duplicate fu

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > Rather than have everyone call pci_bridge_map_irq() themselves and > come up with incorrect mapping functions let's use the default PCI > defined swizzle function unless told otherwise. Then we can also > clean out the duplicate fu

Re: [Qemu-devel] Cross-compiling QEMU for ARM

2013-03-10 Thread Blue Swirl
On Sun, Mar 10, 2013 at 2:59 PM, Peter Maydell wrote: > On 10 March 2013 14:36, Leonid Bloch wrote: >> I want to cross compile QEMU itself to run on ARM, but all my searches >> lead me to tutorials for cross compiling other programs for ARM and >> testing them with QEMU, which is not what I need.

Re: [Qemu-devel] [PATCH uq/master 2/2] kvm: forward INIT signals coming from the chipset

2013-03-10 Thread Gleb Natapov
On Sun, Mar 10, 2013 at 04:04:39PM +0100, Paolo Bonzini wrote: > Il 10/03/2013 15:55, Gleb Natapov ha scritto: > > > > Why not move INIT case from below as is? Vcpu is reset to correct sate > > > > by QEMU just like during system_reset. > > > > > > APs would not be able to receive SIPIs after exec

Re: [Qemu-devel] Compile error on FC17

2013-03-10 Thread Gerhard Wiesinger
On 10.03.2013 14:20, Peter Maydell wrote: On 10 March 2013 20:28, Gerhard Wiesinger wrote: Hello, qemu is currently not compile clean: CC util/hbitmap.o util/hbitmap.c: In function ‘hbitmap_iter_skip_words’: util/hbitmap.c:138:5: error: implicit declaration of function ‘trace_hbitmap_iter_skip

Re: [Qemu-devel] Cross-compiling QEMU for ARM

2013-03-10 Thread Peter Maydell
On 10 March 2013 14:36, Leonid Bloch wrote: > I am using Buildroot as my toolchain, and the farthest I got was: > $ ./configure --cpu=armv7hl --static --cc=arm-linux-cc > $ make > ...And then I get a lot of errors about libintl and libiconv. Oh, and I forgot -- don't try to build system emulators

Re: [Qemu-devel] [PATCH uq/master 2/2] kvm: forward INIT signals coming from the chipset

2013-03-10 Thread Paolo Bonzini
Il 10/03/2013 15:55, Gleb Natapov ha scritto: > > > Why not move INIT case from below as is? Vcpu is reset to correct sate > > > by QEMU just like during system_reset. > > > > APs would not be able to receive SIPIs after executing do_cpu_init, > > because they would stay in KVM_MP_STATE_RUNNABLE s

Re: [Qemu-devel] Cross-compiling QEMU for ARM

2013-03-10 Thread Peter Maydell
On 10 March 2013 14:36, Leonid Bloch wrote: > I want to cross compile QEMU itself to run on ARM, but all my searches > lead me to tutorials for cross compiling other programs for ARM and > testing them with QEMU, which is not what I need. > The only relevant link I found was this: > http://lists.g

Re: [Qemu-devel] [PATCH uq/master 2/2] kvm: forward INIT signals coming from the chipset

2013-03-10 Thread Gleb Natapov
On Sun, Mar 10, 2013 at 03:28:06PM +0100, Paolo Bonzini wrote: > Il 10/03/2013 12:54, Gleb Natapov ha scritto: > > On Sat, Mar 09, 2013 at 07:48:50AM +0100, Paolo Bonzini wrote: > >> CPU_INTERRUPT_INIT can also be generated if you have an internal APIC, > >> since the keyboard controller and the so

[Qemu-devel] Cross-compiling QEMU for ARM

2013-03-10 Thread Leonid Bloch
Hello, I want to cross compile QEMU itself to run on ARM, but all my searches lead me to tutorials for cross compiling other programs for ARM and testing them with QEMU, which is not what I need. The only relevant link I found was this: http://lists.gnu.org/archive/html/qemu-devel/2011-05/msg00099

[Qemu-devel] [Bug 583296] Re: I/O errors with qemu-nbd/qcow2

2013-03-10 Thread Paolo Bonzini
qemu-nbd has been rewritten since 0.12.3. Closing. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/583296 Title: I/O errors with qemu-nbd/qcow

[Qemu-devel] [PATCH v10 0/4] Moxie CPU port

2013-03-10 Thread Anthony Green
This version of the patch includes a bug fix and some formatting fixes identified by Blue Swirl here: http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg01530.html Please consider applying this version of the patch series. Thanks! AG Anthony Green (4): Add moxie target code Add moxie

Re: [Qemu-devel] [PATCH uq/master 2/2] kvm: forward INIT signals coming from the chipset

2013-03-10 Thread Paolo Bonzini
Il 10/03/2013 12:54, Gleb Natapov ha scritto: > On Sat, Mar 09, 2013 at 07:48:50AM +0100, Paolo Bonzini wrote: >> CPU_INTERRUPT_INIT can also be generated if you have an internal APIC, >> since the keyboard controller and the southbridge can also pulse the >> CPU's INIT# pin. >> >> Exit the VCPU is

Re: [Qemu-devel] [PATCH 3/3] memory_region_init_ram_ptr: only allow n*TARGET_PAGE_SIZE memory sizes

2013-03-10 Thread Peter Maydell
On 10 March 2013 22:21, Igor Mitsyanko wrote: > Registering memory regions using preallocated memory which size is not a > multiple of > target page size will result in inconsistency in QEMU memory system. Do not > allow to do that at all by checking for that case (and asserting) in > memory_regi

[Qemu-devel] [PATCH 3/3] memory_region_init_ram_ptr: only allow n*TARGET_PAGE_SIZE memory sizes

2013-03-10 Thread Igor Mitsyanko
Registering memory regions using preallocated memory which size is not a multiple of target page size will result in inconsistency in QEMU memory system. Do not allow to do that at all by checking for that case (and asserting) in memory_region_init_ram_ptr(). Signed-off-by: Igor Mitsyanko --- i

[Qemu-devel] [PATCH 2/3] exynos4210.c: register chipid_mem and rom_mem with vmstate

2013-03-10 Thread Igor Mitsyanko
Even if we do not register newly created RAM MemoryRegion for migration with vmstate_register_ram_global() function, ram_save_setup() still saves this region to snapshot file with empty idstr=="". Consequently this results in error during VM loading in ram_load(). Register chipid_mem and rom_mem fo

[Qemu-devel] [PATCH 1/3] hw/exynos4210.c: set chipid_and_omr array size to TARGET_PAGE_SIZE

2013-03-10 Thread Igor Mitsyanko
During initialization, memory region size is aligned to page size, but size of chipid_and_omr array is less then TARGET_PAGE_SIZE. This could result in errors in some cases, specifically, it could cause errors during VM migration. Signed-off-by: Igor Mitsyanko --- hw/exynos4210.c |2 +- 1

[Qemu-devel] [PATCH 0/3] Fix memory migration for exynos 4210 SoC

2013-03-10 Thread Igor Mitsyanko
First two patches fix issues in exynos4210 code which were blocking proper memory migration. Third patch makes memory_region_init_ram_ptr assert if memory region size is not a multiple of TARGET_PAGE_SIZE. Igor Mitsyanko (3): hw/exynos4210.c: set chipid_and_omr array size to TARGET_PAGE_SIZE

[Qemu-devel] [PATCH v10 1/4] Add moxie target code

2013-03-10 Thread Anthony Green
Signed-off-by: Anthony Green --- target-moxie/Makefile.objs | 2 + target-moxie/cpu.c | 172 + target-moxie/cpu.h | 169 + target-moxie/helper.c | 171 + target-moxie/helper.h | 9 + target-moxie/machine.c | 28 ++ target-moxie/machine.h

[Qemu-devel] [PATCH v10 4/4] Add top level changes for moxie

2013-03-10 Thread Anthony Green
Signed-off-by: Anthony Green --- MAINTAINERS | 5 + arch_init.c | 2 ++ configure | 9 - cpu-exec.c| 2 ++ default-configs/moxie-softmmu.mak | 2 ++ qapi-schema.json | 6 +++--

[Qemu-devel] [PATCH v10 3/4] Add sample moxie system

2013-03-10 Thread Anthony Green
Signed-off-by: Anthony Green --- hw/moxie/Makefile.objs | 6 ++ hw/moxie/moxiesim.c| 174 + include/sysemu/arch_init.h | 1 + 3 files changed, 181 insertions(+) create mode 100644 hw/moxie/Makefile.objs create mode 100644 hw/moxie/mox

[Qemu-devel] [PATCH v10 2/4] Add moxie disassembler

2013-03-10 Thread Anthony Green
Signed-off-by: Anthony Green --- disas.c | 6 + disas/Makefile.objs | 1 + disas/moxie.c | 360 include/disas/bfd.h | 2 + 4 files changed, 369 insertions(+) create mode 100644 disas/moxie.c diff --git a/disas.c b/dis

[Qemu-devel] [PATCH] qemu-char.c: fix waiting for telnet connection message

2013-03-10 Thread Igor Mitsyanko
Current colon position in "waiting for telnet connection" message template produces messages like: QEMU waiting for connection on: telnet::127.0.0.1,server After moving a colon to the right, we will get a correct messages like: QEMU waiting for connection on: telnet:127.0.0.1:,server Sign

Re: [Qemu-devel] [PATCH 2/2] qemu-char: fix win32 build

2013-03-10 Thread Igor Mitsyanko
On 09.03.2013 13:56, Blue Swirl wrote: 96c6384776d631839a9c8fe02bf135f9ba22586c did not adjust Win32 #ifdeffery properly, breaking build in later commits. Fix. Signed-off-by: Blue Swirl --- qemu-char.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/qemu-char.c

[Qemu-devel] [PATCH 3/3] hw/onenand.c: fix migration of dynamically allocated buffer "otp"

2013-03-10 Thread Igor Mitsyanko
VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, not for buffers allocated dynamically. Change to VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right. Signed-off-by: Igor Mitsyanko --- hw/onenand.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[Qemu-devel] [PATCH 2/3] hw/sd.c: fix migration of dynamically allocated buffer "buf"

2013-03-10 Thread Igor Mitsyanko
VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, not for buffers allocated dynamically. Change to VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right. Signed-off-by: Igor Mitsyanko --- hw/sd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) d

[Qemu-devel] [PATCH 1/3] vmstate.h: introduce VMSTATE_BUFFER_POINTER_UNSAFE macro

2013-03-10 Thread Igor Mitsyanko
Macro could be used to migrate a dynamically allocated buffer of known size. Signed-off-by: Igor Mitsyanko --- include/migration/vmstate.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index f27276c..e12

[Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage

2013-03-10 Thread Igor Mitsyanko
hw/sd.c and hw/onenand.c were wrongly using VMSTATE_BUFFER_UNSAFE for dynamically allocated buffer migration, this was causing memory corruption. Use VMSTATE_BUFFER_POINTER_UNSAFE (wich has an additional VMS_POINTER flag set) instead. Not sure what to do with vmstate version for his devices, sh

Re: [Qemu-devel] Compile error on FC17

2013-03-10 Thread Peter Maydell
On 10 March 2013 20:28, Gerhard Wiesinger wrote: > Hello, > > qemu is currently not compile clean: > CC util/hbitmap.o > util/hbitmap.c: In function ‘hbitmap_iter_skip_words’: > util/hbitmap.c:138:5: error: implicit declaration of function > ‘trace_hbitmap_iter_skip_words’ [-Werror=implicit-functi

[Qemu-devel] Compile error on FC17

2013-03-10 Thread Gerhard Wiesinger
Hello, qemu is currently not compile clean: CC util/hbitmap.o util/hbitmap.c: In function ‘hbitmap_iter_skip_words’: util/hbitmap.c:138:5: error: implicit declaration of function ‘trace_hbitmap_iter_skip_words’ [-Werror=implicit-function-declaration] util/hbitmap.c:138:5: error: nested extern de

Re: [Qemu-devel] [PATCH uq/master 2/2] kvm: forward INIT signals coming from the chipset

2013-03-10 Thread Gleb Natapov
On Sat, Mar 09, 2013 at 07:48:50AM +0100, Paolo Bonzini wrote: > CPU_INTERRUPT_INIT can also be generated if you have an internal APIC, > since the keyboard controller and the southbridge can also pulse the > CPU's INIT# pin. > > Exit the VCPU is one is received, and process it by changing the > m

Re: [Qemu-devel] QEMU -netdev vhost=on + -device virtio-net-pci bug

2013-03-10 Thread Alexey Kardashevskiy
On 10/03/13 20:24, Michael S. Tsirkin wrote: On Fri, Mar 08, 2013 at 03:48:04PM +1100, Alexey Kardashevskiy wrote: Michael, Thanks for the fix. There was another question which was lost in the thread. I am testing virtio-net in two ways: Old -net interface: -net tap,ifname=tap0,script=qemu-i

Re: [Qemu-devel] [RFC 3/8] backup: write to BlockDriverState instead of BackupDumpFunc

2013-03-10 Thread Stefan Hajnoczi
On Sun, Mar 10, 2013 at 11:05 AM, Dietmar Maurer wrote: >> Remove the BackupDumpFunc function pointer and write directly to a >> BlockDriverState. > > My callback approach is the generic one. You can easily implement the > BlockDriverState approach using the BackupDumpFunc? Yes it can be implemen

Re: [Qemu-devel] [PATCH v4 3/6] add backup related monitor commands

2013-03-10 Thread Stefan Hajnoczi
On Sun, Mar 10, 2013 at 10:32 AM, Dietmar Maurer wrote: >> >> What I am looking for is a stripped down patch series with just a >> >> backup block job (no backup archive writer or migration code). That >> >> would be easily merged and saves you front rebasing this series as QEMU >> changes. >> >

Re: [Qemu-devel] [RFC 0/8] block: Live backup prototype

2013-03-10 Thread Stefan Hajnoczi
On Sun, Mar 10, 2013 at 11:50 AM, Dietmar Maurer wrote: >> About 4KB zero tracking: >> >> The vma.py module does not check for zeros, the mask is always 0x. >> There is a pathalogical case of a disk with every 2nd 4 KB block zeroed, >> here >> vma.py would create a fully-allocated file.But t

Re: [Qemu-devel] [RFC 0/8] block: Live backup prototype

2013-03-10 Thread Dietmar Maurer
> About 4KB zero tracking: > > The vma.py module does not check for zeros, the mask is always 0x. > There is a pathalogical case of a disk with every 2nd 4 KB block zeroed, here > vma.py would create a fully-allocated file.But the more common case is that > the > whole 64 KB cluster is zero

Re: [Qemu-devel] [RFC 0/8] block: Live backup prototype

2013-03-10 Thread Stefan Hajnoczi
On Sun, Mar 10, 2013 at 10:57 AM, Dietmar Maurer wrote: >> The difference between this approach and Dietmar's series is that the backup >> archive format is implemented outside QEMU and runs as a separate program. >> >> This way, management tools like proxmox, oVirt, OpenStack, and others can >> p

Re: [Qemu-devel] [RFC 0/8] block: Live backup prototype

2013-03-10 Thread Dietmar Maurer
> > I can see the advantage to move the code out of qemu, but I want to > > avoid that overhead by all means. So are there any other ideas to avoid the > overhead of a socket based IPC? > > There are enough avenues to investigate better performance that I think the > solution is to just profile an

Re: [Qemu-devel] [RFC 0/8] block: Live backup prototype

2013-03-10 Thread Stefan Hajnoczi
On Sun, Mar 10, 2013 at 10:14 AM, Dietmar Maurer wrote: >> The objection to this approach has been performance. Exporting vmstate and >> disk data over UNIX domain sockets to an external process incurs IPC >> overhead. >> This prototype shows that even Python code hacked up in a day achieves dec

Re: [Qemu-devel] [RFC 3/8] backup: write to BlockDriverState instead of BackupDumpFunc

2013-03-10 Thread Dietmar Maurer
> Remove the BackupDumpFunc function pointer and write directly to a > BlockDriverState. My callback approach is the generic one. You can easily implement the BlockDriverState approach using the BackupDumpFunc?

Re: [Qemu-devel] [RFC 0/8] block: Live backup prototype

2013-03-10 Thread Dietmar Maurer
> The difference between this approach and Dietmar's series is that the backup > archive format is implemented outside QEMU and runs as a separate program. > > This way, management tools like proxmox, oVirt, OpenStack, and others can > provide their preferred backup archive formats without modifyi

Re: [Qemu-devel] [PATCH v4 3/6] add backup related monitor commands

2013-03-10 Thread Dietmar Maurer
> >> What I am looking for is a stripped down patch series with just a > >> backup block job (no backup archive writer or migration code). That > >> would be easily merged and saves you front rebasing this series as QEMU > changes. > > > > That is Patch 2/6? > > Yes. I sent an RFC series that sh

Re: [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-10 Thread Michael S. Tsirkin
On Fri, Mar 08, 2013 at 08:58:43AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > libvirt has a long-standing bug: when removing the device, > >> > it can reque

Re: [Qemu-devel] QEMU -netdev vhost=on + -device virtio-net-pci bug

2013-03-10 Thread Michael S. Tsirkin
On Fri, Mar 08, 2013 at 03:48:04PM +1100, Alexey Kardashevskiy wrote: > Michael, > > Thanks for the fix. > > There was another question which was lost in the thread. > > I am testing virtio-net in two ways: > > Old -net interface: > -net tap,ifname=tap0,script=qemu-ifup.sh \ > -net nic,model=vi

Re: [Qemu-devel] [RFC 0/8] block: Live backup prototype

2013-03-10 Thread Dietmar Maurer
> The objection to this approach has been performance. Exporting vmstate and > disk data over UNIX domain sockets to an external process incurs IPC overhead. > This prototype shows that even Python code hacked up in a day achieves decent > performance. > > I'm leaving benchmarking as an exercise

Re: [Qemu-devel] [PATCH 1/2] Add GDB qAttached support

2013-03-10 Thread Jan Kiszka
On 2013-03-05 17:03, Fabien Chouteau wrote: > With this patch GDB will issue a "detach" command at the end of a > debugging session instead of a "kill". This behavior can be inverted > with the new option -gdb-not-attached. > > This patch implements the requirement described in Jan Kiszka's patch: