Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity

2013-02-20 Thread Roy Tam
2013/2/21 Paolo Bonzini : > Il 21/02/2013 01:35, Roy Tam ha scritto: >>> > QEMU system emulation has been thread-safe for a long time, and >>> > setting the CPU affinity is hurting performance badly. Remove >>> > the bogus code. >>> > >>> > Jacob Kroon reports that the time to boot his VxWorks ima

[Qemu-devel] [Bug 1130533] Re: Documentation cannot be build since commit c70a01e449536c616c85ab820c6fbad7d7e9cf39

2013-02-20 Thread FredBezies
Could be also a bug related to texinfo 5.0 upgrade, indeed ! Anyway, besides removing this patch, which are the options ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1130533 Title: Documentation

Re: [Qemu-devel] [PATCH 26/41] migration: detect error before sleeping

2013-02-20 Thread Orit Wasserman
On 02/15/2013 07:46 PM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > migration.c |7 --- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/migration.c b/migration.c > index 5e2077e..63ecab5 100644 > --- a/migration.c > +++ b/migration.c > @@ -644,6 +644,1

Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity

2013-02-20 Thread Paolo Bonzini
Il 21/02/2013 01:35, Roy Tam ha scritto: >> > QEMU system emulation has been thread-safe for a long time, and >> > setting the CPU affinity is hurting performance badly. Remove >> > the bogus code. >> > >> > Jacob Kroon reports that the time to boot his VxWorks image goes from >> > "3 minutes pass

Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration

2013-02-20 Thread Paolo Bonzini
Il 21/02/2013 00:34, David Woodhouse ha scritto: > On Thu, 2013-02-21 at 00:31 +0100, Andreas Färber wrote: >> >> >> Reviewed-by: Andreas Färber >> >> A minor suggestion since you seem to be preparing a v2 would be to do >> I440FX_PCI_DEVICE(ds), but I don't see dev becoming unused anytime >> soon

Re: [Qemu-devel] [PATCH 1/4] configure: Add --enable-migration-from-qemu-kvm

2013-02-20 Thread Paolo Bonzini
Il 20/02/2013 22:03, Anthony Liguori ha scritto: > Paolo Bonzini writes: > >> Il 20/02/2013 21:26, Anthony Liguori ha scritto: >>> Cole Robinson writes: >>> This switch will turn on all the migration compat bits needed to perform migration from qemu-kvm to qemu. It's just a stub for no

Re: [Qemu-devel] [PATCH 31/41] qemu-file: check exit status when closing a pipe QEMUFile

2013-02-20 Thread Orit Wasserman
On 02/15/2013 07:47 PM, Paolo Bonzini wrote: > This is what exec_close does. Move this to the underlying QEMUFile. > > Signed-off-by: Paolo Bonzini > --- > migration-exec.c |4 > savevm.c |3 +++ > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/migration

Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver

2013-02-20 Thread Paolo Bonzini
Il 21/02/2013 07:33, Dietmar Maurer ha scritto: >> This should call bdrv_is_allocated_above like the other block jobs do. >> It would be needed later anyway to backup only the topmost image. > > I do not need that information now, so why do you want that I add dead code? I think you do. You're w

Re: [Qemu-devel] [PATCH 25/41] migration: eliminate last_round

2013-02-20 Thread Orit Wasserman
On 02/15/2013 07:46 PM, Paolo Bonzini wrote: > We will go around the loop exactly once after setting last_round. > Eliminate the variable altogether. > > Signed-off-by: Paolo Bonzini > --- > migration.c | 11 +-- > 1 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/migr

Re: [Qemu-devel] [PATCH 29/41] migration: merge qemu_popen_cmd with qemu_popen

2013-02-20 Thread Orit Wasserman
On 02/15/2013 07:47 PM, Paolo Bonzini wrote: > There is no reason for outgoing exec migration to do popen manually > anymore (the reason used to be that we needed the FILE* to make it > non-blocking). Use qemu_popen_cmd. > > Signed-off-by: Paolo Bonzini > --- > include/migration/qemu-file.h |

Re: [Qemu-devel] [PATCH 28/41] migration: use qemu_file_rate_limit consistently

2013-02-20 Thread Orit Wasserman
On 02/15/2013 07:47 PM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > migration.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/migration.c b/migration.c > index 3de7cbf..8d35af5 100644 > --- a/migration.c > +++ b/migration.c > @@ -616,7 +616,7 @@

Re: [Qemu-devel] [PATCH 27/41] migration: remove useless qemu_file_get_error check

2013-02-20 Thread Orit Wasserman
On 02/15/2013 07:46 PM, Paolo Bonzini wrote: > migration_put_buffer is never called if there has been an error. > > Signed-off-by: Paolo Bonzini > --- > migration.c |6 -- > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/migration.c b/migration.c > index 63ecab5..3de7

Re: [Qemu-devel] unknown keycodes

2013-02-20 Thread Markus Armbruster
Matt Brennan writes: > Hi - I am running on an OS X 10.8.2 (Mountain Lion) laptop, with XQuartz > installed, using SSH -X in to a ubuntu machine where qemu is attempting to > run Raspberry Pi. > > $ qemu-system-arm -kernel kernel-qemu -cpu arm1176 -m 512 -M versatilepb > -no-reboot -serial stdio

Re: [Qemu-devel] [Bug 1130769] [NEW] VirtFS (virtio-9p-pci) error: Parameter 'driver' expects device type

2013-02-20 Thread Markus Armbruster
Tim Comer writes: > Public bug reported: > > Getting error "Parameter 'driver' expects device type" when trying to > share a file system with a guest. Full error message, please. Should look like qemu-system-x86_64: -device foo: Parameter 'driver' expects device type > Command line: > qem

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom size to 8192

2013-02-20 Thread Gerd Hoffmann
Hi, >> I took a stab at this, unfortunately the situation isn't that simple. qxl >> rom_size is actually dependent on the spice version we build against: >> >> stock qemu 1.2 built on F17 against spice-0.10.1: >> sizeof(QXLRom)=72 rom_size=8192 >> >> stock qemu 1.2 built on F18 against spice-0.1

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-20 Thread Dietmar Maurer
> Interesting series, the backup block job makes sense to me. Regarding > efficiency, I think incremental backup is a must, One can easily implement incremental backup on top of this patches. That is why I introduced the BackupDriver abstraction. > otherwise regular backups using > this approac

Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver

2013-02-20 Thread Dietmar Maurer
> This should call bdrv_is_allocated_above like the other block jobs do. > It would be needed later anyway to backup only the topmost image. I do not need that information now, so why do you want that I add dead code?

Re: [Qemu-devel] [PATCH v4 5/6] add regression tests for backup

2013-02-20 Thread Dietmar Maurer
> > Note: the call to g_thread_init() solves problems with g_slice_alloc() - > > without > that call we get arbitrary crashes. > > This should be a comment in the code. GLib needs to be running in > multithreaded mode in order for the GSlice allocator to be thread-safe. > This is why you see cra

Re: [Qemu-devel] [PATCH 2/2] qemu-timer: move timeBeginPeriod/timeEndPeriod to os-win32

2013-02-20 Thread Stefan Weil
Am 21.02.2013 00:49, schrieb Jacob Kroon: > On Wed, Feb 20, 2013 at 9:46 PM, Jacob Kroon wrote: >> Paolo, >> >> Just a heads up, I tried the patched qemu (1+2+3) on my laptop at >> home, which is running Windows 7 64-bit. I'm seeing qemu "lockups" >> appearing randomly.. Will try to debug it. >> O

Re: [Qemu-devel] [PATCH v4 3/6] add backup related monitor commands

2013-02-20 Thread Dietmar Maurer
> > Another option would be to simply dump > > to the output fh (pipe), and an > > external binary saves the data. That way we could move the whole archive > format related code out of qemu. > > That sounds like the NBD option - write the backup to an NBD disk image. > The NBD server process can

[Qemu-devel] [PATCH v2 00/15] Debug output revamp

2013-02-20 Thread Andreas Färber
Hello, Based on suggestions from Igor Mitsyanko, Anthony and Alex this series aims to expose debug output to compile-testing, so that it doesn't constantly break. The basic requirement is to move format strings and arguments out of #ifdef sections or no-op macros, so that the C compiler sees and c

[Qemu-devel] [PATCH v2 07/15] target-cris: Refactor debug output macros

2013-02-20 Thread Andreas Färber
Make debug output compile-testable even if disabled. Introduce DPRINTF() in helper.c and consolidate stdout and stderr output. Introduce DPRINTF() in mmu.c and inline remaining D(x). Drop unused D(x) macros in op_helper.c and translate.c. Signed-off-by: Andreas Färber --- target-cris/helper.c

[Qemu-devel] [PATCH v2 06/15] target-alpha: Refactor debug output macros

2013-02-20 Thread Andreas Färber
Make LOG_DISAS() arguments compile-testable even if disabled. Signed-off-by: Andreas Färber --- target-alpha/translate.c | 14 -- 1 Datei geändert, 12 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index f687b95..32fe05

[Qemu-devel] [PATCH v2 08/15] target-i386: Refactor debug output macros

2013-02-20 Thread Andreas Färber
Make debug output compile-testable even if disabled. Signed-off-by: Andreas Färber Cc: Richard Henderson --- target-i386/helper.c | 42 ++ target-i386/kvm.c| 16 target-i386/seg_helper.c | 24 +++- 3

Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver

2013-02-20 Thread Dietmar Maurer
> > +bit = cluster_num % BITS_PER_LONG; > > +val = job->bitmap[idx]; > > +if (dirty) { > > +if (!(val & (1UL << bit))) { > > +val |= 1UL << bit; > > +} > > +} else { > > +if (val & (1UL << bit)) { > > +val &= ~(1UL << bit); > > +

Re: [Qemu-devel] [PATCH RESEND for 1.4-stable] net: reduce memory allocation when multiqueue is not used

2013-02-20 Thread Jason Wang
On 02/20/2013 09:01 PM, Stefan Hajnoczi wrote: > On Wed, Feb 20, 2013 at 06:11:33PM +0800, Jason Wang wrote: >> Edivaldo reports a problem that the array of NetClientState in NICState is >> too >> large - MAX_QUEUE_NUM(1024) which will waste memory even if multiqueue is not >> used. >> >> For 1.4

[Qemu-devel] [PATCH v2 13/15] target-s390x: Refactor debug output macros

2013-02-20 Thread Andreas Färber
Make debug output compile-testable even if disabled. Rename dprintf() in kvm.c to kvm_dprintf() due to a conflict with glibc. Drop unused DEBUG_HELPER and LOG_HELPER() in fpu_helper.c. Drop unused LOG_DISAS() in translate.c and inline S390X_DEBUG_DISAS. Signed-off-by: Andreas Färber --- target

[Qemu-devel] [PATCH v2 14/15] target-sparc: Refactor debug output macros

2013-02-20 Thread Andreas Färber
Make debug output compile-testable even if disabled. Inline DEBUG_FEATURES and introduce features_printf() in cpu.c. Inline DEBUG_MMU in ldst_helper.c but leave DPRINTF_MMU() as is due to "MMU: " prefix. Inline DEBUG_{MXCC,ASI} in ldst_helper.c. Signed-off-by: Andreas Färber --- target-sparc/cp

[Qemu-devel] [PATCH v2 09/15] target-lm32: Refactor debug output macros

2013-02-20 Thread Andreas Färber
Already enabled and thus compile-tested, but align with other targets. Signed-off-by: Andreas Färber --- target-lm32/translate.c | 14 -- 1 Datei geändert, 12 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index 6b87340..

[Qemu-devel] [PATCH v2 10/15] target-microblaze: Refactor debug output macros

2013-02-20 Thread Andreas Färber
Make debug output compile-testable even if disabled. Drop unused D(x) macros. Signed-off-by: Andreas Färber --- target-microblaze/helper.c| 48 +++-- target-microblaze/mmu.c | 38 ++-- target-microblaze/op_helper.c |

Re: [Qemu-devel] [PATCH v4 1/6] add documenation for new backup framework

2013-02-20 Thread Dietmar Maurer
> Thanks for writing this up. I don't think docs/backup.txt should be committed > as-is though because it refers to you proposing this patch series. Once > merged > some of this document will no longer be relevant. Why will it be no longer relevant? It explain the basic idea. > You could incl

[Qemu-devel] [PATCH v2 03/15] qemu-log: Introduce qemu_log_mask_vprintf()

2013-02-20 Thread Andreas Färber
Corresponds to existing qemu_log_vprintf() but uses a mask. Signed-off-by: Andreas Färber --- include/qemu/log.h | 16 1 Datei geändert, 16 Zeilen hinzugefügt(+) diff --git a/include/qemu/log.h b/include/qemu/log.h index 5a46555..9dd7a3e 100644 --- a/include/qemu/log.h +++ b/

[Qemu-devel] [PATCH v2 12/15] target-ppc: Refactor debug output macros

2013-02-20 Thread Andreas Färber
Make debug output compile-testable even if disabled. Rename dprintf() in kvm.c to kvm_dprintf() to avoid conflict with glibc. Inline DEBUG_OP check in excp_helper.c. Inline LOG_MMU_STATE() in mmu_helper.c. Inline PPC_{DEBUG_SPR,DUMP_SPR_ACCESSES} checks in translate_init.c. Signed-off-by: Andrea

Re: [Qemu-devel] [RESEND PATCH v2 2/2] seabios q35: Add new PCI slot to irq routing function

2013-02-20 Thread Alex Williamson
On Wed, 2013-02-20 at 23:29 -0500, Kevin O'Connor wrote: > On Fri, Feb 15, 2013 at 02:11:41PM -0700, Alex Williamson wrote: > > q35/ich9 doesn't use the same interrupt mapping function as > > i440fx/piix. PIRQA:D and PIRQE:H are programmed identically, but we > > start at index 0, not index -1. S

Re: [Qemu-devel] [RFC PATCH v1 3/4] xilinx_axienet: Create Proxy object for stream

2013-02-20 Thread Andreas Färber
Am 21.02.2013 05:17, schrieb Peter Crosthwaite: > Ping! > > Edgar merged patches 1&2 (trivials) before he went on vacation, but > left this out because he wanted to give everyone a chance to review in > the context of the active QOM discussions. I probably should have ccd > Paolo as this little su

[Qemu-devel] [PATCH v2 11/15] target-openrisc: Refactor debug output macros

2013-02-20 Thread Andreas Färber
Debug output is already enabled and thus compile-testable, but align with other targets. Signed-off-by: Andreas Färber --- target-openrisc/translate.c | 14 -- 1 Datei geändert, 12 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/target-openrisc/translate.c b/target-openri

Re: [Qemu-devel] [RESEND PATCH v2 2/2] seabios q35: Add new PCI slot to irq routing function

2013-02-20 Thread Kevin O'Connor
On Fri, Feb 15, 2013 at 02:11:41PM -0700, Alex Williamson wrote: > q35/ich9 doesn't use the same interrupt mapping function as > i440fx/piix. PIRQA:D and PIRQE:H are programmed identically, but we > start at index 0, not index -1. Slots 25 through 31 are also > programmed independently. > > When

[Qemu-devel] [PATCH v2 01/15] target-ppc: Fix PPC_DUMP_SPR_ACCESS build

2013-02-20 Thread Andreas Färber
A victim of the d523dd00a7d73b28f2e99acf45a4b3f92e56e40a AREG0 conversion, insert the missing cpu_env arguments. Cc: Blue Swirl Signed-off-by: Andreas Färber --- target-ppc/translate_init.c |4 ++-- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/target-ppc/tra

[Qemu-devel] [PATCH v2 15/15] target-unicore32: Refactor debug output macros

2013-02-20 Thread Andreas Färber
Make debug output compile-testable even if disabled. Signed-off-by: Andreas Färber --- target-unicore32/helper.c | 18 -- target-unicore32/softmmu.c | 17 +++-- 2 Dateien geändert, 31 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/target-unicore32/help

[Qemu-devel] [PATCH v2 05/15] target-cris/mmu.c: Update Coding Style of cris_mmu_translate_page()

2013-02-20 Thread Andreas Färber
Reindent, add braces, adjust whitespace. Prepares for touching the logging macros. Signed-off-by: Andreas Färber --- target-cris/mmu.c | 312 +++-- 1 Datei geändert, 160 Zeilen hinzugefügt(+), 152 Zeilen entfernt(-) diff --git a/target-cris/mmu.

[Qemu-devel] [PATCH v2 02/15] target-ppc: Move PPC_DUMP_CPU to translate.c

2013-02-20 Thread Andreas Färber
There's an opcode handler field dependent on PPC_DUMP_CPU without which the build fails. Signed-off-by: Andreas Färber --- target-ppc/translate.c |1 + target-ppc/translate_init.c |1 - 2 Dateien geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-ppc/translat

[Qemu-devel] [PATCH v2 04/15] target-cris/helper.c: Update Coding Style

2013-02-20 Thread Andreas Färber
Reindent, add missing braces and drop/adjust whitespace. Prepares for CPUArchState-to-CPUState field movements in cpu_cris_handle_mmu_fault(), do_interruptv10() and do_interrupt(). The remaining functions were so minor that they can be fixed in one go. Acked-by: Edgar E. Iglesias Signed-off-by:

Re: [Qemu-devel] [RESEND PATCH v2 1/2] seabios q35: Enable all PIRQn IRQs at startup

2013-02-20 Thread Kevin O'Connor
On Fri, Feb 15, 2013 at 02:11:35PM -0700, Alex Williamson wrote: > We seem to use the IRQEN bit of the PIRQn registers interchangeably > to select APIC mode or to disable an IRQ. I can't decide if we're > intending to disable the IRQ or select APIC mode here, but in either > case it prevents PIC m

Re: [Qemu-devel] [RFC PATCH v1 3/4] xilinx_axienet: Create Proxy object for stream

2013-02-20 Thread Peter Crosthwaite
Ping! Edgar merged patches 1&2 (trivials) before he went on vacation, but left this out because he wanted to give everyone a chance to review in the context of the active QOM discussions. I probably should have ccd Paolo as this little sub system started way back with his refactoring of axienet to

Re: [Qemu-devel] [PATCH v1 0/5] Zynq GEM updates

2013-02-20 Thread Peter Crosthwaite
Ping! These should all be low controversy. CC Stefan in case hes interested in keeping tabs on net devices. Regards, Peter On Fri, Feb 15, 2013 at 2:51 PM, Peter Crosthwaite wrote: > Misc fixes and cleanups to the Zynq GEM device model. Patch 1 fixes a flow > control issue talking to the netwo

[Qemu-devel] [0/3] Use ONE_REG interface to synchronize more state with KVM

2013-02-20 Thread David Gibson
At the moment, there is a significant amount of state which both qemu and KVM track, which is not synchronized between the two. In a KVM setup, qemu never updates that information, so we mostly get away with it, but we'll need this data in qemu to implement savevm and migration. This series impro

[Qemu-devel] [PATCH] Add some missing qtest binaries to .gitignore

2013-02-20 Thread David Gibson
These binaries are generated during make check on at least some configurations, so att them to .gitignore. Signed-off-by: David Gibson --- tests/.gitignore |7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/.gitignore b/tests/.gitignore index 38c94ef..fb05c2a 100644 --- a/tests/

[Qemu-devel] [PATCH] ppc: fixed RAM initialization bug in hw/ppc4xx_devs.c, can now use memory larger than 256MB in bamboo PPC machines

2013-02-20 Thread Alin Tomescu
I hope this is the right way of submitting QEMU patches. I was trying to launch a PowerPC "bamboo" machine with more than 256MB of RAM with qemu-system-ppc -M bamboo -kernel $kernel -initrd $ramdisk -m 512, but QEMU would just hang. However, when I used -m 256, the machine would boot. I looked th

[Qemu-devel] [PATCH V2] tap: forbid creating multiqueue tap when hub is used

2013-02-20 Thread Jason Wang
Obviously, hub does not support multiqueue tap. So this patch forbids creating multiple queue tap when hub is used to prevent the crash when command line such as "-net tap,queues=2" is used. Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang --- Changes from V1: - Add a comment to explain the r

Re: [Qemu-devel] [PATCH] tap: forbid creating multiqueue tap when hub is used

2013-02-20 Thread Jason Wang
On 02/20/2013 09:08 PM, Stefan Hajnoczi wrote: > On Wed, Feb 20, 2013 at 05:18:08PM +0800, Jason Wang wrote: >> diff --git a/net/tap.c b/net/tap.c >> index 48c254e..1e14f59 100644 >> --- a/net/tap.c >> +++ b/net/tap.c >> @@ -693,6 +693,12 @@ int net_init_tap(const NetClientOptions *opts, const >>

[Qemu-devel] [PATCH 2/3] target-ppc: Synchronize FPU state with KVM

2013-02-20 Thread David Gibson
Currently qemu does not get and put the state of the floating point and vector registers to KVM. This is obviously a problem for savevm, as well as possibly being problematic for debugging of FP-using guests. This patch fixes this by using new extensions to the ONE_REG interface to synchronize th

[Qemu-devel] [PATCH 1/3] target-ppc: Add mechanism for synchronizing SPRs with KVM

2013-02-20 Thread David Gibson
Currently when runing under KVM on ppc, we synchronize a certain number of vital SPRs to KVM through the SET_SREGS call. This leaves out quite a lot of important SPRs which are maintained in KVM. It would be helpful to have their contents in qemu for debugging purposes, and when we implement migr

[Qemu-devel] [PATCH 3/3] target-ppc: Synchronize VPA state with KVM

2013-02-20 Thread David Gibson
For PAPR guests, KVM tracks the various areas registered with the H_REGISTER_VPA hypercall. For full emulation, of course, these are tracked within qemu. At present these values are not synchronized. This is a problem for reset (qemu's reset of the VPA address is not pushed to KVM) and will also

Re: [Qemu-devel] emulate powerpc(mpc8544ds) on x86 architecture

2013-02-20 Thread Scott Wood
On 02/20/2013 07:04:39 PM, Shi Rong wrote: 于 2013/02/21 2:30, Scott Wood 写道: On 02/20/2013 08:46:52 AM, Alexander Graf wrote: Also no need for enable-kvm, as you're running on x86. KVM only helps for compatible CPUs (ppc on ppc for example). you mean that KVM only support the same architect

Re: [Qemu-devel] emulate powerpc(mpc8544ds) on x86 architecture

2013-02-20 Thread Shi Rong
于 2013/02/21 2:30, Scott Wood 写道: On 02/20/2013 08:46:52 AM, Alexander Graf wrote: On 20.02.2013, at 15:07, Andreas Färber wrote: > Hi, > > Am 20.02.2013 10:22, schrieb Shi Rong: >> I want to emulate powerpc(mpc8544ds) on x86 architecture, is anybody >> succeed in it? > > If you CC Power Archi

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-20 Thread Laszlo Ersek
On 02/21/13 00:55, David Woodhouse wrote: >>> The above implements a CPU-only soft reset that should fix the problem >>> you're having with PAM resetting unconditionally. If it works, I'll >>> fixup the other PC callers of reset too. >> >> The problem I was facing on my workstation is that the PA

Re: [Qemu-devel] [PATCH 1/2] win32: do not set CPU affinity

2013-02-20 Thread Roy Tam
2013/2/20 Paolo Bonzini : > QEMU system emulation has been thread-safe for a long time, and > setting the CPU affinity is hurting performance badly. Remove > the bogus code. > > Jacob Kroon reports that the time to boot his VxWorks image goes from > "3 minutes passed and I still haven't made it th

Re: [Qemu-devel] [PATCH v4 4/6] introduce new vma archive format

2013-02-20 Thread Eric Blake
On 02/20/2013 02:32 AM, Dietmar Maurer wrote: > This is a very simple archive format, see docs/specs/vma_spec.txt > > Signed-off-by: Dietmar Maurer > --- > +++ b/docs/specs/vma_spec.txt > @@ -0,0 +1,24 @@ > +=Virtual Machine Archive format (VMA)= > + > +This format contains a header which includ

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-20 Thread David Woodhouse
On Wed, 2013-02-20 at 12:12 -0600, Anthony Liguori wrote: > The above implements a CPU-only soft reset that should fix the problem > you're having with PAM resetting unconditionally. If it works, I'll > fixup the other PC callers of reset too. To be clear: that wasn't my problem :) If people wan

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-20 Thread David Woodhouse
On Thu, 2013-02-21 at 00:50 +0100, Laszlo Ersek wrote: > On 02/20/13 19:12, Anthony Liguori wrote: > > > Or better yet, post binaries of Tiano Core + SeaBIOS as a CSM for me to > > try out? > > I tested David's recent PAM-resetting series with these: > > http://people.redhat.com/~lersek/csm-test

Re: [Qemu-devel] [PATCH V19 07/10] libqblock: libqblock API design and type defines

2013-02-20 Thread Eric Blake
On 02/15/2013 07:48 PM, Wenchao Xia wrote: > Public API design header files: libqblock.h, libqblock-error.h. > Public type define header files: libqblock-types.h. Private internal used > header files: libqblock-internal. For ABI some reserved bytes are used in > structure defines. Macro QEMU_DLL_

Re: [Qemu-devel] [PATCH 2/2] qemu-timer: move timeBeginPeriod/timeEndPeriod to os-win32

2013-02-20 Thread Jacob Kroon
On Wed, Feb 20, 2013 at 9:46 PM, Jacob Kroon wrote: > Paolo, > > Just a heads up, I tried the patched qemu (1+2+3) on my laptop at > home, which is running Windows 7 64-bit. I'm seeing qemu "lockups" > appearing randomly.. Will try to debug it. > On the other hand, plain vanilla 1.4.0 in Windows 7

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-20 Thread Laszlo Ersek
On 02/20/13 19:12, Anthony Liguori wrote: > Or better yet, post binaries of Tiano Core + SeaBIOS as a CSM for me to > try out? I tested David's recent PAM-resetting series with these: http://people.redhat.com/~lersek/csm-test.tar.xz (Debug output of OVMF, SeaBIOS and SeaVGABIOS all goes to the

Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration

2013-02-20 Thread Andreas Färber
Am 21.02.2013 00:34, schrieb David Woodhouse: > On Thu, 2013-02-21 at 00:31 +0100, Andreas Färber wrote: >> >> >> Reviewed-by: Andreas Färber >> >> A minor suggestion since you seem to be preparing a v2 would be to do >> I440FX_PCI_DEVICE(ds), but I don't see dev becoming unused anytime >> soon, t

Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration

2013-02-20 Thread David Woodhouse
On Thu, 2013-02-21 at 00:31 +0100, Andreas Färber wrote: > > > Reviewed-by: Andreas Färber > > A minor suggestion since you seem to be preparing a v2 would be to do > I440FX_PCI_DEVICE(ds), but I don't see dev becoming unused anytime > soon, therefore moot. Well it's only used because you told

Re: [Qemu-devel] [PATCH 2/4] piix_pci: Use ISA_BUS() instead of DO_UPCAST()

2013-02-20 Thread Andreas Färber
Am 21.02.2013 00:19, schrieb David Woodhouse: > On Thu, 2013-02-21 at 00:08 +0100, Andreas Färber wrote: >> Use of ISA_BUS() is correct, but it would be nice to use >> (DEVICE(piix3), ...) if respun. > > http://git.infradead.org/users/dwmw2/qemu.git/commitdiff/16d69961 Perfect! Andreas -- SUSE

Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration

2013-02-20 Thread Andreas Färber
Am 20.02.2013 22:46, schrieb David Woodhouse: > From: David Woodhouse > > This implements reset functionality for the i440FX, resetting all the > PAM registers to their power-on defaults of no RAM access and thus > forwarding all access to the 0xc-0xf range to PCI address space > (i.e. to

Re: [Qemu-devel] [PATCH V6 11/14] qmp: add interface query-snapshots

2013-02-20 Thread Eric Blake
On 02/20/2013 03:57 PM, Eric Blake wrote: > On 02/18/2013 03:46 PM, Wenchao Xia wrote: >> Hi, Eric >> About the interface,there is actually requirement to know internal >> snapshots in an image of a backing file, so I think the API should be >> improved as: >> >> # @query-snapshots: >> # >> # Get

Re: [Qemu-devel] [PATCH 3/4] piix_pci: Fix C99 comments

2013-02-20 Thread Andreas Färber
Am 20.02.2013 22:46, schrieb David Woodhouse: > From: David Woodhouse > > Signed-off-by: David Woodhouse > --- > hw/piix_pci.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/hw/piix_pci.c b/hw/piix_pci.c > index d45449a..2eeb739 100644 > --- a/hw/piix_pci.c

Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration

2013-02-20 Thread Laszlo Ersek
On 02/21/13 00:25, Laszlo Ersek wrote: > On 02/20/13 22:46, David Woodhouse wrote: > >> +static void i440fx_reset(DeviceState *ds) >> +{ >> +PCIDevice *dev = PCI_DEVICE(ds); >> +PCII440FXState *d = I440FX_PCI_DEVICE(dev); >> +uint8_t *pci_conf = dev->config; >> + >> +pci_conf[0x59]

Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration

2013-02-20 Thread Laszlo Ersek
On 02/20/13 22:46, David Woodhouse wrote: > +static void i440fx_reset(DeviceState *ds) > +{ > +PCIDevice *dev = PCI_DEVICE(ds); > +PCII440FXState *d = I440FX_PCI_DEVICE(dev); > +uint8_t *pci_conf = dev->config; > + > +pci_conf[0x59] = 0x00; /* Reset PAM setup */ > +pci_conf[0x5

Re: [Qemu-devel] [PATCH] i440fx: implement reset

2013-02-20 Thread David Woodhouse
On Wed, 2013-02-20 at 20:25 +, David Woodhouse wrote: > On Wed, 2013-02-20 at 19:20 +0100, Andreas Färber wrote: > > > And then all the *existing* uses of DO_UPCAST should be fixed to > use it > > > too? Such as in i440fx_write_config() ? > > > > Outside the scope of this patch. > > Well, may

Re: [Qemu-devel] [PATCH 2/4] piix_pci: Use ISA_BUS() instead of DO_UPCAST()

2013-02-20 Thread David Woodhouse
On Thu, 2013-02-21 at 00:08 +0100, Andreas Färber wrote: > Use of ISA_BUS() is correct, but it would be nice to use > (DEVICE(piix3), ...) if respun. http://git.infradead.org/users/dwmw2/qemu.git/commitdiff/16d69961 -- dwmw2 smime.p7s Description: S/MIME cryptographic signature

Re: [Qemu-devel] [PATCH 2/4] piix_pci: Use ISA_BUS() instead of DO_UPCAST()

2013-02-20 Thread Andreas Färber
Am 20.02.2013 22:46, schrieb David Woodhouse: > From: David Woodhouse > > Signed-off-by: David Woodhouse > --- > hw/piix_pci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/piix_pci.c b/hw/piix_pci.c > index 6b69e26..d45449a 100644 > --- a/hw/piix_pci.c > +++ b/

Re: [Qemu-devel] [PATCH 1/4] piix_pci: Clean up i440FX object handling

2013-02-20 Thread Andreas Färber
Am 20.02.2013 22:46, schrieb David Woodhouse: > From: David Woodhouse > > Define and use I440FX_PCI_DEVICE() instead of using DO_UPCAST(). > > Signed-off-by: David Woodhouse Reviewed-by: Andreas Färber Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF:

Re: [Qemu-devel] [PATCH V6 11/14] qmp: add interface query-snapshots

2013-02-20 Thread Eric Blake
On 02/18/2013 03:46 PM, Wenchao Xia wrote: > Hi, Eric > About the interface,there is actually requirement to know internal > snapshots in an image of a backing file, so I think the API should be > improved as: > > # @query-snapshots: > # > # Get a list of internal snapshots for whole virtual mac

Re: [Qemu-devel] [PATCH V6 10/14] block: distinguish id and name in bdrv_find_snapshot()

2013-02-20 Thread Eric Blake
On 02/18/2013 07:09 AM, Wenchao Xia wrote: > To make it clear about id and name in searching, the API was changed > a bit to distinguish them. Caller can choose to search by id or name now. > Searching will be done with higher priority of id. > > Signed-off-by: Wenchao Xia > --- > block.c

[Qemu-devel] needs help to choise right version of qemu and linux kernel

2013-02-20 Thread Vasiliy Tolstov
Hello. I need to host is about 50 vm on phisical server, each vm need to able to create snapshot of it hard drive to backup server and live migrate to another server.. What version of kernel and qemu i need to use? What is the best stable version ofr kernel? (i'm interesting vanilla kernels from ke

[Qemu-devel] [Bug 1130822] Re: Qemu wiki compile page error (solution provided)

2013-02-20 Thread Stefan Weil
Thanks for the hint - I just fixed the wrong compiler option. Did you know that this is a Wiki? You can get a user account and improve any documentation. Regards, Stefan Weil ** Changed in: qemu Status: New => Fix Released ** Changed in: qemu Assignee: (unassigned) => Stefan Weil

Re: [Qemu-devel] [PATCH V6 09/14] block: move bdrv_snapshot_find() to block.c

2013-02-20 Thread Eric Blake
On 02/18/2013 07:09 AM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > block.c | 24 > include/block/block.h |2 ++ > savevm.c | 22 -- > 3 files changed, 26 insertions(+), 22 deletions(-) Reviewed-by: Eric

Re: [Qemu-devel] [PATCH] tcg: Document tcg_qemu_tb_exec() and provide constants for low bit uses

2013-02-20 Thread Andreas Färber
Am 20.02.2013 13:20, schrieb Peter Maydell: > Document tcg_qemu_tb_exec(). In particular, its return value is a > combination of a pointer to the next translation block and some > extra information in the low two bits. Provide some #defines for > the values passed in these bits to improve code clar

Re: [Qemu-devel] Online resize of virtio-blk device does not emit udev event

2013-02-20 Thread Milos Vyletel
Stefan, that's essentially what I was trying to do. I wanted to get an opinion from someone more familiar with the virtio-blk and kernel in general firs though. It looks like none of the block drivers handle this. It may be good idea to add some function to block/genhd.c where similar stuff alrea

[Qemu-devel] [Bug 1130769] [NEW] VirtFS (virtio-9p-pci) error: Parameter 'driver' expects device type

2013-02-20 Thread Tim Comer
Public bug reported: Getting error "Parameter 'driver' expects device type" when trying to share a file system with a guest. Command line: qemu-kvm -m 4096 -cpu host -smp 4,sockets=1 -net nic,model=virtio,macaddr=00:00:00:00:00:00 -net tap,ifname=tap0,script=no,downscript=no -rtc bas

[Qemu-devel] [PATCH 2/4] piix_pci: Use ISA_BUS() instead of DO_UPCAST()

2013-02-20 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/piix_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 6b69e26..d45449a 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -301,8 +301,7 @@ static PCIBus *i440fx_common_init(

[Qemu-devel] [Bug 1077116] Re: automoc4 segfaults when building in an armhf pbuilder on an amd64 host

2013-02-20 Thread Serge Hallyn
Thanks for reporting this bug. There seem to be a few bugs in the armhf qemu-user-static right now. I'll test against bleeding edge upstream. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1077116 T

[Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration

2013-02-20 Thread David Woodhouse
From: David Woodhouse This implements reset functionality for the i440FX, resetting all the PAM registers to their power-on defaults of no RAM access and thus forwarding all access to the 0xc-0xf range to PCI address space (i.e. to the actual ROM) instead of RAM. Fixing this is sufficien

[Qemu-devel] [PATCH 1/4] piix_pci: Clean up i440FX object handling

2013-02-20 Thread David Woodhouse
From: David Woodhouse Define and use I440FX_PCI_DEVICE() instead of using DO_UPCAST(). Signed-off-by: David Woodhouse --- hw/piix_pci.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 6c77e49..6b69e26 100644 --- a/hw/piix

[Qemu-devel] [PATCH 3/4] piix_pci: Fix C99 comments

2013-02-20 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/piix_pci.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index d45449a..2eeb739 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -426,10 +426,10 @@ static void piix3_reset

Re: [Qemu-devel] emulate powerpc(mpc8544ds) on x86 architecture

2013-02-20 Thread Andreas Färber
Hi, Am 20.02.2013 10:22, schrieb Shi Rong: > I want to emulate powerpc(mpc8544ds) on x86 architecture, is anybody > succeed in it? If you CC Power Architecture questions to qemu-ppc, you have higher chances of getting replies from the experts. > My working step: > about qemu: > ./configure --cpu

Re: [Qemu-devel] [PATCH v2][QEMU] vmxcap: Report APIC register emulation and RDTSCP control

2013-02-20 Thread Marcelo Tosatti
On Mon, Feb 18, 2013 at 07:56:54AM +0100, Jan Kiszka wrote: > From: Jan Kiszka > > Signed-off-by: Jan Kiszka > --- > > This time I've checked twice that I'm no longer missing a field. Applied, thanks.

Re: [Qemu-devel] [PATCH 1/4] configure: Add --enable-migration-from-qemu-kvm

2013-02-20 Thread Anthony Liguori
Paolo Bonzini writes: > Il 20/02/2013 21:26, Anthony Liguori ha scritto: >> Cole Robinson writes: >> >>> This switch will turn on all the migration compat bits needed to >>> perform migration from qemu-kvm to qemu. It's just a stub for now. >>> >>> This compat will break incoming migration from

Re: [Qemu-devel] [PATCH V24 1/7] Support for TPM command line options

2013-02-20 Thread Corey Bryant
On 02/19/2013 04:59 PM, Stefan Berger wrote: On 02/19/2013 04:42 PM, Corey Bryant wrote: diff --git a/tpm/Makefile.objs b/tpm/Makefile.objs new file mode 100644 index 000..dffb567 --- /dev/null +++ b/tpm/Makefile.objs @@ -0,0 +1 @@ +common-obj-y = tpm.o diff --git a/tpm/tpm.c b/tpm/tpm.c

Re: [Qemu-devel] [PATCH 2/2] qemu-timer: move timeBeginPeriod/timeEndPeriod to os-win32

2013-02-20 Thread Jacob Kroon
Paolo, Just a heads up, I tried the patched qemu (1+2+3) on my laptop at home, which is running Windows 7 64-bit. I'm seeing qemu "lockups" appearing randomly.. Will try to debug it. On the other hand, plain vanilla 1.4.0 in Windows 7 seems to run fine with my VxWorks image.. Regards Jacob On We

Re: [Qemu-devel] [PATCH 1/4] configure: Add --enable-migration-from-qemu-kvm

2013-02-20 Thread Cole Robinson
On 02/20/2013 03:26 PM, Anthony Liguori wrote: > Cole Robinson writes: > >> This switch will turn on all the migration compat bits needed to >> perform migration from qemu-kvm to qemu. It's just a stub for now. >> >> This compat will break incoming migration from qemu < 1.3, but for >> distros wh

Re: [Qemu-devel] [PATCH 1/4] configure: Add --enable-migration-from-qemu-kvm

2013-02-20 Thread Paolo Bonzini
Il 20/02/2013 21:26, Anthony Liguori ha scritto: > Cole Robinson writes: > >> This switch will turn on all the migration compat bits needed to >> perform migration from qemu-kvm to qemu. It's just a stub for now. >> >> This compat will break incoming migration from qemu < 1.3, but for >> distros

Re: [Qemu-devel] [PATCH V24 5/7] Add a TPM Passthrough backend driver implementation

2013-02-20 Thread Corey Bryant
On 02/19/2013 06:30 PM, Stefan Berger wrote: On 02/19/2013 05:43 PM, Corey Bryant wrote: diff --git a/tpm/Makefile.objs b/tpm/Makefile.objs index 94ad2e7..8abd0f9 100644 --- a/tpm/Makefile.objs +++ b/tpm/Makefile.objs @@ -1,4 +1,6 @@ -common-obj-y = tpm.o +common-obj-y = tpm.o tpm_backend.o

Re: [Qemu-devel] fixing qemu busy wait

2013-02-20 Thread Paolo Bonzini
Il 20/02/2013 20:39, Orr Dvory ha scritto: > if (errno != EINTR && errno != EAGAIN) > +/* there's no need to restore the > +O_NONBLOCK option. */ > return; > + But it's cleaner to do it anyway. :) Paolo

[Qemu-devel] [Bug 1130533] Re: Documentation cannot be build since commit c70a01e449536c616c85ab820c6fbad7d7e9cf39

2013-02-20 Thread Peter Weber
I'm using Archlinux and I'm trying to install any qemu-* package from AUR currently. It doesn't work and reverting the mentioned patch doesn't fix it: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=c70a01e449536c616c85ab820c6fbad7d7e9cf39;hp=6265c43b0c872015e4331d3a93ff99946f3edb01 Rationale: I'm

[Qemu-devel] [Bug 1130822] [NEW] Qemu wiki compile page error (solution provided)

2013-02-20 Thread deviker
Public bug reported: Hello, At http://wiki.qemu.org/Hosts/W32 Compile howto needs an "s" on "thread" ---> "threads" configure --cross-prefix=i586-mingw32msvc- [--extra-cflags=-mthread] SHOULD BE: configure --cross-prefix=i586-mingw32msvc- [--extra-cflags=-mthreads] Best regards, Iker De Ech

Re: [Qemu-devel] [PATCH 1/4] configure: Add --enable-migration-from-qemu-kvm

2013-02-20 Thread Anthony Liguori
Cole Robinson writes: > This switch will turn on all the migration compat bits needed to > perform migration from qemu-kvm to qemu. It's just a stub for now. > > This compat will break incoming migration from qemu < 1.3, but for > distros where qemu-kvm was the only shipped package for years it's

  1   2   3   4   >