... and use them where appropriate in the targets. As can be seen,
most targets can make use of a widening multiply. And if one is
sufficiently clever, one can use add2 to significantly improve carry
generation for the target.
This patch series is based on the target-i386 flags rewrite that I
ju
Make SPI and QSPI different classes. QSPIPS is setup as a child of SPIPS.
Only QSPI has the LQSPI functionality, so move all that to the child class.
Signed-off-by: Peter Crosthwaite
---
hw/xilinx_spips.c | 66 ++--
hw/xilinx_zynq.c |2 +-
Unused CS lines should init to 0 to avoid segfaulting when accessing an
unattached QSPI controller.
Signed-off-by: Peter Crosthwaite
---
hw/xilinx_spips.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xilinx_spips.c b/hw/xilinx_spips.c
index 42e019d..3eee828 10064
Few fixes for the latest QOM styling guides.
Signed-off-by: Peter Crosthwaite
---
hw/xilinx_spips.c | 29 -
1 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/hw/xilinx_spips.c b/hw/xilinx_spips.c
index 45a1c51..530ef47 100644
--- a/hw/xilinx_spips.c
From: Nathan Rossi
The R_LQPSI_CFG register has the LQSPI_CFG_SEP_BUS and LQSPI_CFG_TWO_MEM bits.
Signed-off-by: Nathan Rossi
Signed-off-by: Peter Crosthwaite
---
hw/xilinx_spips.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xilinx_spips.c b/hw/xilinx_spips
Few updates to the Zynq SPI controller. Couple of bug-fixes/completions followed
by some QOMifying cleanup.
Nathan Rossi (2):
xilinx_spips: Fix bus setup conditional check
xilinx_spips: Add missing dual-bus snoop commands
Peter Crosthwaite (3):
xilinx_spips: Set unused IRQs to NULL
xilin
Il 20/02/2013 07:32, Kazuya Saito ha scritto:
> Signed-off-by: Kazuya Saito
Unfortunately, this conflicts with my series to simplify migration.c
(branch migration-thread-20130115 in git://github.com/bonzini/qemu.git).
I'm not sure how to proceed here, because migrate_set_state doesn't
exist anym
First, many thanks for the review!
> It is customary to send a 0/6 cover letter for details like this, rather than
> slamming it into the first patch (git send-email --cover-letter).
> Remember, once it is in git, it is no longer as easy to identify where a
> series
> starts and ends, so the cont
On 2013-02-19 09:40, Richard Henderson wrote:
+/* Otherwise compute the carry-out in two steps. */
+tcg_gen_add_tl(cpu_T[0], cpu_T[0], cpu_regs[reg]);
+tcg_gen_setcond_tl(TCG_COND_LTU, cpu_tmp4,
+
On 2013-02-19 13:52, Torbjorn Granlund wrote:
Execute. I believe correct behaviour is to print:
000d 000d 040b 000a
The program under your special qemu instead prints:
000e 000d 040b 000a
As sPAPRPHBState struct incapsulates DeviceState struct,
the "id" property can be set from the command line.
So there is no need in the "busname" property which is only used
to pass a PCI bus name from the spapr-pci-host-bridge device to
pci_register_bus().
Signed-off-by: Alexey Kardashevskiy
---
Hello all,
I ran OKL4 and got an image file as output.
I am trying to run OKL4 image by using QEMU.
I didn't use "-start-addr 0x0790" option.
I used the below command.
*# qemu-system-arm -M versatileab -nographic -kernel
build.nano-debug/images/image.elf*
*Segmentation fault (core dumped)*
using bit[11-12] of opcode as acc is not correct for ASE_MIPS16 instructions.
doing so generates RI/DSPDIS exception when decoding MIPS16 MULT/DIV.
Signed-off-by: Leon Yu
---
target-mips/translate.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/target-mips
DEFAULT_MACHINE_OPTIONS is setting default boot_order,
while QEMUMachine already has default_machine_opts
to encapsulate some default options, so change it to
DEFAULT_MACHINE_BOOT_ORDER.
Signed-off-by: liguang
---
hw/alpha_dp264.c |2 +-
hw/an5206.c |2 +-
Signed-off-by: Kazuya Saito
---
include/migration/migration.h |2 ++
migration.c | 19 +--
trace-events |3 +++
3 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/include/migration/migration.h b/include/migration/migration.
Signed-off-by: Kazuya Saito
---
trace-events |1 +
vl.c |2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/trace-events b/trace-events
index 1011f27..bf508f0 100644
--- a/trace-events
+++ b/trace-events
@@ -472,6 +472,7 @@ scsi_request_sense(int target, int lun,
This series adds tracepoints about state transition of VM to get
information of live migration. I fixed the function names to
"migrate_" prefix as Stefan pointed out[1] and tested it.
The previous version[2] doesn't seem to be taken in qemu tree, so
if this version is better, please take it in.
[
Add the I2C controllers/switches and EEPROMs attached to Zynq boards.
Signed-off-by: Peter Crosthwaite
---
hw/xilinx_zynq.c | 30 ++
1 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c
index 311f791..2608015 100644
--
Initial version of device model for PCA9548 8 way I2C switch.
Signed-off-by: Peter Crosthwaite
---
default-configs/arm-softmmu.mak |1 +
hw/Makefile.objs|1 +
hw/pca9548.c| 229 +++
3 files changed, 231 insertions(
Cadence I2C controller as current implemented in Xilinx Zynq.
Signed-off-by: Peter Crosthwaite
---
hw/Makefile.objs |1 +
hw/cadence_i2c.c | 388 ++
2 files changed, 389 insertions(+), 0 deletions(-)
create mode 100644 hw/cadence_i2c.c
> > * Backup to a single archive file
> > * Backup contain all data to restore VM (full backup)
> > * Do not depend on storage type or image format
> > * Avoid use of temporary storage
> > * store sparse images efficiently
>
> It is customary to send a 0/6 cover letter for details like this, rathe
Device models and machine model changed for the Xilinx Zynq I2C controller and
the devices attached to the ZC70x development boards.
Peter Crosthwaite (6):
i2c: support address ranges
i2c: Add no_init version of i2c_create_slave
cadence_i2c: first revision
hw: M24Cxx I2C EEPROM device mod
On 20/02/13 08:49, Alex Williamson wrote:
On Tue, 2013-02-19 at 18:43 +1100, Alexey Kardashevskiy wrote:
The patch adds the following functionality:
1. Implements VFIO-IOMMU host kernel driver support;
2. Implements interface between SPAPR TCE and VFIO via
sPAPRVFIOData's map/unmap hooks;
3.
Device model for the ST M24Cxx I2C EEPROM devices. Device can optionally be
backed onto a file for persistent storage (using -mtd-block).
Signed-off-by: Peter Crosthwaite
---
default-configs/arm-softmmu.mak |1 +
hw/Makefile.objs|1 +
hw/m24cxx.c | 2
Add a version of i2c_create_slave that does not qdev init the created device.
This give the machine model a chance to set properites of the created device
before qdev_init time. Based on equivalent function in ssi.c.
Signed-off-by: Peter Crosthwaite
---
hw/i2c.c | 11 ++-
hw/i2c.h |
Some I2C devices (eg m24c08) can decode a linear range of addresses
(e.g. 0b10100xx). Add the address_range field to I2C slave that specifies the
number of consecutive addresses the device decodes.
Signed-off-by: Peter Crosthwaite
---
hw/i2c.c | 14 ++
hw/i2c.h |6 ++
2 fi
On Mon, Feb 18, 2013 at 11:25 PM, Michael Tokarev wrote:
> Hello.
>
> Since there's no interest in 1.1 series - neither from users nor
> from the official qemu maintainers, I'm cancelling this series.
>
> Thanks all.
>
> /mjt
>
I follow it for Gentoo support. I just didn't have feedback other tha
Allows for repeating of -sd arguments in the same way as -pflash and -mtdblock.
Acked-by: Igor Mitsyanko
Reviewed-by: Peter Maydell
Signed-off-by: Peter Crosthwaite
---
vl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index c5b0eea..fb6ff1c 100644
---
The Xilinx Zynq device has two SDHCI controllers. Added to the machine model.
Reviewed-by: Peter Maydell
Signed-off-by: Peter Crosthwaite
---
hw/xilinx_zynq.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c
index 311f791..3
[Original cover by Igor]
First patch introduces standard SD host controller model. This is accumulated
version of my previous patch I sent a while ago and a recent SDHCI patch by
Peter A. G. Crosthwaite.
Second patch changes the -sd command line argument to be repeatable, to support
multiple SD co
On Tue, Feb 19, 2013 at 6:35 PM, Gerd Hoffmann wrote:
> Hi,
>
>> I ran git blame on it and its actually Gerds code. Gerd you want
>> co-authorship and the (c) of this hexdump.c?
>
> Yes.
>
> And don't break iov_hexdump() behavior please. I suggest to just
> iov_to_buf() into a temporary buffer,
In QEMU emulation, there is no functional difference between the ARM mpcore
private timers and watchdogs. Removed all the distinction between the two from
arm_mptimer.c and converted it to be just the mptimer. a9mpcore and arm11mpcore
just instantiate the same mptimer object twice to get both timer
This field was write only and thus unused. Removed.
Signed-off-by: Peter Crosthwaite
---
Set minimum version ID to 3 (PMM review)
hw/a9mpcore.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/a9mpcore.c b/hw/a9mpcore.c
index 0032f53..23630af 100644
--- a/hw
Patches 1-3 and 5 are trivial code cleanup and may be candidate to go via
trivial queue inpdependent of review of this work. Patch 4 unifies the MPTimer
and WDT into one device. My motivation for doing this is so I can dynamically
create one without the other (Im throwing away MPCore altogether in
To conform with QEMU coding style.
Signed-off-by: Peter Crosthwaite
---
changed from v1:
s/MPCorePrivState/ARM11MPCorePriveState (PMM review)
hw/a9mpcore.c| 26 +-
hw/arm11mpcore.c | 20 ++--
2 files changed, 23 insertions(+), 23 deletions(-)
dif
Trivial find replace on type names "timerblock" and "arm_mptimer_state" to
conform with QEMU coding style.
Signed-off-by: Peter Crosthwaite
Reviewed-by: Peter Maydell
---
hw/arm_mptimer.c | 56 +++---
1 files changed, 28 insertions(+), 28 delet
This commit does the same for the ICH9 LPC as commit 1ec4ba74 for the
PIIX3. For the present we're ignoring the Full Reset (FULL_RST) and System
Reset (SYS_RST) bits; the guest can read them back but that's it.
Signed-off-by: Laszlo Ersek
---
Tested retention of RCR contents and reset functional
Split the SCU in a9mpcore out into its own object definition. mpcore is now
just a container for the mpcore components.
Signed-off-by: Peter Crosthwaite
---
changed from v1:
added DeviceState pointer for SCU in APMPPrivState (PMM review)
Deleted stale comment (PMM review)
hyphenated strings (PMM
2013/2/19 Stefan Hajnoczi :
> On Tue, Feb 19, 2013 at 09:43:27AM +0800, Kuo-Jung Su wrote:
>> 2013/2/19 Kuo-Jung Su :
>> > 2013/2/18 Stefan Hajnoczi :
>> >> On Mon, Feb 18, 2013 at 05:44:38PM +0800, Kuo-Jung Su wrote:
>> >>> 2013/2/18 Stefan Hajnoczi :
>> >>> > On Wed, Feb 06, 2013 at 05:45:19PM +0
On Tue, Feb 19, 2013 at 4:49 AM, Peter Maydell wrote:
> On 8 February 2013 04:03, Peter Crosthwaite
> wrote:
>> Split the SCU in a9mpcore out into its own object definition. mpcore is now
>> just a container for the mpcore components.
>
> Good idea.
>
>> --- a/hw/a9mpcore.c
>> +++ b/hw/a9mpcore.c
On 02/19/2013 09:53 PM, Peter Maydell wrote:
On 19 February 2013 17:44, Igor Mitsyanko wrote:
On 02/19/2013 11:46 AM, Peter Crosthwaite wrote:
Device model for Primecell PL330 DMA controller.
Signed-off-by: Peter Crosthwaite
Signed-off-by: Kirill Batuzov
Tested-by: Igor Mitsyanko
Is my
On Wed, Feb 20, 2013 at 4:02 AM, Igor Mitsyanko wrote:
>
> On 02/19/2013 09:53 PM, Peter Maydell wrote:
>>
>> On 19 February 2013 17:44, Igor Mitsyanko wrote:
>>>
>>> On 02/19/2013 11:46 AM, Peter Crosthwaite wrote:
Device model for Primecell PL330 DMA controller.
Signed-off-b
Use a dirty flag to know whether env->cc_op is up to date,
rather than forcing s->cc_op to DYNAMIC and losing info.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 37 ++---
1 file changed, 22 insertions(+), 15 deletions(-)
diff --git a/target-i386
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 32
1 file changed, 32 insertions(+)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index c1a2886..68e30e6 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -4433,6
I'll have to apologize to Paolo here, in that (1) during some of the
various rewriting and rebasing, the original author credit got dropped
and (2) most of the signed-off-by is still there, despite the large changes.
I've fixed the performance regression that Laurent reported on nbench.
I've misp
This is looking at EFLAGS, but it can do so more efficiently with
setcond.
Reviewed-by: Blue Swirl
Signed-off-by: Paolo Bonzini
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/target-i386/translate.c b/targ
On 2013-02-19 16:54, Peter Maydell wrote:
> On 19 February 2013 15:51, Jan Kiszka wrote:
>> On 2013-02-19 16:20, Michael S. Tsirkin wrote:
>>> qdev_init_nofail(dev);
>>> d = SYS_BUS_DEVICE(dev);
>>> -sysbus_mmio_map(d, 0, 0xfec0);
>>> +/* APIC overlaps the PCI window. */
>>>
Hi all:
I want to use the qemu's -sd option to emulate a sd card, so that I can
get more free space.
When I use the command "qemu-system-ppc -M mpc8544ds -kernel uImage
-initrd initrd.img
-append "root=/dev/ram rdinit=/linuxrc" -nographic -sd sd.img" to start
the kernel image, I can't
find an
On Mon, Feb 18, 2013 at 02:33:23PM -0500, Kevin O'Connor wrote:
> On Mon, Feb 18, 2013 at 09:17:05PM +0200, Gleb Natapov wrote:
> > On Mon, Feb 18, 2013 at 02:00:52PM -0500, Kevin O'Connor wrote:
> > > Why not fix KVM so that it runs at fff0 after reset?
> > >
> > Because KVM uses VMX extensio
Move the definition of struct VirtIOFeature from virtio-net.c to virtio.h
so other virtio devices can benefit.
Signed-off-by: Jesse Larrew
---
hw/virtio-net.c | 12
hw/virtio.h | 12
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/hw/virtio-net.c b/
On Tue, Feb 19, 2013 at 4:37 AM, Peter Maydell wrote:
> On 8 February 2013 04:03, Peter Crosthwaite
> wrote:
>> In QEMU emulation, there is no functional difference between the ARM mpcore
>> private timers and watchdogs. Removed all the distinction between the two
>> from
>> arm_mptimer.c and co
Drivers affected:
* virtio_balloon
* virtio_serial_bus
* virtio_scsi
* virtio_blk
* virtio_9p
* virtio_rng
Signed-off-by: Jesse Larrew
---
hw/s390x/s390-virtio-bus.c | 8 +---
hw/s390x/virtio-ccw.c | 11 +++
hw/virtio-balloon.c| 2 +-
hw/virtio-blk.c|
On Tue, Feb 19, 2013 at 4:16 AM, Peter Maydell wrote:
> On 8 February 2013 04:03, Peter Crosthwaite
> wrote:
>> --- a/hw/arm11mpcore.c
>> +++ b/hw/arm11mpcore.c
>> @@ -12,7 +12,7 @@
>>
>> /* MPCore private memory region. */
>>
>> -typedef struct mpcore_priv_state {
>> +typedef struct MPCorePriv
On Tue, Feb 19, 2013 at 4:12 AM, Peter Maydell wrote:
> On 8 February 2013 04:03, Peter Crosthwaite
> wrote:
>> The DeviceState *mptimer var in a9mp_priv_state was only used by the init
>> function and had no reason for persistence. Made a local variable and removed
>> from state struct.
>
> Nope
Since none of the existing feature bits changed the layout of struct
VirtIOSCSIConf, set the minimum struct size to use the full struct (i.e
endof(struct VirtIOSCSIConf, cmd_per_lun)).
Signed-off-by: Jesse Larrew
---
hw/virtio-scsi.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
There are two feature bits for virtio-balloon:
VIRTIO_BALLOON_F_MUST_TELL_HOST, and
VIRTIO_BALLOON_F_STATS_VQ.
Since these features don't require additional fields in the config struct,
set the 'end' field to the end of the last field in the struct.
Signed-off-by: Jesse Larrew
---
hw/vir
On 02/15/2013 07:46 PM, Paolo Bonzini wrote:
> Completion of migration is currently done with a "nested" loop that
> invokes buffered_flush: migrate_fd_completed is called by
> buffered_file_thread, which calls migrate_fd_cleanup, which calls
> buffered_close (via qemu_fclose), which flushes the bu
ZF, SF and PF can always be computed from CC_DST except in the
CC_OP_EFLAGS case (and CC_OP_DYNAMIC, which just resolves to CC_OP_EFLAGS
in gen_compute_eflags). Use setcond to compute ZF and SF.
We could also use a table lookup to compute PF.
Reviewed-by: Blue Swirl
Signed-off-by: Paolo Bonzini
Make gen_compute_eflags_z and gen_compute_eflags_s able to compute the
inverted condition, and use this in gen_setcc_slow_T0. We cannot do it
yet in gen_compute_eflags_c, but prepare the code for it anyway. It is
not worthwhile for PF, as usual.
shr+and+xor could be replaced by and+setcond. I'm
On 19 February 2013 23:54, Peter Crosthwaite
wrote:
> On Tue, Feb 19, 2013 at 6:19 AM, Andreas Färber wrote:
>> Am 18.02.2013 19:49, schrieb Peter Maydell:
>>> You need to add a DeviceState* for the scu.
>>
>> No, not a DeviceState*, an A9SCUState. With object_initialize() and
>> qdev_set_parent_
Move the config size calculation from virtio_net_init() to
virtio_common_init() so that all virtio devices can benefit. This requires
that the host_features be passed to virtio_common_init(), and the size of
the config struct will be calculated based on which feature bits are
enabled. This calculat
Am 18.02.2013 um 17:14 schrieb Paolo Bonzini :
> Il 18/02/2013 16:58, Peter Lieven ha scritto:
>>
>> +acb = qemu_aio_get(&iscsi_aiocb_info, bs, cb, opaque);
>> +
>> +acb->iscsilun = iscsilun;
>> +acb->retries = ISCSI_CMD_RETRIES;
>> +acb->nb_sectors = nb_sectors;
>> +acb->s
Commit 14f9b664b34bbd37a488cb5c762aa278c60e1fb6 added a config_size field
to struct VirtIONet. However, struct VirtIONet has an embedded struct
VirtIODevice that already contains a config_len field for this purpose, so
config_size is unnecessary. This patch simply replaces it with
vdev->config_len
And allow gen_setcc_slow to operate on cpu_cc_src.
Signed-off-by: Paolo Bonzini
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index dab6983..fea43
VIRTIO_CONSOLE_F_MULTIPORT is set when max_nr_ports > 1, so set the config
size to include max_nr_ports.
Signed-off-by: Jesse Larrew
---
hw/virtio-serial-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 9cd9fbd..0
Hi Andreas,
On Tue, Feb 19, 2013 at 6:19 AM, Andreas Färber wrote:
> Am 18.02.2013 19:49, schrieb Peter Maydell:
>> On 8 February 2013 04:03, Peter Crosthwaite
>> wrote:
>>> Split the SCU in a9mpcore out into its own object definition. mpcore is now
>>> just a container for the mpcore components
In preparation for making this a const helper.
By using the proper types in the parameters to the helper functions,
we get to avoid quite a lot of subsequent casting.
Signed-off-by: Richard Henderson
---
target-i386/cc_helper.c | 217 ++
target-i386/cc_h
Build the TPM frontend code that has been added so far.
Signed-off-by: Stefan Berger
Reviewed-by: Corey Bryant
---
configure | 11 +++
default-configs/i386-softmmu.mak | 1 +
default-configs/x86_64-softmmu.mak | 1 +
tpm/Makefile.objs | 3 +
On 02/19/2013 05:43 PM, Corey Bryant wrote:
diff --git a/tpm/Makefile.objs b/tpm/Makefile.objs
index 94ad2e7..8abd0f9 100644
--- a/tpm/Makefile.objs
+++ b/tpm/Makefile.objs
@@ -1,4 +1,6 @@
-common-obj-y = tpm.o
+common-obj-y = tpm.o tpm_backend.o
ifeq ($(CONFIG_TPM),y)
common-obj-$(CONFIG_T
On Tue, 2013-02-19 at 21:49 +0100, Paolo Bonzini wrote:
> > And in fact it probably shouldn't use the hard-coded 0xcf9 reset; it
> > should use the one indicated by the ACPI RESET_REG field (which *is*
> > 0xcf9... or should be).
>
> We should implement this: http://mjg59.dreamwidth.org/3561.html
The actual command from the build log:
/usr/lib/jvm/java-6-openjdk-armhf/bin/java -cp
".:../../unxlngr.pro/class:/usr/lib/jvm/java-6-openjdk-armhf/jre/lib/rt.jar:.:/build/buildd/libreoffice-3.5.7/solver/unxlngr.pro/bin
/jaxp.jar:/build/buildd/libreoffice-3.5.7/solver/unxlngr.pro/bin/juh.jar:/bu
On Tue, Dec 18, 2012 at 10:41 AM, Vasilis Liaskovitis <
vasilis.liaskovi...@profitbricks.com> wrote:
> This is v4 of the ACPI memory hotplug functionality. Only x86_64 target is
> supported (both i440fx and q35). There are still several issues, but it's
> been a while since v3 and I wanted to get
This makes the i386 front-end able to create CCPrepare structs for all
condition, not just those that come from a single flag. In particular,
JCC_L and JCC_LE can be optimized because gen_prepare_cc is not forced
to return a result in bit 0 (unlike gen_setcc_slow).
However, for now the slow jcc o
Il 19/02/2013 23:59, Cole Robinson ha scritto:
> On 02/19/2013 05:52 PM, Paolo Bonzini wrote:
>> Il 19/02/2013 23:40, Cole Robinson ha scritto:
>>> +#ifdef CONFIG_MIGRATE_FROM_QEMU_KVM
>>> +/* qemu-kvm defaulted to 16MB video memory since 0.15 at least. */
>>> +# define OLD_VGA_MEM stringify(16)
>>
Fill in the feature table with the last field of struct virtio_blk_config
at the time that the feature flag was introduced. The table was constructed
by searching through the git history.
Signed-off-by: Jesse Larrew
---
hw/virtio-blk.c | 22 --
1 file changed, 20 insertions(+
To ensure compatibility between qemu versions, virtio drivers should set
the size of their config structs according to the feature bits that are
set. This should keep the size from changing as new features are introduced
and avoid breaking older drivers.
Changes since v1:
* Fixed a build error on
On 02/18/2013 07:09 AM, Wenchao Xia wrote:
> This patch add function bdrv_query_image_info(), which will return
> image info in qmp object format. The implementation code are based
> on the code moved from qemu-img.c, but use block layer function to get
> snapshot info.
> A check with bdrv_can_
Signed-off-by: Cole Robinson
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index 53fe9c3..27ad002 100644
--- a/.gitignore
+++ b/.gitignore
@@ -83,12 +83,15 @@ fsdev/virtfs-proxy-helper.pod
patches
pc-bios/bios-pq/status
pc-bios/vgabios-pq/status
On 02/19/2013 04:31 AM, Dietmar Maurer wrote:
> We use a generic BackupDriver struct to encapsulate all archive format
> related function.
>
> Another option would be to simply dump to
> the output fh (pipe), and an external binary saves the data. That way we
> could move the whole archive format
On 02/19/2013 05:52 PM, Paolo Bonzini wrote:
> Il 19/02/2013 23:40, Cole Robinson ha scritto:
>> +#ifdef CONFIG_MIGRATE_FROM_QEMU_KVM
>> +/* qemu-kvm defaulted to 16MB video memory since 0.15 at least. */
>> +# define OLD_VGA_MEM stringify(16)
>> +#else
>> +# define OLD_VGA_MEM stringify(8)
>> +#en
This switch will turn on all the migration compat bits needed to
perform migration from qemu-kvm to qemu. It's just a stub for now.
This compat will break incoming migration from qemu < 1.3, but for
distros where qemu-kvm was the only shipped package for years it's
not a big loss (and I don't know
Il 19/02/2013 23:40, Cole Robinson ha scritto:
> +#ifdef CONFIG_MIGRATE_FROM_QEMU_KVM
> +/* qemu-kvm defaulted to 16MB video memory since 0.15 at least. */
> +# define OLD_VGA_MEM stringify(16)
> +#else
> +# define OLD_VGA_MEM stringify(8)
> +#endif
> +
> #define PC_COMPAT_1_2 \
> PC_COMP
On 19 February 2013 22:17, Anthony Liguori wrote:
> David Woodhouse writes:
>> On Tue, 2013-02-19 at 14:29 -0600, Anthony Liguori wrote:
>>> So should we even be resetting anything other than the CPU during soft
>>> reset?
>>
>> I suspect not. A soft reset triggered by the RCR, keyboard controlle
Il 19/02/2013 23:17, Anthony Liguori ha scritto:
>>> >> > if (val & 4) {
>>> >> > +if (val & 2)
>>> >> > +qemu_irq_pulse(d->reset_out);
>>> >> > qemu_system_reset_request();
>> >>
>> >>
>> >> This is a bit strange to me.
> >
> > The reset_out "IRQ" isn't actuall
Special case xor with self. We need not even store the known
zero into cc_src.
Signed-off-by: Richard Henderson
---
target-i386/cc_helper.c | 3 +++
target-i386/cpu.h | 2 ++
target-i386/helper.c| 2 ++
target-i386/translate.c | 17 ++---
4 files changed, 21 insertions(
diff --git a/tpm/Makefile.objs b/tpm/Makefile.objs
index 94ad2e7..8abd0f9 100644
--- a/tpm/Makefile.objs
+++ b/tpm/Makefile.objs
@@ -1,4 +1,6 @@
-common-obj-y = tpm.o
+common-obj-y = tpm.o tpm_backend.o
ifeq ($(CONFIG_TPM),y)
common-obj-$(CONFIG_TPM_TIS) += tpm_tis.o
endif
+common-obj-$(CO
On Tue, 2013-02-19 at 16:17 -0600, Anthony Liguori wrote:
> Right, this is what's strange to me. There's no hardware analog AFAICT
> so I'm not sure why we're exposing it as a qemu_irq other than we want
> to jump through a function pointer invocation instead of making a
> straight funciton call :
qemu-kvm commit 81bdec908fb2be0ccaff1d4ee67956c509e440ad did this,
but the logic can't be carried unconditionally in qemu.git without
breaking migration from qemu < 1.1.
Conditionalize it with --enable-migrate-from-qemu-kvm
Signed-off-by: Cole Robinson
---
hw/i8254_common.c | 8
1 file
Paolo outlines this here:
https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg02540.html
qemu-kvm defaulted to vgamem=16MB since at least 0.15, while qemu used
8MB. For qemu 1.2, the default was changed to 16MB for all devices
except cirrus.
If --enable-migration-from-qemu-kvm is specified,
qemu-kvm 1.2 advertised version_id=2, but it was not the same
format as qemu.git version_id=2.
commit b0b873a07872f7ab7f66f259c73fb9dd42aa66a9 added the qemu-kvm
format to qemu.git, but was forced to call it version_id=3, and
bumped minimum_version_id to 3. This breaks incoming migration from
qemu
No actual required uses of these encodings yet.
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 68 ++---
1 file changed, 64 insertions(+), 4 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index e5cda94..f82
diff --git a/tpm/tpm.c b/tpm/tpm.c
new file mode 100644
index 000..51eaf7e
--- /dev/null
+++ b/tpm/tpm.c
@@ -0,0 +1,345 @@
+/*
+ * TPM configuration
+ *
+ * Copyright (C) 2011-2013 IBM Corporation
+ *
+ * Authors:
+ * Stefan Berger
+ *
+ * This work is licensed under the terms of the GN
On 02/19/2013 04:42 PM, Corey Bryant wrote:
diff --git a/tpm/Makefile.objs b/tpm/Makefile.objs
new file mode 100644
index 000..dffb567
--- /dev/null
+++ b/tpm/Makefile.objs
@@ -0,0 +1 @@
+common-obj-y = tpm.o
diff --git a/tpm/tpm.c b/tpm/tpm.c
new file mode 100644
index 000..51eaf7e
---
From: Paolo Bonzini
This simplifies all the jump generation code. CCPrepare allows the
code to create an efficient brcond always, so there is no need to
duplicate the setcc and jcc code.
Signed-off-by: Paolo Bonzini
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 119 -
David Woodhouse writes:
> On Tue, 2013-02-19 at 14:29 -0600, Anthony Liguori wrote:
>> David Woodhouse writes:
>> > if (val & 4) {
>> > +if (val & 2)
>> > +qemu_irq_pulse(d->reset_out);
>> > qemu_system_reset_request();
>>
>>
>> This is a bit strange to me.
>
And mark the helpers as NO_RWG_SE.
Signed-off-by: Richard Henderson
---
target-i386/helper.h | 6 +++---
target-i386/int_helper.c | 45 +++--
2 files changed, 14 insertions(+), 37 deletions(-)
diff --git a/target-i386/helper.h b/target-i386/helper.h
Jesse Larrew writes:
> To ensure compatibility between qemu versions, virtio drivers should set
> the size of their config structs according to the feature bits that are
> set. This should keep the size from changing as new features are introduced
> and avoid breaking older drivers.
>
> [PATCH 1/
On 02/19/2013 05:04 PM, Corey Bryant wrote:
diff --git a/tpm/tpm.c b/tpm/tpm.c
new file mode 100644
index 000..51eaf7e
--- /dev/null
+++ b/tpm/tpm.c
@@ -0,0 +1,345 @@
+/*
+ * TPM configuration
+ *
+ * Copyright (C) 2011-2013 IBM Corporation
+ *
+ * Authors:
+ * Stefan Berger
+ *
+ * Th
From: Paolo Bonzini
Discard CC_DST and set s->cc_op immediately after computing EFLAGS.
Signed-off-by: Paolo Bonzini
Signed-off-by: Richard Henderson
---
target-i386/translate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target-i386/translate.c b/target-i386/transl
diff --git a/tpm/Makefile.objs b/tpm/Makefile.objs
new file mode 100644
index 000..dffb567
--- /dev/null
+++ b/tpm/Makefile.objs
@@ -0,0 +1 @@
+common-obj-y = tpm.o
diff --git a/tpm/tpm.c b/tpm/tpm.c
new file mode 100644
index 000..51eaf7e
--- /dev/null
+++ b/tpm/tpm.c
@@ -0,0 +1,345 @@
1 - 100 of 355 matches
Mail list logo
