[Qemu-devel] [PATCH V18 03/10] libqblock: build: add configure support

2013-02-08 Thread Wenchao Xia
Rule for libqblock.la will be included if it is enabled, and will be added to 'all' to be automatically built. Only support Linux now, to save trouble in building on windows. Signed-off-by: Wenchao Xia --- Makefile |3 +++ configure | 32 +

[Qemu-devel] [PATCH V18 08/10] libqblock: libqblock API implement

2013-02-08 Thread Wenchao Xia
This patch contains implemention for APIs. Basically it is a layer above qemu block general layer now. qb_image_new() will try do init for this library. Signed-off-by: Wenchao Xia --- libqblock/libqblock-error.c | 49 +++ libqblock/libqblock.c | 991 +

[Qemu-devel] [PATCH V18 04/10] libqblock: build: add rule for libqblock.la

2013-02-08 Thread Wenchao Xia
Now libqblock.la can be built with neccessary object files, and can be automatically cleaned by make clean in root directory. make libqblock-clean also clean it. -fvisibility=hidden was used to hide symbols, and a special macro was introduced to export symbols that marked as public. Signed-off-b

[Qemu-devel] [PATCH V18 06/10] block: export function path_has_protocol()

2013-02-08 Thread Wenchao Xia
libqblock need to use it. Signed-off-by: Wenchao Xia --- block.c |2 +- include/block/block.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 50dab8e..0736cce 100644 --- a/block.c +++ b/block.c @@ -195,7 +195,7 @@ static void

[Qemu-devel] [PATCH V18 09/10] libqblock: build: add rules for test case

2013-02-08 Thread Wenchao Xia
Libtool will be used for final link, the rules do nothing if libqblock was disabled. Temp directory was used to store image created in test, which will be deleted in clean. Signed-off-by: Wenchao Xia --- tests/Makefile |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --

[Qemu-devel] [PATCH V18 00/10] libqblock qemu block layer library

2013-02-08 Thread Wenchao Xia
These patches introduce libqblock API, make subdir-libqblock and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image. Supported

Re: [Qemu-devel] [PATCH V21 1/7] Support for TPM command line options

2013-02-08 Thread Stefan Berger
On 02/08/2013 05:01 PM, Eric Blake wrote: On 02/08/2013 02:42 PM, Stefan Berger wrote: This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev passthrough,path=,id= -device tpm-tis,tpmdev= and ./qemu-... -tpmdev ? I tho

[Qemu-devel] [Bug 1119861] [NEW] Poor console performance in Windows 7

2013-02-08 Thread Francois Gouget
Public bug reported: As part of its conformance test suite, Wine tests the behavior of the Windows console API. Part of this test involves opening a test console and scrolling things around. The test probably does not need to perform that many scroll operations to achieve its goal. However as is i

[Qemu-devel] Invalid data memory access on qemu-ppc

2013-02-08 Thread Ed Swierk
I'm using the ppc-linux-user target to run processes in a Debian Wheezy filesystem I built using multistrap. I built qemu from yesterday's head of the git tree. When I try to run a Python JSON database called jsonstore, I qemu-ppc barfs with an "Invalid data memory access", with the invalid addres

[Qemu-devel] Support for 1366x768 (720p) resolution?

2013-02-08 Thread Josh Triplett
Late last year, I saw a patch go by adding support for the unfortunately common 1366x768 resolution. Some discussion in the resulting thread suggested some possible improvements to the patch that needed to occur before merging; however, I haven't seen a newer version go by. Just wanted to check b

[Qemu-devel] [PATCH V21 6/7] Add support for cancelling of a TPM command

2013-02-08 Thread Stefan Berger
This patch adds support for cancelling an executing TPM command. In Linux for example a user can cancel a command through the TPM's sysfs 'cancel' entry using echo "1" > /sysfs/class/misc/tpm0/device/cancel This patch propagates the cancellation of a command inside a VM to the host TPM's sysfs en

Re: [Qemu-devel] [PATCH V21 7/7] Introduce --enable-tpm-passthrough configure option

2013-02-08 Thread Anthony Liguori
Stefan Berger writes: > Introduce --enable-tpm-passthrough configure option. You're duplicating the subject line here. Regards, Anthony Liguori > > Signed-off-by: Stefan Berger > --- > configure | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/configure b/configur

[Qemu-devel] [Bug 1054558] Re: 1366x768 resolution missing

2013-02-08 Thread Josh Triplett
** Bug watch added: Debian Bug tracker #700055 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700055 ** Also affects: debian via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700055 Importance: Unknown Status: Unknown -- You received this bug notification because you are a m

[Qemu-devel] [PATCH V21 2/7] Add TPM (frontend) hardware interface (TPM TIS) to QEMU

2013-02-08 Thread Stefan Berger
This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to QEMU. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support for changing of localities and all the functionalit

[Qemu-devel] [Bug 939443] Re: qemu-system-x86_64 can no support 1366x768

2013-02-08 Thread Josh Triplett
*** This bug is a duplicate of bug 1054558 *** https://bugs.launchpad.net/bugs/1054558 ** This bug has been marked a duplicate of bug 1054558 1366x768 resolution missing -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

[Qemu-devel] [PATCH V21 7/7] Introduce --enable-tpm-passthrough configure option

2013-02-08 Thread Stefan Berger
Introduce --enable-tpm-passthrough configure option. Signed-off-by: Stefan Berger --- configure | 17 + 1 file changed, 17 insertions(+) diff --git a/configure b/configure index b7359aa..b4f0a82 100755 --- a/configure +++ b/configure @@ -227,6 +227,7 @@ seccomp="" glusterfs=""

Re: [Qemu-devel] [PATCH V21 1/7] Support for TPM command line options

2013-02-08 Thread Eric Blake
On 02/08/2013 02:42 PM, Stefan Berger wrote: > This patch adds support for TPM command line options. > The command line options supported here are > > ./qemu-... -tpmdev passthrough,path=,id= >-device tpm-tis,tpmdev= > > and > > ./qemu-... -tpmdev ? I though we preferred '-tpmdev he

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Borislav Petkov
On Fri, Feb 08, 2013 at 04:23:04PM -0200, Eduardo Habkost wrote: > If you don't have the implementation of MOVBE working (and included on > TCG_EXT_FEATURES), neither your patch or "+movbe" can help you. Yes, running -cpu n270,+movbe with Richard's patchset merged works. Thanks. -- Regards/Grus

Re: [Qemu-devel] [RFC v2 5/5] qtest: Add MMIO support

2013-02-08 Thread Anthony Liguori
Andreas Färber writes: > Introduce [qtest_]{read,write}[bwlq]() libqtest functions and > corresponding QTest protocol commands to replace local versions in > libi2c-omap.c. > > Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > qtest.c |

[Qemu-devel] [PATCH V21 3/7] Add a debug register

2013-02-08 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). Signed-off-by: Stefan Berger --- tpm/tpm_tis.c | 70

[Qemu-devel] [PATCH V21 5/7] Add a TPM Passthrough backend driver implementation

2013-02-08 Thread Stefan Berger
>From Andreas Niederl's original posting with adaptations where necessary: This patch is based of off version 9 of Stefan Berger's patch series "QEMU Trusted Platform Module (TPM) integration" and adds a new backend driver for it. This patch adds a passthrough backend driver for passing command

[Qemu-devel] [PATCH V21 4/7] Build the TPM frontend code

2013-02-08 Thread Stefan Berger
Build the TPM frontend code that has been added so far. Signed-off-by: Stefan Berger --- configure | 11 +++ tpm/Makefile.objs | 1 + 2 files changed, 12 insertions(+) diff --git a/configure b/configure index 8789324..b7359aa 100755 --- a/configure +++ b/configure @@ -226,6 +22

[Qemu-devel] [PATCH V21 1/7] Support for TPM command line options

2013-02-08 Thread Stefan Berger
This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev passthrough,path=,id= -device tpm-tis,tpmdev= and ./qemu-... -tpmdev ? where the latter works similar to -soundhw ? and shows a list of available TPM backends (for exa

[Qemu-devel] [PATCH V21 0/7] QEMU Trusted Platform Module (TPM) integration

2013-02-08 Thread Stefan Berger
From: root The following series of patches adds TPM (Trusted Platform Module) support to QEMU. An emulator for the TIS (TPM Interface Spec) interface is added that provides the basis for accessing a 'backend' implementing the actual TPM functionality. The TIS emulator serves as a 'frontend' enabl

Re: [Qemu-devel] [RFC v2 5/5] qtest: Add MMIO support

2013-02-08 Thread Andreas Färber
Am 08.02.2013 22:37, schrieb Anthony Liguori: > Andreas Färber writes: > >> Introduce [qtest_]{read,write}[bwlq]() libqtest functions and >> corresponding QTest protocol commands to replace local versions in >> libi2c-omap.c. >> >> Signed-off-by: Andreas Färber > > Reviewed-by: Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4 v2 1/5] qtest: Use strtoull() for uint64_t

2013-02-08 Thread Anthony Liguori
Andreas Färber writes: > On 32-bit hosts, unsigned long may be uint32_t and uint64_t may be > unsigned long long. Account for this by always using strtoull(). > We were already using strtoll() for int64_t. > > Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori Regards, Anthony Liguor

[Qemu-devel] [PATCH for-1.4 v3 2/6] error: Clean up abuse of error_report() for help

2013-02-08 Thread Markus Armbruster
Use error_printf() instead, so the help gets presented more nicely. Signed-off-by: Markus Armbruster --- hw/vfio_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 66537b7..a934f13 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_pci.c @@ -1

[Qemu-devel] [PATCH for-1.4 v3 0/6] Error reporting fixes

2013-02-08 Thread Markus Armbruster
I tagged this for 1.4 because the patches improve the user experience a bit, and are all low risk. v3: * Fix another instance of the bug in PATCH 06 (Luiz Capitulino) v2: * Clean up messages touched by PATCH 01 some more (Peter Maydell) * The other patches are unchanged Markus Armbruster (6): e

[Qemu-devel] [PATCH for-1.4 v3 3/6] error: Strip trailing '\n' from error string arguments (again)

2013-02-08 Thread Markus Armbruster
Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming back. Tracked down with this Coccinelle semantic patch: @r@ expression err, eno, cls, fmt; position p; @@ ( error_report(fmt, ...)@p | error_set(err, cls, fmt, ...)@p |

[Qemu-devel] [Bug 1119686] [NEW] Incorrect handling of icebp

2013-02-08 Thread Francois Gouget
Public bug reported: Wine conformance suite tests the behavior of various low-level Windows API functions. One of the tests involves checking the interaction of breakpoints and exceptions, and in particular the 'icebp' breakpoint. This test works on a Windows XP machine running either on the metal

[Qemu-devel] [PATCH for-1.4 v3 5/6] vl: Drop redundant "parse error" reports

2013-02-08 Thread Markus Armbruster
qemu_opts_parse() reports the error already, and in a much more useful way. Signed-off-by: Markus Armbruster --- vl.c | 4 1 file changed, 4 deletions(-) diff --git a/vl.c b/vl.c index a8dc73d..73122d8 100644 --- a/vl.c +++ b/vl.c @@ -3334,7 +3334,6 @@ int main(int argc, char **argv, char

Re: [Qemu-devel] [PATCH] linux-user: make bogus negative iovec lengths fail EINVAL

2013-02-08 Thread Richard Henderson
On 2013-02-08 09:58, Peter Maydell wrote: If the guest passes us a bogus negative length for an iovec, fail EINVAL rather than proceeding blindly forward. This fixes some of the error cases tests for readv and writev in the LTP. Signed-off-by: Peter Maydell --- I guess I'll resend this mixed bag

Re: [Qemu-devel] [PATCH] linux-user: Implement sendfile and sendfile64

2013-02-08 Thread Richard Henderson
On 2013-02-08 09:31, Peter Maydell wrote: Implement the sendfile and sendfile64 syscalls. This implementation passes all the LTP test cases for these syscalls. Signed-off-by: Peter Maydell --- This test-driven-development thing is fun :-) configure| 17 linux-u

[Qemu-devel] [PATCH for-1.4 v3 4/6] qemu-option: Disable two helpful messages that got broken recently

2013-02-08 Thread Markus Armbruster
commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error message and the helpful explanation that should follow it, like this: $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=, Identifiers consist of letters, digits, '-', '.', '_', starting with a letter. qe

[Qemu-devel] [PATCH for-1.4 v3 6/6] vl: Exit unsuccessfully on option argument syntax error

2013-02-08 Thread Markus Armbruster
We exit successfully after reporting syntax error for argument of --sandbox and --add-fd. We continue undaunted after reporting it for argument of -boot, --option-rom and --object. Change all five to exit unsuccessfully, like the other options. Signed-off-by: Markus Armbruster --- vl.c | 16 ++

[Qemu-devel] [PATCH for-1.4 v3 1/6] error: Clean up error strings with embedded newlines

2013-02-08 Thread Markus Armbruster
The arguments of error_report() should yield a short error string without newlines. A few places try to print additional help after the error message by embedding newlines in the error string. That's nice, but let's do it the right way. Since I'm touching these lines anyway, drop a stray preposi

Re: [Qemu-devel] [PATCH] linux-user: Implement accept4

2013-02-08 Thread Richard Henderson
On 2013-02-08 06:35, Peter Maydell wrote: Implement the accept4 syscall (which is identical to accept but has an additional flags argument). Signed-off-by: Peter Maydell --- Passes all the LTP accept and accept4 tests... linux-user/syscall.c | 39 +++ 1

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Don't warn about unimplemented get_robust_list

2013-02-08 Thread Richard Henderson
On 2013-02-08 06:34, Peter Maydell wrote: The nature of the kernel ABI for the get_robust_list and set_robust_list syscalls means we cannot implement them in QEMU. Make get_robust_list silently return ENOSYS rather than using the default "print message and then fail ENOSYS" code path, in the same

Re: [Qemu-devel] [PATCH for-1.4 v2 1/6] error: Clean up error strings with embedded newlines

2013-02-08 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 08 Feb 2013 19:56:17 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Fri, 8 Feb 2013 17:17:07 +0100 >> > Markus Armbruster wrote: >> > >> >> The arguments of error_report() should yield a short error string >> >> without newlines. >>

Re: [Qemu-devel] [PATCH for-1.4 v2 4/6] qemu-option: Disable two helpful messages that got broken recently

2013-02-08 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 08 Feb 2013 19:58:42 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Fri, 8 Feb 2013 17:17:10 +0100 >> > Markus Armbruster wrote: >> > >> >> commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error >> >> message and the he

Re: [Qemu-devel] [PATCH for-1.4 v2 4/6] qemu-option: Disable two helpful messages that got broken recently

2013-02-08 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 8 Feb 2013 17:17:10 +0100 > Markus Armbruster wrote: > >> commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error >> message and the helpful explanation that should follow it, like this: >> >> $ qemu-system-x86_64 --nodefaults -S --vnc :0 --cha

Re: [Qemu-devel] [PATCH for-1.4 stable] block/curl: disable extra protocols to prevent CVE-2013-0249

2013-02-08 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 3/4] This patch adds new qemu-img subcommand that compares content of two disk images.

2013-02-08 Thread Eric Blake
On 02/08/2013 01:33 AM, Miroslav Rezanina wrote: > This patch adds new qemu-img subcommand that compares content of two disk > images. > > +static int64_t sectors_to_process(int64_t total, int64_t from) > +{ > +return MIN((total - from), (IO_BUF_SIZE >> BDRV_SECTOR_BITS)); Why the spurious (

Re: [Qemu-devel] [PATCH for-1.4 v2 0/6] Error reporting fixes

2013-02-08 Thread Luiz Capitulino
On Fri, 08 Feb 2013 19:59:55 +0100 Markus Armbruster wrote: > Luiz, would you like to take v3 through your tree? In that case I'd > drop qemu-trivial. Yes, I can do it.

Re: [Qemu-devel] [PATCH for-1.4 v2 4/6] qemu-option: Disable two helpful messages that got broken recently

2013-02-08 Thread Luiz Capitulino
On Fri, 08 Feb 2013 19:58:42 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Fri, 8 Feb 2013 17:17:10 +0100 > > Markus Armbruster wrote: > > > >> commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error > >> message and the helpful explanation that should follow i

Re: [Qemu-devel] [PATCH for-1.4] net: fix infinite loop on exit

2013-02-08 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4 v2 1/6] error: Clean up error strings with embedded newlines

2013-02-08 Thread Luiz Capitulino
On Fri, 08 Feb 2013 19:56:17 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Fri, 8 Feb 2013 17:17:07 +0100 > > Markus Armbruster wrote: > > > >> The arguments of error_report() should yield a short error string > >> without newlines. > >> > >> A few places try to print add

Re: [Qemu-devel] [PATCH V2 0/3] set config size using available features

2013-02-08 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/2] virtio-net: fix config size for older guests

2013-02-08 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4 v2 0/6] Error reporting fixes

2013-02-08 Thread Markus Armbruster
Luiz, would you like to take v3 through your tree? In that case I'd drop qemu-trivial.

Re: [Qemu-devel] [PATCH for-1.4] xilinx_zynq: Fix wrong IRQ number of the second EHCI controller

2013-02-08 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for 1.4] qemu-nbd: document --cache and --aio options

2013-02-08 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4 v2 1/6] error: Clean up error strings with embedded newlines

2013-02-08 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 8 Feb 2013 17:17:07 +0100 > Markus Armbruster wrote: > >> The arguments of error_report() should yield a short error string >> without newlines. >> >> A few places try to print additional help after the error message by >> embedding newlines in the error strin

Re: [Qemu-devel] [PATCH for-1.4 v2 6/6] vl: Exit unsuccessfully on option argument syntax error

2013-02-08 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 8 Feb 2013 17:17:12 +0100 > Markus Armbruster wrote: > >> We exit successfully after reporting syntax error for argument of >> --sandbox and --add-fd. >> >> We continue undaunted after reporting it for argument of --option-rom >> and --object then. >> >> Chan

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 06:35:56PM +0100, Borislav Petkov wrote: > On Fri, Feb 08, 2013 at 01:58:58PM -0200, Eduardo Habkost wrote: > > [ … ] > > > As we don't have a decent method to do that today, we are using static > > variables and compatibility-setup functions called from the machine init >

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 05:54:50PM +0100, Andreas Färber wrote: > Am 08.02.2013 15:52, schrieb Eduardo Habkost: > > On Fri, Feb 08, 2013 at 01:58:42PM +0100, Igor Mammedov wrote: > >> On Fri, 08 Feb 2013 12:16:17 +0100 > >> Andreas Färber wrote: > >>> Am 08.02.2013 10:03, schrieb Igor Mammedov: >

Re: [Qemu-devel] [PATCH 4/4] qemu-iotests: Add qemu-img compare test

2013-02-08 Thread Eric Blake
On 02/08/2013 01:33 AM, Miroslav Rezanina wrote: > Simple test for qemu-img compare to check it's working correctly. > > Signed-off-by: Miroslav Rezanina > --- > tests/qemu-iotests/048 | 77 > > tests/qemu-iotests/048.out | 25 ++

Re: [Qemu-devel] [PATCH for-1.4 v2 6/6] vl: Exit unsuccessfully on option argument syntax error

2013-02-08 Thread Luiz Capitulino
On Fri, 8 Feb 2013 17:17:12 +0100 Markus Armbruster wrote: > We exit successfully after reporting syntax error for argument of > --sandbox and --add-fd. > > We continue undaunted after reporting it for argument of --option-rom > and --object then. > > Change all four to exit unsuccessfully, li

[Qemu-devel] [PATCH] linux-user: make bogus negative iovec lengths fail EINVAL

2013-02-08 Thread Peter Maydell
If the guest passes us a bogus negative length for an iovec, fail EINVAL rather than proceeding blindly forward. This fixes some of the error cases tests for readv and writev in the LTP. Signed-off-by: Peter Maydell --- I guess I'll resend this mixed bag of linux-user patches as a single series a

Re: [Qemu-devel] [PATCH for-1.4 v2 5/6] vl: Drop redundant "parse error" reports

2013-02-08 Thread Luiz Capitulino
On Fri, 8 Feb 2013 17:17:11 +0100 Markus Armbruster wrote: > qemu_opts_parse() reports the error already, and in a much more useful > way. > > Signed-off-by: Markus Armbruster Reviewed-by: Luiz Capitulino > --- > vl.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/vl.c b/vl.c

Re: [Qemu-devel] [RFC qom-cpu v2 03/28] target-arm: Update ARMCPU to QOM realizefn

2013-02-08 Thread Andreas Färber
Am 08.02.2013 18:35, schrieb Peter Maydell: > On 8 February 2013 17:31, Andreas Färber wrote: >> Am 07.02.2013 19:56, schrieb Peter Maydell: >>> An idle thought: I wonder if we could rearrange things so that >>> the target-specific TCG init is called via tcg_init(), to >>> parallel the way that ta

Re: [Qemu-devel] [PATCH for-1.4 v2 4/6] qemu-option: Disable two helpful messages that got broken recently

2013-02-08 Thread Luiz Capitulino
On Fri, 8 Feb 2013 17:17:10 +0100 Markus Armbruster wrote: > commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error > message and the helpful explanation that should follow it, like this: > > $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=, > Identifiers co

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-08 Thread Stefan Weil
Am 08.02.2013 13:14, schrieb Jeff Cody: > On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote: >> Am 07.02.2013 20:26, schrieb Stefan Weil: >>> From: Stefan Weil >>> >>> The size calculated from the CHS values is not the real image (disk) size, >>> but usually a smaller value. This is cause

Re: [Qemu-devel] [PATCH for-1.4 v2 3/6] error: Strip trailing '\n' from error string arguments (again)

2013-02-08 Thread Luiz Capitulino
On Fri, 8 Feb 2013 17:17:09 +0100 Markus Armbruster wrote: > Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming > back. Tracked down with this Coccinelle semantic patch: > > @r@ > expression err, eno, cls, fmt; > position p; > @@ > ( > error_rep

Re: [Qemu-devel] [PATCH for-1.4 v2 1/6] error: Clean up error strings with embedded newlines

2013-02-08 Thread Luiz Capitulino
On Fri, 8 Feb 2013 17:17:07 +0100 Markus Armbruster wrote: > The arguments of error_report() should yield a short error string > without newlines. > > A few places try to print additional help after the error message by > embedding newlines in the error string. That's nice, but let's do it > t

Re: [Qemu-devel] [PATCH] target-mips: fix for sign-issue in MULQ_W helper

2013-02-08 Thread Richard Henderson
On 2013-02-07 10:36, Petar Jovanovic wrote: From: Petar Jovanovic Correct sign-propagation before multiplication in MULQ_W helper. The change also fixes previously incorrect expected values in the tests for MULQ_RS.W and MULQ_S.W. Signed-off-by: Petar Jovanovic --- target-mips/dsp_helper.c

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Borislav Petkov
On Fri, Feb 08, 2013 at 01:58:58PM -0200, Eduardo Habkost wrote: [ … ] > As we don't have a decent method to do that today, we are using static > variables and compatibility-setup functions called from the machine init > function. See disable_kvm_pv_eoi() for example. > > One day we will be able

Re: [Qemu-devel] [RFC qom-cpu v2 03/28] target-arm: Update ARMCPU to QOM realizefn

2013-02-08 Thread Peter Maydell
On 8 February 2013 17:31, Andreas Färber wrote: > Am 07.02.2013 19:56, schrieb Peter Maydell: >> An idle thought: I wonder if we could rearrange things so that >> the target-specific TCG init is called via tcg_init(), to >> parallel the way that target-specific KVM init is called >> via kvm_init()

[Qemu-devel] [PATCH] linux-user: Implement sendfile and sendfile64

2013-02-08 Thread Peter Maydell
Implement the sendfile and sendfile64 syscalls. This implementation passes all the LTP test cases for these syscalls. Signed-off-by: Peter Maydell --- This test-driven-development thing is fun :-) configure| 17 linux-user/syscall.c | 53

Re: [Qemu-devel] [RFC qom-cpu v2 03/28] target-arm: Update ARMCPU to QOM realizefn

2013-02-08 Thread Andreas Färber
Am 07.02.2013 19:56, schrieb Peter Maydell: > On 7 February 2013 18:44, Andreas Färber wrote: >> Am 07.02.2013 17:31, schrieb Eduardo Habkost: >>> My first question I had when I saw this was: are you really sure it is >>> safe to call cpu_reset() and qemu_init_vcpu() before >>> arm_translate_init(

Re: [Qemu-devel] [PATCH v2 00/15] propagate Errors to do_device_add()

2013-02-08 Thread Luiz Capitulino
On Tue, 5 Feb 2013 21:39:13 +0100 Laszlo Ersek wrote: > In v2, I'm mostly attempting to address Luiz's comments for v1: Apart from minor comments, looks good to me. Not sure if I did a good job on trying to suggest you a better splitting though. Also, I think it's a good idea for someone more

[Qemu-devel] [PATCH for-1.4 v2 1/6] error: Clean up error strings with embedded newlines

2013-02-08 Thread Markus Armbruster
The arguments of error_report() should yield a short error string without newlines. A few places try to print additional help after the error message by embedding newlines in the error string. That's nice, but let's do it the right way. Since I'm touching these lines anyway, drop a stray preposi

[Qemu-devel] [PATCH for-1.4 v2 2/6] error: Clean up abuse of error_report() for help

2013-02-08 Thread Markus Armbruster
Use error_printf() instead, so the help gets presented more nicely. Signed-off-by: Markus Armbruster --- hw/vfio_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 66537b7..a934f13 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_pci.c @@ -1

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread H. Peter Anvin
This is problematic since the n270 qemu model won't boot a real kernel compiled for that box. Eduardo Habkost wrote: >On Fri, Feb 08, 2013 at 10:30:02AM +0100, Borislav Petkov wrote: >> From: Borislav Petkov >> >> The Atom core (cpu name "n270" in QEMU speak) supports MOVBE. This is >> needed

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom size to 8192

2013-02-08 Thread Cole Robinson
On 02/08/2013 04:36 AM, Gerd Hoffmann wrote: > Hi, > >>> foo.img generated with stock qemu 1.3.1, migration fails with git >>> head, still >>> fails after reverting the seabios 1.7.2 update which supposedly >>> causes other >>> migrate issues (commit 3588185b8396eb97fd9efd41c2b97775465f67c4) >>

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-08 Thread Stefan Weil
Am 08.02.2013 09:18, schrieb Stefan Hajnoczi: > On Thu, Feb 07, 2013 at 08:26:52PM +0100, Stefan Weil wrote: >> From: Stefan Weil > Should be "From: Stefan Weil "? Yes, of course. Maybe whoever applies the patch can fix this, please. Thanks, Stefan W.

Re: [Qemu-devel] [PATCH 2/4] qemu-img: Add "Quiet mode" option

2013-02-08 Thread Eric Blake
On 02/08/2013 01:33 AM, Miroslav Rezanina wrote: > There can be a need to turn output to stdout off. This patch adds a -q option > that enable "Quiet mode". In Quiet mode, only errors are printed out. > > Signed-off-by: Miroslav Rezanina > --- > > if (result.bfi.total_clusters != 0 && resu

[Qemu-devel] [PATCH for-1.4 v2 4/6] qemu-option: Disable two helpful messages that got broken recently

2013-02-08 Thread Markus Armbruster
commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error message and the helpful explanation that should follow it, like this: $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=, Identifiers consist of letters, digits, '-', '.', '_', starting with a letter. qe

[Qemu-devel] [PATCH for-1.4 v2 0/6] Error reporting fixes

2013-02-08 Thread Markus Armbruster
I tagged this for 1.4 because the patches improve the user experience a bit, and are all low risk. v2: * Clean up messages touched by PATCH 01 some more (Peter Maydell) * The other patches are unchanged Markus Armbruster (6): error: Clean up error strings with embedded newlines error: Clean u

[Qemu-devel] [PATCH for-1.4 v2 5/6] vl: Drop redundant "parse error" reports

2013-02-08 Thread Markus Armbruster
qemu_opts_parse() reports the error already, and in a much more useful way. Signed-off-by: Markus Armbruster --- vl.c | 4 1 file changed, 4 deletions(-) diff --git a/vl.c b/vl.c index a8dc73d..73122d8 100644 --- a/vl.c +++ b/vl.c @@ -3334,7 +3334,6 @@ int main(int argc, char **argv, char

Re: [Qemu-devel] [PATCH 0/4] Add subcommand compare for qemu-img

2013-02-08 Thread Eric Blake
On 02/08/2013 01:33 AM, Miroslav Rezanina wrote: > This is 9th version of patch adding compare subcommand that > compares two images. Compare has following criteria: > - only data part is compared > - unallocated sectors are not read > to be zeroed/unallocated to compare rest > - qemu-img retur

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-08 Thread Andreas Färber
Am 08.02.2013 15:52, schrieb Eduardo Habkost: > On Fri, Feb 08, 2013 at 01:58:42PM +0100, Igor Mammedov wrote: >> On Fri, 08 Feb 2013 12:16:17 +0100 >> Andreas Färber wrote: >>> Am 08.02.2013 10:03, schrieb Igor Mammedov: On Thu, 7 Feb 2013 13:08:19 -0200 Eduardo Habkost wrote: >>>

Re: [Qemu-devel] Set Spice audio without envvar

2013-02-08 Thread Gerd Hoffmann
On 02/08/13 16:19, Fabio Fantoni wrote: > Is possible to set spice audio without envvar but with qemu parameter? Should not be needed. With spice enabled qemu will automatically pick spice audio as default, without spice whatever else comes first in the list (alsa probably, but depends on which d

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Richard Henderson
On 2013-02-08 03:38, Andreas Färber wrote: Otherwise if someone can ack (or if you can point me to a manual), this looks like a good bugfix for v1.4. CC'ing some more CPU'ish people. It wouldn't be a bug fix without extracting the patch out of my x86-next tree that actually implements movbe. I

[Qemu-devel] [Bug 1119281] [NEW] The virtio network device breaks UuidCreateSequential()

2013-02-08 Thread Francois Gouget
Public bug reported: UuidCreateSequential() usually creates version 1 UUIDs (1) which means they contain the main network card's MAC address. However when using a virtio network card and driver the UUIDs contain random data instead of the guest's MAC address. Changing the network card to either th

Re: [Qemu-devel] [RFC V6 00/33] QCOW2 deduplication core functionality

2013-02-08 Thread Eric Blake
On 02/08/2013 06:49 AM, Stefan Hajnoczi wrote: > On Wed, Feb 06, 2013 at 01:31:33PM +0100, Benoît Canet wrote: >> This patchset create the core infrastructure for deduplication and enable it. > > Here is a high-level overview of qcow2 dedup for others reviewing this series: Awesome. Benoît, how

[Qemu-devel] request for mediawiki account / RDMA documentation

2013-02-08 Thread Michael R. Hines
Hi, According to the website, I should ask here for someone to make a wiki account for me? I would like to post documentation of the RDMA patches I'm preparing. Thanks, - Michael R. Hines

[Qemu-devel] [PATCH for-1.4 v2 3/6] error: Strip trailing '\n' from error string arguments (again)

2013-02-08 Thread Markus Armbruster
Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming back. Tracked down with this Coccinelle semantic patch: @r@ expression err, eno, cls, fmt; position p; @@ ( error_report(fmt, ...)@p | error_set(err, cls, fmt, ...)@p |

[Qemu-devel] [PATCH for-1.4 v2 6/6] vl: Exit unsuccessfully on option argument syntax error

2013-02-08 Thread Markus Armbruster
We exit successfully after reporting syntax error for argument of --sandbox and --add-fd. We continue undaunted after reporting it for argument of --option-rom and --object then. Change all four to exit unsuccessfully, like the other options. Signed-off-by: Markus Armbruster --- vl.c | 10

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 04:34:58PM +0100, Borislav Petkov wrote: > On Fri, Feb 08, 2013 at 01:19:02PM -0200, Eduardo Habkost wrote: > > "-machine pc-1.3 -cpu n270" (and older machine-types) needs to keep > > MOVBE disabled, or you will break live migration. > > > > Personally I wouldn't mind declar

Re: [Qemu-devel] [PATCH v9 1/3] hw: introduce standard SD host controller

2013-02-08 Thread Peter Maydell
On 7 February 2013 06:50, Peter Crosthwaite wrote: > From: Igor Mitsyanko > > Device model for standard SD Host Controller Interface (SDHCI) compliant with > version 2.00 of SD association specification. > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Igor Mitsyanko Reviewed-by: Peter Ma

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Borislav Petkov
On Fri, Feb 08, 2013 at 01:19:02PM -0200, Eduardo Habkost wrote: > "-machine pc-1.3 -cpu n270" (and older machine-types) needs to keep > MOVBE disabled, or you will break live migration. > > Personally I wouldn't mind declaring n270 as a non-migratable CPU > model. But libvirt supports n270, so it

[Qemu-devel] Set Spice audio without envvar

2013-02-08 Thread Fabio Fantoni
Is possible to set spice audio without envvar but with qemu parameter? I'm writing patch to add spice audio support to xen. Here is one reply from xen-devel: Setting envvars to configure qemu is a pretty crappy interface though, given that qemu supports both command line and configuration files

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Paolo Bonzini
Il 08/02/2013 16:10, Eduardo Habkost ha scritto: > On Fri, Feb 08, 2013 at 02:59:25PM +0100, Paolo Bonzini wrote: >> Il 08/02/2013 14:44, Andreas Färber ha scritto: >>> Otherwise if someone can ack (or if you can point me to a manual), this >>> looks like a good bugfix for v1.4. > >

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 10:30:02AM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > The Atom core (cpu name "n270" in QEMU speak) supports MOVBE. This is > needed when booting 3.8 and later linux kernels built with the MATOM > target because we require MOVBE in order to boot properly now

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 02:59:25PM +0100, Paolo Bonzini wrote: > Il 08/02/2013 14:44, Andreas Färber ha scritto: > >>> >> Otherwise if someone can ack (or if you can point me to a manual), this > >>> >> looks like a good bugfix for v1.4. > >> > > >> > Right, I don't know what v1.4 is > > It's the

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 12:52:31PM -0200, Eduardo Habkost wrote: > On Fri, Feb 08, 2013 at 01:58:42PM +0100, Igor Mammedov wrote: [...] > > Continuing on theoretical issue: > > > We could add an inited field to X86CPUClass that gets checked at initfn > > > time (only ever getting set to true by the

[Qemu-devel] [PATCH V3 2/2] virtio-block: support auto-sensing of block sizes

2013-02-08 Thread Einar Lueck
Virtio-blk does not impose fixed block sizes for access to backing devices. This patch introduces support for auto lookup of the block sizes of the backing block device. This automatic lookup needs to be enabled explicitly. Users may do this by specifying (physical|logical)_block_size=0. Machine ty

[Qemu-devel] [PATCH V3 1/2] hd-geometry.c: Integrate HDIO_GETGEO in guessing for target-s390x

2013-02-08 Thread Einar Lueck
This patch extends the function hd_geometry_guess. It introduces a target specific hook. The default implementation for this target specific hook is empty, has therefore no effect and the existing logic works as before. For target-s390x, the behaviour is chosen as follows: If no geo could be guesse

[Qemu-devel] [PATCH V3 0/2] hd-geometry.c: Integrate HDIO_GETGEO in guessing

2013-02-08 Thread Einar Lueck
Hi, here is a reworked version. V2->V3: * introduced a hook for target specific geoemtry guessing ** target-s390x: as suggested in previous patch ** all other: like before Einar Lueck (2): hd-geometry.c: Integrate HDIO_GETGEO in guessing for target-s390x virtio-block: support auto-sensing of

  1   2   >