Re: [Qemu-devel] [PATCHv2 0/2] virtio-net: mq feature fixes

2013-02-07 Thread Amos Kong
On Thu, Feb 07, 2013 at 11:26:03AM +0200, Michael S. Tsirkin wrote: > mq feature is not needed: we can look at the number of queues and set > the flag accordingly. > Removing this feature removes ambiguity (what does it mean to have > queues=2 with mq=off?). > > Changes from v1: > - split the patc

Re: [Qemu-devel] Sigsegv error when create JVM, called by bdrv_create in block.c

2013-02-07 Thread harryxiyou
On Fri, Feb 8, 2013 at 12:11 AM, Peter Maydell wrote: > On 7 February 2013 16:08, Stefan Hajnoczi wrote: >> On Thu, Feb 7, 2013 at 3:12 PM, harryxiyou wrote: >>> The above debug info show jni will be used in coroutine. I do not >>> familay with coroutine, however I guess if coroutine not allow t

[Qemu-devel] [PATCH v1 5/6] a9mpcore: remove old_timer_status field

2013-02-07 Thread Peter Crosthwaite
This field was write only and thus unused. Removed. Signed-off-by: Peter Crosthwaite --- hw/a9mpcore.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/a9mpcore.c b/hw/a9mpcore.c index 6520c24..4523074 100644 --- a/hw/a9mpcore.c +++ b/hw/a9mpcore.c @@ -16,7

[Qemu-devel] [PATCH v1 3/6] arm: *mpcore.c: CamelCased type names

2013-02-07 Thread Peter Crosthwaite
To conform with QEMU coding style. Signed-off-by: Peter Crosthwaite --- hw/a9mpcore.c| 26 +- hw/arm11mpcore.c | 20 ++-- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/hw/a9mpcore.c b/hw/a9mpcore.c index 1f6c985..6ad7c6d 100644

[Qemu-devel] [PATCH v1 4/6] arm: mptimer: Remove WDT distinction

2013-02-07 Thread Peter Crosthwaite
In QEMU emulation, there is no functional difference between the ARM mpcore private timers and watchdogs. Removed all the distinction between the two from arm_mptimer.c and converted it to be just the mptimer. a9mpcore and arm11mpcore just instantiate the same mptimer object twice to get both timer

[Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-07 Thread Peter Crosthwaite
The DeviceState *mptimer var in a9mp_priv_state was only used by the init function and had no reason for persistence. Made a local variable and removed from state struct. Signed-off-by: Peter Crosthwaite --- hw/a9mpcore.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH v1 6/6] arm: a9mpcore: Coreify the SCU

2013-02-07 Thread Peter Crosthwaite
Split the SCU in a9mpcore out into its own object definition. mpcore is now just a container for the mpcore components. Signed-off-by: Peter Crosthwaite --- hw/a9mpcore.c| 119 +++-- hw/a9scu.c | 162 +++

[Qemu-devel] [PATCH v1 1/6] arm: mptimer: CamelCased type names

2013-02-07 Thread Peter Crosthwaite
Trivial find replace on type names "timerblock" and "arm_mptimer_state" to conform with QEMU coding style. Signed-off-by: Peter Crosthwaite --- hw/arm_mptimer.c | 56 +++--- 1 files changed, 28 insertions(+), 28 deletions(-) diff --git a/hw/arm

[Qemu-devel] [PATCH v1 0/6] Cleanup of ARM MPCore

2013-02-07 Thread Peter Crosthwaite
Patches 1-3 and 5 are trivial code cleanup and may be candidate to go via trivial queue inpdependent of review of this work. Patch 4 unifies the MPTimer and WDT into one device. My motivation for doing this is so I can dynamically create one without the other (Im throwing away MPCore altogether

[Qemu-devel] [PATCH v9 3/3] xilinx_zynq: added pl330 to machine model

2013-02-07 Thread Peter Crosthwaite
Signed-off-by: Peter Crosthwaite --- hw/xilinx_zynq.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index 0ac33b5..f826bff 100644 --- a/hw/xilinx_zynq.c +++ b/hw/xilinx_zynq.c @@ -35,6 +35,10 @@ #define IRQ

[Qemu-devel] [PATCH v9 2/3] pl330: Initial version

2013-02-07 Thread Peter Crosthwaite
Device model for Primecell PL330 dma controller. Signed-off-by: Peter Crosthwaite Signed-off-by: Kirill Batuzov Tested-by: Igor Mitsyanko --- changed from v9: s/sysbus_from_qdev/SYS_BUS_DEVICE (rebase) Fixed include names (rebase) Reworked debug instrumentation Added level 2 debug hexdumper (du

[Qemu-devel] [PATCH v9 1/3] iov: Factor out hexdumper

2013-02-07 Thread Peter Crosthwaite
Factor out the hexdumper functionality from iov for all to use. Useful for creating verbose debug printfery that dumps packet data. Signed-off-by: Peter Crosthwaite --- include/qemu/hexdump.h |3 +++ util/Makefile.objs |1 + util/hexdump.c | 45

[Qemu-devel] [PATCH v9 0/3] Xilinx Zynq PL330 support

2013-02-07 Thread Peter Crosthwaite
These patches add support for the Primcell PL330 DMA controller and add it to the Xilinx Zynq machine model. Patch 2 is the device model. Patch 3 is the machine model update. Patch 1 is a helper function for debug mode. The Device model was originally contributed by Kirill Batuzov / Samsung, as

Re: [Qemu-devel] [PATCH v12 rebased 2/8] start vm after resetting it

2013-02-07 Thread Marcelo Tosatti
On Wed, Jan 23, 2013 at 03:19:23PM +0800, Hu Tao wrote: > From: Wen Congyang > > The guest should run after resetting it, but it does not run if its > old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. > > We don't set runstate to RUN_STATE_PAUSED when resetting the guest, > so the runst

Re: [Qemu-devel] [PATCH] m25p80.c: Use QOM classes for part differentiation

2013-02-07 Thread Peter Crosthwaite
On Thu, Feb 7, 2013 at 8:40 PM, Andreas Färber wrote: > Am 07.02.2013 06:51, schrieb Peter Crosthwaite: >> Currently, M25P80 uses an object property to differentiate between flash >> parts. >> Changed this over to use QOM sub-classes - the actual names of the different >> parts >> are used to cr

Re: [Qemu-devel] [PATCH v12 rebased] kvm: notify host when the guest is panicked

2013-02-07 Thread Marcelo Tosatti
Hi, On Wed, Jan 23, 2013 at 03:19:21PM +0800, Hu Tao wrote: > We can know the guest is panicked when the guest runs on xen. > But we do not have such feature on kvm. > > Another purpose of this feature is: management app(for example: > libvirt) can do auto dump when the guest is panicked. If mana

Re: [Qemu-devel] [PATCH v1 0/2] DTC as submodule

2013-02-07 Thread Peter Crosthwaite
On Thu, Feb 7, 2013 at 9:24 PM, Andreas Färber wrote: > Am 07.02.2013 07:08, schrieb Peter Crosthwaite: >> These two patches add and use dtc as a submodule as per the RFC: >> >> http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg05000.html >> >> There is a remaining action item to mandate lib

Re: [Qemu-devel] [PATCH v12 rebased 1/8] preserve cpu runstate

2013-02-07 Thread Marcelo Tosatti
On Wed, Jan 23, 2013 at 03:19:22PM +0800, Hu Tao wrote: > This patch enables preservation of cpu runstate during save/load vm. > So when a vm is restored from snapshot, the cpu runstate is restored, > too. > > See following example: > > # save two vms: one is running, the other is paused > (qemu)

Re: [Qemu-devel] [RFC PATCH v1] iov: Factor out hexdumper

2013-02-07 Thread Peter Crosthwaite
On Thu, Feb 7, 2013 at 6:56 PM, Stefan Hajnoczi wrote: > On Thu, Feb 07, 2013 at 04:22:02PM +1000, Peter Crosthwaite wrote: >> diff --git a/util/hexdump.c b/util/hexdump.c >> new file mode 100644 >> index 000..38d64ca >> --- /dev/null >> +++ b/util/hexdump.c >> @@ -0,0 +1,23 @@ > > License/cop

Re: [Qemu-devel] [RFC V2 7/7] qmp: Add block-dedup-control.

2013-02-07 Thread Eric Blake
On 02/06/2013 05:32 AM, Benoît Canet wrote: > --- > blockdev.c | 20 > qapi-schema.json | 19 +++ > qmp-commands.hx | 25 + > 3 files changed, 64 insertions(+) > > +++ b/qapi-schema.json > @@ -812,6 +812,25 @@ > ## > { '

[Qemu-devel] [PATCH 0/2] virtio-net config_size cleanups

2013-02-07 Thread Jesse Larrew
This patch set includes some minor cleanups requested by the community for the virtio-net config size solution. [PATCH 1/2] hw/virtio-net: use existing macros to implement endof [PATCH 2/2] hw/virtio-net: fix config_size data type

Re: [Qemu-devel] [PATCH v3 20/20] arm: add Faraday FTSPI020 SPI flash controller support

2013-02-07 Thread Peter Crosthwaite
On Thu, Feb 7, 2013 at 10:13 PM, Andreas Färber wrote: > Am 07.02.2013 13:04, schrieb Peter Maydell: >> On 7 February 2013 11:50, Andreas Färber wrote: >>> Am 07.02.2013 07:59, schrieb Kuo-Jung Su: >> +/** >> + *

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: >> Currently, the config size for virtio devices is hard coded. When a new >> feature is added that changes the config size, drivers that assume a static >> config size will break. For purposes of backwar

Re: [Qemu-devel] [RFC qom-cpu v2 06/28] target-ppc: Update PowerPCCPU to QOM realizefn

2013-02-07 Thread Eduardo Habkost
On Sun, Jan 20, 2013 at 08:22:29AM +0100, Andreas Färber wrote: > Adapt ppc_cpu_realize() signature, hook it up to DeviceClass and set > realized = true in cpu_ppc_init(). > > Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost > --- > target-ppc/cpu-qom.h|2 ++ > target-p

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Stefan Hajnoczi
On Thu, Feb 7, 2013 at 4:55 PM, Anthony Liguori wrote: > Stefan Hajnoczi writes: > >> On Thu, Feb 7, 2013 at 3:43 PM, Laszlo Ersek wrote: >>> Instead, what about >>> >>> #define endof(container, field) \ >>> (offsetof(container, field) + sizeof ((container *)0)->field) >> >> As mentioned in

[Qemu-devel] qemu patch for disabling tcg

2013-02-07 Thread Claudio Fontana
Hello, there was a proposed patch by Paolo Bonzini some time ago about adding an option to qemu to disable tcg: https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02568.html Is there some plan to integrate it? Paolo, do you have a newer version that applies cleanly to mainline? Thanks,

Re: [Qemu-devel] What limitions when run in coroutine mode ?

2013-02-07 Thread Stefan Hajnoczi
On Thu, Feb 7, 2013 at 11:13 AM, Kang Hua wrote: > HI all : > I write a new block driver based on hdfs of hadoop, it need to connect > to hdfs when create step (called by bdrv_create in block.c) by use libhdfs ( > hdfs c++ api) 。 Please don't send duplicate emails to the list. Stefan

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2013-02-07 Thread Brian Murray
Hello Klaus, or anyone else affected, Accepted qemu-kvm into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/qemu-kvm/1.2.0 +noroms-0ubuntu2.12.10.3 in a few hours, and then in the -proposed repository. Please help us by testing this new packag

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 03:15:42PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Feb 07, 2013 at 11:46:55AM -0600, Anthony Liguori wrote: > > > > So why do we add extra code who's sole effect is breaking old > > windows drivers? > > A little dramatic, no? > > > I li

[Qemu-devel] [PATCH 2/2] hw/virtio-net: fix config_size data type

2013-02-07 Thread Jesse Larrew
Since the new config_size member of struct VirtIONet specifies a size, it should be declared as size_t. Signed-off-by: Jesse Larrew --- hw/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 663f33c..573c669 100644 --- a/hw/vir

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 1/6] cpu: Register VMStateDescription through CPUState

2013-02-07 Thread Eduardo Habkost
On Thu, Feb 07, 2013 at 06:20:52PM +0100, Andreas Färber wrote: > Am 07.02.2013 17:40, schrieb Eduardo Habkost: > > On Sat, Feb 02, 2013 at 04:04:11PM +0100, Andreas Färber wrote: > >> In comparison to DeviceClass::vmsd, CPU VMState is split in two, > >> "cpu_common" and "cpu", and uses cpu_index a

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Thu, Feb 07, 2013 at 11:46:55AM -0600, Anthony Liguori wrote: > > So why do we add extra code who's sole effect is breaking old > windows drivers? A little dramatic, no? > I like the idea but why add code for status and mac features? Because it's correct and t

Re: [Qemu-devel] [RFC V6 32/33] qemu-iotests: Filter dedup=on/off so existing tests don't break.

2013-02-07 Thread Eric Blake
On 02/06/2013 05:32 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > tests/qemu-iotests/common.rc |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc > index aef5f52..72e746d 100644 > --- a/tests/q

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 11:46:55AM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Feb 07, 2013 at 09:45:54AM -0600, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> This is about bug-for-bug compatibility with older QEMU. > > > > Sorry, with which v

[Qemu-devel] [PATCH 1/2] hw/virtio-net: use existing macros to implement endof

2013-02-07 Thread Jesse Larrew
Clarify the definition of endof() by using the offsetof() and sizeof() macros to handle the pointer magic. Signed-off-by: Jesse Larrew --- hw/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 8f521b3..663f33c 100644 --- a/hw/

[Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-07 Thread Stefan Weil
From: Stefan Weil The size calculated from the CHS values is not the real image (disk) size, but usually a smaller value. This is caused by rounding effects. Only older operating systems use CHS. Such guests won't be able to use the whole disk. All modern operating systems use the real size. Th

Re: [Qemu-devel] [PATCH v9 0/3] Standard SD host controller model

2013-02-07 Thread Peter Maydell
On 7 February 2013 18:57, Igor Mitsyanko wrote: > So, this SDHCI implementation is working and it couldn't lock-up QEMU, It'd > be really great to have it merged during next development window. Any issues > we have we can address later. Well, our quality bar should be higher than "it doesn't hang

Re: [Qemu-devel] [RFC qom-cpu v2 03/28] target-arm: Update ARMCPU to QOM realizefn

2013-02-07 Thread Peter Maydell
On 7 February 2013 18:44, Andreas Färber wrote: > Am 07.02.2013 17:31, schrieb Eduardo Habkost: >> My first question I had when I saw this was: are you really sure it is >> safe to call cpu_reset() and qemu_init_vcpu() before >> arm_translate_init()? >> >> But I see that you change this on commit

Re: [Qemu-devel] [PATCH v9 0/3] Standard SD host controller model

2013-02-07 Thread Igor Mitsyanko
So, this SDHCI implementation is working and it couldn't lock-up QEMU, It'd be really great to have it merged during next development window. Any issues we have we can address later. On 02/07/2013 10:50 AM, Peter Crosthwaite wrote: [Original cover by Igor] First patch introduces standard SD

Re: [Qemu-devel] Sigsegv error when create JVM, called by bdrv_create in block.c

2013-02-07 Thread Peter Maydell
On 7 February 2013 16:08, Stefan Hajnoczi wrote: > On Thu, Feb 7, 2013 at 3:12 PM, harryxiyou wrote: >> The above debug info show jni will be used in coroutine. I do not >> familay with coroutine, however I guess if coroutine not allow to >> spawn a new thread? ,or it's stack corrupte with java j

Re: [Qemu-devel] [PATCH v2 07/15] set_property(): push error handling to callers

2013-02-07 Thread Luiz Capitulino
On Tue, 5 Feb 2013 21:39:20 +0100 Laszlo Ersek wrote: > The return type can't be changed to void, because "set_property" must have > type "qemu_opt_loopfunc". > > Conversion status (call chains covered or substituted by error propagation > marked with square brackets): This is fine to be squas

Re: [Qemu-devel] [PATCH 5/7] block/vpc: Fix size calculation

2013-02-07 Thread Stefan Weil
Am 05.02.2013 14:02, schrieb Jeff Cody: Hi Kevin, I can verify the issue he is seeing (see my comments on Bug 1105670 (https://bugs.launchpad.net/qemu/+bug/1105670/comments/3), at least using Hyper-V. I haven't tried it against VPC from Win7. Jeff Hi Kevin, a rebased version of this patch

Re: [Qemu-devel] [RFC qom-cpu v2 03/28] target-arm: Update ARMCPU to QOM realizefn

2013-02-07 Thread Andreas Färber
Am 07.02.2013 17:31, schrieb Eduardo Habkost: > On Sun, Jan 20, 2013 at 08:22:26AM +0100, Andreas Färber wrote: >> Turn arm_cpu_realize() into a QOM realize function, no longer called >> via cpu.h prototype. To maintain the semantics of cpu_init(), set >> realized = true explicitly in cpu_arm_init(

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 0/6] QOM CPUState VMStateDescriptions

2013-02-07 Thread Andreas Färber
Am 02.02.2013 16:04, schrieb Andreas Färber: > Hello, > > In response to patches from Juan [1], this series implements a declarative way > for CPUs to register their CPU-specific VMStateDescription. Ping? OK to go ahead with patches 1-3? Any thoughts on how to proceed with the not-yet-migratable

Re: [Qemu-devel] [PATCH v2 01/15] remove some trailing whitespace

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:14PM +0100, Laszlo Ersek wrote: > > Signed-off-by: Laszlo Ersek Reviewed-by: Eduardo Habkost > --- > hw/qdev-monitor.c |2 +- > vl.c |8 > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/qdev-monitor.c b/hw/qdev

[Qemu-devel] [PATCH] target-mips: fix for sign-issue in MULQ_W helper

2013-02-07 Thread Petar Jovanovic
From: Petar Jovanovic Correct sign-propagation before multiplication in MULQ_W helper. The change also fixes previously incorrect expected values in the tests for MULQ_RS.W and MULQ_S.W. Signed-off-by: Petar Jovanovic --- target-mips/dsp_helper.c|2 +- tests/tcg/mips/mips32

[Qemu-devel] [PATCH v3 1/5] qcow2: introduce check_refcounts_l1/l2() flags

2013-02-07 Thread Stefan Hajnoczi
The check_refcounts_l1/l2() functions have a check_copied argument to check that the QCOW_O_COPIED flag is consistent with refcount == 1. This should be a bool, not an int. However, the next patch introduces qcow2 fragmentation statistics and also needs to pass an option to check_refcounts_l1/l2()

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Anthony Liguori
Stefan Hajnoczi writes: > On Thu, Feb 7, 2013 at 3:43 PM, Laszlo Ersek wrote: >> Instead, what about >> >> #define endof(container, field) \ >> (offsetof(container, field) + sizeof ((container *)0)->field) > > As mentioned in my reply, I think endof() isn't necessary. > > Just use offsetof()

Re: [Qemu-devel] [PATCH v2 02/15] do_device_add(): look up "device" opts list with qemu_find_opts_err()

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:15PM +0100, Laszlo Ersek wrote: > Conversion status (call chains covered or substituted by error propagation > marked with square brackets): > > do_device_add -> [qemu_find_opts -> error_report] > do_device_add -> qdev_device_add -> qerror_report > do_device_add -> qd

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Anthony Liguori
Laszlo Ersek writes: > On 02/07/13 09:55, Michael S. Tsirkin wrote: >> On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: >>> Currently, the config size for virtio devices is hard coded. When a new >>> feature is added that changes the config size, drivers that assume a static >>> conf

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 1/6] cpu: Register VMStateDescription through CPUState

2013-02-07 Thread Andreas Färber
Am 07.02.2013 19:22, schrieb Eduardo Habkost: > On Thu, Feb 07, 2013 at 07:02:32PM +0100, Andreas Färber wrote: >> Am 07.02.2013 18:46, schrieb Eduardo Habkost: >>> On Thu, Feb 07, 2013 at 06:20:52PM +0100, Andreas Färber wrote: Am 07.02.2013 17:40, schrieb Eduardo Habkost: > On Sat, Feb 0

Re: [Qemu-devel] [RFC qom-cpu v2 07/28] target-cris: Introduce QOM realizefn for CRISCPU

2013-02-07 Thread Eduardo Habkost
On Sun, Jan 20, 2013 at 08:22:30AM +0100, Andreas Färber wrote: > Introduce realizefn and set realized = true from cpu_cris_init(). > > Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost > --- > target-cris/cpu-qom.h |2 ++ > target-cris/cpu.c | 15 +++ > tar

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 1/6] cpu: Register VMStateDescription through CPUState

2013-02-07 Thread Eduardo Habkost
On Thu, Feb 07, 2013 at 07:02:32PM +0100, Andreas Färber wrote: > Am 07.02.2013 18:46, schrieb Eduardo Habkost: > > On Thu, Feb 07, 2013 at 06:20:52PM +0100, Andreas Färber wrote: > >> Am 07.02.2013 17:40, schrieb Eduardo Habkost: > >>> On Sat, Feb 02, 2013 at 04:04:11PM +0100, Andreas Färber wrote

Re: [Qemu-devel] [PATCH v3 0/5] qcow2: add fragmentation and compression info support

2013-02-07 Thread Eric Blake
On 02/07/2013 09:15 AM, Stefan Hajnoczi wrote: > Applies on kevin/block-next (2700d627e4d73bb2aacb832a93ffac8fec78b1fd). > > This series adds fragmentation info support to qcow2 and then adds compression > info. Previously only QED supported fragmentation info. Note that > fragmentation info onl

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 2/6] target-i386: Update VMStateDescription to X86CPU

2013-02-07 Thread Andreas Färber
Am 07.02.2013 17:55, schrieb Eduardo Habkost: > On Sat, Feb 02, 2013 at 04:04:12PM +0100, Andreas Färber wrote: >> Expose vmstate_cpu as vmstate_x86_cpu and hook it up to CPUClass::vmsd. >> Adapt opaques and VMState fields to X86CPU. Drop cpu_{save,load}(). >> >> Signed-off-by: Andreas Färber >> -

Re: [Qemu-devel] [libvirt] q35 machine type and libvirt.

2013-02-07 Thread Alex Williamson
On Thu, 2013-02-07 at 17:31 +, Daniel P. Berrange wrote: > On Wed, Feb 06, 2013 at 01:15:05PM -0700, Alex Williamson wrote: > > On Wed, 2013-02-06 at 14:13 -0500, Laine Stump wrote: > > > 2) Are there other issues aside from implicit controller devices I > > > need to consider for q35? For exam

Re: [Qemu-devel] [RFC V2 14/16] qcow2: Add qcow2_dedup_update_metrics to compute dedup RAM usage.

2013-02-07 Thread Eric Blake
On 02/06/2013 05:32 AM, Benoît Canet wrote: > --- > block/qcow2-dedup.c | 11 +++ > block/qcow2.h | 18 ++ > 2 files changed, 29 insertions(+) > > diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c > index 308b4f6..72ce1d7 100644 > --- a/block/qcow2-dedup.c >

Re: [Qemu-devel] [PATCH v2 06/15] set_property(): extend signature with Error

2013-02-07 Thread Luiz Capitulino
On Thu, 7 Feb 2013 15:18:41 -0200 Eduardo Habkost wrote: > On Tue, Feb 05, 2013 at 09:39:19PM +0100, Laszlo Ersek wrote: > > > > Signed-off-by: Laszlo Ersek > > --- > > hw/qdev-monitor.c | 21 - > > 1 files changed, 16 insertions(+), 5 deletions(-) > > > > diff --git a/h

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 1/6] cpu: Register VMStateDescription through CPUState

2013-02-07 Thread Andreas Färber
Am 07.02.2013 18:46, schrieb Eduardo Habkost: > On Thu, Feb 07, 2013 at 06:20:52PM +0100, Andreas Färber wrote: >> Am 07.02.2013 17:40, schrieb Eduardo Habkost: >>> On Sat, Feb 02, 2013 at 04:04:11PM +0100, Andreas Färber wrote: In comparison to DeviceClass::vmsd, CPU VMState is split in two,

Re: [Qemu-devel] [RFC V6 25/33] qcow2: Serialize write requests when deduplication is activated.

2013-02-07 Thread Eric Blake
On 02/06/2013 05:31 AM, Benoît Canet wrote: > This fix the sub cluster sized writes race conditions while waiting s/fix/fixes/ > for a more faster solution. s/more// Would it be worth describing the race condition in more detail? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt vi

Re: [Qemu-devel] [PATCH v2 05/15] qdev_prop_parse(): change return type to void

2013-02-07 Thread Luiz Capitulino
On Thu, 7 Feb 2013 15:12:22 -0200 Eduardo Habkost wrote: > On Tue, Feb 05, 2013 at 09:39:18PM +0100, Laszlo Ersek wrote: > > Problems are now reported via Error only. > > > > Signed-off-by: Laszlo Ersek > > --- > > hw/qdev-properties.h |4 ++-- > > hw/qdev-monitor.c|3 ++- > > hw/q

Re: [Qemu-devel] Want to be part of Memory Hotplug

2013-02-07 Thread Vasilis Liaskovitis
Hi Senthil, On Mon, Feb 04, 2013 at 04:17:30PM +0530, kumaran wrote: > Hi, > > I am Senthil, doing post graduation in IIT Bombay,India. > > I am looking for some problems related to KVM as part of my research > work. I read about memory hotplug and other open issues in KVM. > > Can i be part of

Re: [Qemu-devel] [PATCH v2 03/15] qdev_prop_parse(): extend signature with Error

2013-02-07 Thread Luiz Capitulino
On Thu, 7 Feb 2013 15:04:54 -0200 Eduardo Habkost wrote: > On Tue, Feb 05, 2013 at 09:39:16PM +0100, Laszlo Ersek wrote: > > Error handling is not changed yet. > > > > Signed-off-by: Laszlo Ersek > > The extra parameter seems useless and even misleading (because Error > info won't be set even

Re: [Qemu-devel] [PATCH v2 02/15] do_device_add(): look up "device" opts list with qemu_find_opts_err()

2013-02-07 Thread Luiz Capitulino
On Thu, 07 Feb 2013 18:07:01 +0100 Laszlo Ersek wrote: > On 02/07/13 18:01, Eduardo Habkost wrote: > > On Tue, Feb 05, 2013 at 09:39:15PM +0100, Laszlo Ersek wrote: > >> Conversion status (call chains covered or substituted by error propagation > >> marked with square brackets): > >> > >> do_devi

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Thu, Feb 07, 2013 at 09:45:54AM -0600, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> This is about bug-for-bug compatibility with older QEMU. > > Sorry, with which version? > > It looks like if I run qemu 1.3 with .status=off > windows drivers wo

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 04:22:45PM +0100, Stefan Hajnoczi wrote: > On Thu, Feb 7, 2013 at 3:43 PM, Laszlo Ersek wrote: > > Instead, what about > > > > #define endof(container, field) \ > > (offsetof(container, field) + sizeof ((container *)0)->field) > > As mentioned in my reply, I think endo

Re: [Qemu-devel] [libvirt] q35 machine type and libvirt.

2013-02-07 Thread Daniel P. Berrange
On Wed, Feb 06, 2013 at 01:15:05PM -0700, Alex Williamson wrote: > On Wed, 2013-02-06 at 14:13 -0500, Laine Stump wrote: > > 2) Are there other issues aside from implicit controller devices I > > need to consider for q35? For example, are there any devices that (as > > I recall is the case for some

Re: [Qemu-devel] [PATCH v3 04/20] arm: add Faraday FTDDRII030 support

2013-02-07 Thread Igor Mitsyanko
On 02/06/2013 01:45 PM, Kuo-Jung Su wrote: From: Kuo-Jung Su The FTDDRII030 is a DDRII SDRAM controller which is responsible for SDRAM initialization. In QEMU we simply emualte the SDRAM enable function, neither timing parameter nor bank setup is handled. Signed-off-by: Kuo-Jung Su --- hw/a

Re: [Qemu-devel] [PATCH v3 01/20] arm: add Faraday a360 SoC platform support

2013-02-07 Thread Igor Mitsyanko
On 02/06/2013 01:45 PM, Kuo-Jung Su wrote: > From: Kuo-Jung Su > > The Faraday A360 EVB is a Faraday SoC platform evaluation board used for > Faraday IP functional verification based on the well-known ARM AMBA 2.0 > architecture. > > Signed-off-by: Kuo-Jung Su > --- > hw/arm/Makefile.objs |

[Qemu-devel] What limitions when run in coroutine mode ?

2013-02-07 Thread Kang Hua
HI all : I write a new block driver based on hdfs of hadoop, it need to connect to hdfs when create step (called by bdrv_create in block.c) by use libhdfs ( hdfs c++ api) 。 libhdfs use jni api to will create jvm . The problem is —— it will cause sigsegv error when create jvm . #0 0x000

Re: [Qemu-devel] [PATCH qom-cpu-next v2 1/1] target-cris: Introduce CRISCPU subclasses

2013-02-07 Thread Andreas Färber
Am 07.02.2013 18:04, schrieb Andreas Färber: > diff --git a/target-cris/cpu.c b/target-cris/cpu.c > index fedf641..8008988 100644 > --- a/target-cris/cpu.c > +++ b/target-cris/cpu.c > @@ -55,6 +55,84 @@ static void cris_cpu_reset(CPUState *s) > #endif > } > > +static ObjectClass *cris_cpu_class

Re: [Qemu-devel] [PATCH v3 02/20] arm: add Faraday a369 SoC platform support

2013-02-07 Thread Igor Mitsyanko
On 02/06/2013 01:45 PM, Kuo-Jung Su wrote: From: Kuo-Jung Su The Faraday A369 EVB is a Faraday SoC platform evalution board used for Faraday IP functional verification based on the well-known ARM AMBA 2.0 architecture. Signed-off-by: Kuo-Jung Su --- hw/arm/Makefile.objs |1 + hw

[Qemu-devel] [PATCH v3 2/5] qcow2: record fragmentation statistics during check

2013-02-07 Thread Stefan Hajnoczi
The qemu-img check command can display fragmentation statistics: * Total number of clusters in virtual disk * Number of allocated clusters * Number of fragmented clusters This patch adds fragmentation statistics support to qcow2. Compressed and normal clusters count as allocated. Zero cluster

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 1/6] cpu: Register VMStateDescription through CPUState

2013-02-07 Thread Andreas Färber
Am 07.02.2013 17:40, schrieb Eduardo Habkost: > On Sat, Feb 02, 2013 at 04:04:11PM +0100, Andreas Färber wrote: >> In comparison to DeviceClass::vmsd, CPU VMState is split in two, >> "cpu_common" and "cpu", and uses cpu_index as instance_id instead of -1. >> Therefore add a CPU-specific CPUClass::v

Re: [Qemu-devel] [PATCH v2 06/15] set_property(): extend signature with Error

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:19PM +0100, Laszlo Ersek wrote: > > Signed-off-by: Laszlo Ersek > --- > hw/qdev-monitor.c | 21 - > 1 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index cf96046..545e66c 100644 > ---

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom size to 8192

2013-02-07 Thread Alon Levy
> On 02/07/2013 07:31 AM, Alon Levy wrote: > >> On 02/06/2013 05:52 PM, Cole Robinson wrote: > >>> On 01/22/2013 05:09 AM, Gerd Hoffmann wrote: > From: Alon Levy > > This is a simpler solution to 869981, where migration breaks > since > qxl's > rom bar size has change

Re: [Qemu-devel] [PATCH v2 05/15] qdev_prop_parse(): change return type to void

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:18PM +0100, Laszlo Ersek wrote: > Problems are now reported via Error only. > > Signed-off-by: Laszlo Ersek > --- > hw/qdev-properties.h |4 ++-- > hw/qdev-monitor.c|3 ++- > hw/qdev-properties.c | 14 ++ > 3 files changed, 10 insertions(+)

Re: [Qemu-devel] [PATCH v2 02/15] do_device_add(): look up "device" opts list with qemu_find_opts_err()

2013-02-07 Thread Laszlo Ersek
On 02/07/13 18:01, Eduardo Habkost wrote: > On Tue, Feb 05, 2013 at 09:39:15PM +0100, Laszlo Ersek wrote: >> Conversion status (call chains covered or substituted by error propagation >> marked with square brackets): >> >> do_device_add -> [qemu_find_opts -> error_report] >> do_device_add -> qdev_d

[Qemu-devel] [PATCH qom-cpu-next v2 0/1] QOM'ify CRIS CPU

2013-02-07 Thread Andreas Färber
Hi Edgar, This patch takes a second attempt at introducing CPU subclasses for cris. In v1 I had used a declarative CRISCPUInfo-based class initialization; this v2 now proposes a TypeInfo/class_init based approach, removing the field duplication and preparing to manually extend the crisv32 class_i

[Qemu-devel] [PATCH qom-cpu-next v2 1/1] target-cris: Introduce CRISCPU subclasses

2013-02-07 Thread Andreas Färber
Use class_init functions to initialize the VR in preparation for overriding v32+ behavior there. Move cpu_cris_init() to cpu.c and hook up a class_by_name callback. This change leads to unknown -cpu model names no longer falling back to a CPU with VR 32 but instead returning NULL. Signed-off-by:

Re: [Qemu-devel] [PATCH v2 04/15] qdev_prop_parse(): push error handling to callers

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:17PM +0100, Laszlo Ersek wrote: > Error consumption is moved from qdev_prop_parse() to its direct callers. > > Conversion status (call chains covered or substituted by error propagation > marked with square brackets): > > do_device_add -> [qemu_find_opts -> error_rep

Re: [Qemu-devel] [PATCH v2 03/15] qdev_prop_parse(): extend signature with Error

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:16PM +0100, Laszlo Ersek wrote: > Error handling is not changed yet. > > Signed-off-by: Laszlo Ersek The extra parameter seems useless and even misleading (because Error info won't be set even if the function returns -1) without patch 04/15. What about squashing bot

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 2/6] target-i386: Update VMStateDescription to X86CPU

2013-02-07 Thread Eduardo Habkost
On Sat, Feb 02, 2013 at 04:04:12PM +0100, Andreas Färber wrote: > Expose vmstate_cpu as vmstate_x86_cpu and hook it up to CPUClass::vmsd. > Adapt opaques and VMState fields to X86CPU. Drop cpu_{save,load}(). > > Signed-off-by: Andreas Färber > --- > target-i386/cpu-qom.h |2 + > target-i386/

[Qemu-devel] [PATCH v3 0/5] qcow2: add fragmentation and compression info support

2013-02-07 Thread Stefan Hajnoczi
Applies on kevin/block-next (2700d627e4d73bb2aacb832a93ffac8fec78b1fd). This series adds fragmentation info support to qcow2 and then adds compression info. Previously only QED supported fragmentation info. Note that fragmentation info only covers the current image, internal snapshots are not in

[Qemu-devel] [PULL for-1.4] QMP queue

2013-02-07 Thread Luiz Capitulino
The changes (since ecd8d4715ea33aa2c146a5047bacb031e86af599) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Peter Maydell (1): tests/test-string-input-visitor: Handle errors provoked by fuzz test tests/test-string-input-visitor.c | 12 ++---

[Qemu-devel] [PATCH v3 5/5] qcow2: support compressed clusters in BlockFragInfo

2013-02-07 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 771b7b2..55543ed 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -968,6 +968,7 @@ static int check_refcounts_l2(B

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 1/6] cpu: Register VMStateDescription through CPUState

2013-02-07 Thread Eduardo Habkost
On Sat, Feb 02, 2013 at 04:04:11PM +0100, Andreas Färber wrote: > In comparison to DeviceClass::vmsd, CPU VMState is split in two, > "cpu_common" and "cpu", and uses cpu_index as instance_id instead of -1. > Therefore add a CPU-specific CPUClass::vmsd field. > > Unlike the legacy CPUArchState regi

[Qemu-devel] [PULL] tests/test-string-input-visitor: Handle errors provoked by fuzz test

2013-02-07 Thread Luiz Capitulino
From: Peter Maydell It's OK and expected for visitors to return errors when presented with the fuzz test's random data. Since the fuzzer doesn't care about errors, we pass in NULL rather than an Error**. This fixes a bug in the fuzzer where it was passing the same Error** into each visitor, with

Re: [Qemu-devel] [RFC qom-cpu v2 03/28] target-arm: Update ARMCPU to QOM realizefn

2013-02-07 Thread Eduardo Habkost
On Sun, Jan 20, 2013 at 08:22:26AM +0100, Andreas Färber wrote: > Turn arm_cpu_realize() into a QOM realize function, no longer called > via cpu.h prototype. To maintain the semantics of cpu_init(), set > realized = true explicitly in cpu_arm_init(). > > Move GDB coprocessor registration, CPU rese

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 05:56:16PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2013 at 09:45:54AM -0600, Anthony Liguori wrote: > > "Michael S. Tsirkin" writes: > > > > > On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: > > >> Currently, the config size for virtio devices is h

[Qemu-devel] [PATCH v3 4/5] qemu-img: add compressed clusters to BlockFragInfo

2013-02-07 Thread Stefan Hajnoczi
Show how many clusters are compressed. This can be used to monitor how many compressed clusters remain and whether to recompress the image. Suggested-by: Cole Robinson Signed-off-by: Stefan Hajnoczi --- include/block/block.h| 1 + qapi-schema.json | 6 +- qemu-img.c

Re: [Qemu-devel] [RFC qom-cpu v2 04/28] target-i386: Update X86CPU to QOM realizefn

2013-02-07 Thread Eduardo Habkost
On Sun, Jan 20, 2013 at 08:22:27AM +0100, Andreas Färber wrote: > Adapt the signature of x86_cpu_realize(), hook up to > DeviceClass::realize and set realized = true in cpu_x86_init(). > > The QOM realizefn cannot depend on errp being non-NULL as in > cpu_x86_init(), so use a local Error to preser

[Qemu-devel] [PATCH v3 3/5] qemu-img: fix missing space in qemu-img check output

2013-02-07 Thread Stefan Hajnoczi
The qemu-img check fragmentation printf() is missing a space before the '=' sign. The human output is not guaranteed to be stable and we are not aware of screen scrapers, so add the missing space. Also fix the missing indentation of the printf() arguments. Signed-off-by: Stefan Hajnoczi --- qe

Re: [Qemu-devel] Sigsegv error when create JVM, called by bdrv_create in block.c

2013-02-07 Thread Stefan Hajnoczi
On Thu, Feb 7, 2013 at 3:12 PM, harryxiyou wrote: > The above debug info show jni will be used in coroutine. I do not > familay with coroutine, however I guess if coroutine not allow to > spawn a new thread? ,or it's stack corrupte with java jvm stack ? , > For when I modify bdrv_create out of cor

Re: [Qemu-devel] [RFC V2 5/7] qcow2: Add qcow2_dedup_control.

2013-02-07 Thread Eric Blake
On 02/06/2013 05:32 AM, Benoît Canet wrote: > --- > block/qcow2-dedup.c | 31 +++ > block/qcow2.c |2 ++ > block/qcow2.h |1 + > 3 files changed, 34 insertions(+) > > diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c > index 1ac..66fb415

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 09:45:54AM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: > >> Currently, the config size for virtio devices is hard coded. When a new > >> feature is added that changes the config size, driv

Re: [Qemu-devel] [RFC V2 12/16] qapi: Add support for deduplication infos in qapi-schema.json.

2013-02-07 Thread Eric Blake
On 02/06/2013 05:32 AM, Benoît Canet wrote: > --- > qapi-schema.json | 40 +++- > 1 file changed, 39 insertions(+), 1 deletion(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index cf4e9d6..ec61f6a 100644 > --- a/qapi-schema.json > +++ b/qapi-schema

Re: [Qemu-devel] [RFC V2 11/16] qcow2: Count deduplication refcount overflow metric.

2013-02-07 Thread Eric Blake
On 02/06/2013 05:32 AM, Benoît Canet wrote: > --- > block/qcow2-dedup.c |1 + > 1 file changed, 1 insertion(+) It wouldn't hurt to squash several of these one-liner patches into a bigger patch that turns on collection of all stats in one go. > > diff --git a/block/qcow2-dedup.c b/block/qcow

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Laszlo Ersek
On 02/07/13 16:22, Stefan Hajnoczi wrote: > On Thu, Feb 7, 2013 at 3:43 PM, Laszlo Ersek wrote: >> Instead, what about >> >> #define endof(container, field) \ >> (offsetof(container, field) + sizeof ((container *)0)->field) > > As mentioned in my reply, I think endof() isn't necessary. > > J

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Laszlo Ersek
On 02/07/13 15:43, Laszlo Ersek wrote: > On 02/07/13 09:55, Michael S. Tsirkin wrote: >> On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: >>> +#define endof(container, field) \ >>> +((intptr_t)(&(((container *)0)->field)+1)) >> > Furthermore, taking the pointer to "one past" &fie

  1   2   >