[Qemu-devel] [PATCH V3 10/11] hmp: retrieve info from qmp for snapshot info

With this patch, hmp command info snapshot simply call a block layer funtion which will return a qmp object, and then translate it in monitor console. Now snapshot info retrieving code in qemu and qemu-tool are merged by calling same block layer function, and then they just translate the qmp to s

[Qemu-devel] [PATCH V3 05/11] block: rename bdrv_query_info to bdrv_query_block_info

Now that we have bdrv_query_image_info, rename this function to make it more obvious what it is doing. Reviewed-by: Eric Blake Signed-off-by: Wenchao Xia --- block.c |4 ++-- include/block/block.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bloc

[Qemu-devel] [PATCH V3 02/11] block: add bdrv_get_filename() function

This function will simply return the uri or filename used to open the image. Reviewed-by: Eric Blake Signed-off-by: Wenchao Xia --- block.c |5 + include/block/block.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 4e28c5

[Qemu-devel] [PATCH V3 03/11] block: add snapshot and image info query function

This patch added function bdrv_query_image_info() and bdrv_query_snapshot_infolist(), which will return info in qmp object format. The implementation code are mostly copied from collect_image_info() and collect_snapshot() in qemu-img.c. To help filter out snapshot info not needed, a call back f

[Qemu-devel] [PATCH V3 00/11] add qmp/hmp interfaces for snapshot info

This serial of patches does two things: merge some info code in qemu-img, and add following interfaces: 1) qmp: query-images 2) qmp: query-snapshots 3) hmp: show snapshot info on a single block device These patches follows the rule that use qmp to retieve information, hmp layer just do a transl

[Qemu-devel] [PATCH V3 11/11] hmp: show snapshot on single block device

This patch use block layer API to qmp snapshot info on a block device, then use the same code dumping vm snapshot info, to print in monitor. Signed-off-by: Wenchao Xia --- Note: This patch need previous hmp extention patch which enable info sub command take qdict * as paramter. --- monitor.

[Qemu-devel] [PATCH V3 09/11] hmp: export function hmp_handle_error()

Signed-off-by: Wenchao Xia --- hmp.c |2 +- hmp.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hmp.c b/hmp.c index 2465d9b..89a1a8c 100644 --- a/hmp.c +++ b/hmp.c @@ -23,7 +23,7 @@ #include "monitor/monitor.h" #include "ui/console.h" -static void hmp_handle_er

[Qemu-devel] [PATCH V3 06/11] qmp: add interface query-images.

This mirror function will return all image info including snapshots. Now Qemu have both query-images and query-block interfaces. Signed-off-by: Wenchao Xia --- block.c | 19 + qapi-schema.json | 27 +++ qmp-commands.hx | 76 ++

[Qemu-devel] [PATCH V3 08/11] qmp: add interface query-snapshots

This interface now return valid internal snapshots. Signed-off-by: Wenchao Xia --- block.c | 32 qapi-schema.json | 13 + qmp-commands.hx | 53 + 3 files changed, 98 insertions(+),

[Qemu-devel] [PATCH V3 01/11] qemu-img: remove unused parameter in collect_image_info()

Parameter *fmt was not used, so remove it. Reviewed-by: Eric Blake Signed-off-by: Wenchao Xia --- qemu-img.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 85d3740..9dab48f 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1186,8 +1186,7

[Qemu-devel] [PATCH V6 5/5] HMP: add sub command table to info

Now info command takes a table of sub info commands, and changed do_info() to do_info_help() to do help funtion only. Note that now "info " returns error instead of list of info topics. Signed-off-by: Wenchao Xia --- hmp-commands.hx |3 ++- monitor.c | 22 +- 2

[Qemu-devel] [PATCH V6 2/5] HMP: delete info handler

Now cmd and info handler have same format, so delete info handler. Signed-off-by: Wenchao Xia --- monitor.c | 91 ++--- 1 files changed, 45 insertions(+), 46 deletions(-) diff --git a/monitor.c b/monitor.c index c7b3014..359f333 100644

[Qemu-devel] [PATCH V6 3/5] HMP: add infrastructure for sub command

This patch make parsing of hmp command aware of that it may have sub command. Also discard simple encapsulation function monitor_find_command(). For case "@command ", space after @command is filtered out. Signed-off-by: Wenchao Xia --- monitor.c | 49 +++--

[Qemu-devel] [PATCH V6 4/5] HMP: move define of mon_cmds

Because mon_cmds may use info_cmds, so adjust the declare sequence of them. Signed-off-by: Wenchao Xia --- monitor.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 6f470bf..d3225c2 100644 --- a/monitor.c +++ b/monitor.c @@ -2425,

[Qemu-devel] [PATCH V6 1/5] HMP: add QDict to info callback handler

This patch change all info call back function to take additional QDict * parameter, which allow those command take parameter. Now it is set to NULL at default case. Signed-off-by: Wenchao Xia --- hmp.c | 36 ++-- hmp.h | 3

[Qemu-devel] [PATCH V6 0/5] HMP: allow parsing for sub command

These patches enhance HMP to allow it parse 2nd level of commands, such as info sub command list, which means foldered command with parameter is possible now. V2: Follow the way supposed by Markus, which make the infrastructure knows there is possible a 2nd level of command exist, instead of a

[Qemu-devel] [PATCH 2/2] sheepdog: clean up sd_aio_setup()

From: Liu Yuan The last two parameters of sd_aio_setup() are never used, so remove them. Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/sheepdog.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/block/sheepdog.c b/b

[Qemu-devel] [PATCH 1/2] sheepdog: multiplex the rw FD to flush cache

From: Liu Yuan This will reduce sockfds connected to the sheep server to one, which simply the future hacks. Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/sheepdog.c | 64 +++--- 1 file changed, 27

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

The attachment "Patch against debian package" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu- sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

On 01/11/2013 11:37 PM, Eric Blake wrote: On 01/11/2013 12:18 AM, Lei Li wrote: For this version, it's a one-hour offset represented as:±[hh]. Negative values are west, andpositive values are east of UTC. Won't work. There are timezones with a half-hour offset. You need to express offset at l

Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction

于 2013-1-11 17:12, Stefan Hajnoczi 写道: On Fri, Jan 11, 2013 at 02:22:28PM +0800, Wenchao Xia wrote: 于 2013-1-10 20:41, Stefan Hajnoczi 写道: On Thu, Jan 10, 2013 at 11:21:22AM +0800, Wenchao Xia wrote: 于 2013-1-9 20:44, Stefan Hajnoczi 写道: On Mon, Jan 07, 2013 at 03:28:06PM +0800, Wenchao Xia w

Re: [Qemu-devel] [PATCH v4 1/3] target-i386:define name of breakpoint bit in dr7

在 2013-01-11五的 17:10 +0100，Andreas Färber写道： > Am 10.12.2012 03:22, schrieb liguang: > > Signed-off-by: liguang > > For a patch series consisting of more than 1 patch, please use a cover > letter (e.g., --cover-letter) that details the change history of the > versions. That also facilitates comme

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

** Patch added: "Patch against debian package" https://bugs.launchpad.net/qemu/+bug/1033727/+attachment/3482404/+files/qemu-debian.diff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1033727 Title

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

Thanks a lot Peter! I can confirm that this patch fixes the problems when added on top of Debian's qemu-kvm 1.1.2+dfsg-4 package. I have attached a patch against the Debian git tree. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. htt

Re: [Qemu-devel] [PATCH V5 4/6] HMP: filter out space before check of sub-command

于 2013-1-12 4:12, Luiz Capitulino 写道: On Fri, 11 Jan 2013 17:14:03 +0800 Wenchao Xia wrote: This fix the case when user input "@command ". Original it will return NULL for monitor_parse_command(), now it will return the @command related instance. Signed-off-by: Wenchao Xia --- monitor.c

Re: [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way

于 2013-1-11 21:56, Luiz Capitulino 写道: On Thu, 10 Jan 2013 14:01:27 +0800 Wenchao Xia wrote: 于 2013-1-10 6:34, Eric Blake 写道: On 01/07/2013 12:27 AM, Wenchao Xia wrote: These patch added a seperated layer to take internal or external snapshots in a unified way, the granularity is block d

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

On 01/12/2013 08:00 PM, Blue Swirl wrote: > On Fri, Jan 11, 2013 at 7:27 AM, 马磊 wrote: >> >> >> On Fri, Jan 11, 2013 at 2:28 PM, Wanlong Gao >> wrote: >>> >>> On 01/11/2013 11:39 AM, 马磊 wrote: On Thu, Jan 10, 2013 at 8:20 PM, Daniel P. Berrange >>> > wro

[Qemu-devel] [RFC ppc-next v3 06/10] mac_nvram: Clean up public API

The state data field is accessed in uint8_t quantities, so switch from uint32_t argument and return value to uint8_t. Fix debug format specifiers while at it. Signed-off-by: Andreas Färber --- hw/mac_nvram.c | 21 ++--- hw/ppc/mac.h |4 ++-- 2 Dateien geändert, 12 Zeilen

[Qemu-devel] [RFC ppc-next v3 09/10] ide/macio: QOM'ify MacIO IDE

It was not qdev'ified before, turn it into a SysBusDevice. Embed them into the MacIO devices. Signed-off-by: Andreas Färber Cc: Markus Armbruster --- hw/ide.h |4 -- hw/ide/macio.c| 81 --- hw/macio.c| 102 +

[Qemu-devel] [PATCH 01/10] qom: Make object_resolve_path_component() path argument const

This allows to navigate partial well-known paths from an object. Signed-off-by: Andreas Färber Cc: Anthony Liguori --- include/qom/object.h |2 +- qom/object.c |2 +- 2 Dateien geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/include/qom/object.h b/include/q

[Qemu-devel] [RFC ppc-next v3 10/10] cuda: QOM'ify CUDA

It was not qdev'ified before, turn it into a SysBusDevice and embed it in MacIO. Signed-off-by: Andreas Färber --- hw/cuda.c | 98 ++--- hw/macio.c| 43 +++--- hw/ppc/mac.h | 68 +++

[Qemu-devel] [RFC ppc-next v3 05/10] macio: Split MacIO in two

Let the machines create two different types. This prepares to move knowledge about sub-devices from the machines into the devices. Signed-off-by: Andreas Färber --- hw/macio.c| 97 +++-- hw/ppc/mac.h | 10 +++-- hw/ppc/mac_neww

[Qemu-devel] [RFC ppc-next v3 02/10] ppc: Move Mac machines to hw/ppc/

Signed-off-by: Andreas Färber --- hw/cuda.c |2 +- hw/grackle_pci.c |2 +- hw/heathrow_pic.c |2 +- hw/ide/macio.c|6 +++--- hw/mac_nvram.c|

[Qemu-devel] [RFC ppc-next v3 03/10] macio: QOM'ify some more

Move bar MemoryRegion initialization to an instance_init. Signed-off-by: Andreas Färber --- hw/macio.c | 25 +++-- 1 Datei geändert, 19 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git a/hw/macio.c b/hw/macio.c index f01fc57..770e3bd 100644 --- a/hw/macio.c +++ b/hw/

[Qemu-devel] [RFC ppc-next v3 07/10] mac_nvram: Mark as Big Endian

Signed-off-by: Andreas Färber --- hw/mac_nvram.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/hw/mac_nvram.c b/hw/mac_nvram.c index bcde07d..0a22e66 100644 --- a/hw/mac_nvram.c +++ b/hw/mac_nvram.c @@ -96,7 +96,7 @@ static uint64_t macio_nvram_readb(void

[Qemu-devel] [RFC ppc-next v3 08/10] mac_nvram: QOM'ify MacIO NVRAM

It was not qdev'ified before, turn it into a SysBusDevice and initialize it via static properties. Prepare Old World specific MacIO state and embed the NVRAM state there. Drop macio_nvram_setup_bar() in favor of sysbus_mmio_map() or direct use of Memory API. Signed-off-by: Andreas Färber --- h

[Qemu-devel] [RFC ppc-next v3 04/10] macio: Delay qdev init until all fields are initialized

This turns macio_bar_setup() into an implementation detail of the qdev initfn, to be removed step by step. Signed-off-by: Andreas Färber --- hw/macio.c | 11 --- 1 Datei geändert, 8 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/hw/macio.c b/hw/macio.c index 770e3bd..8b4b48d

[Qemu-devel] [RFC ppc-next v3 00/10] target-ppc: MacIO QOM'ification

Hello, As requested by Markus, here's a conversion of MacIO IDE to QOM. There's more work to be done, but in light of the approaching Soft Freeze here's my current state of affairs, lightly tested. Patch 1 is a generic QOM API fix and could be applied independent of the ppc device conversion. Pa

Re: [Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

Hi, well - it's probably only for historic interest, but if i made no bisecting mistake, this commit has fixed it (note that the meaning of 'good' and 'bad' is swapped due to how git bisect works): root@debian:~/qemu_git/qemu-kvm# git bisect good Bisecting: 87 revisions left to test after this

[Qemu-devel] [Bug 668799] Re: qemu-arm segfaults executing msgmerge (gettext)

The test I'm using in LP:1098729 hangs or segfaults nearly every single run. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/668799 Title: qemu-arm segfaults executing msgmerge (gettext) Status in

[Qemu-devel] [PATCH] bswap: improve gluing

OpenBSD system compiler (gcc 4.2.1) has problems with concatenation of macro arguments in macro functions: CCaes.o In file included from /src/qemu/include/qemu-common.h:126, from /src/qemu/aes.c:30: /src/qemu/include/qemu/bswap.h: In function 'leul_to_cpu': /src/qemu/include/

[Qemu-devel] [Bug 1087114] Re: assertion "QLIST_EMPTY(&bs->tracked_requests)" failed

I am still having this error even though I compile from the master branch and commit a795ef8dcb8cbadffc996c41ff38927a97645234 is definitely there. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1087114

[Qemu-devel] [Bug 1098729] Re: qemu-user-static for armhf: segfault in threaded code

At the top of function cpu_unlink_tb() in translate-all.c: /* FIXME: TB unchaining isn't SMP safe. For now just ignore the problem and hope the cpu will stop of its own accord. For userspace emulation this often isn't actually as bad as it sounds. Often signals are used

Re: [Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

Hello Michael, Am 1/12/2013 1:24 PM, Michael Tokarev wrote: > Peter, are you able to run git bisect or something like that, to try to > pinpoint either the commit which introduced this issue or which fixed > it? Well, i'm no expert at git, but i made some progress, see below. > Besides, what ar

[Qemu-devel] [PULL] pci,virtio

The following changes since commit 8e4a424b305e29dc0e454f52df3b35577f342975: Revert "virtio-pci: replace byte swap hack" (2013-01-06 18:30:17 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fetch changes up to feb

Re: [Qemu-devel] [PATCH] pc87312: avoid define conflict on mingw32

Blue Swirl a écrit : Mingw32 headers define FAR, causing this warning: /src/qemu/hw/pc87312.c:38:0: warning: "FAR" redefined [enabled by default] In file included from /usr/local/lib/gcc/i686-mingw32msvc/4.7.0/../../../../i686-mingw32msvc/include/windows.h:48:0, from /src/qemu/i

Re: [Qemu-devel] [PATCH] pc87312: Replace register_ioport_*() with MemoryRegion

Andreas Färber a écrit : Prepare an instance_init function for the MemoryRegion init. Signed-off-by: Andreas Färber Cc: Hervé Poussineau --- hw/pc87312.c | 26 ++ hw/pc87312.h |2 ++ 2 Dateien geändert, 24 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) Tested-by:

[Qemu-devel] [PATCH] pc87312: avoid define conflict on mingw32

Mingw32 headers define FAR, causing this warning: /src/qemu/hw/pc87312.c:38:0: warning: "FAR" redefined [enabled by default] In file included from /usr/local/lib/gcc/i686-mingw32msvc/4.7.0/../../../../i686-mingw32msvc/include/windows.h:48:0, from /src/qemu/include/sysemu/os-win32.