Re: [Qemu-devel] [PATCH] hw/pc.c: Fix converting of ioport_register* to MemoryRegion

2013-01-09 Thread Adam Lackorzynski
On Wed Jan 09, 2013 at 18:10:22 +, Julien Grall wrote: > The commit 258711 introduced MemoryRegion to replace ioport_region* > for ioport 80h and F0h. > A MemoryRegion needs to have both read and write callback otherwise a segfault > will occur when an access is made. > > The previous behaviou

Re: [Qemu-devel] [PATCH 10/12] virtio-net: multiqueue support

2013-01-09 Thread Jason Wang
On Thursday, January 10, 2013 02:49:14 PM Wanlong Gao wrote: > On 01/10/2013 02:43 PM, Jason Wang wrote: > > On Wednesday, January 09, 2013 11:26:33 PM Jason Wang wrote: > >> On 01/09/2013 06:01 PM, Wanlong Gao wrote: > >>> On 01/09/2013 05:30 PM, Jason Wang wrote: > On 01/09/2013 04:23 PM, Wa

Re: [Qemu-devel] [PATCH v2 5/8] target-mips: use DSP unions for binary DSP operators

2013-01-09 Thread Aurelien Jarno
On Wed, Jan 09, 2013 at 09:16:29PM +, Blue Swirl wrote: > On Wed, Jan 9, 2013 at 3:27 PM, Aurelien Jarno wrote: > > This allow to reduce the number of macros. > > > > Signed-off-by: Aurelien Jarno > > --- > > target-mips/dsp_helper.c | 384 > > ++

Re: [Qemu-devel] [PATCH V3 2/4] HMP: add infrastructure for sub command

2013-01-09 Thread wenchao xia
于 2013-1-10 11:30, Wenchao Xia 写道: -static const mon_cmd_t *qmp_find_cmd(const char *cmdname) -{ -return search_dispatch_table(qmp_cmds, cmdname); -} Touching qmp_find_cmd() is unrelated to this series. OK. - -static const mon_cmd_t *monitor_parse_command(Monitor *mon, -

Re: [Qemu-devel] QCOW2 deduplication design

2013-01-09 Thread Stefan Hajnoczi
On Wed, Jan 9, 2013 at 5:32 PM, Eric Blake wrote: > On 01/09/2013 09:16 AM, Stefan Hajnoczi wrote: > >>> I.6) max refcount reached >>> The L2 hash block of the cluster is written in order to remember at next >>> startup >>> that it must not be used anymore for deduplication. The hash is dropped

Re: [Qemu-devel] [PATCH] ui/vnc: VA API based H.264 encoding for VNC framebuffer updates

2013-01-09 Thread Gerd Hoffmann
On 01/09/13 23:18, Alexander Graf wrote: > > On 09.01.2013, at 21:25, Anthony Liguori wrote: > >> >> Since we really can't guarantee that libva will initialize okay, we >> need to more gracefully handle falling back to another encoding >> type. > > In fact, doesn't libavcodec / gstreamer suppor

Re: [Qemu-devel] [PATCH 10/12] virtio-net: multiqueue support

2013-01-09 Thread Wanlong Gao
On 01/10/2013 02:43 PM, Jason Wang wrote: > On Wednesday, January 09, 2013 11:26:33 PM Jason Wang wrote: >> On 01/09/2013 06:01 PM, Wanlong Gao wrote: >>> On 01/09/2013 05:30 PM, Jason Wang wrote: On 01/09/2013 04:23 PM, Wanlong Gao wrote: > On 01/08/2013 06:14 PM, Jason Wang wrote: >>

Re: [Qemu-devel] [PATCH 10/12] virtio-net: multiqueue support

2013-01-09 Thread Jason Wang
On Wednesday, January 09, 2013 11:26:33 PM Jason Wang wrote: > On 01/09/2013 06:01 PM, Wanlong Gao wrote: > > On 01/09/2013 05:30 PM, Jason Wang wrote: > >> On 01/09/2013 04:23 PM, Wanlong Gao wrote: > >>> On 01/08/2013 06:14 PM, Jason Wang wrote: > On 01/08/2013 06:00 PM, Wanlong Gao wrote: >

Re: [Qemu-devel] [PATCH 1/2] oslib-win32: add lock for gmtime_r()

2013-01-09 Thread Stefan Weil
>>> Il 09/01/2013 07:18, Wenchao Xia ha scritto: Also changed the caller of gmtime() to gmtime_r(). >>> >>> Should be a separate patch. >> >> There is already a pending patch which replaces gmtime, localtime: >> >> http://patchwork.ozlabs.org/patch/210250/ >> >> Stefan >> >> >Should oth

Re: [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way

2013-01-09 Thread Wenchao Xia
于 2013-1-10 6:34, Eric Blake 写道: On 01/07/2013 12:27 AM, Wenchao Xia wrote: These patch added a seperated layer to take internal or external snapshots in a unified way, the granularity is block device, so other functions can just combine the request and submit, such as group snapshot, savevm.

Re: [Qemu-devel] [PATCH 07/13] qapi: Convert savevm

2013-01-09 Thread Wenchao Xia
于 2013-1-10 6:32, Eric Blake 写道: On 01/09/2013 08:18 AM, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- hmp-commands.hx | 4 ++-- hmp.c | 9 + hmp.h | 1 + include/sysemu/sysemu.h | 1 - qapi-schema.json| 18

Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function

2013-01-09 Thread Wenchao Xia
于 2013-1-9 23:56, Eric Blake 写道: On 01/08/2013 10:12 PM, Wenchao Xia wrote: This patch added function bdrv_query_image_info() and bdrv_query_snapshot_infolist(), which will return info in qmp object format. The implemetion code are mostly copied from collect_image_info() s/implemetion/impl

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-09 Thread Liu Yuan
On 01/09/2013 11:10 PM, Paolo Bonzini wrote: > Il 09/01/2013 14:04, Liu Yuan ha scritto: 2 The upper layer software which relies on the 'cache=xxx' to choose cache mode will fail its assumption against new QEMU. >>> >>> Which assumptions do you mean? As far as I can say the behaviour ha

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Michael S. Tsirkin had to walk into mine at 13:44:38 on Wednesday 09 January 2013 and say: > On Wed, Jan 09, 2013 at 09:30:43AM -0800, Bill Paul wrote: > > Of all the gin joints in all the towns in all the world, Michael S. > > Tsirkin > >

Re: [Qemu-devel] vhost-net thread getting stuck ?

2013-01-09 Thread Chegu Vinod
On 1/9/2013 8:35 PM, Jason Wang wrote: On 01/10/2013 04:25 AM, Chegu Vinod wrote: Hello, 'am running into an issue with the latest bits. [ Pl. see below. The vhost thread seems to be getting stuck while trying to memcopy...perhaps a bad address?. ] Wondering if this is a known issue or some re

Re: [Qemu-devel] vhost-net thread getting stuck ?

2013-01-09 Thread Jason Wang
On 01/10/2013 04:25 AM, Chegu Vinod wrote: > > Hello, > > 'am running into an issue with the latest bits. [ Pl. see below. The > vhost thread seems to be getting > stuck while trying to memcopy...perhaps a bad address?. ] Wondering > if this is a known issue or > some recent regression ? Hi: Loo

Re: [Qemu-devel] [PATCH V3 2/4] HMP: add infrastructure for sub command

2013-01-09 Thread Wenchao Xia
-static const mon_cmd_t *qmp_find_cmd(const char *cmdname) -{ -return search_dispatch_table(qmp_cmds, cmdname); -} Touching qmp_find_cmd() is unrelated to this series. OK. - -static const mon_cmd_t *monitor_parse_command(Monitor *mon, - cons

Re: [Qemu-devel] [PULL 0/6] s390 patch queue 2013-01-07

2013-01-09 Thread Alexander Graf
On 10.01.2013, at 04:23, Rob Landley wrote: > On 01/07/2013 10:09:20 AM, Alexander Graf wrote: >> Hi Blue / Aurelien, >> This is my current patch queue for s390. Please pull. > > Ok, you'd be a good person to ask: > > http://wiki.qemu.org/Testing doesn't have a s390 test image. > > There are

Re: [Qemu-devel] [PULL 0/6] s390 patch queue 2013-01-07

2013-01-09 Thread Rob Landley
On 01/07/2013 10:09:20 AM, Alexander Graf wrote: Hi Blue / Aurelien, This is my current patch queue for s390. Please pull. Ok, you'd be a good person to ask: http://wiki.qemu.org/Testing doesn't have a s390 test image. There are Debian for s390 CD images and instruction how to install them

Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction

2013-01-09 Thread Wenchao Xia
于 2013-1-9 20:44, Stefan Hajnoczi 写道: On Mon, Jan 07, 2013 at 03:28:06PM +0800, Wenchao Xia wrote: This patch switch to internal common API to take group external snapshots from qmp_transaction interface. qmp layer simply does a translation from user input. Signed-off-by: Wenchao Xia ---

Re: [Qemu-devel] [PATCH 1/2] oslib-win32: add lock for gmtime_r()

2013-01-09 Thread Wenchao Xia
于 2013-1-10 1:06, Stefan Weil 写道: Il 09/01/2013 07:18, Wenchao Xia ha scritto: Also changed the caller of gmtime() to gmtime_r(). Should be a separate patch. There is already a pending patch which replaces gmtime, localtime: http://patchwork.ozlabs.org/patch/210250/ Stefan Should o

Re: [Qemu-devel] [PATCH 1/2] oslib-win32: add lock for gmtime_r()

2013-01-09 Thread Wenchao Xia
于 2013-1-9 17:47, Paolo Bonzini 写道: Il 09/01/2013 07:18, Wenchao Xia ha scritto: Also changed the caller of gmtime() to gmtime_r(). Should be a separate patch. Also, what is the reason to add this lock? They are already protected by the BQL. Paolo localtime_r() will be used in interna

[Qemu-devel] [PATCH] hw/pc.c: Fix converting of ioport_register* to MemoryRegion

2013-01-09 Thread Julien Grall
The commit 258711 introduced MemoryRegion to replace ioport_region* for ioport 80h and F0h. A MemoryRegion needs to have both read and write callback otherwise a segfault will occur when an access is made. The previous behaviour of this both ioport is to return 0x. So keep this beh

Re: [Qemu-devel] [Bug 108996 V2] hw/dma.c: Fix converting of ioport_register* to MemoryRegion

2013-01-09 Thread Julien Grall
On Wed, Dec 19, 2012 at 12:09 PM, Julien Grall wrote: > The commit 582299336879504353e60c7937fbc70fea93f3da introduced a 1-shift for > some offset in dma emulation. > > Before the previous commit, which converted ioport_register_* to MemoryRegion, > the DMA controller registered 8 ioports with the

Re: [Qemu-devel] [PATCH V2 08/11] qmp: add interface query-snapshots

2013-01-09 Thread Eric Blake
On 01/08/2013 10:12 PM, Wenchao Xia wrote: > This interface now return valid internal snapshots. > > +Each json-object contain the following: > + > +- "id": unique snapshot id (json-string) > +- "name": internal snapshot name (json-string) > +- "vm-state-size": size of the VM state (json-int)

Re: [Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2013-01-09 Thread Peter Schaefer
Am 1/8/2013 6:08 PM, Serge Hallyn wrote: > > (replying to comment #12) could you please follow up on comments #6 and > #7? > > It also would be worthwhile, at this point, checking whether latest > upstream (1.3) is still broken. Just a short note: I somehow produced a backported *.deb for 1.3.0 an

Re: [Qemu-devel] [PATCH V2 06/11] qmp: add interface query-images.

2013-01-09 Thread Eric Blake
On 01/08/2013 10:12 PM, Wenchao Xia wrote: > This mirror function will return all image info including > snapshots. Now Qemu have both query-images and query-block > interfaces. > > V2: > Redesign the interface, it will show related block device name now. > Added counter part in qmp-commands

Re: [Qemu-devel] [PATCH 13/13] vm-snapshot-save: add force parameter

2013-01-09 Thread Eric Blake
On 01/09/2013 08:18 AM, Pavel Hrdina wrote: > HMP command "savevm" now takes extra optional force parameter to specifi > whether s/specifi/specify/ > replace existing snapshot or not. > > QMP command "vm-snapshot-save" has also extra optional force parameter and > name parameter isn't optional

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 02:21:50PM -0800, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Michael S. Tsirkin > had to walk into mine at 14:07:53 on Wednesday 09 January 2013 and say: > > > On Wed, Jan 09, 2013 at 01:50:39PM -0600, Anthony Liguori wrote: > > > I figured

Re: [Qemu-devel] [PATCH 12/13] savevm: update return value from qemu_savevm_state

2013-01-09 Thread Eric Blake
On 01/09/2013 08:18 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > savevm.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > @@ -2189,6 +2189,7 @@ void qmp_vm_snapshot_save(bool has_name, const char > *name, Error **errp) > error_setg(errp, "Failed to

Re: [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way

2013-01-09 Thread Eric Blake
On 01/07/2013 12:27 AM, Wenchao Xia wrote: > These patch added a seperated layer to take internal or external snapshots > in a unified way, the granularity is block device, so other functions can > just combine the request and submit, such as group snapshot, savevm. > > Total goal are: > Live

Re: [Qemu-devel] [PATCH 07/13] qapi: Convert savevm

2013-01-09 Thread Eric Blake
On 01/09/2013 08:18 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > hmp-commands.hx | 4 ++-- > hmp.c | 9 + > hmp.h | 1 + > include/sysemu/sysemu.h | 1 - > qapi-schema.json| 18 ++ > qmp-commands.hx

Re: [Qemu-devel] [PATCH 31/32] usbredir: Add support for buffered bulk input (v2)

2013-01-09 Thread Hans de Goede
Hi, On 01/09/2013 09:52 PM, Blue Swirl wrote: diff --git a/hw/usb/quirks-ftdi-ids.h b/hw/usb/quirks-ftdi-ids.h new file mode 100644 index 000..57c12ef --- /dev/null +++ b/hw/usb/quirks-ftdi-ids.h @@ -0,0 +1,1255 @@ +/* + * vendor/product IDs (VID/PID) of devices using FTDI USB serial conv

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Michael S. Tsirkin had to walk into mine at 14:07:53 on Wednesday 09 January 2013 and say: > On Wed, Jan 09, 2013 at 01:50:39PM -0600, Anthony Liguori wrote: > > I figured this would be the case but this is where a comment in the code > > o

Re: [Qemu-devel] [PATCH] ui/vnc: VA API based H.264 encoding for VNC framebuffer updates

2013-01-09 Thread Alexander Graf
On 09.01.2013, at 21:25, Anthony Liguori wrote: > Hi, > > David Verbeiren writes: [...] > >> + >> +int frame_w = ds_get_width(vs->ds); >> +int frame_h = ds_get_height(vs->ds); >> + >> +/* first call for this frame: perform encoding */ >> +if ((frame.data == NULL) || (frame.co

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Michael S. Tsirkin had to walk into mine at 02:51:00 on Wednesday 09 January 2013 and say: > Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > qemu started updating ICS register when interrupt > is sent, with the intent to match spec

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 01:50:39PM -0600, Anthony Liguori wrote: > I figured this would be the case but this is where a comment in the code > or commit message would have helped a lot in avoiding future confusion. > > Regards, > > Anthony Liguori I just sent a documentation patch, please take a

Re: [Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 08:39:08PM +, Blue Swirl wrote: > On Mon, Jan 7, 2013 at 4:11 PM, Michael S. Tsirkin wrote: > > On Sun, Jan 06, 2013 at 08:04:39PM +, Blue Swirl wrote: > >> On Sun, Jan 6, 2013 at 6:25 PM, Andreas Färber wrote: > >> > Am 06.01.2013 14:17, schrieb Alexander Graf: >

[Qemu-devel] [PATCH] e1000: document ICS read behaviour

2013-01-09 Thread Michael S. Tsirkin
Add code comment to clarify the reason we set ICS with ICR: the reason was previously undocumented and git log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) confused rather than clarified the comments. Digging in the mailing list archives gives the real reason https://lists.gnu.org/archive/html

Re: [Qemu-devel] [PATCH 57/61] virtio : remove the function pointer.

2013-01-09 Thread KONRAD Frédéric
On 09/01/2013 21:40, Blue Swirl wrote: On Mon, Jan 7, 2013 at 6:41 PM, wrote: From: KONRAD Frederic This remove the function pointer in VirtIODevice, and use only VirtioDeviceClass function pointer. It should be applied after all the device have been refactored. Signed-off-by: KONRAD Freder

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 09:30:43AM -0800, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Michael S. Tsirkin > had to walk into mine at 02:51:00 on Wednesday 09 January 2013 and say: > > > Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > > qemu started updating

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 10:22:58PM +0100, Paolo Bonzini wrote: > Il 09/01/2013 21:40, Anthony Liguori ha scritto: > >> > Yes, but this can only be done after looking at all PCI devices that > >> > have buses below (of which the bridge is a special case). And Anthony > >> > also metioned using a ne

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

2013-01-09 Thread Paolo Bonzini
Il 09/01/2013 21:40, Anthony Liguori ha scritto: >> > Yes, but this can only be done after looking at all PCI devices that >> > have buses below (of which the bridge is a special case). And Anthony >> > also metioned using a new method of PCIDevice instead of device_reset. > Sorry, what's the bug

Re: [Qemu-devel] [PATCH 2/2] QEMU-AER: Qemu changes to support AER for VFIO-PCI devices

2013-01-09 Thread Blue Swirl
On Wed, Jan 9, 2013 at 6:26 AM, Pandarathil, Vijaymohan R wrote: > - Create eventfd per vfio device assigned to a guest and register an > event handler > > - This fd is passed to the vfio_pci driver through a new ioctl > > - When the device encounters an error, th

Re: [Qemu-devel] [PATCH v2 0/8] target-mips: DSP ASE fixes and cleanup

2013-01-09 Thread Blue Swirl
On Wed, Jan 9, 2013 at 3:27 PM, Aurelien Jarno wrote: > This patch series contains some fixes and cleanup following the merge > of the DSP ASE patches. Please fix the spacing in the for loops. > > Changes v1 -> v2: > - patch 1: unchanged > - patch 2: new patch as suggested by Richard Henderson

Re: [Qemu-devel] [PATCH v2 7/8] target-mips: use DSP unions for reduction add instructions

2013-01-09 Thread Blue Swirl
On Wed, Jan 9, 2013 at 3:27 PM, Aurelien Jarno wrote: > Signed-off-by: Aurelien Jarno > --- > target-mips/dsp_helper.c | 32 +++- > 1 file changed, 15 insertions(+), 17 deletions(-) > > diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c > index 1bc77a2

Re: [Qemu-devel] [PATCH v2 6/8] target-mips: use DSP unions for unary DSP operators

2013-01-09 Thread Blue Swirl
On Wed, Jan 9, 2013 at 3:27 PM, Aurelien Jarno wrote: > This allow to reduce the number of macros. > > Signed-off-by: Aurelien Jarno > --- > target-mips/dsp_helper.c | 124 > -- > 1 file changed, 42 insertions(+), 82 deletions(-) > > diff --git a/tar

Re: [Qemu-devel] [PATCH v2 5/8] target-mips: use DSP unions for binary DSP operators

2013-01-09 Thread Blue Swirl
On Wed, Jan 9, 2013 at 3:27 PM, Aurelien Jarno wrote: > This allow to reduce the number of macros. > > Signed-off-by: Aurelien Jarno > --- > target-mips/dsp_helper.c | 384 > ++ > 1 file changed, 116 insertions(+), 268 deletions(-) > > diff --git a/t

Re: [Qemu-devel] [PATCH 1/3] split acpi pci hotplug code into separate file

2013-01-09 Thread Blue Swirl
On Wed, Jan 9, 2013 at 3:41 PM, Gerd Hoffmann wrote: > Also some minor code restructions along the way: > > * create a new struct for acpi pci hotplug state > * rename functions so they no longer carry piix in the name > > Signed-off-by: Gerd Hoffmann > --- > hw/Makefile.objs |2 +- >

Re: [Qemu-devel] [PATCH] gdbstub: Implement "Xfer:spaces" requests. This is a part of Codebench IDE integration.

2013-01-09 Thread Blue Swirl
On Mon, Jan 7, 2013 at 11:31 PM, Alex Rozenman wrote: > Signed-off-by: Alex Rozenman > --- > gdbstub.c | 113 > + > 1 file changed, 113 insertions(+) > > diff --git a/gdbstub.c b/gdbstub.c > index a8dd437..564bde1 100644 > --- a/gdbst

Re: [Qemu-devel] [PATCH 11/12] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

2013-01-09 Thread Blue Swirl
On Tue, Jan 8, 2013 at 11:00 PM, Michael Roth wrote: > From: Tomoki Sekiyama > > To use the online disk snapshot for online-backup, application-level > consistency of the snapshot image is required. However, currently the > guest agent can provide only filesystem-level consistency, and the > snap

Re: [Qemu-devel] [RFC PATCH] PIIX: reset the VM when the Reset Control Register's RCPU bit gets set

2013-01-09 Thread Blue Swirl
On Tue, Jan 8, 2013 at 9:44 PM, Laszlo Ersek wrote: > From : > > Traditional PCI config space access is achieved by writing a 32 bit > value to io port 0xcf8 to identify the bus, device, function and config > register. Port 0xcfc then contains the regis

Re: [Qemu-devel] QCOW2 deduplication design

2013-01-09 Thread Benoît Canet
> > Two GTrees are used to give access to the hashes : one indexed by hash and > > one other indexed by physical offset. > > What is the GTree indexed by physical offset used for? I think I can get rid of the second GTree for ram based deduplication. It need to: -Start qcow2 with the deduplicati

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-09 Thread Blue Swirl
On Tue, Jan 8, 2013 at 10:27 AM, Tim Hardeck wrote: > This patch adds basic Websocket Protocol version 13 - RFC 6455 - support > to QEMU VNC. Binary encoding support on the client side is mandatory. > > Because of the GnuTLS requirement the Websockets implementation is > optional (--enable-vnc-ws)

[Qemu-devel] [PATCH 1/2] vfio-pci: Make host MSI-X enable track guest

2013-01-09 Thread Alex Williamson
Guests typically enable MSI-X with all of the vectors in the MSI-X vector table masked. Only when the vector is enabled does the vector get unmasked, resulting in a vector_use callback. These two points, enable and unmask, correspond to pci_enable_msix() and request_irq() for Linux guests. Some

Re: [Qemu-devel] [PATCH] virtio-pci: replace byte swap hack

2013-01-09 Thread Blue Swirl
On Mon, Jan 7, 2013 at 4:11 PM, Michael S. Tsirkin wrote: > On Sun, Jan 06, 2013 at 08:04:39PM +, Blue Swirl wrote: >> On Sun, Jan 6, 2013 at 6:25 PM, Andreas Färber wrote: >> > Am 06.01.2013 14:17, schrieb Alexander Graf: >> >> >> >> On 30.12.2012, at 13:55, Blue Swirl wrote: >> >> >> >>> Re

Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions

2013-01-09 Thread Blue Swirl
On Tue, Jan 8, 2013 at 9:03 AM, Stefan Hajnoczi wrote: > On Mon, Jan 07, 2013 at 03:38:39PM -0500, Nickolai Zeldovich wrote: >> memcpy() for overlapping regions is undefined behavior; use memmove() >> instead in readline_hist_add(). >> >> Signed-off-by: Nickolai Zeldovich >> --- >> readline.c |

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

2013-01-09 Thread Anthony Liguori
Paolo Bonzini writes: > Il 09/01/2013 13:10, Michael S. Tsirkin ha scritto: >> OK you mean like this this? Completely untested - if you >> and Anthony think we need this change please let me know >> and I'll test and repost. >> >> --> >> >> pci: make secondary bus reset explicit >> >> Signed-o

Re: [Qemu-devel] [PATCH 57/61] virtio : remove the function pointer.

2013-01-09 Thread Blue Swirl
On Mon, Jan 7, 2013 at 6:41 PM, wrote: > From: KONRAD Frederic > > This remove the function pointer in VirtIODevice, and use only > VirtioDeviceClass function pointer. It should be applied after all > the device have been refactored. > > Signed-off-by: KONRAD Frederic > --- > hw/9pfs/virtio-9p

Re: [Qemu-devel] [PATCH] ui/vnc: VA API based H.264 encoding for VNC framebuffer updates

2013-01-09 Thread Anthony Liguori
Hi, David Verbeiren writes: > This patch implements H.264 encoding of the VNC framebuffer updates > using hardware acceleration through the VA API. > > This is experimental support to let the community explore the possibilities > offered by the potential bandwidth and latency reductions that H.2

[Qemu-devel] vhost-net thread getting stuck ?

2013-01-09 Thread Chegu Vinod
Hello, 'am running into an issue with the latest bits. [ Pl. see below. The vhost thread seems to be getting stuck while trying to memcopy...perhaps a bad address?. ] Wondering if this is a known issue or some recent regression ? 'am using the latest qemu (from qemu.git) and the latest kvm.

[Qemu-devel] [PATCH 2/2] vfio-pci: Loosen sanity checks to allow future features

2013-01-09 Thread Alex Williamson
VFIO_PCI_NUM_REGIONS and VFIO_PCI_NUM_IRQS should never have been used in this manner as it locks a specific kernel implementation. Future features may introduce new regions or interrupt entries (VGA may add legacy ranges, AER might add an IRQ for error signalling). Fix this before it gets us into

[Qemu-devel] [PULL 0/2] vfio-pci: Fixes for 1.4 & stable

2013-01-09 Thread Alex Williamson
Anthony, The following changes since commit 560c30b1db1d40fe45c5104185367c4de43399d3: Merge remote-tracking branch 'kraxel/usb.75' into staging (2013-01-08 10:36:20 -0600) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/qemu-1.4-vfio-20130109.0 for yo

Re: [Qemu-devel] [PATCH 10/11] chardev: add socket chardev support to chardev-add (qmp)

2013-01-09 Thread Eric Blake
On 01/07/2013 06:55 AM, Gerd Hoffmann wrote: > qemu_chr_open_socket is splitted into two functions. All initialization s/splitted/split/ > after creating the socket file handler is splitted away into the new and again > qemu_chr_open_socket_fd function. > > chr->filename doesn't get filled fr

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Anthony Liguori
Bill Paul writes: > Of all the gin joints in all the towns in all the world, Michael S. Tsirkin > had to walk into mine at 02:51:00 on Wednesday 09 January 2013 and say: > >> Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, >> qemu started updating ICS register when interrupt >> is sent, w

[Qemu-devel] [RFC 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-09 Thread Eduardo Habkost
This will allow each architecture to define how the VCPU ID is set on the KVM_CREATE_VCPU ioctl call. Signed-off-by: Eduardo Habkost --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin Cc: Gleb Natapov Cc: Marcelo Tosatti Changes v2: - Get CPUState as argument instead of CPUArchState --- in

[Qemu-devel] [RFC 12/12] pc: Generate APIC IDs according to CPU topology

2013-01-09 Thread Eduardo Habkost
This keeps compatibility on machine-types pc-1.2 and older, and prints a warning in case the requested configuration won't get the correct topology. I couldn't think of a better way to warn about broken topology when in compat mode other than using error_report(). The warning message will be proba

[Qemu-devel] [RFC 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-09 Thread Eduardo Habkost
This is a cleanup that tries to solve two small issues: - We don't need a separate kvm_pv_eoi_features variable just to keep a constant calculated at compile-time, and this style would require adding a separate variable (that's declared twice because of the CONFIG_KVM ifdef) for each fea

[Qemu-devel] [RFC 08/12] cpus.h: Make constant smp_cores/smp_threads available on *-user

2013-01-09 Thread Eduardo Habkost
The code that calculates the APIC ID will use smp_cores/smp_threads, so just define them as 1 on *-user to avoid #ifdefs in the code. Signed-off-by: Eduardo Habkost --- include/sysemu/cpus.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/sysemu/cpus.h b/include/sysemu/cpus.h

[Qemu-devel] [RFC 11/12] target-i386: Topology & APIC ID utility functions

2013-01-09 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: - Support 32-bit APIC IDs (in case x2APIC is going to be used) - Coding style changes - Use TARGET_I386_TOPOLOGY_H instead of __QEMU_X86_TOPOLOGY_H__ - Rename topo_make_apic_id() to topo_apicid_for_cpu() - Rename __make_apicid() to topo_mak

[Qemu-devel] [RFC 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-09 Thread Eduardo Habkost
Currently, the pc-1.4 machine init function enables PV EOI and then calls the pc-1.2 machine init function. The problem with this approach is that now we can't enable any compatibility code inside the pc-1.2 init function because it would enable the compatibility behavior on pc-1.3 and pc-1.4 as we

[Qemu-devel] [RFC 05/12] target-i386: kvm: Set vcpu_id to APIC ID instead of CPU index

2013-01-09 Thread Eduardo Habkost
The CPU ID in KVM is supposed to be the APIC ID, so change the KVM_CREATE_VCPU call to match it. The current behavior didn't break anything yet because today the APIC ID is assumed to be equal to the CPU index, but this won't be true in the future. Signed-off-by: Eduardo Habkost --- Cc: k...@vger

[Qemu-devel] [RFC 06/12] fw_cfg: Remove FW_CFG_MAX_CPUS from fw_cfg_init()

2013-01-09 Thread Eduardo Habkost
PC will not use max_cpus for that field, so move it outside the common code so it can use a different value on PC. Signed-off-by: Eduardo Habkost --- hw/fw_cfg.c | 1 - hw/pc.c | 2 +- hw/ppc_newworld.c | 1 + hw/ppc_oldworld.c | 1 + hw/sun4m.c| 3 +++ hw/sun4u.c

[Qemu-devel] [RFC 10/12] tests: Support target-specific unit tests

2013-01-09 Thread Eduardo Habkost
To make unit tests that depend on target-specific files, use check-unit--y and test-obj--y. Signed-off-by: Eduardo Habkost --- tests/Makefile | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index b09a343..fa96d1a 100644 --- a/t

[Qemu-devel] [RFC 09/12] pc: Set fw_cfg data based on APIC ID calculation

2013-01-09 Thread Eduardo Habkost
This changes FW_CFG_MAX_CPUS and FW_CFG_NUMA to use apic_id_for_cpu(), so the NUMA table can be based on the APIC IDs, instead of CPU index (SeaBIOS knows nothing about CPU indexes, just APIC IDs). Signed-off-by: Eduardo Habkost --- Changes v2: - Get PC object as argument - Add more detailed co

[Qemu-devel] [RFC 07/12] target-i386/cpu: Introduce apic_id_for_cpu() function

2013-01-09 Thread Eduardo Habkost
This function will be used by both the CPU initialization code and the fw_cfg table initialization code. Later this function will be updated to generate APIC IDs according to the CPU topology. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 17 - target-i386/cpu.h | 2 ++

[Qemu-devel] [RFC 01/12] kvm: add KVM_FEATURE_CLOCKSOURCE_STABLE_BIT fake #define

2013-01-09 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin Cc: Gleb Natapov Cc: Marcelo Tosatti --- include/sysemu/kvm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index 6bdd513..22acf91 100644 --- a/include/sysemu/kv

[Qemu-devel] [RFC 00/12] target-i386: Fix APIC-ID-based topology (v4)

2013-01-09 Thread Eduardo Habkost
This series uses a much simpler approach than the previous versions: - The APIC ID calculation code is now inside cpu.c - It doesn't require touching the PC CPU creation code at all - It simply uses a static variable to enable the compat behavior on pc-1.3 and older - I considered making

Re: [Qemu-devel] [PATCH v2 0/8] target-mips: DSP ASE fixes and cleanup

2013-01-09 Thread Richard Henderson
On 01/09/2013 07:27 AM, Aurelien Jarno wrote: Aurelien Jarno (8): target-mips: fix DSP loads with rd = 0 target-mips: copy insn_flags in DisasContext target-mips: generate a reserved instruction exception on CPU without DSP target-mips: add unions to access DSP elements target-mips

Re: [Qemu-devel] [Xen-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2013-01-09 Thread Stefano Stabellini
On Wed, 19 Dec 2012, Konrad Rzeszutek Wilk wrote: > On Wed, May 09, 2012 at 01:42:41PM +0100, Stefano Stabellini wrote: > > On Thu, 26 Apr 2012, Konrad Rzeszutek Wilk wrote: > > > On Wed, Apr 25, 2012 at 01:23:35PM +0200, Christoph Hellwig wrote: > > > > On Wed, Apr 25, 2012 at 12:21:53PM +0100, St

[Qemu-devel] [PATCH v2] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2013-01-09 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini Changes in v2: - BLKIF_OP_FLUSH_DISKCACHE implies a preflush, not a postflush. diff --git a/hw/xen_disk.c b/hw/xen_disk.c index a6a64a2..2d0de09 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c @@ -182,12 +182,11 @@ static int ioreq_parse(struct ioreq *ioreq)

Re: [Qemu-devel] [PATCH 06/11] chardev: add file chardev support to chardev-add (qmp)

2013-01-09 Thread Eric Blake
On 01/07/2013 06:55 AM, Gerd Hoffmann wrote: > Add support for file chardevs. Output file is mandatory, > input file is optional. Both file names and file descriptor > passing is supported. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json |9 +- > qemu-char.c | 77 > ++

Re: [Qemu-devel] [PATCH 2/2] QEMU-AER: Qemu changes to support AER for VFIO-PCI devices

2013-01-09 Thread Alex Williamson
On Wed, 2013-01-09 at 06:26 +, Pandarathil, Vijaymohan R wrote: > - Create eventfd per vfio device assigned to a guest and register an > event handler > > - This fd is passed to the vfio_pci driver through a new ioctl > > - When the device encounters an error, the

Re: [Qemu-devel] [PATCH 1/2] VFIO-AER: Vfio-pci driver changes for supporting AER

2013-01-09 Thread Alex Williamson
On Wed, 2013-01-09 at 06:26 +, Pandarathil, Vijaymohan R wrote: > - New ioctl which is used to pass the eventfd that is signaled when > an error occurs in the vfio_pci_device > > - Register pci_error_handler for the vfio_pci driver > > - When the device encounters

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 09:30:43AM -0800, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Michael S. Tsirkin > had to walk into mine at 02:51:00 on Wednesday 09 January 2013 and say: > > > Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > > qemu started updating

Re: [Qemu-devel] [libvirt] [Qemu PATCH v2] add a boot option to do strict boot

2013-01-09 Thread Gleb Natapov
On Wed, Jan 09, 2013 at 12:28:57PM -0500, Laine Stump wrote: > On 01/09/2013 10:22 AM, Daniel P. Berrange wrote: > > On Wed, Jan 09, 2013 at 08:14:07AM -0700, Eric Blake wrote: > >> On 01/09/2013 01:39 AM, Amos Kong wrote: > >>> Current seabios will try to boot from selected devices first, > >>> if

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

2013-01-09 Thread Paolo Bonzini
Il 09/01/2013 13:10, Michael S. Tsirkin ha scritto: > OK you mean like this this? Completely untested - if you > and Anthony think we need this change please let me know > and I'll test and repost. > > --> > > pci: make secondary bus reset explicit > > Signed-off-by: Michael S. Tsirkin Yes, bu

Re: [Qemu-devel] [PATCH 11/11] chardev: add pty chardev support to chardev-add (qmp)

2013-01-09 Thread Eric Blake
On 01/07/2013 06:55 AM, Gerd Hoffmann wrote: > The ptsname is returned directly, so there is no need to > use query-chardev to figure the pty device path. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json |7 ++- > qemu-char.c | 24 +--- > 2 files chang

Re: [Qemu-devel] [libvirt] [Qemu PATCH v2] add a boot option to do strict boot

2013-01-09 Thread Laine Stump
On 01/09/2013 10:22 AM, Daniel P. Berrange wrote: > On Wed, Jan 09, 2013 at 08:14:07AM -0700, Eric Blake wrote: >> On 01/09/2013 01:39 AM, Amos Kong wrote: >>> Current seabios will try to boot from selected devices first, >>> if they are all failed, seabios will also try to boot from >>> un-selecte

[Qemu-devel] [PATCH] ui/vnc: VA API based H.264 encoding for VNC framebuffer updates

2013-01-09 Thread David Verbeiren
This patch implements H.264 encoding of the VNC framebuffer updates using hardware acceleration through the VA API. This is experimental support to let the community explore the possibilities offered by the potential bandwidth and latency reductions that H.264 encoding allows. This may be particul

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

2013-01-09 Thread Stefan Weil
> On Tue, Jan 08, 2013 at 01:06:19AM +0100, q...@buildbot.b1-systems.de > wrote: >> The Buildbot has detected a new failure on builder block_mingw32 while >> building qemu. >> Full details are available at: >> http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/439 >> >> Buildbot URL:

Re: [Qemu-devel] [PATCH 04/11] chardev: add qmp hotplug commands, with null chardev support

2013-01-09 Thread Eric Blake
On 01/07/2013 06:55 AM, Gerd Hoffmann wrote: > Add chardev-add and chardev-remove qmp commands. Hotplugging > a null chardev is supported for now, more will be added later. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 32 q> qemu-char.c |

[Qemu-devel] [PATCH 03/13] savevm: add error parameter to qemu_savevm_state_begin()

2013-01-09 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- include/sysemu/sysemu.h | 3 ++- migration.c | 2 +- savevm.c| 7 +-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 28a783e..e50f990 100644 --- a/include/sysem

[Qemu-devel] [PATCH 11/13] savevm: update return value from qemu_savevm_state_complete

2013-01-09 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- savevm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/savevm.c b/savevm.c index f204748..f9858cc 100644 --- a/savevm.c +++ b/savevm.c @@ -1692,7 +1692,7 @@ int qemu_savevm_state_complete(QEMUFile *f, Error **errp) trace_savevm_

[Qemu-devel] [PATCH V2 7/7] virtio-s390-device: create a virtio-s390-bus during init.

2013-01-09 Thread fred . konrad
From: KONRAD Frederic A virtio-s390-bus is created during the init. So one VirtIODevice can be connected on the virtio-s390-device through this bus. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 2 ++ hw/s390-virtio-bus.h | 1 + 2 files changed, 3 insertions(+) diff --git a/hw/s39

Re: [Qemu-devel] [PATCH 1/2] oslib-win32: add lock for gmtime_r()

2013-01-09 Thread Stefan Weil
> Il 09/01/2013 07:18, Wenchao Xia ha scritto: >> Also changed the caller of gmtime() to gmtime_r(). > > Should be a separate patch. There is already a pending patch which replaces gmtime, localtime: http://patchwork.ozlabs.org/patch/210250/ Stefan

Re: [Qemu-devel] [PULL 0/12] qemu-ga: error handling improvements and fsfreeze hooks

2013-01-09 Thread Anthony Liguori
Pulled, thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH 10/13] savevm: update return value from qemu_savevm_state_begin

2013-01-09 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- savevm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/savevm.c b/savevm.c index 930ef65..f204748 100644 --- a/savevm.c +++ b/savevm.c @@ -1600,17 +1600,17 @@ int qemu_savevm_state_begin(QEMUFile *f, if (ret < 0) {

[Qemu-devel] [PATCH 04/13] savevm: add error parameter to qemu_savevm_state_iterate()

2013-01-09 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- include/sysemu/sysemu.h | 2 +- migration.c | 2 +- savevm.c| 19 --- 3 files changed, 14 insertions(+), 9 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index e50f990..afc1fe6 100644 ---

[Qemu-devel] [PATCH v2 7/8] target-mips: use DSP unions for reduction add instructions

2013-01-09 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-mips/dsp_helper.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c index 1bc77a2..ea7a99f 100644 --- a/target-mips/dsp_helper.c +++ b/target-mips/ds

  1   2   3   >