Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-04 Thread Liu Yuan
On 01/05/2013 01:29 PM, Liu Yuan wrote: > On 01/05/2013 12:40 PM, Liu Yuan wrote: >> On 01/05/2013 12:38 AM, Stefan Hajnoczi wrote: >>> Hi Yuan, >>> BDRV_O_NOCACHE means bypass host page cache (O_DIRECT). >>> >>> BDRV_O_CACHE_WB specifies the cache semantics that the guest sees - that >>> means whe

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-04 Thread Liu Yuan
On 01/05/2013 12:40 PM, Liu Yuan wrote: > On 01/05/2013 12:38 AM, Stefan Hajnoczi wrote: >> Hi Yuan, >> BDRV_O_NOCACHE means bypass host page cache (O_DIRECT). >> >> BDRV_O_CACHE_WB specifies the cache semantics that the guest sees - that >> means whether the disk cache is writethrough or writeback

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-04 Thread Liu Yuan
On 01/05/2013 12:38 AM, Stefan Hajnoczi wrote: > Hi Yuan, > BDRV_O_NOCACHE means bypass host page cache (O_DIRECT). > > BDRV_O_CACHE_WB specifies the cache semantics that the guest sees - that > means whether the disk cache is writethrough or writeback. > > In other words, BDRV_O_NOCACHE is a hos

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

2013-01-04 Thread Anthony Liguori
Andreas Färber writes: > Hi, > > Am 02.01.2013 19:07, schrieb Anthony Liguori: >> 2) Patches that no longer apply via git am --3way will receive a >> notification. > > Isn't Nacked-by too strong of a notification for a mere technical need > for a rebase (compared to a rejection of its conc

[Qemu-devel] QEMU build fails with Clang?

2013-01-04 Thread Brad Smith
Supposedly QEMU is able to build with Clang and yet trying to do so I am seeing the build fail as follows.. Comments? gmake[1]: Entering directory `/home/brad/qemu/pc-bios/optionrom' clang -I. -I/home/brad/qemu -I/home/brad/qemu/include -I/home/brad/qemu/libcacard -Wall -Wstrict-prototypes -Wer

[Qemu-devel] [PATCH 7/8] alpha-linux-user: Fix sigaction

2013-01-04 Thread Richard Henderson
Unconditional bswap replaced by __get_user/__put_user. Signed-off-by: Richard Henderson --- linux-user/signal.c | 22 -- linux-user/syscall_defs.h | 2 +- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 95

[Qemu-devel] [PATCH 5/8] bswap: Rewrite cpu_to_u with {ld, st}__p

2013-01-04 Thread Richard Henderson
We've now optimized the ld/st versions; reuse that for the "legacy" versions. Always use inlines so that we get the type checking that we expect. Signed-off-by: Richard Henderson --- include/qemu/bswap.h | 147 +++ 1 file changed, 53 insertions(+)

[Qemu-devel] [PATCH 2/8] bswap: Tidy base definitions of bswapN

2013-01-04 Thread Richard Henderson
Move the bswap_N -> bswapN wrappers inside CONFIG_BYTESWAP_H. Change the ultimate fallback defintions from macros to inline functions. The proper types recieved by the function arguments means we can remove unnecessary casts, making the code more readable. Signed-off-by: Richard Henderson --- i

[Qemu-devel] [PATCH 4/8] bswap: Rewrite all ld__p functions

2013-01-04 Thread Richard Henderson
Use the new host endian unaligned access functions instead of open coding byte-by-byte references. Remove assembly special cases for i386 and ppc -- we've now exposed the operation to the compiler sufficiently for these to be optimized automatically. Signed-off-by: Richard Henderson --- include

[Qemu-devel] [PATCH 1/8] fdt: Use bswapN instead of bswap_N

2013-01-04 Thread Richard Henderson
Fixes the libfdt enabled build for hosts that have . The code at the beginning of qemu/bswap.h is attempting to standardize on bswapN. In the case of CONFIG_MACHINE_BSWAP_H, this is all we get. In the case of CONFIG_BYTESWAP_H, we get bswap_N from the system header and then wrap these with inline

[Qemu-devel] [PATCH 6/8] linux-user: Rewrite __get_user/__put_user with __builtin_choose_expr

2013-01-04 Thread Richard Henderson
The previous formuation with multiple assignments to __typeof(*hptr) falls down when hptr is qualified const. E.g. with const struct S *p, p->f is also qualified const. With this formulation, there's no assignment to any local variable. Signed-off-by: Richard Henderson --- linux-user/qemu.h |

Re: [Qemu-devel] [PATCH] build: change dist target to use xz

2013-01-04 Thread Brad Smith
On Fri, Jan 04, 2013 at 05:41:41PM -0700, Eric Blake wrote: > On 01/04/2013 05:28 PM, Brad Smith wrote: > > On Thu, Aug 02, 2012 at 06:08:15AM -0400, Brad Smith wrote: > >> If a compression format other than gzip is used we might > >> as well move to xz instead of bzip2. > > Agreed, many projects

[Qemu-devel] [PATCH 3/8] bswap: Add host endian unaligned access functions

2013-01-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/qemu/bswap.h | 51 ++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h index b2a8f94..381554b 100644 --- a/include/qemu/bswap.h +++ b/include/qemu

Re: [Qemu-devel] [PATCH] build: change dist target to use xz

2013-01-04 Thread Eric Blake
On 01/04/2013 05:28 PM, Brad Smith wrote: > On Thu, Aug 02, 2012 at 06:08:15AM -0400, Brad Smith wrote: >> If a compression format other than gzip is used we might >> as well move to xz instead of bzip2. Agreed, many projects are dropping bzip2 as irrelevant (slower than the more-widely-available

[Qemu-devel] [PATCH 8/8] user: Consider symbolic links as possible directories

2013-01-04 Thread Richard Henderson
Commit 2296f194dfde4c0a54f249d3fdb8c8ca21dc611b reduced the number of syscalls performed during user emulation startup, but failed to consider the use of symbolic links in creating directory structures. Signed-off-by: Richard Henderson --- path.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

[Qemu-devel] [PATCH v2 0/8] linux-user fixes

2013-01-04 Thread Richard Henderson
Version 1 was way back in October, http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg02854.html wherein Blue asked me to re-do the unaligned access function part of the patch. I've now done that, as patch 3 of this series. But having a look at was frought with ugliness, and I've now c

[Qemu-devel] [PATCH] Modification to remove a h2g() call and calculate properly instead

2013-01-04 Thread Samuel Seay
Peter Maydell recommended the change to be more proper. The result was tested and shows coming up with the same proper value. Signed-off-by: Samuel Seay --- linux-user/signal.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index

Re: [Qemu-devel] [PATCH] build: change dist target to use xz

2013-01-04 Thread Brad Smith
On Thu, Aug 02, 2012 at 06:08:15AM -0400, Brad Smith wrote: > If a compression format other than gzip is used we might > as well move to xz instead of bzip2. 11.8M qemu-1.3.0.tar.gz 9.8M qemu-1.3.0.tar.bz2 7.8M qemu-1.3.0.tar.xz diff --git a/Makefile b/Makefile index a7ac04b..9073a86 100644 ---

Re: [Qemu-devel] [RFC V4 12/30] qcow2: Load and save deduplication table header extension.

2013-01-04 Thread Eric Blake
On 01/02/2013 09:16 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block/qcow2.c | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 410d3c1..9a7177b 100644 > --- a/block/qcow2.c > +++ b/block/qco

Re: [Qemu-devel] [PATCH 06/11] qmp: add interface query-image

2013-01-04 Thread Eric Blake
On 12/29/2012 01:45 AM, Wenchao Xia wrote: > This mirror function will return all image info including > snapshots. Now Qemu have both query-image and query-block > interfaces, and qemu-img share the code for image info > retrieving with qemu emulator. > > Signed-off-by: Wenchao Xia > --- > bl

[Qemu-devel] [PATCH] PPC: Bring EPR support closer to reality

2013-01-04 Thread Alexander Graf
We already used to support the external proxy facility of FSL MPICs, but only implemented it halfway correctly. This patch adds support for * dynamic enablement of the EPR facility * interrupt acknowledgement only when the interrupt is delivered This way the implementation now is closer to r

Re: [Qemu-devel] [PATCH] PPC: Bring EPR support closer to reality

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 20:07, Scott Wood wrote: > On 01/04/2013 12:54:51 PM, Alexander Graf wrote: >> On 04.01.2013, at 19:50, Scott Wood wrote: >> > On 01/04/2013 04:24:59 AM, Alexander Graf wrote: >> >> msi_supported = true; >> >> list = list_be; >> >> diff --git a/target-ppc/Makefil

[Qemu-devel] [PATCH qom-cpu 08/11] target-i386: check/enforce: Check SVM flag support as well

2013-01-04 Thread Eduardo Habkost
When nested SVM is supported, the kernel returns the SVM flag on GET_SUPPORTED_CPUID[1], so we can check the SVM flag safely on kvm_check_features_against_host(). I don't know why the original code ignored the SVM flag. Maybe it was because kvm_cpu_fill_host() used the CPUID instruction directly i

[Qemu-devel] [PATCH qom-cpu 10/11] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set

2013-01-04 Thread Eduardo Habkost
This will be necessary once kvm_check_features_against_host() starts using KVM-specific definitions (so it won't compile anymore if CONFIG_KVM is not set). Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target-i386/cpu.c b/target-i386

[Qemu-devel] [PATCH qom-cpu 01/11] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-04 Thread Eduardo Habkost
This is a cleanup that tries to solve two small issues: - We don't need a separate kvm_pv_eoi_features variable just to keep a constant calculated at compile-time, and this style would require adding a separate variable (that's declared twice because of the CONFIG_KVM ifdef) for each fea

Re: [Qemu-devel] [PATCH 05/11] block: rename bdrv_query_info to bdrv_query_block_info

2013-01-04 Thread Eric Blake
On 12/29/2012 01:45 AM, Wenchao Xia wrote: > Now this function have a mirror name with bdrv_query_image_info > to tip well what it is doing. Awkward to read. Maybe: Now that we have bdrv_query_image_info, rename this function to make it more obvious what it is doing. > > Signed-off-by: Wench

[Qemu-devel] [PATCH 09/20 v4] target-i386: add x86cpu_vendor_words2str()

2013-01-04 Thread Igor Mammedov
Make for() cycle reusable for the next patch Signed-off-by: Igor Mammedov --- v3: -replace e[bcd]x arguments naming with vendor[123] -fix/swap vendor2 and vendor3 order Spotted-By: Eduardo Habkost Tested vendor feature in TCG/KVM mode + custom value, works as expected v

[Qemu-devel] [PATCH qom-cpu 06/11] target-i386: check/enforce: Do not ignore "hypervisor" flag

2013-01-04 Thread Eduardo Habkost
We don't need any hack to ignore CPUID_EXT_HYPERVISOR anymore, because kvm_arch_get_supported_cpuid() now set CPUID_EXT_HYPERVISOR properly. So, this shouldn't introduce any behavior change, but it makes the code simpler. Signed-off-by: Eduardo Habkost --- My goal is to eliminate the check_feat f

[Qemu-devel] [PATCH qom-cpu 03/11] target-i386: kvm: -cpu host: Use GET_SUPPORTED_CPUID for SVM features

2013-01-04 Thread Eduardo Habkost
The existing -cpu host code simply set every bit inside svm_features (initializing it to -1), and that makes it impossible to make the enforce/check options work properly when the user asks for SVM features explicitly in the command-line. So, instead of initializing svm_features to -1, use GET_SUP

[Qemu-devel] [PATCH 06/10] acpi-piix4: do not use old_portio-style callbacks

2013-01-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/acpi_piix4.c | 91 --- 1 file changed, 40 insertions(+), 51 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 06a8aca..63b41db 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -531,6

[Qemu-devel] [PATCH qom-cpu 00/11] disable-kvm_mmu + -cpu check/enforce fixes (v2)

2013-01-04 Thread Eduardo Habkost
Changes on v2: - Now both the kvm_mmu-disable and -cpu "enforce" changes are on the same series - Coding style fixes Git tree for reference: git://github.com/ehabkost/qemu-hacks.git cpu-enforce-all.v2 https://github.com/ehabkost/qemu-hacks/tree/cpu-enforce-all.v2 Patches 1-2 disable the

[Qemu-devel] [PATCH qom-cpu 04/11] target-i386: kvm: Enable all supported KVM features for -cpu host

2013-01-04 Thread Eduardo Habkost
When using -cpu host, we don't need to use the kvm_default_features variable, as the user is explicitly asking QEMU to enable all feature supported by the host. This changes the kvm_cpu_fill_host() code to use GET_SUPPORTED_CPUID to initialize the kvm_features field, so we get all host KVM feature

Re: [Qemu-devel] [RFC] lively write vmstate with predictable size

2013-01-04 Thread Juan Quintela
Stefan Hajnoczi wrote: > On Fri, Dec 21, 2012 at 10:25:51AM +0800, Wenchao Xia wrote: >> resent the mail to mail-list. >> --- >> >> Hi, Paolo and Juan >> Currently savevm needs pause vm, and I am working on that make it >> lively. > > What is the benefit over migrating to fil

[Qemu-devel] [PATCH qom-cpu 05/11] target-i386: check/enforce: Fix CPUID leaf numbers on error messages

2013-01-04 Thread Eduardo Habkost
The -cpu check/enforce warnings are printing incorrect information about the missing flags. There are no feature flags on CPUID leaves 0 and 0x8000, but there were references to 0 and 0x8000 in the table at kvm_check_features_against_host(). This changes the model_features_t struct to cont

Re: [Qemu-devel] [PATCH 3/4] hw: Add test device for unittests execution

2013-01-04 Thread Alexander Graf
Am 04.01.2013 um 22:44 schrieb "Stefan Weil" : >> From: Lucas Meneghel Rodrigues >> >> Add a test device which supports the kvmctl ioports, >> so one can run the KVM unittest suite. >> >> Intended Usage: >> >> qemu-system-x86_64 -nographic \ >>-device pc-testdev \ >>-device isa-debug

[Qemu-devel] [PATCH qom-cpu 07/11] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits

2013-01-04 Thread Eduardo Habkost
I have no idea why PPRO_FEATURES was being ignored on the check of the CPUID.8001H.EDX bits. I believe it was a mistake, and it was supposed to be ~(PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) or just ~CPUID_EXT2_AMD_ALIASES, because some time ago kvm_cpu_fill_host() used the CPUID instruction dire

[Qemu-devel] [PATCH qom-cpu 09/11] target-i386: check/enforce: Eliminate check_feat field

2013-01-04 Thread Eduardo Habkost
Now that all entries have check_feat=~0 on kvm_check_features_against_host(), we can eliminate check_feat entirely and make the code check all bits. This patch shouldn't introduce any behavior change, as check_feat is set to ~0 on all entries. Signed-off-by: Eduardo Habkost --- Changes v2: - Co

[Qemu-devel] [PATCH 08/10] isa: use memory regions instead of portio_list_* functions

2013-01-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/isa-bus.c | 127 -- hw/isa.h |2 +- 2 files changed, 125 insertions(+), 4 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 86b0bbd..bcf7cd4 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bu

Re: [Qemu-devel] [PATCH 09/20 v3] target-i386: add x86cpu_vendor_words2str()

2013-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2013 at 09:46:30PM +0100, Igor Mammedov wrote: > On Fri, 4 Jan 2013 18:02:33 -0200 > Eduardo Habkost wrote: > > > On Fri, Jan 04, 2013 at 08:37:24PM +0100, Igor Mammedov wrote: > > > Make for() cycle reusable for the next patch > > > > > > Signed-off-by: Igor Mammedov > > > ---

Re: [Qemu-devel] [RFC 6/6] target-i386: CPU model subclasses

2013-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2013 at 05:56:22PM -0200, Eduardo Habkost wrote: > +/* Original model name for -cpu ? listing */ > +const char *model_name; This is a leftover of a test I was making. It will be removed. -- Eduardo

Re: [Qemu-devel] [RFC 0/6] x86 CPU subclasses, v4

2013-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2013 at 05:56:16PM -0200, Eduardo Habkost wrote: > This is a new RFC for the x86 CPU subclasses. This version handles the "host" > subclass differently, and I believe this made the code much simpler. > > However, a few tricks were necessary: > > - To keep the "default_kvm_feature

[Qemu-devel] [PATCH qom-cpu 02/11] target-i386: Disable kvm_mmu_op by default on pc-1.4

2013-01-04 Thread Eduardo Habkost
The kvm_mmu_op feature was removed from the kernel since v3.3 (released in March 2012), it was marked for removal since January 2011 and it's slower than shadow or hardware assisted paging (see kernel commit fb92045843). It doesn't make sense to keep it enabled by default. Also, keeping it enabled

[Qemu-devel] [PATCH qom-cpu 11/11] target-i386: check/enforce: Check all feature words

2013-01-04 Thread Eduardo Habkost
This adds the following feature words to the list of flags to be checked by kvm_check_features_against_host(): - cpuid_7_0_ebx_features - ext4_features - kvm_features - svm_features This will ensure the "enforce" flag works as it should: it won't allow QEMU to be started unless every flag tha

[Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW

2013-01-04 Thread Stefan Weil
pc-testdev.c cannot be compiled with MinGW: CCi386-softmmu/hw/i386/../pc-testdev.o hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found hw/i386/../pc-testdev.c: In function ‘test_flush_page’: hw/i386/../pc-testdev.c:103: warning: implicit declaration of function ‘mprotect’ ...

[Qemu-devel] [PATCH 03/10] uhci: stop using portio lists

2013-01-04 Thread Hervé Poussineau
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Tested-by: Hervé Poussineau --- hw/usb/hcd-uhci.c | 106 +++-- trace-events |2 - 2 files changed, 30 insertions(+), 78 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c in

Re: [Qemu-devel] [PATCH 2/2] target-i386: Disable kvm_mmu_op by default on pc-1.4

2013-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2013 at 08:48:42PM +, Blue Swirl wrote: [...] > > +/* machine init function for pc-0.14 - pc-1.2 */ > > static void pc_init_pci(QEMUMachineInitArgs *args) > > { > > ram_addr_t ram_size = args->ram_size; > > @@ -232,12 +233,20 @@ static void pc_init_pci(QEMUMachineInitArgs

Re: [Qemu-devel] [PATCH 3/4] hw: Add test device for unittests execution

2013-01-04 Thread Stefan Weil
> From: Lucas Meneghel Rodrigues > > Add a test device which supports the kvmctl ioports, > so one can run the KVM unittest suite. > > Intended Usage: > > qemu-system-x86_64 -nographic \ > -device pc-testdev \ > -device isa-debug-exit,iobase=0xf4,iosize=0x04 \ > -kernel /path/to/kvm/un

[Qemu-devel] [PATCH 09/10] ioport: remove now useless portio_list_* functions

2013-01-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- include/exec/ioport.h | 19 ioport.c | 121 - 2 files changed, 140 deletions(-) diff --git a/include/exec/ioport.h b/include/exec/ioport.h index fc28350..b02ddf7 100644 --- a/include/exec

[Qemu-devel] [PATCH 10/10] memory: remove old_portio-style callbacks support

2013-01-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- include/exec/memory.h |4 memory.c | 44 2 files changed, 48 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 2322732..4a757f0 100644 --- a/include/exec/memory.h

[Qemu-devel] [PATCH 07/10] vga/qxl: do not use portio_list_init/portio_list_add

2013-01-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/qxl.c |4 +--- hw/vga.c |8 ++-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index d08b9bd..8279a95 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -2048,7 +2048,6 @@ static int qxl_init_primary(PCIDevice *dev) {

[Qemu-devel] [PATCH 04/10] sun4u: create VGA card after ISA bus

2013-01-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/sun4u.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index cbfd217..c9150ad 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@ -825,11 +825,12 @@ static void sun4uv_init(MemoryRegion *address_space_mem, ivec_

[Qemu-devel] [PATCH 05/10] xen_platform: do not use old_portio-style callbacks

2013-01-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/xen_platform.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/hw/xen_platform.c b/hw/xen_platform.c index e7611bb..02e0146 100644 --- a/hw/xen_platform.c +++ b/hw/xen_platform.c @@ -279,7 +279,8 @@ static void p

[Qemu-devel] [PATCH 02/10] ppc/oldworld: add ISA bus, required by VGA card

2013-01-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/ppc_oldworld.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc_oldworld.c b/hw/ppc_oldworld.c index fff5129..99eb22e 100644 --- a/hw/ppc_oldworld.c +++ b/hw/ppc_oldworld.c @@ -223,6 +223,7 @@ static void ppc_heathrow_init(QEMUMachineInitArgs *a

[Qemu-devel] [PATCH 01/10] ppc/newworld: add ISA bus, required by VGA card

2013-01-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/ppc_newworld.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c index fabcc08..cd30f42 100644 --- a/hw/ppc_newworld.c +++ b/hw/ppc_newworld.c @@ -274,6 +274,7 @@ static void ppc_core99_init(QEMUMachineInitArgs *arg

[Qemu-devel] [PATCH 00/10] memory: remove old_portio usage

2013-01-04 Thread Hervé Poussineau
These proposed patches aim at removing the .old_portio member of MemoryRegionOps structure, and replacing their usage by .read/.write handlers. That way, faked I/O address space can be removed from architectures which don't have it (MIPS, PowerPC...), and commits like a178274efabcbbc5d44805b51def8

Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/15] openpic: rework critical interrupt support

2013-01-04 Thread Scott Wood
On 01/04/2013 03:17:21 PM, Blue Swirl wrote: On Fri, Jan 4, 2013 at 8:49 PM, Scott Wood wrote: > On 01/04/2013 02:46:00 PM, Blue Swirl wrote: >> >> On Thu, Jan 3, 2013 at 11:07 PM, Scott Wood >> wrote: >> > It looks like one of the adjustments was wrapping an error string -- >> > does >

Re: [Qemu-devel] [PATCH 1/2] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2013 at 07:02:17PM -0200, Eduardo Habkost wrote: > On Fri, Jan 04, 2013 at 08:47:07PM +, Blue Swirl wrote: > > > { > > > -kvm_default_features |= kvm_pv_eoi_features; > > > +#ifdef CONFIG_KVM > > > +if (kvm_enabled()) > > > > Missing braces, please read CODING_STYLE an

Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/15] openpic: rework critical interrupt support

2013-01-04 Thread Blue Swirl
On Fri, Jan 4, 2013 at 8:49 PM, Scott Wood wrote: > On 01/04/2013 02:46:00 PM, Blue Swirl wrote: >> >> On Thu, Jan 3, 2013 at 11:07 PM, Scott Wood >> wrote: >> > It looks like one of the adjustments was wrapping an error string -- >> > does >> > QEMU not follow the Linux rule of not wrapping erro

Re: [Qemu-devel] [PATCH 0/9] target-i386: make "enforce" flag work as it should

2013-01-04 Thread Anthony Liguori
Eduardo Habkost writes: > The Cc header of the message looks broken. It contained: > > Cc: > > =?utf-8?q?kvm=40vger=2Ekernel=2Eorg=2C_Gleb_Natapov_=3Cgleb=40redhat=2E?=.=?utf-8?q?com=3E=2C_libvir-list=40redhat=2Ecom=2C_Marcelo_Tosatti_=3Cmtosat?=.=?utf-8?q?ti=40redhat=2Ecom=3E=2C_Igor_Mammed

Re: [Qemu-devel] [PATCH RFC 3/3] xen_disk: add persistent grant support to xen_disk backend

2013-01-04 Thread Blue Swirl
On Mon, Dec 31, 2012 at 12:16 PM, Roger Pau Monne wrote: > This protocol extension reuses the same set of grant pages for all > transactions between the front/back drivers, avoiding expensive tlb > flushes, grant table lock contention and switches between userspace > and kernel space. The full des

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

2013-01-04 Thread Andreas Färber
Hi, Am 02.01.2013 19:07, schrieb Anthony Liguori: > 2) Patches that no longer apply via git am --3way will receive a > notification. Isn't Nacked-by too strong of a notification for a mere technical need for a rebase (compared to a rejection of its concept/approach)? Also, since quite a f

Re: [Qemu-devel] [PATCH 1/2] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2013 at 08:47:07PM +, Blue Swirl wrote: > > { > > -kvm_default_features |= kvm_pv_eoi_features; > > +#ifdef CONFIG_KVM > > +if (kvm_enabled()) > > Missing braces, please read CODING_STYLE and use checkpatch.pl to find > problems in patches. Sorry (again). I will soon

Re: [Qemu-devel] [PATCH 0/9] target-i386: make "enforce" flag work as it should

2013-01-04 Thread Anthony Liguori
Hi, This is an automated message generated from the QEMU Patches. Thank you for submitting this patch. This patch no longer applies to qemu.git. This may have occurred due to: 1) Changes in mainline requiring your patch to be rebased and re-tested. 2) Sending the mail using a tool other t

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

2013-01-04 Thread Daniel P. Berrange
On Wed, Jan 02, 2013 at 12:07:57PM -0600, Anthony Liguori wrote: > Hi, > > Over the holiday, I spent some time overhauling my patch tracking > scripts. One new feature is automated responses so you will start > seeing some additional mail on the list. Notably: > > 1) My 'Thanks, applied.' mai

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

2013-01-04 Thread Blue Swirl
On Wed, Jan 2, 2013 at 6:07 PM, Anthony Liguori wrote: > Hi, > > Over the holiday, I spent some time overhauling my patch tracking > scripts. One new feature is automated responses so you will start > seeing some additional mail on the list. Notably: > > 1) My 'Thanks, applied.' mails are now

Re: [Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support.

2013-01-04 Thread Anthony Liguori
Hi, This is an automated message generated from the QEMU Patches. Thank you for submitting this patch. This patch no longer applies to qemu.git. This may have occurred due to: 1) Changes in mainline requiring your patch to be rebased and re-tested. 2) Sending the mail using a tool other t

Re: [Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support.

2013-01-04 Thread Anthony Liguori
Hi, This is an automated message generated from the QEMU Patches. Thank you for submitting this patch. This patch no longer applies to qemu.git. This may have occurred due to: 1) Changes in mainline requiring your patch to be rebased and re-tested. 2) Sending the mail using a tool other t

Re: [Qemu-devel] [PULL 0/6] Trivial patches for 18 December 2012 to 4 January 2013

2013-01-04 Thread Anthony Liguori
Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 3/9] target-i386: check/enforce: Fix CPUID leaf numbers on error messages

2013-01-04 Thread Blue Swirl
On Fri, Jan 4, 2013 at 3:37 PM, Eduardo Habkost wrote: > The -cpu check/enforce warnings are printing incorrect information about the > missing flags. There are no feature flags on CPUID leaves 0 and 0x8000, > but > there were references to 0 and 0x8000 in the table at > kvm_check_feature

Re: [Qemu-devel] [PATCH 09/20 v3] target-i386: add x86cpu_vendor_words2str()

2013-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2013 at 08:37:24PM +0100, Igor Mammedov wrote: > Make for() cycle reusable for the next patch > > Signed-off-by: Igor Mammedov > --- > v3: > fix/swap vendor2 and vendor3 order > Spotted-By: Eduardo Habkost > v2: > place x86cpu_vendor_words2str() a bit earlier,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/15] openpic: rework critical interrupt support

2013-01-04 Thread Scott Wood
On 01/04/2013 02:46:00 PM, Blue Swirl wrote: On Thu, Jan 3, 2013 at 11:07 PM, Scott Wood wrote: > It looks like one of the adjustments was wrapping an error string -- does > QEMU not follow the Linux rule of not wrapping error strings? If not, maybe > that should change. There was some d

Re: [Qemu-devel] [PATCH 2/2] target-i386: Disable kvm_mmu_op by default on pc-1.4

2013-01-04 Thread Blue Swirl
On Fri, Jan 4, 2013 at 2:52 PM, Eduardo Habkost wrote: > The kvm_mmu_op feature was removed from the kernel since v3.3 (released > in March 2012), it was marked for removal since January 2011 and it's > slower than shadow or hardware assisted paging (see kernel commit > fb92045843). It doesn't mak

Re: [Qemu-devel] [PATCH 1/2] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-04 Thread Blue Swirl
On Fri, Jan 4, 2013 at 2:52 PM, Eduardo Habkost wrote: > This is a cleanup that tries to solve two small issues: > > - We don't need a separate kvm_pv_eoi_features variable just to keep a >constant calculated at compile-time, and this style would require >adding a separate variable (that'

Re: [Qemu-devel] [PATCH 0/9] target-i386: make "enforce" flag work as it should

2013-01-04 Thread Eduardo Habkost
The Cc header of the message looks broken. It contained: Cc: =?utf-8?q?kvm=40vger=2Ekernel=2Eorg=2C_Gleb_Natapov_=3Cgleb=40redhat=2E?=.=?utf-8?q?com=3E=2C_libvir-list=40redhat=2Ecom=2C_Marcelo_Tosatti_=3Cmtosat?=.=?utf-8?q?ti=40redhat=2Ecom=3E=2C_Igor_Mammedov_=3Cimammedo=40redhat=2Ecom?=.=?utf

Re: [Qemu-devel] [PATCH 09/20 v3] target-i386: add x86cpu_vendor_words2str()

2013-01-04 Thread Igor Mammedov
On Fri, 4 Jan 2013 18:02:33 -0200 Eduardo Habkost wrote: > On Fri, Jan 04, 2013 at 08:37:24PM +0100, Igor Mammedov wrote: > > Make for() cycle reusable for the next patch > > > > Signed-off-by: Igor Mammedov > > --- > > v3: > > fix/swap vendor2 and vendor3 order > > Spotted-By: Ed

Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/15] openpic: rework critical interrupt support

2013-01-04 Thread Blue Swirl
On Thu, Jan 3, 2013 at 11:07 PM, Scott Wood wrote: > On 01/03/2013 12:31:47 PM, Alexander Graf wrote: >> >> >> On 22.12.2012, at 03:15, Scott Wood wrote: >> >> > Critical interrupts on FSL MPIC are not supposed to pay >> > attention to priority, IACK, EOI, etc. On the currently modeled >> > versi

Re: [Qemu-devel] [PATCH] QEMU: PPC: set has-idle in guest device tree

2013-01-04 Thread Alexander Graf
Am 04.01.2013 um 21:21 schrieb Anthony Liguori : > Hi, > > This is an automated message generated from the QEMU Patches. > Thank you for submitting this patch. This patch no longer applies to > qemu.git. Great idea, but not patricularly useful for ppc patches :). Could you please just omit

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-04 Thread Blue Swirl
On Wed, Jan 2, 2013 at 1:29 PM, Tim Hardeck wrote: > This patch adds basic Websocket Protocol version 13 - RFC 6455 - support > to QEMU VNC. Binary encoding support on the client side is mandatory. > > Because of the GnuTLS requirement the Websockets implementation is > optional (--enable-vnc-ws).

[Qemu-devel] [RFC 4/6] target-i386: Set feature string parsing results directly on CPU object

2013-01-04 Thread Eduardo Habkost
Note that this is temporary: just like we would eventually kill usage of x86_def_t inside cpu_x86_parse_featurestr(), we will eventually kill usage of X86CPU inside that function as well. This will help us keep the x86_def_t usage restricted to the CPU object creation code. Signed-off-by: Eduardo

Re: [Qemu-devel] [PATCH 10/12] virtio-net: multiqueue support

2013-01-04 Thread Blue Swirl
On Fri, Jan 4, 2013 at 5:12 AM, Jason Wang wrote: > On 12/29/2012 01:52 AM, Blue Swirl wrote: >> On Fri, Dec 28, 2012 at 10:32 AM, Jason Wang wrote: >>> This patch implements both userspace and vhost support for multiple queue >>> virtio-net (VIRTIO_NET_F_MQ). This is done by introducing an array

Re: [Qemu-devel] [PULL 0/4] test and debug devices

2013-01-04 Thread Anthony Liguori
Pulled, thanks. N.B. This note may be extraneous because the pull request was sent by a version of git older than 1.7.9 making the pull request ambigious. Please consider upgrading to a newer version of git. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] QEMU: PPC: set has-idle in guest device tree

2013-01-04 Thread Anthony Liguori
Hi, This is an automated message generated from the QEMU Patches. Thank you for submitting this patch. This patch no longer applies to qemu.git. This may have occurred due to: 1) Changes in mainline requiring your patch to be rebased and re-tested. 2) Sending the mail using a tool other t

Re: [Qemu-devel] [RFC V9 04/12] virtio-pci : refactor virtio-pci device.

2013-01-04 Thread Blue Swirl
On Thu, Jan 3, 2013 at 2:52 PM, wrote: > From: KONRAD Frederic > > Create the virtio-pci device. This transport device will create a > virtio-pci-bus, so one VirtIODevice can be connected. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-pci.c | 133 > +

Re: [Qemu-devel] [RFC V9 08/12] virtio-blk : add the virtio-blk device.

2013-01-04 Thread Blue Swirl
On Thu, Jan 3, 2013 at 2:52 PM, wrote: > From: KONRAD Frederic > > Create virtio-blk which extends virtio-device, so it can be connected on > virtio-bus. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-blk.c | 101 > +++- > hw/virtio-bl

Re: [Qemu-devel] [PULL 0/4] acpi fixups

2013-01-04 Thread Anthony Liguori
Pulled, thanks. N.B. This note may be extraneous because the pull request was sent by a version of git older than 1.7.9 making the pull request ambigious. Please consider upgrading to a newer version of git. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2 0/4] openpic cleanups and fixes

2013-01-04 Thread Anthony Liguori
Hi, This is an automated message generated from the QEMU Patches. Thank you for submitting this patch. This patch no longer applies to qemu.git. This may have occurred due to: 1) Changes in mainline requiring your patch to be rebased and re-tested. 2) Sending the mail using a tool other t

Re: [Qemu-devel] [PATCH] PPC: Bring EPR support closer to reality

2013-01-04 Thread Anthony Liguori
Hi, This is an automated message generated from the QEMU Patches. Thank you for submitting this patch. This patch no longer applies to qemu.git. This may have occurred due to: 1) Changes in mainline requiring your patch to be rebased and re-tested. 2) Sending the mail using a tool other t

[Qemu-devel] [Bug 1054831] Re: qemu-user-static for sparc32plus : bash: fork: Invalid argument

2013-01-04 Thread Dillon Amburgey
What I mean is that QEMU isn't compiled with guest support for NPTL on every architecture. If you look in the configure script around line 3900, you'll see some architectures have target_nptl="yes" while others (including sparc) do not. Unfortunately it looks like the code isn't complete for spar

[Qemu-devel] [RFC 0/6] x86 CPU subclasses, v4

2013-01-04 Thread Eduardo Habkost
This is a new RFC for the x86 CPU subclasses. This version handles the "host" subclass differently, and I believe this made the code much simpler. However, a few tricks were necessary: - To keep the "default_kvm_features" compat functions working (this shouldn't be necessary once we start usi

[Qemu-devel] [RFC 2/6] target-i386: Make cpu_x86_create() get Error argument

2013-01-04 Thread Eduardo Habkost
Instead of forcing the caller to guess what went wrong while creating the CPU object, return error information in a Error argument. Also, as cpu_x86_create() won't print error messages itself anymore, change cpu_x86_init() to print any error returned by cpu_x86_create() or cpu_x86_realize(). Sign

[Qemu-devel] [RFC 3/6] target-i386: Simplify cpu_x86_find_by_name() logic

2013-01-04 Thread Eduardo Habkost
Move the check for "host" to beginning of function, so instead of a confusing if/else-if/else mess we now have just two obvious if/else blocks: 1) Special case for "host"; 2) General case for CPU model lookup on x86_defs list. This way, we will be able to easily move those two parts to separate c

[Qemu-devel] [RFC 5/6] target-i386: Move kvm_features/hypervisor initialization to cpu_x86_find_by_name()

2013-01-04 Thread Eduardo Habkost
Move the initialization to the cpu_x86_find_by_name(), inside the block for predefined CPU models. That code is not necessary for -cpu "host", because: - kvm_features doesn't need to be set because kvm_cpu_fill_host() already sets all bits supported by the host. - the CPUID_EXT_HYPERVISOR flag

[Qemu-devel] [RFC 1/6] target-i386: Move CPU object creation to cpu.c

2013-01-04 Thread Eduardo Habkost
As we will need to create the CPU object after splitting the CPU model string (because we're going to use different subclasses for each CPU model), move the CPU object creation to cpu_x86_register(), and at the same time rename cpu_x86_register() to cpu_x86_create(). This will also simplify the CP

[Qemu-devel] [PATCH 09/20 v3] target-i386: add x86cpu_vendor_words2str()

2013-01-04 Thread Igor Mammedov
Make for() cycle reusable for the next patch Signed-off-by: Igor Mammedov --- v3: fix/swap vendor2 and vendor3 order Spotted-By: Eduardo Habkost v2: place x86cpu_vendor_words2str() a bit earlier, before feature arrays to avoid compile error when vendor property is convert

[Qemu-devel] [PATCH v3 2/2] ahci: add migration support

2013-01-04 Thread Jason Baron
From: Jason Baron I've tested these patches by migrating Windows 7 and Fedora 17 guests (while uunder i/o) on both piix with ahci attached and on q35 (which has a built-in ahci controller). Changes from v2: -migrate all relevant ahci fields -flush any pending i/o in 'post_load' Changes from v

[Qemu-devel] [PATCH v3 0/2] add ahci migration

2013-01-04 Thread Jason Baron
Hi, Add migration bits for ahci. This allows q35 to be migratable. I also have been working on some qtest migration tests, to show that this does something. I will re-post those separately. Thanks, -Jason Jason Baron (2): ahci: remove unused AHCIDevice fields ahci: add migration support h

[Qemu-devel] [PATCH v3 1/2] ahci: remove unused AHCIDevice fields

2013-01-04 Thread Jason Baron
From: Jason Baron 'dma_status' and 'dma_cb' are written to, but never read. Remove these fields in preparation for AHCI migration bits. Signed-off-by: Jason Baron --- hw/ide/ahci.c |8 ++-- hw/ide/ahci.h |2 -- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/ide/a

Re: [Qemu-devel] [PATCH] pixman: pass extra cflags and ldflags

2013-01-04 Thread Scott Wood
On 01/04/2013 03:18:08 AM, Gerd Hoffmann wrote: Store --extra-cflags and --extra-ldflags in config-host.mak, then pass them on to the pixman configure script. Cc: Scott Wood Signed-off-by: Gerd Hoffmann --- Makefile |2 +- configure |4 2 files changed, 5 insertions(+), 1 deleti

Re: [Qemu-devel] [PATCH v4 0/2] soft-float-fixes for target-s390x

2013-01-04 Thread Richard Henderson
Ping. r~ On 12/31/2012 10:09 AM, Richard Henderson wrote: > Changes v3-v4: > Rebase after source tree rearrangements. > > Changes v2-v3: > Ignore softfloat "style" completely. Code now formatted per QEMU. > > Changes v1-v2: > Incorporating feedback from Peter Maydell (previously missed i

Re: [Qemu-devel] [PATCH] linux-user: Add Alpha socket constants

2013-01-04 Thread Richard Henderson
On 01/02/2013 06:06 PM, dill...@dillona.com wrote: > From: Dillon Amburgey > > Without these, some networking programs will not work > > Signed-off-by: Dillon Amburgey > --- > linux-user/socket.h | 69 > +++ > 1 files changed, 69 insertions(+)

  1   2   3   >