Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2013-01-02 Thread Gerd Hoffmann
On 12/23/12 21:33, Alon Levy wrote: > On Thu, Dec 13, 2012 at 03:43:46PM +0100, Gerd Hoffmann wrote: >> Hi, >> That is indeed a better solution, but it does change functionality. I think it is correct but I'd like to get some other opinions - Uri, Arnon, Yonit, Soren - any problems

[Qemu-devel] [Bug 1095531] Re: sparc32plus (and others?) has x86 code generation errors on 64bit hosts

2013-01-02 Thread Samuel Seay
I forgot to add, this is on the latest master branch as of this post. I am doing a static compile with debug enabled. My test is doing a chroot of a sparc system built from debootstrap. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1095531] [NEW] sparc32plus (and others?) has x86 code generation errors on 64bit hosts

2013-01-02 Thread Samuel Seay
Public bug reported: On 64bit hosts, the load and store functions compile improperly. The issue is the call to gen_address_mask() under the ld and st functions in target-sparc/translate.c. Below are some snips from the log file. Doing a gdb debug, this results in constant access violation errors w

[Qemu-devel] MC13226 PiP freescale - arm7tdmi core

2013-01-02 Thread Vinicius Sanches
Hi, everybody. I would like to start a development of a new device based on Freescale arm 7 microcontroller. I would like to know how to start developing. Where can I find some tutorial or documentation to start it? Should I project it as another board containning all periferals like MAC accelerat

[Qemu-devel] [PATCH] linux-user: Add Alpha socket constants

2013-01-02 Thread dillona
From: Dillon Amburgey Without these, some networking programs will not work Signed-off-by: Dillon Amburgey --- linux-user/socket.h | 69 +++ 1 files changed, 69 insertions(+), 0 deletions(-) diff --git a/linux-user/socket.h b/linux-user/socket

[Qemu-devel] [PATCH] linux-user: Add Alpha socket constants

2013-01-02 Thread dillona
From: Dillon Amburgey Without these, some networking programs will not work Signed-off-by: Dillon Amburgey --- linux-user/socket.h | 69 +++ 1 files changed, 69 insertions(+), 0 deletions(-) diff --git a/linux-user/socket.h b/linux-user/socket

Re: [Qemu-devel] [kvmarm] pthread_create failed: Resource temporarily unavailable

2013-01-02 Thread Adrian Taylor
Hi Christoffer, On Wed, Jan 2, 2013 at 7:17 PM, Christoffer Dall wrote: > > The culprit seems to be when the process runs out of virtual address > space on 32-bit systems due to some subsystem (virtio?) creating a > large number of pthreads under heavy workloads. > > One possibility - qemu uses c

[Qemu-devel] [PATCH] linux-user: Add Alpha socket constants

2013-01-02 Thread dillona
From: Dillon Amburgey Without these, some networking programs will not work Signed-off-by: Dillon Amburgey --- linux-user/socket.h | 69 +++ 1 files changed, 69 insertions(+), 0 deletions(-) diff --git a/linux-user/socket.h b/linux-user/socket

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-02 Thread ronnie sahlberg
On Wed, Jan 2, 2013 at 11:18 AM, Troy Benjegerdes wrote: > If you do get a hash collision, it's a rather exceptional event, so I'd > say every effort should be made to log the event and the data that created > it in multiple places. > > There are three questions I'd ask on a hash collision: > > 1)

Re: [Qemu-devel] [PATCH v4] correct error message qemu-img reported

2013-01-02 Thread Anthony Liguori
Peter Maydell writes: > On 3 January 2013 00:19, Anthony Liguori wrote: >> This is an automated message generated from the QEMU Patches. >> Thank you for submitting this patch. This patch no longer applies to >> qemu.git. > >> Nacked-by: QEMU Patches > > Are we going to get these emails on ev

Re: [Qemu-devel] [PATCH v4] correct error message qemu-img reported

2013-01-02 Thread Peter Maydell
On 3 January 2013 00:19, Anthony Liguori wrote: > This is an automated message generated from the QEMU Patches. > Thank you for submitting this patch. This patch no longer applies to > qemu.git. > Nacked-by: QEMU Patches Are we going to get these emails on every old patch that was superseded

Re: [Qemu-devel] [PATCH] tci: Fix broken builds with TCG interpreter

2013-01-02 Thread Anthony Liguori
Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] savevm.c: cleanup system includes

2013-01-02 Thread Anthony Liguori
Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v2] tests: add gcov target

2013-01-02 Thread Anthony Liguori
Hi, This is an automated message generated from the QEMU Patches. Thank you for submitting this patch. This patch no longer applies to qemu.git. This may have occurred due to: 1) Changes in mainline requiring your patch to be rebased and re-tested. 2) Sending the mail using a tool other t

Re: [Qemu-devel] [kvmarm] pthread_create failed: Resource temporarily unavailable

2013-01-02 Thread Peter Maydell
On 3 January 2013 00:45, Adrian Taylor wrote: > One possibility - qemu uses coroutines for IO. There are various backends > for coroutines, and the qemu configure script will try to choose the best > one. Perhaps your environment is lacking system calls such as makecontext > and the configure scri

Re: [Qemu-devel] [PATCH v3] disallow -daemonize usage of stdio (curses display, -nographic, -serial stdio etc)

2013-01-02 Thread Anthony Liguori
Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v4] correct error message qemu-img reported

2013-01-02 Thread Anthony Liguori
Hi, This is an automated message generated from the QEMU Patches. Thank you for submitting this patch. This patch no longer applies to qemu.git. This may have occurred due to: 1) Changes in mainline requiring your patch to be rebased and re-tested. 2) Sending the mail using a tool other t

Re: [Qemu-devel] buildbot failure in qemu on disable_kvm_x86_64_out_of_tree

2013-01-02 Thread Anthony Liguori
These are all virtio-blk-dataplane Stefan... The problem seems to be !CONFIG_KVM related. Regards, Anthony Liguori q...@buildbot.b1-systems.de writes: > The Buildbot has detected a new failure on builder > disable_kvm_x86_64_out_of_tree while building qemu. > Full details are available at: >

Re: [Qemu-devel] [PULL 0/2] migration queue

2013-01-02 Thread Anthony Liguori
Anthony Liguori writes: > Thanks, applied. Please disregard. That's a bug in my script. Sorry for the noise. Regards, Anthony Liguori > > Regards, > > Anthony Liguori

Re: [Qemu-devel] [PATCH] configure: Write new file "config-all-disas.mak" when running configure

2013-01-02 Thread Anthony Liguori
Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3] tests: add gcov support

2013-01-02 Thread Anthony Liguori
Hi, This is an automated message generated from the QEMU Patches. Thank you for submitting this patch. This patch no longer applies to qemu.git. This may have occurred due to: 1) Changes in mainline requiring your patch to be rebased and re-tested. 2) Sending the mail using a tool other t

Re: [Qemu-devel] [PULL 0/2] migration queue

2013-01-02 Thread Anthony Liguori
Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [RFC 0/8] Remove old_portio usage

2013-01-02 Thread Andreas Färber
Am 23.12.2012 16:32, schrieb Hervé Poussineau: > These proposed patches aim at removing the .old_portio member of > MemoryRegionOps structure, and replacing their usage by .read/.write > handlers. > > Patches 2 to 6 are already ready to be committed. In lack of a memory maintainer, I'll volunteer

Re: [Qemu-devel] [PATCH] qga: add missing commas in json docs

2013-01-02 Thread mdroth
On Wed, Jan 02, 2013 at 09:15:11AM -0700, Eric Blake wrote: > * qga/qapi-schema.json: Use valid JSON. > > Signed-off-by: Eric Blake Thanks, applied to qga branch > --- > qga/qapi-schema.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qga/qapi-schema.json b/qg

[Qemu-devel] buildbot failure in qemu on disable_kvm_x86_64_out_of_tree

2013-01-02 Thread qemu
The Buildbot has detected a new failure on builder disable_kvm_x86_64_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/disable_kvm_x86_64_out_of_tree/builds/687 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Buil

[Qemu-devel] buildbot failure in qemu on disable_kvm_i386_out_of_tree

2013-01-02 Thread qemu
The Buildbot has detected a new failure on builder disable_kvm_i386_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/disable_kvm_i386_out_of_tree/builds/687 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: y

Re: [Qemu-devel] [PATCH 02/11] block: add bdrv_get_filename() function

2013-01-02 Thread Eric Blake
On 12/29/2012 01:45 AM, Wenchao Xia wrote: > This function will simply return the uri or filename used > to open the image. > > Signed-off-by: Wenchao Xia > --- > block.c |5 + > include/block/block.h |1 + > 2 files changed, 6 insertions(+), 0 deletions(-) Reviewed-

[Qemu-devel] buildbot failure in qemu on disable_kvm_x86_64_debian_6_0

2013-01-02 Thread qemu
The Buildbot has detected a new failure on builder disable_kvm_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/disable_kvm_x86_64_debian_6_0/builds/501 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build:

[Qemu-devel] buildbot failure in qemu on disable_kvm_i386_debian_6_0

2013-01-02 Thread qemu
The Buildbot has detected a new failure on builder disable_kvm_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/disable_kvm_i386_debian_6_0/builds/501 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuz

Re: [Qemu-devel] Using QEMU guest agent to run programs from guest path

2013-01-02 Thread mdroth
On Mon, Dec 31, 2012 at 06:14:59PM -0200, Erlon Cruz wrote: > Hi, > > > I needed to run an external program in a guest machine. Once this must be > triggered by the host, I first thought in qemu-ga. > Is that possible? In QEMU help page and in the code I couldn't find such > capability. > So Im t

Re: [Qemu-devel] [RFC] Time resync by qemu-ga

2013-01-02 Thread mdroth
On Fri, Dec 28, 2012 at 12:29:15AM +0800, Lei Li wrote: > Hi guys, > > I am working on the time drift issue as background info here. > > http://mid.gmane.org/87pq5r5otp@codemonkey.ws > > As Anthony proposed, one part of the solutions is that we want > to add a qemu-ga command to resync the g

[Qemu-devel] buildbot failure in qemu on default_i386_debian_6_0

2013-01-02 Thread qemu
The Buildbot has detected a new failure on builder default_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_debian_6_0/builds/499 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Buil

[Qemu-devel] buildbot failure in qemu on default_i386_out_of_tree

2013-01-02 Thread qemu
The Buildbot has detected a new failure on builder default_i386_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_out_of_tree/builds/685 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Bu

[Qemu-devel] buildbot failure in qemu on default_x86_64_out_of_tree

2013-01-02 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_out_of_tree while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_out_of_tree/builds/685 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuk

[Qemu-devel] buildbot failure in qemu on default_x86_64_debian_6_0

2013-01-02 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_debian_6_0/builds/499 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

[Qemu-devel] pthread_create failed: Resource temporarily unavailable

2013-01-02 Thread Christoffer Dall
Hi, I am seeing some brutal crashes with QEMU running virtio using KVM/ARM. The culprit seems to be when the process runs out of virtual address space on 32-bit systems due to some subsystem (virtio?) creating a large number of pthreads under heavy workloads. Unfortunately my QEMU expertise is t

Re: [Qemu-devel] qemu-ga command listing

2013-01-02 Thread Eric Blake
On 01/02/2013 01:34 PM, Jeff Cody wrote: > On Mon, Dec 31, 2012 at 01:41:57PM -0700, Eric Blake wrote: >> Is there a guest-agent command for querying the list of available >> commands for a given guest agent? If not, should there be? In other >> words, I'm looking for the counterpart to QMP {"exe

[Qemu-devel] [PATCH v3] Modifications to fix PowerPC on 64bit host, bug 1052857

2013-01-02 Thread Samuel Seay
Removed h2g() macro around the ka->_sa_handler due to the _sa_handler being a guest memory address Changed the __put_user to put_user as it was attempting to put a value at the stack address but the new address is a guest memory address, __put_user is for host memory addresses. Patch v2 -> v3, r

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: enable all supported KVM features for -cpu host

2013-01-02 Thread Eduardo Habkost
On Wed, Jan 02, 2013 at 09:30:20PM +0100, Igor Mammedov wrote: > On Wed, 2 Jan 2013 13:29:10 -0200 > Eduardo Habkost wrote: > > > On Wed, Jan 02, 2013 at 03:52:45PM +0100, Igor Mammedov wrote: > > > On Fri, 28 Dec 2012 16:37:34 -0200 > > > Eduardo Habkost wrote: > > > > > > > When using -cpu ho

Re: [Qemu-devel] [PATCH v2] Modifications to fix PowerPC on 64bit host, bug #1052857

2013-01-02 Thread Peter Maydell
On 2 January 2013 19:56, Samuel Seay wrote: > Removed h2g() macro around the ka->_sa_handler due to _sa_handler being a > guest value > Changed the __put_user macro as it was attempting to put a value to a guest > memory location without converting to the guest area > > Signed-off-by: Samuel Sea

[Qemu-devel] [PATCH][v2] linux-user: correct semctl() and shmctl()

2013-01-02 Thread Laurent Vivier
The parameter "union semun" of semctl() is not a value but a pointer to the value. Moreover, all fields of target_su must be swapped (if needed). The third argument of shmctl is a pointer. WITHOUT this patch: $ ipcs kernel not configured for shared memory qemu: uncaught target signal 11 (Segm

Re: [Qemu-devel] qemu-ga command listing

2013-01-02 Thread Jeff Cody
On Mon, Dec 31, 2012 at 01:41:57PM -0700, Eric Blake wrote: > Is there a guest-agent command for querying the list of available > commands for a given guest agent? If not, should there be? In other > words, I'm looking for the counterpart to QMP {"execute":"query-commands"}. > Hi Eric, There is

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: enable all supported KVM features for -cpu host

2013-01-02 Thread Igor Mammedov
On Wed, 2 Jan 2013 13:29:10 -0200 Eduardo Habkost wrote: > On Wed, Jan 02, 2013 at 03:52:45PM +0100, Igor Mammedov wrote: > > On Fri, 28 Dec 2012 16:37:34 -0200 > > Eduardo Habkost wrote: > > > > > When using -cpu host, we don't need to use the kvm_default_features > > > variable, as the user i

Re: [Qemu-devel] [RFC 7/9] target-i386: CPU subclass for -cpu "host"

2013-01-02 Thread Eduardo Habkost
On Wed, Jan 02, 2013 at 09:07:26PM +0100, Igor Mammedov wrote: > On Wed, 2 Jan 2013 20:00:26 +0100 > Igor Mammedov wrote: > > > On Fri, 28 Dec 2012 18:34:04 -0200 > > Eduardo Habkost wrote: > > > > > Note that we are initializing the CPU features inside instance_init (and > > > not storing any

Re: [Qemu-devel] [RFC 7/9] target-i386: CPU subclass for -cpu "host"

2013-01-02 Thread Eduardo Habkost
On Wed, Jan 02, 2013 at 08:00:26PM +0100, Igor Mammedov wrote: > On Fri, 28 Dec 2012 18:34:04 -0200 > Eduardo Habkost wrote: > > > Note that we are initializing the CPU features inside instance_init (and > > not storing any CPU feature information inside the class struct) because > > kvm_cpu_fill

Re: [Qemu-devel] [RFC 7/9] target-i386: CPU subclass for -cpu "host"

2013-01-02 Thread Igor Mammedov
On Wed, 2 Jan 2013 20:00:26 +0100 Igor Mammedov wrote: > On Fri, 28 Dec 2012 18:34:04 -0200 > Eduardo Habkost wrote: > > > Note that we are initializing the CPU features inside instance_init (and > > not storing any CPU feature information inside the class struct) because > > kvm_cpu_fill_host(

[Qemu-devel] [PATCH v2] Modifications to fix PowerPC on 64bit host, bug #1052857

2013-01-02 Thread Samuel Seay
Removed h2g() macro around the ka->_sa_handler due to _sa_handler being a guest value Changed the __put_user macro as it was attempting to put a value to a guest memory location without converting to the guest area Signed-off-by: Samuel Seay --- linux-user/signal.c |4 ++-- 1 file changed,

Re: [Qemu-devel] [PATCH] linux-user: allow to use sudo in guest

2013-01-02 Thread Laurent Vivier
Le mercredi 02 janvier 2013 à 01:16 +, Peter Maydell a écrit : > On 20 December 2012 20:56, Laurent Vivier wrote: > > When qemu-linux-user is used in a linux container or chroot, > > if it needs to load binaries with SUID/SGID bits, it needs to > > have root rights to be able to change UID/GID

[Qemu-devel] [FYI] May need to remove all objdir after doing a git pull

2013-01-02 Thread Anthony Liguori
If you experience any problems relating to missing tracepoints, you need to completely remove your old files. This should be okay if you do a distclean before pulling but not necessarily after pulling. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL v2 00/18] Block patches

2013-01-02 Thread Anthony Liguori
Stefan Hajnoczi writes: > Paolo's include/ reorganization was merged and this pull request had > conflicts. > Resolved in v2. > > The following changes since commit 5928023cef87847a295035487397b9ec701fdd6b: > > pflash_cfi01: Suppress warning when Linux probes for AMD flash (2013-01-01 > 13:05

Re: [Qemu-devel] [PATCH 0/1] Exogenous memory management via -mem-path

2013-01-02 Thread Peter Feiner
On Tue, Nov 20, 2012 at 7:10 AM, Peter Feiner wrote: > > This patch proposes a framework that empowers QEMU to implement powerful > memory > management techniques with very low cost. The insight is to leverage existing > sub-systems, composing functionality in a traditional UNIX style. The key to

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-02 Thread Troy Benjegerdes
If you do get a hash collision, it's a rather exceptional event, so I'd say every effort should be made to log the event and the data that created it in multiple places. There are three questions I'd ask on a hash collision: 1) was it the data? 2) was it the hardware? 3) was it a software bug?

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2013-01-02 Thread Serge Hallyn
Re-verified in precise. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1077838 Title: qemu-nbd -r -c taints device for subseque

Re: [Qemu-devel] [RFC 7/9] target-i386: CPU subclass for -cpu "host"

2013-01-02 Thread Igor Mammedov
On Fri, 28 Dec 2012 18:34:04 -0200 Eduardo Habkost wrote: > Note that we are initializing the CPU features inside instance_init (and > not storing any CPU feature information inside the class struct) because > kvm_cpu_fill_host() needs KVM to be initialized, and we can't guarantee > that KVM will

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-02 Thread Benoît Canet
Le Wednesday 02 Jan 2013 à 10:47:48 (-0800), ronnie sahlberg a écrit : > Do you really need to resolve the conflicts? > It might be easier and sufficient to just flag those hashes where a > conflict has been detected as : "dont dedup this hash anymore, > collissions have been seen." True, that's m

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-02 Thread ronnie sahlberg
Do you really need to resolve the conflicts? It might be easier and sufficient to just flag those hashes where a conflict has been detected as : "dont dedup this hash anymore, collissions have been seen." On Wed, Jan 2, 2013 at 10:40 AM, Benoît Canet wrote: > Le Wednesday 02 Jan 2013 à 12:26:37

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-02 Thread Benoît Canet
Le Wednesday 02 Jan 2013 à 12:26:37 (-0600), Troy Benjegerdes a écrit : > The probability may be 'low' but it is not zero. Just because it's > hard to calculate the hash doesn't mean you can't do it. If your > input data is not random the probability of a hash collision is > going to get scewed. >

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-02 Thread Troy Benjegerdes
The probability may be 'low' but it is not zero. Just because it's hard to calculate the hash doesn't mean you can't do it. If your input data is not random the probability of a hash collision is going to get scewed. Read about how Bitcoin uses hashes. I need a budget of around $10,000 or so for

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

2013-01-02 Thread Anthony Liguori
Sorry for breaking threading... I've fixed that bug. FWIW, the reason this got notified but other patches haven't is that as of this afternoon, this patch no longer applies but it did apply before my earlier commits. So it's the first patch series to get identified by my scripts. Regards, Ant

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-02 Thread Benoît Canet
I think I can easily add a "verify" option at image creation. This way the code would read the cluster already on disk and compare it with the cluster to write. If there are different it would print some debug message and return -EIO to the upper layers. > Le Wednesday 02 Jan 2013 à 11:01:04 (-07

[Qemu-devel] [FYI] Testing new patch management scripts...

2013-01-02 Thread Anthony Liguori
Hi, Over the holiday, I spent some time overhauling my patch tracking scripts. One new feature is automated responses so you will start seeing some additional mail on the list. Notably: 1) My 'Thanks, applied.' mails are now automated. 2) Patches that no longer apply via git am --3way will

Re: [Qemu-devel] [PATCH] tcg: Remove unneeded assertion

2013-01-02 Thread Anthony Liguori
Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-02 Thread Eric Blake
On 01/02/2013 10:33 AM, Benoît Canet wrote: >> How does this code handle hash collisions, and do you have some regression >> tests that purposefully create a dedup hash collision, and verify that the >> 'right thing' happens? > > The two hash function that can be used are cryptographics and not br

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

2013-01-02 Thread Anthony Liguori
Hi, This is an automated message generated from the QEMU Patches. Thank you for submitting this patch. This patch no longer applies to qemu.git. This may have occurred due to: 1) Changes in mainline requiring your patch to be rebased and re-tested. 2) Sending the mail using a tool other t

Re: [Qemu-devel] [PATCH 01/11] qemu-img: remove unused parameter in collect_image_info()

2013-01-02 Thread Eric Blake
On 12/29/2012 01:45 AM, Wenchao Xia wrote: > Parameter *fmt was not used, so remove it. > > Signed-off-by: Wenchao Xia > --- > qemu-img.c |5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt vi

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-02 Thread Troy Benjegerdes
On Wed, Jan 02, 2013 at 05:16:03PM +0100, Beno??t Canet wrote: > This patchset is a cleanup of the previous QCOW2 deduplication rfc. > > One can compile and install https://github.com/wernerd/Skein3Fish and use the > --enable-skein-dedup configure option in order to use the faster skein HASH. > >

[Qemu-devel] [RFC V4 23/30] qcow2: Add check_dedup_l2 in order to check l2 of dedup table.

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2-refcount.c | 65 +--- 1 file changed, 56 insertions(+), 9 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 9aef608..0c6e75a 100644 --- a/block/qcow2-refcount.c +++ b/block/qco

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2013-01-02 Thread Adam Conrad
Hello Robert, or anyone else affected, Accepted qemu-kvm into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/qemu-kvm/1.0+noroms- 0ubuntu14.6 in a few hours, and then in the -proposed repository. Please help us by testing this new package. Se

[Qemu-devel] [RFC V4 02/30] qcow2: Add deduplication structures and fields.

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2.h | 57 - 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/block/qcow2.h b/block/qcow2.h index 718b52b..637c86a 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -58,6 +58,50 @@ #

[Qemu-devel] [PATCH 18/18] sheepdog: pass oid directly to send_pending_req()

2013-01-02 Thread Stefan Hajnoczi
From: Liu Yuan Cc: MORITA Kazutaka Cc: Kevin Wolf Signed-off-by: Liu Yuan Reviewed-by: MORITA Kazutaka Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index b9186fb..e821746 100644 --

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-02 Thread Benoît Canet
> How does this code handle hash collisions, and do you have some regression > tests that purposefully create a dedup hash collision, and verify that the > 'right thing' happens? The two hash function that can be used are cryptographics and not broken yet. So nobody knows how to generate a collisi

[Qemu-devel] [RFC V4 13/30] qcow2: Extract qcow2_do_table_init.

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2-refcount.c | 43 ++- block/qcow2.h |5 + 2 files changed, 35 insertions(+), 13 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index e014b0e..75c2bde 100644 --- a/bloc

Re: [Qemu-devel] [PULL 0/1] update seabios

2013-01-02 Thread Luigi Rizzo
are you going to distribute a 1.3.x snapshot with the updated bios that lets FreeBSD boot ? thanks luigi On Wed, Jan 2, 2013 at 5:57 PM, Anthony Liguori wrote: > Gerd Hoffmann writes: > > > Hi, > > > > One more seabios update, fixing the FreeBSD build failure. > > > > please pull, > > Gerd

[Qemu-devel] [PATCH 01/18] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane

2013-01-02 Thread Stefan Hajnoczi
The raw_get_aio_fd() function allows virtio-blk-data-plane to get the file descriptor of a raw image file with Linux AIO enabled. This interface is really a layering violation that can be resolved once the block layer is able to run outside the global mutex - at that point virtio-blk-data-plane wi

Re: [Qemu-devel] [PULL 0/1] update seabios

2013-01-02 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > One more seabios update, fixing the FreeBSD build failure. > > please pull, > Gerd > Pulled. Thanks. Regards, Anthony Liguori > The following changes since commit 914606d26e654d4c01bd5186f4d05e3fd445e219: > > Merge remote-tracking branch 'stefanha/trivial

Re: [Qemu-devel] [PULL] pci,virtio

2013-01-02 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > Included here is v3 virtio typesafety change - no comments > were made to v3 - I made my best to address all comment > and got no response to v3 so I assume it's OK now. > > There are more optimizations in my tree but > they are a bit more scary - I'll let them > st

Re: [Qemu-devel] [PATCH 0/2] [PULL] qemu-kvm.git uq/master queue

2013-01-02 Thread Anthony Liguori
Gleb Natapov writes: > The following changes since commit e376a788ae130454ad5e797f60cb70d0308babb6: > > Merge remote-tracking branch 'kwolf/for-anthony' into staging (2012-12-13 > 14:32:28 -0600) > > are available in the git repository at: > > > git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm

[Qemu-devel] [RFC V4 11/30] qcow2: create function to load deduplication hashes at startup.

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 68 +++ block/qcow2.h |1 + 2 files changed, 69 insertions(+) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index b998a2d..4c391e5 100644 --- a/block/qcow2-dedup.c +++ b/blo

[Qemu-devel] [RFC V4 18/30] qcow2: Behave correctly when refcount reach 0 or 2^16.

2013-01-02 Thread Benoît Canet
When refcount reach zero we destroy the hash on disk and remove it from GTree. When refcount is at it's maximum value we mark the hash so it won't be loaded at next startup and remove it from GTree. Signed-off-by: Benoit Canet --- block/qcow2-dedup.c| 79 +++

[Qemu-devel] [PATCH 07/18] iov: add iov_discard_front/back() to remove data

2013-01-02 Thread Stefan Hajnoczi
The iov_discard_front/back() functions remove data from the front or back of the vector. This is useful when peeling off header/footer structs. Signed-off-by: Stefan Hajnoczi --- include/qemu/iov.h | 13 + iov.c | 51 +++

Re: [Qemu-devel] [PATCH 6/6] usb-tablet: Allow connecting to ehci

2013-01-02 Thread Hans de Goede
Hi, On 12/30/2012 12:55 PM, Erik Rull wrote: Hi Hans, Hans de Goede wrote: Hi, On 12/26/2012 01:07 PM, Erik Rull wrote: Hi Gerd, hi Hans, is my assumption correct that if I check out and compile this version from GIT master that the usb-tablet device is automatically routed to ehci without

[Qemu-devel] [PATCH 17/18] sheepdog: don't update inode when create_and_write fails

2013-01-02 Thread Stefan Hajnoczi
From: Liu Yuan For the error case such as SD_RES_NO_SPACE, we shouldn't update the inode bitmap to avoid the scenario that the object is allocated but wasn't created at the server side. This will result in VM's IO error on the failed object. Cc: MORITA Kazutaka Cc: Kevin Wolf Signed-off-by: Li

[Qemu-devel] [PATCH 15/18] qemu-img: report size overflow error message

2013-01-02 Thread Stefan Hajnoczi
From: liguang qemu-img will complain when qcow or qcow2 size overflow for 64 bits, report the right message in this condition. $./qemu-img create -f qcow2 /tmp/foo 0x1 before change: qemu-img: Invalid image size specified! You may use k, M, G or T suffixes for qemu-img: kilobytes

Re: [Qemu-devel] [RFC V4 30/30] qemu-iotests: Filter dedup=on/off so existing tests don't break.

2013-01-02 Thread Benoît Canet
Ack. There is more than one patch to move. I'll do in for the next RFC. Regards Benoît Le Wednesday 02 Jan 2013 à 09:42:06 (-0700), Eric Blake a écrit : > On 01/02/2013 09:16 AM, Benoît Canet wrote: > > Signed-off-by: Benoit Canet > > --- > > tests/qemu-iotests/common.rc |3 ++- > > 1 fil

[Qemu-devel] [RFC V4 26/30] qcow2: Add lazy refcounts to deduplication to prevent qcow2_cache_set_dependency loops

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2.c |1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 0154d50..f66e67d 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1606,6 +1606,7 @@ static int qcow2_create(const char *filename, QEMUOptionParameter *option

[Qemu-devel] [RFC V4 24/30] qcow2: Do not overwrite existing entries with QCOW_OFLAG_COPIED.

2013-01-02 Thread Benoît Canet
In the case of a race condition between two writes a l2 entry can be written without QCOW_OFLAG_COPIED before the first write fill it. This patch simply check if the l2 entry has the correct offset without QCOW_OFLAG_COPIED and do nothing. Signed-off-by: Benoit Canet --- block/qcow2-cluster.c |

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

2013-01-02 Thread Eduardo Habkost
On Wed, Jan 02, 2013 at 05:40:58PM +0100, Igor Mammedov wrote: > On Wed, 02 Jan 2013 16:08:42 +0100 > Andreas Färber wrote: > > > Am 05.12.2012 17:49, schrieb Eduardo Habkost: > > > This finally makes the CPU class a child of DeviceState, allowing us to > > > start using DeviceState properties on

[Qemu-devel] [RFC V4 07/30] qcow2: Add qcow2_dedup_store_new_hashes.

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 315 ++- block/qcow2.h |5 + 2 files changed, 319 insertions(+), 1 deletion(-) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 5901749..2a444f5 100644 --- a/block/qcow2-d

[Qemu-devel] [RFC V4 03/30] qcow2: Add qcow2_dedup_read_missing_and_concatenate

2013-01-02 Thread Benoît Canet
This function is used to read missing data when unaligned writes are done. This function also concatenate missing data with the given qiov data in order to prepare a buffer used to look for duplicated clusters. Signed-off-by: Benoit Canet --- block/Makefile.objs |1 + block/qcow2-dedup.c |

[Qemu-devel] [RFC V4 06/30] qcow2: Add qcow2_dedup and related functions

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 436 +++ block/qcow2.h |5 + 2 files changed, 441 insertions(+) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 4e99eb1..5901749 100644 --- a/block/qcow2-dedup.c +++ b/bl

[Qemu-devel] [PATCH 03/18] dataplane: add host memory mapping code

2013-01-02 Thread Stefan Hajnoczi
The data plane thread needs to map guest physical addresses to host pointers. Normally this is done with cpu_physical_memory_map() but the function assumes the global mutex is held. The data plane thread does not touch the global mutex and therefore needs a thread-safe memory mapping mechanism.

Re: [Qemu-devel] [RFC V4 30/30] qemu-iotests: Filter dedup=on/off so existing tests don't break.

2013-01-02 Thread Eric Blake
On 01/02/2013 09:16 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > tests/qemu-iotests/common.rc |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc > index aef5f52..72e746d 100644 > --- a/tests/q

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

2013-01-02 Thread Igor Mammedov
On Wed, 02 Jan 2013 16:08:42 +0100 Andreas Färber wrote: > Am 05.12.2012 17:49, schrieb Eduardo Habkost: > > This finally makes the CPU class a child of DeviceState, allowing us to > > start using DeviceState properties on CPU subclasses. > > To avoid confusion with child<> properties and Device

[Qemu-devel] [RFC V4 08/30] qcow2: Implement qcow2_compute_cluster_hash.

2013-01-02 Thread Benoît Canet
Add detection of libgnutls used to compute SHA256 hashes Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 13 - configure | 22 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 2a4

[Qemu-devel] [RFC V4 16/30] qcow2: Extract qcow2_add_feature and qcow2_remove_feature.

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2.c | 49 ++--- block/qcow2.h |4 ++-- 2 files changed, 32 insertions(+), 21 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 499e939..ad399c8 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @

[Qemu-devel] [RFC V4 05/30] qcow2: Create a way to link to l2 tables when deduplicating.

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2-cluster.c |8 ++-- block/qcow2.h |9 + 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 56fccf9..63a7241 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-

[Qemu-devel] [RFC V4 12/30] qcow2: Load and save deduplication table header extension.

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 410d3c1..9a7177b 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -53,9 +53,16 @@ typedef struct { uint32_t len; }

[Qemu-devel] [Bug 1091766] Re: Physical host crash with Mellanox IB PCI passthrough

2013-01-02 Thread Alex Williamson
I'm currently trying to make that happen, starting with the patches in comments 2 & 3 and moving to something like the patch in comment 8 in the development branch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpa

[Qemu-devel] [RFC V4 09/30] qcow2: Extract qcow2_dedup_grow_table

2013-01-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qcow2-cluster.c | 102 +++-- block/qcow2-dedup.c |3 +- block/qcow2.h |6 +++ 3 files changed, 71 insertions(+), 40 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 6

[Qemu-devel] [PATCH 06/18] dataplane: add Linux AIO request queue

2013-01-02 Thread Stefan Hajnoczi
The IOQueue has a pool of iocb structs and a function to add new read/write requests. Multiple requests can be added before calling the submit function to actually tell the host kernel to begin I/O. This allows callers to batch requests and submit them in one go. The actual I/O is performed usin

  1   2   >