Ping 2...
r~
On 2012-12-20 11:45, Richard Henderson wrote:
> Ping? It's got reviews...
>
> r~
>
> On 12/11/2012 09:21 AM, Richard Henderson wrote:
>> Changes v2-v3:
>> Ignore softfloat "style" completely. Code now formatted per QEMU.
>>
>> Changes v1-v2:
>> Incorporating feedback from Pet
On 28 December 2012 06:38, Brad Smith wrote:
> Disable the semaphores fallback code for OpenBSD as modern OpenBSD
> releases now have sem_timedwait().
Maybe we should have a configure test for existence of sem_timedwait()
rather than os-guessing ifdeffery...
-- PMM
Reported-by: Stuart Brady
Signed-off-by: Richard Henderson
---
tcg/hppa/tcg-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/hppa/tcg-target.c b/tcg/hppa/tcg-target.c
index 5b27cf6..656e736 100644
--- a/tcg/hppa/tcg-target.c
+++ b/tcg/hppa/tcg-target.c
@@ -824,7 +
Existing compile-time detection is spotty at best. Convert
it all to runtime detection instead.
Signed-off-by: Richard Henderson
---
configure | 19 +++
tcg/i386/tcg-target.c | 31 ++-
tcg/i386/tcg-target.h | 5 -
3 files changed, 49
Ping 2. There is a Reviewed-by...
r~
On 2012-12-07 13:07, Richard Henderson wrote:
> Cc: Aurelien Jarno
> Signed-off-by: Richard Henderson
> ---
> tcg/tcg-op.h | 2 ++
> tcg/tcg.h| 3 +++
> 2 files changed, 5 insertions(+)
>
> Changes since v1:
> * Add tl-sized TCGV_IS_UNUSED to tcg-o
Instead of forcing the caller to guess what went wrong while creating
the CPU object, return error information in a Error argument.
Also, as cpu_x86_create() won't print error messages itself anymore,
change cpu_x86_init() to print any error returned by cpu_x86_create()
or cpu_x86_realize().
Sign
This uses a separate base class (TYPE_X86_PREDEF_CPU) for all the
predefined CPU models, because those classes will have a x86_def_t
struct embedded into the class struct (while TYPE_X86_HOST_CPU, for
example, doesn't have it). The code that was inside
x86_cpu_create_from_name() is now inside the i
Move the check for "host" to beginning of function, so instead of a
confusing if/else-if/else mess we now have just two obvious if/else
blocks:
1) Special case for "host";
2) General case for CPU model lookup on x86_defs list.
This way, we will be able to easily move those two parts to separate
c
While moving the code, rename the resulting function from
cpu_x86_find_by_name() to x86_cpu_create_from_name().
Note that this adds duplicate object_new() and cpudef_2_x86_cpu() calls.
This is because the "host" and predefined CPU classes will be converted
in separate steps. After both parts are c
it will help to get rid of setting default.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 64b7637..1497980 100644
---
kvm_check_features_against_host() should be called when features can't be
changed and when features are convereted to properties it would be possible to
change them until realize time, so correct way is to call
kvm_check_features_against_host() in x86_cpu_realize()
- calling kvm_check_features_ag
To keep the kvm_enabled() check for "host" working, a 'kvm_required'
field was added to X86CPUClass.
Signed-off-by: Eduardo Habkost
---
target-i386/cpu-qom.h | 1 +
target-i386/cpu.c | 32
2 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/targ
It prepares for converting "+feature,-feature,feature=foo,feature" into
a set of key,value property pairs that will be applied to CPU by
cpu_x86_set_props().
It separates legacy format parsing from property setting, later it could be
transformed into code that sets global properties for a given CP
freeing resources in one place would require setting 'error'
to not NULL, so add some more error reporting before jumping to
exit branch.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
v2:
- add missing 'return -1' on exit if error is not NULL,
Spotted-By: Eduardo
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index eb0dcc2..00cb413 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1339,7 +1339,7 @@ stat
Note that this is temporary: just like we would eventually kill usage of
x86_def_t inside cpu_x86_parse_featurestr(), we will eventually kill
usage of X86CPU inside that function as well.
This will help us keep the x86_def_t usage restricted to the CPU object
creation code.
Signed-off-by: Eduardo
On Fri, Dec 28, 2012 at 08:13:37PM +, Blue Swirl wrote:
> On Fri, Dec 28, 2012 at 6:00 AM, Brad Smith wrote:
> > As reported in bug 1087114 the semaphores fallback code is broken which
> > results in QEMU crashing and making QEMU unusable.
> >
> > This patch is from Paolo.
> >
> > This needs t
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 64f385b..cd1884d 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1296,13 +1296,7
Move the initialization to the cpu_x86_find_by_name(), inside the block
for predefined CPU models.
That code is not necessary for -cpu "host", because:
- kvm_features doesn't need to be set because kvm_cpu_fill_host()
already sets all bits supported by the host.
- the CPUID_EXT_HYPERVISOR flag
Signed-off-by: Igor Mammedov
Signed-off-by: Eduardo Habkost
---
target-i386/cpu.c | 31 ---
1 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 7be3ad8..63aae86 100644
--- a/target-i386/cpu.c
+++ b/target-i386
No functional change, a simple code movement to simplify following refactoring.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
v2:
- rebased on top of "i386: cpu: remove duplicate feature names"
http://www.mail-archive.com/qemu-devel@nongnu.org/msg129458.html
v3:
- re
Signed-off-by: Igor Mammedov
---
v2:
use qstring_append_int() for converting xlevel to string
Suggested-By: Eduardo Habkost
---
target-i386/cpu.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 02ece1e..14f434b 100644
This series is several cleanups, moved out from CPU properties series,
since they do not really depend on CPU properties re-factoring and could
simplify CPU subclasses work as well.
Series doesn't depend on cpu as device or any other series, and applies
to current master.
git tree for testing:
On Fri, Dec 28, 2012 at 09:01:30PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
> ---
> v2:
> use qstring_append_int() for converting xlevel to string
>Suggested-By: Eduardo Habkost
> ---
> target-i386/cpu.c |5 -
> 1 files changed, 4 i
On Fri, Dec 28, 2012 at 09:01:29PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
> ---
> target-i386/cpu.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 00cb413..02ece1e 10
On Fri, Dec 28, 2012 at 09:01:25PM +0100, Igor Mammedov wrote:
> Vendor property setter takes string as vendor value but cpudefs
> use uint32_t vendor[123] fields to define vendor value. It makes it
> difficult to unify and use property setter for values from cpudefs.
>
> Simplify code by using ve
On Fri, Dec 28, 2012 at 09:01:16PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> Signed-off-by: Eduardo Habkost
Reviewed-by: Eduardo Habkost
> ---
> target-i386/cpu.c | 31 ---
> 1 files changed, 16 insertions(+), 15 deletions(-)
>
> diff --git a/
when CPU properties are implemented, ext2_features may change
between object_new(CPU) and cpu_realize_fn(). Sanitizing
ext2_features for AMD based CPU at realize() time will keep
current behavior after CPU features are converted to properties.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Hab
Note that we are initializing the CPU features inside instance_init (and
not storing any CPU feature information inside the class struct) because
kvm_cpu_fill_host() needs KVM to be initialized, and we can't guarantee
that KVM will be initialized when class_init is called.
Signed-off-by: Eduardo H
This is basically a x86 CPU subclasses RFC, preceded by some changes that I
would like to include even if this particular approach to the x86 CPU subclasses
doesn't get accepted (so the first patches are marked as PATCH instead of RFC).
The main differences from the RFC sent by Andreas previously
As we will need to create the CPU object after splitting the CPU model
string (because we're going to use different subclasses for each CPU
model), move the CPU object creation to cpu_x86_register(), and at the
same time rename cpu_x86_register() to cpu_x86_create().
This will also simplify the CP
Add support for compiling for GCOV test coverage, enabled
with '--enable-gcov' during configure.
After tests, test coverage can be reported with 'make gcov'.
Signed-off-by: Blue Swirl
---
v2:
update to HEAD: report coverage for more files
improve gcov invocation and use foo-y Makefile magic fo
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 14f434b..8d3ac5e 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1320,13 +1320,7
On Fri, Dec 28, 2012 at 6:00 AM, Brad Smith wrote:
> As reported in bug 1087114 the semaphores fallback code is broken which
> results in QEMU crashing and making QEMU unusable.
>
> This patch is from Paolo.
>
> This needs to be back ported to the 1.3 stable tree as well.
Needs to be back ported
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index e20356e..8009a59 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1312,13 +1312,7
Thanks, applied.
On Fri, Dec 28, 2012 at 6:38 AM, Brad Smith wrote:
> Disable the semaphores fallback code for OpenBSD as modern OpenBSD
> releases now have sem_timedwait().
>
> Signed-off-by: Brad Smith
>
> diff --git a/include/qemu/thread-posix.h b/include/qemu/thread-posix.h
> index 380bae2..
Thanks, applied.
On Sun, Dec 23, 2012 at 9:25 PM, Alon Levy wrote:
> Broken since:
>
> commit 927d4878b0ff319ed87fed9363f314613b0a5ed9
> Author: Paolo Bonzini
> Date: Mon Dec 17 18:20:05 2012 +0100
>
> softmmu: move remaining include files to include/ subdirectories
>
> Signed-off-by: Alon
Thanks, pulled.
On Sun, Dec 23, 2012 at 12:00 AM, Andreas Färber wrote:
> Am 22.12.2012 13:08, schrieb Blue Swirl:
>> On Wed, Dec 19, 2012 at 1:36 PM, Andreas Färber wrote:
>>> Hello,
>>>
>>> This is my current QOM CPU patch queue. Please pull.
>>
>> It conflicts with HEAD, please rebase.
>
> Me
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 8009a59..64f385b 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1304,13 +1304,7
Signed-off-by: Igor Mammedov
---
target-i386/cpu.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 00cb413..02ece1e 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1335,6 +1335,8 @@ static int cpu_x86_parse_featurest
Make for() cycle reusable for the next patch
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c | 21 ++---
1 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index d93bf5a..935bc42 100644
--- a/ta
commit 8935499831312 makes cpuid return to guest host's vendor value
instead of built-in one by default if kvm_enabled() == true and allows
to override this behavior if 'vendor' is specified on -cpu command line.
But every time guest calls cpuid to get 'vendor' value, host's value is
read again an
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 8d3ac5e..e20356e 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1340,8 +1340,7 @@ sta
Vendor property setter takes string as vendor value but cpudefs
use uint32_t vendor[123] fields to define vendor value. It makes it
difficult to unify and use property setter for values from cpudefs.
Simplify code by using vendor property setter, vendor[123] fields
are converted into vendor[13] ar
No functional change, needed for simplifying conversion to properties.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 99fd3f3..e534254
since cpu_def config is not supported anymore and all remaining sources now
always set x86_def_t.vendor[123] fields remove setting default vendor to
simplify future re-factoring.
Signed-off-by: Igor Mammedov
Reviewed-by: Eduardo Habkost
---
target-i386/cpu.c | 13 -
1 files change
On Fri, 28 Dec 2012 15:39:19 -0200
Eduardo Habkost wrote:
> On Thu, Dec 27, 2012 at 03:59:26PM +0100, Igor Mammedov wrote:
> [...]
> > assert(kvm_enabled());
> >
> > x86_cpu_def->name = "host";
> > -host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx);
> > -x86_cpu_def->vendor1 = ebx;
>
Hi Paolo,
Am 28.12.2012 18:53, schrieb Paolo Bonzini:
Il 28/12/2012 08:05, Alexandre DERUMIER ha scritto:
Hi list,
After discuss with Stefan Yesterday here some more info:
(this is for stable qemu 1.3, it was working fine with qemu 1.2)
The problem seem that whesettings a migrate_set_downtime
The existing -cpu host code simply set every bit inside svm_features
(initializing it to -1), and that makes it impossible to make the
enforce/check options work properly when the user asks for SVM features
explicitly in the command-line.
So, instead of initializing svm_features to -1, use GET_SUP
When using -cpu host, we don't need to use the kvm_default_features
variable, as the user is explicitly asking QEMU to enable all feature
supported by the host.
This changes the kvm_cpu_fill_host() code to use GET_SUPPORTED_CPUID to
initialize the kvm_features field, so we get all host KVM feature
This series has two very similar fixes for feature initizliation for "-cpu
host". This should allow us to make the check/enforce code check for host
support of KVM and SVM features, later.
Eduardo Habkost (2):
target-i386: kvm: -cpu host: use GET_SUPPORTED_CPUID for SVM features
target-i386: k
On Sat, Dec 29, 2012 at 1:33 AM, Saptarshi Sen wrote:
> HI,
>
> I am using the following command for booting a CENTOS image. Although
> the system boots initially but at the
> end, it throws an error " No root Device found "
>
>qemu/qemu-system-x86_64 -m 512 -kernel vmlinuz-2.6.32-71.el6.i
On Fri, Dec 28, 2012 at 10:31 AM, Jason Wang wrote:
> This patch adds basic multiqueue support for qemu. The idea is simple, an
> array
> of NetClientStates were introduced in NICState, parse_netdev() were extended
> to
> find and match all NetClientStates belongs to the backend and place their
On Fri, Dec 28, 2012 at 10:32 AM, Jason Wang wrote:
> This patch implements both userspace and vhost support for multiple queue
> virtio-net (VIRTIO_NET_F_MQ). This is done by introducing an array of
> VirtIONetQueue to VirtIONet.
>
> Signed-off-by: Jason Wang
> ---
> hw/virtio-net.c | 318
> +
Il 28/12/2012 08:05, Alexandre DERUMIER ha scritto:
> Hi list,
> After discuss with Stefan Yesterday here some more info:
>
> (this is for stable qemu 1.3, it was working fine with qemu 1.2)
>
> The problem seem that whesettings a migrate_set_downtime to 1sec,
>
> the transfert of the vm seem to
On Thu, Dec 27, 2012 at 10:06 AM, Luigi Rizzo wrote:
> Before submitting a proper patch, I'd like to hear feedback on the
> following proposed change to hw/e1000.c to properly implement
> interrupt mitigation.
> This is joint work with Vincenzo Maffione and Giuseppe Lettieri (in Cc),
> and is a fo
On Thu, Dec 27, 2012 at 03:59:26PM +0100, Igor Mammedov wrote:
[...]
> assert(kvm_enabled());
>
> x86_cpu_def->name = "host";
> -host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx);
> -x86_cpu_def->vendor1 = ebx;
> -x86_cpu_def->vendor2 = edx;
> -x86_cpu_def->vendor3 = ecx;
> +
HI,
I am using the following command for booting a CENTOS image. Although
the system boots initially but at the
end, it throws an error " No root Device found "
qemu/qemu-system-x86_64 -m 512 -kernel vmlinuz-2.6.32-71.el6.i686
-initrd initramfs-2.6.32-71.el6.i686.img -append "root=/dev/hda
** Changed in: qemu
Assignee: (unassigned) => leeseungman (forsucess1)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/902413
Title:
qemu-i386-user on ARM host: wine hangs/spins when trying to r
This patch implements both userspace and vhost support for multiple queue
virtio-net (VIRTIO_NET_F_MQ). This is done by introducing an array of
VirtIONetQueue to VirtIONet.
Signed-off-by: Jason Wang
---
hw/virtio-net.c | 318 ++-
hw/virtio-net
To support multiqueue nic, this patch separate the nic destructor from
qemu_del_net_client() to a new helper qemu_del_nic(). The following patches
would refactor this function to support multiqueue nic.
Signed-off-by: Jason Wang
---
hw/e1000.c |2 +-
hw/eepro100.c|2 +-
Some device (such as virtio-net) needs the ability to destroy or re-order the
virtqueues, this patch adds a helper to do this.
Signed-off-by: Jason Wang
---
hw/virtio.c |9 +
hw/virtio.h |2 ++
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/hw/virtio.c b/hw/virti
This patch lets vhost support multiqueue. The idea is simple, just launching
multiple threads of vhost and let each of vhost thread processing a subset of
the virtqueues of the device.
The only thing needed is passing a virtqueue index when starting vhost device,
this is used to track the first vi
This patch adds basic multiqueue support for qemu. The idea is simple, an array
of NetClientStates were introduced in NICState, parse_netdev() were extended to
find and match all NetClientStates belongs to the backend and place their
pointers in NICConf. Then qemu_new_nic can setup a N:N mapping be
Disable multiqueue support for pre 1.4.
Signed-off-by: Jason Wang
---
hw/pc_piix.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 19e342a..0145370 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -295,6 +295,10 @@ static QEMUMachine p
Recently, linux support multiqueue tap which could let userspace call TUNSETIFF
for a signle device many times to create multiple file descriptors as
independent queues. User could also enable/disabe a specific queue through
TUNSETQUEUE.
The patch adds the generic infrastructure to create multique
Add a queue_index to VirtQueue and a helper to fetch it, this could be used by
multiqueue supported device.
Signed-off-by: Jason Wang
---
hw/virtio.c |8
hw/virtio.h |1 +
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/hw/virtio.c b/hw/virtio.c
index bc3c9c3..726
This patch add migration support for multiqueue virtio-net. The version were
bumped to 12.
Signed-off-by: Jason Wang
---
hw/virtio-net.c | 45 +++--
1 files changed, 35 insertions(+), 10 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index
To support multiqueue , the patch introduce a helper qemu_get_nic() to get the
NICState from a NetClientState. The following patches would refactor this helper
to support multiqueue.
Signed-off-by: Jason Wang
---
hw/cadence_gem.c|8
hw/dp8393x.c|6 +++---
hw/
To support multiqueue, the patch introduce a helper qemu_get_queue()
which is used to get the NetClientState of a device. The following patches would
refactor this helper to support multiqueue.
Signed-off-by: Jason Wang
---
hw/cadence_gem.c|8 +++---
hw/dp8393x.c|8 ++
To support multiqueue virtio-net, the first step is to separate the virtqueue
related fields from VirtIONet to a new structure VirtIONetQueue. The following
patches will add an array of VirtIONetQueue to VirtIONet based on this patch.
Signed-off-by: Jason Wang
---
hw/virtio-net.c | 209
Hello all:
This seires is an update of last version of multiqueue virtio-net support.
Recently, linux tap gets multiqueue support. This series implements basic
support for multiqueue tap, nic and vhost. Then use it as an infrastructure to
enable the multiqueue support for virtio-net.
Both vhost
Commit b9d03e352cb6b31a66545763f6a1e20c9abf0c2c added link
auto-negotiation emulation, it would always set link up by
callback function. Problem exists if original link status
was down, link status should not be changed in auto-negotiation.
Signed-off-by: Jason Wang
Signed-off-by: Amos Kong
---
A device reset does not affect the link state, only set_link does.
Signed-off-by: Amos Kong
---
hw/rtl8139.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index c59ec6b..3e08062 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
@@ -1258,7 +1258,8
Set link down and reboot guest, e1000 link status will be re-set
to up by auto-negotiation, it's a regression bug. rtl8139 link
status would be reset to up always.
Problems are fixed by those two patches.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=890288
Amos Kong (2):
e1000: no need au
75 matches
Mail list logo
