Re: [Qemu-devel] [PATCH V2] qemu-char: Inherit ptys and improve output from -serial pty

2012-12-20 Thread Markus Armbruster
Lei Li writes: > Changes since V1: > - Avoid crashing since qemu_opts_id() may return null on some > systems according to Markus's suggestion. Version history belongs below the "---" line. > When controlling a qemu instance from another program, it's > hard to know which serial port or mo

Re: [Qemu-devel] [PATCH] target-i386: CPUID: return highest basic leaf if eax > cpuid_xlevel

2012-12-20 Thread Markus Armbruster
Eduardo Habkost writes: > This fixes a subtle bug. A bug that probably won't cause trouble for any > existing OS, but a bug anyway: > > Intel SDM Volume 2, CPUID Instruction states: > >> Two types of information are returned: basic and extended function >> information. If a value entered for CPUI

Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Markus Armbruster
Jason Baron writes: > On Thu, Dec 20, 2012 at 08:07:02PM +, Blue Swirl wrote: >> On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: >> > From: Jason Baron [...] >> > @@ -172,9 +173,11 @@ void qtest_quit(QTestState *s) >> > unlink(s->pid_file); >> > unlink(s->socket_path); >> >

[Qemu-devel] [PATCH v3] translate-all.c: Use tb1->phys_hash_next directly in tb_remove

2012-12-20 Thread Wei-Ren Chen
When tb_remove was first commited at fd6ce8f6, there were three different calls pass different names to offsetof. In current codebase, the other two calls are replaced with tb_page_remove. There is no need to have a general tb_remove. Omit passing the third parameter and using tb1->phys_hash_next

Re: [Qemu-devel] [PATCH] vfio-pci: Add missing kvm_enabled() checks

2012-12-20 Thread Stefan Hajnoczi
On Thu, Dec 20, 2012 at 11:35 PM, Alex Williamson wrote: > On Thu, 2012-12-20 at 22:14 +0100, Stefan Hajnoczi wrote: >> It's necessary to check kvm_enabled() since a QEMU binary can be >> compiled with KVM support but TCG can be used at run-time. >> kvm_check_extension() segfaults if kvm_state is

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-20 Thread Dietmar Maurer
>If libvirt could integrate external tool using code, that would be great. > For > qemu, My understanding is just to take internal snapshot and stop vm, You just need to save VM state, flush all IO requests, then stop. After that the management framework can issue command to: * create inter

[Qemu-devel] [Bug 990364] Re: virtio_ioport_write: unexpected address 0x13 value 0x1

2012-12-20 Thread Szilárd Páll
I can't add much, except that I started noticing his issue when migrating my VMs to an Ubuntu Precise server hypervisor where under (heavy?) load my Win 2008 Server VM started to crash very frequently with the error showing up in the libvirt log of the VM. It might be useful information that I end

[Qemu-devel] [PATCH V2] qemu-char: Inherit ptys and improve output from -serial pty

2012-12-20 Thread Lei Li
Changes since V1: - Avoid crashing since qemu_opts_id() may return null on some systems according to Markus's suggestion. When controlling a qemu instance from another program, it's hard to know which serial port or monitor device is redirected to which pty. With more than one device using "

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-20 Thread Wenchao Xia
于 2012-12-21 6:19, Eric Blake 写道: On 12/17/2012 02:58 AM, Dietmar Maurer wrote: Seems this makes it impossible to use external commands to make snapshots? what command? can you tip more about the case? For example, nexenta storage provides an API to create snapshots. We want to use th

Re: [Qemu-devel] [PATCH 2/6] snapshot: add error set function

2012-12-20 Thread Wenchao Xia
于 2012-12-21 5:36, Eric Blake 写道: On 12/16/2012 11:25 PM, Wenchao Xia wrote: Added two function which will try replace the error if it is already set, so only last error is reported. +#define error_setg_replace(err, fmt, ...) do { \ +if (*err != NULL) { \ +

[Qemu-devel] [RFC] lively write vmstate with predictable size

2012-12-20 Thread Wenchao Xia
resent the mail to mail-list. --- Hi, Paolo and Juan Currently savevm needs pause vm, and I am working on that make it lively. Considering the flexibility I'd like to split out the functions apart as following: 1) snapshot lively internal/external 2) save vmstate lively int

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-20 Thread Juan Quintela
Anthony Liguori wrote: > Juan Quintela writes: > >> Hi >> >> Changes for yesterday: >> - Paolo Acked the series >> - Rebaso on top of today git (only conflicts were due to header re-shuffle) >> >> Please pull. >> >> [20121219] >> >> This is my queue for migration-thread and patches associated. T

Re: [Qemu-devel] [PATCH 10/20] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs

2012-12-20 Thread Igor Mammedov
On Thu, 20 Dec 2012 20:13:19 -0200 Eduardo Habkost wrote: > On Thu, Dec 20, 2012 at 09:22:49PM +0100, Igor Mammedov wrote: > > On Thu, 20 Dec 2012 12:10:25 -0200 > > Eduardo Habkost wrote: > > > > It's a log list of answers. please look through them all to the end. > > > On Wed, Dec 19, 2012 at

Re: [Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-20 Thread Anthony Liguori
it never takes 100ms, nothing is printed. > > Please pull. > > Thanks, Juan. > > > The following changes since commit 27dd7730582be85c7d4f680f5f71146629809c86: > > Merge remote-tracking branch 'bonzini/header-dirs' into staging (2012-12-19 > 17:15:39 -0600

Re: [Qemu-devel] [Bug 1091766] Re: Physical host crash with Mellanox IB PCI passthrough

2012-12-20 Thread Vlastimil Holer
Confirmed, third patch for legacy pci-assign enables only 4 vectors on host and guest. Mellanox IB works for me fine as well. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1091766 Title: Ph

Re: [Qemu-devel] Is mips-user broken on 64bit host?

2012-12-20 Thread Richard Henderson
On 12/18/2012 08:10 AM, Michael Tokarev wrote: > Is it just Debian, or is something really broken there? Something's broken. But it's tricky. For instance, running with -R 2G works, but -R 3G does not. Now, I'll also note for the record that 2G is the most that a mips32 userland application oug

Re: [Qemu-devel] [PATCH 19/20] block: choose the default dirty bitmap granularity in bdrv_enable_dirty_tracking

2012-12-20 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > This is useful because we want the same logic in the monitor commands > that enable the persistent dirty bitmap. > > Signed-off-by: Paolo Bonzini > --- > block-migration.c | 2 +- > block.c | 46 +--

Re: [Qemu-devel] [PATCH 18/20] mirror: add support for persistent dirty bitmap

2012-12-20 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > A persistent dirty bitmap lets mirroring proceed with no waste of work > after QEMU exits (either offline, or online when the VM restarts). > It is also useful in order to communicate to management whether the > switch to the destination was completed

Re: [Qemu-devel] [PATCH 32/34] ram: refactor ram_save_block() return value

2012-12-20 Thread Eric Blake
On 12/19/2012 05:33 AM, Juan Quintela wrote: > It could only return 0 if we only found dirty xbzrle pages that hadn't > changed (i.e. they were written with the same content). We don't care > about that case, it is the same than nothing dirty. s/than/as/ > > So now the return of the function is

Re: [Qemu-devel] [PATCH 29/34] ram: Use memory_region_test_and_clear_dirty

2012-12-20 Thread Eric Blake
On 12/19/2012 05:33 AM, Juan Quintela wrote: > This avoids having to do two walks over the dirty bitmap, once reading > the dirty bits, and anthoer cleaning them. s/anthoer/another/ -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signatur

[Qemu-devel] [3.7.0] Crash when killing qemu on e500mc

2012-12-20 Thread Ben Collins
I'm mainly posting this as a reminder that I need to investigate it and to get any ideas on where the NULL is coming from. [573785.701594] Unable to handle kernel paging request for data at address 0x [573785.709182] Faulting instruction address: 0xc016e864 [573785.714232] Oops: Kernel a

[Qemu-devel] [PATCH v7 5/8] trace: [monitor] Use new event control interface

2012-12-20 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- monitor.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index c0e32d6..cdd8fd2 100644 --- a/monitor.c +++ b/monitor.c @@ -735,10 +735,19 @@ static void do_trace_event_set_state(Monitor *mon, const QD

Re: [Qemu-devel] [PATCH 17/20] block: support a persistent dirty bitmap

2012-12-20 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block.c | 133 > +++- > block.h | 5 +++ > block_int.h | 5 +++ > 3 files changed, 141 insertions(+), 2 deletions(-) > > +void bdrv_enable_per

[Qemu-devel] [PULL 00/34] migration thread and queue

2012-12-20 Thread Juan Quintela
s since commit 27dd7730582be85c7d4f680f5f71146629809c86: Merge remote-tracking branch 'bonzini/header-dirs' into staging (2012-12-19 17:15:39 -0600) are available in the git repository at: git://repo.or.cz/qemu/quintela.git thread-20121220.next for you to fetch changes up to 9848a40427cd7662

[Qemu-devel] [PATCH v7 4/8] trace: Provide a detailed event control interface

2012-12-20 Thread Lluís Vilanova
This interface decouples event obtention from interaction. Events can be obtained through three different methods: * identifier * name * simple wildcard pattern Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 44 --- trace/control-internal.h | 60 +++ trace

[Qemu-devel] [PATCH v7 3/8] trace: Provide a generic tracing event descriptor

2012-12-20 Thread Lluís Vilanova
Uses tracetool to generate a backend-independent tracing event description (struct TraceEvent). The values for such structure are generated with the non-public "events" backend ("events-c" frontend). The generation of the defines to check if an event is statically enabled is also moved to the "ev

[Qemu-devel] [PATCH v7 7/8] trace: [simple] Port to generic event information and new control interface

2012-12-20 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/simple.py | 18 +- trace/simple.c | 33 ++--- trace/simple.h |6 +- 3 files changed, 12 insertions(+), 45 deletions(-) diff --git a/script

Re: [Qemu-devel] [PATCH v7 1/9] series: Generic event state description

2012-12-20 Thread Lluís Vilanova
Please disregard this thread and see next one (also v7). Lluis Lluís Vilanova writes: > --- > covers/generic-events | 57 > + > 1 file changed, 57 insertions(+) > create mode 100644 covers/generic-events > diff --git a/covers/generic-events

[Qemu-devel] [PATCH v7 8/8] trace: [stderr] Port to generic event information and new control interface

2012-12-20 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/stderr.py | 27 --- trace/stderr.c | 35 +++ trace/stderr.h | 11 --- 3 files changed, 15 insertions(+), 58 deletions(-) del

[Qemu-devel] [PATCH v7 6/8] trace: [default] Port to generic event information and new control interface

2012-12-20 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- trace/default.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/trace/default.c b/trace/default.c index c9b27a2..2b61224 100644 --- a/trace/default.c +++ b/trace/default.c @@ -1,7 +1,7 @@ /* * Default implementation for backend ini

[Qemu-devel] [PATCH v7 1/8] build: Use separate makefile for "trace/"

2012-12-20 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Paolo Bonzini --- .gitignore |8 ++-- Makefile| 15 +--- Makefile.objs | 64 ++-- scripts/tracetool/backend/dtrace.py |2 + scripts/tr

Re: [Qemu-devel] [PATCH] vfio-pci: Add missing kvm_enabled() checks

2012-12-20 Thread Alex Williamson
On Thu, 2012-12-20 at 22:14 +0100, Stefan Hajnoczi wrote: > It's necessary to check kvm_enabled() since a QEMU binary can be > compiled with KVM support but TCG can be used at run-time. > kvm_check_extension() segfaults if kvm_state is NULL. Ugh, this is exactly why we added kvm_irqfds_enabled() w

[Qemu-devel] [PATCH v7 2/8] trace: [tracetool] Explicitly identify public backends

2012-12-20 Thread Lluís Vilanova
Public backends are those printed by "--list-backends" and thus considered valid by the configure script. Signed-off-by: Lluís Vilanova --- scripts/tracetool.py |4 ++-- scripts/tracetool/backend/__init__.py | 16 +++- scripts/tracetool/backend/dtrace.py |

[Qemu-devel] [PATCH v7 0/8] trace: Generic event state description

2012-12-20 Thread Lluís Vilanova
Provides a generic event state description structure (TraceEvent) and a more detailed event control and query interface. This is achieved by creating a new "non-public" tracing backend (i.e., not selectable by the user at configure time) that will generate the appropriate event description informa

[Qemu-devel] [PATCH v7 2/9] build: Use separate makefile for "trace/"

2012-12-20 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova Reviewed-by: Paolo Bonzini --- .gitignore |8 ++-- Makefile| 15 +--- Makefile.objs | 64 ++-- scripts/tracetool/backend/dtrace.py |2 + scripts/tr

[Qemu-devel] [PATCH v7 1/9] series: Generic event state description

2012-12-20 Thread Lluís Vilanova
--- covers/generic-events | 57 + 1 file changed, 57 insertions(+) create mode 100644 covers/generic-events diff --git a/covers/generic-events b/covers/generic-events new file mode 100644 index 000..ab61bc5 --- /dev/null +++ b/covers/generic

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-20 Thread Eric Blake
On 12/17/2012 02:58 AM, Dietmar Maurer wrote: > Seems this makes it impossible to use external commands to make snapshots? > what command? can you tip more about the case? >>> >>> For example, nexenta storage provides an API to create snapshots. We >>> want to use that. Anothe

Re: [Qemu-devel] [PATCH] pci-assign: Enable MSIX on device to match guest

2012-12-20 Thread Alex Williamson
On Thu, 2012-12-20 at 18:38 +0200, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2012 at 09:05:50AM -0700, Alex Williamson wrote: > > When a guest enables MSIX on a device we evaluate the MSIX vector > > table, typically find no unmasked vectors and don't switch the device > > to MSIX mode. This gen

Re: [Qemu-devel] [PATCH] vfio-pci: Make host MSI-X enable track guest

2012-12-20 Thread Alex Williamson
On Thu, 2012-12-20 at 18:36 +0200, Michael S. Tsirkin wrote: > On Thu, Dec 20, 2012 at 09:06:41AM -0700, Alex Williamson wrote: > > Guests typically enable MSI-X with all of the vectors in the MSI-X > > vector table masked. Only when the vector is enabled does the vector > > get unmasked, resultin

Re: [Qemu-devel] [PATCH 10/20] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs

2012-12-20 Thread Eduardo Habkost
On Thu, Dec 20, 2012 at 09:22:49PM +0100, Igor Mammedov wrote: > On Thu, 20 Dec 2012 12:10:25 -0200 > Eduardo Habkost wrote: > > It's a log list of answers. please look through them all to the end. > > On Wed, Dec 19, 2012 at 09:18:09PM +0100, Igor Mammedov wrote: > > > On Wed, 19 Dec 2012 14:54:

[Qemu-devel] [PATCH] net: Add missing include statement (fix compiler warnings for MinGW)

2012-12-20 Thread Stefan Weil
These and some more compiler warnings were caused by a recent commit: net/tap-win32.c:724: warning: no previous prototype for ‘tap_has_ufo’ net/tap-win32.c:729: warning: no previous prototype for ‘tap_has_vnet_hdr’ ... Signed-off-by: Stefan Weil --- net/tap-win32.c |1 + 1 file changed, 1 i

Re: [Qemu-devel] [PATCH 2/6] snapshot: add error set function

2012-12-20 Thread Eric Blake
On 12/16/2012 11:25 PM, Wenchao Xia wrote: > Added two function which will try replace the error if it is > already set, so only last error is reported. > > +#define error_setg_replace(err, fmt, ...) do { \ > +if (*err != NULL) { \ > +error_free(*err); \ > +

[Qemu-devel] [PATCH] vfio-pci: Add missing kvm_enabled() checks

2012-12-20 Thread Stefan Hajnoczi
It's necessary to check kvm_enabled() since a QEMU binary can be compiled with KVM support but TCG can be used at run-time. kvm_check_extension() segfaults if kvm_state is NULL. Reported-by: Joe Terranova Signed-off-by: Stefan Hajnoczi --- hw/vfio_pci.c | 6 -- 1 file changed, 4 insertions(

[Qemu-devel] [PATCH] linux-user: correct msgrcv()

2012-12-20 Thread Laurent Vivier
All parameters must be swapped before the call of do_msgrcv(). Allow faked (debian fakeroot daemon) to work properly. WITHOUT this patch: $ faked-sysv --foreground --debug using 1723744788 as msg key msg_key=1723744788 1723744788:431 FAKEROOT: msg=131072, key=1723744788 FAKEROOT: r=-1, received

[Qemu-devel] [PATCH] linux-user: correct semctl() and shmctl()

2012-12-20 Thread Laurent Vivier
The parameter "union semun" of semctl() is not a value but a pointer to the value. Moreover, all fields of target_su must be swapped (if needed). The third argument of shmctl is a pointer. WITHOUT this patch: $ ipcs kernel not configured for shared memory qemu: uncaught target signal 11 (Segm

[Qemu-devel] [PATCH] linux-user: add string type in rtentry struct

2012-12-20 Thread Laurent Vivier
This allows to pass the device name. You can test this with the "route" command. WITHOUT this patch: $ sudo route add -net default gw 10.0.3.1 eth0 SIOCADDRT: Bad address $ netstat -nr Kernel IP routing table Destination Gateway Genmask Flags MSS Window irtt Iface 10.0.3.0

[Qemu-devel] [PATCH] linux-user: allow to use sudo in guest

2012-12-20 Thread Laurent Vivier
When qemu-linux-user is used in a linux container or chroot, if it needs to load binaries with SUID/SGID bits, it needs to have root rights to be able to change UID/GID. To do that, we need to install it with SUID bits and root owner. Then, if the SUID bit is not set on the binary to load, qemu wil

[Qemu-devel] [PATCH] linux-user: correctly align types in thunking code

2012-12-20 Thread Laurent Vivier
This is a follow up of patch: commit c2e3dee6e03527baf8698698cce76b1a3174969a Author: Laurent Vivier Date: Sun Feb 13 23:37:34 2011 +0100 linux-user: Define target alignment size In my case m68k aligns "int" on 2 not 4. You can check this with the following

[Qemu-devel] [PATCH] linux-user: convert /proc/net/route when endianess differs

2012-12-20 Thread Laurent Vivier
This patch allows to have IP addresses in correct order in the case of "netstat -nr" when the endianess of the guest differs from one of the host. For instance, an m68k guest on an x86_64 host: WITHOUT this patch: $ netstat -nr Kernel IP routing table Destination Gateway Genmask

Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Blue Swirl
On Thu, Dec 20, 2012 at 8:26 PM, Jason Baron wrote: > On Thu, Dec 20, 2012 at 08:07:02PM +, Blue Swirl wrote: >> On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: >> > From: Jason Baron >> > >> > Currently, the qtest harness can only spawn 1 qemu instance at a time >> > because >> > the p

Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Jason Baron
On Thu, Dec 20, 2012 at 08:07:02PM +, Blue Swirl wrote: > On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: > > From: Jason Baron > > > > Currently, the qtest harness can only spawn 1 qemu instance at a time > > because > > the parent pid is used to create the socket files. Use 'mkdtemp()'

Re: [Qemu-devel] [PATCH 10/20] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs

2012-12-20 Thread Igor Mammedov
On Thu, 20 Dec 2012 12:10:25 -0200 Eduardo Habkost wrote: It's a log list of answers. please look through them all to the end. > On Wed, Dec 19, 2012 at 09:18:09PM +0100, Igor Mammedov wrote: > > On Wed, 19 Dec 2012 14:54:30 -0200 > > Eduardo Habkost wrote: > > > > > On Mon, Dec 17, 2012 at 05:

Re: [Qemu-devel] [PATCH v2 3/3] qtest: add migrate-test

2012-12-20 Thread Blue Swirl
On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: > From: Jason Baron > > Tests a single 'pc' machine migration on the same host. > > Would be nice to extend the test matrix to various machine versions, but that > requires building multiple qemu binaries, which is a bit awkward in the > context

Re: [Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Blue Swirl
On Thu, Dec 20, 2012 at 5:14 PM, Jason Baron wrote: > From: Jason Baron > > Currently, the qtest harness can only spawn 1 qemu instance at a time because > the parent pid is used to create the socket files. Use 'mkdtemp()' in But mkdtemp() is not available on Win32. > combination with the paren

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2012-12-20 Thread Serge Hallyn
Verified on quantal. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1077838 Title: qemu-nbd -r -c taints device for subsequent

Re: [Qemu-devel] [PATCH 12/20 v2] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2012-12-20 Thread Eduardo Habkost
On Thu, Dec 20, 2012 at 01:16:22AM +0100, Igor Mammedov wrote: > Vendor property setter takes string as vendor value but cpudefs > use uint32_t vendor[123] fields to define vendor value. It makes it > difficult to unify and use property setter for values from cpudefs. > > Simplify code by using ve

Re: [Qemu-devel] [PATCH 11/20] target-i386: add x86cpu_vendor_words2str()

2012-12-20 Thread Eduardo Habkost
On Thu, Dec 20, 2012 at 01:16:13AM +0100, Igor Mammedov wrote: > Make for() cycle reusable for the next patch > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost > --- > target-i386/cpu.c | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v7 4/4] Add qemu-img compare documentation

2012-12-20 Thread Miroslav Rezanina
- Original Message - > From: "Eric Blake" > To: mreza...@redhat.com > Cc: qemu-devel@nongnu.org, kw...@redhat.com, pbonz...@redhat.com, > stefa...@redhat.com > Sent: Wednesday, December 19, 2012 7:15:11 PM > Subject: Re: [Qemu-devel] [PATCH v7 4/4] Add qemu-img compare documentation > >

Re: [Qemu-devel] [PATCH v3 0/2] soft-float-fixes for target-s390x

2012-12-20 Thread Richard Henderson
Ping? It's got reviews... r~ On 12/11/2012 09:21 AM, Richard Henderson wrote: > Changes v2-v3: > Ignore softfloat "style" completely. Code now formatted per QEMU. > > Changes v1-v2: > Incorporating feedback from Peter Maydell (previously missed in > the 140+ message thread). > > > r~ >

Re: [Qemu-devel] [PATCH v7 3/4] qemu-img: Add compare subcommand

2012-12-20 Thread Miroslav Rezanina
- Original Message - > From: "Eric Blake" > To: mreza...@redhat.com > Cc: qemu-devel@nongnu.org, kw...@redhat.com, pbonz...@redhat.com, > stefa...@redhat.com > Sent: Wednesday, December 19, 2012 7:12:49 PM > Subject: Re: [Qemu-devel] [PATCH v7 3/4] qemu-img: Add compare subcommand > >

Re: [Qemu-devel] [PATCH v7 2/4] qemu-img: Add "Quiet mode" option

2012-12-20 Thread Miroslav Rezanina
Hi Eric, thanks for review, reply inline. - Original Message - > From: "Eric Blake" > To: mreza...@redhat.com > Cc: qemu-devel@nongnu.org, kw...@redhat.com, pbonz...@redhat.com, > stefa...@redhat.com > Sent: Wednesday, December 19, 2012 7:06:35 PM > Subject: Re: [Qemu-devel] [PATCH v7 2/

[Qemu-devel] [PATCH] target-i386: CPUID: return highest basic leaf if eax > cpuid_xlevel

2012-12-20 Thread Eduardo Habkost
This fixes a subtle bug. A bug that probably won't cause trouble for any existing OS, but a bug anyway: Intel SDM Volume 2, CPUID Instruction states: > Two types of information are returned: basic and extended function > information. If a value entered for CPUID.EAX is higher than the maximum > i

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-20 Thread Eric Blake
On 12/19/2012 04:27 AM, Luiz Capitulino wrote: >> Libvirt has been using it when available (although reluctantly, as it >> risks hanging on an uncooperative guest); > > This has always been disabled and qemu never returns the stats info. > I believe libvirt's code is rotting just like qemu's is.

Re: [Qemu-devel] [PATCH 16/20] block: split bdrv_enable_dirty_tracking and bdrv_disable_dirty_tracking

2012-12-20 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block-migration.c | 17 +++-- > block.c | 22 +++--- > block.h | 3 ++- > block/mirror.c| 4 ++-- > 4 files changed, 18 insertions(+), 28 deletions(-) Reviewe

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2012-12-20 Thread Serge Hallyn
Verified on precise. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1077838 Title: qemu-nbd -r -c taints device for subsequent usage, even after -d Status in QEMU: In Progress Status in “qemu-kvm

Re: [Qemu-devel] [PATCH] target-mips: Fix for helpers for EXTR_* instructions

2012-12-20 Thread Jovanovic, Petar
ping http://patchwork.ozlabs.org/patch/204941/ Petar From: Petar Jovanovic [petar.jovano...@rt-rk.com] Sent: Monday, December 10, 2012 4:28 PM To: qemu-devel@nongnu.org Cc: Jovanovic, Petar; aurel...@aurel32.net Subject: [PATCH] target-mips: Fix for helper

Re: [Qemu-devel] [PATCH] target-mips: Fix incorrect reads and writes to DSPControl register

2012-12-20 Thread Jovanovic, Petar
ping: http://patchwork.ozlabs.org/patch/204306/ Petar From: Petar Jovanovic [petar.jovano...@rt-rk.com] Sent: Thursday, December 06, 2012 8:30 PM To: qemu-devel@nongnu.org Cc: Jovanovic, Petar; aurel...@aurel32.net Subject: [PATCH] target-mips: Fix incorre

[Qemu-devel] [PATCH v2 2/3] qtest: extend qtest_qmp() to fill in the reply

2012-12-20 Thread Jason Baron
From: Jason Baron Introduce: Add void qtest_qmp_resp(QTestState *s, QString *resp, const char *fmt, ...) which allows a response string to be filled in. Signed-off-by: Jason Baron --- tests/Makefile |2 +- tests/libqtest.c | 17 ++--- tests/libqtest.h | 15 +

[Qemu-devel] [PATCH v2 0/3] qtest: add migration testing

2012-12-20 Thread Jason Baron
Hi, Add a basic qtest for migration testing. Currently, it just tests a migrate of machine 'pc' on the same host. Would be nice to extend to multiple machine versions, but that requires multiple binaries, which could be done, but is perhaps a bit awkward from qtest? Testing different machine versi

[Qemu-devel] [PATCH v2 3/3] qtest: add migrate-test

2012-12-20 Thread Jason Baron
From: Jason Baron Tests a single 'pc' machine migration on the same host. Would be nice to extend the test matrix to various machine versions, but that requires building multiple qemu binaries, which is a bit awkward in the context of qtest. Testing migration between different machine versions w

[Qemu-devel] [PATCH v2 1/3] qtest: Enable creation of multiple qemu instances

2012-12-20 Thread Jason Baron
From: Jason Baron Currently, the qtest harness can only spawn 1 qemu instance at a time because the parent pid is used to create the socket files. Use 'mkdtemp()' in combination with the parent pid to avoid conflicts. Signed-off-by: Jason Baron --- tests/libqtest.c | 15 +-- 1 fi

Re: [Qemu-devel] [PATCH 08/20] target-i386: compile kvm only functions if CONFIG_KVM is defined

2012-12-20 Thread Eduardo Habkost
On Wed, Dec 19, 2012 at 06:16:08PM +0100, Igor Mammedov wrote: > On Wed, 19 Dec 2012 14:42:31 -0200 > Eduardo Habkost wrote: > > > On Mon, Dec 17, 2012 at 05:01:20PM +0100, Igor Mammedov wrote: > > [...] > > > > > > static void x86_cpuid_version_get_family(Object *obj, Visitor *v, void > > > *

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Daniel P. Berrange
On Thu, Dec 20, 2012 at 12:45:33PM +0100, Gerd Hoffmann wrote: > I doubt I manage to finish (and test!) it before xmas. > > ^ > > > >>> Okay, the QMP interface seems sane to me (from libvirt POV). However, > >>> what about other chardev

Re: [Qemu-devel] [PATCH] pci-assign: Enable MSIX on device to match guest

2012-12-20 Thread Michael S. Tsirkin
On Thu, Dec 20, 2012 at 09:05:50AM -0700, Alex Williamson wrote: > When a guest enables MSIX on a device we evaluate the MSIX vector > table, typically find no unmasked vectors and don't switch the device > to MSIX mode. This generally works fine and the device will be > switched once the guest en

Re: [Qemu-devel] [PATCH] vfio-pci: Make host MSI-X enable track guest

2012-12-20 Thread Michael S. Tsirkin
On Thu, Dec 20, 2012 at 09:06:41AM -0700, Alex Williamson wrote: > Guests typically enable MSI-X with all of the vectors in the MSI-X > vector table masked. Only when the vector is enabled does the vector > get unmasked, resulting in a vector_use callback. These two points, > enable and unmask, c

[Qemu-devel] [PATCHv2] virtio: don't waste irqfds on control vqs

2012-12-20 Thread Michael S. Tsirkin
Pass nvqs to set_guest_notifiers. This makes it possible to save on irqfds by not allocating one for the control vq for virtio-net. Signed-off-by: Michael S. Tsirkin --- Changes from v1: - fix poll implementation to not use uninitialized notifiers - verify correct API usage by checking s

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-20 Thread Scott Wood
On 12/20/2012 12:59:05 AM, Gerd Hoffmann wrote: Hi, >> Why do you need this? Any tools not picked up correctly if you don't >> set the PATH? Which ones? > > If I don't set the PATH for configure then I get this: > ERROR: "powerpc-linux-gnu-gcc" either does not exist or does not work A

[Qemu-devel] [PATCH] vfio-pci: Make host MSI-X enable track guest

2012-12-20 Thread Alex Williamson
Guests typically enable MSI-X with all of the vectors in the MSI-X vector table masked. Only when the vector is enabled does the vector get unmasked, resulting in a vector_use callback. These two points, enable and unmask, correspond to pci_enable_msix() and request_irq() for Linux guests. Some

[Qemu-devel] [PATCH] pci-assign: Enable MSIX on device to match guest

2012-12-20 Thread Alex Williamson
When a guest enables MSIX on a device we evaluate the MSIX vector table, typically find no unmasked vectors and don't switch the device to MSIX mode. This generally works fine and the device will be switched once the guest enables and therefore unmasks a vector. Unfortunately some drivers enable M

Re: [Qemu-devel] [PATCH] qemu-char: inherit ptys and imporve output from -serial pty

2012-12-20 Thread Markus Armbruster
Lei Li writes: > When controlling a qemu instance from another program, it's > hard to know which serial port or monitor device is redirected > to which pty. With more than one device using "pty" a lot of > guesswork is involved. > > $ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty -

Re: [Qemu-devel] [PATCH] qemu-char: inherit ptys and imporve output from -serial pty

2012-12-20 Thread Lei Li
Sorry, s/imporve/improve... On 12/20/2012 10:49 PM, Lei Li wrote: When controlling a qemu instance from another program, it's hard to know which serial port or monitor device is redirected to which pty. With more than one device using "pty" a lot of guesswork is involved. $ ./x86_64-softmmu/qem

Re: [Qemu-devel] [PATCH] MAkefile: dont rebuild vhost for each target

2012-12-20 Thread Michael S. Tsirkin
On Thu, Dec 20, 2012 at 03:37:58PM +0100, Paolo Bonzini wrote: > Il 20/12/2012 15:20, Michael S. Tsirkin ha scritto: > > diff --git a/hw/vhost_net_stub.c b/hw/vhost_net_stub.c > > new file mode 100644 > > index 000..387b578 > > --- /dev/null > > +++ b/hw/vhost_net_stub.c > > @@ -0,0 +1 @@ > > +

[Qemu-devel] [PATCH] qemu-char: inherit ptys and imporve output from -serial pty

2012-12-20 Thread Lei Li
When controlling a qemu instance from another program, it's hard to know which serial port or monitor device is redirected to which pty. With more than one device using "pty" a lot of guesswork is involved. $ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty -monitor pty char device redi

Re: [Qemu-devel] [PATCH] MAkefile: dont rebuild vhost for each target

2012-12-20 Thread Paolo Bonzini
Il 20/12/2012 15:20, Michael S. Tsirkin ha scritto: > diff --git a/hw/vhost_net_stub.c b/hw/vhost_net_stub.c > new file mode 100644 > index 000..387b578 > --- /dev/null > +++ b/hw/vhost_net_stub.c > @@ -0,0 +1 @@ > +#include "vhost_net.c" Nice. As a follow-up, can you perhaps split the vhost_

[Qemu-devel] [PATCH] MAkefile: dont rebuild vhost for each target

2012-12-20 Thread Michael S. Tsirkin
We rebuild vhost_net for each target, but there's no real reason to, we only have 2 variants: with and without vhost-net. Signed-off-by: Michael S. Tsirkin --- Makefile.target | 1 + hw/Makefile.objs| 5 +++-- hw/vhost_net_stub.c | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) c

Re: [Qemu-devel] [PATCH 10/20] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs

2012-12-20 Thread Eduardo Habkost
On Wed, Dec 19, 2012 at 09:18:09PM +0100, Igor Mammedov wrote: > On Wed, 19 Dec 2012 14:54:30 -0200 > Eduardo Habkost wrote: > > > On Mon, Dec 17, 2012 at 05:01:22PM +0100, Igor Mammedov wrote: > > > It prepares for converting "+feature,-feature,feature=foo,feature" into > > > a set of key,value

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Gerd Hoffmann
Hi, > /me wades through the socket code (unix+tcp) right now, which needs some > refactoring to make it fly. Sneak preview attached. Goes on top of the series. Compile tested only so far. enjoy, Gerd From 2c5568c20d97d497b43c9af1c1c1388db089c1e9 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann

Re: [Qemu-devel] [PATCH 13/20] target-i386: remove vendor_override field from CPUX86State

2012-12-20 Thread Igor Mammedov
On Thu, 20 Dec 2012 10:48:08 -0200 Eduardo Habkost wrote: > On Thu, Dec 20, 2012 at 01:16:31AM +0100, Igor Mammedov wrote: > > commit 8935499831312 makes cpuid return to guest host's vendor value > > instead of built-in one by default if kvm_enabled() == true and allows > > to override this behav

Re: [Qemu-devel] [PATCH 13/20] target-i386: remove vendor_override field from CPUX86State

2012-12-20 Thread Eduardo Habkost
On Thu, Dec 20, 2012 at 01:16:31AM +0100, Igor Mammedov wrote: > commit 8935499831312 makes cpuid return to guest host's vendor value > instead of built-in one by default if kvm_enabled() == true and allows > to override this behavior if 'vendor' is specified on -cpu command line. > > But every ti

Re: [Qemu-devel] [PATCH 11/20] target-i386: do not set vendor_override in x86_cpuid_set_vendor()

2012-12-20 Thread Eduardo Habkost
On Wed, Dec 19, 2012 at 11:47:00PM +0100, Igor Mammedov wrote: > On Wed, 19 Dec 2012 15:38:09 -0200 > Eduardo Habkost wrote: > > > On Mon, Dec 17, 2012 at 05:01:23PM +0100, Igor Mammedov wrote: > > > commit d480e1af which introduced vendor property was setting > > > env->cpuid_vendor_override = 1

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-20 Thread Peter Maydell
On 20 December 2012 00:54, Anthony Liguori wrote: > Paolo Bonzini writes: > >> Anthony, >> >> The following changes since commit a8a826a3c3b8c8a1c4def0e9e22b46e78e6163a0: >> >> exec: refactor cpu_restore_state (2012-12-16 08:35:24 +) >> >> are available in the git repository at: >> >> git

[Qemu-devel] [PATCH] virtio: don't waste irqfds on control vqs

2012-12-20 Thread Michael S. Tsirkin
Pass nvqs to set_guest_notifiers. This makes it possible to save on irqfds by not allocating one for the control vq for virtio-net. Signed-off-by: Michael S. Tsirkin --- hw/vhost.c | 10 +++--- hw/virtio-pci.c | 6 +++--- hw/virtio.h | 2 +- 3 files changed, 11 insertions(+), 7 de

Re: [Qemu-devel] [PATCH 0/2] Build fixes

2012-12-20 Thread Peter Maydell
On 20 December 2012 12:03, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Two build fixes for configurations not covered by my and Anthony's testing. > > Fixes build for me, thanks! Ditto! thanks -- PMM

Re: [Qemu-devel] [PATCH 0/2] Build fixes

2012-12-20 Thread Markus Armbruster
Paolo Bonzini writes: > Two build fixes for configurations not covered by my and Anthony's testing. Fixes build for me, thanks!

[Qemu-devel] About function "change" on monitor for 1wire iBUTTON emulator.

2012-12-20 Thread ASM
Hi folks! I wrote emulator for 1wire iBUTTON reader on RS-232 port (very specific). It uses simple circuit (see some: http://www.maximintegrated.com/app-notes/index.mvp/id/214) It works on char device (option: " -serial 1wire" for using) I have some questions: 1. How can I change options for thi

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Gerd Hoffmann
I doubt I manage to finish (and test!) it before xmas. > ^ > >>> Okay, the QMP interface seems sane to me (from libvirt POV). However, >>> what about other chardev types like pipe and vc? And I guess pty can be >>> covered by tty, right?

[Qemu-devel] [PATCH 2/2] xen: add missing include

2012-12-20 Thread Paolo Bonzini
xen-all needs to access CharDeviceState's filename field, so it needs to include char/char.h. Signed-off-by: Paolo Bonzini --- xen-all.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen-all.c b/xen-all.c index 50edaec..19bcfd1 100644 --- a/xen-all.c +++ b/xen-all.c @@ -16,6 +16,7 @@ #inc

Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

2012-12-20 Thread Paolo Bonzini
Il 20/12/2012 11:56, Daniel P. Berrange ha scritto: > On Thu, Dec 20, 2012 at 11:49:29AM +0100, Michal Privoznik wrote: >> On 19.12.2012 16:58, Gerd Hoffmann wrote: >>> Hi, >>> >>> Chardev hotplug patch series reloaded. Not finished yet, commit >>> messages not finalized yet, totally untested ot

[Qemu-devel] [PATCH 0/2] Build fixes

2012-12-20 Thread Paolo Bonzini
Two build fixes for configurations not covered by my and Anthony's testing. Paolo Paolo Bonzini (2): build: fix includes for VNC xen: add missing include Makefile.target | 5 - configure| 7 +++ ui/Makefile.objs | 1 - xen-all.c| 1 + 4 files changed, 4 insertions(+

[Qemu-devel] [PATCH 1/2] build: fix includes for VNC

2012-12-20 Thread Paolo Bonzini
vnc-tls.h is included by vnc.h, and it includes gnutls/gnutls.h. Hence, GnuTLS header files are needed by all files that include vnc.h, most notably qmp.c. Move these flags to QEMU_CFLAGS for simplicity. Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini --- Makefile.target | 5 - co

  1   2   >